1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-22 09:27:34 +08:00
Commit Graph

35957 Commits

Author SHA1 Message Date
Dean Herbert
a525b3f9f8 Reorder and rename toggle checkboxes to fit better 2022-10-13 15:44:33 +09:00
Dean Herbert
f6f5d33f53 Add slight padding to playfield (roughly matches stable) 2022-10-13 15:44:23 +09:00
Dan Balasescu
338115ff6a Move check to LegacyDifficultyControlPoint 2022-10-13 15:05:15 +09:00
Dean Herbert
ebc1088457
Merge pull request #20729 from frenzibyte/update-local-confirmation-dialog
Request user confirmation on updating locally-modified beatmaps
2022-10-13 12:36:37 +09:00
Dean Herbert
c9b4cacc20
Merge pull request #20724 from mk56-spn/Highest_Combo_Counter
Add "longest combo" counter to HUD components.
2022-10-13 12:26:49 +09:00
Dean Herbert
f573ee4521
Merge pull request #20512 from Feodor0090/comment-deletion
Add ability to delete own comments
2022-10-13 12:13:08 +09:00
Dean Herbert
e240f659c2 Refactor visibility states to read better 2022-10-13 11:22:40 +09:00
Dan Balasescu
565e5586fd
Merge pull request #20725 from peppy/fix-beatmap-skin-fallbakcs
Fix legacy fallbacks not working correctly for beatmap skins
2022-10-13 10:08:40 +09:00
Salman Ahmed
964ed01abb Add confirmation dialog for updating locally modified beatmaps 2022-10-13 02:40:15 +03:00
Salman Ahmed
4fb156ef4e Update xmlodc and add nullability attributes 2022-10-13 00:16:42 +03:00
Salman Ahmed
6199db11a2 Make OsuUserInputManager dependency nullable for tournament client 2022-10-12 17:55:32 +03:00
Salman Ahmed
7a6ecaff0d Remove default invisible cursor container from rulesets 2022-10-12 17:50:47 +03:00
Salman Ahmed
a44cfe2901 Hide menu cursor when user is idle 2022-10-12 17:50:31 +03:00
Salman Ahmed
8305d886e6 Refactor internal visibility logic to route back to PopIn/PopOut 2022-10-12 17:50:04 +03:00
Dean Herbert
19f3810020 Revert namespace change
Let's not
2022-10-12 18:50:47 +09:00
Dean Herbert
3da54814f8
Merge pull request #20641 from pfgithub/patch-fix-save-collections
Preserve collections when saving a beatmap
2022-10-12 18:36:45 +09:00
sw1tchbl4d3
df0501235d Introduce BpmMultiplierMania, remove after the fact clamps 2022-10-12 11:14:01 +02:00
Dean Herbert
8bf4ca4b53 Add legacy skin fallback when beatmap skin is providing resources 2022-10-12 17:47:20 +09:00
Dean Herbert
fd20515a6d Don't throw if LegacySkin doesn't have a transformer encapsulating it
This allows for more flexibility in lookups.
2022-10-12 17:29:17 +09:00
Dean Herbert
1c93551590 Remove completely incorrect check before applying ruleset transformer 2022-10-12 17:07:13 +09:00
Dan Balasescu
9473c350b5
Merge pull request #20266 from cdwcgt/catch-combo-hide
Fade out CatchComboDisplay when hide HUD
2022-10-12 16:59:07 +09:00
Dan Balasescu
3ac3c33cc3
Merge pull request #20712 from peppy/reduce-import-transaction-scope
Reduce the scope of realm transactions during import operations
2022-10-12 16:56:21 +09:00
Dario Headley
b72c8970eb Max Combo Counter added 2022-10-12 09:50:01 +02:00
Dan Balasescu
300888b423
Merge pull request #20720 from peppy/fix-welcome-intro-delay
Fix incorrect delay for non-theme music on "welcome" intro
2022-10-12 16:15:54 +09:00
Dean Herbert
e43c8e84b0 Use Show instead of Alpha=1 2022-10-12 15:48:42 +09:00
Dean Herbert
47fe4eb0bd Merge branch 'master' into comment-deletion 2022-10-12 15:48:26 +09:00
Dean Herbert
5ce890cdb5
Merge pull request #20568 from Susko3/update-displays-in-setting
Sync displays dropdown in settings with OS displays
2022-10-12 15:35:31 +09:00
Dean Herbert
d2d589a156 Expose HUD state via Player 2022-10-12 15:11:52 +09:00
Dean Herbert
1d6d047a69
Merge branch 'master' into master 2022-10-12 14:52:07 +09:00
Dean Herbert
d6998c810c Fix incorrect delay for non-theme music on "welcome" intro 2022-10-12 14:51:14 +09:00
Dean Herbert
db148d145b Fix incorrect offset logic for beatmaps without a preview point specified 2022-10-12 14:47:37 +09:00
Dean Herbert
721bfb5369 Rename parameter to read better 2022-10-12 14:46:35 +09:00
Dean Herbert
195ece02c6
Merge branch 'master' into update-displays-in-setting 2022-10-12 14:37:49 +09:00
Dean Herbert
ab24e87013
Merge branch 'master' into improve-drag-selection 2022-10-12 13:20:17 +09:00
Dean Herbert
b444f0fd0b
Merge pull request #20714 from frenzibyte/improve-flashlight-on-break
Improve flashlight display on break periods
2022-10-12 13:10:12 +09:00
Dean Herbert
a5948e7680
Merge pull request #20704 from ekrctb/scrolling-drag-box
Anchor editor drag box on time (catch, mania)
2022-10-12 11:48:05 +09:00
Salman Ahmed
84fdd2e107 Improve flashlight display on break periods 2022-10-11 17:16:57 +03:00
ekrctb
fcb9e2cc00 Refactor blueprint container drag code 2022-10-11 22:39:53 +09:00
Salman Ahmed
0a97ee71a9 Hide menu cursor when non-mouse input is applied 2022-10-11 16:23:51 +03:00
Salman Ahmed
60c92c8744 Enable NRT on MenuCursorContainer 2022-10-11 16:23:51 +03:00
Salman Ahmed
894127a948 Expose bindable for identifying last input source 2022-10-11 16:21:54 +03:00
Salman Ahmed
9b45a9cf76 Rename various cursor symbols
- `IProvideCursor.MenuCursor` -> `IProvideCursor.Cursor`
 - `MenuCursor` -> `MenuCursorContainer
2022-10-11 16:21:01 +03:00
Dean Herbert
390ff8b9da Reduce the scope of realm transactions during import operations 2022-10-11 21:58:28 +09:00
Dan Balasescu
cc0ca470f1
Merge pull request #20702 from peppy/update-prefer-no-video
Fix beatmap update button not respecting user "prefer no video" setting
2022-10-11 19:36:14 +09:00
Dan Balasescu
2ae41521eb
Merge pull request #20708 from peppy/mania-holding-sounds
Implement hold "sliding" samples in osu!mania
2022-10-11 17:31:44 +09:00
Dan Balasescu
88e82d3154
Merge pull request #20681 from peppy/fix-hidden-hud-interaction
Fix HUD components being interactive even when the HUD is visually hidden
2022-10-11 17:19:27 +09:00
NotGumballer91
d18466d740
Fix delay inconsistency in IntroCircles.cs 2022-10-11 16:16:57 +08:00
Dan Balasescu
6cdc9b2662
Merge pull request #20682 from peppy/fix-show-score-from-song-select
Fix clicking a leaderboard score at song select transtiioning briefly to main menu
2022-10-11 17:16:16 +09:00
NotGumballer91
5baad52a9e
Fix unintended delay on osu!theme 2022-10-11 16:15:56 +08:00
Dan Balasescu
045eb884b5
Merge pull request #20683 from peppy/storyboard-handle-backwards-events
Add support for weird storyboards which have backwards events
2022-10-11 17:12:22 +09:00
Dean Herbert
f41b79688f Avoid casting by accepting all Playfields but throwing on a bad choice 2022-10-11 16:54:41 +09:00
Dean Herbert
f060e6a780 Implement hold "sliding" samples in osu!mania 2022-10-11 16:31:37 +09:00
Dean Herbert
9bab02fab4 Remove unused using statement 2022-10-11 16:23:05 +09:00
Dean Herbert
eba3d37a11 Add xmldoc and simplify calling 2022-10-11 15:50:02 +09:00
Dean Herbert
6f6290a21a Use async flow for storing key binding changes to realm 2022-10-11 15:37:22 +09:00
Dean Herbert
a44ba579c5 Fix beatmap update button not respecting user "prefer no video" setting
Closes #20701.
2022-10-11 14:27:40 +09:00
ekrctb
6ab29a62d0 Anchor drag box on time (catch, mania)
Not done for taiko because I cannot figure out how it should work with the overlapping scroll algorithm.
2022-10-11 14:23:17 +09:00
ekrctb
1a24762f9b Improve drag box selection logic
`AllowDeselectionDuringDrag` is remove.
Instead, selected hit objects are not automatically deselected
when clock is seeked to a later time (the hit object is dead).
Update drag box selection even if mouse is not moved
(in case clock is running or scroll wheel is used).
2022-10-11 14:11:45 +09:00
Dan Balasescu
ccab04d141
Merge pull request #20645 from frenzibyte/flag-markdown
Add support for inline country flags in wiki overlay
2022-10-11 14:01:24 +09:00
Dean Herbert
cb21126623
Merge pull request #20586 from ekrctb/time-based-selection
Use hit object time for timeline drag selection instead of relying on blueprint
2022-10-11 13:20:15 +09:00
pfg
e619c9c1e6 fix style 2022-10-10 21:48:41 -04:00
pfg
de8d485305 Move 'transferCollections' to a shared location 2022-10-10 21:45:33 -04:00
NotGumballer91
a883f44ea2
Merge branch 'master' into master 2022-10-11 02:11:21 +08:00
NotGumballer91
ef840e98cf
Update IntroCircles.cs 2022-10-11 01:49:53 +08:00
NotGumballer91
8a4f2efa14
Update IntroScreen.cs 2022-10-11 01:49:49 +08:00
NotGumballer91
3cd6ce8e3f
Update WorkingBeatmap.cs 2022-10-11 01:48:55 +08:00
Dean Herbert
3d58df2b61 Merge branch 'master' into flag-markdown 2022-10-11 01:58:43 +09:00
Dean Herbert
d700040a0d Make country code parsing resilient to invalid cases 2022-10-11 01:39:53 +09:00
Dean Herbert
be5a413753 Update framework 2022-10-11 01:35:35 +09:00
Dean Herbert
5a43cb6bb2
Merge pull request #20606 from sw1tchbl4d3r/barline_generator_improvements
Barline generator improvements
2022-10-11 01:31:30 +09:00
sw1tchbl4d3
5a4196fd51 Make currentEffectPoint non-nullable 2022-10-10 15:34:29 +02:00
NotGumballer91
9a3689b6e9
Update IntroCircles.cs 2022-10-10 21:04:14 +08:00
NotGumballer91
749dc40062
Update WorkingBeatmap.cs 2022-10-10 21:03:11 +08:00
NotGumballer91
e3b405cc23
Update IWorkingBeatmap.cs 2022-10-10 21:02:23 +08:00
sw1tchbl4d3
d389808427 Make effect point search more efficient 2022-10-10 14:00:26 +02:00
Dean Herbert
28185178d6 Add support for weird storyboards which have backwards events
Closes https://github.com/ppy/osu/issues/20632.
Not adding test coverage because this is just weird.
2022-10-10 16:51:55 +09:00
sw1tchbl4d3
eae32ca483 Switch DefinitelyBigger to AlmostBigger to account for fp errors 2022-10-10 09:39:40 +02:00
sw1tchbl4d3
f8036658c7 Move clamps directly to the usages in the conversion algorithm 2022-10-10 09:36:18 +02:00
Dean Herbert
e57819d687
Merge pull request #20665 from frenzibyte/fix-smoke-blocked-on-relax
Fix smoke being blocked with "Relax" mod enabled
2022-10-10 16:36:03 +09:00
Dean Herbert
b783fdf667 Fix clicking a leaderboard score at song select transtiioning briefly to main menu
- Regressed in #20567.
- Closes #20651.
2022-10-10 16:20:18 +09:00
Dean Herbert
20adc522b9 Fix HUD components being interactive even when the HUD is visually hidden 2022-10-10 16:05:41 +09:00
Dean Herbert
26a473e85e Update resources (fixes osu!mania flashlight crash) 2022-10-10 14:24:36 +09:00
D.Headley
5d2e3dcf4a Remove leftover Enum 2022-10-09 22:52:54 +02:00
Salman Ahmed
2d4f390372 Remove non-smoke key bindings on "Relax" mod instead 2022-10-09 17:14:16 +03:00
sw1tchbl4d3
e0904e263f Fix legacy BpmMultiplier clamp value 2022-10-09 11:25:47 +02:00
Salman Ahmed
a9aba74351 Add markdown country flag support 2022-10-08 21:50:25 +03:00
Salman Ahmed
098a56a784 Add custom container extension support 2022-10-08 21:25:11 +03:00
pfg
edec613724 Remove unnecessary '?' 2022-10-08 13:58:42 -04:00
pfg
ff14453c2b Preserve collections when saving a beatmap 2022-10-08 12:42:29 -04:00
ansel
c384093802 Update main test and add failure scenario test 2022-10-08 18:53:41 +03:00
ansel
b697200460 Properly modify comment visual state on deletion 2022-10-08 18:41:08 +03:00
ansel
4e7c30504f Schedule action buttons visibility changes 2022-10-08 17:15:10 +03:00
ansel
abf56c27a1 Do not requere dialog overlay 2022-10-08 17:11:09 +03:00
sw1tchbl4d3
63ffaa6929 Respect OmitFirstBarLine effect 2022-10-07 20:38:32 +02:00
sw1tchbl4d3
903c8612c8 Move endTime to next timing point 2022-10-07 20:34:31 +02:00
Dean Herbert
072b64b8d4 Update all dependencies 2022-10-07 21:16:11 +09:00
Dan Balasescu
c18d4afdcc Merge branch 'master' into fix-leaderboard-first-place-fade 2022-10-07 19:55:16 +09:00
Dan Balasescu
0fb4ac4733
Merge pull request #20603 from peppy/bg-dim-reduce
Adjust out-of-the-box background dim back down to 70%
2022-10-07 19:40:13 +09:00
Dan Balasescu
57e4d6cc4a
Merge pull request #20562 from peppy/fix-score-submission-crash
Fix potential crash when score submission token retrival fails
2022-10-07 19:24:35 +09:00
Dean Herbert
a8742f0cc3 Adjust out-of-the-box background dim back down to 70%
It was previously bumped from 60% to 80%, but I've recently
felt that this is too high as a default, and takes away from storyboards
and video backgrounds.
2022-10-07 18:47:32 +09:00
Dean Herbert
a543222a2b Add ability to pad stage vertically 2022-10-07 15:45:35 +09:00
Dean Herbert
eea3d5adb8 Standardise column index naming and xmldoc 2022-10-07 15:24:36 +09:00
Dean Herbert
13e0a59f70 Add note about why LegacyManiaSkinConfigurationLookup exist 2022-10-07 15:24:36 +09:00
Dean Herbert
3947011baf Fix regression in legacy dual stage handling logic 2022-10-07 15:24:36 +09:00
Dan Balasescu
bce20e0a59 Merge branch 'master' into adjust-flashlight 2022-10-07 14:45:30 +09:00
Dan Balasescu
7385ef3e1b Extract combo scale to virtual function 2022-10-07 14:26:19 +09:00
Joseph Madamba
b27e70ca47 Fix language settings dropdown not updating when changing language in first run setup 2022-10-06 21:11:00 -07:00
ekrctb
6164e0896a Don't reselect already selected items in SelectAll 2022-10-07 10:46:07 +09:00
Dean Herbert
4980e53c9c
Merge pull request #20376 from goodtrailer/smoke
Add cursor "smoke" trails
2022-10-07 03:41:07 +09:00
ekrctb
9247ff3e0a Allow changing scrolling speed in catch editor
Scroll speed is not saved and doesn't affect gameplay.
It is purely a feature for a better visualization.
It is currently bind to scroll speed increase/decrease.
Default F3/F4 crashes with editor shortcuts so it has to be changed.
2022-10-06 18:06:16 +09:00
ekrctb
29cc554632 Ensure blueprint is added for selected hit object 2022-10-06 13:59:54 +09:00
ekrctb
0d448e6cc8 Fix items without blueprints are not deselected 2022-10-06 13:50:56 +09:00
Dean Herbert
e9ab465da6
Merge branch 'master' into localisation-settings 2022-10-06 13:22:08 +09:00
ekrctb
b0213c29e9 Use mid time instead of start time
It is closer to the old blueprint-based behavior
2022-10-05 22:19:22 +09:00
ekrctb
6753f6b01a Move AllowDeselectionDuringDrag down
Because it is now ignored in the timeline implementation anyways
2022-10-05 22:14:11 +09:00
ekrctb
3108c42ece Fix inspect issues 2022-10-05 22:04:43 +09:00
ekrctb
00b3d97f69 Improve timeline selection performance
But selecting a large number of hit objects is still very slow
because all DHOs must be added
and also `AddBlueprintFor` has quadratic behaviors
2022-10-05 21:58:05 +09:00
ekrctb
0613388aaa Make sure all selected items get deleted 2022-10-05 21:58:05 +09:00
ekrctb
0ffde02f79 Use hit object time for timeline selection 2022-10-05 21:51:01 +09:00
ekrctb
8d29e9e76b Move selection logic from DragBox to BlueprintContainer 2022-10-05 21:51:01 +09:00
Dan Balasescu
35d04fe33c
Merge pull request #20582 from peppy/fix-being-playing-unobserved
Silence unobserved exceptions in `BeginPlayingInternal`
2022-10-05 20:51:55 +09:00
Dan Balasescu
c52ddb0e50
Merge pull request #20570 from ekrctb/scrolling-lifetime
Compute lifetime start from entry for scrolling hit objects
2022-10-05 20:45:43 +09:00
Dean Herbert
365a78d358 Merge branch 'master' into smoke 2022-10-05 18:58:18 +09:00
Dean Herbert
64858cfb8e Update resources 2022-10-05 18:55:49 +09:00
Dean Herbert
4f084664ac Merge branch 'master' into comment-deletion 2022-10-05 14:34:50 +09:00
Dean Herbert
74db42394a Silence unobserved exceptions in BeginPlayingInternal
Closes #20526.
2022-10-05 14:31:13 +09:00
Dean Herbert
276021dd85 Remove now unnecessary ScheduleAfterChildren 2022-10-05 14:20:01 +09:00
Dean Herbert
e06ece7531 Update framework 2022-10-05 14:19:51 +09:00
Dean Herbert
c7d645b086 Merge branch 'master' into fix-gameplay-leaderboard-overlap 2022-10-05 14:15:50 +09:00
Dan Balasescu
d9c3f5834c
Merge pull request #20567 from peppy/fix-show-replay-crash
Fix potential crash when attempting to display an imported score at song select
2022-10-04 19:46:15 +09:00
Dean Herbert
75b9bf2cf9
Merge branch 'master' into intel-exclusive-warning 2022-10-04 19:02:01 +09:00
Dan Balasescu
7293ad751e Update packages 2022-10-04 18:59:35 +09:00
Dan Balasescu
41082ab928 Fix misplaced parenthesis 2022-10-04 18:21:29 +09:00
ekrctb
1cccd03480 Fix scrolling nested hit object lifetime not set 2022-10-04 15:17:14 +09:00
ekrctb
781f5420b0 Add test for scrolling hit object lifetime 2022-10-04 15:17:11 +09:00
ekrctb
5d80950eaf Compute lifetime from entry in scrolling container 2022-10-04 15:12:28 +09:00
Susko3
efc9bed4f0 Use IWindow.DisplaysChanged to update displays 2022-10-03 23:52:04 +02:00
Susko3
31fefc1ee2 Add nullable annotation to LayoutSettings 2022-10-03 23:23:02 +02:00
Susko3
e98b4b4fbd Make updateDisplayModeDropdowns regular method 2022-10-03 23:14:21 +02:00
Dean Herbert
0bac5ef465 Merge branch 'master' into smoke 2022-10-03 21:29:42 +09:00
Dean Herbert
dfb143ec0b Update resources 2022-10-03 21:14:57 +09:00
Dean Herbert
332d63b53b Always return to main menu before attempting to present a score from import 2022-10-03 20:29:44 +09:00
Dean Herbert
13ee5c179e Add missing parenthesis in log message 2022-10-03 18:42:40 +09:00
Dan Balasescu
deae7cff60 Adjust flashliht scaling to match classic 2022-10-03 18:38:29 +09:00
Dan Balasescu
0df217d85c Add ability to adjust flashlight smoothness 2022-10-03 18:24:56 +09:00
Dean Herbert
d9f678d942 Change song select random key binding to not handle key repeat 2022-10-03 18:16:54 +09:00
Dean Herbert
42aac16b37 Adjust leaderboard score panels sizing based on accuracy/combo width 2022-10-03 18:12:36 +09:00
Dean Herbert
65369e96eb Ensure token retrieval failure logic only runs once 2022-10-03 17:29:46 +09:00
Dean Herbert
c4dd23ed15 Log token retrieval failures even when gameplay is allowed to continue 2022-10-03 17:29:34 +09:00
Dean Herbert
4dbac917fc
Merge pull request #20547 from nanashi-1/solo-gameplay-leaderboard-max-combo
Display highest combo rather than current combo for local play on leaderboard
2022-10-03 16:57:05 +09:00
Salman Ahmed
a810afafb3 Reschedule results display delegate to avoid potential softlocks in the future 2022-10-02 15:37:56 +03:00
Salman Ahmed
59728b0ccb Fix results display delegate potentially cancelled while not exiting 2022-10-02 15:30:06 +03:00
nanashi-1
2493468800 display highest combo instead of current combo 2022-10-02 18:40:31 +08:00
ansel
85adfc2df7 Fix DI type 2022-09-28 18:26:36 +03:00
ansel
7645fe20f5 Merge branch 'master' into comment-deletion 2022-09-28 17:55:22 +03:00
ansel
636befb499 Add visual feedback for deleting process 2022-09-28 17:49:37 +03:00
Dan Balasescu
f318452510
Merge pull request #20503 from peppy/change-default-skin
Change default skin for new installations to "Argon"
2022-09-28 18:34:40 +09:00
Dean Herbert
4ee435507d Update framework 2022-09-28 17:58:47 +09:00
Dean Herbert
cbbca616c1 Merge branch 'master' into fix-leaderboard-first-place-fade 2022-09-28 17:58:45 +09:00
Dan Balasescu
1890a66b28
Merge pull request #20509 from o-dasher/cleanup-setting-sources
Removes unnecessary setting sources specifications
2022-09-28 17:55:42 +09:00
Dan Balasescu
cbed268ac9
Merge pull request #20510 from sw1tchbl4d3r/high_bpm_judgements
Clamp `LifetimeStart` of `HitObject`s to their judgement windows
2022-09-28 17:49:35 +09:00
Dean Herbert
baa9e0441f
Merge pull request #20428 from frenzibyte/fix-update-progress-notification
Fix update progress notification not closing on completion
2022-09-28 17:43:45 +09:00
Dean Herbert
9b3778f226
Merge pull request #20507 from smoogipoo/fix-multiplayer-tests
Fix failing multiplayer tests
2022-09-28 17:41:55 +09:00
Dan Balasescu
715b1f64f3
Merge pull request #20518 from peppy/fix-leaderboard-wobble
Fix leaderboard wobble when in first place
2022-09-28 17:03:31 +09:00
Dean Herbert
cdcc8494c9 Fix fade being applied for too long when leaderboard scrolls to start 2022-09-28 16:10:19 +09:00
Dean Herbert
c8643ed265 Set ClampExtension to zero to stop jittering 2022-09-28 15:58:00 +09:00
Dean Herbert
8edb1cb98a Add test coverage of current score staying on screen 2022-09-28 15:57:50 +09:00
ansel
ae0d62838b Move API and DO to fields 2022-09-27 22:46:23 +03:00
ansel
58d9509ce6 Apply NRT to Comment 2022-09-27 22:45:05 +03:00
ansel
5282c8b8c6 Fix CQ 2022-09-27 19:40:18 +03:00
ansel
5da7cb5397 Make comment ID public for test 2022-09-27 19:02:18 +03:00
ansel
60ee813e45 Implement delete button 2022-09-27 18:33:16 +03:00
ansel
31a7ba3f91 Add delete button 2022-09-27 18:23:15 +03:00
sw1tchbl4d3
0cffbb7562 Clamp LifetimeStart of HitObject's to their judgement windows 2022-09-27 16:54:24 +02:00
o-dasher
f3e25eacad Removes unnecessary setting sources specifications 2022-09-27 09:25:58 -04:00
ansel
1721b8e47a Add request class 2022-09-27 16:25:26 +03:00
Dan Balasescu
a0d05f5bb7
Merge pull request #20501 from peppy/fix-editor-initial-performance
Fix editor performance being sub-par on beatmap load
2022-09-27 21:34:04 +09:00
Dan Balasescu
1811647e34 Make room requests handler handle GetBeatmapRequest 2022-09-27 20:30:41 +09:00
Dan Balasescu
da8d94c4b4 Fix test failures due to scheduled operations 2022-09-27 20:24:44 +09:00
Dean Herbert
58217b6839 Fix weird conditional 2022-09-27 20:09:21 +09:00
Dan Balasescu
8642ed7631
Merge pull request #20504 from peppy/fix-playlist-connectivity-crash
Fix potential crash when losing network connectivity in multiplayer/playlists screens
2022-09-27 18:36:24 +09:00
Dan Balasescu
ec30050f2c
Merge pull request #20502 from peppy/forward-toasts-on-gameplay
Flush toast tray on entering gameplay
2022-09-27 18:35:54 +09:00
Dan Balasescu
5a28174448
Merge pull request #20488 from nanashi-1/toggle-score-overlay
Add toggle for solo gameplay leaderboard
2022-09-27 18:09:55 +09:00
Dean Herbert
3ece7205ed Fix potential crash when losing network connectivity at online play screen
Addresses #20448.
2022-09-27 17:52:34 +09:00
Dean Herbert
8b722f8817 Change default skin for new installations to "Argon"
Closes #20459.
2022-09-27 17:41:56 +09:00
Dean Herbert
461ba64bfa Flush toast tray on entering a no-notification section 2022-09-27 17:32:53 +09:00
Dean Herbert
c61f5403ab Increase delay back slightly on notifications posting after disabled period 2022-09-27 17:32:30 +09:00
Dean Herbert
0296685c74 Start key counter / gameplay leaderboard hidden to avoid initial fade out 2022-09-27 17:25:24 +09:00
Dean Herbert
a9088d9231 Add assert/log output when too many ticks are being displayed 2022-09-27 17:18:46 +09:00
Dean Herbert
e227519b09 Don't attempt to render timeline ticks until DrawWidth is above zero 2022-09-27 17:18:46 +09:00
Dean Herbert
ccae721af2 Ensure ZoomableScrollContainer content isn't shown until zoom is set 2022-09-27 17:07:11 +09:00
Dean Herbert
9dc0eb7fd0 Remove unused static 2022-09-27 17:04:56 +09:00
Dean Herbert
320f134634 Use same logic as KeyCounterDisplay 2022-09-27 15:01:18 +09:00
Dean Herbert
bac3108aea Remove unnecessary keywords 2022-09-27 14:29:59 +09:00
Dan Balasescu
aa3956cfbb
Merge pull request #20495 from Feodor0090/playlist-overflow-fix
Fix playlist overlay overflowing at high UI scales
2022-09-27 13:53:14 +09:00
Dean Herbert
de6709d12c Fix rank_history serialisation order dependence
```csharp
[network] 2022-09-26 18:18:39 [verbose]: Processing response from https://dev.ppy.sh/api/v2/me/ failed with Newtonsoft.Json.JsonSerializationException: Error setting value to 'rankHistory' on 'osu.Game.Online.API.Requests.Responses.APIUser'.
[network] 2022-09-26 18:18:39 [verbose]: ---> System.NullReferenceException: Object reference not set to an instance of an object.
[network] 2022-09-26 18:18:39 [verbose]: at osu.Game.Online.API.Requests.Responses.APIUser.set_rankHistory(APIRankHistory
value) in /tmp/osu/osu.Game/Online/API/Requests/Responses/APIUser.cs:line 231
```
2022-09-27 12:46:17 +09:00
Salman Ahmed
8aff856c79 Fix SkinnableTestScene sizing logic potentially failing to work 2022-09-27 05:18:17 +03:00
nanashi-1
5d18001d75 move config 2022-09-26 21:11:38 +08:00
nanashi-1
4295d9c169 revert 2022-09-26 21:11:14 +08:00
nanashi-1
ee4d1b2d58 add config visibility 2022-09-26 20:13:07 +08:00
nanashi-1
dc051a8b79 add gameplay leaderboard config 2022-09-26 20:08:58 +08:00
nanashi-1
bed25ff60e add gameplay leaderboard config string 2022-09-26 20:08:26 +08:00
nanashi-1
f81107eb5a add gameplay leaderboard config 2022-09-26 20:07:43 +08:00
Dan Balasescu
836da6a5e6
Merge pull request #20485 from peppy/leaderboard-nrt
Apply NRT to leaderboard hierarchy
2022-09-26 18:53:37 +09:00
Dan Balasescu
e5894ccd6f
Merge pull request #20478 from peppy/fix-progress-notification-fling
Fix progress notifications being able to be flung (and cancelled)
2022-09-26 18:21:12 +09:00
Dan Balasescu
f2eed881bd
Merge pull request #20480 from peppy/fix-drawable-mutation-tablet-settings
Fix potential crash from incorrect drawable mutation in tablet settings display
2022-09-26 18:16:52 +09:00
Dan Balasescu
525de8c140
Merge pull request #20479 from peppy/fix-drawable-mutation-misc
Fix potential crash on game exit due to incorrect scheduling of realm change handler
2022-09-26 18:02:28 +09:00
Dan Balasescu
987294f294
Merge pull request #20483 from peppy/music-controller-thread-safety
Move `MusicController` binds to `LoadComplete` for added thread safety
2022-09-26 17:59:02 +09:00
Dan Balasescu
c969afcb71
Merge branch 'master' into leaderboard-nrt 2022-09-26 17:12:19 +09:00
Dan Balasescu
28470bd5c0
Merge pull request #20486 from peppy/gameplay-leaderboard-nrt
Apply NRT to `GameplayLeaderboard` hierarchy
2022-09-26 17:11:51 +09:00
Dan Balasescu
426ab176d6
Merge pull request #20418 from peppy/fix-leaderboard-crash
Fix intermittent leaderboard crash due to request finishing after drawable is disposed
2022-09-26 17:10:32 +09:00
Dean Herbert
20da1051d9 Apply NRT to GameplayLeaderboard hierarchy
Just some cleanup work that I wanted to do as part of my last changes.
2022-09-26 16:21:24 +09:00
Dean Herbert
5fc836d1f0 Apply NRT to BeatmapLeaderboard / MatchLeaderboard 2022-09-26 16:17:28 +09:00
Dean Herbert
a1297af441 Apply NRT to base Leaderboard classes 2022-09-26 16:12:47 +09:00
Dean Herbert
32d56fe3a9 Use request cancellation and IsDisposed guard instead of more Schedule 2022-09-26 16:02:33 +09:00
Dean Herbert
4e9b25d8b0 Move MusicController binds to LoadComplete for added thread safety 2022-09-26 15:42:37 +09:00
Dean Herbert
43c16cb613 Fix potential crash from incorrect drawable mutation in tablet settings display 2022-09-26 15:10:02 +09:00
Dean Herbert
c4887269f7 Avoid performing a realm write if there are no changes pending in RulesetConfigManager 2022-09-26 14:55:23 +09:00
Dean Herbert
4bd96108c0 Fix crash on game exit due to incorrect scheduling of realm change handler 2022-09-26 14:45:17 +09:00
Dean Herbert
b6dd8168d2 Fix progress notifications being able to be flung 2022-09-26 14:33:12 +09:00
o-dasher
feadac1f79 Cleanup all other leftover binding instantiation 2022-09-25 16:02:40 -04:00
o-dasher
537796c3a1 Cleanup mod bindings 2022-09-25 15:49:22 -04:00
ansel
5d0b2d34c9 Make playlist to always be in screen bounds 2022-09-24 23:35:06 +03:00
ansel
6c8e587344 Move margin value to constant 2022-09-24 21:52:16 +03:00
Salman Ahmed
ddbbd594c6
Merge branch 'master' into fix-main-menu-storyboard-crash 2022-09-23 18:56:17 +03:00
Salman Ahmed
835cae3087 Remove null conditional 2022-09-23 17:06:55 +03:00
Salman Ahmed
cdc3afac88 Fix update progress notification not closing on completion 2022-09-23 16:30:07 +03:00
Dean Herbert
0fa5e1b28e Fix intermittent leaderboard crash due to request finishing after drawable is disposed 2022-09-23 20:18:44 +09:00
Dean Herbert
4e9053b099 Fix crash when storyboard attempts to play at main menu 2022-09-23 20:10:57 +09:00
Dean Herbert
a65a76f7de Fix off-thread drawable mutation in multiplayer settings overlay when an error occurs
Closes #20413.
2022-09-23 20:05:32 +09:00
Dean Herbert
8a7526aaa3
Merge pull request #20344 from frenzibyte/better-tablet-notifications
Improve tablet error/warning notifications messaging
2022-09-22 22:45:27 +09:00
Dan Balasescu
61a41d9533
Merge pull request #20402 from peppy/argon-combo-colours
Add argon combo colours
2022-09-22 21:33:20 +09:00
Dan Balasescu
1d1012e196
Merge pull request #20286 from peppy/gameplay-leaderboards
Add basic gameplay leaderboard display
2022-09-22 21:16:12 +09:00
Dan Balasescu
6a0047b7a2 Update location of FullscreenCapability bindable 2022-09-22 21:01:23 +09:00
Dan Balasescu
445e026a32
Merge pull request #20389 from peppy/fix-gameplay-leaderboard-layout
Fix gameplay leaderboard sometimes not showing up
2022-09-22 20:51:54 +09:00
Dean Herbert
37e2579244 Fix reversed checks 2022-09-22 20:35:26 +09:00
Dan Balasescu
5dbe73ad0e
Merge pull request #20398 from peppy/fix-missing-notelock-shake
Fix "note lock" shake not always animating
2022-09-22 20:07:38 +09:00
Dan Balasescu
7508592789 Clean up some checks 2022-09-22 19:56:24 +09:00
Dean Herbert
8f7a306d81 Inline comment regarding margin necessity 2022-09-22 19:53:16 +09:00
Dean Herbert
5243ff3c22 Add argon combo colours
I'm 99% sure these are just test colours flyte was using, but they look good
so let's go with them. I've added two new colours to increase the default
combo colour rotation to 6. The initial ordering still matches, for whatever
that's worth.
2022-09-22 19:49:32 +09:00
Salman Ahmed
fd92bcdff2
Ignore case sensitivity during message comparison
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2022-09-22 13:21:27 +03:00
Salman Ahmed
794a131954 Update method name and conditions 2022-09-22 13:17:01 +03:00
Dean Herbert
74aefdc5bd Move basic transformer behaviour to base abstract class 2022-09-22 18:53:43 +09:00
Dean Herbert
ea7c5458fe Fix sprite dropdown not showing resources from non-legacy skins during gameplay 2022-09-22 18:53:43 +09:00
Salman Ahmed
fa3f53f39f Remove tablet prefix from error notification 2022-09-22 12:37:24 +03:00
Dean Herbert
b321afc3a6 Update framework 2022-09-22 18:04:31 +09:00
Dean Herbert
2bc6b4e84f
Merge branch 'master' into Colour_hit_meter_improved 2022-09-22 15:52:06 +09:00
Dean Herbert
f0dcda9acc Decrease precision of spacing setting 2022-09-22 15:49:02 +09:00
Dean Herbert
26d98323ff Fix bindable flow, code quality, everything 2022-09-22 15:45:23 +09:00
Dean Herbert
0f663deda0 Fix changing shape causing alpha to be permanently reset to zero 2022-09-22 15:24:57 +09:00