1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 10:12:54 +08:00
Commit Graph

56639 Commits

Author SHA1 Message Date
Dean Herbert
56ef519cc2 Move PopoverContainer into OnlineOverlay to ensure correct colours 2022-11-03 15:43:06 +09:00
Dean Herbert
e6c45b8ab5 Merge branch 'master' into comment-report 2022-11-03 15:35:42 +09:00
Dean Herbert
94a34071f5
Merge pull request #21094 from smoogipoo/fix-velocity-test
Fix velocity test failing with no audio device
2022-11-03 15:18:49 +09:00
Dan Balasescu
0aa8dfe11c
Merge pull request #21092 from peppy/increase-tourney-max-seed
Increase the maximum seed range for tournament client
2022-11-03 14:21:17 +09:00
Dan Balasescu
fc191807c6 Fix velocity test failing with no audio device 2022-11-03 13:59:22 +09:00
Dean Herbert
ec4ac77f14 Increase the maximum seed range for tournament client 2022-11-03 13:27:54 +09:00
Dan Balasescu
92dc3a3c02
Merge pull request #21074 from peppy/taiko-clean-up
Clean up taiko classes in preparation for new skin implementation
2022-11-03 12:38:59 +09:00
Dan Balasescu
993439d30b Fix missed nullability 2022-11-03 11:28:39 +09:00
Dean Herbert
bfa5d41d89 Fix one more case 2022-11-02 17:39:45 +09:00
Dan Balasescu
5dfaf27722 A bit more cleanup 2022-11-02 17:23:45 +09:00
Dean Herbert
bc3382f373 Apply NRT to many taiko classes 2022-11-02 17:15:25 +09:00
Dean Herbert
910dd3ad01 Move more default classes to correct namespace 2022-11-02 17:15:25 +09:00
Dean Herbert
2407eb063d Simplify Circle usage in default CentreHitCirclePiece 2022-11-02 17:15:25 +09:00
Dean Herbert
9c758e5425 Move DefaultInputDrum to correct location 2022-11-02 17:15:25 +09:00
Dean Herbert
0689d3845f Fix TestSceneHitExplosion not maintaining aspect ratio 2022-11-02 17:15:25 +09:00
Dean Herbert
c66064872a Fix DrawableHit test scene not showing rim hits correctly 2022-11-02 17:15:25 +09:00
Dan Balasescu
cb51fc7384
Merge pull request #21071 from peppy/fix-multiple-import-notifications
Fix multiple notifications arriving for imports in edge cases
2022-11-02 16:54:56 +09:00
Dan Balasescu
db34f238c0 Fix inverted condition 2022-11-02 15:47:30 +09:00
Dan Balasescu
e5f53b1ad8 Use Interlocked.Exhange() instead
Increment isn't correct since it returns the post-incremented value. It
also always increments.
2022-11-02 15:18:48 +09:00
Dan Balasescu
22f662a076
Merge pull request #21070 from peppy/standardise-visual-settings-ui-components
Standardise "Visual Settings" components to fix mismatched paddings and labels
2022-11-02 14:53:00 +09:00
Dean Herbert
e761c0395d Fix multiple notifications arriving for imports in edge cases 2022-11-02 14:47:56 +09:00
Dean Herbert
4dabb1aa9c
Merge pull request #20990 from smoogipoo/socket-client
Generalise `HubClientConnector` into `SocketClientConnector`
2022-11-02 14:17:36 +09:00
Dean Herbert
37300ba9e2 Standardise "Visual Settings" components to fix mismatched paddings and labels 2022-11-02 14:01:57 +09:00
Dan Balasescu
30800c9252 Add/adjust xmldocs 2022-11-02 13:16:34 +09:00
Dan Balasescu
e59c8b7d24 Use IDisposable instead 2022-11-02 11:49:04 +09:00
Dan Balasescu
c9108ce41b Rename StartAsync -> ConnectAsync 2022-11-02 11:44:16 +09:00
Dan Balasescu
46d1713e28 Rename Socket* -> PersistentEndpoint* 2022-11-02 11:43:22 +09:00
Bartłomiej Dach
f1138f51f3
Merge pull request #21051 from peppy/fix-directory-selector-breadcrumb
Fix breadcrumb display in directory selector overlapping new "show hidden" button
2022-11-01 15:00:21 +01:00
Dean Herbert
9f031b55a1 Merge branch 'master' into fix-directory-selector-breadcrumb 2022-11-01 22:28:13 +09:00
Dean Herbert
e104242864 Update framework 2022-11-01 22:28:06 +09:00
Bartłomiej Dach
3f48aff09b
Merge pull request #21049 from peppy/fix-slider-sv-snap
Fix time snap of sliders not matching when SV is not 1.0x
2022-11-01 13:57:14 +01:00
Bartłomiej Dach
ac554c644d
Merge branch 'master' into fix-slider-sv-snap 2022-11-01 13:19:46 +01:00
Dan Balasescu
5621db8a2e
Merge pull request #21052 from peppy/fix-control-point-info
Fix control points not being cloned when running beatmap conversion
2022-11-01 21:04:49 +09:00
Dan Balasescu
e4fb9119b3
Merge pull request #21060 from peppy/rename-target-practice
Rename mod "Target" to "Target Practice"
2022-11-01 20:38:15 +09:00
Dan Balasescu
3fa529c27a
Merge pull request #21059 from peppy/fix-combo-colour-application
Fix `DrawableHitObject.AccentColour` not being updated if object entry is not attached
2022-11-01 20:21:17 +09:00
Dan Balasescu
947e6d41c0
Merge pull request #21056 from peppy/fix-argon-explosion-size
Fix argon hit circle outer gradient getting smaller each state application
2022-11-01 20:03:22 +09:00
Dan Balasescu
fcf0ad2b99
Merge pull request #21057 from peppy/fix-accent-colour-change-performance-osu-argon
Fix large transform retention when adjusting accent colour of hitobject during pause
2022-11-01 20:00:48 +09:00
Dean Herbert
cd8dc9b17b Rename "Target" to "Target Practice" 2022-11-01 19:47:20 +09:00
Dean Herbert
f014acfc8d Fix DrawableHitObject.AccentColour not being updated if object entry is not attached 2022-11-01 19:34:53 +09:00
Dean Herbert
ff60eebe21 Fix large transform retention when adjusting accent colour of hitobject during pause 2022-11-01 19:12:59 +09:00
Dean Herbert
c179f0bb52 Fix argon hit circle outer gradient getting smaller each state application 2022-11-01 18:31:30 +09:00
Dean Herbert
ddb3d8326e
Merge pull request #21054 from smoogipoo/adjust-mod-multipliers
Adjust target and hold off mod multipliers
2022-11-01 18:12:56 +09:00
Dan Balasescu
37407293aa Adjust target and hold off mod multipliers 2022-11-01 17:57:20 +09:00
Dean Herbert
978d15955c Fix control points not being cloned when running beatmap conversion
Closes #20994.

I haven't considered how this affects performance of difficulty
calculation or otherwise. Seems like a sane initial fix which we can
iterate on going forward.

I've tested using the scenario in the linked issue.

I'm not going to add test coverage because
[BeatmapConversionTest](https://github.com/ppy/osu/blob/master/osu.Game/Tests/Beatmaps/BeatmapConversionTest.cs)
should correctly cover this scenario once we are serialising control
points as well.
2022-11-01 17:42:09 +09:00
Dean Herbert
17b435db35
Merge pull request #21050 from peppy/fix-safe-area-initial-state
Fix notch toggle not applying correctly after restart
2022-11-01 17:20:17 +09:00
Dean Herbert
29bc653d24 Remove incorrect double multiplication and add missing test coverage 2022-11-01 17:17:54 +09:00
Dean Herbert
d15585153d Fix breadcrumb display in directory selector overlapping new "show hidden" button
Closes #21034.
2022-11-01 17:07:59 +09:00
Dean Herbert
8280605e92 Fix notch toggle not applying correctly after restart 2022-11-01 16:31:09 +09:00
Dean Herbert
d807d9d822 Add failing test covering snap calculations with SV applied 2022-11-01 16:22:48 +09:00
Dean Herbert
e8b7914295 Add test coverage of new parameter 2022-11-01 15:13:05 +09:00