Dean Herbert
209d217024
Remove unused using statement
2021-06-10 12:37:56 +09:00
Gagah Pangeran Rosfatiputra
05cb935a94
change WikiMarkdownImage to extend OsuMarkdownImage
2021-06-10 09:38:48 +07:00
Gagah Pangeran Rosfatiputra
28d7b06908
create OsuMarkdownImage
2021-06-10 09:38:07 +07:00
Dean Herbert
3d508f9266
Merge branch 'master' into results-screen-sfx
2021-06-10 11:28:35 +09:00
Joseph Madamba
e3f3c37953
Add ability to navigate score panels with left/right arrows
2021-06-09 17:03:46 -07:00
Bartłomiej Dach
209f658d05
Merge branch 'master' into fix-beatmap-skin-disables
2021-06-09 20:22:00 +02:00
Bartłomiej Dach
89cdea8123
Merge branch 'master' into fix-results-exit-transition
2021-06-09 19:40:56 +02:00
Bartłomiej Dach
266c1e2e25
Merge branch 'master' into fix-beatmap-skin-disables
2021-06-09 18:43:15 +02:00
Bartłomiej Dach
222ae40a04
Merge branch 'master' into update-framework
2021-06-09 17:36:17 +02:00
Bartłomiej Dach
7fe878299f
Merge branch 'master' into wiki-article
2021-06-09 16:24:45 +02:00
Dean Herbert
f113c095ce
Update framework
2021-06-09 20:29:06 +09:00
Dean Herbert
b02b8ae2bc
Merge pull request #13381 from smoogipoo/improve-hit-error-judgements
...
Improve hit error judgement displays
2021-06-09 19:40:17 +09:00
Dean Herbert
31b46afa71
Fix wrong naming scheme for applause samples
2021-06-09 19:35:05 +09:00
Dean Herbert
7d86dafd4f
Simplify tick calculation/playback method
2021-06-09 19:31:53 +09:00
Dean Herbert
57bc34f224
Move consts closer to usage
2021-06-09 19:24:35 +09:00
Dean Herbert
cb4f366651
Move forgotten private function down more
2021-06-09 19:15:55 +09:00
Dean Herbert
81cecac90b
Move tick rate initialisation to earlier
2021-06-09 19:09:00 +09:00
Dean Herbert
499aba95c0
Simplify sample construction logic and move private functions down
2021-06-09 19:06:37 +09:00
Dean Herbert
489a5a3c1d
Add back missing space in csproj
2021-06-09 19:01:05 +09:00
Dean Herbert
21a63efd78
Rename variable back to withFlair to match parent class
2021-06-09 18:55:29 +09:00
Dean Herbert
330bb7cb45
Remove unnecessary skin lookup logic
2021-06-09 18:55:29 +09:00
Dean Herbert
0cf7c56e7e
Add fallback lookup support for DefaultSkin
2021-06-09 18:51:42 +09:00
Dean Herbert
8fda04c2d9
Merge branch 'master' into results-screen-sfx
2021-06-09 18:00:11 +09:00
Dean Herbert
2438c20d63
Fix SourceChanged not being correctly forwarded through LegacySkinTransformer
2021-06-09 17:56:07 +09:00
Dean Herbert
a65b76bdbf
Add a simple fade to the results screen
...
Stops it from immediately disappearing.
2021-06-09 17:19:37 +09:00
Dean Herbert
7b0c5e9d32
Fix results screen changing applied colour to background on exit
...
The general rule is that screens should only apply colours and the likes
on enter / resume, and leave the outwards transition to whatever screen
is coming next.
2021-06-09 17:18:55 +09:00
Dean Herbert
258d05d1e0
Ensure PlayerLoader restores the background colour to its own value on resume
2021-06-09 17:17:39 +09:00
Dean Herbert
a7ef0173e9
Add safety to ensure background is correct tint when entering gameplay
2021-06-09 17:07:28 +09:00
Bartłomiej Dach
020c63017e
Fix inspectcode issues
2021-06-09 09:21:02 +02:00
Dean Herbert
448e4e7ee5
Fix FindProvider calls on SkinProvidingContainer not considering disable flags
...
Closes #13394 .
2021-06-09 16:19:04 +09:00
Bartłomiej Dach
023015f9a6
Merge branch 'master' into fix-skin-background-regression
2021-06-09 08:09:21 +02:00
Bartłomiej Dach
a801a9a14d
Ensure background rotation on default skins
2021-06-09 07:59:47 +02:00
Dean Herbert
b754c52392
Update ModAutoplay matching to use new UserPlayable flag instead
2021-06-09 14:32:48 +09:00
Dean Herbert
b8df3fff9e
Fix incorrect method referenced in xmldco
...
Co-authored-by: ekrctb <32995012+ekrctb@users.noreply.github.com>
2021-06-09 14:20:01 +09:00
Dean Herbert
d0e9f8ef90
Replace and obsolete Ranked flag with IsUserPlayable
2021-06-09 14:17:03 +09:00
Dean Herbert
62199a38a8
Add one missing obsoletion removal date
2021-06-09 14:11:50 +09:00
Dean Herbert
f41e34ae2c
Remove more obsoleted members
2021-06-09 14:10:48 +09:00
Dean Herbert
a87226ab10
Remove obsoleted DrawableJudgement methods
...
Undated, but change was made on 2020-11-18.
2021-06-09 14:09:23 +09:00
Dean Herbert
7774344f0e
Remove "Unranked" text from ModDisplay
2021-06-09 13:45:09 +09:00
Dean Herbert
249a8f259b
Reword "unranked" to "not ranked" on beatmap overlay
...
This will be replaced anyway once we start to consume osu-web
translation strings.
2021-06-09 13:44:27 +09:00
Bartłomiej Dach
97204b6f27
Reduce unnecessary background changes via IEquatable implementation
2021-06-08 22:37:18 +02:00
Bartłomiej Dach
a98c302211
Bring back skin background source
2021-06-08 22:04:59 +02:00
Bartłomiej Dach
5bf4dd6358
Move skin background to separate file
2021-06-08 21:57:08 +02:00
Bartłomiej Dach
410cb16340
Apply fixed label width to setup screen items
2021-06-08 17:18:00 +02:00
Bartłomiej Dach
88266eac63
Add option to fix label width of a LabelledDrawable
2021-06-08 16:57:32 +02:00
smoogipoo
00efed2c39
Add colours for tick judgements
2021-06-08 23:10:21 +09:00
smoogipoo
c8e14d7710
Ignore non-scorable and bonus judgements
2021-06-08 23:09:23 +09:00
smoogipoo
c3ea1b26e1
Fix DT being doubled in multiplayer spectator
2021-06-08 22:51:42 +09:00
Dean Herbert
25af4dfa8a
Merge pull request #13375 from smoogipoo/fix-multi-nullref
...
Fix possible nullref when exiting song select too fast
2021-06-08 20:47:40 +09:00
Dan Balasescu
5a8cde7e6f
Merge pull request #13377 from peppy/fix-lazer-replays-getting-classic
...
Move legacy `ScoreInfo` to be completely based on presence of classic mod
2021-06-08 19:15:13 +09:00
Samuel Cattini-Schultz
f1bef989b7
Refactor DifficultyAttributes to use auto properties over public fields
2021-06-08 19:43:59 +10:00
smoogipoo
0b9916b266
Add parens to declare operator precedence
2021-06-08 18:39:52 +09:00
Dean Herbert
4ee7721c51
Extract first version out to constant
2021-06-08 18:38:47 +09:00
Dan Balasescu
d31e3e8f1c
Fix nullref
2021-06-08 18:23:03 +09:00
Dean Herbert
b287366c8b
Remove forgotten classic mod addition
2021-06-08 18:09:57 +09:00
Dean Herbert
061e3d7f26
Move legacy ScoreInfo to be completely based on presence of classic mod
2021-06-08 18:00:09 +09:00
Dean Herbert
4d9fffc01b
Update score encoder version to be higher than any existing stable version
2021-06-08 17:59:43 +09:00
smoogipoo
ab9290772b
Fix a similar case with online play sub-screens
2021-06-08 17:54:54 +09:00
smoogipoo
860f1aebb3
Only call OnBackButton() if the screen has finished loading
2021-06-08 17:38:12 +09:00
Dean Herbert
6017ef3825
Merge branch 'master' into fix-skin-sample-lookup
2021-06-08 17:37:36 +09:00
Dan Balasescu
e5e3509c87
Merge pull request #13264 from peppy/legacy-skin-default-fallback
...
Allow fallback to legacy defaults from legacy skins
2021-06-08 17:30:27 +09:00
Dan Balasescu
c0fdbfba04
Merge pull request #13374 from peppy/update-framework
...
Update framework
2021-06-08 17:09:20 +09:00
smoogipoo
7fa0ac6ed7
Fix possible nullref when exiting song select too fast
2021-06-08 17:03:50 +09:00
Dan Balasescu
791855dfa0
Merge branch 'master' into legacy-skin-default-fallback
2021-06-08 16:54:26 +09:00
Dan Balasescu
e3cb6f45f5
Merge pull request #13371 from peppy/fix-poolable-sample-disposal-skin-change
...
Clean up previous sample immediately on skin source change to avoid `Play` after disposal
2021-06-08 16:52:59 +09:00
Dean Herbert
89895f6ce4
Update framework
2021-06-08 16:24:00 +09:00
Dan Balasescu
67135ce3db
Add null check
2021-06-08 16:15:17 +09:00
Dean Herbert
e2fdc23d98
Merge branch 'fix-skin-sample-lookup' into results-screen-sfx
2021-06-08 15:20:11 +09:00
Dean Herbert
e0f568aa8f
Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup
2021-06-08 15:19:52 +09:00
Dean Herbert
95852ccdf8
Merge branch 'master' into results-screen-sfx
2021-06-08 15:14:31 +09:00
Dean Herbert
f3f634e969
Clean up previous sample immediately on skin source change to avoid Play after disposal
...
This seems to be the simplest way to avoid calls to `Play` after the
underlying sample may have been disposed. As per the issue thread, a
local workaround is acceptable here.
Closes #13223 .
2021-06-08 15:05:18 +09:00
smoogipoo
7341e474f1
Attempt to safeguard against collections database corruptions
2021-06-08 14:25:39 +09:00
Dean Herbert
27e3de3ea3
Add TODO about beatmap skin fallback support
2021-06-08 12:12:14 +09:00
Dean Herbert
06840d78cc
Remove now unused method
2021-06-08 12:06:42 +09:00
Dean Herbert
2c1f22d7ae
Refactor animation lookup to properly handle skins providing non-animated resources
2021-06-08 01:17:20 +09:00
Dean Herbert
e7e9197f03
Fix FindProvider not correctly checking legacy default in SkinManager
2021-06-08 00:42:50 +09:00
Dean Herbert
6d56e02ddb
Add back incorrectly reverted animation handling logic
...
This reverts commit b904fa6615
2021-06-08 00:17:01 +09:00
Dean Herbert
c0305343bc
Fix FindProvider incorrectly returning LegacySkinTransformer itself
2021-06-07 23:23:44 +09:00
Dean Herbert
08701b5eab
Ensure all lookups in LegacyHealthDisplay use the found provider
...
Not actually needed to fix the remaining issue but does feel better
2021-06-07 23:23:12 +09:00
Bartłomiej Dach
0531c2dcd9
Move empty window check to bar error meter
...
It's not valid in the base `HitErrorMeter`, as the colour meter only
displays colour for a given judgement, so it is still valid to add new
items to it even if the hit window is 0, as misses are still possible.
2021-06-07 13:16:07 +02:00
Bartłomiej Dach
37d062c7cd
Add failing assertions to hit error meter test
2021-06-07 13:16:07 +02:00
Bartłomiej Dach
b192c46316
Merge branch 'master' into wiki-article
2021-06-07 11:19:20 +02:00
Bartłomiej Dach
a0bda9ad59
Hoist scroll cache declaration to original place of definition
2021-06-07 11:18:18 +02:00
Bartłomiej Dach
e606bf249a
Move dependency specification to BDL
...
As it is not used anywhere else.
2021-06-07 11:05:30 +02:00
Dean Herbert
59130be99c
Fix switching storyboard mode not triggering a reload
2021-06-07 17:32:04 +09:00
Dean Herbert
f677f9b5f4
Stop BackgroundScreenDefault from reloading beatmap background when already correct
2021-06-07 17:22:36 +09:00
Dean Herbert
e8d4147773
Add missing null handling for never Markdig version
2021-06-07 16:08:44 +09:00
Dean Herbert
aa700702fe
Update framework
2021-06-07 15:48:45 +09:00
Dean Herbert
d26c9a66c2
Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup
2021-06-07 12:01:19 +09:00
Dean Herbert
e10dfab2e8
Ensure scorebar marker lookup is performed on the source the background is retrieved from
2021-06-06 23:23:35 +09:00
Dean Herbert
b5f145cfa9
Use null propagation for animation lookups
2021-06-06 23:01:37 +09:00
Gagah Pangeran Rosfatiputra
ed733ee648
directly using table of content entry in wiki table of contents
2021-06-06 20:19:39 +07:00
Dean Herbert
b904fa6615
Revert "Ensure all frames in an animation are retrieved from the same skin"
...
This reverts commit 37c8c63fc5
2021-06-06 12:37:42 +09:00
Dean Herbert
b87a5956dd
Add fallback logic to SkinManager
2021-06-06 12:17:55 +09:00
Dean Herbert
39f99bf785
Move FindProvider to ISkinSource
2021-06-06 12:17:32 +09:00
Gagah Pangeran Rosfatiputra
525c16419a
use container for main title and sub title table of contents
2021-06-06 08:37:03 +07:00
Craftplacer
b97f31f314
Revert deletion of xmldoc summary line
2021-06-05 19:03:11 +02:00
Craftplacer
4925a7d59e
Minor code quality changes
2021-06-05 15:57:14 +02:00
Gagah Pangeran Rosfatiputra
9f45a28623
use WikiTableOfContents in WikiSidebar
2021-06-05 19:47:00 +07:00
Gagah Pangeran Rosfatiputra
55f3a328a4
add WikiTableOfContents
2021-06-05 19:46:46 +07:00
Craftplacer
5e44329e0b
Add DummyAPIAccess request handler
...
Make CreateChannelRequest.channel public
2021-06-05 14:43:26 +02:00
Craftplacer
ce4bcda803
Use separate method for fetching channel objects
...
Resolves a pull request review
2021-06-05 14:02:48 +02:00
Gagah Pangeran Rosfatiputra
958bddc8cb
remove onclick in toc entry
2021-06-05 18:30:28 +07:00
Gagah Pangeran Rosfatiputra
c099751ad1
use plain if check in switch case
2021-06-05 18:26:03 +07:00
Craftplacer
39c3b08fc7
Merge remote-tracking branch 'upstream/master' into chat-mention
2021-06-05 11:18:06 +02:00
Craftplacer
b746fe7c03
Fix binding order
2021-06-05 11:03:49 +02:00
Dean Herbert
9f6e3996b1
Merge branch 'master' into fix-osutestscene-content
2021-06-05 14:49:19 +09:00
Craftplacer
1084906d40
Add DummyAPIAccess one parent up
2021-06-05 03:30:21 +02:00
Gagah Pangeran Rosfatiputra
4cf3381d0b
use wiki article page when failed fetch
2021-06-04 23:59:11 +07:00
Gagah Pangeran Rosfatiputra
5ee77925e4
change WikiArticlePage to extends CompositeDrawable
2021-06-04 23:54:50 +07:00
Gagah Pangeran Rosfatiputra
f07d4532d9
move scroll to into action
2021-06-04 23:51:18 +07:00
Gagah Pangeran Rosfatiputra
a431ef6c48
keep colour change when entry is clicked
2021-06-04 23:43:00 +07:00
Gagah Pangeran Rosfatiputra
5febbe4530
rename method add entry
2021-06-04 23:32:42 +07:00
Gagah Pangeran Rosfatiputra
70c64af25e
rename toc entry
2021-06-04 23:31:51 +07:00
Dean Herbert
10acad6524
Merge pull request #13261 from smoogipoo/fix-spectator-frame-conversion
...
Fix spectator crashing when converting mania replay frames
2021-06-05 00:38:15 +09:00
Dan Balasescu
bde0071de8
Merge pull request #13336 from ekrctb/pdwl-catch-explosion
...
Fix catch hit lighting not always showing when a replay is rewound
2021-06-04 22:19:34 +09:00
smoogipoo
009aa994d0
Fix potential race incorrectly pausing the source clock
2021-06-04 21:58:51 +09:00
Dan Balasescu
57a38374db
Merge branch 'master' into fix-spectator-frame-conversion
2021-06-04 21:17:40 +09:00
ekrctb
5512231bf4
Add NextSingle of version taking output range to StatelessRNG
2021-06-04 19:52:12 +09:00
Dean Herbert
840f084dc4
Merge pull request #13303 from LeNitrous/mainmenu-storyboard-backgrounds
...
Add storyboards as a main menu background source
2021-06-04 19:50:40 +09:00
Gagah Pangeran Rosfatiputra
8883d5e2d1
use heading block to get title string
2021-06-04 15:28:54 +07:00
Gagah Pangeran Rosfatiputra
6d6c03eafe
use linq to find first literal inline
2021-06-04 14:45:06 +07:00
Dean Herbert
ae2165b3be
Fix incorrect xmldoc
2021-06-04 16:44:04 +09:00
Jamie Taylor
50819ef91f
use a dictionary for sample lookups instead
2021-06-04 16:41:52 +09:00
Dean Herbert
5fa9366152
Update resources
2021-06-04 16:22:16 +09:00
Dean Herbert
37c8c63fc5
Ensure all frames in an animation are retrieved from the same skin
2021-06-04 16:18:04 +09:00
Dan Balasescu
2069a5bd28
Merge pull request #13313 from ekrctb/factor-out-hoc
...
Factor out entry management logic of `HitObjectContainer` to the new base class
2021-06-04 16:06:48 +09:00
Dean Herbert
06275a6a7d
Merge branch 'master' into legacy-skin-default-fallback
2021-06-04 16:00:30 +09:00
Dan Balasescu
b283c48abb
Merge branch 'master' into factor-out-hoc
2021-06-04 15:31:35 +09:00
Dean Herbert
19a44d65c5
Tidy up code
2021-06-04 15:18:16 +09:00
Dean Herbert
23096c58bb
Merge branch 'master' into fix-spectator-frame-conversion
2021-06-04 15:06:15 +09:00
Dean Herbert
071c07586a
Increase music volume back to 80% for the time being
2021-06-04 15:00:53 +09:00
Nathan Alo
996c156106
apply suggestions
...
- apply 0 alpha to beatmap background if storyboard replaces it
- use an AudioContainer to mute all samples coming from the storyboard
2021-06-04 13:56:10 +08:00
Gagah Pangeran Rosfatiputra
a706ff63ed
change sprite text to text flow
2021-06-04 12:50:03 +07:00
Gagah Pangeran Rosfatiputra
91e77ee4de
add onclick in toc title
2021-06-04 11:43:49 +07:00
Gagah Pangeran Rosfatiputra
37ff6299c9
add target in toc title
2021-06-04 11:43:32 +07:00
Gagah Pangeran Rosfatiputra
e28b38653b
cache scroll container
2021-06-04 11:43:00 +07:00
Gagah Pangeran Rosfatiputra
4e73d02540
move sidebar into local variable
2021-06-04 11:35:23 +07:00
Gagah Pangeran Rosfatiputra
424d1b4025
add margin padding spacing in toc title
2021-06-04 11:18:08 +07:00
Gagah Pangeran Rosfatiputra
41ec531bab
add subtitle toc
2021-06-04 11:12:42 +07:00
Gagah Pangeran Rosfatiputra
d8d4bf66b3
create TocTitle in WikiSidebar
2021-06-04 11:09:20 +07:00
Gagah Pangeran Rosfatiputra
59dbed6418
create ArticleMarkdownContainer in WikiArticlePage
2021-06-04 11:08:51 +07:00
Gagah Pangeran Rosfatiputra
abb522f084
add missing using
2021-06-04 10:53:48 +07:00
Dan Balasescu
0ba493d598
Merge pull request #13318 from gagahpangeran/error-page-placeholder
...
Add error page placeholder for wiki overlay
2021-06-04 12:20:21 +09:00
Gagah Pangeran Rosfatiputra
b1b305c150
add method AddToc
2021-06-04 10:17:38 +07:00
Gagah Pangeran Rosfatiputra
7e78150144
add basic content wiki sidebar
2021-06-04 10:16:49 +07:00
Dean Herbert
eebd5745a8
Move full stop out of link and reword slightly
2021-06-04 11:44:43 +09:00
Dan Balasescu
233551fc08
Merge pull request #13323 from gagahpangeran/extract-sidebar
...
Create abstract class `OverlaySidebar`
2021-06-04 11:38:36 +09:00
Gagah Pangeran Rosfatiputra
458910b744
use WikiArticlePage in WikiOverlay
2021-06-04 09:29:36 +07:00
Gagah Pangeran Rosfatiputra
791a9dd33a
add WikiArticlePage
2021-06-04 09:29:10 +07:00
Gagah Pangeran Rosfatiputra
beb0119dd5
initial wiki sidebar
2021-06-04 09:28:31 +07:00
Dan Balasescu
50c60c791f
Merge pull request #13322 from Pasi4K5/seed-for-all-random-mods
...
Add seed option for all random mods
2021-06-04 11:26:13 +09:00
Gagah Pangeran Rosfatiputra
905472a20b
make NewsSidebar extends OverlaySidebar
2021-06-04 00:12:29 +07:00
Gagah Pangeran Rosfatiputra
076e498a63
create abstract class OverlaySidebar
2021-06-04 00:12:13 +07:00
Dean Herbert
d444fed46f
Detach gameplay score from replay recorder before importing
...
Closes #13320 .
2021-06-04 02:00:02 +09:00
Pasi4K5
7a4fc9ffc8
Move seed to base class
2021-06-03 18:16:11 +02:00
Gagah Pangeran Rosfatiputra
c5fc155cc0
Change text wording
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-06-03 20:37:27 +07:00
Gagah Pangeran Rosfatiputra
490ce0bbc5
load placeholder page when failed
2021-06-03 19:40:54 +07:00
Bartłomiej Dach
5f5f3a8c5c
General comment cleanups
2021-06-03 14:20:52 +02:00
Bartłomiej Dach
b2cc2a51ec
Rename method to be less misleading
...
Would rather avoid variations of Equals/Equal/IsEqual. There's not
really much equality involved as the types are different.
2021-06-03 14:13:01 +02:00
Bartłomiej Dach
e8c2483f19
Use standard list instead of bindable list
...
No reason to use a bindable list there, as `CollectionChanged` was never
subscribed to.
2021-06-03 14:09:52 +02:00
Bartłomiej Dach
8193691cbc
Invert condition to reduce nesting
2021-06-03 14:09:52 +02:00
Bartłomiej Dach
acb4873157
Merge branch 'master' into keyboard_shortcuts
2021-06-03 14:09:48 +02:00
Dean Herbert
33ab411e39
Merge branch 'master' into drawavatar-use-avatar-url
2021-06-03 19:36:32 +09:00
Jamie Taylor
054de675ff
allow skinned 'applause' sample to override results screen sfx
2021-06-03 18:35:55 +09:00
Jamie Taylor
582360d0c8
only load the required impact/applause samples
2021-06-03 18:35:51 +09:00
Jamie Taylor
ed012a724b
refactor from using public variables
2021-06-03 18:35:46 +09:00
Jamie Taylor
8dc595d201
move result screen samples to DefaultSkin
2021-06-03 18:35:27 +09:00
Jamie Taylor
63e5bc4543
update sample names and timings
2021-06-03 18:34:33 +09:00
Jamie Taylor
30eff8cc2a
remove overlapping/legacy applause
2021-06-03 18:34:28 +09:00
Jamie Taylor
9ad87ee5dc
add sfx for results screen + sound design tool
2021-06-03 18:34:22 +09:00
smoogipoo
e887807ae7
Apply review fixes
2021-06-03 18:32:05 +09:00
smoogipoo
be03a2d7d2
Fix multiple calls to seek method potentially not working
2021-06-03 17:47:22 +09:00
smoogipoo
c3280083a2
Merge branch 'master' into fix-spectator-frame-conversion
2021-06-03 17:42:01 +09:00
smoogipoo
662bbed5d1
Fix seeking to gameplay too soon
2021-06-03 17:38:51 +09:00
Dan Balasescu
15b43beef1
Merge pull request #11857 from Syriiin/diffcalc/refactor/catch-clockrate-effects
...
Refactor catch Movement skill to not require explicit clockrate usage
2021-06-03 17:29:27 +09:00
smoogipoo
420df124b5
Add framestable-bypassing seek for spectator
2021-06-03 17:27:21 +09:00
Dan Balasescu
69009a36b7
Merge branch 'master' into autoplay-pause-support
2021-06-03 16:37:41 +09:00
Dean Herbert
48687028a3
Merge branch 'test-platform-actions' into keyboard_shortcuts
2021-06-03 15:35:57 +09:00
Dean Herbert
be91203c92
Add nested PlatformActionContainer to allow testing of platform actions in visual tests
2021-06-03 15:35:32 +09:00
Samuel Cattini-Schultz
f51413ead9
Refactor to pass clockrate in constructor rather than deriving from mods
2021-06-03 16:09:42 +10:00
Dean Herbert
e74fe68c96
Use new platform actions instead of hardcoded keys
2021-06-03 15:04:07 +09:00
ekrctb
b321b20e9d
Remove OnAdd/OnRemove of HitObjectContainer
...
Instead, override `AddDrawable`/`RemoveDrawable`.
2021-06-03 15:00:16 +09:00
ekrctb
0ce7baa3f3
Make HitObjectContainer.Clear non-virtual
...
It just call `Remove` for all entries.
2021-06-03 15:00:16 +09:00
ekrctb
2c9e5b6c7e
Replace EntryCrossedBoundary with more useful RemoveRewoundEntry property
...
It can be used for dynamically added entries.
2021-06-03 15:00:16 +09:00
ekrctb
fe2934db1d
Factor out lifetime management logic of HitObjectContainer
2021-06-03 14:57:28 +09:00
Dean Herbert
a91015302e
Replace second usage of new function
2021-06-03 14:56:29 +09:00
Dean Herbert
a6cc37eb3b
Mark fields readonly
2021-06-03 14:56:21 +09:00
Nathan Alo
d7d0dde5d2
use created storyboard to check for drawables instead
2021-06-03 13:56:14 +08:00
Dean Herbert
4a5d8215f3
Merge branch 'master' into keyboard_shortcuts
2021-06-03 14:47:40 +09:00
Nathan Alo
62b07fb9ce
apply suggestions
...
- Replace the sprite with a solid black box when a storyboard requests it.
- Create a new storyboard instance and exclude the fail layer as well as strip all samples from it
- Do not attempt in creating the storyboard when it isn't needed
2021-06-03 13:27:00 +08:00
Nathan Alo
d00fb21188
prevent scaling container from creating a storyboard background
2021-06-03 13:24:21 +08:00
Dan Balasescu
44b1102241
Merge branch 'master' into autoplay-pause-support
2021-06-03 13:26:00 +09:00
Dean Herbert
a62dd7cca0
Revert "refactor BeatmapBackgroundWithStoryboard to reduce overhead"
...
This reverts commit 277545bb06
2021-06-03 12:33:16 +09:00
Dean Herbert
d6656047e3
Fix beatmap statistics with value of zero not displaying correctly at song select
...
Closes #13307 .
2021-06-03 01:58:51 +09:00
Nathan Alo
277545bb06
refactor BeatmapBackgroundWithStoryboard to reduce overhead
...
This avoids loading the sprite if its not needed and instead of hiding it, it is removed when the storyboard replaces the background or there is a video.
This also only initializes DrawableStoryboard if there are any elements in any layer.
2021-06-02 20:27:12 +08:00
Dean Herbert
cde8de154d
Remove unused test property for now
2021-06-02 19:11:09 +09:00
Dan Balasescu
c065f761c7
Merge branch 'master' into legacy-skin-default-fallback
2021-06-02 19:08:52 +09:00
Dean Herbert
e0eb0adb0a
Remove unnecessary bind in ReplayPlayer
2021-06-02 18:32:14 +09:00
Nathan Alo
3c3ef13632
remove fade
2021-06-02 16:28:22 +08:00
Nathan Alo
e66f6e8f91
fix inspect code issues and cleanup code
2021-06-02 16:12:41 +08:00
Nathan Alo
dde64adcb5
add new background type in BackgroundScreenDefault
2021-06-02 15:51:43 +08:00
Nathan Alo
dec18ef826
implement BeatmapBackgroundWithStoryboard
2021-06-02 15:50:58 +08:00
Nathan Alo
5b436ee436
add beatmap with storyboard source
2021-06-02 15:50:33 +08:00
Dean Herbert
5366e7f61e
Merge branch 'master' into remove-hud-component-lookup
2021-06-02 16:10:06 +09:00
Dean Herbert
f8ae70e562
Update existing function type rather than adding an override
2021-06-02 16:04:53 +09:00
Dean Herbert
a15cac6f53
Change the way Score is initialised in Player to better lend to population of metadata
2021-06-02 15:44:04 +09:00
Dan Balasescu
47019196f6
Merge branch 'master' into fix-relative-link-resolution
2021-06-02 14:55:38 +09:00
Dean Herbert
ac761bb075
Use string.Empty instead of arbitrary string
2021-06-02 14:43:35 +09:00
Dean Herbert
4759ac098f
Merge pull request #13293 from smoogipoo/update-dependencies
...
Update dependencies
2021-06-02 14:35:06 +09:00
Dean Herbert
4fd8c9c17b
Merge pull request #13284 from ppy/dependabot/nuget/ppy.LocalisationAnalyser-2021.525.0
...
Bump ppy.LocalisationAnalyser from 2021.524.0 to 2021.525.0
2021-06-02 14:34:37 +09:00
Dean Herbert
45984f035b
Make autoplay tests test via the ReplayPlayer code path
2021-06-02 11:49:06 +09:00
smoogipoo
d3d8941ec8
Make method internal
2021-06-02 11:11:41 +09:00
Dean Herbert
911256603b
Rewrite comment to hopefully be more informative
2021-06-02 11:10:02 +09:00
smoogipoo
8ee2b3a2d2
Merge branch 'master' into fix-scrolling-lifetime
2021-06-02 11:08:28 +09:00
Dan Balasescu
ac83450791
Merge pull request #13256 from ekrctb/update-lifetime-2
...
Update DHO lifetime on entry lifetime change
2021-06-02 11:07:54 +09:00
Dean Herbert
8a76d97b63
Remove replay logic from DrawableRuleset (and implement in DrawableEditorRulesetWrapper)
2021-06-02 11:06:30 +09:00
smoogipoo
51e4b6c860
Merge remote-tracking branch 'ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.6' into update-dependencies
2021-06-02 09:21:26 +09:00
smoogipoo
4184cb88f6
Merge remote-tracking branch 'ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.6' into update-dependencies
2021-06-02 09:21:09 +09:00
smoogipoo
dc31e2925c
Merge remote-tracking branch 'ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-5.0.6' into update-dependencies
2021-06-02 09:20:37 +09:00
smoogipoo
e19568c91b
Merge remote-tracking branch 'ppy/dependabot/nuget/Sentry-3.4.0' into update-dependencies
2021-06-02 09:20:33 +09:00
smoogipoo
b0a229da87
Merge remote-tracking branch 'ppy/dependabot/nuget/ppy.LocalisationAnalyser-2021.525.0' into update-dependencies
2021-06-02 09:20:31 +09:00
dependabot[bot]
a758b38278
Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack
...
Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore ) from 5.0.5 to 5.0.6.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.5...v5.0.6 )
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:32 +00:00
dependabot[bot]
a10ef2ba65
Bump Humanizer from 2.8.26 to 2.10.1
...
Bumps [Humanizer](https://github.com/Humanizr/Humanizer ) from 2.8.26 to 2.10.1.
- [Release notes](https://github.com/Humanizr/Humanizer/releases )
- [Changelog](https://github.com/Humanizr/Humanizer/blob/main/release_notes.md )
- [Commits](https://github.com/Humanizr/Humanizer/compare/v2.8.26...v2.10.1 )
---
updated-dependencies:
- dependency-name: Humanizer
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:31 +00:00
dependabot[bot]
deaa381440
Bump Sentry from 3.3.4 to 3.4.0
...
Bumps [Sentry](https://github.com/getsentry/sentry-dotnet ) from 3.3.4 to 3.4.0.
- [Release notes](https://github.com/getsentry/sentry-dotnet/releases )
- [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md )
- [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.3.4...3.4.0 )
---
updated-dependencies:
- dependency-name: Sentry
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:30 +00:00
dependabot[bot]
bd8db2ce63
Bump ppy.LocalisationAnalyser from 2021.524.0 to 2021.525.0
...
Bumps [ppy.LocalisationAnalyser](https://github.com/ppy/osu-localisation-analyser ) from 2021.524.0 to 2021.525.0.
- [Release notes](https://github.com/ppy/osu-localisation-analyser/releases )
- [Commits](https://github.com/ppy/osu-localisation-analyser/compare/2021.524.0...2021.525.0 )
---
updated-dependencies:
- dependency-name: ppy.LocalisationAnalyser
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:28 +00:00
dependabot[bot]
ea9919e8fe
Bump Microsoft.AspNetCore.SignalR.Client from 5.0.5 to 5.0.6
...
Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore ) from 5.0.5 to 5.0.6.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.5...v5.0.6 )
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Client
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:27 +00:00
dependabot[bot]
069baab883
Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
...
Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore ) from 5.0.5 to 5.0.6.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.5...v5.0.6 )
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:27 +00:00
Dean Herbert
92ffc4627f
Update framework
2021-06-01 23:24:49 +09:00
Dean Herbert
2e2281c7d2
Revert disabling taiko sample tests and fix logic
2021-06-01 18:57:19 +09:00
Dean Herbert
e8aa5c4ecf
Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup
2021-06-01 18:05:00 +09:00
Dean Herbert
cd139660ab
Merge branch 'master' into legacy-skin-default-fallback
2021-06-01 18:04:54 +09:00
Dean Herbert
3a6d081d82
Remove duplicated taiko fallback
2021-06-01 18:04:49 +09:00
Dean Herbert
ea4644be90
Revert "Fix weird taiko logic failing for weird reasons that probably should not have been a thing"
...
This reverts commit 69c4ccad05
2021-06-01 18:04:49 +09:00
Dean Herbert
a837fc9e3b
Remove duplicated taiko fallback
2021-06-01 18:00:24 +09:00
Dean Herbert
f14c0eae99
Fix editor no longer creating autoplay frames
2021-06-01 17:28:41 +09:00
Dean Herbert
df0a5689e4
Revert "Fix weird taiko logic failing for weird reasons that probably should not have been a thing"
...
This reverts commit 69c4ccad05
2021-06-01 17:13:13 +09:00
Dean Herbert
3668f1861f
Fix one more null issue
2021-06-01 17:10:09 +09:00
Dean Herbert
ff815cb4b4
Fix incorrect xmldoc
2021-06-01 16:57:41 +09:00
Dean Herbert
289dc00f38
Merge branch 'master' into autoplay-pause-support
2021-06-01 16:50:44 +09:00
Dean Herbert
145e42928b
Fix remaining null checks
2021-06-01 16:49:05 +09:00
Dean Herbert
1f8abcdf6c
Merge branch 'master' into fix-relative-link-resolution
2021-06-01 16:49:02 +09:00
Dean Herbert
6e861a9b7f
Revert incorrect ScoreProcessor change
2021-06-01 16:39:50 +09:00
Dean Herbert
790f1dacc9
Ensure ScoreProcessor is still hooked up in special case
2021-06-01 16:24:38 +09:00
Salman Ahmed
7c6400735f
Merge branch 'master' into remove-hud-component-lookup
2021-06-01 10:17:52 +03:00
Salman Ahmed
c090110ae2
Provide cell skin on content creation
2021-06-01 10:16:13 +03:00
Gagah Pangeran Rosfatiputra
b4dd935538
add corner radius and padding
2021-06-01 14:14:12 +07:00
Gagah Pangeran Rosfatiputra
5108dadfbc
use inline code in markdown text flow
2021-06-01 14:03:57 +07:00
Gagah Pangeran Rosfatiputra
1babb05fc7
add OsuMarkdownInlineCode
2021-06-01 14:03:31 +07:00
Dean Herbert
3ba0d29108
Fix incorrect beatmap being parsed down for autoplay generation
2021-06-01 15:44:24 +09:00
