Dean Herbert
f997886142
Add scrolling gameplay visualisation mode to latency certifier
2022-06-13 17:18:32 +09:00
Dean Herbert
86163d2225
Fix hit error meters not updating visual state when hidden
...
It is an expectation of users that when the HUD is shown after a period
of being hidden, it will visually reflect the state based on recent
judgements.
To achieve this, I've added `AlwaysPresent` and moved the transform
application to the meter level, rather than at a child level. If this is
seen as a bad direction, `AlwaysPresent` can be applied to the drawable
children and the transforms can be moved back.
Also of note, `ColourHitErrorMeter` is pretty weird. The flow class
could potentially be removed and reduce `AlwaysPresent` usage by one.
Can do that refactor as part of this PR if preferred.
Closes #18624 .
2022-06-13 16:38:57 +09:00
Dean Herbert
17eaf7bb5c
Add failing test coverage showing hit meters don't update when not visible
2022-06-13 16:36:22 +09:00
Dean Herbert
77fcf35d1d
Remove unlimited frame limiter warning
...
This should not be required now that we have a 1,000 Hz limiter in
place.
2022-06-13 15:40:27 +09:00
Dan Balasescu
dfc643fd8c
Match family string via GetFamilyString()
2022-06-13 12:35:10 +09:00
Salman Ahmed
3aec0fe9b6
Fix torus alternate not mapping "medium" weight to "regular"
2022-06-13 04:45:07 +03:00
Salman Ahmed
7971355660
Fix torus "medium" weight not mapped to "regular" when using With
2022-06-13 04:44:44 +03:00
Salman Ahmed
051aa8f028
Mark family strings as verbatim
2022-06-13 04:43:14 +03:00
Salman Ahmed
85fc218edf
Provide context menu items at BlueprintContainer
for out-of-bounds support
2022-06-11 20:53:53 +03:00
Dan Balasescu
12ff98001d
Merge pull request #18635 from peppy/latency-comparer-more-modes
...
Add multiple display modes (including circle gameplay) to latency certification
2022-06-12 00:59:36 +09:00
Dan Balasescu
486f762f44
Fix inspection by removing unstable rate code
2022-06-12 00:13:36 +09:00
Dean Herbert
af353c37c0
Don't show UR for now
2022-06-11 23:54:11 +09:00
Dean Herbert
52c8cea27d
Update spectator/multiplayer endpoint in line with new deployment
2022-06-11 22:31:01 +09:00
Salman Ahmed
419b5791c9
Move circle duration to constant
2022-06-11 16:08:24 +03:00
Dean Herbert
8d53ed64a3
Fix mode cycling and add test coverage
2022-06-11 21:36:43 +09:00
Dean Herbert
0c333e5c08
Link directly to methodology section
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-06-11 21:34:00 +09:00
Dean Herbert
c697dc90e4
Hide settings at results screen
2022-06-11 21:32:02 +09:00
Dean Herbert
d130e7ebff
Remove ScrollingGameplay
class for now
2022-06-11 21:30:33 +09:00
Dean Herbert
68da9f0386
Add explicit precision for BPM adjustment
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-06-11 21:27:44 +09:00
Salman Ahmed
06f070c3ec
Fix latency certifier potentially reporting infinite mouse polling rate
2022-06-11 14:58:16 +03:00
Dean Herbert
8562641560
Update framework
2022-06-11 12:48:31 +09:00
Dean Herbert
096d6df868
Fix regression in testing and setting logic
2022-06-10 20:33:21 +09:00
Dean Herbert
8ce545ff9d
Fix visuals in circle gameplay and greedy hover
2022-06-10 20:25:33 +09:00
Dean Herbert
b956a916c1
Make units sane
2022-06-10 20:21:03 +09:00
Dean Herbert
213ccfb743
Improve explanation text and add link to wiki
2022-06-10 20:14:12 +09:00
Dean Herbert
18f74b2840
Move settings and bindables to a sane location
2022-06-10 20:04:51 +09:00
Dean Herbert
837958b254
Remove scrolling gameplay mode for now
2022-06-10 19:43:09 +09:00
Dean Herbert
ef5c1a1ecb
Improve visuals of circle gameplay mode
2022-06-10 19:42:25 +09:00
Dean Herbert
a6fd61c444
Default to circle gameplay mode
2022-06-10 19:42:25 +09:00
Dean Herbert
41d16c613d
Fix being able to hit way too early using keyboard
2022-06-10 19:42:25 +09:00
Dean Herbert
2f1c331f65
Move shared logic to LatencySampleComponent
and implement key support for circle gameplay
2022-06-10 19:42:25 +09:00
Dean Herbert
7f4a54096f
Fix circles in the future being hittable
2022-06-10 19:42:25 +09:00
Dean Herbert
ba14d646c3
Add static configuration
2022-06-10 19:42:25 +09:00
Dean Herbert
5deaa42e9f
Stop music on entering latency certification screen
2022-06-10 19:42:25 +09:00
Dean Herbert
5c7d29cd31
Remove dependency on game-wide audio
2022-06-10 19:42:25 +09:00
Dean Herbert
d46739ff0b
Add circle gameplay test coverage
2022-06-10 19:42:25 +09:00
Dean Herbert
c657ef2722
Add ability to adjust spacing
2022-06-10 19:42:25 +09:00
Dean Herbert
e9547542ea
Add circle gameplay
2022-06-10 19:42:25 +09:00
Dean Herbert
53eb5c176c
Create setup for adding other visual display modes
2022-06-10 19:42:25 +09:00
Dan Balasescu
e5d6dc1ba5
Merge pull request #18606 from peppy/latency-comparer
...
Add latency certifier system
2022-06-10 19:41:44 +09:00
Dean Herbert
e0644f2726
Simplify flow of progression to be linear
2022-06-10 15:19:10 +09:00
Dean Herbert
5541ebc76b
Revert OsuButton
changes
2022-06-10 15:02:26 +09:00
Dan Balasescu
c9dfffbc0e
Merge pull request #18619 from peppy/fix-collection-performance
...
Fix performance overhead of large collections
2022-06-10 15:01:31 +09:00
Dean Herbert
eb16de9c71
Use upper-case "Hz"
2022-06-10 14:38:04 +09:00
Dean Herbert
f71343c880
Fix box colour getting stuck when changing active mode
2022-06-10 14:28:46 +09:00
Dean Herbert
5b8bd24140
Simplify text when reaching maximum supported level
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-06-10 14:25:15 +09:00
Dean Herbert
69b856bd58
Rename rounds variables to hopefully read better
2022-06-10 14:23:24 +09:00
Dean Herbert
613814c26c
Make TargetFrameRate
nullable
2022-06-10 14:18:35 +09:00
Dean Herbert
c625c929e5
Update button text to match new terminology
2022-06-10 14:16:56 +09:00
Dean Herbert
4a5e86e451
Rename Beatmaps
to BeatmapHashes
for clarity
2022-06-10 14:03:51 +09:00
Dean Herbert
3b229624dd
Simplify contains check to use LINQ the whole way
2022-06-10 14:02:58 +09:00
Dean Herbert
70ebfbcf5e
Add recommendation text and adjust weightings to read better
2022-06-09 19:26:24 +09:00
Dan Balasescu
6d2a2ba7d6
Rename Position -> Index
2022-06-09 18:49:11 +09:00
Dan Balasescu
f0ef2e610e
Merge branch 'master' into dho
2022-06-09 18:29:14 +09:00
Dan Balasescu
bc7262a3dd
Merge pull request #18627 from Joehuu/always-show-mod-selector-beatmap-info
...
Always show mod selector on beatmap info leaderboards regardless of supporter
2022-06-09 18:18:12 +09:00
Dan Balasescu
6e450b7350
Explicitly handle operation cancelled exceptions
2022-06-09 14:35:53 +09:00
Dan Balasescu
ec03dc16db
Don't trigger notification when user quit
2022-06-09 14:13:14 +09:00
Dan Balasescu
bfde334e77
Allow beatmaps to load endlessly when entering Player
2022-06-09 14:03:21 +09:00
Dan Balasescu
85c85f37c6
Merge pull request #18622 from jai-x/chat-timestamp-colour
...
Enable nullable types in `ChatLine` and update timestamp colours to match design
2022-06-09 11:39:51 +09:00
Dean Herbert
8879c59b36
Merge pull request #18623 from LittleEndu/new-me-recommender
...
Use new own profile statistics in difficulty recommender
2022-06-09 11:11:21 +09:00
Dan Balasescu
ace03a3c1a
Merge pull request #18620 from peppy/channel-manager-always-has-api
...
Ensure `ChannelManager` has access to API from point of construction
2022-06-09 11:03:13 +09:00
Joseph Madamba
f3371e8bc8
Always show mod selector on beatmap info leaderboards regardless of supporter
2022-06-08 13:22:49 -07:00
Endrik Tombak
c90b285861
Change variable name and inline it
2022-06-08 21:10:27 +03:00
Endrik Tombak
bf67b35ade
Use new own profile statistics in difficulty recommender
2022-06-08 17:44:57 +03:00
Jai Sharma
c2ed41d097
Remove CanBeNull
specification from DI attributes
2022-06-08 15:10:19 +01:00
Jai Sharma
04b434b8ce
Update ChatLine
timestamp and message colours
2022-06-08 14:04:01 +01:00
Jai Sharma
dfa31df2af
Use #nullable enable
in ChatLine
2022-06-08 14:04:01 +01:00
Dean Herbert
c22bffaa01
Fix filter failure when no collection is selected
2022-06-08 19:30:18 +09:00
Dean Herbert
187086e4ec
Merge pull request #18609 from ALANVF/settings-delete-skin
...
Add button to delete the current skin
2022-06-08 19:18:59 +09:00
Dean Herbert
c661f2b059
Ensure ChannelManager
has access to API from point of construction
...
Closes https://github.com/ppy/osu/issues/18451 .
2022-06-08 19:15:23 +09:00
Dean Herbert
42cd7d9e6e
Change CollectionManager
to only store MD5 hashes instead of full BeatmapInfo
2022-06-08 18:23:09 +09:00
Dan Balasescu
f8594acb1d
Cleanup dialog implementation
2022-06-08 18:17:43 +09:00
Dean Herbert
cf438b1a44
Add index on MD5Hash
property
...
Reduces actual query overhead significantly
2022-06-08 18:01:55 +09:00
Dan Balasescu
3a90aa0b9b
Fix code styling
2022-06-08 17:57:59 +09:00
Dean Herbert
5157a78ae6
Isolate nested sample screens from main game to avoid toolbar interactions
2022-06-08 16:53:06 +09:00
Dan Balasescu
c43670fcd9
Merge pull request #18603 from peppy/fix-import-dialog
...
Add placeholder when no results are visible at song select
2022-06-08 15:22:31 +09:00
Dean Herbert
3b46787e06
Merge pull request #18496 from smoogipoo/multiplayer-leaderboard-user-mods-2
...
Support mod/ruleset combinations in multiplayer gameplay leaderboard
2022-06-08 14:58:13 +09:00
Dean Herbert
eee79c9531
Merge pull request #18610 from jai-x/refactor-chat-line
...
Refactor `ChatLine` and fix `DrawableChannel` flow padding
2022-06-08 13:54:53 +09:00
Dean Herbert
cd649f7d97
Merge branch 'master' into multiplayer-leaderboard-user-mods-2
2022-06-08 13:39:42 +09:00
Salman Ahmed
830ff66688
Fix message notifier not handling unresolved PM channels
2022-06-08 04:31:31 +03:00
theangryepicbanana
6c05329144
Close #5820 (Ability to delete a single skin)
2022-06-07 18:01:40 -04:00
Jai Sharma
2f635fa854
Refactor ChatLine
and fix DrawableChannel
flow padding
...
Refactors `ChatLine` component to use more sensible override properties
and layout using grid container. Moves creation of username component
into its own method to simplify BDL.
Updates padding of base `DrawableChannel` flow padding.
Removes usage of `ChatOverlayDrawableChannel` since it's overrides are
no longer needed.
Updates usage of `StandAloneChatDisplay` to use new override properties
of `DrawableChannel`.
2022-06-07 22:35:45 +01:00
Dean Herbert
b924aa3296
Fix tests failing when run headless
2022-06-08 00:36:19 +09:00
Dean Herbert
228683e956
Fix nullability of dialogOverlay
dependency
2022-06-07 23:48:34 +09:00
Dean Herbert
2e0b888410
Fix song select carousel invalidating every frame during global overlay dimming
2022-06-07 23:46:53 +09:00
Dean Herbert
9da99a0ddf
Rename to latency certifier
2022-06-07 23:34:55 +09:00
Dean Herbert
1a1dfaeae6
Update framework
2022-06-07 23:27:59 +09:00
Dean Herbert
95dea00725
Tidy up code and namespaces
2022-06-07 23:10:08 +09:00
Dean Herbert
058760253a
Add test coverage of certification flow
2022-06-07 23:02:15 +09:00
Dean Herbert
c1ef59ab03
Add more comprehensive certification flow (and remove "difficulty" terminology)
2022-06-07 22:52:24 +09:00
Dean Herbert
0561e9cc75
Fix mouse focus not always working
2022-06-07 20:45:37 +09:00
Dean Herbert
f2524fc3d7
Increase separator width
2022-06-07 20:42:19 +09:00
Dean Herbert
60d7060baa
Add tab focus support
2022-06-07 20:28:42 +09:00
Dean Herbert
00a6cbe53f
Allow using J/K to move box as well
2022-06-07 20:03:49 +09:00
Dean Herbert
146225d87e
Fix multiple issues with layout and text
2022-06-07 20:02:26 +09:00
Dean Herbert
43a04010a7
Add display of polling rate
2022-06-07 19:43:33 +09:00
Dean Herbert
2e7a966218
Add proper frame rate limiting and fix mouse cursor missing at results
2022-06-07 19:31:56 +09:00
Dean Herbert
c0e88d9577
Add better messaging and pass/fail cutoff
2022-06-07 19:06:54 +09:00
Dean Herbert
3fc8ac0ec7
Add key bindings everywhere
2022-06-07 18:27:42 +09:00
Dean Herbert
a175defefd
Add difficulty levels
2022-06-07 18:11:54 +09:00
Dean Herbert
3bd8bbd297
Add explanatory text
2022-06-07 17:36:34 +09:00
Dean Herbert
c323c67d7d
Allow increasing confidence by playing longer
2022-06-07 17:28:31 +09:00
Dean Herbert
20cfa5d83f
Add button to access latency comparer from game
2022-06-07 17:28:31 +09:00
Dean Herbert
0adeccbf03
Add full latency testing flow
2022-06-07 17:28:31 +09:00
Dean Herbert
f8524c3af4
Use VisibilityContainer
to avoid too many animations triggering
2022-06-07 17:25:06 +09:00
Dean Herbert
a04af1ca5f
Enable nullable and add hinting at convert filter criteria
2022-06-07 17:25:06 +09:00
Dean Herbert
0d32c94104
Add initial implementation of beatmap carousel no-results-placeholder
2022-06-07 17:25:06 +09:00
Dean Herbert
df9174ec00
Remove import popup dialog from song select
...
This has been replaced in spirit by the first run overlay.
2022-06-07 16:45:27 +09:00
Dan Balasescu
476a05cafb
Merge pull request #18599 from hlysine/fix-score-panel-diff-name-overflow
...
Truncate difficulty name in score panel
2022-06-07 14:16:02 +09:00
Dan Balasescu
561a932d17
Merge pull request #18587 from peppy/skin-editor-fix-sizing
...
Fix skin editor not accounting for aspect ratios in base-game sizing logic
2022-06-07 13:19:50 +09:00
Henry Lin
ef5d601f67
Fix difficulty name overflow in score panel
2022-06-07 12:05:03 +08:00
Dan Balasescu
f576d53aed
Update some unmatching strings
2022-06-07 11:54:41 +09:00
Dan Balasescu
0bfbfc6411
Update package
2022-06-07 11:51:24 +09:00
Dan Balasescu
86b685f7e4
Merge pull request #18589 from peppy/skin-bool-parsin
...
Change `skin.ini` boolean parsing to match osu!stable
2022-06-07 10:11:07 +09:00
Dean Herbert
46eba86ad1
Remove unintended left-over invalidation code
2022-06-07 09:29:30 +09:00
Bartłomiej Dach
4df7711af8
Merge branch 'master' into volume-metre-keyboard-fix
2022-06-06 23:45:42 +02:00
Bartłomiej Dach
f7ae156bb5
Merge branch 'master' into skin-editor-null-ref-on-game-exit
2022-06-06 21:49:13 +02:00
Dean Herbert
3b4b35c51e
Remove unnecessary string interpolation
2022-06-06 20:18:57 +09:00
Dean Herbert
f96340e37d
Improve messaging of deletion progress / completion
2022-06-06 20:18:32 +09:00
Dean Herbert
b104b7a90d
Rename method to mention "all"
2022-06-06 20:12:20 +09:00
Dean Herbert
da000ee5f0
Centralise video file extensions
2022-06-06 20:11:43 +09:00
Dean Herbert
cb383d4bdc
Merge branch 'master' into delete-all-beatmap-videos-sbs
2022-06-06 20:08:05 +09:00
Dean Herbert
3862681d94
Change skin.ini
boolean parsing to match osu!stable
...
Closes https://github.com/ppy/osu/issues/18579 .
2022-06-06 19:43:09 +09:00
Dean Herbert
44400142e2
Merge pull request #18584 from smoogipoo/fix-spectating-combo
...
Fix combo starting at 0 when spectating
2022-06-06 19:16:47 +09:00
Dean Herbert
734636299e
Merge pull request #18567 from jai-x/update-dayseparator
...
Update `DaySeparator` to use new design throughout
2022-06-06 19:15:43 +09:00
Dean Herbert
a8764b67e1
Add padding and avoid using invalidation (triggers too often when toolbar is being toggled)
2022-06-06 18:28:56 +09:00
Dean Herbert
28c9c61f71
Fix potential null reference in skin editor if target screen is null (during exit)
...
```csharp
[runtime] 2022-06-06 09:24:31 [verbose]: Host execution state changed to
Stopping
[runtime] 2022-06-06 09:24:31 [error]: An unhandled error has occurred.
[runtime] 2022-06-06 09:24:31 [error]: System.NullReferenceException:
Object reference not set to an instance of an object.
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Game.Skinning.Editor.SkinEditorOverlay.setTarget(OsuScreen target)
in
/Users/dean/Projects/osu/osu.Game/Skinning/Editor/SkinEditorOverlay.cs:line
173
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Threading.Scheduler.Update()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Graphics.Drawable.UpdateSubTree()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
```
2022-06-06 18:27:54 +09:00
Dean Herbert
003a3de270
Adjust transitions to look better
2022-06-06 18:06:46 +09:00
Dean Herbert
cd0e0fe70f
Fix skin editor not accounting for aspect ratios in base-game sizing logic
2022-06-06 18:02:42 +09:00
Dan Balasescu
6351f652a2
Fix combo starting at 0 when spectating
2022-06-06 17:56:25 +09:00
Dean Herbert
7facbc9b28
Merge branch 'master' into multiplayer-test-clone-room
2022-06-06 13:47:16 +09:00
Dean Herbert
f1af3205ca
Update framework
2022-06-05 13:15:05 +09:00
Dan Balasescu
b897e1464f
Merge pull request #18462 from frenzibyte/fix-timeline-zooming
...
Fix timeline objects disappearing prematurely on wide-screens
2022-06-05 11:49:44 +09:00
Jai Sharma
c0aaeff2b3
Update DaySeparator
to use new design throughout
...
Moves `DaySeparator` chat component to it's own file and update it to
match new chat design. Makes use of several virtual attributes that can
be overridden to update spacing and layout in other usage contexts.
Remove redundant usage of `ChatOverlayDaySeparator`, since the new
design is now part of the base class.
Create `StandAloneDaySeparator` to use in `StandAloneChatDisplay` which
overrides attributes to match correct spacing and layout for its design.
Ensure that `DrawableChannel.CreateDaySeparator` returns type of
`DaySeparator` instead of `Drawable`.
2022-06-04 18:02:14 +01:00
Dean Herbert
8ad588d927
Update framework
2022-06-04 22:12:53 +09:00
Dean Herbert
4d0c3fcee2
Merge pull request #18556 from frenzibyte/default-legacy-spinner-approach-circle
...
Fix spinner approach circle displaying on default legacy skin
2022-06-04 15:30:34 +09:00
Joseph Madamba
30cf6bffad
Add tooltips to beatmap card icon pills
2022-06-03 21:41:52 -07:00
Joseph Madamba
4b54fedd88
Add back hide common string using new ToSentence()
extension method
2022-06-03 20:09:20 -07:00
Joseph Madamba
58c8562cb0
Fix username placeholder text casing and missing localisation on registration form
2022-06-03 20:09:20 -07:00
Joseph Madamba
b342aad24a
Revert/fix some incorrectly used sorting localisation
2022-06-03 19:56:33 -07:00
Salman Ahmed
045e044637
Expose LegacySkinTransformer
's underlying skin for pattern-matching
2022-06-04 01:14:42 +03:00
Dean Herbert
d0e098fbcd
Allow using arrow keys to navigate volume controls when controls are already visible
2022-06-04 01:04:46 +09:00
Dean Herbert
712253a35b
Make non-localisable strings in VolumeMeter
verbatim
2022-06-04 01:04:23 +09:00
Dean Herbert
64616a6d73
Remove completely gimped implementation in VolumeMeter
2022-06-04 00:18:54 +09:00
Jamie Taylor
396a566a0e
Add some randomness to click samples
2022-06-03 22:33:11 +09:00
Jamie Taylor
6115275bc2
Use 'default' sampleset for toolbar and repurpose 'toolbar' select sample temporarily
2022-06-03 22:33:06 +09:00
Jamie Taylor
2878bb592f
Use more appropriate sounds for certain components
2022-06-03 22:32:12 +09:00
Jamie Taylor
365819865e
Remove 'submit' sample usages
2022-06-03 22:31:35 +09:00
Dean Herbert
f68df1518f
Merge branch 'master' into multiplayer-test-clone-room
2022-06-03 22:29:39 +09:00
Dan Balasescu
fcf51a6f51
Merge pull request #18530 from peppy/add-cloen-button
...
Change text on timing group add button when it is going to clone instead
2022-06-03 22:23:04 +09:00
Dan Balasescu
725a4dd9f4
Merge pull request #18545 from peppy/web-request-canceled-fix
...
Fix web requests potentially being performed after cancelled
2022-06-03 21:32:24 +09:00
Dan Balasescu
3df4d1b0e6
Fix incorrect HasPassword value for returned rooms
2022-06-03 21:17:48 +09:00
Dan Balasescu
06ac3c1ad3
Make MultiplayerClient update CurrentPlaylistItem
2022-06-03 21:17:23 +09:00
Dan Balasescu
41ff170b60
Fix playlist IDs not being returned
2022-06-03 21:12:09 +09:00
Dan Balasescu
77289c7224
Fix inability to serialise-then-deserialise playlist items
2022-06-03 20:36:12 +09:00
Dan Balasescu
68337df643
Fix tests by creating a score processor
2022-06-03 20:04:20 +09:00
Dan Balasescu
5245995689
Use IsNotNull() helper
2022-06-03 19:50:21 +09:00
Dan Balasescu
646f5f0f33
Isolate "server-side" multiplayer rooms in testing
2022-06-03 19:17:34 +09:00
Dan Balasescu
2aabcf51ae
Update framework again
2022-06-03 18:47:19 +09:00
Dean Herbert
514dffd49a
Merge pull request #18544 from frenzibyte/macos-borderless-default-mode
...
Change default window mode to "Borderless" on macOS
2022-06-03 18:18:53 +09:00
Dean Herbert
debd1a59b0
Merge pull request #18539 from frenzibyte/repeating-button-behaviour
...
Share repeat implementation in `TimingAdjustButton` for timeline zoom buttons
2022-06-03 18:18:23 +09:00
Dan Balasescu
1c738e22ae
Merge pull request #18523 from peppy/tap-button
...
Add tap for BPM button
2022-06-03 18:11:10 +09:00
Dean Herbert
cd3edc869c
Remove unnecessary nesting of IconButton
and update design a touch
2022-06-03 17:00:00 +09:00
Salman Ahmed
cd999cf7ac
Fix back-to-front conditional
2022-06-03 10:51:20 +03:00
Salman Ahmed
7b28451e3d
Improve warning message for user
2022-06-03 10:50:52 +03:00
Dean Herbert
e779b460e4
Use Component
instead of CompositeDrawable
2022-06-03 16:49:08 +09:00
Salman Ahmed
3ad1180c48
Use macOS
instead of IsApple
for better safety
2022-06-03 10:32:59 +03:00
Salman Ahmed
1a835f0622
Add warning note when running fullscreen on macOS
2022-06-03 10:32:59 +03:00
Dean Herbert
54a32bde44
Don't report sentry errors from builds targetting a different server
2022-06-03 16:29:55 +09:00
Dean Herbert
eb2d822530
Fix web requests potentially being performed after cancelled
...
Closes https://github.com/ppy/osu/issues/18524 .
2022-06-03 16:04:52 +09:00
Dean Herbert
1af51a2b19
Update framework
2022-06-03 16:00:42 +09:00
Dan Balasescu
f1169af627
Merge pull request #18541 from peppy/update-realm
...
Update realm to latest version
2022-06-03 15:53:44 +09:00
Salman Ahmed
6cb8b2d6f4
Set default window mode to "Borderless" rather than "Fullscreen" on macOS
2022-06-03 09:37:21 +03:00
Salman Ahmed
3aa8bc933d
Add sentry tag for selected beatmap
2022-06-03 08:21:35 +03:00
Dean Herbert
1b4c89c418
Update realm to latest version
...
Contains minor changes to async usage in line with upstream API changes.
I believe a feedback issue we were seeing with offset changes (the only
component using async write flow) may have been resolved by these
upstream changes (see [release
notes](https://github.com/realm/realm-dotnet/releases/tag/10.14.0 )) but
am not investigating further just yet.
2022-06-03 14:16:10 +09:00
Dean Herbert
678229fdab
Merge pull request #18536 from bdach/safe-file-chooser-textbox-disposal
...
Improve safety of file chooser textbox disposal
2022-06-03 13:50:41 +09:00
Dan Balasescu
dd93fc283b
Merge pull request #18531 from peppy/track-groups-better
...
Improve group tracking logic to avoid switching which point type unnecessarily
2022-06-03 13:04:54 +09:00
Salman Ahmed
b51e0a5047
Share button repeating logic with TimelineButton
for better UX
2022-06-03 05:23:49 +03:00
Salman Ahmed
efbde06c11
Split button repeating logic from TimingAdjustButton
to own component
2022-06-03 05:23:49 +03:00
Salman Ahmed
21385655fe
Fix ZoomableScrollContainer
not updating on parent size changes
2022-06-03 02:34:10 +03:00
Salman Ahmed
60fb5d5e6c
Revert "Fix timeline objects disappearing prematurely on wide-screens"
...
This reverts commit 02baf9a97a
.
2022-06-03 02:03:04 +03:00
Salman Ahmed
8471b24659
Merge branch 'master' into fix-timeline-zooming
2022-06-03 02:00:09 +03:00
Bartłomiej Dach
87ec2e490d
Merge branch 'master' into deselect-control-group
2022-06-03 00:47:06 +02:00
Bartłomiej Dach
8523083b2b
Merge branch 'master' into fix-add-new-timing-crash
2022-06-03 00:14:33 +02:00
Bartłomiej Dach
59ffc8b08e
Merge branch 'master' into multiplayer-leaderboard-user-mods-2
2022-06-02 20:45:10 +02:00
Bartłomiej Dach
cf9b78ea2a
Improve safety of FileChooserLabelledTextBox
disposal
2022-06-02 20:38:14 +02:00
Bartłomiej Dach
ec24b32fa6
Add NRT coverage for FileChooserLabelledTextBox
2022-06-02 20:36:28 +02:00
Bartłomiej Dach
d3f217cbdf
Merge branch 'master' into scoreprocessor-cleanup
2022-06-02 18:23:35 +02:00
Dean Herbert
ad3c093a08
Improve group tracking logic to avoid switching which point type unnecessarily
2022-06-02 18:33:09 +09:00
Dean Herbert
2fa4d46f73
Change text on timing group add button when it is going to clone instead
...
Also disables the button when it would otherwise have no effect.
2022-06-02 18:28:16 +09:00
Dean Herbert
0b125ade4c
Allow clicking away to deselect the current control point group
2022-06-02 18:18:18 +09:00
Dean Herbert
5a0f716bf2
Fix timing screen crash when attempting to add group to self
...
Closes #18527 .
2022-06-02 18:14:28 +09:00
Dean Herbert
ee4beefd95
Increase max taps to 128 for now
...
Will revisit this in the future with a more sound algorithm.
2022-06-02 17:27:52 +09:00
Dean Herbert
e75609dfb9
Increase taps to consider for better results for longer tap periods
2022-06-02 17:03:48 +09:00
Dean Herbert
4abfb35611
Improve light rotational alignment and increase light count to 8
2022-06-02 16:58:14 +09:00
Dan Balasescu
773ba97117
Add xmldoc to ScoringValues
2022-06-02 16:39:51 +09:00
Dan Balasescu
a638392e81
Rename member
2022-06-02 16:35:50 +09:00
Dan Balasescu
055845d4f5
Throw exception on access before ApplyBeatmap()
2022-06-02 16:34:45 +09:00
Dean Herbert
5bd9d88219
Fix tutorial download state not matching correctly when already available locally
...
Closes https://github.com/ppy/osu/issues/18468 .
This doesn't stop the tutorial from downloading a second time, but at
least displays the correct status afterwards. Avoiding the download is a
bit more involved and requires a change to the flow. Probably not worth
it just yet.
To test, recommend switching to production environment, as dev server
doesn't have correct metadata for tutorial resulting in weirdness.
2022-06-02 16:34:24 +09:00
Dean Herbert
5adbf85654
Merge pull request #18422 from smoogipoo/detect-exclusive-fullscreen
...
Detect exclusive fullscreen on Windows
2022-06-02 15:13:02 +09:00