Bartłomiej Dach
c6099edb88
Rename test to match class
2023-07-25 22:18:31 +02:00
Dean Herbert
9cfe9164fa
Add helper method to get drain length (and rename some usages)
2023-07-25 16:58:41 +09:00
Bartłomiej Dach
2df6e91176
Add extra test coverage for breaks before first/after last object
2023-07-22 17:12:35 +02:00
NiceAesth
ce78bb549f
Add test for multiple too early objects in break
2023-07-20 00:32:54 +03:00
NiceAesth
b3974b34e7
Test break checks
2023-07-16 23:03:30 +03:00
NiceAesth
3888471148
Add break length and bounds checks
2023-07-16 23:03:21 +03:00
Bartłomiej Dach
a1da0b58db
Improve negative test case without breaks too
2023-07-11 23:22:37 +02:00
Bartłomiej Dach
d927cb3f1c
Actually cover cases with breaks in tests
2023-07-11 23:21:03 +02:00
Bartłomiej Dach
9a3cb624a8
Rewrite tests to be less aggressively DRY
...
Four of six helper methods defined in the test were used exactly once;
the remaining two were used two times. Splitting helpers there is just
too much.
2023-07-11 23:18:52 +02:00
NiceAesth
d75887bb3b
Apply feedback to tests
2023-07-11 13:40:27 +03:00
NiceAesth
c972a4195c
Add tests
2023-07-10 17:29:59 +03:00
Bartłomiej Dach
079e687bee
Fix incorrect mock setup after refactor
2023-06-08 10:09:27 +02:00
Dean Herbert
a842f79ad4
Refactor IWorkingBeatmap.Background to GetBackground()
2023-06-08 16:19:32 +09:00
OliBomby
a6e780a1b9
Update CheckMutedObjectsTest.cs
2023-04-29 23:52:30 +02:00
OliBomby
354cd23874
removed all usage of hitobject's DifficultyControlPoint
2023-04-26 18:17:02 +02:00
Dean Herbert
b0131db1dc
Update test assertions in line with new state saving logic
2023-02-08 15:55:17 +09:00
Dean Herbert
3345e34544
Move beatmap specific logic out of EditorChangeHandler
2023-02-03 17:53:54 +09:00
cdwcgt
209bc3c1ed
remove useless setup
2023-02-01 11:53:26 +08:00
cdwcgt
5afb733fb2
change IssueTemplatePreviewTimeConflict's text
2023-01-23 15:26:28 +09:00
cdwcgt
997a1a8b02
add test for CheckPreviewTime
2023-01-19 01:08:56 +09:00
ansel
03ac2fd7d7
More tests
2023-01-12 03:33:20 +03:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Dean Herbert
e02c477008
Merge pull request #21017 from andy840119/remove-nullable-disable-in-the-checks
...
Remove nullable disable in the checks.
2022-11-06 18:39:03 +09:00
andy840119
e862ba5e04
Fix the wrong AsNonNull() usage.
2022-11-05 20:13:50 +08:00
andy840119
6062641bf4
Mark mock track as nun-nullable because technically it should not accept the null track.
2022-11-05 16:17:20 +08:00
andy840119
5931e965c5
Mark background prams in the getMockWorkingBeatmap() as nun-nullable because technically it should not accept the null background.
2022-11-05 16:16:26 +08:00
Dean Herbert
29bc653d24
Remove incorrect double multiplication and add missing test coverage
2022-11-01 17:17:54 +09:00
Dean Herbert
d807d9d822
Add failing test covering snap calculations with SV applied
2022-11-01 16:22:48 +09:00
Dean Herbert
e8b7914295
Add test coverage of new parameter
2022-11-01 15:13:05 +09:00
andy840119
c8c76f2351
Use AsNonNull() because the type does not accept the null case.
2022-10-30 17:03:54 +08:00
andy840119
500bf90a34
Mark as accept the nullable stream.
2022-10-30 17:03:54 +08:00
andy840119
6ce3841686
Remove nullable disable annotation in the test case.
2022-10-30 17:03:54 +08:00
Dean Herbert
bace3df4ca
Update test assertions in line with change
2022-10-21 22:58:10 +09:00
Dean Herbert
a70fc10d06
Fix mock track construction failure
2022-09-02 16:30:04 +09:00
Dean Herbert
4b72e55770
Fix various test scenes not adding EditorClock to the draw hierarchy
2022-08-26 18:08:43 +09:00
Dean Herbert
1270ee9624
Update multiple tests to use new assert output for easier to understand failures
2022-08-09 19:19:54 +09:00
Dan Balasescu
b4e55f7309
Apply IRenderer changes
2022-08-02 19:50:57 +09:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Dean Herbert
977e6d8a80
Add xmldoc for IDistanceSnapProvider and related properties
2022-05-05 16:25:45 +09:00
Salman Ahmed
fef94d49f4
Revert "Convert data type of DistanceSpacing to float"
...
This reverts commit 7aaa88cac2
2022-04-29 08:02:07 +03:00
Salman Ahmed
abb88b0907
Move distance spacing application to DistanceSnapGrid
2022-04-28 10:54:38 +03:00
Salman Ahmed
7aaa88cac2
Convert data type of DistanceSpacing to float
2022-04-28 10:24:36 +03:00
Salman Ahmed
71533808e9
Add test case for DistanceSpacingMultiplier in distance snapping test scene
2022-04-28 07:14:43 +03:00
Salman Ahmed
500322ff21
Update failing snap test scenes
2022-02-15 02:21:53 +03:00
Bartłomiej Dach
b978010b48
Remove unused allowMissing parameter in audio file check test
...
No longer used since 7f95400f46
2022-02-01 21:53:21 +01:00
Dean Herbert
b5f670cc5b
Add far too many fixes for ruleset non-nullable requirements
2022-01-12 23:24:11 +09:00
Dean Herbert
4f66e8f881
Fix issues with editor check tests
2022-01-12 16:39:36 +09:00
Joseph Madamba
7de43e3aba
Fix most open compound words in identifiers being closed
2021-12-27 20:26:28 -08:00
Dean Herbert
c7bc03e6f7
Add helper method for editor check tests
2021-11-24 14:22:41 +09:00
Dean Herbert
c2f8d9f677
Update tests which set Files lists directly
2021-11-24 14:00:14 +09:00
Naxesss
72ee2b1556
Refactor to avoid duplicate code
2021-11-10 06:18:40 +01:00
Naxesss
5dc6a9ed21
Add background stream closed test
2021-11-10 05:04:30 +01:00
Dean Herbert
d1e6d1cb98
Update some other missed incorrect null/empty usages
2021-11-04 14:50:43 +09:00
Dean Herbert
67d9590a79
Fix new inspections
2021-11-04 14:02:09 +09:00
smoogipoo
aa380a11c1
Merge branch 'master' into no-more-difficulty-control-points-info
2021-10-14 12:02:10 +09:00
Bartłomiej Dach
c7db286b94
Merge branch 'master' into file-sanity-checks
2021-10-14 00:17:29 +02:00
Dean Herbert
7f95400f46
Add proper stream disposal to tests
2021-10-12 11:04:41 +09:00
Naxesss
bb9cbd3e66
Undo disposal of Stream for use in mocking
...
Because the Stream object is accessed when the mocked object calls `GetStream`, we cannot close it here.
The resource should be released upon teardown anyway.
2021-10-12 00:35:58 +02:00
Naxesss
47b4d03145
Dispose of Streams when used
2021-10-12 00:13:38 +02:00
Naxesss
01d77fb741
Remove redundant Bass.Init call in test setup
2021-10-11 23:58:06 +02:00
smoogipoo
bc37cb6f43
Merge branch 'master' into no-more-difficulty-control-points-info
2021-10-08 18:41:17 +09:00
Dean Herbert
b339c149d8
Copy BaseDifficulty to Beatmap<T> and move all write operations across
2021-10-06 15:10:45 +09:00
Dean Herbert
1952ebece9
Update tests to use more correct control point definitions
2021-09-06 22:04:51 +09:00
Dean Herbert
b2a14b13dc
Update outdated tests
2021-09-03 17:11:12 +09:00
Dean Herbert
d4e5a612ea
Update IPositionalSnapProvider to take a HitObject as reference, rather than raw time
...
This allows fetching the correct `DifficultyControlPoint` from the
hitobject. Nothing more.
2021-09-03 17:11:12 +09:00
Dean Herbert
a3d9ab1e2e
Move approach rate to EffectControlPoint
2021-09-03 16:58:16 +09:00
Dean Herbert
9fae2c350d
Fix test regressions
2021-08-30 17:25:36 +09:00
Naxess
6da2a3d51f
Add zero-length objects check and tests
2021-07-13 10:50:11 +02:00
Naxess
c8f58cbf6c
Add audio in video check and tests
2021-07-13 04:17:41 +02:00
Naxess
a4a1919842
Add too short audio files check and tests
2021-07-13 03:46:45 +02:00
Naxess
0a8fd01b99
Add zero byte check and tests
2021-07-13 03:45:21 +02:00
Naxess
b58644106c
Add nested hitobject tests for few hitsounds check
2021-06-27 15:58:00 +02:00
Naxess
1dbac76da5
Use local variables for common sample lists
2021-06-27 15:57:41 +02:00
Naxess
1d5bff1660
Add concurrent hitobjects test for few hitsounds check
...
See https://github.com/ppy/osu/pull/13669#discussion_r659314980
2021-06-27 15:26:52 +02:00
Naxess
c2ceb83bbb
Move MockNestedHitObject to own class
2021-06-27 15:16:40 +02:00
Naxess
5642d321b7
Fix comments in few hitsounds check tests
2021-06-26 23:43:08 +02:00
Naxess
82b64f5589
Add hitsounded with break test
2021-06-26 19:57:12 +02:00
Naxess
a5abc664f3
Add few hitsounds check tests
2021-06-26 19:21:15 +02:00
Naxess
7b9569a117
Add muted object check tests
2021-06-26 19:21:01 +02:00
smoogipoo
e8bc2cac5b
Fix test not being marked as headless
2021-05-19 13:36:39 +09:00
smoogipoo
ab6a79f84c
Simplify
2021-05-18 19:15:46 +09:00
smoogipoo
97f4f7bbd1
Remove Component inheritance
2021-05-18 18:59:45 +09:00
smoogipoo
633f841a0f
Rename to HitObjectUsageEventBuffer
2021-05-18 18:57:02 +09:00
smoogipoo
a31a6947bb
Add test
2021-05-18 18:49:05 +09:00
Dean Herbert
9069db0743
Fix case of hitObjects variables
2021-05-14 16:22:19 +09:00
Naxess
9860e482af
Use TestWorkingBeatmap instead of null in tests
...
Fixes the warning that #12801 will give.
2021-05-14 05:32:52 +02:00
Naxess
94538b3842
Remove accidental whitespace
2021-05-13 12:56:36 +02:00
Naxess
19800f5f7f
Move IBeatmap arg into context
2021-05-13 11:24:22 +02:00
Naxess
c13b93e6f1
Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks
...
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
See next commit for example.
2021-05-12 02:29:18 +02:00
Naxess
200352b750
Rename unsnap check templates
2021-04-27 13:56:05 +02:00
Naxess
0f0870c8b8
Sort objects by time in concurrent check test
2021-04-27 00:36:26 +02:00
Naxess
ce258febf6
Rename CheckUnsnaps -> CheckUnsnappedObjects
...
Will potentially have `CheckUnsnappedKiai` or similar later, so this is worth specifying.
Also consistent with `CheckConcurrentObjects`, which will likely have a `CheckConcurrentLines` later.
2021-04-26 20:32:44 +02:00
Naxess
b8cdcf56c0
Add concurrent object check tests
2021-04-26 20:22:24 +02:00
Naxess
71f880aa94
Fix duplicate code in unsnap test
2021-04-26 17:44:46 +02:00
Naxess
9178aa1d7d
Add unsnap check tests
2021-04-26 04:48:56 +02:00
Naxess
c0318a4d3e
Fix usage of _ in Moq lambdas
2021-04-20 13:29:14 +02:00
Naxess
6a1e4ff99f
Add file hash to file presence test
...
Necessary because we now find the storage path of the file rather than just the file itself.
2021-04-20 13:28:32 +02:00
Naxess
2bb079ea14
Add audio quality check tests
2021-04-20 01:36:15 +02:00
Naxess
be6a02a17e
Simplify background quality test names
2021-04-20 01:32:22 +02:00
Naxess
8656176ab8
Add the playable beatmap as check argument
...
This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.
So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.
This should be preferred over `workingBeatmap.Beatmap`.
2021-04-20 01:31:51 +02:00
