h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 14:27:31 +08:00
Code Issues Releases Wiki Activity
42,127 Commits 3 Branches 653 Tags 366 MiB
8541e73fc1
Commit Graph

26692 Commits

Author SHA1 Message Date
Derrick Timmermans
69803105ef
Fix volume meter requesting focus for any action 2021-07-04 17:19:44 +02:00
Bartłomiej Dach
5e148b273e
Merge branch 'master' into fix-initial-volume-display-when-zero 2021-07-04 16:16:01 +02:00
Derrick Timmermans
14a861003a
Fix code quality errors 2021-07-04 16:06:28 +02:00
Derrick Timmermans
50c9e17e52
Return focus when using UP/DOWN on unfocused meter 2021-07-04 15:42:26 +02:00
Derrick Timmermans
d0707079b1
Remove unused method 2021-07-04 15:35:51 +02:00
Derrick Timmermans
e151c7ffd0
Let VolumeMeter request focus instead of taking it 2021-07-04 15:35:04 +02:00
Bartłomiej Dach
c143a50b73
Merge branch 'master' into fix-zero-hit-score-submit 2021-07-04 15:31:38 +02:00
Derrick Timmermans
d1553f0864
Implement ability to switch between volume meters 2021-07-04 14:47:07 +02:00
Bartłomiej Dach
3291f15dcc Mention GetForWrite() as another alternative to Context accesses 2021-07-04 12:08:15 +02:00
Bartłomiej Dach
b89521314f Mention alternatives to Context when not on update thread in xmldoc 2021-07-04 12:07:34 +02:00
Dean Herbert
3ec7dc3bb9 Update tests in line with thread safety check 2021-07-04 17:59:39 +09:00
Dean Herbert
7a710ceffe Check count as well (statistics can be populated with zero counts) 2021-07-04 16:41:09 +09:00
Dean Herbert
567e9f33a9 Fix thread safety of realm Refresh operation 
Due to the lack of locking, there was a chance the the update thread
`context` was retrieved just before the `flushContexts` call, followed
by `.Refresh()` being run while the blocking behaviour was invoked.

This can be seen in test failures such as
https://ci.appveyor.com/project/peppy/osu/builds/39859786/tests.

As an aside, I tried multiple different methods to avoid `lock()` on the
update thread but they felt flaky. The overhead of lock when there's no
contention is reportedly around 30-50ns, so likely not of concern. We
can address it at a later point if it becomes one.
 2021-07-04 16:24:43 +09:00
Dean Herbert
ef82528309 Don't attempt to submit score when nothing has been hit 2021-07-04 15:16:18 +09:00
Dean Herbert
149a200f34 Fix volume metre not correctly showing volume when initially zero 
Closes https://github.com/ppy/osu/issues/13761.
 2021-07-04 14:56:17 +09:00
Dean Herbert
ec71deec51 Remove some mentions of "lazer" 
I am aware there are more throughout the codebase but intentionally left
the remaining mentioned for one reason or another. The intention here is
to mainly change user-facing versioning to change the positioning of the
"lazer" term (to be where we would expect "cuttingedge" or "beta" to
be).
 2021-07-04 12:41:27 +09:00
PercyDan54
12371f7424
Fix playlist item displays as empty string if no unicode title is present 2021-07-04 08:09:38 +08:00
Bartłomiej Dach
8a23dfa6f5 Fix optimised import path buffering events without flush 2021-07-03 17:58:12 +02:00
Bartłomiej Dach
fbe3b447e5 Merge branch 'master' into linkify-metadata 2021-07-03 15:51:08 +02:00
Bartłomiej Dach
6fb8ed4d07 Trim no longer used constant 2021-07-03 15:47:47 +02:00
Dean Herbert
0be75cc4ed Fix incorrect base call causing import optimisation to not work 2021-07-03 22:35:46 +09:00
Bartłomiej Dach
7dae93ad66 Remove unused using directives 2021-07-03 15:23:26 +02:00
Bartłomiej Dach
16d08df5e2 Remove mention of direct from xmldoc 2021-07-03 15:22:03 +02:00
Salman Ahmed
83578e7c9d Hold a bound copy reference instead 2021-07-02 23:24:51 +03:00
Salman Ahmed
612ed6353c Resolve RestoreDefaultValueButton issue by internal management 2021-07-02 22:30:26 +03:00
Salman Ahmed
2b366e04fd Revert "Fix RestoreDefaultValueButton not behaving correctly on number types" 
This reverts commit bc0ab7dd4f.
 2021-07-02 21:06:57 +03:00
Dan Balasescu
ace57a9ee9
Merge pull request #13727 from peppy/update-disclaimer 
Update disclaimer
 2021-07-02 21:08:43 +09:00
Dan Balasescu
5a7706edee
Merge pull request #13726 from nekodex/notch-tick-sfx 
Add audio feedback for changing volume
 2021-07-02 21:08:31 +09:00
Dean Herbert
6e31c781bb
Merge pull request #13382 from ribbanya/clamp-skin-scale 
Fix skin elements flipping when scaled below zero
 2021-07-02 20:50:47 +09:00
Dan Balasescu
4d85df6bbc
Merge branch 'master' into notch-tick-sfx 2021-07-02 20:38:30 +09:00
Dean Herbert
66240d582f
Merge branch 'master' into consume-bindable-current-factory 2021-07-02 20:28:57 +09:00
Dean Herbert
b0f257fa04
Merge pull request #13685 from gagahpangeran/wiki-image-block 
Fix image overflow in wiki overlay
 2021-07-02 20:21:20 +09:00
Dean Herbert
8847915c6a Update framework 2021-07-02 18:51:14 +09:00
Dan Balasescu
9eb6ae4d45
Merge pull request #13721 from peppy/submit-on-player-exit 
Submit scores on player exit
 2021-07-02 18:25:26 +09:00
Dean Herbert
4e52aee5a0
Merge branch 'master' into wiki-image-block 2021-07-02 18:19:46 +09:00
Dean Herbert
f37e5bdab8
Merge pull request #13742 from aitani9/skin-editor-flipping-reflect 
Make flipping in the skin editor reflect across the axes of the selection box
 2021-07-02 18:19:04 +09:00
Dan Balasescu
211c248692
Merge pull request #13744 from peppy/fix-async-void-calls 
Fix some incorrectly invoked `async` calls
 2021-07-02 18:10:30 +09:00
Dean Herbert
362816492f Move to more friendly namespace 2021-07-02 18:09:16 +09:00
Dean Herbert
1bbf578dfe
Merge pull request #13714 from bdach/colour-picker 
Add osu!-styled colour picker control
 2021-07-02 18:05:19 +09:00
Dean Herbert
eacf867073 Move shared types into their own classes 2021-07-02 18:05:00 +09:00
Dean Herbert
ecb4982281 Add missing blank lines 2021-07-02 17:51:54 +09:00
Henry Lin
6a0c5b54c3 Fix obsolete message in Mod.Ranked 2021-07-02 15:55:25 +08:00
Dean Herbert
35f7966922 Merge conditionals in line with other case of same logic 2021-07-02 15:55:36 +09:00
Dean Herbert
63d2ac66d2 Fix one more instance of incorrect playback/frequency set order 2021-07-02 15:52:20 +09:00
Jamie Taylor
910fe3e9f8 Center pitch randomisation around base pitch 2021-07-02 15:51:23 +09:00
Dean Herbert
bd6664d541 Add note about intentional downward pitch, against expectations 2021-07-02 15:48:16 +09:00
Dean Herbert
13254d51fc Remove usage of bool for initial playback 
Also refactors the whole method to generally clean things up. One more
important fix is setting the frequency on the channel before starting
playback, so avoid the frequency potentially being adjusted after the
playback is already started.
 2021-07-02 15:48:13 +09:00
Dean Herbert
69b1347730 Tidy up weird bind logic 2021-07-02 15:29:51 +09:00
Dean Herbert
9814c24741 Merge branch 'master' into notch-tick-sfx 2021-07-02 15:27:28 +09:00
Dean Herbert
f2d9d78455 Fix some incorrectly invoked async calls 2021-07-02 14:43:48 +09:00
Dean Herbert
f689e788c9 Avoid using game-wide beatmap during score submission 2021-07-02 14:24:27 +09:00
Dean Herbert
0396a03bbc Rename Mod.Ranked back to avoid breaking ruleset API 2021-07-02 12:50:58 +09:00
Dean Herbert
62c125d7a2 Tidy up font formatting methods 2021-07-02 12:21:28 +09:00
Dean Herbert
f0727a63be Reduce usable width 2021-07-02 12:18:52 +09:00
Dean Herbert
a1eaf39645 Slightly change wording to hopefully read better 2021-07-02 12:15:16 +09:00
Bartłomiej Dach
083e463afd Use alternative hue slider nub design 2021-07-02 01:03:02 +02:00
Bartłomiej Dach
434c048d87 Merge branch 'master' into colour-picker 2021-07-02 01:03:00 +02:00
aitani9
9b0fa6d3fc Make flipping reflect across the axes of the selection box 2021-07-01 15:38:38 -07:00
Bartłomiej Dach
6c07f6fecf Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.7' into update-dependencies 2021-07-01 19:17:00 +02:00
Bartłomiej Dach
326a46fa84 Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.7' into update-dependencies 2021-07-01 19:16:23 +02:00
Bartłomiej Dach
7f6d6edc46 Merge remote-tracking branch 'upstream/dependabot/nuget/ppy.LocalisationAnalyser-2021.614.0' into update-dependencies 2021-07-01 19:16:16 +02:00
Bartłomiej Dach
8a581fcf7e Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-5.0.7' into update-dependencies 2021-07-01 19:16:11 +02:00
Bartłomiej Dach
c34ecc7492 Merge remote-tracking branch 'upstream/dependabot/nuget/Humanizer-2.11.10' into update-dependencies 2021-07-01 19:15:58 +02:00
Bartłomiej Dach
e6b9bcb90c Merge remote-tracking branch 'upstream/dependabot/nuget/HtmlAgilityPack-1.11.34' into update-dependencies 2021-07-01 19:14:27 +02:00
Bartłomiej Dach
503bf092c9 Merge remote-tracking branch 'upstream/dependabot/nuget/SharpCompress-0.28.3' into update-dependencies 2021-07-01 19:14:09 +02:00
Bartłomiej Dach
6f859d66f8 Merge remote-tracking branch 'upstream/dependabot/nuget/Sentry-3.6.0' into update-dependencies 2021-07-01 19:13:15 +02:00
dependabot[bot]
d0ae946cb6
Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack 
Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore) from 5.0.6 to 5.0.7.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.6...v5.0.7)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:38 +00:00
dependabot[bot]
f6234864cc
Bump Microsoft.AspNetCore.SignalR.Client from 5.0.6 to 5.0.7 
Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore) from 5.0.6 to 5.0.7.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.6...v5.0.7)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Client
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:33 +00:00
dependabot[bot]
fb2d08b9ee
Bump ppy.LocalisationAnalyser from 2021.608.0 to 2021.614.0 
Bumps [ppy.LocalisationAnalyser](https://github.com/ppy/osu-localisation-analyser) from 2021.608.0 to 2021.614.0.
- [Release notes](https://github.com/ppy/osu-localisation-analyser/releases)
- [Commits](https://github.com/ppy/osu-localisation-analyser/compare/2021.608.0...2021.614.0)

---
updated-dependencies:
- dependency-name: ppy.LocalisationAnalyser
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:29 +00:00
dependabot[bot]
e7c7b8512a
Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson 
Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore) from 5.0.6 to 5.0.7.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.6...v5.0.7)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:25 +00:00
dependabot[bot]
b320528eb5
Bump Humanizer from 2.10.1 to 2.11.10 
Bumps [Humanizer](https://github.com/Humanizr/Humanizer) from 2.10.1 to 2.11.10.
- [Release notes](https://github.com/Humanizr/Humanizer/releases)
- [Changelog](https://github.com/Humanizr/Humanizer/blob/main/release_notes.md)
- [Commits](https://github.com/Humanizr/Humanizer/compare/v2.10.1...v2.11.10)

---
updated-dependencies:
- dependency-name: Humanizer
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:22 +00:00
dependabot[bot]
71867337b6
Bump HtmlAgilityPack from 1.11.33 to 1.11.34 
Bumps [HtmlAgilityPack](https://github.com/zzzprojects/html-agility-pack) from 1.11.33 to 1.11.34.
- [Release notes](https://github.com/zzzprojects/html-agility-pack/releases)
- [Commits](https://github.com/zzzprojects/html-agility-pack/compare/v1.11.33...v1.11.34)

---
updated-dependencies:
- dependency-name: HtmlAgilityPack
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:15 +00:00
dependabot[bot]
e5e468e387
Bump SharpCompress from 0.28.2 to 0.28.3 
Bumps [SharpCompress](https://github.com/adamhathcock/sharpcompress) from 0.28.2 to 0.28.3.
- [Release notes](https://github.com/adamhathcock/sharpcompress/releases)
- [Commits](https://github.com/adamhathcock/sharpcompress/compare/0.28.2...0.28.3)

---
updated-dependencies:
- dependency-name: SharpCompress
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:11 +00:00
dependabot[bot]
c976854e24
Bump Sentry from 3.4.0 to 3.6.0 
Bumps [Sentry](https://github.com/getsentry/sentry-dotnet) from 3.4.0 to 3.6.0.
- [Release notes](https://github.com/getsentry/sentry-dotnet/releases)
- [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md)
- [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.4.0...3.6.0)

---
updated-dependencies:
- dependency-name: Sentry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:08 +00:00
dependabot[bot]
8ab9ea9926
Bump Realm from 10.2.0 to 10.2.1 
Bumps [Realm](https://github.com/realm/realm-dotnet) from 10.2.0 to 10.2.1.
- [Release notes](https://github.com/realm/realm-dotnet/releases)
- [Changelog](https://github.com/realm/realm-dotnet/blob/master/CHANGELOG.md)
- [Commits](https://github.com/realm/realm-dotnet/compare/10.2.0...10.2.1)

---
updated-dependencies:
- dependency-name: Realm
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:03 +00:00
Dean Herbert
48b36e8940
Merge branch 'master' into star-difficulty-range-display 2021-07-01 22:51:42 +09:00
Dean Herbert
153814626c
Merge pull request #13724 from smoogipoo/update-sr-colours 
Update SR colours to match osu-web
 2021-07-01 22:51:23 +09:00
Dean Herbert
f1c11243e9 Update resources 2021-07-01 22:06:59 +09:00
Jamie Taylor
dad28b2826
Update OsuSliderBar to use new notch-tick sample and tweak pitch ramping 2021-07-01 20:55:55 +09:00
Jamie Taylor
68c5e6a431
Add audio feedback to changing volume 2021-07-01 20:55:04 +09:00
smoogipoo
4c95af4b16 Add star rating range display 2021-07-01 20:35:31 +09:00
Dean Herbert
4c1b8bc427 Update disclaimer 2021-07-01 20:23:12 +09:00
Dean Herbert
0522500a57 Fix a couple of merge oversights 2021-07-01 19:45:17 +09:00
Dean Herbert
31dbc7798b Merge branch 'master' into linkify-metadata 2021-07-01 19:41:33 +09:00
smoogipoo
a78d1b4c2e Update SR colours to match osu-web 2021-07-01 19:37:21 +09:00
Dean Herbert
3816c486d5 Guard against a potential startup crash if user's preferred ruleset has a compatibility issue 
Resolves this issue seen at https://github.com/ppy/osu/issues/13722#issuecomment-872088071.
 2021-07-01 19:03:58 +09:00
Dean Herbert
82fd8b13df
Merge pull request #13720 from Game4all/localise-dashboard-friends 
Localise friends view in dashboard overlay
 2021-07-01 18:20:18 +09:00
Dean Herbert
74c63e15be Mark score failed on fail and exit 2021-07-01 17:48:09 +09:00
Dean Herbert
b00ee67895 Remove excess whitespace 2021-07-01 17:25:47 +09:00
Dean Herbert
04b874bb00 Add flow for submitting score on exiting SubmittingPlayer 2021-07-01 17:02:33 +09:00
Dean Herbert
5bc970af0d Make TestPlayer inherit from SoloPlayer for more flexibility in testing 2021-07-01 16:55:33 +09:00
Bartłomiej Dach
583242d96d Add osu!-styled colour picker control 2021-06-30 23:25:50 +02:00
Lucas A
939b2baafe Localise overlay "Scroll to top" button. 2021-06-30 22:19:04 +02:00
Lucas A
8da6ecf6a9 Localise OverlayPanelDisplayStyle tab control. 2021-06-30 21:28:07 +02:00
Lucas A
f2287ba022 Localise friends online status stream control. 2021-06-30 21:16:21 +02:00
Lucas A
285c49be7e Localise dashboard overlay header. 2021-06-30 20:28:27 +02:00
Dean Herbert
00d3baef11 Exit handling flow 2021-06-30 20:23:48 +09:00
Dean Herbert
57a21dfb1c Update framework 2021-06-30 16:11:18 +09:00
Dean Herbert
4a71a4bb21
Merge pull request #13450 from smoogipoo/spectator-start-at-end-2 
Start spectator at the end of gameplay
 2021-06-30 16:09:35 +09:00
Dean Herbert
094cd31361
Merge pull request #13441 from frenzibyte/ruleset-resources-skin 
Provide access to ruleset resources during `ISkinSource` lookups
 2021-06-30 15:26:37 +09:00
Dean Herbert
a019f2cc5c
Merge branch 'master' into rework-multiplayer-test-scenes 2021-06-30 13:49:05 +09:00
Salman Ahmed
bc0ab7dd4f Fix RestoreDefaultValueButton not behaving correctly on number types 2021-06-29 23:39:46 +03:00
Dean Herbert
825181121d
Merge branch 'master' into spectator-start-at-end-2 2021-06-30 01:50:14 +09:00
Dean Herbert
5031707048
Merge pull request #13690 from smoogipoo/fix-action-posting 
Fix commands posted to the wrong channel
 2021-06-30 00:39:02 +09:00
smoogipoo
6dd3c6fe93 Make MultiSpectatorScreen and tests more resillient to timing 2021-06-29 22:45:51 +09:00
Gagah Pangeran Rosfatiputra
3a002e357a
rename method 2021-06-29 19:28:21 +07:00
Dean Herbert
2f1203085b Also add logging of realm block/flush operations 2021-06-29 20:23:25 +09:00
Dean Herbert
9acc5e38bb Add basic logging for osu! storage migration 
When looking into the test failure at https://github.com/ppy/osu/runs/2940065457, it became apparent that we are not showing the migration process anywhere in logs. It's the cause of many issues, and we would want to see this in CI and user logs when occurring.
 2021-06-29 20:23:25 +09:00
smoogipoo
bfdbe3c3fe Fix clocks getting added a second time 2021-06-29 17:29:25 +09:00
smoogipoo
8e04d73b67 Merge branch 'rework-multiplayer-test-scenes' into spectator-start-at-end-2 2021-06-29 17:06:57 +09:00
smoogipoo
ca0eaab8e2 Add test 2021-06-29 16:30:46 +09:00
smoogipoo
7a86686f40 Make nullable 2021-06-29 16:30:40 +09:00
smoogipoo
9132c42f87 Fix actions posted to the wrong channel 2021-06-29 15:58:07 +09:00
smoogipoo
bcdf36e77b Merge branch 'master' into spectator-start-at-end-2 2021-06-29 15:53:58 +09:00
smoogipoo
92fa99700e Merge branch 'master' into rework-multiplayer-test-scenes 2021-06-29 15:39:59 +09:00
smoogipoo
a3b1e1d5fc Check for null ruleset in FilterCriteria 2021-06-29 15:18:40 +09:00
Gagah Pangeran Rosfatiputra
d88d264491
prevent image sprite exceed its parent width 2021-06-29 09:49:45 +07:00
Dan Balasescu
697b07acb1
Merge branch 'master' into fix-beatmap-import-fk-failure 2021-06-29 11:36:31 +09:00
Dan Balasescu
471bf9a752
Merge pull request #13681 from peppy/score-submit-ruleset-id 
Serialise and send ruleset ID as part of score submission
 2021-06-29 11:27:13 +09:00
Dean Herbert
e4ca6a4266 Serialise and send ruleset ID as part of score submission 2021-06-29 01:55:09 +09:00
Gagah Pangeran Rosfatiputra
e58f690210
centering image sprite 2021-06-28 21:09:00 +07:00
Gagah Pangeran Rosfatiputra
2b8d41c045
add BlockImageContainer 
change from AutoSize Both to AutoSize Y and RelativeSize X
 2021-06-28 21:04:56 +07:00
Gagah Pangeran Rosfatiputra
1c074ff018
add BlockMarkdownImage 
change from AutoSize Both to AutoSize Y and RelativeSize X
 2021-06-28 21:04:13 +07:00
Dan Balasescu
a9084db665
Merge pull request #13673 from peppy/import-early-checksum-abort 
Shortcut import process to speed up duplicate imports
 2021-06-28 19:55:09 +09:00
Dan Balasescu
8950757b61
Merge pull request #13618 from peppy/fix-realm-state-change-crashes 
Fix realm threading issues to make it releaseable
 2021-06-28 19:54:49 +09:00
Dan Balasescu
92fcf90768
Merge branch 'master' into import-early-checksum-abort 2021-06-28 19:29:08 +09:00
Salman Ahmed
66fc95c111 Use LastOrDefault instead 2021-06-28 12:43:58 +03:00
Salman Ahmed
7197998a10 Remove resolution to SkinManager and use pattern matching instead 2021-06-28 12:43:13 +03:00
Salman Ahmed
177bfe1234 Merge branch 'master' into ruleset-resources-skin 2021-06-28 11:16:37 +03:00
Dean Herbert
a8597b6213
Merge pull request #13658 from frenzibyte/fix-initial-ruleset-skin-loading 
Fix `RulesetSkinProvidingContainer` being potentially late in setting up skin sources
 2021-06-28 17:03:56 +09:00
Dean Herbert
d4ea73d727 Simplify disposal exceptions 2021-06-28 16:17:09 +09:00
Dean Herbert
f78cedd0e1 Reorder methods and add xmldoc for BlockAllOperations 2021-06-28 16:16:40 +09:00
Dean Herbert
90f0bc87f5 Add safety against double disposal 2021-06-28 16:12:21 +09:00
Dean Herbert
842f033522 Remove no longer necessary exception 2021-06-28 16:11:55 +09:00
Dean Herbert
f7aba7360a
Merge pull request #13654 from Henry-YSLin/fix-invisible-number-box 
Refactor `SeedSettingsControl` and `SettingsNumberBox`
 2021-06-28 16:07:30 +09:00
Dean Herbert
0d2bc4fc5f Merge branch 'master' into fix-realm-state-change-crashes 2021-06-28 16:03:58 +09:00
Salman Ahmed
779a1b322c
Add comment explaining insertion of ruleset skin before default skin 
Co-authored-by: Dean Herbert <pe@ppy.sh>
 2021-06-28 09:38:42 +03:00
Dean Herbert
e4780d4b06 Update framework 2021-06-28 15:29:47 +09:00
Dean Herbert
f939e2603a Merge branch 'master' into localisable-tooltips 2021-06-28 15:29:42 +09:00
Dean Herbert
eeb56970ef Make OutlinedNumberBox private and nested again 2021-06-28 15:24:55 +09:00
Salman Ahmed
f598de4cdb ResourcesSkin -> ResourceStoreBackedSkin 2021-06-28 09:18:29 +03:00
Salman Ahmed
692f24437e Maintain ruleset resources skin across multiple source changes 2021-06-28 09:11:28 +03:00
Dean Herbert
7dd566dc46
Add null check for safety 
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2021-06-28 15:08:49 +09:00
Dean Herbert
c281e43cd8 Remove Dispose() special case and add explicit exception to make debugging issues non-deadlock 2021-06-28 15:04:14 +09:00
Dean Herbert
f777741ca7 Simplify instantiation 2021-06-28 14:51:27 +09:00
Dean Herbert
e387feb1d6 Add inline comment mentioning why CreateChildDependencies is being used in this instance 2021-06-28 14:39:55 +09:00
Dean Herbert
fdd6778f36
Merge branch 'master' into fix-initial-ruleset-skin-loading 2021-06-28 14:35:34 +09:00
Dean Herbert
a3946a1265
Fix typo in newly added xmldoc 
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
 2021-06-28 14:07:21 +09:00
Henry Lin
3d19364a71 Use BindValueChanged instead of setting the value in property setter 2021-06-28 11:20:00 +08:00
Dean Herbert
4d6002ab88 Remove redundant string interpolation (and mark all local logging strings as verbatim) 2021-06-28 12:16:15 +09:00
Henry Lin
0cceef8da5 Moved the string to int? conversion logic into SettingsNumberBox 2021-06-28 11:00:07 +08:00
Dean Herbert
4a557e73a7 Add logging to help understand existing case skips better 2021-06-28 10:42:42 +09:00
Dan Balasescu
9c0840268a
Merge pull request #13598 from JimmyC7834/supporter-only-filter-content 
Add supporter required placeholder in beatmap listing overlay
 2021-06-28 10:27:56 +09:00
Dean Herbert
90b87cbb9e Add back unidirectional online id check 2021-06-28 10:11:27 +09:00
Dean Herbert
9a96cd4a1d Revert "Remove comparison of online beatmap IDs during dedupe checks" 
This reverts commit 15af28d2a0.
 2021-06-28 09:54:18 +09:00
Dean Herbert
a1e8cc5444
Merge pull request #13669 from Naxesss/hitsound-checks 
Add hitsound checks
 2021-06-28 03:13:43 +09:00
Naxess
9f9e96ce9e Add check for spanDuration <= 0 prior to division 2021-06-27 15:40:09 +02:00
Naxess
a4a5325b73 Improve acceptable difference for repeat edges 
Likelihood that `spanDuration` is greater than E+7 is quite low in any realistic case, so this should work fine.
 2021-06-27 15:39:31 +02:00
Dean Herbert
e755dcc34d Add log method for new flow 2021-06-27 20:37:12 +09:00
Dean Herbert
f470b7095d Move private method down in class 2021-06-27 20:36:01 +09:00
Dean Herbert
f216404952 Fix missing undelete call on using existing 2021-06-27 20:22:48 +09:00
Dean Herbert
9120321731 Add comments mentioning shortcomings and avoid potential double check 2021-06-27 19:07:35 +09:00
Dean Herbert
44f875b802 Bypass optimised existing check in SkinManager (due to custom hashing function) 2021-06-27 16:35:13 +09:00
Dean Herbert
e493685c14 Add optimised existing check earlier in import process 2021-06-27 16:34:40 +09:00
Dean Herbert
15af28d2a0 Remove comparison of online beatmap IDs during dedupe checks 2021-06-27 14:48:57 +09:00
Dean Herbert
46f8100f43 Remove overly verbose logging during beatmap imports 2021-06-27 14:29:02 +09:00
Dean Herbert
d1f852d102 Make Populate abstract to avoid unnecessary base call async complexity 2021-06-27 14:29:02 +09:00
Naxess
4cfa0ae5ec Improve precision for repeat edges 2021-06-27 03:26:35 +02:00
Naxess
2cd7eda3c4 Add "or equal to" to volume threshold xmldocs 2021-06-27 02:30:12 +02:00
Naxess
0c0fd291d9 Order hitobjects by endtime 2021-06-27 01:25:03 +02:00
Naxess
4796b1b208 Use local variables for hasHitsound & couldHaveHitsound 2021-06-27 00:04:30 +02:00
Naxess
5bc08ebadb Rename hasHitsounds -> mapHasHitsounds 2021-06-26 23:49:25 +02:00
Naxess
d29e6f4695 Add negligible template to PossibleTemplates 2021-06-26 23:49:06 +02:00
Naxess
1913084342 Use HitSampleInfo.AllAdditions instead of new list 2021-06-26 23:48:28 +02:00
Naxess
f78cc9397e Factor out edge type logic 2021-06-26 20:45:31 +02:00
Naxess
51147405c5 Make || and && priority explicit 2021-06-26 20:44:39 +02:00
Bartłomiej Dach
9061ab0a27 Update/reword comments in listing overlay 2021-06-26 20:42:13 +02:00
Bartłomiej Dach
b56dd7ff25 Fix naming and xmldocs in new beatmap search result structures 2021-06-26 20:35:07 +02:00
Naxess
4b436b774d Add few hitsounds check 2021-06-26 19:20:46 +02:00
Naxess
d8117fa730 Add muted objects check 2021-06-26 19:20:34 +02:00
Gagah Pangeran Rosfatiputra
2b1d3c8e9c
add od filter in search filter 2021-06-26 21:05:01 +07:00
Gagah Pangeran Rosfatiputra
8e1bcc4d6b
add overall difficulty in filter criteria 2021-06-26 21:02:31 +07:00
Salman Ahmed
e8e9fdd533 Dispose ResourcesSkin before clearing skin sources 2021-06-26 12:34:30 +03:00
Salman Ahmed
e5eea503db Remove finalizer logic from ResourcesSkin 2021-06-26 12:21:49 +03:00
Henry Lin
3b822cd5cf Refactor SeedSettingsControl and related controls 2021-06-26 11:19:14 +08:00
Bartłomiej Dach
ea384332c3
Merge branch 'master' into logo-transition-sound 2021-06-25 21:12:48 +02:00
Bartłomiej Dach
50c27d2635 Update usages of IHasTooltip in line with framework localisation changes 2021-06-25 19:10:04 +02:00
aitani9
6bc71590c5 Disable logo click sound when exiting 2021-06-25 09:21:26 -07:00
smoogipoo
c93c615f5e Also fix up interface names 2021-06-25 20:15:30 +09:00
smoogipoo
1ed61b9b98 Fix up dependencies class names 2021-06-25 20:11:38 +09:00
Salman Ahmed
8387acfe15
Merge branch 'master' into fix-initial-ruleset-skin-loading 2021-06-25 12:22:51 +03:00
smoogipoo
a27a647ae7 Rename RoomDependencies -> OnlinePlayDependencies 2021-06-25 18:07:47 +09:00
smoogipoo
04279e7f5c Add some xmldocs 2021-06-25 18:02:53 +09:00
smoogipoo
c0d2b41d4c Move SpectatorClient into multiplayer dependencies 2021-06-25 17:55:16 +09:00
Dean Herbert
51dd7fc238
Merge pull request #13622 from aitani9/mod-settings-dropdown-height 
Decrease the max dropdown height in mod settings
 2021-06-25 17:42:47 +09:00
smoogipoo
7aefbe3da1 Move UserLookupCache inside dependencies 2021-06-25 17:37:02 +09:00
Dean Herbert
5883922177 Remove mod multiplier completely 2021-06-25 16:36:31 +09:00
Salman Ahmed
f07008a0a2 Fix RulesetSkinProvidingContainer potentially late in setting up skin sources 2021-06-25 10:05:51 +03:00
Dean Herbert
57ae87956a Update execution state change blocking logic in line with framework changes 2021-06-25 15:27:40 +09:00
smoogipoo
81a812e216 Rework MultiplayerTestScene to make use of OnlinePlayTestScene 2021-06-25 15:00:10 +09:00