42724 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	353a07f7a5	Fix code quality inspection	2024-05-06 12:23:11 +02:00
Bartłomiej Dach	f066026503	Fix sizing of gameplay preview in skin editor not updating on scaling mode change ... Closes https://github.com/ppy/osu/issues/28115.	2024-05-06 11:55:51 +02:00
Bartłomiej Dach	cf87e9cd40	Do not show integration settings on mobile ... Closes https://github.com/ppy/osu/issues/28097. The settings weren't actually doing anything at all there anyway.	2024-05-06 11:24:42 +02:00
Bartłomiej Dach	761d713593	Merge pull request #28086 from 424ever/ctrl-keeps-menu-open ... Activate stateful menu items with right-click without closing the menu	2024-05-06 09:30:22 +02:00
Bartłomiej Dach	71776a583c	Merge branch 'master' into preset-td-autoplay	2024-05-06 09:02:08 +02:00
Bartłomiej Dach	4c7e6b125c	Add clarification comment	2024-05-06 08:49:30 +02:00
Bartłomiej Dach	cf22fc143f	Merge pull request #27539 from frenzibyte/storyboard-loops-v2 ... Refactor storyboard commands structure and add framework-based transform loop support	2024-05-06 08:39:07 +02:00
Dean Herbert	12cd3bbe1c	Fix incorrect scale handling due to selection point changes	2024-05-06 11:34:37 +08:00
Dean Herbert	6f0fc6f78f	Merge pull request #28111 from Joehuu/fix-broken-scrolling-unicode ... Fix now playing overlay text scroll breaking when toggling metadata language setting	2024-05-06 11:15:51 +08:00
Joseph Madamba	359238395f	Fix now playing overlay text scroll breaking when toggling metadata language setting	2024-05-05 15:43:46 -07:00
Joseph Madamba	1665c5e0e1	Use existing AutomaticallyDownloadMissingBeatmaps localisation on solo spectator screen	2024-05-05 14:41:48 -07:00
Dean Herbert	9e7712740b	Refactor for legibility	2024-05-05 23:33:37 +08:00
Jonas Brandstötter	b1696db9c8	Reorder imports with dotnet format	2024-05-04 16:32:18 +02:00
Jonas Brandstötter	c62952ea3a	Invoke the registered Action when a stateful item is right clicked	2024-05-04 16:27:06 +02:00
Jonas Brandstötter	21917218ce	No longer keep menu open when CTRL is held	2024-05-04 16:27:06 +02:00
cdwcgt	1f92f1d19b	remove blank line ... nt	2024-05-04 20:41:36 +08:00
cdwcgt	fe30ca3d39	fix linq logic	2024-05-04 20:18:31 +08:00
cdwcgt	f9be9ed479	remove incompatible system mods before enable preset	2024-05-04 19:58:32 +08:00
Dean Herbert	002efca422	Merge pull request #28082 from bdach/do-not-lookup-usernames-for-offline-scores ... Do not lookup usernames for scores without an online ID	2024-05-04 15:08:33 +08:00
Dean Herbert	2cb367fdce	Disable "origin" menu when in "Closest" placement mode	2024-05-04 13:29:05 +08:00
Dean Herbert	e7ca02ffde	Fix position changing when origin updates during a drag	2024-05-04 13:28:33 +08:00
Dean Herbert	0b61e2cd42	Use closest origin along with closest anchor	2024-05-04 13:09:51 +08:00
Jonas Brandstötter	e0e7e123bf	Keep menus open when clicking a stateful item with CTRL held	2024-05-03 17:26:10 +02:00
Dean Herbert	5cdaafdb1e	Merge pull request #28083 from bdach/beatmap-attribute-text-breakage ... Fix `BeatmapAttributeText` breaking due to enum serialisation woes	2024-05-03 21:18:26 +08:00
Dean Herbert	6cec4f0c8f	Merge pull request #28067 from bdach/refresh-local-cache-more-often ... Update local metadata lookup cache more often	2024-05-03 20:44:13 +08:00
Bartłomiej Dach	a23d25e0a1	Fix BeatmapAttributeText breaking due to enum serialisation woes	2024-05-03 14:27:34 +02:00
Dean Herbert	ecb9173e51	Merge pull request #28017 from Joehuu/scrollable-text ... Scroll now playing overlay text when overflowing	2024-05-03 20:05:58 +08:00
Bartłomiej Dach	afb491dff0	Do not perform username lookups for scores without an online ID	2024-05-03 13:59:36 +02:00
Bartłomiej Dach	7d31af6f16	Fix room status not updating when password is changed while inside the room	2024-05-03 11:37:09 +02:00
Bartłomiej Dach	221b4cd599	Remove unused cache	2024-05-03 11:37:09 +02:00
Dean Herbert	7141177966	Better signify private rooms by showing a different status pill design	2024-05-03 17:17:35 +08:00
Dean Herbert	42e49067e5	Move Room.Status updates to a common location	2024-05-03 17:10:59 +08:00
Bartłomiej Dach	3840e92576	Merge pull request #28075 from peppy/fix-chat-ui-scale ... Fix chat overlay being far too large	2024-05-03 09:04:07 +02:00
Bartłomiej Dach	cf27366f99	Merge branch 'master' into fix-double-load-playlist-backgrounds	2024-05-03 08:15:56 +02:00
Bartłomiej Dach	d1a50ff85b	Remove redundant conditional access	2024-05-03 08:11:00 +02:00
Bartłomiej Dach	53b9159a01	Merge pull request #28078 from peppy/default-beatmap-background-be-gone ... Stop using visually noisy `bg4` for default backgrounds	2024-05-03 08:06:22 +02:00
Dean Herbert	c935d3bf6c	Reduce font size in channel listing too	2024-05-03 14:00:28 +08:00
Joseph Madamba	c21b7c7df9	Use IsLoaded instead of Schedule	2024-05-02 22:46:42 -07:00
Dean Herbert	c1e9b6d4ca	Fix beatmap backgrounds loading default briefly before final display ... Due to the way `ModelBackedDrawable` works, the default starts to get loaded even though a final `Beatmap` has been set. This avoids loading the default fallback unless a beatmap has been set (and has no background itself).	2024-05-03 13:42:56 +08:00
Dean Herbert	058bd5ced6	Stop using visually noisy bg4 for default backgrounds ... This has always really annoyed me.	2024-05-03 13:38:27 +08:00
Dean Herbert	3249ecee27	Fix chat overlay being far too large	2024-05-03 12:31:19 +08:00
Dean Herbert	aa4d16bdb8	Fix beatmap listing cards being far too large	2024-05-03 12:13:52 +08:00
Joseph Madamba	c15a685071	Remove unused usings	2024-05-02 17:07:49 -07:00
Joseph Madamba	381ddb0676	Fix weird formatting	2024-05-02 17:06:11 -07:00
Joseph Madamba	269077f854	Only support centre anchors	2024-05-02 17:06:11 -07:00
Joseph Madamba	2f075e3247	Apply half margin of tolerance on both sides before text scrolls	2024-05-02 17:06:11 -07:00
Fabian van Oeffelt	4b5ea6bd0b	Fix Code Inspection	2024-05-02 19:41:00 +02:00
Fabian van Oeffelt	588badf292	Fix Formatting	2024-05-02 19:22:39 +02:00
Fabian van Oeffelt	fa0b6311b0	Merge branch 'master' into osu-lazer-speedkeys	2024-05-02 19:17:15 +02:00
Fabian van Oeffelt	7527ddbc68	Comment, make code more readable, functions are now private	2024-05-02 19:05:43 +02:00
Fabian van Oeffelt	5c21a0330a	F1 also does not work with minus in song select, same behaviour	2024-05-02 19:05:07 +02:00
Fabian van Oeffelt	f534c4aada	Initial implementation	2024-05-02 18:42:35 +02:00
Dean Herbert	2d0240437a	Merge pull request #28066 from bdach/distance-snap-grid-spacing-change-hides-it ... Fix changing distance spacing multiplier hiding the distance snap grid when it's already shown	2024-05-02 22:35:02 +08:00
Bartłomiej Dach	802666e621	Update local metadata lookup cache more often ... As proposed in https://github.com/ppy/osu/issues/27332#issuecomment-1962308306.	2024-05-02 16:18:29 +02:00
Bartłomiej Dach	14658824e7	Adjust distance snap grid momentary toggle logic to not hide it on spacing adjust	2024-05-02 14:11:44 +02:00
Dean Herbert	f9ef689492	Don't hide playfield layer with HUD	2024-05-02 15:36:40 +08:00
Bartłomiej Dach	555305bf7f	Merge pull request #28058 from frenzibyte/export-score-rank ... Preserve score rank on lazer scores during encode/decode	2024-05-02 08:44:10 +02:00
Salman Ahmed	b1aff91bba	Use throw helper methods ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-05-02 00:31:48 +03:00
Salman Ahmed	6d6f165884	Make video sprites flippable and vector-scalable to fix type constraint errors ... Stable supports these on videos already from a quick read on code (since videos are generally a subclass of sprites).	2024-05-02 00:01:50 +03:00
Salman Ahmed	4ffeb5b469	Resolve post-merge-conflict issues	2024-05-01 23:57:58 +03:00
Salman Ahmed	895c09d4d1	Merge branch 'master' into storyboard-loops-v2	2024-05-01 23:46:38 +03:00
Salman Ahmed	0106f1fe3e	Preserve score rank on encode/decode	2024-05-01 23:31:23 +03:00
Salman Ahmed	30fd40efd1	Avoid disable/restore pairs	2024-05-01 21:18:56 +03:00
Salman Ahmed	e8a6381395	Update naming of enum fields in ObjType	2024-05-01 17:24:53 +03:00
Salman Ahmed	16bae4f004	Update naming of enum fields in StartMode	2024-05-01 17:22:42 +03:00
Salman Ahmed	97fc2a5473	Disable inconsistent naming in some fields of ScoreRank	2024-05-01 17:22:10 +03:00
Salman Ahmed	2fd8950b21	Disable inconsistent naming in some fields of LegacyManiaSkinConfigurationLookup	2024-05-01 17:22:10 +03:00
Salman Ahmed	02be275554	Disable naming inspections in country/language enums	2024-05-01 17:20:20 +03:00
Bartłomiej Dach	fe9e6168fe	Merge pull request #28050 from peppy/delay-resume-visibility ... Tweak resume overlay to allow better visibility of hit objects underneath	2024-05-01 15:49:31 +02:00
Bartłomiej Dach	72b59c01f7	Merge branch 'master' into preserve-storyboard	2024-05-01 15:21:45 +02:00
Bartłomiej Dach	f0eef32913	Fix code quality inspection	2024-05-01 15:21:39 +02:00
Dean Herbert	b8209b92f6	Add delay before delayed resume starts ... It was previously a bit sudden after dismissing the pause screen. Now there's a short delay before the actual countdown begins.	2024-05-01 20:30:48 +08:00
Dean Herbert	87e814e201	Fix incorrect xmldoc and adjust colour provider to match Player	2024-05-01 20:30:36 +08:00
Dean Herbert	67c0d7590a	Decrease alpha of delayed resume overlay as count approaches zero ... Allows better visibility of playfield underneath it.	2024-05-01 20:29:28 +08:00
Dean Herbert	44091b1f35	Fix some lines still getting forgotten about	2024-05-01 17:33:03 +08:00
Dan Balasescu	61350ebf6e	Merge pull request #28031 from peppy/reduce-volume ... Reduce startup volume	2024-05-01 04:44:00 +09:00
Dean Herbert	ff108416d8	Fix incorrect background being loaded due to async race ... If the API login (and thus user set) completed between `load` and `LoadComplete`, the re-fetch on user change would not yet be hooked up, causing an incorrect default background to be used instead. Of note, moving this out of async load doesn't really affect load performance as the bulk of the load operation is already scheduled and `LoadComponentAsync`ed anyway	2024-05-01 00:05:14 +08:00
Bartłomiej Dach	82d1ebbd20	Merge branch 'master' into fix-zip-encoding	2024-04-30 16:30:15 +02:00
Dean Herbert	6a7e2dc258	Fix formatting	2024-04-30 21:47:03 +08:00
Dean Herbert	a3213fc36d	Change .olz to use UTF-8 encoding	2024-04-30 21:40:04 +08:00
Bartłomiej Dach	5e2e2a8d39	Merge pull request #28019 from peppy/realm-file-perm-check ... Check realm file can be written to before attempting further initialisation	2024-04-30 13:46:43 +02:00
Dean Herbert	ba9f4e4baf	Don't skip lines in beatmap decoding ... Was added in cc76c58f5f without any specific reasoning. Likely not required (and will fix some storyboard elements inside `.osu` files from not being correctly saved).	2024-04-30 16:42:15 +08:00
Dean Herbert	0bfad74907	Move realm error handling to avoid triggering in test scenarios	2024-04-30 14:09:29 +08:00
Dean Herbert	a8416f3572	Move exists check inside retry operation ... Might help?	2024-04-30 12:39:18 +08:00
Dean Herbert	c8f7f2215b	Force encoding to Shift-JIS for archive filenames ... After way too much time investigating this, the encoding situation is not great right now. - Stable sets the "default code page" to be used for encoding filenames to Shift-JIS (932): c29ebd7fc5/osu!/GameBase.cs#L3099 - Lazer does nothing (therefore using UTF-8). When importing to lazer, stable files are assumed to be UTF-8. This means that the linked beatmaps don't work correctly. Forcing lazer to decompress *and* compress using Shift-JIS will fix this. Here's a rough idea of how things look for japanese character filenames in current `master`: | | stable | lazer | |--------|--------|--------| | export encoding | shift-jis | utf8 | | utf8 [bit flag](https://superuser.com/a/1507988) set | ❌ | ❌ | | import stable export osz | ✅ | ❌ | | import lazer export osz | ❌ | ✅ | | windows unzip | ❌ | ❌ | | macos unzip | ✅ | ✅ | and after this change | | stable | lazer | |--------|--------|--------| | export encoding | shift-jis | shift-jis | | utf8 [bit flag](https://superuser.com/a/1507988) set | ❌ | ❌ | | import stable export osz | ✅ | ✅ | | import lazer export osz | ✅ | ✅ | | windows unzip | ❌ | ❌ | | macos unzip | ✅ | ✅ | A future endeavour to improve compatibility would be to look at setting the utf8 flag in lazer, switching the default to utf8, and ensuring the stable supports this flag (I don't believe it does right now).	2024-04-30 01:27:47 +08:00
Dean Herbert	fd3f4a9e7b	Preserve storyboard events when saving a beatmap in the editor ... Until we have full encoding support for storyboards, this stop-gap measure ensures that storyboards don't just disappear from existence.	2024-04-30 00:01:56 +08:00
Dean Herbert	85c085e587	Reduce startup volume ... Constant complaints about startup volume mean we should reduce it further and let users adjust as they see fit.	2024-04-29 23:28:19 +08:00
Bartłomiej Dach	f78abf801c	Autosave edited skin on change	2024-04-29 14:38:53 +02:00
Bartłomiej Dach	45c2327509	Apply adjustments after framework-side FriendlyGameName changes	2024-04-29 13:00:22 +02:00
Dean Herbert	a3d239c11a	Remove unused method	2024-04-29 18:48:07 +08:00
Dean Herbert	1c1ee22aa7	Add retry attempts to hopefully fix windows tests runs	2024-04-29 14:17:48 +08:00
Dean Herbert	a4bc5a8fc9	Use helper method for backup retry attempts	2024-04-29 10:35:37 +08:00
Dean Herbert	b262497083	Check realm file can be written to before attempting further initialisation ... Rather than creating a "corrupt" realm file in such cases, the game will now refuse to start. This behaviour is usually what we want. In most cases a second click on the game will start it successfully (the previous instance's file handles are still doing stuff, or windows defender is being silly). Closes https://github.com/ppy/osu/issues/28018.	2024-04-28 19:07:39 +08:00
Joseph Madamba	d4951a093f	Scroll now playing overlay text when overflowing	2024-04-27 20:18:49 -07:00
Joseph Madamba	48c608e016	Make player width a const	2024-04-27 20:06:09 -07:00
Taevas	694e3900db	Add missing space in setup wizard	2024-04-27 23:43:27 +02:00
Dean Herbert	fb2d28f7e0	Fix audio being paused in a spectator session when all players finish playing	2024-04-26 15:30:26 +08:00
Dean Herbert	21d6556865	Remove managed clocks from SpectatorSyncManager on gameplay completion / abort	2024-04-26 15:29:59 +08:00
Dean Herbert	e0e790fa94	Fix a couple of xmldoc typos	2024-04-26 15:28:52 +08:00
Dan Balasescu	459f97891d	Merge pull request #27994 from bdach/timing-distribution-graph-only-basic ... Do not show non-basic results in timing distribution graph	2024-04-26 01:36:16 +09:00
Dan Balasescu	52addc775e	Merge pull request #27965 from bdach/generic-math ... Apply generic math-related changes	2024-04-26 01:33:54 +09:00
Dean Herbert	5ccc745235	Merge pull request #27997 from bdach/refetch-when-entering-editor ... Fully refetch working beatmap when entering editor	2024-04-25 22:20:33 +08:00
Dean Herbert	387fcb8781	Add a brief inline comment to make sure we don't undo the fix	2024-04-25 21:31:36 +08:00
Dean Herbert	6a8a6fa79d	Merge pull request #27996 from bdach/delete-dirty-difficulty-droken ... Fix deleting modified difficulty via editor leaving user in broken state	2024-04-25 21:20:09 +08:00
Bartłomiej Dach	c1107d2797	Fully refetch working beatmap when entering editor ... Closes https://github.com/ppy/osu/issues/21794. I'm not actually super sure as to what the exact mode of failure is here, but it's 99% to do with working beatmap cache invalidation. Likely this can be even considered as another case of https://github.com/ppy/osu/issues/21357, but because this is a one-liner "fix," I'm PRing it anyways. The issue is confusing to understand when working with the swap scenario given in the issue, but it's a little easier to understand when performing the following: 1. Have a beatmap set with 2 difficulties. Let's call them "A" and "B". 2. From song select, without ever exiting to main menu, edit "A". Change the difficulty name to "AA". Save and exit back to song select; do not exit out to main menu. 3. From song select, edit "B". Change the difficulty name to "BB". Save and exit back to song select. 4. The difficulty names will be "A" and "BB". Basically what I *think* is causing this, is the fact that even though editor invalidates the working beatmap by refetching it afresh on exit, song select is blissfully unaware of this, and continues working with its own `BeatmapInfo` instances which have backlinks to `BeatmapSetInfo`. When editing the first of the two difficulties and then the second, the editing of the first one only invalidates the first one rather than the entire set, and the second difficulty continues to have a stale reference to the first one via the beatmap set, and as such ends up overwriting the changes from the first save when passed into the editor and modified again.	2024-04-25 14:31:13 +02:00
Bartłomiej Dach	19d006d818	Fix deleting modified difficulty via editor leaving user in broken state ... Closes https://github.com/ppy/osu/issues/22783. If the difficulty being edited has unsaved changes, the editor exit flow would prompt for save *after* the deletion method has run. This is undesirable from a UX standpoint, and also leaves the user in a broken state. Thus, just fake an update of the last saved hash of the beatmap to fool the editor into thinking that it's not dirty, so that the exit flow will not show a save dialog.	2024-04-25 12:55:34 +02:00
Bartłomiej Dach	b250a924b1	Do not show non-basic results in timing distribution graph ... Closes https://github.com/ppy/osu/issues/24274. Bit of an ad-hoc resolution but maybe fine? This basically proposes to bypass the problem described in the issue by just not showing tick hits at all on the distribution graph.	2024-04-25 11:20:07 +02:00
Bartłomiej Dach	da953b34a7	Apply nullability annotations to ResultsScreen & inheritors	2024-04-25 10:58:28 +02:00
Joseph Madamba	4f7c9f2970	Remove unused using	2024-04-24 01:00:03 -07:00
Joseph Madamba	f97c519451	Add chevron to distinguish all menus with submenus	2024-04-24 00:19:10 -07:00
Dean Herbert	16fdd4e08d	Add ability to show beatmap source using skin editor's beatmap attribute text ... As per https://github.com/ppy/osu/discussions/27955.	2024-04-24 09:01:31 +08:00
Bartłomiej Dach	cbbf2dd158	Fix DifficultyBindable bound desync between maxValue and CurrentNumber.MaxValue	2024-04-23 18:58:40 +02:00
Bartłomiej Dach	787e60f706	Fix LegacyDrainingHealthProcessor drain rate computation diverging to infinity	2024-04-23 18:57:14 +02:00
Bartłomiej Dach	a35bf77131	Merge pull request #27974 from peppy/editor-menu-chev ... Add a chevron to distinguish editor menus with submenus	2024-04-23 18:12:08 +02:00
Bartłomiej Dach	c454dd2496	Merge pull request #27967 from peppy/storyboard-video-transforms-and-sizing ... Fix storyboard videos not accepting transforms	2024-04-23 18:09:09 +02:00
Dean Herbert	999c8fdc38	Merge pull request #27969 from bdach/enter-to-confirm-keybinding-conflict ... Allow confirming keybinding overwrite on conflict via "select" binding	2024-04-23 23:38:50 +08:00
Dean Herbert	221af74f95	Merge branch 'master' into generic-math	2024-04-23 22:21:31 +08:00
Dean Herbert	d0edf72a0c	Update framework	2024-04-23 22:04:28 +08:00
Dean Herbert	602b16f533	Fix fade-in no longer working on videos	2024-04-23 22:03:32 +08:00
Dean Herbert	a7327a2998	Merge pull request #27972 from bdach/fix-mod-column-stupidity-rfc ... Fix mod select overlay columns not displaying properly sometimes	2024-04-23 21:59:29 +08:00
Dean Herbert	436203a8c1	Add a chevron to distinguish editor menus with submenus	2024-04-23 21:37:01 +08:00
Dean Herbert	804b1b0d88	Fix settings colour scheme wrong when viewing gameplay from skin editor button ... Closes https://github.com/ppy/osu/issues/27949.	2024-04-23 20:54:48 +08:00
Bartłomiej Dach	f7626aba18	Fix mod select overlay columns not displaying properly sometimes ... Closes https://github.com/ppy/osu/issues/26504. As far as I can tell the issue is basically another manifestation of https://github.com/ppy/osu-framework/issues/5129, i.e. presence overrides causing dropped invalidations and thus completely bogus hierarchy state. The fix is to raise the appropriate invalidation manually.	2024-04-23 13:36:12 +02:00
Bartłomiej Dach	1e0db1ab9f	Allow confirming keybinding overwrite on conflict via "select" binding	2024-04-23 12:44:16 +02:00
Dean Herbert	17ca29c2c6	Actually apply transforms to the video	2024-04-23 17:37:37 +08:00
Dean Herbert	7eeac0f3b9	Fix incorrect xmldoc ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-04-23 17:34:52 +08:00
Bartłomiej Dach	12acdeebf1	Merge pull request #27866 from Joehuu/fix-online-score-export ... Fix replay export not working correctly from online leaderboards	2024-04-23 09:08:04 +02:00
Bartłomiej Dach	1f010c4bfd	Merge pull request #27808 from smoogipoo/fix-incorrect-pp-counter ... Fix gameplay PP counter not matching results screen	2024-04-23 08:43:49 +02:00
Joseph Madamba	49154c0e23	Fix code quality	2024-04-22 11:23:38 -07:00
Joseph Madamba	35eddf35c5	Return Task.CompletedTask instead of null	2024-04-22 11:22:39 -07:00
Joseph Madamba	a59bf6d373	Improve xmldoc wording	2024-04-22 11:17:27 -07:00
Joseph Madamba	2eda56ff08	Revert beatmap query change	2024-04-22 11:15:50 -07:00
Dean Herbert	9e7182acf0	Remove unused DI beatmap paramater	2024-04-22 18:45:02 +08:00
Dean Herbert	c43c383abf	Allow storboard videos to take on no-relative size when specified by a mapper	2024-04-22 18:44:47 +08:00
Dean Herbert	4ae9f81c73	Apply transforms to storyboard videos ... This requires that they are a `StoryboardSprite` for simplicity. Luckily this works just fine.	2024-04-22 18:43:15 +08:00
Bartłomiej Dach	70a5288a68	Do not attempt to pass files that don't look like audio to BASS	2024-04-22 10:45:09 +02:00
Bartłomiej Dach	78f97d0ec7	Merge branch 'master' into verify-check-incorrect-audio-formats	2024-04-22 10:34:14 +02:00
Bartłomiej Dach	ceeb9b0819	Use explicit reference equality check	2024-04-22 10:27:30 +02:00
Bartłomiej Dach	1bcf835d22	Remove redundant array type specification	2024-04-22 10:25:46 +02:00
Bartłomiej Dach	09b0f3005e	Apply generic math-related changes	2024-04-22 10:15:56 +02:00
Arthur Araujo	49563f4e5b	Use bitwise to check hitsound formats	2024-04-22 04:44:38 -03:00
Dan Balasescu	89a4a6878f	Merge pull request #27922 from peppy/quick-exit-from-results ... Add ability to quick exit from results screen	2024-04-22 16:01:13 +09:00
Andrei Zavatski	1d3fd65d86	Adjust execution order	2024-04-22 07:02:49 +03:00
Andrei Zavatski	722fa228ce	Don't consider editor table content for input	2024-04-21 17:40:35 +03:00
Dean Herbert	b9b341affd	Merge pull request #27930 from peppy/update-framework ... Update framework	2024-04-20 05:26:53 +08:00
Dean Herbert	4cffc39dff	Don't require hold for quick exit at results screen	2024-04-20 04:53:31 +08:00
Bartłomiej Dach	3d64ffc93e	Merge pull request #27935 from smoogipoo/serialised-drawable-sane-defaults ... Give SerialisedDrawableInfo sane defaults	2024-04-19 17:00:49 +02:00
Bartłomiej Dach	1344ca4e19	Merge pull request #27780 from mafarrica/27105-fix-mod-search-box-focus-changes ... Fix mod search box not tracking external changes to focus state	2024-04-19 17:00:06 +02:00
Dan Balasescu	bac70da1a1	Give SerialisedDrawableInfo sane defaults	2024-04-19 22:03:19 +09:00
Dean Herbert	6e08fd7f27	Merge pull request #27931 from smoogipoo/remove-unused-lookup-members ... Remove unused members from GameplaySkinComponentLookup	2024-04-19 20:51:09 +08:00
Dan Balasescu	ddc1b90ee1	Remove unused method	2024-04-19 20:36:24 +09:00
Arthur Araujo	92b85beff6	Remove ChannelType from messages	2024-04-19 08:01:23 -03:00
Arthur Araujo	68e86b5105	Remove unsued import and add a blankline before yield break;	2024-04-19 07:39:31 -03:00
Arthur Araujo	eac9dededf	Use periods instead of semicolons ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-04-19 07:20:59 -03:00
Bartłomiej Dach	509862490e	Revert unnecessary changes	2024-04-19 11:11:18 +02:00
Bartłomiej Dach	2dcbb823ef	Use textbox focus state directly rather than trying to track it independently	2024-04-19 11:08:34 +02:00
Dan Balasescu	362a7b2c77	Remove unused members from GameplaySkinComponentLookup	2024-04-19 18:03:13 +09:00
Dean Herbert	a41ae99dd7	Update framework	2024-04-19 15:14:52 +08:00
Dean Herbert	fe30c9ec2a	Merge branch 'master' into add-sound-to-tab-selection-change-2	2024-04-19 12:40:22 +08:00
Dean Herbert	c39eb5c5aa	Merge branch 'master' into upgrade-to-SDL3	2024-04-18 22:23:55 +08:00
Dean Herbert	46e2cfdba5	Update framework	2024-04-18 18:33:30 +08:00
Joseph Madamba	d08b1e5ae7	Add xmldoc to GetScore() and Export() and remove xmldoc from private getDatabasedScoreInfo()	2024-04-17 21:52:36 -07:00
Dean Herbert	f92833b588	Add ability to quick exit from results screen	2024-04-18 12:02:49 +08:00
Arthur Araujo	ac03856ebd	Fix test methods names	2024-04-17 08:22:05 -03:00
Arthur Araujo	8d94f8d995	Remove BassFlags.Prescan and free the decodeStream	2024-04-17 08:14:19 -03:00
Salman Ahmed	a7e043bdbe	Fix beatmap rulest selector playing sound for initial ruleset selection	2024-04-17 11:20:17 +03:00
Salman Ahmed	24e8b88320	Add inline comment to the custom implementation of multiple-selection tab items	2024-04-17 11:20:17 +03:00
Salman Ahmed	9e69268676	Change editor screen selection logic to use SelectItem for sound feedback	2024-04-17 11:20:17 +03:00
Salman Ahmed	42892acc1a	Fix multiple selection filter tab items no longer playing sounds ... These tab items are not managed by a `TabControl`, activation events are manually served by the class itself toggling `Active` when clicked.	2024-04-17 11:20:17 +03:00
Salman Ahmed	50a21fb727	Change ToolbarRulesetSelector to use SelectItem to trigger new sound feedback path	2024-04-17 11:20:17 +03:00
Salman Ahmed	2a3ae6bce1	Update all TabItem implementations to play select sample on OnActivatedByUser	2024-04-17 11:20:17 +03:00
Bartłomiej Dach	e11e9fe14f	Add TotalScoreWithoutMods to SoloScoreInfo ... End goal being storing it server-side.	2024-04-17 09:15:51 +02:00
Bartłomiej Dach	18bb81e7a7	Populate total score without mods when performing standardised score migration	2024-04-17 09:11:47 +02:00
Bartłomiej Dach	2f1a4cdaa4	Export and import TotalScoreWithoutMods to replays (or recalculate if it missing)	2024-04-17 09:08:15 +02:00
Bartłomiej Dach	e0178802b8	Populate TotalScoreWithoutMods on scores set locally	2024-04-17 08:52:47 +02:00
Bartłomiej Dach	6b0d577f0b	Add backmigration of TotalScoreWithoutMods for existing scores	2024-04-17 08:52:27 +02:00
Bartłomiej Dach	a386068ed3	Add ScoreInfo.TotalScoreWithoutMods	2024-04-17 08:51:53 +02:00
Bartłomiej Dach	6c943681b0	Fix preview tracks playing after their owning overlay has hidden ... RFC. Closes https://github.com/ppy/osu/issues/27883. The idea here is that `PopOut()` is called _when the hide is requested_, so once an overlay trigger would hide, the overlay would `StopAnyPlaying()`, but because of async load things, the actual track would start playing after that but before the overlay has fully hidden. (That last part is significant because after the overlay has fully hidden, schedules save the day.) Due to the loose coupling between `PreviewTrackManager` and `IPreviewTrackOwner` there's really no easy way to handle this locally to the usages of the preview tracks. Heck, `PreviewTrackManager` doesn't really know which preview track owner is to be considered _present_ at any time, it just kinda works on vibes based on DI until the owner tells all of its preview tracks to stop. This solution causes the preview tracks to stop a little bit later but maybe that's fine? Just trying to not overthink the issue is all. No tests because this is going to suck to test automatically while it is pretty easy to test manually (got it in a few tries on master). The issue also mentions that the track can sometimes resume playing after the overlay is pulled up again, but I don't see that as a problem necessarily, and even if it was, it's not going to be that easy to address due to the aforementioned loose coupling - to fix that, play buttons would have to know who is the current preview track owner and cancel schedules upon determining that their preview track owner has gone away.	2024-04-16 16:19:26 +02:00
Arthur Araujo	c32d99250f	Deal with corrupt audio files ... This removes the corrupt file check from CheckTooShortAudioFiles and makes the audio formats checks deal with it instead to avoid redundant messages.	2024-04-16 06:53:55 -03:00
Bartłomiej Dach	d2a67d2d54	Merge pull request #27881 from smoogipoo/fix-mod-refilter ... Don't re-filter unless mods may change the filter	2024-04-16 11:21:35 +02:00
Arthur Araujo	9ef27104ce	Add checks for audio formats	2024-04-16 06:15:21 -03:00
Joseph Madamba	514e316b49	Make getDatabasedScoreInfo() private and move to GetScore() and Export()	2024-04-15 20:48:51 -07:00
Joseph Madamba	67cfcddc77	Use another beatmap query to not depend on databased score info	2024-04-15 20:18:24 -07:00
Dean Herbert	a651cb8d50	Stop background processing from running when inside a high performance session	2024-04-16 10:04:38 +08:00
Dean Herbert	d89edd2b4f	Expose high performance session state	2024-04-16 10:04:38 +08:00
Dan Balasescu	343b3ba0e6	Don't re-filter unless mods may change the filter	2024-04-15 21:07:36 +09:00
Bartłomiej Dach	7c4c8ee75c	Fix stable scores showing with faded out pp display due to classic mod presence	2024-04-15 11:53:05 +02:00
Joseph Madamba	ed8b596325	Fix replay export not working correctly from online leaderboards	2024-04-14 16:22:58 -07:00
Joseph Madamba	f282152f99	Enable NRT to ScoreManager	2024-04-14 15:53:29 -07:00
Ondřej Vajďák	ed6680a61d	Fixed type inconsistency and rounding	2024-04-14 15:10:05 +02:00
Ondřej Vajďák	9833dd955f	Fix toolbar volume bar masking	2024-04-14 01:30:59 +02:00
Loreos7	5a8b8908dd	fix missing underscore	2024-04-13 14:53:51 +03:00
Dean Herbert	c0dce94f15	Fix newly placed items in skin editor not getting correct anchor placement	2024-04-12 17:08:49 +08:00
Dean Herbert	3ec93745a4	Fix test failures due to sentry oversight	2024-04-12 01:10:42 +08:00
Dan Balasescu	8b2017be45	Update Sentry to fix iOS build	2024-04-12 01:02:40 +09:00
Dan Balasescu	e9b319f4c6	Ensure all remaining objects are added in the last iteration	2024-04-12 00:11:54 +09:00
Dan Balasescu	19cc847be6	Implement a less failure-prone method	2024-04-11 23:40:40 +09:00
Dan Balasescu	f5555b9fa4	Also add potentially missed intermediate parents	2024-04-11 16:53:08 +09:00
Bartłomiej Dach	518addf323	Merge branch 'master' into fix-catmull-bulbs	2024-04-10 11:25:02 +02:00
Dean Herbert	6cb5bffdfc	Update resources	2024-04-10 13:03:37 +08:00
Dan Balasescu	fefcd17db9	Fix gameplay PP counter not matching results screen	2024-04-08 22:34:11 +09:00
Bartłomiej Dach	d6b1e68ee7	Merge branch 'master' into update-hit-error-icons	2024-04-05 09:36:18 +02:00
Dan Balasescu	7b92c725b1	Revert "Merge pull request #27454 from EVAST9919/sb-lifetime-improvements" ... This reverts commit 0881e7c8c1, reversing changes made to 29a37e3585.	2024-04-05 14:45:49 +09:00
Dean Herbert	10d1308a0a	Update resources	2024-04-04 15:05:59 +08:00
Dan Balasescu	cd474de61f	Update osu.Framework package	2024-04-04 15:55:05 +09:00
Dean Herbert	9521c1e3e4	Update hit error metre to use new icons ... - [ ] Depends on https://github.com/ppy/osu-resources/pull/317.	2024-04-04 14:31:40 +08:00
Dean Herbert	2e1d63a1c2	Merge pull request #27783 from 64ArthurAraujo/add-invalid-beatmap-hash-custom-message ... Add custom message in the case of a `invalid beatmap_hash`	2024-04-04 10:47:22 +08:00
Arthur Araujo	9e92ebaa43	Make message more general ... Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>	2024-04-03 19:15:22 -03:00
Arthur Araujo	8e00368f7c	Add custom message in the case of a invalid beatmap_hash	2024-04-03 11:30:14 -03:00
Bartłomiej Dach	9d54f1a092	Fix some maps requiring multiple intro skips that weren't there on stable ... Closes https://github.com/ppy/osu/issues/25633. The reason why that particular beatmap did not have a double skip on stable is here: e53980dd76/osu!/GameModes/Play/Player.cs#L1761-L1770 The particular place of interest is the `leadInTime < 10000` check. If `leadInTime < 10000`, then `leadIn == leadInTime`, and it turns out that `AudioEngine.Time` will always be more than or equal to `leadIn`, because it's also the gameplay start time: e53980dd76/osu!/GameModes/Play/Player.cs#L2765 This essentially means that if the `leadInTime` is less than 10000, that particular check is just dead. So a double skip can only occur if the gameplay starts at time -10000 or earlier due to the storyboard.	2024-04-03 16:12:20 +02:00
Mafalda Fernandes	16276dfcd6	Fix #27105: Mod search box doesnt track external focus changes ... In the Mod selection area, the search bar's focus could be changed by pressing TAB. However, when clicking outside of the search bar, the focus would be killed but two TABs were required to get the focus back on the search bar. This happened because the action of clicking in an empty area would trigger the search bar to change its appearence, but not its internal state. In my solution, I made the OnClick function aware of the search bar's state, so it would not only change its appearance, but also its state. Now, after clicking in an empty area, there is only needed one TAB to select the search box again, as expected.	2024-04-03 14:06:11 +01:00
Bartłomiej Dach	6d6412afdf	Merge branch 'master' into fix-skineditor-external-event-bind	2024-04-03 11:42:15 +02:00
Bartłomiej Dach	05fe8968d8	Only interact with clipboard via bound copy	2024-04-03 11:39:12 +02:00
Dan Balasescu	ce68f6adb7	Fix SkinEditor binding event to external bindable	2024-04-03 17:46:26 +09:00
Dan Balasescu	b5adcf2e0e	Fix SpectatorClient holding references to Player	2024-04-03 17:32:02 +09:00
Bartłomiej Dach	cb82fb0487	Merge branch 'master' into mania-key-count-mod-query	2024-04-03 09:29:32 +02:00
Dean Herbert	94cbe1838f	Replace usages of is null with == null	2024-04-03 01:50:39 +08:00
Dean Herbert	aa7b357063	Merge pull request #27768 from 64ArthurAraujo/editor-fix-sliders-same-start-time-merge ... Fix merging sliders with the same `StartTime` causing a Unhandled Exception	2024-04-03 01:45:55 +08:00
Arthur Araujo	2a2a372595	Check if blueprint is in SelectionBlueprints before changing its depth	2024-04-02 07:45:27 -03:00
Dean Herbert	51e9348d27	Merge pull request #26702 from honguyenminh/fix-rotate-editor-button-disabled ... Fix rotate tool button in editor disabled when selecting 1 circle	2024-04-02 14:31:43 +08:00
Dan Balasescu	4806ea54f1	Only optimise Catmull segments in osu ruleset	2024-04-01 17:22:50 +09:00
Dan Balasescu	d12a2e7df7	Replace schedule with SequenceEqual()	2024-04-01 17:02:02 +09:00
Dean Herbert	95b50576bd	Merge pull request #27698 from bdach/banish-rulesets-that-do-stupid-crap-to-the-BLAGOLE ... Attempt to disable custom rulesets that can be linked to an unhandled crash	2024-04-01 15:47:47 +08:00
Andrei Zavatski	11b1135804	Adjust blurred icons position due to size handling differences	2024-03-31 01:55:34 +03:00
Andrei Zavatski	58a68e94af	Simplify glowing icons in break overlay	2024-03-31 01:44:54 +03:00
Andrei Zavatski	54472e6452	Decouple GlowingDrawable from GlowingSpriteText	2024-03-31 01:44:54 +03:00
Nguyên Minh Hồ	6f782266b5	Fix inspection	2024-03-30 17:28:57 +07:00
Nguyên Minh Hồ	5d497ba4a8	Simplify TooltipText for EditorRadioButton	2024-03-30 16:04:22 +07:00
Nguyên Minh Hồ	9950395e5f	Merge branch 'fix-rotate-editor-button-disabled' of https://github.com/honguyenminh/osu into fix-rotate-editor-button-disabled	2024-03-30 13:57:44 +07:00
Nguyên Minh Hồ	113dbcd10f	Merge branch 'master' into fix-rotate-editor-button-disabled	2024-03-30 13:56:31 +07:00
Dan Balasescu	48f8d9c916	Merge pull request #27756 from bdach/pp-on-results-provisional ... Apply partial fade on pp display on results screen when score will not give pp	2024-03-29 19:57:59 +09:00
Bartłomiej Dach	5371141d3b	Merge pull request #27755 from peppy/fix-import-weirdness ... Avoid reporting an import as successful when all beatmaps failed to import	2024-03-29 11:25:41 +01:00
Bartłomiej Dach	e06df34a1c	Apply partial fade on pp display on results screen when score will not give pp	2024-03-29 11:16:31 +01:00
Bartłomiej Dach	2d3b273974	Remove redundant string interpolation	2024-03-29 10:37:49 +01:00
Dean Herbert	233b9eb172	Avoid reporting an import as successful when all beatmaps failed to import	2024-03-29 17:11:55 +08:00
Dean Herbert	d9cf5b5440	Fix bindable not being correctly re-bound across local user changes	2024-03-29 15:50:10 +08:00
Dean Herbert	fef8afb833	Fix double binding causing game crash after API enters failing state ... See https://sentry.ppy.sh/organizations/ppy/issues/33406/?alert_rule_id=4&alert_timestamp=1711655107332&alert_type=email&environment=production&project=2&referrer=alert_email	2024-03-29 12:19:14 +08:00
Dan Balasescu	6e746a0fa0	Fix carousel reoder on initial enter	2024-03-28 23:56:46 +09:00
Dan Balasescu	9fd6449fd8	Add mods to FilterCriteria, pass to ruleset method	2024-03-28 23:03:26 +09:00
Dan Balasescu	10edb54614	Add ability to query key count with mods	2024-03-28 22:51:12 +09:00
Dan Balasescu	5febd40bd9	Add HP and AR to LegacyBeatmapConversionDifficultyInfo	2024-03-28 22:30:39 +09:00
Susko3	53900d5472	Fix tests failing locally due to not using invariant culture	2024-03-27 18:56:26 +01:00
Dan Balasescu	600098d845	Fix bulbs on Catmull sliders	2024-03-27 04:05:04 +09:00
Bartłomiej Dach	6ef54321c4	Merge pull request #26707 from peppy/beat-sync-container-early-adjust ... Adjust `BeatSyncContainer`'s early animate offset based on source's rate	2024-03-26 18:43:25 +01:00
Bartłomiej Dach	0b29a762b8	Add precautionary guard to avoid potential div-by-zero ... Probably wouldn't happen outside of tests, but I'd rather not find out next release.	2024-03-26 17:36:40 +01:00
Dean Herbert	a5f15a119e	Apply rate adjust fix in all cases rather than specifically for Clock.Rate == 1	2024-03-26 22:51:54 +08:00
Dean Herbert	eae8e243c6	Merge branch 'master' into beat-sync-container-early-adjust	2024-03-26 21:31:33 +08:00
Bartłomiej Dach	bc1ffb0b6e	Merge branch 'master' into shared-menu-content	2024-03-26 13:47:44 +01:00
Dean Herbert	e77d4c8cfa	Remove unnecessary Math.Max	2024-03-26 20:28:03 +08:00
Dean Herbert	fd649edaba	Also don't rotate images during a drag operation	2024-03-26 20:21:48 +08:00