Dean Herbert
e0dea4c941
Merge pull request #10775 from bdach/disable-kiai-explosion-on-legacy
2020-11-11 18:06:31 +09:00
Dean Herbert
8706b51b77
Merge pull request #10717 from smoogipoo/dho-apply
2020-11-11 10:54:24 +09:00
Bartłomiej Dach
35763a74fd
Add test scene
2020-11-10 14:08:13 +01:00
smoogipoo
4ea823e4dc
Fix test failures
2020-11-10 22:02:33 +09:00
kamp
ceb17764b1
Also replace / with - for args in other task.jsons
2020-11-07 01:09:21 +01:00
Dean Herbert
1a0171fb2d
Fix tests specifying steps in their constructors
2020-10-02 18:23:18 +09:00
smoogipoo
f439c1afbc
Make osu/taiko/catch use Ok+Great
2020-09-29 17:16:55 +09:00
smoogipoo
4ef7ab2872
Fix tests
2020-09-29 16:33:38 +09:00
Bartłomiej Dach
0563a488f4
Add failing test case
2020-09-26 20:45:18 +02:00
Bartłomiej Dach
b1e02db874
Extract base taiko drawable ruleset scene
2020-09-26 20:36:38 +02:00
Bartłomiej Dach
095686a320
Hide test hit directly in explosion scene
2020-09-26 17:26:26 +02:00
Bartłomiej Dach
b64e69fabd
Add test hits to playfields directly where possible
2020-09-26 17:18:50 +02:00
Dean Herbert
a72629437d
Merge pull request #10250 from smoogipoo/fix-taiko-crash
...
Fix potential taiko crash on rewind
2020-09-25 20:24:22 +09:00
smoogipoo
0853f0e128
Remove comment
2020-09-25 19:38:23 +09:00
smoogipoo
acfa62bb50
Fix potential taiko crash on rewind
2020-09-25 19:25:58 +09:00
Dean Herbert
c41fb67e73
Move all ruleset editor tests to their own namespace
2020-09-25 18:51:26 +09:00
Bartłomiej Dach
a0573af0e1
Fix test failure due to uninitialised drawable hit object
2020-09-20 20:44:31 +02:00
Bartłomiej Dach
026fc2023b
Add visual tests for strong hit explosions
2020-09-20 19:40:30 +02:00
Bartłomiej Dach
64b1a009ef
Adjust diffcalc test case to pass
2020-09-10 20:56:55 +02:00
smoogipoo
d700ae55fb
Merge branch 'master' into morth-taiko-changes
2020-09-10 16:34:09 +09:00
smoogipoo
679dc34aa4
Add test timeouts
2020-09-07 17:18:54 +09:00
smoogipoo
d387c0cba0
Merge branch 'master' into morth-taiko-changes
2020-09-03 17:35:26 +09:00
dependabot-preview[bot]
66c0d12da6
Bump Microsoft.NET.Test.Sdk from 16.7.0 to 16.7.1
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.7.0 to 16.7.1.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.7.0...v16.7.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-01 17:19:46 +00:00
smoogipoo
90189fc40c
Merge branch 'master' into morth-taiko-changes
2020-08-13 00:31:10 +09:00
dependabot-preview[bot]
d7de8b2916
Bump Microsoft.NET.Test.Sdk from 16.6.1 to 16.7.0
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.6.1 to 16.7.0.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.6.1...v16.7.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-10 17:17:07 +00:00
Bartłomiej Dach
566c5310bf
Add test coverage for taiko sample lookups
2020-07-30 21:34:57 +02:00
smoogipoo
c1a4f2e6af
Update expected SR in test
2020-07-29 20:53:50 +09:00
Bartłomiej Dach
f7a330becd
Fix tests failing due to not checking state early enough
2020-07-25 13:32:06 +02:00
Bartłomiej Dach
897ab4a9bb
Add example test resources to demonstrate fail case
2020-07-25 11:53:38 +02:00
Dean Herbert
c1442568b9
Make perfect mod ignore all non-combo-affecting hitobjects
2020-07-21 17:04:45 +09:00
Dean Herbert
cc62d8911a
Merge pull request #9573 from smoogipoo/taiko-diffcalc-fixes-2
2020-07-16 14:59:06 +09:00
smoogipoo
dcd345eed9
Add a few tests
2020-07-16 01:35:38 +09:00
dependabot-preview[bot]
8087a75c35
Bump NUnit3TestAdapter from 3.15.1 to 3.17.0
...
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter ) from 3.15.1 to 3.17.0.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases )
- [Commits](https://github.com/nunit/nunit3-vs-adapter/compare/V3.15.1...V3.17 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-13 17:22:39 +00:00
Salman Ahmed
741fa20149
Use CreateRuleset() for editor test scenes as well
2020-06-04 00:47:10 +03:00
Salman Ahmed
84b40ea2c6
Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset
...
# Conflicts:
# osu.Game.Rulesets.Catch.Tests/TestSceneBananaShower.cs
# osu.Game.Rulesets.Catch.Tests/TestSceneHyperDash.cs
# osu.Game/Tests/Visual/ModTestScene.cs
# osu.Game/Tests/Visual/OsuTestScene.cs
2020-06-03 22:00:02 +03:00
Dean Herbert
da289c474e
Split files out
2020-05-29 16:45:47 +09:00
Dean Herbert
3487c1fd1b
Add menus to mark as rim and strong
2020-05-29 16:45:47 +09:00
Dean Herbert
90acba8c36
Introduce initial placement blueprint logic
2020-05-29 16:45:39 +09:00
Dean Herbert
7d4e60f05e
Add basic setup for TaikoHitObjectComposer
2020-05-29 16:45:39 +09:00
Dean Herbert
76080368e9
Mark test as headless
2020-05-20 10:14:08 +09:00
Dean Herbert
db4e3047dd
Add test for final sample output
2020-05-19 23:28:13 +09:00
Dean Herbert
e9710b6f83
Add taiko type conversion test coverage
2020-05-19 09:43:05 +09:00
Dean Herbert
be3a0a3c1d
Merge branch 'master' into remove-requiredtypes
2020-05-16 18:28:14 +09:00
smoogipoo
648999a2de
Remove all RequiredTypes usages
2020-05-16 18:17:12 +09:00
smoogipoo
4bf5477252
Merge branch 'master' into fix-taiko-scroller-time-control
2020-05-14 17:04:09 +09:00
Dean Herbert
134a94e86d
Rename enum members (no idea what a TaikoDon is)
2020-05-14 10:02:47 +09:00
Dean Herbert
76af6f25f1
Remove pointless test resources
2020-05-14 09:58:58 +09:00
Dean Herbert
e28e89213f
Fix incorrect spawning when scale adjustments are applied to child sprites
2020-05-12 16:58:47 +09:00
Dean Herbert
949e17cc0e
Rework scroller to support backwards playback
2020-05-12 15:23:47 +09:00
Bartłomiej Dach
e5821ff2b2
Integrate GameplayBeatmap changes
2020-05-11 22:53:05 +02:00
Dan Balasescu
d697de29a6
Merge branch 'master' into taiko-don
2020-05-11 13:24:27 +09:00
Dean Herbert
8243dc239a
Merge branch 'master' into taiko-don
2020-05-10 22:34:47 +09:00
Dean Herbert
cea6be5e52
Expose as JudgementResult instead of "passing" state
2020-05-03 23:55:44 +09:00
Dean Herbert
ff1d63060d
Add and consume passing state in GameplayBeatmap
2020-05-01 20:08:18 +09:00
Dean Herbert
3033ab80ce
Add passing/failing test
2020-05-01 19:49:30 +09:00
Dean Herbert
5e430c726c
Add testing resources
2020-05-01 19:25:55 +09:00
Dean Herbert
8955b98cbb
Add basic taiko scroller implementation
2020-05-01 17:56:09 +09:00
Bartłomiej Dach
05183c6e6f
Final test touch-ups
2020-05-01 00:24:39 +02:00
Bartłomiej Dach
db4c8b2ba5
Fix transition out of clear state
2020-04-30 22:16:25 +02:00
Bartłomiej Dach
5cfc05e12a
Ensure correct initial state
2020-04-30 22:03:39 +02:00
Bartłomiej Dach
22fde8d2a0
Implement partial clear transition logic
2020-04-30 21:58:05 +02:00
Bartłomiej Dach
99677ac171
Expand test coverage of state transitions
2020-04-30 21:41:57 +02:00
Dean Herbert
d0a8c0fa71
Add kiai support to osu!taiko skinned playfields
2020-04-30 16:43:00 +09:00
Bartłomiej Dach
b0e97793b6
Implement transitions into and from clear state
2020-04-30 00:14:27 +02:00
Bartłomiej Dach
47b040b7d8
Cover strong hit miss exemption in tests
2020-04-29 21:42:28 +02:00
Bartłomiej Dach
e81d33dcec
Refactor mascot animations to split logic paths
2020-04-29 21:27:02 +02:00
Bartłomiej Dach
6e2ed0c4f3
Refactor mascot to only contain state transitions
2020-04-29 20:28:46 +02:00
Craftplacer
c61584bc2f
Merge branch 'taiko-don' of https://github.com/Craftplacer/osu into taiko-don
2020-04-28 23:51:34 +02:00
Bartłomiej Dach
d7b072dd6e
Fix post-merge test regression
2020-04-29 00:00:01 +02:00
Bartłomiej Dach
5f0a4103c2
Merge branch 'master' into taiko-don
2020-04-28 23:46:42 +02:00
Bartłomiej Dach
e7e529ab99
Remove unnecessary null checks
2020-04-28 23:26:10 +02:00
Bartłomiej Dach
15bbedca87
Remove unnecessary beatmap field
2020-04-28 23:24:21 +02:00
Bartłomiej Dach
24216b6600
Remove unnecessary lists
2020-04-28 23:22:50 +02:00
Craftplacer
902326e7ac
Slight refactoring
2020-04-28 22:24:19 +02:00
Dean Herbert
f387fe310f
Fix regressing hits test
2020-04-28 11:07:31 +09:00
Craftplacer
c8ee941952
Fix formatting
2020-04-27 23:17:33 +02:00
Craftplacer
0972442b3a
Use test scene beatmap bindable
2020-04-27 23:17:19 +02:00
Dean Herbert
df55439f8b
Remove undetected usings
2020-04-27 23:24:12 +09:00
Dean Herbert
be59ee945a
Add taiko hit explosion skinning support
2020-04-27 22:36:27 +09:00
Craftplacer
ece6e2db5c
Change removed class
2020-04-27 13:12:31 +02:00
Craftplacer
e8a0b77729
Merge remote-tracking branch 'upstream/master' into taiko-don
2020-04-27 12:43:51 +02:00
dependabot-preview[bot]
03863d901b
Bump Microsoft.NET.Test.Sdk from 16.5.0 to 16.6.1
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.5.0 to 16.6.1.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.5.0...v16.6.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-27 08:59:09 +00:00
Dean Herbert
b9f28c8373
Combine hit types and remove old drumroll hits using a more efficient method
2020-04-27 16:13:28 +09:00
Dean Herbert
1cd4fd2ac4
Merge branch 'master' into taiko-drumroll-party
2020-04-27 13:27:10 +09:00
smoogipoo
81df22d2a7
Improve test scene
2020-04-27 12:17:36 +09:00
Craftplacer
e830c7d833
Merge remote-tracking branch 'upstream/master' into taiko-don
2020-04-27 02:13:09 +02:00
Craftplacer
dc6acf6ec9
Various code changes, fixes
2020-04-27 01:40:57 +02:00
Dean Herbert
75c588c59d
Remove stray space
2020-04-27 08:36:48 +09:00
Dean Herbert
743b4f05b3
Rename out of place variable
2020-04-27 08:36:36 +09:00
Dean Herbert
4ca7ce7715
Merge branch 'master' into taiko-barline-skinning
2020-04-25 18:58:44 +09:00
Craftplacer
dbf39be607
Decide on the name "Mascot", add testing, bug fixed, etc.
2020-04-24 06:59:05 +02:00
Dean Herbert
dba737105e
Update test scene for dynamic compilation
2020-04-24 08:57:01 +09:00
Salman Ahmed
227503c0af
Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset
2020-04-23 16:25:33 +03:00
Salman Ahmed
2fa47992dc
Seal the ruleset creation methods and let abstract method take their place
...
Also makes `CreatePlayerRuleset()` and `CreateRulesetForSkinProvider()` not-null to avoid unwanted behaviour with their derivers
2020-04-23 13:27:12 +03:00
Dean Herbert
712331a2fe
Add metric barline element
2020-04-23 15:26:20 +09:00
Dean Herbert
ab93c819b5
Add metric right background element
2020-04-23 15:26:03 +09:00
Dean Herbert
8f31846def
Add playfield background to test scene to better understand bounds
2020-04-23 14:39:34 +09:00
Dean Herbert
2a1cc35541
Add test scene
2020-04-23 14:01:50 +09:00
Dean Herbert
559487b205
Move playfield background implementation to its own file
2020-04-23 13:23:49 +09:00
Dean Herbert
37f7e0a734
Restructure TaikoPlayfield for better skin support
2020-04-23 12:49:53 +09:00
Dean Herbert
ca56e6c0d2
Rename taiko HitTarget classes to avoid conflict with mania
2020-04-23 12:11:30 +09:00
Dean Herbert
bfc17bf4c0
Add taiko hit target skinning
2020-04-21 19:06:43 +09:00
Dean Herbert
e74f902483
Add playfield test scene
2020-04-21 18:40:18 +09:00
Dean Herbert
d1c701a997
Rename existing test to something more relevant
2020-04-21 18:34:56 +09:00
Dean Herbert
af32f51116
Merge pull request #8800 from iiSaLMaN/allow-cancelling-completion
...
Fix results screen pushed after rewinding in-between push delay
2020-04-21 12:49:49 +09:00
Salman Ahmed
fc6c245de5
Replace all judged event logic with HasCompleted bindable
2020-04-19 05:36:04 +03:00
Salman Ahmed
155bc8b49a
Remove ModTestScene ruleset parameter on constructor and use CreateRuleset instead
2020-04-17 11:17:59 +03:00
Salman Ahmed
92df4e3a9e
Remove PlayerTestScene constructor and use CreateRuleset method instead
2020-04-17 11:17:51 +03:00
Salman Ahmed
5fa6bcb5a3
Move SkinnableTestScene into using the global CreateRuleset method
2020-04-17 11:17:44 +03:00
Dean Herbert
3137417994
Add drumroll skinning
2020-04-15 18:03:23 +09:00
Dean Herbert
45d88b70f8
Split out base logic from LegacyHit into LegacyCirclePiece
2020-04-15 18:03:23 +09:00
Dean Herbert
18c28390ef
Setup drumroll testing
2020-04-15 16:29:39 +09:00
Dean Herbert
019e777d7d
Move taiko skinning tests to own namespace
2020-04-15 16:01:49 +09:00
Dean Herbert
bf938a37e3
Add old skin test resources (with "animation")
2020-04-11 15:00:39 +09:00
Dean Herbert
96bf86099c
Fix scaling of strong hits
2020-04-11 14:43:57 +09:00
Dean Herbert
dc56be0a1d
Add support for skinned hits
2020-04-11 14:23:13 +09:00
Dean Herbert
ca2df77c76
Add default skin test resources
2020-04-11 14:19:59 +09:00
Dean Herbert
7fba291134
Change inheritance of taiko hit pieces to better allow for skinning
2020-04-11 13:33:49 +09:00
Dean Herbert
40267cb1fe
Add test sprites and make alignment initially better
2020-04-08 19:42:31 +09:00
Dean Herbert
2c840c52a3
Add skinnable test scene per ruleset to better allow dynamic compilation
2020-04-07 16:20:13 +09:00
Dean Herbert
0a7d9b930c
Add osu!taiko legacy drum skinning support
2020-04-03 18:23:03 +09:00
smoogipoo
5106d275ca
Remove CentreHit/RimHit hitobject abstraction
2020-03-23 12:08:15 +09:00
Dean Herbert
0be423183d
Rename data class
2020-03-11 00:36:56 +09:00
Dean Herbert
5b8aaba4a6
Merge branch 'master' into fix-perfect-judgements
2020-03-06 00:18:05 +09:00
Dean Herbert
5200633f9f
Centralise TestPlayer implementations as much as possible
2020-03-05 11:25:07 +09:00
smoogipoo
d11d29c1f7
Adjust namespaces
2020-03-03 15:30:53 +09:00
smoogipoo
e58fb3f528
Make default taiko HP 1 for test scene
2020-03-02 13:25:16 +09:00
smoogipoo
6d939e9d41
Add failing test scenes
2020-03-02 12:42:48 +09:00
smoogipoo
239cfddcbb
Improve test scenes/cases
2020-03-02 10:50:41 +09:00
smoogipoo
a02c5710ac
Rename base class
2020-03-02 10:06:49 +09:00
voidedWarranties
089ec4c792
Test scene for mod development
2020-02-29 21:16:28 -08:00
Dean Herbert
a047456354
Revert changes to make HitObject abstract
2020-02-25 19:07:15 +09:00
Dean Herbert
ffc7eaa3f2
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
...
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.
This fixes BananaShower and JuiceStreams in osu!catch.
This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
dependabot-preview[bot]
48781e5685
Bump Microsoft.NET.Test.Sdk from 16.4.0 to 16.5.0
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.4.0 to 16.5.0.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.4.0...v16.5.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-10 08:24:12 +00:00
smoogipoo
91735ff367
Update MathUtils namespace usages
2020-01-09 13:43:44 +09:00
smoogipoo
2688a855a0
Downgrade NUnit to fix discovery issues
2020-01-08 14:14:46 +09:00
dependabot-preview[bot]
f91637e7b6
Bump NUnit3TestAdapter from 3.15.1 to 3.16.0
...
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter ) from 3.15.1 to 3.16.0.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases )
- [Commits](https://github.com/nunit/nunit3-vs-adapter/compare/V3.15.1...V3.16 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-06 07:41:37 +00:00
Dean Herbert
492a910671
Update missed launch configurations
2019-12-20 19:08:05 +09:00
Huo Yaoyuan
351e826120
Upgrade project targets to netcoreapp3.1
2019-12-20 17:03:54 +08:00
Dean Herbert
bc31146560
Mods -> SelectedMods
2019-12-13 21:45:38 +09:00
smoogipoo
5861eca80d
Make DrawableRuleset take a converted beatmap
2019-12-12 15:58:11 +09:00
Dean Herbert
709ec1404f
Centralise End/StartTime retrieval to extension method
2019-11-25 19:09:14 +09:00
dependabot-preview[bot]
f2084df0bb
Bump Microsoft.NET.Test.Sdk from 16.3.0 to 16.4.0
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.3.0 to 16.4.0.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.3...v16.4.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-07 06:19:49 +00:00
Dean Herbert
e987db37ec
Add grouping of ControlPoints
2019-10-25 19:52:02 +09:00
Dean Herbert
1bf5f9313f
Fix failing test
2019-10-21 18:10:00 +09:00
Dean Herbert
5d6648d9c9
Update 2.2 references
2019-10-10 17:45:38 +09:00
Bartłomiej Dach
09864d7f0e
Add bar line visual check in taiko playfield test
...
Add a step checking alignment of a centre and a bar line in taiko
playfield. Purely visual test without asserts.
2019-09-24 23:02:39 +02:00
dependabot-preview[bot]
f10b390ca0
Bump Microsoft.NET.Test.Sdk from 16.2.0 to 16.3.0
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.2.0 to 16.3.0.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.2.0...v16.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-19 16:32:39 +00:00
Bartłomiej Dach
a407e267a2
Fix PF/SD legacy mod conversion
...
Upon investigating an user report in #6091 that indicated that viewing
replays using the Perfect mod would also display the Sudden Death mod
icon despite Perfect being the more restrictive of the two, it turned
out that the logic of importing legacy scores was missing that corner
case. A similar case of Double Time/Nightcore mutual exclusion was
handled, but PF/SD was missed.
Add analogous handling of PF/SD legacy mods for all four rulesets,
and additionally cover a tiny fraction of all cases with unit tests.
The most problematic cases (NC+HD and PF+SD) are covered in all four
basic rulesets.
2019-09-15 22:55:25 +02:00
Dean Herbert
f925e781a9
Refactor HitWindows for legibility
2019-09-06 15:24:14 +09:00
