11504 Commits

Author	SHA1	Message	Date
Dean Herbert	f07a635447	Merge pull request #28630 from peppy/fix-long-note-break-woes	2024-06-27 15:50:25 +09:00
Bartłomiej Dach	981340debe	Add safety test coverage for removal of breaks at end of beatmap	2024-06-27 07:45:59 +02:00
Salman Ahmed	e4335a543e	Add failing test case ... Includes a refactor of `ThemeComparisonTestScene` to allow accessing a manual input manager.	2024-06-27 06:41:44 +03:00
Dean Herbert	bbacfc8d23	Add failing test coverage of osu!mania automated break creation scenarios	2024-06-27 12:10:10 +09:00
Bartłomiej Dach	fff27e619d	Fix slider tail volume not saving ... Closes https://github.com/ppy/osu/issues/28587. As outlined in the issue thread, the tail volume wasn't saving because it wasn't actually attached to a hitobject properly, and as such the `LegacyBeatmapEncoder` logic, which is based on hitobjects, did not pick them up on save. To fix that, switch to using `NodeSamples` for objects that are `IHasRepeats`. That has one added complication in that having it work properly requires changes to the decode side too. That is because the intent is to allow the user to change the sample settings for each node (which are specified via `NodeSamples`), as well as "the rest of the object", which generally means ticks or auxiliary samples like `sliderslide` (which are specified by `Samples`). However, up until now, `Samples` always queried the control point which was _active at the end time of the slider_. This obviously can't work anymore when converting `NodeSamples` to legacy control points, because the last node's sample is _also_ at the end time of the slider. To bypass that, add extra sample points after each node (just out of reach of the 5ms leniency), which are supposed to control volume of ticks and/or slides. Upon testing, this *sort of* has the intended effect in stable, with the exception of `sliderslide`, which seems to either respect or _not_ respect the relevant volume spec dependent on... not sure what, and not sure I want to be debugging that. It might be frame alignment, or it might be the phase of the moon.	2024-06-26 15:52:16 +02:00
Bartłomiej Dach	8f0198ba0f	Add test coverage for encode-after-decode stability of slider sample volume specs	2024-06-26 15:42:13 +02:00
Dean Herbert	ac235cb506	Remove unused local variable	2024-06-26 16:22:25 +09:00
Bartłomiej Dach	006184ed2f	Implement carousel container for daily challenge screen	2024-06-26 08:49:00 +02:00
Dean Herbert	0c8279c5df	Remove unused using statements	2024-06-26 14:50:53 +09:00
Salman Ahmed	fa46d8e6c9	Fix intermittent failure in online menu banner tests	2024-06-26 08:39:55 +03:00
Dean Herbert	aadb104851	Merge pull request #28589 from bdach/scale-handling-crash ... Fix crashes when opening scale/rotation popovers during selection box operations	2024-06-26 00:11:03 +09:00
Dean Herbert	d722be16e3	Add missing base calls for safety	2024-06-25 23:41:43 +09:00
Dean Herbert	3d22f700a7	Merge pull request #28561 from bdach/daily-challenge/score-breakdown ... Implement score breakdown display for daily challenge screen	2024-06-25 23:34:47 +09:00
Bartłomiej Dach	18e2a925a8	Add failing test coverage for manual breaks at start/end of map not being culled	2024-06-25 12:34:37 +02:00
Bartłomiej Dach	66b093b17e	Implement score breakdown display for daily challenge screen	2024-06-24 10:09:10 +02:00
Salman Ahmed	2efafcaf5b	Remove stale comment	2024-06-23 08:46:55 +03:00
Salman Ahmed	1298b98534	Update test coverage	2024-06-23 08:22:54 +03:00
Salman Ahmed	04efa61156	Add different display for mod customisation	2024-06-23 08:22:13 +03:00
Dean Herbert	14104e57d4	Merge branch 'master' into timeline-drag-selection-crash	2024-06-20 15:16:10 +09:00
Dean Herbert	00443403b6	Merge branch 'master' into break-autogeneration	2024-06-19 21:49:17 +09:00
Bartłomiej Dach	8757e08c2c	Fix test failures due to automatic break generation kicking in	2024-06-19 11:32:08 +02:00
Bartłomiej Dach	4390798761	Add test coverage for automatic break generation	2024-06-19 11:14:38 +02:00
Bartłomiej Dach	6a6ccbc09f	Make list of breaks bindable	2024-06-19 07:44:03 +02:00
Bartłomiej Dach	5551bae7ce	Merge branch 'master' into navigate-to-timestamp	2024-06-18 18:32:33 +02:00
Bartłomiej Dach	7ee29667db	Parse plain numbers as millisecond count when parsing timestamp	2024-06-18 16:48:04 +02:00
Bartłomiej Dach	623055b60a	Fix tests	2024-06-18 16:41:13 +02:00
Givikap120	1ddfc8f011	Updated the tests according to new logic ... and fixed one minor CI code quality thing	2024-06-18 15:48:21 +03:00
Bartłomiej Dach	44b9a06639	Allow more lenient parsing of incoming timestamps	2024-06-18 13:13:50 +02:00
Bartłomiej Dach	659505f711	Adjust calls to GetContainingInputManager()	2024-06-18 07:41:19 +02:00
Dean Herbert	316125d47a	Merge pull request #23443 from OliBomby/edit-nodesample ... Make NodeSamples editable	2024-06-18 11:12:02 +09:00
Dean Herbert	a6f09bc626	Merge pull request #28468 from bdach/daily-challenge/event-feed ... Implement event feed view for daily challenge screen	2024-06-17 20:16:48 +09:00
Dean Herbert	15fbad0097	Merge pull request #28480 from bdach/storyboard-pass-fail-show ... Implement toggling visibility of pass and fail storyboard layers	2024-06-16 11:08:00 +09:00
Dean Herbert	6bd633f8ce	Apply NRT to test scene	2024-06-15 17:26:57 +08:00
Bartłomiej Dach	67ca7e4135	Implement toggling visibility of pass and fail storyboard layers ... Closes https://github.com/ppy/osu/issues/6842. This is a rather barebones implementation, just to get this in place somehow at least. The logic is simple - 50% health or above shows pass layer, anything below shows fail layer. This does not match stable logic all across the board because I have no idea how to package that. Stable defines "passing" in like fifty ways: - in mania it's >80% HP (bb57924c15/osu!/GameModes/Play/Rulesets/Mania/RulesetMania.cs#L333-L336) - in taiko it's >80% *accuracy* (bb57924c15/osu!/GameModes/Play/Rulesets/Taiko/RulesetTaiko.cs#L486-L492) - there's also the part where "geki additions" will unconditionally set passing state (bb57924c15/osu!/GameModes/Play/Player.cs#L3561-L3564) - and also the part where at the end of the map, the final passing state is determined by checking whether the user passed more sections than failed (bb57924c15/osu!/GameModes/Play/Player.cs#L3320) The biggest issues of these are probably the first two, and they can *probably* be fixed, but would require a new member on `Ruleset` and I'm not sure how to make one look, so I'm not doing that at this time pending collection of ideas on how to do that.	2024-06-14 13:59:02 +02:00
Shiumano	bfca64a98e	Add failing test	2024-06-14 20:07:27 +09:00
Bartłomiej Dach	8b6385f7d0	Add failing test case demonstrating crash	2024-06-14 09:24:53 +02:00
Bartłomiej Dach	8c4aa84037	Implement event feed view for daily challenge screen	2024-06-13 09:05:45 +02:00
Bartłomiej Dach	2be6b29f21	Implement time remaining display for daily challenge screen	2024-06-12 11:43:24 +02:00
Bartłomiej Dach	2321e408cb	Add test scene for daily challenge screen	2024-06-10 13:12:20 +02:00
Bartłomiej Dach	dd6e9308b3	Extract user mod select button for reuse	2024-06-10 12:45:27 +02:00
Salman Ahmed	6201220994	Merge branch 'master' into footer-v2-become-global	2024-06-08 14:13:05 +03:00
Dean Herbert	daf85c320a	Merge pull request #22237 from mk56-spn/LeaderBoardScore_clean ... New leaderboard score card design implementation	2024-06-08 20:06:17 +09:00
Dean Herbert	7fc6ad5340	Merge pull request #28184 from frenzibyte/footer-v2-transitions ... Add basic animation to new footer and buttons	2024-06-08 19:43:23 +09:00
Salman Ahmed	5f8f6caedd	Use OsuGame.SHEAR	2024-06-07 22:45:22 +03:00
Salman Ahmed	6f729be573	Merge branch 'master' into LeaderBoardScore_clean	2024-06-07 22:42:49 +03:00
Bartłomiej Dach	199d31c0f4	Fix test not compiling ... A little ugly but maybe it'll do...	2024-06-07 09:54:00 +02:00
Bartłomiej Dach	4cd1ccc4d4	Merge branch 'master' into add-rank-display	2024-06-07 09:33:03 +02:00
Bartłomiej Dach	dd9c77d248	Fix obsoletion warning	2024-06-06 13:50:31 +02:00
Bartłomiej Dach	86b13074a0	Merge branch 'master' into edit-nodesample	2024-06-06 13:42:25 +02:00
OliBomby	d8994786f6	Merge remote-tracking branch 'upstream/master' into grids-2	2024-06-05 17:18:48 +02:00
Bartłomiej Dach	4fcb902341	Merge branch 'master' into grids-1	2024-06-03 12:33:51 +02:00
Dean Herbert	53b7c29488	Add test coverage of menu banner link opening	2024-05-31 03:15:26 +09:00
Dean Herbert	2f2bc8e52e	Avoid ChatAckRequest failures flooding console in OsuGameTestScenes	2024-05-30 17:37:55 +09:00
Dean Herbert	16e2fa2c6a	Merge branch 'master' into fix/editor-test-exit	2024-05-29 21:08:36 +09:00
Bartłomiej Dach	7b7e439d03	Merge branch 'master' into scale-tool	2024-05-29 10:15:48 +02:00
Bartłomiej Dach	4c881b5633	Use better name if we're renaming	2024-05-29 09:40:29 +02:00
Dan Balasescu	655b0f5343	Merge branch 'master' into negative-frame-handling	2024-05-29 13:14:59 +09:00
OliBomby	a89ba33b47	rename CanScaleSelectionOrigin/PlayfieldOrigin to make clear its not the origin being scaled	2024-05-28 16:14:16 +02:00
Dean Herbert	8c4931eeec	Merge branch 'master' into footer-v2-transitions	2024-05-28 18:49:39 +09:00
Dean Herbert	4408039b3e	Merge branch 'master' into footer-v2-back-button	2024-05-28 15:50:34 +09:00
Dean Herbert	75d961e6f2	Pass the same thing in twice for better maybe	2024-05-27 20:30:01 +09:00
Bartłomiej Dach	1f41261fc7	Fix test failure	2024-05-27 12:01:02 +02:00
Dean Herbert	740a3377fa	Merge branch 'master' into LeaderBoardScore_clean	2024-05-27 17:18:41 +09:00
Joseph Madamba	8e14c24ee3	Follow slanted flow logic precedent in test ... See `ModSelectOverlay` components.	2024-05-26 00:24:03 -07:00
Salman Ahmed	91fb5ed749	Move toggle step to SetUpSteps	2024-05-25 17:28:03 +03:00
Salman Ahmed	2c18c10ac8	Move to SelectV2 namespace	2024-05-25 17:20:10 +03:00
Salman Ahmed	d395c85418	Adjust right content width based on scoring mode	2024-05-25 17:16:41 +03:00
Salman Ahmed	5955378004	Replace "X mods" text with a pill indicator	2024-05-25 16:11:24 +03:00
Salman Ahmed	35af518fdb	Remove expanded/contracted states and limit to 5 mods ... Also adjusts right content width to contain those 5 mods. Not sure how to handle the extra space in the score though...to be dealt with later.	2024-05-25 12:52:48 +03:00
Salman Ahmed	1f01293783	Make scores slanted in test scene	2024-05-25 12:36:09 +03:00
Dean Herbert	2134ff7a1b	Merge pull request #28071 from Fabiano1337/lazer-speedkeys ... Make ctrl-up/down change speed modifier of mods	2024-05-24 23:20:04 +09:00
Bartłomiej Dach	9f19ab092d	Merge branch 'master' into grids-1	2024-05-24 14:39:55 +02:00
Bartłomiej Dach	c800bb5339	Merge branch 'master' into lazer-speedkeys	2024-05-24 13:19:26 +02:00
Bartłomiej Dach	63406b6feb	Rewrite implementation	2024-05-24 13:03:42 +02:00
Bartłomiej Dach	9045ec24ab	Rewrite test	2024-05-24 12:04:09 +02:00
Bartłomiej Dach	a80dbba9d0	Update to not use obsoleted method	2024-05-24 10:35:31 +02:00
Bartłomiej Dach	4089071299	Merge branch 'master' into fix-editor-didnt-save	2024-05-24 10:16:46 +02:00
Bartłomiej Dach	8a2dd4d816	Merge branch 'master' into scaling	2024-05-23 15:10:40 +02:00
Dean Herbert	84fe3699f6	Reorder test steps to work better on multiple runs	2024-05-23 14:32:25 +08:00
Dean Herbert	6c37560842	Merge branch 'master' into daily-challenge-mvp	2024-05-23 10:57:05 +08:00
Dean Herbert	ae27fc6944	Merge pull request #28200 from Hecatia-Lapislazuli/max-cs-scaling ... Enforce difficulty setting limits during decode	2024-05-23 09:30:15 +08:00
Dan Balasescu	0d13848421	Add whitespace to appease R#	2024-05-23 00:21:19 +09:00
Dean Herbert	093be3d723	Cast remaining test usages to IFocusManager to remove obsolete notice	2024-05-22 21:55:53 +08:00
Fabian van Oeffelt	abc67ebbac	Fix test not running due to floating point number inaccuacy	2024-05-22 13:59:26 +02:00
Aurelian	f3cae73e2e	Added tests for difficulty clamping	2024-05-22 13:26:00 +02:00
Dean Herbert	1fdebe94ac	Merge branch 'master' into lazer-speedkeys	2024-05-22 12:05:04 +08:00
Bartłomiej Dach	3b15c223be	Add failing test case	2024-05-20 15:05:39 +02:00
Bartłomiej Dach	85f85dee9e	Enable NRT in TestScenePresentScore	2024-05-20 14:46:28 +02:00
Fabian van Oeffelt	99f30d92c8	Add Unit Tests	2024-05-18 18:38:31 +02:00
Bartłomiej Dach	a4f8ed2a0e	Add button to access daily challenge playlist from main menu	2024-05-17 11:15:52 +02:00
Salman Ahmed	8b285f5b1e	Add dummy SongSelectV2 screen to house new footer buttons (and new components going forward)	2024-05-16 07:48:58 +03:00
Salman Ahmed	03220598b8	Move screen footer to OsuGame	2024-05-16 07:48:58 +03:00
Salman Ahmed	95840672cb	Clean up screen footer test scene	2024-05-16 07:48:10 +03:00
Salman Ahmed	a2794922d5	Add TopLevelContent layer for applying external transforms on footer buttons	2024-05-16 07:48:10 +03:00
Salman Ahmed	e3afd89dc8	Allow specifying height of ShearedButtons ... Also includes a test case in `TestSceneShearedButton`s to ensure the buttons' shear factors don't change on different heights (I've encountered issues with that previously).	2024-05-16 05:02:56 +03:00
Salman Ahmed	21f5d891bb	Rename and move footer classes to appropriate places	2024-05-16 04:41:16 +03:00
OliBomby	8df5f22b4e	Merge remote-tracking branch 'upstream/master' into scaling	2024-05-15 23:05:19 +02:00
Bartłomiej Dach	7f3fde2a25	Add failing test case	2024-05-14 11:13:06 +02:00
Dean Herbert	6cfe1356cd	Merge pull request #28141 from frenzibyte/footer-v2-mods-display ... Add mod display and unranked indicator to new song select footer	2024-05-11 21:41:25 +08:00
Dean Herbert	a988bbd3cb	Tidy up UnrankedBadge implementation	2024-05-11 20:58:51 +08:00
Salman Ahmed	bff34a1c04	Add localisation and tooltip for mods count text	2024-05-10 06:48:18 +03:00
Salman Ahmed	d7b658ec76	Add similar test steps to song select footer test scene	2024-05-10 02:21:06 +03:00
Salman Ahmed	6b91b4abf4	Add simple implementation for extended mods display in new footer design	2024-05-10 02:20:48 +03:00
Bartłomiej Dach	c9414da5d4	Merge branch 'master' into pre-mod-multiplier-score	2024-05-08 13:39:44 +02:00
Bartłomiej Dach	7551cf01d1	Fix test failure	2024-05-08 09:45:52 +02:00
Bartłomiej Dach	bd869b6cdc	Add failing tests for looking up users by online ID if present when importing scores	2024-05-06 13:24:24 +02:00
Bartłomiej Dach	554ead0d9d	Decode user ID from score if available	2024-05-06 12:28:13 +02:00
Bartłomiej Dach	761d713593	Merge pull request #28086 from 424ever/ctrl-keeps-menu-open ... Activate stateful menu items with right-click without closing the menu	2024-05-06 09:30:22 +02:00
Bartłomiej Dach	71776a583c	Merge branch 'master' into preset-td-autoplay	2024-05-06 09:02:08 +02:00
Bartłomiej Dach	cb4af79416	Touch up test case	2024-05-06 08:53:41 +02:00
Bartłomiej Dach	cf22fc143f	Merge pull request #27539 from frenzibyte/storyboard-loops-v2 ... Refactor storyboard commands structure and add framework-based transform loop support	2024-05-06 08:39:07 +02:00
Joseph Madamba	eb92e8de37	Edit title/artist unicode values and add unicode toggle in test	2024-05-05 15:43:46 -07:00
Jonas Brandstötter	78d6f24fca	Add Test	2024-05-04 16:27:06 +02:00
cdwcgt	6af30a3d45	add test for non-td system mod	2024-05-04 20:02:35 +08:00
cdwcgt	b35f2c99e6	add failed test	2024-05-04 18:43:04 +08:00
Dean Herbert	002efca422	Merge pull request #28082 from bdach/do-not-lookup-usernames-for-offline-scores ... Do not lookup usernames for scores without an online ID	2024-05-04 15:08:33 +08:00
Dean Herbert	ecb9173e51	Merge pull request #28017 from Joehuu/scrollable-text ... Scroll now playing overlay text when overflowing	2024-05-03 20:05:58 +08:00
Bartłomiej Dach	1b7652e60d	Add failing tests	2024-05-03 13:47:10 +02:00
Bartłomiej Dach	f57818f5a2	Add visual test coverage of private room status	2024-05-03 11:25:50 +02:00
Joseph Madamba	2f075e3247	Apply half margin of tolerance on both sides before text scrolls	2024-05-02 17:06:11 -07:00
Bartłomiej Dach	1eac34667d	Fix test failure	2024-05-02 08:02:55 +02:00
Salman Ahmed	4ffeb5b469	Resolve post-merge-conflict issues	2024-05-01 23:57:58 +03:00
Salman Ahmed	895c09d4d1	Merge branch 'master' into storyboard-loops-v2	2024-05-01 23:46:38 +03:00
Salman Ahmed	eb45a406e1	Add failing test case	2024-05-01 23:00:24 +03:00
Bartłomiej Dach	72b59c01f7	Merge branch 'master' into preserve-storyboard	2024-05-01 15:21:45 +02:00
Bartłomiej Dach	82d1ebbd20	Merge branch 'master' into fix-zip-encoding	2024-04-30 16:30:15 +02:00
Bartłomiej Dach	38e239a435	Expand test to cover both legacy and non-legacy export paths	2024-04-30 16:07:41 +02:00
Dean Herbert	97da47f69c	Add test coverage of reading japanese filename after exporting	2024-04-30 01:27:47 +08:00
Dean Herbert	b455e793dd	Add test coverage of reading japanese file from stable export	2024-04-30 01:15:02 +08:00
Dean Herbert	19897c4c07	Add testing for actual presence of video after encode-decode	2024-04-30 00:50:40 +08:00
Dean Herbert	fd3f4a9e7b	Preserve storyboard events when saving a beatmap in the editor ... Until we have full encoding support for storyboards, this stop-gap measure ensures that storyboards don't just disappear from existence.	2024-04-30 00:01:56 +08:00
Bartłomiej Dach	fa3aeca09d	Add failing test for skins not saving on change	2024-04-29 14:38:49 +02:00
Dean Herbert	c900c0c01c	Merge branch 'master' into LeaderBoardScore_clean	2024-04-28 13:51:29 +08:00
Joseph Madamba	d4951a093f	Scroll now playing overlay text when overflowing	2024-04-27 20:18:49 -07:00
Dan Balasescu	459f97891d	Merge pull request #27994 from bdach/timing-distribution-graph-only-basic ... Do not show non-basic results in timing distribution graph	2024-04-26 01:36:16 +09:00
Dean Herbert	6a8a6fa79d	Merge pull request #27996 from bdach/delete-dirty-difficulty-droken ... Fix deleting modified difficulty via editor leaving user in broken state	2024-04-25 21:20:09 +08:00
Dean Herbert	1756da0dda	Fix redundant string interpolations	2024-04-25 21:14:09 +08:00
Bartłomiej Dach	d2e9c33b6a	Add failing test case	2024-04-25 12:55:33 +02:00
Bartłomiej Dach	9e919b784d	Add test case covering ignoring non-basic results	2024-04-25 11:19:29 +02:00
Bartłomiej Dach	da953b34a7	Apply nullability annotations to ResultsScreen & inheritors	2024-04-25 10:58:28 +02:00
Joseph Madamba	5f463b81a8	Remove hardcoded chevrons in test	2024-04-24 00:22:20 -07:00
Bartłomiej Dach	c454dd2496	Merge pull request #27967 from peppy/storyboard-video-transforms-and-sizing ... Fix storyboard videos not accepting transforms	2024-04-23 18:09:09 +02:00
Dean Herbert	602b16f533	Fix fade-in no longer working on videos	2024-04-23 22:03:32 +08:00
Dean Herbert	564dec7a14	Add test coverage of transforms actually being applied to video	2024-04-23 19:21:55 +08:00
Bartłomiej Dach	a978518a74	Add failing tests	2024-04-23 12:41:33 +02:00
Bartłomiej Dach	12acdeebf1	Merge pull request #27866 from Joehuu/fix-online-score-export ... Fix replay export not working correctly from online leaderboards	2024-04-23 09:08:04 +02:00
Bartłomiej Dach	1f010c4bfd	Merge pull request #27808 from smoogipoo/fix-incorrect-pp-counter ... Fix gameplay PP counter not matching results screen	2024-04-23 08:43:49 +02:00
Dean Herbert	50afd48812	Add manual test coverage of storyboard videos	2024-04-23 05:21:01 +08:00
Joseph Madamba	49154c0e23	Fix code quality	2024-04-22 11:23:38 -07:00
Bartłomiej Dach	b28bf4d2ec	Add test covering non-audio file formats not being checked	2024-04-22 10:43:20 +02:00