740 Commits

Author	SHA1	Message	Date
Dean Herbert	1629024111	ILegacyScoreProcessor -> ILegacyScoreSimulator	2023-07-04 17:32:54 +09:00
Dan Balasescu	09bc8e45de	Refactoring	2023-06-28 16:14:32 +09:00
Dan Balasescu	5f350aa66f	Fix float division ... Firstly, this is intended to be a float division. Secondly, dividing integers by 0 results in an exception, but dividing non-zero floats by 0 results in +/- infinity which will be clamped to the upper range. In particular, this occurs when the beatmap has 1 hitobject (0 drain length).	2023-06-27 17:14:35 +09:00
Dan Balasescu	a9c65d200a	Initial conversion of scores	2023-06-26 22:19:01 +09:00
Dan Balasescu	e1d723a2cc	Merge branch 'master' into diffcalc-total-scorev1	2023-06-26 14:32:14 +09:00
Bartłomiej Dach	e3a89a6273	Fix remaining obvious CI inspections	2023-06-24 16:07:01 +02:00
Dean Herbert	df5b389629	Manual fixes to reduce warnings to zero	2023-06-24 01:52:53 +09:00
Dan Balasescu	06565871d6	Add flag to disable computing legacy scoring values	2023-06-24 01:03:18 +09:00
Dean Herbert	0ab0c52ad5	Automated pass	2023-06-24 01:00:03 +09:00
Dan Balasescu	87447f41d0	Fix incorrect calculation of difficulty	2023-06-24 00:58:45 +09:00
Dan Balasescu	bfa449e47a	Adjust attribute data	2023-06-19 21:38:13 +09:00
Dan Balasescu	b9f485b551	Merge classes + split out	2023-06-13 02:32:54 +09:00
Dan Balasescu	446807e7f6	Add combo score / bonus score attributes	2023-06-12 23:00:29 +09:00
Dan Balasescu	d10c63ed2d	Fix difficulty calculation when mods are involved	2023-06-08 16:29:34 +09:00
Dan Balasescu	77c745cc94	"TotalScoreV1" -> "LegacyTotalScore"	2023-06-06 17:25:28 +09:00
Dan Balasescu	e402c6d2b4	Write max combo attribute from base class	2023-06-02 21:53:25 +09:00
Dan Balasescu	02111e3854	Implement ScoreV1 calculation for OsuRuleset	2023-06-02 17:36:45 +09:00
apollo-dw	23d0c03fc8	Merge branch 'master' into no-combo-scaling	2022-10-24 02:17:39 +01:00
abstrakt	6e1edc4d8d	Use the StackedEndPosition to determine the jump distance in the FlashlightEvaluator. ... Signed-off-by: abstrakt <abstrakt.osu@gmail.com>	2022-09-26 14:06:35 +02:00
Dan Balasescu	1e9b60f07f	Merge pull request #16524 from stanriders/move-td-reduction ... Fix touch device difficulty reduction not affecting star rating	2022-09-21 12:51:14 +09:00
StanR	1801ae3c6a	Move flashlight TD difficulty reduction to diffcalc	2022-09-14 17:40:22 +03:00
StanR	6338b87c63	attributes	2022-09-09 17:31:52 +03:00
StanR	c2e3fcfa3f	Merge branch 'master' into move-td-reduction	2022-09-09 17:24:58 +03:00
apollo-dw	1997519364	Don't use full hit window in rhythm	2022-09-07 13:25:35 +01:00
apollo-dw	b5779508d0	Retrieve great hit window from the hit object	2022-09-06 17:10:32 +01:00
Dan Balasescu	9645bfe708	Bump difficulty calculator versions	2022-09-02 16:27:25 +09:00
apollo-dw	ad650adab0	Fix speed note count sum	2022-08-30 18:03:44 +01:00
Dan Balasescu	e34c8e4975	Merge pull request #19716 from MBmasher/fl-grid ... Nerf repeated angles in Flashlight skill	2022-08-29 21:15:45 +09:00
MBmasher	b082dc1fe4	Slightly buff flashlight multiplier	2022-08-27 18:31:07 +10:00
MBmasher	454d868dd5	Remove unnecessary using call	2022-08-26 20:42:02 +10:00
MBmasher	249c3f868f	Compare raw angle values instead of rounding angles	2022-08-26 20:40:18 +10:00
MBmasher	5082ee26cf	Ensure a negative value cannot be added to angleRepeatCount	2022-08-26 20:30:14 +10:00
MBmasher	08cb70b093	Lessen repeated angle nerf for objects further back in time	2022-08-26 20:27:31 +10:00
MBmasher	d8854413cb	Add newline	2022-08-26 12:38:36 +10:00
MBmasher	6651e76e2e	Remove whitespace	2022-08-26 12:37:56 +10:00
MBmasher	b0e7f63361	Update angle multiplier to nerf repeated angles	2022-08-26 12:34:33 +10:00
StanR	43e471c2a5	Clamp effective miss count to maximum amount of possible braks	2022-08-16 16:12:13 +03:00
MBmasher	21c5fed45f	Adjust capitalisation	2022-08-12 14:09:16 +10:00
MBmasher	f70588a423	Add newline before brace	2022-08-12 14:08:32 +10:00
MBmasher	037f56077b	Apply Flashlight grid nerf	2022-08-12 13:29:04 +10:00
Dan Balasescu	61a3758cd9	Merge branch 'master' into pp-balancing	2022-08-11 19:46:16 +09:00
Dan Balasescu	7cac089246	Merge branch 'master' into fl-slider	2022-08-10 21:19:05 +09:00
Dan Balasescu	2c6c315e3a	Merge branch 'master' into pp-balancing	2022-08-04 15:40:46 +09:00
MBmasher	267d55a6a8	Remove osuSlider from statement	2022-07-23 14:48:39 +10:00
MBmasher	230943f698	Merge branch 'fl-slider' of https://github.com/mbmasher/osu into fl-slider	2022-07-23 14:40:54 +10:00
MBmasher	f44a5def90	Move repeat bonus to TravelDistance	2022-07-23 14:40:16 +10:00
Dan Balasescu	71912e10c4	Merge branch 'master' into fl-slider	2022-07-22 15:22:50 +09:00
Dean Herbert	aca19a005e	Add versioning to difficulty calculators	2022-07-21 18:15:25 +09:00
StanR	163c3f9c2d	Adjust multipliers to account for speed changes	2022-07-20 16:10:34 +03:00
StanR	35e841de95	Move base performance multiplier to a const	2022-07-20 15:54:49 +03:00
StanR	9c9f32b435	Merge branch 'master' into pp-balancing	2022-07-20 15:40:29 +03:00
StanR	633f6fe620	Increase global multiplier	2022-07-18 21:58:11 +03:00
MBmasher	42b9dc877d	Divide slider bonus by repeat count	2022-07-18 16:14:06 +10:00
MBmasher	72c096f9af	Update xmldoc	2022-07-18 15:59:20 +10:00
MBmasher	7c680afc3c	Change initialisation of osuSlider	2022-07-18 15:59:00 +10:00
MBmasher	204fbde07b	Remove debug code	2022-07-18 15:58:32 +10:00
MBmasher	8413c40442	Remove debug code	2022-07-18 15:58:09 +10:00
MBmasher	68caafa210	Update xmldoc	2022-07-17 17:02:30 +10:00
MBmasher	dae698638c	Add repeat bonus to Flashlight, move repeat multiplier to AimEvaluator	2022-07-17 16:56:05 +10:00
MBmasher	a950deb7db	Re-implement slider changes to FlashlightEvaluator	2022-07-17 16:27:55 +10:00
Jamieson Berida	a0dd6cbab3	Merge branch 'master' into fl-slider	2022-07-17 16:18:18 +10:00
StanR	760742e358	Move relax global multiplier to diffcalc	2022-07-14 00:42:50 +03:00
StanR	0983e4f81e	Increase 50s nerf again	2022-07-12 17:57:00 +03:00
StanR	58c687172b	Reduce low AR bonus	2022-07-12 10:52:44 +03:00
apollo-dw	5b96f67a8b	Remove non-overlapping velocity buff	2022-07-04 20:49:26 +01:00
StanR	4f77637946	Update desmos	2022-07-04 21:52:57 +03:00
StanR	bf738aa04f	Account for extreme ODs in relax multipliers	2022-07-04 21:49:45 +03:00
StanR	afa3f8cda3	Make relax ok/meh multipliers dependent on OD	2022-07-04 20:53:20 +03:00
StanR	11eb344476	Reduce 50s nerf further	2022-07-04 20:28:15 +03:00
StanR	db8bb07c78	Reduce 50s nerf effect	2022-07-04 20:10:26 +03:00
StanR	212360f67e	Make relax ok/meh nerfs less drastic, add flashlight nerf, remove ar bonus for relax	2022-07-04 19:59:30 +03:00
StanR	45258b3f14	Buff aim slightly	2022-07-04 19:53:34 +03:00
Dan Balasescu	d4aa18112b	Merge pull request #15035 from emu1337/speed-acc-scaling ... Change speed accuracy scaling to be closer to worst case scenario	2022-06-29 18:04:23 +09:00
Dan Balasescu	6d91c0f375	Resolve inspection issue	2022-06-29 16:57:11 +09:00
Dan Balasescu	ad95f037de	Prevent another case of potential div-by-0	2022-06-29 16:42:53 +09:00
Dan Balasescu	e6ccca8045	Fix inspection	2022-06-29 16:29:17 +09:00
Dan Balasescu	0211fe7ae8	Fix exception + possible div-by-0	2022-06-29 16:29:14 +09:00
Dan Balasescu	2989803b71	Merge branch 'master' into speed-acc-scaling	2022-06-29 16:15:20 +09:00
Dan Balasescu	34b9118fb3	Cleanup by using const value	2022-06-29 16:10:06 +09:00
Dan Balasescu	7d743994bc	Merge branch 'master' into FL-diffspike	2022-06-29 16:05:53 +09:00
Dan Balasescu	0fd2c010e5	Remove NRT disables from attributes classes	2022-06-27 16:07:15 +09:00
Dan Balasescu	0579780bb8	Add IBeatmapOnlineInfo parameter and use to extract more data	2022-06-27 16:07:15 +09:00
Dan Balasescu	a7de43ade6	Add attribute ID	2022-06-21 19:31:45 +09:00
apollo-dw	630bd244d5	Inherit StrainSkill instead	2022-06-21 10:01:11 +01:00
apollo-dw	0f6f000188	Remove difficulty spike nerf	2022-06-21 09:13:44 +01:00
emu1337	26b0815fc8	fixed casting the wrong skill	2022-06-20 04:19:07 +02:00
emu1337	ecbbd29c9b	Merge branch 'master' into speed-acc-scaling ... # Conflicts: # osu.Game.Rulesets.Osu/Difficulty/OsuDifficultyAttributes.cs # osu.Game.Rulesets.Osu/Difficulty/OsuDifficultyCalculator.cs # osu.Game.Rulesets.Osu/Difficulty/OsuPerformanceCalculator.cs # osu.Game.Rulesets.Osu/Difficulty/Skills/Speed.cs	2022-06-20 04:15:35 +02:00
Dan Balasescu	1bd6198da2	Merge pull request #18692 from apollo-dw/dbltap ... Rework doubletap detection in osu!'s Speed evaluator	2022-06-19 11:03:16 +09:00
apollo-dw	c4d69405bf	Adjust speed ratio fraction to avoid division by 0	2022-06-17 21:18:16 +01:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
apollo-dw	2634e56944	Further adjustments	2022-06-14 16:16:12 +01:00
apollo-dw	737197591d	Change doubletap algorithm	2022-06-13 17:49:56 +01:00
Dan Balasescu	f73142c50f	Remove for loop	2022-06-13 20:43:56 +09:00
Dan Balasescu	b300bc1e24	Fix ever-increasing flashlight-strain	2022-06-13 20:41:32 +09:00
apollo-dw	4e3dd1ce18	Merge remote-tracking branch 'master/master' into evaluators	2022-06-13 12:27:02 +01:00
apollo-dw	e7602563fb	Fetch lastlast object from beatmap, not objects list	2022-06-10 10:28:14 +01:00
Dan Balasescu	6d2a2ba7d6	Rename Position -> Index	2022-06-09 18:49:11 +09:00
apollo-dw	774ac13900	Add xmldocs	2022-05-28 14:09:08 +01:00
apollo-dw	b631cefc55	Move object difficulty calculation to evaluator methods	2022-05-28 13:29:09 +01:00
apollo-dw	777d9af0f5	Move object difficulty calculation to evaluator methods	2022-05-28 13:28:04 +01:00
apollo-dw	66a6467403	Pass object position to the object	2022-05-26 19:26:14 +01:00
Dan Balasescu	8a4f52287c	Re-invert distances, cleanup, use actual normalised distance	2022-05-25 13:38:36 +09:00
Dan Balasescu	cde06ecf17	Apply code reviews	2022-05-25 13:03:08 +09:00
Dan Balasescu	7b2a5d4f76	Adjust xmldoc for correctness	2022-05-25 13:01:27 +09:00
apollo-dw	1ef711de41	Return null for out of range objects	2022-05-24 16:40:24 +01:00
apollo-dw	30b9e0e7ab	Use object list size for object position	2022-05-24 16:30:25 +01:00
apollo-dw	5dbec92d9e	Update comments	2022-05-23 22:17:29 +01:00
Jamieson Berida	c9b00a2302	Merge branch 'master' into fl-slider	2022-05-23 17:42:12 +10:00
apollo-dw	26985ca8af	Store hitobject history in the hitobject	2022-05-22 16:26:22 +01:00
Dan Balasescu	b71274265f	Merge pull request #15665 from MBmasher/fl-opacity ... Consider opacity of hit objects in Flashlight skill	2022-05-12 19:00:21 +09:00
Dan Balasescu	4463a26f4e	Refactor opacity computation algorithm	2022-05-12 18:31:10 +09:00
Dan Balasescu	637f817696	Ignore zero-sections on a per-case basis	2022-05-03 16:06:20 +09:00
Dan Balasescu	ce095d6af6	Merge branch 'master' into fl-opacity	2022-04-26 18:34:53 +09:00
Dan Balasescu	32e55e7d78	Merge branch 'master' into osu-diff-calc-max-combo	2022-03-31 15:08:08 +09:00
apollo-dw	2f335a76dc	Switch to using osuAttributes	2022-03-17 22:08:56 +00:00
apollo	0d4fe96ddf	Merge branch 'master' into no-combo-scaling	2022-03-17 21:13:07 +00:00
Dan Balasescu	523f668c8c	Remove unnecessary ctor argument	2022-03-15 12:37:39 +09:00
Dan Balasescu	4a3e3aba65	Restructure PerformanceCalculator to not require ScoreInfo argument	2022-03-14 14:25:28 +09:00
apollo	580e43b5ea	Merge branch 'master' into no-combo-scaling	2022-03-03 14:55:41 +00:00
apollo-dw	c18df86720	Remove clockrate factor	2022-02-19 15:33:28 +00:00
Dan Balasescu	567da9214e	Merge branch 'master' into osu-diff-calc-max-combo	2022-02-18 18:35:24 +09:00
Dan Balasescu	84e82ef5e4	Add XMLDocs to difficulty attribute properties	2022-02-16 14:09:19 +09:00
Dan Balasescu	215da7e933	Reimplement as extension method on IBeatmap ... Implementation has changed slightly to support arbitrary levels of nested hitobjects.	2022-02-16 12:06:49 +09:00
apollo-dw	94a46ab640	Rescale miss penalty for note strains	2022-02-14 02:02:46 +00:00
apollo-dw	da31ca17e7	Use note strains instead of sectional strains	2022-02-14 01:53:03 +00:00
apollo	1ae8ff0cf6	Merge branch 'master' into no-combo-scaling	2022-02-10 22:34:34 +00:00
Henry Lin	74a55ead77	Simplify combo counting logic	2022-01-23 13:00:54 +08:00
Henry Lin	f53ce5aedf	Fix max combo calculation in osu diffcalc	2022-01-23 11:11:12 +08:00
Bartłomiej Dach	1ce0b18003	Merge branch 'master' into display-performance-attributes	2022-01-22 14:12:57 +01:00
Dan Balasescu	36d1cdb95a	Merge branch 'master' into fl-opacity	2022-01-20 14:48:20 +09:00
StanR	b77e6f92b7	Fix touch device difficulty reduction not affecting star rating	2022-01-19 22:31:11 +03:00
Dan Balasescu	58bae9bda3	Merge pull request #16331 from stanriders/continuous-effective-misscount ... Don't floor `effectiveMissCount`	2022-01-19 14:13:12 +09:00
Henry Lin	b81fc675e8	Include PropertyName in PerformanceDisplayAttribute	2022-01-17 20:45:25 +08:00
Henry Lin	d014fef179	Hide confusing attributes	2022-01-17 20:36:36 +08:00
Henry Lin	511a607599	Display performance breakdown in a tooltip	2022-01-17 18:28:17 +08:00
apollo-dw	598946737f	Reword comment and rename argument	2022-01-12 14:38:53 +00:00
Dan Balasescu	b88a65166e	Fix pp counter underflow with SpunOut mod	2022-01-11 10:22:16 +09:00
Dan Balasescu	400abc147b	Add attribute ids to mapping functions	2022-01-06 16:28:04 +09:00
StanR	dc755f4a7f	Remove redundant casts	2022-01-05 15:07:02 +03:00
StanR	b317a95fe1	Don't floor effectiveMissCount	2022-01-05 14:36:07 +03:00
apollo-dw	dcb969316d	Weight difficult strain count against the top strain	2022-01-04 17:33:23 +00:00
Luminiscental	132079004c	Remove unnecessary truncation	2022-01-04 12:30:05 +00:00
Luminiscental	75be4e83d6	Remove abusable 0.66 threshold by averaging	2022-01-03 22:32:21 +00:00
apollo-dw	d2b815b745	Add miss penalty comment	2022-01-02 19:20:20 +00:00
apollo-dw	fd1028f3bb	Use clockrate in the difficult strain count method	2021-12-29 23:49:07 +00:00
apollo-dw	4f257d6987	Clean up unsuccessful merge	2021-12-29 18:59:17 +00:00
apollo-dw	8ce6e3c573	Remove mathnet	2021-12-29 18:49:13 +00:00
apollo-dw	d51456741c	Merge master	2021-12-29 18:12:30 +00:00
Bartłomiej Dach	63e0492725	Mark ShouldSerialize() methods as implicitly used	2021-12-28 09:02:03 +01:00
apollo-dw	e9589e57a6	Fix logical error	2021-12-27 02:23:03 +00:00