mk56-spn
091cc155d3
Fix nub naming in OsuCheckbox.cs and associated classes
2023-01-26 16:10:02 +01:00
mk56-spn
a630f1113f
Rename nub object in NormalSliderBar.cs class
2023-01-26 15:03:51 +01:00
mk56-spn
8840694674
Adjust some padding details on ShearedSliderBar.cs as well as colouration tweaks.
2023-01-26 15:03:51 +01:00
mk56-spn
2f90ffccfc
Implement ShearedSliderBar.cs and corresponding TestSceneShearedSliderBar.cs
2023-01-26 15:03:22 +01:00
mk56-spn
6dfb9630d6
Implement ShearedNub.cs as well as tweak the syntax in NormalNub.cs
2023-01-26 15:03:22 +01:00
mk56-spn
b8ae689b31
Re-add Nub.cs and move logic from NormalNub.cs to it.
2023-01-26 15:03:22 +01:00
mk56-spn
63efe79abc
Enable NRT for NormalNub.cs
2023-01-26 15:03:22 +01:00
mk56-spn
374c3b56f6
Rename Nub.cs to NormalNub.cs
2023-01-26 15:03:11 +01:00
mk56-spn
7355397e83
Enable NRT on NormalSliderBar.cs
2023-01-26 12:58:58 +01:00
mk56-spn
fc99165df7
Extract samples into base OsuSliderBar.cs from NormalSliderBar.cs
2023-01-26 12:36:05 +01:00
mk56-spn
9afc8681ef
Extract tooltip implementation into base OsuSliderBar.cs from NormalSliderBar.cs
2023-01-26 12:25:05 +01:00
mk56-spn
ac3ad9cf8d
Implement OsuSliderBar.cs as base ( non framework side ) class from which NormalSliderBar.cs inherits
2023-01-26 12:16:51 +01:00
mk56-spn
3988131475
Rename OsuSliderBar.cs as NormalSliderBar.cs
2023-01-26 12:12:56 +01:00
Bartłomiej Dach
88d58e8476
Merge pull request #22337 from Joehuu/fix-comment-editor-sounds
...
Fix comment editor text boxes not having sound feedback
2023-01-22 09:10:20 +01:00
Joseph Madamba
da03abc812
Fix comment editor text boxes not having sound feedback
2023-01-21 17:32:42 -08:00
Bartłomiej Dach
718cbf9382
Fix SegmentedGraph draw node calculating segment colours in unsafe manner
...
The `SegmentedGraph`'s draw node would call `getSegmentColour()`
on the drawable, which would query the `DrawColourInfo` and
`tierColours` properties of the drawable. This is a cross-thread access
and as such completely unsafe, as due to being cross-thread it can die
on invalidations or out-of-bounds accesses.
Fix by transferring everything to the draw node first before attempting
to draw. `SegmentedGraph.TierColours` setter already correctly
invalidates the draw node via `graphNeedsUpdate`, so no further
intervention was required there.
Closes #22326 .
2023-01-21 23:19:34 +01:00
Dean Herbert
db8084570d
Merge pull request #22285 from bdach/segmented-graph-tint
...
Apply draw colour to segmented graph
2023-01-19 13:36:19 +09:00
Bartłomiej Dach
a0fe71c706
Use alternative segment colour computation method
2023-01-19 00:08:32 +01:00
Bartłomiej Dach
903c37bf32
Apply draw colour to segmented graph segments
2023-01-18 23:17:57 +01:00
Dean Herbert
b62b5714e8
Fix TierColours assignment
2023-01-17 18:07:11 +09:00
ansel
ad32d99daa
Localise caps lock warning
2023-01-16 23:08:29 +03:00
ansel
76eefc7573
Add support for localisation where it was missing
2023-01-15 01:46:11 +03:00
tsrk
bb2ece5c71
refactor(SegmentedGraph): adjust tierCount based on passed Colours
2023-01-12 10:57:12 +01:00
tsrk
7cbc03dce6
refactor(SegmentedGraph): use (get/set)ters to expose TierColour
2023-01-12 10:13:16 +01:00
tsrk
5694487a7b
fix(SegmentedGraph): update graphNeedsUpdate variable during Update() loop
2023-01-12 02:36:35 +01:00
tsrk
624e90b213
style: nitpicks
2023-01-11 21:32:12 +01:00
tsrk
6249322a32
fix(SegmentedGraph): solve issue for negatives values
2023-01-11 14:03:36 +01:00
tsrk
e128b9ee5c
fix(SegmentedGraph): make ctor public
2023-01-11 14:03:19 +01:00
tsrk
42ff8c75fa
refactor: make class not abstract
2023-01-11 11:22:18 +01:00
tsrk
578d16f2bc
perf: Do not draw sectoins that are less than 1px
2023-01-11 11:11:31 +01:00
tsrk
21073f3601
reafactor: use DrawNode to draw SegmenteddGraph
2023-01-10 22:49:35 +01:00
mk56-spn
61caabaa8e
Add coloured star counter
2023-01-10 11:45:40 +01:00
tsrk
91eab7985b
feat(ui): Implement a segmented graph
2023-01-09 21:35:27 +01:00
Dean Herbert
ac85433178
Fix default volume control keys not working when chat textbox is focused
...
Closes #22004 .
2023-01-03 09:44:35 +08:00
Joseph Madamba
777ffcf805
Highlight "open" option on external link button context menu
2022-12-26 20:47:24 -08:00
Berkan Diler
c7ca4bbba5
Use generic Enum methods
2022-12-26 20:36:39 +01:00
Bartłomiej Dach
67aea34e7e
Merge branch 'master' into fix-breadcrumb-tab-item-click-area
2022-12-23 16:36:58 +01:00
Berkan Diler
08d2fbeb8e
Use new ArgumentNullException.ThrowIfNull throw-helper API
2022-12-22 21:27:59 +01:00
Joseph Madamba
813c351607
Fix breadcrumb tab item click area not extending to background height
2022-12-16 21:44:10 -08:00
Dean Herbert
27c497145f
Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
2022-12-16 18:16:26 +09:00
Dean Herbert
efe057176e
Make OsuButton abstract
2022-12-13 22:13:48 +09:00
Dean Herbert
edc78205d5
Add comments about why both positional input checks are required in OsuClickableContainer
2022-12-13 22:12:52 +09:00
Andrei Zavatski
890dd9cd06
Fix input doesn't take original drawable modifications into account
2022-12-12 15:10:03 +03:00
Andrei Zavatski
b0d475cd8b
CI fix
2022-12-12 14:57:07 +03:00
Andrei Zavatski
7e39f171fb
Fix OsuButton input receiving
2022-12-12 14:42:54 +03:00
Salman Ahmed
af000c6e92
Fix RangeSlider potentially throwing exception on mobile platforms
2022-12-04 21:58:00 +03:00
Dean Herbert
56a694fb04
Add automated test coverage of simple scenarios for RangeSlider
2022-11-29 15:10:21 +09:00
mk56-spn
db7f429e39
Fix partial class issues and adjust test slightly
2022-11-27 10:44:05 +01:00
mk56-spn
0aba119056
Merge remote-tracking branch 'origin/RangeSlider_implementation' into RangeSlider_implementation
...
# Conflicts:
# osu.Game.Tests/Visual/SongSelect/TestSceneDifficultyRangeFilterControl.cs
# osu.Game/Screens/Select/DifficultyRangeFilterControl.cs
2022-11-27 10:40:29 +01:00
Bartłomiej Dach
894ef15e79
Merge branch 'master' into update-framework
2022-11-26 16:19:36 +01:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
mk56-spn
92ed2ed4ef
Refactor star "DifficultyRangeFilterControl" into generic range slider class
2022-11-26 12:19:08 +01:00
Dean Herbert
53b03df93d
Combine TriangleButton and RoundedButton classes
2022-11-24 16:26:57 +09:00
Dean Herbert
bea2acc60e
Remove local specifications of triangle colouring
2022-11-24 16:18:15 +09:00
Dean Herbert
4fbca4037c
Update existing triangle buttons to use RoundedButton
2022-11-24 16:18:15 +09:00
Dean Herbert
40f706155f
Update RoundedButton to have new triangles design
2022-11-24 16:18:15 +09:00
Dean Herbert
172e798847
Merge pull request #21228 from Terochi/recent-messages-implementation
...
Add ability to view chat send history in input box
2022-11-23 14:58:42 +09:00
Terochi
d81ef541bc
Variant 5: cannot change history, edit resets index
2022-11-21 10:17:28 +01:00
Terochi
7dc7729ac2
Variant 4: cannot change history, empty text/everything selected resets index (current with bug fix)
2022-11-21 10:11:26 +01:00
Terochi
58288275a6
Variant 3: cannot change history, cannot reset index (the "default")
2022-11-21 09:43:36 +01:00
Terochi
672e1cd45b
Variant 2: edit changes history, cannot reset index (similar to stable)
2022-11-21 09:41:29 +01:00
Terochi
8f942f130b
Variant 1: edit changes history, empty text resets index
2022-11-21 09:36:31 +01:00
Andrei Zavatski
18c79dfda3
Move all the logic into BarsInfo class
2022-11-20 23:00:13 +03:00
Bartłomiej Dach
33b2fe46d9
Add xmldoc to HistoryTextBox
2022-11-20 12:29:47 +01:00
Andrei Zavatski
36141cb2a4
Make BarsInfo a class
2022-11-20 05:14:07 +03:00
Andrei Zavatski
fcb52ee237
Make BarsInfo a readonly struct
2022-11-20 02:28:07 +03:00
Andrei Zavatski
fbfcf49ea6
Remove readonly modifier from struct fields
2022-11-20 02:13:54 +03:00
Andrei Zavatski
2cb966b47c
Rework BarsInfo struct
2022-11-20 01:48:54 +03:00
Andrei Zavatski
6c62cfb830
Store barBreadth as a separate float
2022-11-19 23:40:02 +03:00
Andrei Zavatski
67ee9f3915
Naming adjustments
2022-11-19 23:34:55 +03:00
Andrei Zavatski
f1201454b7
Use value tuples
2022-11-19 23:29:50 +03:00
Andrei Zavatski
6f449a583e
Handle empty values as a separate case
2022-11-19 23:27:48 +03:00
Terochi
eff6c7be64
Removed unnecessary methods, changed tests, and moved LimitedCapacityQueue.cs to a more generic namespace.
2022-11-19 16:53:35 +01:00
Andrei Zavatski
0239103b6b
Fix BeatmapOverlay crashing test scene
2022-11-19 11:33:14 +03:00
Andrei Zavatski
05992d3aa8
CI fix
2022-11-19 10:23:37 +03:00
Andrei Zavatski
9b8f98735c
Use struct for bars description
2022-11-19 10:16:58 +03:00
Andrei Zavatski
11f5fddc1f
Remove redundant returns
2022-11-19 09:57:52 +03:00
Andrei Zavatski
e8ca9f5dc5
Rework BarGraph to use Quads
2022-11-19 00:22:57 +03:00
Dan Balasescu
c2a127dc68
Merge pull request #21289 from peppy/fix-triangle-button-flash
...
Fix triangle button flash effect looking incorrect
2022-11-18 15:26:43 +09:00
Dean Herbert
5fc0d45675
Fix triangle button flash effect looking incorrect
2022-11-18 14:30:59 +09:00
Dragon
a25c94d567
Replacing structure to use LimitedCapacityQueue.cs
2022-11-17 13:07:06 +01:00
Dragon
a9747d367c
Cleaning up
2022-11-17 13:07:06 +01:00
Terochi
0100c01b82
Implemented finite limit of stored history.
2022-11-17 13:07:06 +01:00
Terochi
5253f5309e
Added more tests for new features
2022-11-17 13:07:06 +01:00
Terochi
44c3e71746
Reversed indexing
2022-11-17 13:07:06 +01:00
Terochi
3d4962e181
Added functioning tests.
2022-11-17 13:07:06 +01:00
Terochi
6d83af01e2
Moved and renamed MessageHistoryTextBox.cs for better fit.
2022-11-17 13:07:06 +01:00
maromalo
1911120afe
Merge branch 'master' into long-standard
2022-11-12 09:52:11 -03:00
maromalo
b7ef9b176d
Make score type consistent
2022-11-06 19:59:27 -03:00
Dean Herbert
e7b543de2f
Move disabled check to apply to all calls to updateGlow()
2022-11-07 02:19:13 +09:00
Dean Herbert
700f8b0469
Remove pointless nested if conditional
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-11-07 02:13:04 +09:00
Dean Herbert
78bb940e6c
Don't play hover sounds on disabled elements
2022-11-04 19:06:08 +09:00
Dean Herbert
0e350f52f5
Fix SliderBar disabled value potentially not transferring to hover sounds
2022-11-04 19:06:08 +09:00
Dean Herbert
a2fdad4afc
Fix slider updating glow when disabled
2022-11-04 19:06:08 +09:00
Dean Herbert
a16540dc6d
Update Nub hover animation to better suit immediacy of sound effects
2022-11-04 19:06:08 +09:00
Dean Herbert
8b58475ee0
Update OsuButton hover animation to better suit immediacy of sound effects
2022-11-04 18:51:09 +09:00
Dean Herbert
f6c376c090
Minor refactoring
2022-11-03 20:29:27 +09:00
Jamie Taylor
59bbd9c460
Fix some components using wrong sample set
2022-11-03 17:47:49 +09:00
Jamie Taylor
f1c17129eb
Add support for 'disabled' sample variation to HoverClickSounds
2022-11-03 17:47:49 +09:00
Dean Herbert
247cf589aa
Merge branch 'master' into directoryselector-hidden-toggle
2022-10-24 15:33:10 +09:00
Dean Herbert
447d420c99
Fix adjusting volume via settings playing tick samples twice
2022-10-21 21:03:39 +09:00
Jamie Taylor
7b1edff2b3
Add unique hover/select samples to settings sidebar buttons
2022-10-21 18:06:38 +09:00
ansel
295e6f5a68
Move toast to it's namespace
2022-10-13 23:57:25 +03:00
ansel
e97dbf3dbc
Move copy toast to its own file
2022-10-13 22:12:32 +03:00
Jamie Taylor
cb1d886c9c
Add audio feedback for Esc/Back clearing text from a FocusedTextBox
2022-09-07 13:17:04 +09:00
Dean Herbert
2bec8b82b3
Fix textbox sample playback potentially crashing if called before load
2022-09-05 16:26:41 +09:00
Dean Herbert
6a35b233e5
Merge branch 'master' into remove-dispose-updates
2022-09-01 23:03:19 +09:00
Jamie Taylor
212d76a11f
Add audio feedback for invalid textbox input
2022-08-31 17:31:36 +09:00
Jamie Taylor
cc9dc604a0
Refactor feedback sample playback logic
2022-08-31 17:29:57 +09:00
Dean Herbert
a215d009fe
Update Remove/RemoveRange/RemoveAll calls in line with framework changes
2022-08-29 15:57:40 +09:00
Dean Herbert
470bec7949
Move private method down
2022-08-26 23:29:03 +09:00
Jamie Taylor
da7f8270da
Fix incorrect cast
2022-08-24 22:31:28 +09:00
Jamie Taylor
dc829334a1
Update for framework-side changes.
2022-08-24 22:19:32 +09:00
Jamie Taylor
41408a3106
Add audio feedback for text selection
2022-08-19 15:51:27 +09:00
Dan Balasescu
efc4a129d9
Merge pull request #19658 from peppy/user-button-better-display
...
Display connecting / failing states on toolbar user display
2022-08-09 17:59:28 +09:00
Dan Balasescu
d80db2aee7
Merge pull request #19639 from peppy/fix-fps-damping
...
Fix incorrect FPS damping implementation
2022-08-09 17:03:55 +09:00
Dean Herbert
4da9482a3e
Add ability for loading layer to not block input
2022-08-09 15:51:11 +09:00
Dean Herbert
c7313ac371
Allow LoadingLayer's spinning circle to scale smaller than before
2022-08-09 15:34:11 +09:00
Dean Herbert
4f7d63be29
Ignore very long periods of no frame drawing when showing FPS counter ms value
2022-08-08 15:21:49 +09:00
Dean Herbert
81c079c937
Fix incorrect damping implementation
...
I'm not sure what I was thinking with the weighting stuff. It wasn't
correct. Can most easily be noticed if suspending the app on iOS for a
considerable period, or pausing debugger.
2022-08-08 15:21:49 +09:00
its5Q
68e7000620
Fix FPS counter disappearing when hovered over
2022-08-08 15:52:47 +10:00
Bartłomiej Dach
085080576a
Add button for creating new mod presets
2022-08-02 22:03:32 +02:00
Dean Herbert
34ffc51c51
Avoid clearing chat overlay textbox when pressing "back" key binding
...
Generally this is expected behaviour for usages of focused text boxes
(ie. to clear search content), but not so much here.
Addresses https://github.com/ppy/osu/discussions/19403#discussioncomment-3230395 .
2022-08-02 13:56:03 +09:00
Bartłomiej Dach
298efa5391
Fix broken ShearedButton autosizing logic
2022-08-01 22:04:16 +02:00
Dean Herbert
f44a4c8652
Reorder file content to match expectations
2022-07-28 12:13:47 +09:00
Dean Herbert
f01c397220
Apply nullability
2022-07-28 12:12:46 +09:00
Andrew Hong
f097064eea
Adjust to reviews
2022-07-27 21:52:38 -04:00
Andrew Hong
ac39d3a142
"Copied URL" -> "URL copied"
2022-07-27 21:52:28 -04:00
Andrew Hong
2d4655f61e
Add Toast Notification to Copy URL
2022-07-27 02:25:40 -04:00
Dean Herbert
c30e8047ab
Merge pull request #19375 from novialriptide/contextmenu-external-beatmap
...
Add ContextMenu to beatmap external link
2022-07-26 19:06:10 +09:00
Andrew Hong
aaf6ec05bb
Remove notification upon copy
2022-07-26 04:19:54 -04:00
Andrew Hong
a8e315abf0
Refactor
2022-07-25 17:16:33 -04:00
Andrew Hong
46c4e78477
Add notification and another menuitem
2022-07-25 16:59:00 -04:00
Andrew Hong
f1534da683
Formatting issues
2022-07-25 04:13:05 -04:00
Andrew Hong
fcf767e28b
Add contextmenu to beatmap external link
2022-07-25 04:07:33 -04:00
Dean Herbert
2dd99ef1fd
Refactor FPSCounter to not use scheduled tasks
...
While on the surface this looks harmless (ignoring allocations),
`Scheduler` doesn't clear cancelled tasks until they reach their
execution time. This can cause an increase in time spent processing the
scheduler itself.
I don't think a per-frame updating component should use scheduled tasks
in this way in the first place, so I've just rewritten the logic to
avoid that overhead altogether.
2022-07-25 16:26:48 +09:00
Salman Ahmed
4332e6cae9
Fix OsuSliderBar throwing on negative draw width
2022-07-24 08:34:24 +03:00
Dean Herbert
b9f5074c13
Merge branch 'fps-counter-no-rolling-counter' into fps-counter-cleanup
2022-07-22 02:22:01 +09:00
Dean Herbert
0eeafea500
Increase responsiveness to change slightly
2022-07-21 23:37:32 +09:00
Dean Herbert
c140601c2d
Cleanup pass on FPSCounter
2022-07-21 23:02:31 +09:00
Dean Herbert
fc6445caea
Rate limit updates for good measure
2022-07-21 22:55:45 +09:00
Dean Herbert
3d2603e0eb
Remove unused classes
2022-07-21 22:51:35 +09:00
Dean Herbert
3fad481a96
Avoid using RollingCounter in fps counter
...
It wasn't made to be updated every frame, and it shows. Inaccurate for
reasons I'm not really interested in investigating, because I don't want
to incur the `Transorm` overhead in the first place for an fps counter.
Was only used originally out of convenience.
2022-07-21 22:50:02 +09:00
Dean Herbert
5db4d9437a
Add missing using statement
2022-07-21 21:39:24 +09:00
Dan Balasescu
6fac34c721
Merge pull request #19274 from peppy/fix-fps-counter-fps-inaccuracy
...
Fix draw FPS being inaccurate due to using `ElapsedFrameTime`
2022-07-21 20:55:14 +09:00
Dean Herbert
4c4939d18d
Fix draw FPS being inaccurate due to using ElapsedFrameTime
...
Had a feeling this would be the case.
Basically, we're calculating on the update thread and checking the last
value of draw thread's `ElapsedFrameTime`. In the case that value is
spiky, a completely incorrect fps can be displayed.
I've left the spike display do use `ElapsedFrameTime`, as
`FramesPerSecond` is too averaged to see spikes.
2022-07-21 19:17:58 +09:00
Dean Herbert
fb728fbed1
Fix FPS counter not being wide enough to show large fps numbers
2022-07-21 18:56:39 +09:00
Dean Herbert
56106e43d2
Avoid div-by-zero
2022-07-21 13:06:43 +09:00
Dean Herbert
311a0a3de0
Always show counter temporarily when aim FPS changes
2022-07-21 12:57:40 +09:00
Dean Herbert
705ff06ea5
Better handle spikes and significant changes
2022-07-21 12:50:39 +09:00
