Bartłomiej Dach
10a8e84046
Apply NRT to StatisticsPanel
2024-05-14 15:19:46 +02:00
Bartłomiej Dach
cb49147d1e
Apply NRT to ScorePanelList
2024-05-14 15:19:43 +02:00
Bartłomiej Dach
03a279a48d
Use hash rather than online ID as primary lookup key when presenting score
...
Something I ran into when investigating
https://github.com/ppy/osu/issues/28169 .
If there are two scores with the same online ID available in the
database - for instance, one being recorded locally, and one recorded by
spectator server, of one single play - the lookup code would use online
ID first to find the score and pick any first one that matched. This
could lead to the wrong replay being refetched and presented / exported.
(In the case of the aforementioned issue, I was confused as to whether
after restarting spectator server midway through a play and importing
the replay saved by spectator server after the restart, I was seeing a
complete replay with no dropped frames, even though there was nothing in
the code that prevented the frame drop. It turns out that I was getting
presented the locally recorded replay instead all along.)
Instead, jiggle the fallback preference to use hash first.
2024-05-14 11:16:50 +02:00
Dean Herbert
cfb2c8272b
Set a rudimentary lifetime end to improve seek performance in scrolling rulesets
2024-05-14 05:02:08 +08:00
Bartłomiej Dach
87f2a23263
Merge pull request #28144 from peppy/hide-country-flags
...
Add setting to allow hiding all country flags
2024-05-13 10:10:38 +02:00
Dean Herbert
5a362be190
Merge branch 'master' into glow
2024-05-12 12:58:57 +08:00
Dean Herbert
147ebb6bc7
Merge pull request #28142 from frenzibyte/footer-v2-button-animation
...
Improve animation of new song select footer buttons
2024-05-12 11:07:30 +08:00
Salman Ahmed
fa6ccc854d
Revert behavioural changes on options button
2024-05-12 05:24:45 +03:00
Thomas Mok
5e8f6df799
Add glow to footerV2 buttons
2024-05-12 01:55:18 +01:00
Salman Ahmed
4cf6ab40f6
Use MustDisposeResource annotation to appease ReSharper inspections
2024-05-11 22:33:18 +03:00
Dean Herbert
69d699a218
Merge branch 'master' into footer-v2-button-animation
2024-05-11 21:41:50 +08:00
Dean Herbert
6cfe1356cd
Merge pull request #28141 from frenzibyte/footer-v2-mods-display
...
Add mod display and unranked indicator to new song select footer
2024-05-11 21:41:25 +08:00
Dean Herbert
a988bbd3cb
Tidy up UnrankedBadge implementation
2024-05-11 20:58:51 +08:00
Dean Herbert
ac7598cb68
Move localisation to existing file to avoid silly new class
2024-05-11 20:25:47 +08:00
Salman Ahmed
da096376af
Fix DI error in mod tooltip
2024-05-11 09:31:36 +03:00
Salman Ahmed
f64cf5c037
Fix button extending beyond unranked indicator width
2024-05-11 09:29:09 +03:00
Dean Herbert
ea35ad4689
Fix nullability inspection
2024-05-10 23:26:43 +08:00
Dean Herbert
a780abb0b4
Merge pull request #27912 from bdach/pre-mod-multiplier-score
...
Store total score without mod multipliers to local database and to replays, and send it on score submission
2024-05-10 22:46:34 +08:00
Dean Herbert
e887f93eca
Always show placeholder on unknown / missing country
2024-05-10 22:45:59 +08:00
Dean Herbert
b026309e36
Add setting to allow hiding all country flags
...
There have been enough requests for this at this point to implement it.
2024-05-10 20:32:21 +08:00
Dean Herbert
ca608a8443
Update resources
2024-05-10 18:36:44 +08:00
Salman Ahmed
09c52f03d8
Fix "options" button behaving weirdly when clicking on it while open
2024-05-10 08:25:16 +03:00
Salman Ahmed
b6d6a8940b
Improve animation of new song select footer buttons
2024-05-10 08:24:39 +03:00
Salman Ahmed
0392f7b04c
Add tooltip to unranked indicator
2024-05-10 07:37:08 +03:00
Salman Ahmed
f5ab9a7ff8
Make unranked indicator orange to match mod select overlay
2024-05-10 07:12:28 +03:00
Salman Ahmed
e5b2023155
Remove unappealing fade transition between mod display and count text
...
Fading out the mod display looks quite ugly, since alpha is applied per mod sprite, introducing bad visual on the intersection between mods.
2024-05-10 07:05:36 +03:00
Salman Ahmed
6ddf8f8498
Few cleanups
2024-05-10 06:55:02 +03:00
Salman Ahmed
c1ea9d2c9f
Adjust unranked badge height
2024-05-10 06:48:18 +03:00
Salman Ahmed
bff34a1c04
Add localisation and tooltip for mods count text
2024-05-10 06:48:18 +03:00
Salman Ahmed
49692e168e
Fix ModDisplay expanding on load with "always contracted/expanded" modes
...
This is especially visible when reloading `SongSelectFooterV2` while multiple mods are already selected. The mods will appear expanded then contract.
2024-05-10 06:48:18 +03:00
Salman Ahmed
6b91b4abf4
Add simple implementation for extended mods display in new footer design
2024-05-10 02:20:48 +03:00
Dean Herbert
c4d6318c0d
Update framework
2024-05-09 22:12:09 +08:00
Dan Balasescu
13692d8e7a
Merge branch 'masking-changes' into framework-bump
2024-05-09 21:11:54 +09:00
Dan Balasescu
3b8b56cbcb
Apply required changes after framework masking updates
2024-05-09 20:18:53 +09:00
Dean Herbert
58636d4bfb
Merge branch 'master' into Make-deletion-confirmation-less-confusing
2024-05-09 14:40:11 +08:00
Dean Herbert
88b20b357a
Increase padding around text in dialogs
2024-05-09 14:38:10 +08:00
Bartłomiej Dach
c9414da5d4
Merge branch 'master' into pre-mod-multiplier-score
2024-05-08 13:39:44 +02:00
Bartłomiej Dach
5a9a786199
Merge branch 'master' into user-id-in-replays
2024-05-08 10:43:25 +02:00
Ekischleki
e4bfa6f46b
Merge branch 'master' into Make-deletion-confirmation-less-confusing
2024-05-07 18:45:02 +02:00
Erik Wolfschläger
ab2677d913
Changed default delete confirmation content strings for better translatability
2024-05-07 17:15:49 +02:00
Dean Herbert
069841b2b3
Merge pull request #28128 from peppy/update-bundled-beatmaps
...
Update bundled beatmaps
2024-05-07 22:48:48 +08:00
Dean Herbert
0ddd3cbdc5
Randomise which menu content is shown on arriving at the menu
2024-05-07 17:02:25 +08:00
Dean Herbert
1d6915478f
Add message letting users know that beatmaps are donwloading in the background
2024-05-07 14:26:49 +08:00
Dean Herbert
91c684151a
Update bundled beatmaps
2024-05-07 14:18:50 +08:00
Susko3
f824bd1441
Fix userTriggered not being passed to private helper
2024-05-06 21:52:03 +02:00
Erik Wolfschläger
12522d9ae5
Fix formatting issues
2024-05-06 18:29:46 +02:00
Erik Wolfschläger
32444e0e30
Make deletion confirmation content less confusing
2024-05-06 18:11:40 +02:00
Erik Wolfschläger
a694f46253
Add new localisable strings
2024-05-06 18:10:58 +02:00
Bartłomiej Dach
9c6968c13a
Use score.User.OnlineID instead of score.UserID
...
You'd hope that they'd be the same thing, but
post-https://github.com/ppy/osu-server-spectator/pull/230 it turns out
that cannot be guaranteed, so just attempt to use `User` in the encoder
consistently everywhere...
2024-05-06 16:29:03 +02:00
Bartłomiej Dach
d7a0fdce07
Merge pull request #28089 from peppy/use-closest-origin
...
Automatically choose origin (along with anchor) to make skin editor placement easier for users
2024-05-06 14:57:34 +02:00
Bartłomiej Dach
abfb2c00bc
Look up users by ID if available when importing scores
2024-05-06 13:24:34 +02:00
Dean Herbert
29eef26a69
Merge pull request #28118 from bdach/scaling-mode-does-not-affect-skin-editor
...
Fix sizing of gameplay preview in skin editor not updating on scaling mode change
2024-05-06 18:46:48 +08:00
Bartłomiej Dach
554ead0d9d
Decode user ID from score if available
2024-05-06 12:28:13 +02:00
Bartłomiej Dach
4d9ccdc3b2
Encode user ID to replays
2024-05-06 12:28:13 +02:00
Bartłomiej Dach
353a07f7a5
Fix code quality inspection
2024-05-06 12:23:11 +02:00
Bartłomiej Dach
f066026503
Fix sizing of gameplay preview in skin editor not updating on scaling mode change
...
Closes https://github.com/ppy/osu/issues/28115 .
2024-05-06 11:55:51 +02:00
Bartłomiej Dach
cf87e9cd40
Do not show integration settings on mobile
...
Closes https://github.com/ppy/osu/issues/28097 .
The settings weren't actually doing anything at all there anyway.
2024-05-06 11:24:42 +02:00
Bartłomiej Dach
761d713593
Merge pull request #28086 from 424ever/ctrl-keeps-menu-open
...
Activate stateful menu items with right-click without closing the menu
2024-05-06 09:30:22 +02:00
Bartłomiej Dach
71776a583c
Merge branch 'master' into preset-td-autoplay
2024-05-06 09:02:08 +02:00
Bartłomiej Dach
4c7e6b125c
Add clarification comment
2024-05-06 08:49:30 +02:00
Bartłomiej Dach
cf22fc143f
Merge pull request #27539 from frenzibyte/storyboard-loops-v2
...
Refactor storyboard commands structure and add framework-based transform loop support
2024-05-06 08:39:07 +02:00
Dean Herbert
12cd3bbe1c
Fix incorrect scale handling due to selection point changes
2024-05-06 11:34:37 +08:00
Dean Herbert
6f0fc6f78f
Merge pull request #28111 from Joehuu/fix-broken-scrolling-unicode
...
Fix now playing overlay text scroll breaking when toggling metadata language setting
2024-05-06 11:15:51 +08:00
Joseph Madamba
359238395f
Fix now playing overlay text scroll breaking when toggling metadata language setting
2024-05-05 15:43:46 -07:00
Joseph Madamba
1665c5e0e1
Use existing AutomaticallyDownloadMissingBeatmaps localisation on solo spectator screen
2024-05-05 14:41:48 -07:00
Dean Herbert
9e7712740b
Refactor for legibility
2024-05-05 23:33:37 +08:00
Jonas Brandstötter
b1696db9c8
Reorder imports with dotnet format
2024-05-04 16:32:18 +02:00
Jonas Brandstötter
c62952ea3a
Invoke the registered Action when a stateful item is right clicked
2024-05-04 16:27:06 +02:00
Jonas Brandstötter
21917218ce
No longer keep menu open when CTRL is held
2024-05-04 16:27:06 +02:00
cdwcgt
1f92f1d19b
remove blank line
...
nt
2024-05-04 20:41:36 +08:00
cdwcgt
fe30ca3d39
fix linq logic
2024-05-04 20:18:31 +08:00
cdwcgt
f9be9ed479
remove incompatible system mods before enable preset
2024-05-04 19:58:32 +08:00
Dean Herbert
002efca422
Merge pull request #28082 from bdach/do-not-lookup-usernames-for-offline-scores
...
Do not lookup usernames for scores without an online ID
2024-05-04 15:08:33 +08:00
Dean Herbert
2cb367fdce
Disable "origin" menu when in "Closest" placement mode
2024-05-04 13:29:05 +08:00
Dean Herbert
e7ca02ffde
Fix position changing when origin updates during a drag
2024-05-04 13:28:33 +08:00
Dean Herbert
0b61e2cd42
Use closest origin along with closest anchor
2024-05-04 13:09:51 +08:00
Jonas Brandstötter
e0e7e123bf
Keep menus open when clicking a stateful item with CTRL held
2024-05-03 17:26:10 +02:00
Dean Herbert
5cdaafdb1e
Merge pull request #28083 from bdach/beatmap-attribute-text-breakage
...
Fix `BeatmapAttributeText` breaking due to enum serialisation woes
2024-05-03 21:18:26 +08:00
Dean Herbert
6cec4f0c8f
Merge pull request #28067 from bdach/refresh-local-cache-more-often
...
Update local metadata lookup cache more often
2024-05-03 20:44:13 +08:00
Bartłomiej Dach
a23d25e0a1
Fix BeatmapAttributeText breaking due to enum serialisation woes
2024-05-03 14:27:34 +02:00
Dean Herbert
ecb9173e51
Merge pull request #28017 from Joehuu/scrollable-text
...
Scroll now playing overlay text when overflowing
2024-05-03 20:05:58 +08:00
Bartłomiej Dach
afb491dff0
Do not perform username lookups for scores without an online ID
2024-05-03 13:59:36 +02:00
Bartłomiej Dach
7d31af6f16
Fix room status not updating when password is changed while inside the room
2024-05-03 11:37:09 +02:00
Bartłomiej Dach
221b4cd599
Remove unused cache
2024-05-03 11:37:09 +02:00
Dean Herbert
7141177966
Better signify private rooms by showing a different status pill design
2024-05-03 17:17:35 +08:00
Dean Herbert
42e49067e5
Move Room.Status updates to a common location
2024-05-03 17:10:59 +08:00
Bartłomiej Dach
3840e92576
Merge pull request #28075 from peppy/fix-chat-ui-scale
...
Fix chat overlay being far too large
2024-05-03 09:04:07 +02:00
Bartłomiej Dach
cf27366f99
Merge branch 'master' into fix-double-load-playlist-backgrounds
2024-05-03 08:15:56 +02:00
Bartłomiej Dach
d1a50ff85b
Remove redundant conditional access
2024-05-03 08:11:00 +02:00
Bartłomiej Dach
53b9159a01
Merge pull request #28078 from peppy/default-beatmap-background-be-gone
...
Stop using visually noisy `bg4` for default backgrounds
2024-05-03 08:06:22 +02:00
Dean Herbert
c935d3bf6c
Reduce font size in channel listing too
2024-05-03 14:00:28 +08:00
Joseph Madamba
c21b7c7df9
Use IsLoaded instead of Schedule
2024-05-02 22:46:42 -07:00
Dean Herbert
c1e9b6d4ca
Fix beatmap backgrounds loading default briefly before final display
...
Due to the way `ModelBackedDrawable` works, the default starts to get
loaded even though a final `Beatmap` has been set. This avoids loading
the default fallback unless a beatmap has been set (and has no
background itself).
2024-05-03 13:42:56 +08:00
Dean Herbert
058bd5ced6
Stop using visually noisy bg4 for default backgrounds
...
This has always really annoyed me.
2024-05-03 13:38:27 +08:00
Dean Herbert
3249ecee27
Fix chat overlay being far too large
2024-05-03 12:31:19 +08:00
Dean Herbert
aa4d16bdb8
Fix beatmap listing cards being far too large
2024-05-03 12:13:52 +08:00
Joseph Madamba
c15a685071
Remove unused usings
2024-05-02 17:07:49 -07:00
Joseph Madamba
381ddb0676
Fix weird formatting
2024-05-02 17:06:11 -07:00
Joseph Madamba
269077f854
Only support centre anchors
2024-05-02 17:06:11 -07:00
Joseph Madamba
2f075e3247
Apply half margin of tolerance on both sides before text scrolls
2024-05-02 17:06:11 -07:00
Fabian van Oeffelt
4b5ea6bd0b
Fix Code Inspection
2024-05-02 19:41:00 +02:00
Fabian van Oeffelt
588badf292
Fix Formatting
2024-05-02 19:22:39 +02:00
Fabian van Oeffelt
fa0b6311b0
Merge branch 'master' into osu-lazer-speedkeys
2024-05-02 19:17:15 +02:00
Fabian van Oeffelt
7527ddbc68
Comment, make code more readable, functions are now private
2024-05-02 19:05:43 +02:00
Fabian van Oeffelt
5c21a0330a
F1 also does not work with minus in song select, same behaviour
2024-05-02 19:05:07 +02:00
Fabian van Oeffelt
f534c4aada
Initial implementation
2024-05-02 18:42:35 +02:00
Dean Herbert
2d0240437a
Merge pull request #28066 from bdach/distance-snap-grid-spacing-change-hides-it
...
Fix changing distance spacing multiplier hiding the distance snap grid when it's already shown
2024-05-02 22:35:02 +08:00
Bartłomiej Dach
802666e621
Update local metadata lookup cache more often
...
As proposed in
https://github.com/ppy/osu/issues/27332#issuecomment-1962308306 .
2024-05-02 16:18:29 +02:00
Bartłomiej Dach
14658824e7
Adjust distance snap grid momentary toggle logic to not hide it on spacing adjust
2024-05-02 14:11:44 +02:00
Dean Herbert
f9ef689492
Don't hide playfield layer with HUD
2024-05-02 15:36:40 +08:00
Bartłomiej Dach
555305bf7f
Merge pull request #28058 from frenzibyte/export-score-rank
...
Preserve score rank on lazer scores during encode/decode
2024-05-02 08:44:10 +02:00
Salman Ahmed
b1aff91bba
Use throw helper methods
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-05-02 00:31:48 +03:00
Salman Ahmed
6d6f165884
Make video sprites flippable and vector-scalable to fix type constraint errors
...
Stable supports these on videos already from a quick read on code (since videos are generally a subclass of sprites).
2024-05-02 00:01:50 +03:00
Salman Ahmed
4ffeb5b469
Resolve post-merge-conflict issues
2024-05-01 23:57:58 +03:00
Salman Ahmed
895c09d4d1
Merge branch 'master' into storyboard-loops-v2
2024-05-01 23:46:38 +03:00
Salman Ahmed
0106f1fe3e
Preserve score rank on encode/decode
2024-05-01 23:31:23 +03:00
Salman Ahmed
30fd40efd1
Avoid disable/restore pairs
2024-05-01 21:18:56 +03:00
Salman Ahmed
e8a6381395
Update naming of enum fields in ObjType
2024-05-01 17:24:53 +03:00
Salman Ahmed
16bae4f004
Update naming of enum fields in StartMode
2024-05-01 17:22:42 +03:00
Salman Ahmed
97fc2a5473
Disable inconsistent naming in some fields of ScoreRank
2024-05-01 17:22:10 +03:00
Salman Ahmed
2fd8950b21
Disable inconsistent naming in some fields of LegacyManiaSkinConfigurationLookup
2024-05-01 17:22:10 +03:00
Salman Ahmed
02be275554
Disable naming inspections in country/language enums
2024-05-01 17:20:20 +03:00
Bartłomiej Dach
fe9e6168fe
Merge pull request #28050 from peppy/delay-resume-visibility
...
Tweak resume overlay to allow better visibility of hit objects underneath
2024-05-01 15:49:31 +02:00
Bartłomiej Dach
72b59c01f7
Merge branch 'master' into preserve-storyboard
2024-05-01 15:21:45 +02:00
Bartłomiej Dach
f0eef32913
Fix code quality inspection
2024-05-01 15:21:39 +02:00
Dean Herbert
b8209b92f6
Add delay before delayed resume starts
...
It was previously a bit sudden after dismissing the pause screen. Now
there's a short delay before the actual countdown begins.
2024-05-01 20:30:48 +08:00
Dean Herbert
87e814e201
Fix incorrect xmldoc and adjust colour provider to match Player
2024-05-01 20:30:36 +08:00
Dean Herbert
67c0d7590a
Decrease alpha of delayed resume overlay as count approaches zero
...
Allows better visibility of playfield underneath it.
2024-05-01 20:29:28 +08:00
Dean Herbert
44091b1f35
Fix some lines still getting forgotten about
2024-05-01 17:33:03 +08:00
Dan Balasescu
61350ebf6e
Merge pull request #28031 from peppy/reduce-volume
...
Reduce startup volume
2024-05-01 04:44:00 +09:00
Dean Herbert
ff108416d8
Fix incorrect background being loaded due to async race
...
If the API login (and thus user set) completed between `load` and
`LoadComplete`, the re-fetch on user change would not yet be hooked up,
causing an incorrect default background to be used instead.
Of note, moving this out of async load doesn't really affect load
performance as the bulk of the load operation is already scheduled and
`LoadComponentAsync`ed anyway
2024-05-01 00:05:14 +08:00
Bartłomiej Dach
82d1ebbd20
Merge branch 'master' into fix-zip-encoding
2024-04-30 16:30:15 +02:00
Dean Herbert
6a7e2dc258
Fix formatting
2024-04-30 21:47:03 +08:00
Dean Herbert
a3213fc36d
Change .olz to use UTF-8 encoding
2024-04-30 21:40:04 +08:00
Bartłomiej Dach
5e2e2a8d39
Merge pull request #28019 from peppy/realm-file-perm-check
...
Check realm file can be written to before attempting further initialisation
2024-04-30 13:46:43 +02:00
Dean Herbert
ba9f4e4baf
Don't skip lines in beatmap decoding
...
Was added in cc76c58f5f
2024-04-30 16:42:15 +08:00
Dean Herbert
0bfad74907
Move realm error handling to avoid triggering in test scenarios
2024-04-30 14:09:29 +08:00
Dean Herbert
a8416f3572
Move exists check inside retry operation
...
Might help?
2024-04-30 12:39:18 +08:00
Dean Herbert
c8f7f2215b
Force encoding to Shift-JIS for archive filenames
...
After way too much time investigating this, the encoding situation is
not great right now.
- Stable sets the "default code page" to be used for encoding filenames
to Shift-JIS (932):
c29ebd7fc5/osuhttps://superuser.com/a/1507988 ) set | ❌ | ❌ |
| import stable export osz | ✅ | ❌ |
| import lazer export osz | ❌ | ✅ |
| windows unzip | ❌ | ❌ |
| macos unzip | ✅ | ✅ |
and after this change
| | stable | lazer |
|--------|--------|--------|
| export encoding | shift-jis | shift-jis |
| utf8 [bit flag](https://superuser.com/a/1507988 ) set | ❌ | ❌ |
| import stable export osz | ✅ | ✅ |
| import lazer export osz | ✅ | ✅ |
| windows unzip | ❌ | ❌ |
| macos unzip | ✅ | ✅ |
A future endeavour to improve compatibility would be to look at setting
the utf8 flag in lazer, switching the default to utf8, and ensuring the
stable supports this flag (I don't believe it does right now).
2024-04-30 01:27:47 +08:00
Dean Herbert
fd3f4a9e7b
Preserve storyboard events when saving a beatmap in the editor
...
Until we have full encoding support for storyboards, this stop-gap
measure ensures that storyboards don't just disappear from existence.
2024-04-30 00:01:56 +08:00
Dean Herbert
85c085e587
Reduce startup volume
...
Constant complaints about startup volume mean we should reduce it
further and let users adjust as they see fit.
2024-04-29 23:28:19 +08:00
Bartłomiej Dach
f78abf801c
Autosave edited skin on change
2024-04-29 14:38:53 +02:00
Bartłomiej Dach
45c2327509
Apply adjustments after framework-side FriendlyGameName changes
2024-04-29 13:00:22 +02:00
Dean Herbert
a3d239c11a
Remove unused method
2024-04-29 18:48:07 +08:00
Dean Herbert
1c1ee22aa7
Add retry attempts to hopefully fix windows tests runs
2024-04-29 14:17:48 +08:00
Dean Herbert
a4bc5a8fc9
Use helper method for backup retry attempts
2024-04-29 10:35:37 +08:00
Dean Herbert
b262497083
Check realm file can be written to before attempting further initialisation
...
Rather than creating a "corrupt" realm file in such cases, the game will
now refuse to start. This behaviour is usually what we want. In most
cases a second click on the game will start it successfully (the
previous instance's file handles are still doing stuff, or windows
defender is being silly).
Closes https://github.com/ppy/osu/issues/28018 .
2024-04-28 19:07:39 +08:00
Joseph Madamba
d4951a093f
Scroll now playing overlay text when overflowing
2024-04-27 20:18:49 -07:00
Joseph Madamba
48c608e016
Make player width a const
2024-04-27 20:06:09 -07:00
Taevas
694e3900db
Add missing space in setup wizard
2024-04-27 23:43:27 +02:00
Dean Herbert
fb2d28f7e0
Fix audio being paused in a spectator session when all players finish playing
2024-04-26 15:30:26 +08:00
Dean Herbert
21d6556865
Remove managed clocks from SpectatorSyncManager on gameplay completion / abort
2024-04-26 15:29:59 +08:00
Dean Herbert
e0e790fa94
Fix a couple of xmldoc typos
2024-04-26 15:28:52 +08:00
Dan Balasescu
459f97891d
Merge pull request #27994 from bdach/timing-distribution-graph-only-basic
...
Do not show non-basic results in timing distribution graph
2024-04-26 01:36:16 +09:00
Dan Balasescu
52addc775e
Merge pull request #27965 from bdach/generic-math
...
Apply generic math-related changes
2024-04-26 01:33:54 +09:00
Dean Herbert
5ccc745235
Merge pull request #27997 from bdach/refetch-when-entering-editor
...
Fully refetch working beatmap when entering editor
2024-04-25 22:20:33 +08:00
Dean Herbert
387fcb8781
Add a brief inline comment to make sure we don't undo the fix
2024-04-25 21:31:36 +08:00
Dean Herbert
6a8a6fa79d
Merge pull request #27996 from bdach/delete-dirty-difficulty-droken
...
Fix deleting modified difficulty via editor leaving user in broken state
2024-04-25 21:20:09 +08:00
Bartłomiej Dach
c1107d2797
Fully refetch working beatmap when entering editor
...
Closes https://github.com/ppy/osu/issues/21794 .
I'm not actually super sure as to what the exact mode of failure is
here, but it's 99% to do with working beatmap cache invalidation. Likely
this can be even considered as another case of
https://github.com/ppy/osu/issues/21357 , but because this is a one-liner
"fix," I'm PRing it anyways.
The issue is confusing to understand when working with the swap scenario
given in the issue, but it's a little easier to understand when
performing the following:
1. Have a beatmap set with 2 difficulties. Let's call them "A" and "B".
2. From song select, without ever exiting to main menu, edit "A". Change
the difficulty name to "AA". Save and exit back to song select; do
not exit out to main menu.
3. From song select, edit "B". Change the difficulty name to "BB". Save
and exit back to song select.
4. The difficulty names will be "A" and "BB".
Basically what I *think* is causing this, is the fact that even though
editor invalidates the working beatmap by refetching it afresh on exit,
song select is blissfully unaware of this, and continues working with
its own `BeatmapInfo` instances which have backlinks to
`BeatmapSetInfo`.
When editing the first of the two difficulties and then the second,
the editing of the first one only invalidates the first one rather than
the entire set, and the second difficulty continues to have a stale
reference to the first one via the beatmap set, and as such ends up
overwriting the changes from the first save when passed into the editor
and modified again.
2024-04-25 14:31:13 +02:00
Bartłomiej Dach
19d006d818
Fix deleting modified difficulty via editor leaving user in broken state
...
Closes https://github.com/ppy/osu/issues/22783 .
If the difficulty being edited has unsaved changes, the editor exit flow
would prompt for save *after* the deletion method has run. This is
undesirable from a UX standpoint, and also leaves the user in a broken
state.
Thus, just fake an update of the last saved hash of the beatmap to fool
the editor into thinking that it's not dirty, so that the exit flow will
not show a save dialog.
2024-04-25 12:55:34 +02:00
Bartłomiej Dach
b250a924b1
Do not show non-basic results in timing distribution graph
...
Closes https://github.com/ppy/osu/issues/24274 .
Bit of an ad-hoc resolution but maybe fine? This basically proposes to
bypass the problem described in the issue by just not showing tick hits
at all on the distribution graph.
2024-04-25 11:20:07 +02:00
Bartłomiej Dach
da953b34a7
Apply nullability annotations to ResultsScreen & inheritors
2024-04-25 10:58:28 +02:00
Joseph Madamba
4f7c9f2970
Remove unused using
2024-04-24 01:00:03 -07:00
Joseph Madamba
f97c519451
Add chevron to distinguish all menus with submenus
2024-04-24 00:19:10 -07:00
Dean Herbert
16fdd4e08d
Add ability to show beatmap source using skin editor's beatmap attribute text
...
As per https://github.com/ppy/osu/discussions/27955 .
2024-04-24 09:01:31 +08:00
Bartłomiej Dach
cbbf2dd158
Fix DifficultyBindable bound desync between maxValue and CurrentNumber.MaxValue
2024-04-23 18:58:40 +02:00
Bartłomiej Dach
787e60f706
Fix LegacyDrainingHealthProcessor drain rate computation diverging to infinity
2024-04-23 18:57:14 +02:00
Bartłomiej Dach
a35bf77131
Merge pull request #27974 from peppy/editor-menu-chev
...
Add a chevron to distinguish editor menus with submenus
2024-04-23 18:12:08 +02:00
Bartłomiej Dach
c454dd2496
Merge pull request #27967 from peppy/storyboard-video-transforms-and-sizing
...
Fix storyboard videos not accepting transforms
2024-04-23 18:09:09 +02:00
Dean Herbert
999c8fdc38
Merge pull request #27969 from bdach/enter-to-confirm-keybinding-conflict
...
Allow confirming keybinding overwrite on conflict via "select" binding
2024-04-23 23:38:50 +08:00
Dean Herbert
221af74f95
Merge branch 'master' into generic-math
2024-04-23 22:21:31 +08:00
Dean Herbert
d0edf72a0c
Update framework
2024-04-23 22:04:28 +08:00
Dean Herbert
602b16f533
Fix fade-in no longer working on videos
2024-04-23 22:03:32 +08:00
Dean Herbert
a7327a2998
Merge pull request #27972 from bdach/fix-mod-column-stupidity-rfc
...
Fix mod select overlay columns not displaying properly sometimes
2024-04-23 21:59:29 +08:00
Dean Herbert
436203a8c1
Add a chevron to distinguish editor menus with submenus
2024-04-23 21:37:01 +08:00
Dean Herbert
804b1b0d88
Fix settings colour scheme wrong when viewing gameplay from skin editor button
...
Closes https://github.com/ppy/osu/issues/27949 .
2024-04-23 20:54:48 +08:00
Bartłomiej Dach
f7626aba18
Fix mod select overlay columns not displaying properly sometimes
...
Closes https://github.com/ppy/osu/issues/26504 .
As far as I can tell the issue is basically another manifestation of
https://github.com/ppy/osu-framework/issues/5129 , i.e. presence
overrides causing dropped invalidations and thus completely bogus
hierarchy state. The fix is to raise the appropriate invalidation
manually.
2024-04-23 13:36:12 +02:00
Bartłomiej Dach
1e0db1ab9f
Allow confirming keybinding overwrite on conflict via "select" binding
2024-04-23 12:44:16 +02:00
Dean Herbert
17ca29c2c6
Actually apply transforms to the video
2024-04-23 17:37:37 +08:00
Dean Herbert
7eeac0f3b9
Fix incorrect xmldoc
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-04-23 17:34:52 +08:00
Bartłomiej Dach
12acdeebf1
Merge pull request #27866 from Joehuu/fix-online-score-export
...
Fix replay export not working correctly from online leaderboards
2024-04-23 09:08:04 +02:00
Bartłomiej Dach
1f010c4bfd
Merge pull request #27808 from smoogipoo/fix-incorrect-pp-counter
...
Fix gameplay PP counter not matching results screen
2024-04-23 08:43:49 +02:00
Joseph Madamba
49154c0e23
Fix code quality
2024-04-22 11:23:38 -07:00
Joseph Madamba
35eddf35c5
Return Task.CompletedTask instead of null
2024-04-22 11:22:39 -07:00
Joseph Madamba
a59bf6d373
Improve xmldoc wording
2024-04-22 11:17:27 -07:00
Joseph Madamba
2eda56ff08
Revert beatmap query change
2024-04-22 11:15:50 -07:00
Dean Herbert
9e7182acf0
Remove unused DI beatmap paramater
2024-04-22 18:45:02 +08:00
Dean Herbert
c43c383abf
Allow storboard videos to take on no-relative size when specified by a mapper
2024-04-22 18:44:47 +08:00
Dean Herbert
4ae9f81c73
Apply transforms to storyboard videos
...
This requires that they are a `StoryboardSprite` for simplicity. Luckily
this works just fine.
2024-04-22 18:43:15 +08:00
Bartłomiej Dach
70a5288a68
Do not attempt to pass files that don't look like audio to BASS
2024-04-22 10:45:09 +02:00
Bartłomiej Dach
78f97d0ec7
Merge branch 'master' into verify-check-incorrect-audio-formats
2024-04-22 10:34:14 +02:00
Bartłomiej Dach
ceeb9b0819
Use explicit reference equality check
2024-04-22 10:27:30 +02:00
Bartłomiej Dach
1bcf835d22
Remove redundant array type specification
2024-04-22 10:25:46 +02:00
Bartłomiej Dach
09b0f3005e
Apply generic math-related changes
2024-04-22 10:15:56 +02:00
Arthur Araujo
49563f4e5b
Use bitwise to check hitsound formats
2024-04-22 04:44:38 -03:00
Dan Balasescu
89a4a6878f
Merge pull request #27922 from peppy/quick-exit-from-results
...
Add ability to quick exit from results screen
2024-04-22 16:01:13 +09:00
Andrei Zavatski
1d3fd65d86
Adjust execution order
2024-04-22 07:02:49 +03:00
Andrei Zavatski
722fa228ce
Don't consider editor table content for input
2024-04-21 17:40:35 +03:00
Dean Herbert
b9b341affd
Merge pull request #27930 from peppy/update-framework
...
Update framework
2024-04-20 05:26:53 +08:00
Dean Herbert
4cffc39dff
Don't require hold for quick exit at results screen
2024-04-20 04:53:31 +08:00
