mirror of
https://github.com/ppy/osu.git
synced 2024-11-11 09:27:29 +08:00
03a279a48d
Something I ran into when investigating https://github.com/ppy/osu/issues/28169. If there are two scores with the same online ID available in the database - for instance, one being recorded locally, and one recorded by spectator server, of one single play - the lookup code would use online ID first to find the score and pick any first one that matched. This could lead to the wrong replay being refetched and presented / exported. (In the case of the aforementioned issue, I was confused as to whether after restarting spectator server midway through a play and importing the replay saved by spectator server after the restart, I was seeing a complete replay with no dropped frames, even though there was nothing in the code that prevented the frame drop. It turns out that I was getting presented the locally recorded replay instead all along.) Instead, jiggle the fallback preference to use hash first. |
||
|---|---|---|
| .. | ||
| Audio | ||
| Beatmaps | ||
| Collections | ||
| Configuration | ||
| Database | ||
| Extensions | ||
| Graphics | ||
| Input | ||
| IO | ||
| IPC | ||
| Localisation | ||
| Models | ||
| Online | ||
| Overlays | ||
| Performance | ||
| Properties | ||
| Replays | ||
| Rulesets | ||
| Scoring | ||
| Screens | ||
| Skinning | ||
| Storyboards | ||
| Tests | ||
| Updater | ||
| Users | ||
| Utils | ||
| .editorconfig | ||
| FodyWeavers.xml | ||
| osu!.res | ||
| osu.Game.csproj | ||
| OsuGame.cs | ||
| OsuGameBase_Importing.cs | ||
| OsuGameBase.cs | ||
| PerformFromMenuRunner.cs | ||