Dean Herbert
1539fa704b
Always allow selecting the top-most button using the select binding
2022-07-26 17:46:23 +09:00
Dean Herbert
6ff44ed2c6
Merge pull request #19399 from frenzibyte/carousel-order-stability
...
Maintain sort stability by using carousel item ID as a fallback
2022-07-26 17:33:30 +09:00
Dean Herbert
7f75184a01
Merge branch 'master' into beatmap-update-test
2022-07-26 17:27:36 +09:00
Andrew Hong
003aec86ae
Rearrange sizeaxes
2022-07-26 04:27:22 -04:00
Andrew Hong
aaf6ec05bb
Remove notification upon copy
2022-07-26 04:19:54 -04:00
Dean Herbert
4c22b55ce3
Fix incorrect handling if an update is processed with no changes
2022-07-26 17:00:28 +09:00
Dan Balasescu
412d42b907
Merge pull request #19393 from peppy/fix-statistics-panel
...
Avoid potential realm fetch after disposal in `StatisticsPanel`
2022-07-26 16:32:59 +09:00
Salman Ahmed
a4f6f2b9eb
Make item ID comparer static
2022-07-26 09:55:37 +03:00
Dean Herbert
9939866f7d
Revert one more missed change
2022-07-26 15:54:10 +09:00
Dean Herbert
8370ca9765
Add ImportAsUpdate method to IModelImporter to avoid otehr changes
2022-07-26 15:49:04 +09:00
Salman Ahmed
693ac8750c
Remove remaining uses of "child" terminology in non-drawable components
2022-07-26 09:43:47 +03:00
Salman Ahmed
d7ef4170be
Maintain sort stability by using carousel item ID as fallback
2022-07-26 09:40:41 +03:00
Dean Herbert
4efe09e7c2
Merge pull request #19377 from frenzibyte/fix-timeline-tests
...
Fix intermittent timeline zoom test failures
2022-07-26 15:18:35 +09:00
Dean Herbert
99bdf41717
Avoid potential realm fetch after disposal in StatisticsPanel
...
As seen at https://github.com/ppy/osu/runs/7513799859?check_suite_focus=true .
2022-07-26 15:12:23 +09:00
Dan Balasescu
1b2158ff04
Remove unused method
2022-07-26 14:15:59 +09:00
Dean Herbert
ef10145d6f
Rename MenuCursorContainer and clean up code
2022-07-26 14:11:52 +09:00
Dean Herbert
ee0c67e114
Add ability to make cursor show even during touch input
...
I completely disagree with this from a UX perspective, but it's come up
so often that I figure we should just let users bone themselves.
2022-07-26 14:08:00 +09:00
Andrew Hong
a8e315abf0
Refactor
2022-07-25 17:16:33 -04:00
Andrew Hong
46c4e78477
Add notification and another menuitem
2022-07-25 16:59:00 -04:00
Dean Herbert
d41ac36a69
Fix scenario where import is expected to be empty
2022-07-25 23:59:27 +09:00
Dean Herbert
8a0c8f5fd8
Fix some realm pieces not being cleaned up
2022-07-25 19:51:19 +09:00
Dean Herbert
2e14d8730c
Move implementation of updating a beatmap to BeatmapImporter
2022-07-25 19:51:19 +09:00
Dean Herbert
2363a3fb7b
Persist DateAdded over beatmap updates
2022-07-25 19:51:19 +09:00
Dean Herbert
e5ad07454c
Ensure previous version prior to update loses online info after marked pending delete
2022-07-25 19:51:19 +09:00
Dean Herbert
912218e123
Ensure scores are transferred after beatmap update if difficulty hash didn't change
2022-07-25 19:51:19 +09:00
Dean Herbert
b7f6413bce
Fix old version of beatmap potentially not being deleted during update flow
...
This can happen if the online IDs are not present in the `.osu` files.
Previously this was only working due to the early logic in the import
process (that relies on matching all online IDs perfectly).
2022-07-25 19:51:19 +09:00
Dean Herbert
6a3e8e31de
Centralise calls to reset online info of a BeatmapInfo
2022-07-25 19:51:19 +09:00
Salman Ahmed
1b6ebcfd87
Remove SubmittableScore and replace with SoloScoreInfo extension method
2022-07-25 13:43:43 +03:00
Salman Ahmed
d04df19c7e
Remove APIScore and replace its final usage
2022-07-25 13:13:46 +03:00
Dan Balasescu
068063a43a
Merge pull request #19371 from peppy/fix-working-cache-invalidation
...
Fix calls to `GetWorkingBeatmap` invalidating cache too often
2022-07-25 18:29:46 +09:00
Dan Balasescu
1d48cee230
Merge pull request #19373 from peppy/fix-negative-star-rating-display
...
Fix star ratings which are still being calculated showing as "-1" at song select
2022-07-25 18:20:30 +09:00
Dan Balasescu
6937296192
Merge pull request #19374 from peppy/fps-counter-no-scheduler
...
Refactor `FPSCounter` to not use scheduled tasks
2022-07-25 18:19:59 +09:00
Salman Ahmed
48bcf57066
Mark SetupZoom and parameterless ZoomableScrollContainer ctor as protected
2022-07-25 12:07:50 +03:00
Salman Ahmed
07c6b44864
Fix Timeline attempting to setup zoom with unloaded track
2022-07-25 12:07:50 +03:00
Salman Ahmed
123930306b
Refactor ZoomableScrollContainer to allow setting up zoom range and initial zoom after load
2022-07-25 12:07:50 +03:00
Salman Ahmed
678acabf7e
Merge branch 'master' into log-diffcalc-failure
2022-07-25 11:16:31 +03:00
Andrew Hong
f1534da683
Formatting issues
2022-07-25 04:13:05 -04:00
Andrew Hong
fcf767e28b
Add contextmenu to beatmap external link
2022-07-25 04:07:33 -04:00
Dean Herbert
2dd99ef1fd
Refactor FPSCounter to not use scheduled tasks
...
While on the surface this looks harmless (ignoring allocations),
`Scheduler` doesn't clear cancelled tasks until they reach their
execution time. This can cause an increase in time spent processing the
scheduler itself.
I don't think a per-frame updating component should use scheduled tasks
in this way in the first place, so I've just rewritten the logic to
avoid that overhead altogether.
2022-07-25 16:26:48 +09:00
Salman Ahmed
4d90e6bbac
Flip method to read better
2022-07-25 10:03:06 +03:00
Dean Herbert
6bf2645b1a
Fix StarRatingDisplay not handling negative numbers as "pending"
2022-07-25 15:44:54 +09:00
Salman Ahmed
e402e919ab
Display placeholder for user profile scores
2022-07-25 09:40:20 +03:00
Dean Herbert
2ec90e37bb
Fix calls to GetWorkingBeatmap invalidating cache too often
...
With recent changes, the pathway between refetching (on request) and
refetching (on requirement due to unpopulated files) was combined.
Unfortunately this pathway also added a forced invalidation, which
should not have been applied to the second case.
Closes https://github.com/ppy/osu/issues/19365 .
2022-07-25 15:30:49 +09:00
Salman Ahmed
f54cee0270
Display placeholder for leaderboard top scores
2022-07-25 09:18:04 +03:00
Salman Ahmed
91d1c9686c
Separate unprocessed PP placeholder to own class
2022-07-25 09:07:51 +03:00
Salman Ahmed
54eb2b98a9
Display exclamation triangle on scores with unprocessed PP
2022-07-25 07:30:57 +03:00
Salman Ahmed
3beb1da3de
Merge branch 'master' into beatmap-overlay-null-pp
2022-07-25 07:18:03 +03:00
Dean Herbert
12e2e63a1c
Merge pull request #19349 from bdach/mod-overlay/presets-column
...
Implement basic appearance of mod preset column
2022-07-25 13:10:47 +09:00
Dan Balasescu
3d97b74813
Log beatmap difficulty retrieval failures during score calculation
2022-07-25 13:03:47 +09:00
Salman Ahmed
fa9daa6899
Fix TestSceneReplayRecorder not using score provided by gameplay state
2022-07-25 05:21:27 +03:00
Salman Ahmed
e0266b0d81
Reword comment slightly
2022-07-25 04:39:14 +03:00
Salman Ahmed
f5a5887669
Fix players potentially not displaying in spectator after restart
2022-07-25 04:21:53 +03:00
Bartłomiej Dach
446485f804
Move localisation string to common location
2022-07-24 23:30:52 +02:00
Bartłomiej Dach
8af9cfbe40
Add readonly modifier
2022-07-24 23:29:18 +02:00
Bartłomiej Dach
6a67d76d7c
Add basic mod preset column implementation
2022-07-24 16:39:04 +02:00
Bartłomiej Dach
b2f8934117
Extract base mod select column presentation logic
2022-07-24 16:39:03 +02:00
Salman Ahmed
4332e6cae9
Fix OsuSliderBar throwing on negative draw width
2022-07-24 08:34:24 +03:00
Salman Ahmed
7c477e6f22
Fix beatmap overlay leaderboard not handling null PP scores properly
2022-07-24 04:20:49 +03:00
Dean Herbert
f1791e79e3
Add error logging for background processing failures
2022-07-23 19:22:16 +09:00
Salman Ahmed
836cb0927c
Merge branch 'master' into disable-backgorund-beatmap-processor-for-tests
2022-07-23 11:55:24 +03:00
Salman Ahmed
840ad8fad2
Fix background beatmap processor resetting star ratings in tests
2022-07-23 11:10:59 +03:00
Salman Ahmed
2829a7e836
Merge branch 'master' into beatmap-overlay-modded-stats
2022-07-23 10:38:13 +03:00
Salman Ahmed
661c79baf6
Add explanatory comment
2022-07-23 10:16:11 +03:00
Adam Baker
06462c13dd
Overwrite IBindable<ReadOnlyList<Mod>> cache in BeatmapSetOverlay
...
Implement fix as suggested
2022-07-22 23:15:24 -05:00
Adam Baker
d451bc8fda
Revert commits
...
This reverts commit 28586c704dd9d35bb847
2022-07-22 22:25:49 -05:00
Dean Herbert
98593fbba1
Merge pull request #19287 from bdach/mod-overlay/preset-panel
2022-07-23 11:18:51 +09:00
Dean Herbert
db632c0d6e
Inline rolling duration
2022-07-23 02:38:00 +09:00
Dean Herbert
475679ca66
Fix DI failure
2022-07-23 02:27:47 +09:00
Dean Herbert
bb46ba66e0
Simplify TotalScoreCounter tick playback logic
2022-07-23 02:27:17 +09:00
Bartłomiej Dach
d0e15d04cc
Merge branch 'master' into mod-overlay/preset-panel
2022-07-22 19:23:09 +02:00
Bartłomiej Dach
f3ceabc53f
Rename ModSelect{Overlay -> }Panel
2022-07-22 19:17:22 +02:00
Dean Herbert
9f045209b9
Simplify score panel balance adjustment
2022-07-23 02:09:08 +09:00
Dean Herbert
e08e4fc426
Update framework
2022-07-23 00:04:14 +09:00
Dean Herbert
9c0d793896
Update resources
2022-07-23 00:04:11 +09:00
Jamie Taylor
62d4d4b055
Add dynamic panning fun to score panel sfx
2022-07-22 21:03:47 +09:00
Jamie Taylor
89da21b6de
Add total score counter sfx
2022-07-22 21:03:47 +09:00
Jamie Taylor
6ce8e74e6b
Add panel appearance sounds
2022-07-22 21:03:46 +09:00
Dan Balasescu
d9105c9785
Merge pull request #19272 from peppy/beatmap-background-reprocessing
...
Add background beatmap processing
2022-07-22 20:33:26 +09:00
Dean Herbert
63fe4f265f
Merge pull request #19263 from frenzibyte/fix-failed-score-statistics
...
Populate failed scores with "miss" results for all remaining hitobjects
2022-07-22 20:16:16 +09:00
Adam Baker
d9d35bb847
Set BeatmapSetHeaderContent details to not show modded values
2022-07-22 05:43:56 -05:00
Adam Baker
28586c704d
Add showModdedValue parameter to StatisticRow
2022-07-22 05:43:05 -05:00
Dean Herbert
bfafb4480e
Merge pull request #19296 from smoogipoo/fix-timeline-focus-point
...
Fix timeline zoom focus point when using zoom buttons
2022-07-22 17:43:36 +09:00
Dan Balasescu
1d69090301
Merge pull request #19295 from frenzibyte/filter-control-available-area
...
Fix sorting mode not filling up to usable area in filter control
2022-07-22 17:20:40 +09:00
Dan Balasescu
83f696e757
Merge pull request #19279 from peppy/fps-counter-cleanup
...
Cleanup pass on `FPSCounter`
2022-07-22 17:20:32 +09:00
Dan Balasescu
e1df50c8ff
Fix timeline zoom focus point when using buttons
2022-07-22 17:03:05 +09:00
Dean Herbert
72916d708c
Merge pull request #19294 from peppy/fix-timeline-feedback-loop
...
Fix timeline `alt`+`scroll` zoom not correctly zooming to current mouse position
2022-07-22 16:05:38 +09:00
Dean Herbert
be0d73f951
Merge branch 'master' into fps-counter-cleanup
2022-07-22 15:39:37 +09:00
Dean Herbert
1774a96455
Merge pull request #19278 from Cwazywierdo/timeline-relative-zoom
...
Make editor timeline zoom relative to song length
2022-07-22 15:37:47 +09:00
Dan Balasescu
5444ce0cc9
Merge pull request #19277 from peppy/fps-counter-no-rolling-counter
...
Avoid using `RollingCounter` in fps counter
2022-07-22 15:28:13 +09:00
Dean Herbert
6eb42d08ce
Fix timeline zoom receiving feedback from bindable changes
...
This causes the focal point zooming to not work (as the focal point is
lost). There's no need to handle ongoing changes to
`BeatmapInfo.TimelineZoom` because it is not a property which is changed
at runtime.
2022-07-22 15:25:57 +09:00
Salman Ahmed
3b913bb9ad
Fix sorting mode not filling up to usable area in filter control
2022-07-22 09:15:48 +03:00
Dean Herbert
4cec9a085a
Combine both calls to use same pathway
2022-07-22 14:59:20 +09:00
Dan Balasescu
f87efae115
Merge pull request #19293 from peppy/skin-editor-save-hotkey
...
Add the ability to save in the skin editor using system save hotkey
2022-07-22 14:43:34 +09:00
Dean Herbert
f713253d1b
Fix formatting inconsistencies in empty ctors
2022-07-22 14:00:29 +09:00
Dean Herbert
92f59ce9a0
Add the ability to save in the skin editor using system save hotkey
2022-07-22 13:10:18 +09:00
LukynkaCZE
ed94d7fce8
Fix requested changes
2022-07-22 02:46:17 +02:00
Adam Baker
997fe00cdc
Fix zoom delta math
2022-07-21 17:29:13 -05:00
Adam Baker
d69dc457ba
Extract zoom delta method
2022-07-21 17:28:43 -05:00
LukynkaCZE
ebe386c288
Merge branch 'ppy:master' into editor-save-toast
2022-07-22 00:25:23 +02:00
Bartłomiej Dach
a3090003de
Add tooltip showing contents of mod preset
2022-07-21 23:29:21 +02:00
Bartłomiej Dach
bdff7f1ef4
Implement basic appearance of mod preset panels
2022-07-21 23:29:21 +02:00
Bartłomiej Dach
de0a076eb6
Add model class for mod presets
2022-07-21 23:29:21 +02:00
Bartłomiej Dach
6cd18fad99
Fix code inspections after base panel class extraction
2022-07-21 23:29:08 +02:00
Bartłomiej Dach
d796b7d53c
Extract base mod select overlay panel presentation logic
2022-07-21 22:37:00 +02:00
Dean Herbert
b9f5074c13
Merge branch 'fps-counter-no-rolling-counter' into fps-counter-cleanup
2022-07-22 02:22:01 +09:00
Dean Herbert
b3aa496ba7
Add handling of realm disposed exceptions
2022-07-22 00:14:30 +09:00
Dean Herbert
0eeafea500
Increase responsiveness to change slightly
2022-07-21 23:37:32 +09:00
Dean Herbert
c140601c2d
Cleanup pass on FPSCounter
2022-07-21 23:02:31 +09:00
Dean Herbert
fc6445caea
Rate limit updates for good measure
2022-07-21 22:55:45 +09:00
Dean Herbert
3d2603e0eb
Remove unused classes
2022-07-21 22:51:35 +09:00
Dean Herbert
3fad481a96
Avoid using RollingCounter in fps counter
...
It wasn't made to be updated every frame, and it shows. Inaccurate for
reasons I'm not really interested in investigating, because I don't want
to incur the `Transorm` overhead in the first place for an fps counter.
Was only used originally out of convenience.
2022-07-21 22:50:02 +09:00
Adam Baker
a4f071fe53
Make zoom sensitivity relative to containers max zoom
2022-07-21 08:26:48 -05:00
Dean Herbert
5db4d9437a
Add missing using statement
2022-07-21 21:39:24 +09:00
Dan Balasescu
6fac34c721
Merge pull request #19274 from peppy/fix-fps-counter-fps-inaccuracy
...
Fix draw FPS being inaccurate due to using `ElapsedFrameTime`
2022-07-21 20:55:14 +09:00
Dan Balasescu
2001d79bb2
Merge pull request #19269 from peppy/fix-update-button-test-failure
...
Fix `UpdateBeatmapSetButton` intermittent test failure
2022-07-21 20:36:00 +09:00
Dean Herbert
4c4939d18d
Fix draw FPS being inaccurate due to using ElapsedFrameTime
...
Had a feeling this would be the case.
Basically, we're calculating on the update thread and checking the last
value of draw thread's `ElapsedFrameTime`. In the case that value is
spiky, a completely incorrect fps can be displayed.
I've left the spike display do use `ElapsedFrameTime`, as
`FramesPerSecond` is too averaged to see spikes.
2022-07-21 19:17:58 +09:00
Dean Herbert
fb728fbed1
Fix FPS counter not being wide enough to show large fps numbers
2022-07-21 18:56:39 +09:00
Dean Herbert
94cd641fb4
Change migration to trigger reprocessing on every local beatmap
...
Was originally relying on the fact that this would be triggered due to a
null `LastOnlineUpdate`, but wouldn't cover the case of beatmaps with no
`OnlineID`.
2022-07-21 18:31:12 +09:00
Dean Herbert
1374738a0d
Add test coverage
2022-07-21 18:20:46 +09:00
Dean Herbert
d5e0dba9da
Change default value of StarRating to -1
2022-07-21 18:20:46 +09:00
Dean Herbert
04f48d8862
Add better log output and sleeping during gameplay sections
2022-07-21 18:20:46 +09:00
Dean Herbert
57a41c6897
Add basic background processor
2022-07-21 18:20:46 +09:00
Dean Herbert
68f28ff660
Add last applied version to RulesetInfo
2022-07-21 18:15:25 +09:00
Dean Herbert
aca19a005e
Add versioning to difficulty calculators
2022-07-21 18:15:25 +09:00
Salman Ahmed
559254db31
Merge branch 'master' into fix-update-button-test-failure
2022-07-21 11:15:43 +03:00
Salman Ahmed
aa7c16ee5f
Merge branch 'master' into change-carousel-item-terminology
2022-07-21 10:29:13 +03:00
Dan Balasescu
defadeef47
Merge pull request #19250 from peppy/fps-counter
...
Add game-side FPS counter
2022-07-21 16:26:38 +09:00
Dean Herbert
fc0c9f76bd
Fix UpdateBeatmapSetButton intermittent test failure
...
Carousel would only expire items when off-screen. This meant that for a
case (like a test) where items are generally always on-screen,
`UpdateBeatmapSet` calls would result in panels remaining hidden but not
cleaned up.
2022-07-21 16:24:48 +09:00
Dean Herbert
3cfe624af1
Fix one more missed method with incorrect terminology
2022-07-21 16:16:41 +09:00
Dean Herbert
a05d7f4d8c
Change carousel terminology to not use Children / InternalChildren
2022-07-21 16:06:06 +09:00
Dean Herbert
07e1763a70
Tweak velocity a bit more (and simplify in multiple places)
2022-07-21 14:25:11 +09:00
Salman Ahmed
a97170a272
Keep Rank bindable enabled on score fail
2022-07-21 08:16:17 +03:00
Salman Ahmed
9df49db45f
Include bonus/ignore judgements in statistics fill logic
2022-07-21 08:13:09 +03:00
Salman Ahmed
ad09e728fd
Move Passed assignment inside FailScore
2022-07-21 08:12:06 +03:00
TacoGuyAT
2f16174d3d
Changed control points set to private; Cleanup
2022-07-21 07:25:44 +03:00
Salman Ahmed
c1bcbd9c8a
Fix fail score not handling bonus/tick-only beatmaps
2022-07-21 07:20:59 +03:00
Dean Herbert
56106e43d2
Avoid div-by-zero
2022-07-21 13:06:43 +09:00
Dean Herbert
311a0a3de0
Always show counter temporarily when aim FPS changes
2022-07-21 12:57:40 +09:00
Dean Herbert
705ff06ea5
Better handle spikes and significant changes
2022-07-21 12:50:39 +09:00
Dean Herbert
285516b111
Fix isDisplayed never actually being set
2022-07-21 12:40:27 +09:00
TacoGuyAT
d6c3a52494
Added missing braces
2022-07-21 06:38:33 +03:00
TacoGuyAT
ed8e065a86
Logo triangles speed and beat sync tweaks
2022-07-21 06:13:45 +03:00
Dean Herbert
728e22fbce
Improve tooltip display when running single thread
2022-07-21 12:06:22 +09:00
Salman Ahmed
0f0b19da4a
Populate score with remaining "miss" statistics on fail/exit
2022-07-21 06:01:36 +03:00
Salman Ahmed
c4089b71bd
Store maximum score results from simulated autoplay
2022-07-21 06:00:41 +03:00
Dean Herbert
e1a577ea48
Adjust spacing to make things feel more even
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-07-21 11:59:51 +09:00
Dean Herbert
57ecc3a6df
Remove unnecessary negative spacing from thread names
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-07-21 11:59:26 +09:00
Dean Herbert
c7313b4198
Fix alignment glitching due to non-matching anchor/origin
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-07-21 11:58:28 +09:00
Dean Herbert
75453b78c0
Adjust colours and metrics
2022-07-21 00:09:46 +09:00
Dean Herbert
f54aff2ece
Add global key binding for FPS toggle
2022-07-21 00:09:46 +09:00
Dean Herbert
0a1744faca
Add to game and bind with configuration setting
2022-07-20 23:49:19 +09:00
Dean Herbert
0fb959a565
Stay displayed while hovering
2022-07-20 23:49:19 +09:00
Dean Herbert
03e644e548
Choose colours based on relative performance goals
2022-07-20 23:49:19 +09:00
Dean Herbert
0c3d43026d
Add initial structure for fps counter
2022-07-20 23:49:19 +09:00
Dan Balasescu
7dfc18a0e3
Merge pull request #19208 from frenzibyte/remove-score-multiplier-on-custom-mod-settings
...
Remove score multiplier on difficulty-increasing mods with customised settings
2022-07-20 20:12:59 +09:00
Dean Herbert
62133fa069
Merge pull request #19246 from frenzibyte/fix-wiki-navigation
...
Fix wiki overlay not handling path redirection properly
2022-07-20 20:08:11 +09:00
Dan Balasescu
2b399ec7ad
Merge branch 'master' into date-submitted-ranked
2022-07-20 18:36:57 +09:00
Salman Ahmed
5e933cb466
Improve comment wording
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2022-07-20 09:43:32 +03:00
Dan Balasescu
de29078db2
Remove nullable disables
2022-07-20 15:16:40 +09:00
Dan Balasescu
f9c02c34b6
Merge branch 'master' into beatmap-update-online-flow
2022-07-20 15:15:51 +09:00
Salman Ahmed
474c1a8a7a
Fix wiki overlay not handling path redirection properly
2022-07-20 09:06:11 +03:00
Salman Ahmed
e7f35701db
Add failing test case
2022-07-20 09:06:11 +03:00
Salman Ahmed
6ce6f6f7df
Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings
2022-07-20 08:57:43 +03:00
Dean Herbert
af4d7feb9b
Merge pull request #19244 from frenzibyte/highlight-perfect-ticks
...
Highlight perfect slider tick/end values in beatmap info leaderboards
2022-07-20 14:44:03 +09:00
Dan Balasescu
6c0d7f8099
Merge pull request #19235 from andy840119/remove-nullable-disable-in-the-mods
...
Remove nullable disable annotation in the mods.
2022-07-20 14:39:32 +09:00
Dan Balasescu
c4e32742dc
Merge pull request #19234 from Cwazywierdo/edit-map-carousel
...
Fix multiplayer map selection carousel opening to wrong map
2022-07-20 13:53:41 +09:00
Dean Herbert
2a76a04619
Update framework
2022-07-20 13:41:36 +09:00
Dan Balasescu
1fae683b33
Merge pull request #19240 from peppy/fix-mouse-floating-position
...
Fix floating mouse position not running correctly in single thread mode
2022-07-20 13:32:21 +09:00
Dan Balasescu
ebb9861377
Merge branch 'master' into remove-nullable-disable-in-the-mods
2022-07-20 13:28:28 +09:00
Adam Baker
cecf654a7b
Update osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerMatchSubScreen.cs
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-07-19 18:58:59 -05:00
Salman Ahmed
ae6aab2555
Merge branch 'master' into edit-map-carousel
2022-07-20 02:43:47 +03:00
Salman Ahmed
990d3ffb39
Merge branch 'master' into fix-editor-clap-finish-order
2022-07-20 02:26:40 +03:00
Salman Ahmed
1270abdf42
Highlight perfect slider tick/end values in beatmap info leaderboards
2022-07-20 00:53:10 +03:00
LukynkaCZE
5987acfbca
Fixed code formatting
2022-07-19 22:59:25 +02:00
LukynkaCZE
51a0b5afdc
Skin Editor
2022-07-19 22:18:19 +02:00
LukynkaCZE
a00da279b7
Beatmap Editor Save Toast
2022-07-19 21:38:23 +02:00
Salman Ahmed
4210ec6502
Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings
2022-07-19 19:21:26 +03:00
Salman Ahmed
89653b74c7
Only add setting tracker when customisation is permitted
2022-07-19 19:21:16 +03:00
Dean Herbert
7be5c638e4
Fix floating mouse position not running correctly in single thread mode
...
Noticed while testing on iOS. Previously, the interpolation was being
done in input handling but using the update thread clock, leading to
incorrect application.
2022-07-20 00:22:45 +09:00
Dean Herbert
87afa7317b
Update framework
2022-07-19 23:12:49 +09:00
Dean Herbert
25028bb7fa
Fix editor clap/finish buttons being ordered against expectations
2022-07-19 22:36:11 +09:00
Adam Baker
4164f260b3
Fix code quality errors
2022-07-19 08:12:12 -05:00
為什麼
317558f876
Mark the shader as non-nullable because shader should always has the value.
...
And initialize the breaks to avoid get the null instance.
2022-07-19 20:39:41 +08:00
為什麼
3af093cb27
Remove the null check because bindable should always have the value.
2022-07-19 20:39:41 +08:00
為什麼
ce1bb206c8
Initialize some bindables for prevent get the null instance.
2022-07-19 20:39:41 +08:00
andy840119
1f9f2b413e
Remove the nullable disable annotation.
...
Also, mark as nullable for some properties.
2022-07-19 20:39:41 +08:00
Dean Herbert
6357223341
Fix incorrect DI fetch and apply nullability to ModelDownloader
2022-07-19 20:06:34 +09:00
Dean Herbert
30daa0fd44
Add ranked and submitted date storage and filtering
2022-07-19 19:55:56 +09:00
Dean Herbert
07874efa7f
Set last online update to actual value provided by data source
2022-07-19 19:39:51 +09:00
Dean Herbert
17046b0553
Add basic handling of download failures
2022-07-19 19:01:23 +09:00
Dean Herbert
a16bf35581
Rename button class and add basic progress display
2022-07-19 18:29:36 +09:00
Dean Herbert
da360af15a
Fix vertical centering of button
2022-07-19 18:29:36 +09:00
Dean Herbert
eaf4f6dbb7
Add beatmap update button
2022-07-19 18:29:36 +09:00
Dean Herbert
6adcf82d2e
Add change ingester to handle passing of online changes to correct target components
2022-07-19 17:57:01 +09:00
Dean Herbert
cd39f444ef
Expose event from OnlineMetadataClient rather than calling BeatmapUpdater directly
2022-07-19 17:57:01 +09:00
Dean Herbert
6ea380d649
Add new properties to BeatmapInfo to track online hash and updates
2022-07-19 17:57:01 +09:00
Dean Herbert
12e5bc3f3d
Fix BeginPlayingInternal firing actual errors when beatmap not available online
2022-07-19 17:14:57 +09:00
Adam Baker
5008a73774
Make add item button open to the last beatmap in queue
2022-07-19 02:04:19 -05:00
Dean Herbert
2716bd41d9
Use more correct json casing in APIScoresCollection
...
osu-web API is already returning both of these casings for backwards
compatibility, but the former will be removed at some point.
e540276721/app/Http/Controllers/BeatmapsController.php (L314-L315)
2022-07-19 15:34:17 +09:00
Dan Balasescu
c07f78409e
Merge pull request #19189 from peppy/peform-actions-after-reconnect
...
Fix creating multiplayer game during server migration not joining new room correctly
2022-07-19 14:46:29 +09:00
