Dean Herbert
a6b6644c2e
Replace LINQ queries with recommendations
2022-02-23 16:22:13 +09:00
Dean Herbert
9e279c3ebc
Fix completely incorrect judgement specification
2022-02-22 14:37:52 +09:00
Dean Herbert
91acc9eec6
Remove checks which are still going to occasionally fail due to pooling
2022-02-22 14:36:08 +09:00
Dean Herbert
0d56693b7a
Fix test not always checking the final bonus value
...
Due to the previous logic not waiting until the spinner had completed,
there could be false negatives as the check runs too early, with a
potential additional bonus spin occurring afterwards.
2022-02-22 14:28:15 +09:00
Dean Herbert
692ddd5f52
Merge branch 'master' into issues/16839-spun-out-rate
2022-02-22 14:04:45 +09:00
Dan Balasescu
567da9214e
Merge branch 'master' into osu-diff-calc-max-combo
2022-02-18 18:35:24 +09:00
Dean Herbert
7307e68e9c
Revert "Merge pull request #16889 from smoogipoo/remove-mod-multiplier"
...
This reverts commit 252b945d3b
, reversing
changes made to a1b39a96cf
.
2022-02-17 13:26:12 +09:00
Dean Herbert
28fcad9281
Update failing test to not account for no-longer-existing multiplier
2022-02-16 17:33:55 +09:00
Salman Ahmed
8b30c847f9
Update outdated bindable casts in tests
2022-02-16 08:39:08 +03:00
Salman Ahmed
0992bec2c8
Change "distance spacing" multipler type to double
...
Avoids losing precision on initial load, causing an unnecessary
hash change in `EditorChangeHandler`.
Resolves test failures in `TestSceneEditorChangeStates`
(https://github.com/ppy/osu/runs/5192493482?check_suite_focus=true ).
2022-02-16 03:28:12 +03:00
Dean Herbert
d79845fb1d
Revert NUnit3TestAdaptor
(again)
...
Console output is still broken. See
https://github.com/ppy/osu/runs/5196023462?check_suite_focus=true .
2022-02-15 17:06:34 +09:00
Dean Herbert
60153bb69d
Update nuget packages to highest usable versions
...
EF packages are intentionally pinned to 5.0.14 as higher versions no
longer support `netstandard2.1`, which we require for xamarin projects.
2022-02-15 15:19:23 +09:00
Salman Ahmed
500322ff21
Update failing snap test scenes
2022-02-15 02:21:53 +03:00
Salman Ahmed
528dc03b8c
Expose distance spacing in IPositionSnapProvider
for updating distance grid
...
Alternate method is to expose a `SnapDistancesChanged` event in
`IPositionSnapProvider` instead, but I chose this way as an analogue to
`IBeatSnapProvider.BeatDivisor`, which might even make sense to be
exposed as `BindableBeatDivisor` instead of caching that separately.
2022-02-15 02:21:53 +03:00
Kaleb
95b1bffffe
Add test to ensure spinners only complete
...
No bonus or a non-300 judgement
2022-02-14 03:46:36 -05:00
Kaleb
c1777f20e1
Fix Spun Out tests
...
Change 'unaffected by mods' test to use dynamic RPM value instead of a fixed value
2022-02-14 03:11:44 -05:00
Dean Herbert
176bb4a4e2
Update desktop projects to target .NET 6
2022-02-10 17:42:09 +09:00
Dean Herbert
2731d8e3c2
Merge pull request #16701 from LeNitrous/mod-alternate-osu
...
Add "Alternate" mod for osu! ruleset
2022-02-03 10:41:23 +09:00
Dean Herbert
987aa5a21c
Add testing of different strengths
2022-02-02 16:26:00 +09:00
Dean Herbert
6b31e7e9db
Merge branch 'master' into aimassist-mod
2022-02-02 15:18:48 +09:00
Dean Herbert
104256a054
Add test coverage
2022-02-02 15:18:44 +09:00
Bartłomiej Dach
7cdf63c654
Remove unused FindProvider()
methods
...
No longer needed since 39f99bf785
.
2022-02-01 21:53:21 +01:00
Nitrous
e408d8ef0e
rename Frames
to ReplayFrames
2022-01-29 23:19:51 +08:00
Nitrous
1087d8b1ce
add tests
2022-01-29 22:31:31 +08:00
Dean Herbert
17f0d7897b
Increase lenience of alpha check in TestSceneOsuModNoScope
...
I believe the [test
failures](https://github.com/ppy/osu/runs/4977283066?check_suite_focus=true )
we're seeing here are due to the implementation of interpolation of the
alpha being frame dependent (in a way that doesn't interact well with
tests). The reason for never hitting the expected value is that the
beatmap ends, causing the cursor to become fully visible again.
It's probably already good-enough for most cases, so let's attempt to
silence these test failures by not checking so precisely for the alpha
value.
We're checking for either 1 or 0 so it's not too important how close it
is to either.
2022-01-28 18:36:00 +09:00
Dean Herbert
deaff340d2
Add test coverage of saving velocity
2022-01-24 19:43:18 +09:00
Henry Lin
44311c1f4e
Add tests for diffcalc max combo
2022-01-23 11:25:22 +08:00
Dan Balasescu
3e5d29ed00
Merge pull request #16505 from peppy/remove-base-difficulty-usage
...
Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)
2022-01-19 13:53:55 +09:00
Dean Herbert
96d07e20ed
Revert nunit test adaptor version bump until console output bug is resolved
...
Tests have started to output too much log content, causing viewing CI
failures to be painfully impossible. Roll back for now.
Fix may be related to
https://github.com/nunit/nunit3-vs-adapter/issues/941 , although we don't
use filter.
2022-01-19 02:18:58 +09:00
Dean Herbert
7f65f3a47f
Remove all usage of BaseDifficulty
(and access Difficulty
instead)
2022-01-18 22:57:39 +09:00
Dean Herbert
1b62a685f3
Merge branch 'master' into realm-integration/score-and-beatmaps
2022-01-18 15:07:59 +09:00
Dean Herbert
125439d177
Update all (non-NET6) nuget packages
2022-01-18 11:09:26 +09:00
Dean Herbert
b5f670cc5b
Add far too many fixes for ruleset non-nullable requirements
2022-01-12 23:24:11 +09:00
Dean Herbert
90558f809f
Merge branch 'master' into slider-snapping
2022-01-10 22:42:16 +09:00
Bartłomiej Dach
d2f44813dd
Add test coverage for slider snapping when adding/removing control points
2022-01-07 15:47:02 +01:00
Bartłomiej Dach
814b318a10
Add test coverage of slider end snapping behaviour
2022-01-07 15:47:02 +01:00
Dean Herbert
f9713b8895
Replace usage of TimeoutAttribute
to fix beatmap conversion test failures
2022-01-04 11:51:41 +09:00
Bartłomiej Dach
b29c2bf9f3
Add test resources for animated legacy hit circle overlay
2021-12-28 15:58:34 +01:00
Bartłomiej Dach
c429c74d89
Expose and use test ruleset config cache in test scenes
2021-12-23 19:42:26 +01:00
Bartłomiej Dach
5cbaa028eb
Use extracted ruleset config cache implementation in DI
2021-12-23 19:02:10 +01:00
Bartłomiej Dach
29b42402a3
Add failing test for drag after placement moving last placed point sometimes
2021-12-23 09:06:03 +01:00
Bartłomiej Dach
ef20182a34
Rewrite test to check selection state during and after new control point placement
2021-12-22 10:57:39 +01:00
Bartłomiej Dach
307d3709e0
Add failing test steps for selection behaviour on new point creation
2021-12-22 09:32:38 +01:00
Bartłomiej Dach
9973db3981
Add failing test steps for right click behaviour
2021-12-22 08:40:17 +01:00
Bartłomiej Dach
adfadc13f7
Add test case for dragging selection including slider head
2021-12-21 12:34:55 +01:00
Bartłomiej Dach
b311308ada
Add more comprehensive test of multiple selection
2021-12-20 22:41:24 +01:00
Bartłomiej Dach
cdb587d956
Add more test steps for input handling edge cases
2021-12-20 21:51:56 +01:00
Bartłomiej Dach
d2417beeac
Implement drag operation for multiple path control points
2021-12-20 21:29:57 +01:00
Bartłomiej Dach
fbba8293c7
Add failing test for expected multiple path drag UX
2021-12-20 21:01:11 +01:00
Dean Herbert
f6a3709060
Store default skins to database
2021-11-29 18:28:25 +09:00
Dean Herbert
e0629ba81c
Update all dependencies
2021-11-20 13:31:10 +09:00
Dean Herbert
fabf253381
Update difficulty calculator tests to also use IWorkingBeatmap
2021-11-15 19:16:49 +09:00
Dean Herbert
369b4ba789
Update DifficultyCalculator
to take an IRulesetInfo
2021-11-15 19:16:48 +09:00
Dan Balasescu
a76247603f
Merge pull request #15564 from apollo-dw/sliderend-sr
...
Nerf dropped sliders in osu! difficulty calculation
2021-11-12 18:16:28 +09:00
Dan Balasescu
512094c17b
Update tests
2021-11-12 14:00:36 +09:00
Bartłomiej Dach
8aa04864ce
Add support for converting sliders with repeats to streams
2021-11-11 23:25:49 +01:00
Bartłomiej Dach
0cd3f98598
Ensure samples & sample points are carried over during conversion
2021-11-11 21:43:06 +01:00
Bartłomiej Dach
d9494d405e
Add test coverage for slider-to-stream conversion
2021-11-11 21:01:30 +01:00
Semyon Rozhkov
34d235b790
Reset combo in different way
2021-11-10 15:50:36 +03:00
Dan Balasescu
2c1941eec6
Merge pull request #15514 from Wieku/fix-initial-strain
...
Change currentStrain to 0 for standard mode skills
2021-11-08 12:04:50 +09:00
Dean Herbert
17637d9dac
Merge pull request #15505 from peppy/use-class-rename
...
Rename `User` to `APIUser` and move to correct namespace
2021-11-08 11:48:19 +09:00
Sebastian Krajewski
e88b0e5587
Fix tests
2021-11-08 02:08:12 +01:00
smoogipoo
366583c8e2
Update tests
2021-11-08 00:33:57 +09:00
smoogipoo
95f2bef119
Update tests
2021-11-07 23:27:37 +09:00
Dean Herbert
0ecf5f201c
Rename User
to APIUser
and move to correct namespace
2021-11-07 11:26:01 +09:00
smoogipoo
c3a31a019b
Merge branch 'master' into aim-refactor-base
2021-11-03 00:32:51 +09:00
smoogipoo
5486ca084e
Resolve tests
2021-11-02 23:32:58 +09:00
Dan Balasescu
3f31cb39c0
Merge pull request #15279 from Flux3on/spinner-judgement-fix
...
Fix spinner judgements on old beatmaps get incorrectly stacked
2021-11-02 14:46:15 +09:00
dependabot[bot]
7747fd5810
Bump Microsoft.NET.Test.Sdk from 16.11.0 to 17.0.0
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.11.0 to 17.0.0.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.11.0...v17.0.0 )
---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-11-01 17:01:54 +00:00
Dean Herbert
0a56e22fa0
Remove unused using statement
2021-10-29 12:14:14 +09:00
Dean Herbert
e0cdcdd7a4
Merge branch 'master' into spinner-judgement-fix
2021-10-29 12:13:42 +09:00
Dean Herbert
6944151486
Apply batch fixing of built-in types using var
2021-10-27 13:04:41 +09:00
Dean Herbert
838481bf3a
Merge pull request #15252 from jaswon/no-scope-breaks
...
Show cursor during breaks and spinners in no scope mod
2021-10-27 12:55:02 +09:00
Dean Herbert
e7b19cb724
Rename test and fix incorrect layout
2021-10-26 11:30:36 +09:00
Roxie Wattz
3687f830e8
Rename my test scene
...
As requested by bdach
2021-10-25 16:57:07 -07:00
Roxie Wattz
7a92c7ab7e
Move condition to separate switch statement
...
No clue if this is how peppy wanted me to do it but it still works
2021-10-25 00:25:32 -07:00
Roxie Wattz
03896fd2eb
Added test for Ouendan 2 style Hidden mod
2021-10-24 22:17:55 -07:00
Roxie Wattz
27d4201dae
Added a spinner spam test
...
Shoutout to Echo for making Wizards in Winter x3
2021-10-24 19:42:37 -07:00
Jason Won
9f62d1d98c
add tests for NoScope
2021-10-24 19:04:04 -04:00
Dean Herbert
06249c4ab2
Fix incorrect usages of Scheduler.AddOnce
2021-10-14 17:52:19 +09:00
smoogipoo
aa380a11c1
Merge branch 'master' into no-more-difficulty-control-points-info
2021-10-14 12:02:10 +09:00
smoogipoo
ceec81d54d
Fix another spinner test failure
2021-10-13 20:26:54 +09:00
Dan Balasescu
e49f1f6e6b
Merge branch 'master' into no-more-difficulty-control-points-info
2021-10-13 20:17:57 +09:00
smoogipoo
e36c484060
Ensure rewinding before the spinner's start time
2021-10-13 15:30:58 +09:00
smoogipoo
392e7c4e73
Update tests
2021-10-10 16:16:59 +09:00
Dan Balasescu
8884091422
Merge pull request #15014 from joseph-ireland/remove-initial-strain
...
Change initial strain value in skills from 1 to 0
2021-10-10 15:56:20 +09:00
smoogipoo
bc37cb6f43
Merge branch 'master' into no-more-difficulty-control-points-info
2021-10-08 18:41:17 +09:00
Dan Balasescu
bece807857
Merge pull request #14980 from peppy/difficulty-move-to-beatmap
...
Copy `BaseDifficulty` to `Beatmap<T>` and move the majority of write operations across
2021-10-07 18:43:44 +09:00
Joseph Ireland
185bb9c122
change initial strain from 1 to 0 to allow simpler implementations
2021-10-07 09:30:18 +01:00
Dean Herbert
c41271ea78
Fix hidden test failures
2021-10-07 16:26:24 +09:00
Dean Herbert
b339c149d8
Copy BaseDifficulty
to Beatmap<T>
and move all write operations across
2021-10-06 15:10:45 +09:00
Dean Herbert
bd84a8b749
Merge branch 'new-interfaces' into beatmap-difficulty-more-interface-usage
2021-10-05 18:21:21 +09:00
Dean Herbert
853cf6feaa
Rename last remaining BeatmapInfo Beatmap
usage
2021-10-04 17:35:53 +09:00
Dan Balasescu
aa1bfc16d2
Merge pull request #14929 from peppy/gameplay-state
...
Replace `GameplayBeatmap` with `GameplayState`
2021-10-04 15:56:44 +09:00
Bartłomiej Dach
07c11953cd
Modify special test skin to visually cover regression
2021-10-03 15:53:46 +02:00
Dean Herbert
32afd3f426
Replace all basic usages
2021-10-02 02:22:23 +09:00
Dean Herbert
a92d499d7a
Convert usages of BeatmapDifficulty
to IBeatmapDifficultyInfo
2021-10-01 16:55:50 +09:00
Dean Herbert
46bafb6252
Merge branch 'master' into no-more-difficulty-control-points-info
2021-09-28 13:53:56 +09:00
Dean Herbert
60c9e9f704
Merge pull request #14805 from bdach/rectangular-snap-grid
...
Add rectangular snap grid to osu! editor composer
2021-09-22 00:12:03 +09:00
Dean Herbert
4cdce69f7e
Update test to match test beamap data
2021-09-21 23:45:03 +09:00
smoogipoo
69e28dc8a1
Add failing test
2021-09-21 14:44:22 +09:00
Bartłomiej Dach
d15bd5a15e
Store grid size back to beatmap on change
2021-09-20 20:39:39 +02:00
Bartłomiej Dach
0d7dac03f4
Start with largest grid size
2021-09-20 20:34:22 +02:00
Bartłomiej Dach
fe21577f11
Adjust grid snap in line with new logic
2021-09-20 20:32:34 +02:00
Bartłomiej Dach
4e094b2127
Implement grid size toggling matching stable
2021-09-19 20:26:02 +02:00
Bartłomiej Dach
c403e628dd
Add test coverage for distance/rectangular grid exclusivity
2021-09-19 18:08:34 +02:00
Opelkuh
1d7d779f66
Merge branch 'master' into add-legacy-star-particles
2021-09-19 04:34:35 +02:00
Dean Herbert
fde7c88999
Merge branch 'master' into update-framework
2021-09-16 22:49:02 +09:00
Dean Herbert
bb132f9509
Update a few more missed event changes in tests
2021-09-16 22:41:35 +09:00
smoogipoo
d8f27633a4
Fix legacy approach circles accepting alpha
2021-09-16 19:35:15 +09:00
smoogipoo
81ced68f89
Merge branch 'master' into display-sr-changes
2021-09-14 13:32:58 +09:00
Opelkuh
16f98357e6
Add cursor particles tests
2021-09-13 21:44:25 +02:00
Dean Herbert
1952ebece9
Update tests to use more correct control point definitions
2021-09-06 22:04:51 +09:00
Dean Herbert
b2a14b13dc
Update outdated tests
2021-09-03 17:11:12 +09:00
Dean Herbert
d4e5a612ea
Update IPositionalSnapProvider
to take a HitObject
as reference, rather than raw time
...
This allows fetching the correct `DifficultyControlPoint` from the
hitobject. Nothing more.
2021-09-03 17:11:12 +09:00
Dean Herbert
a3d9ab1e2e
Move approach rate to EffectControlPoint
2021-09-03 16:58:16 +09:00
dependabot[bot]
5a1eccd8e3
Bump Microsoft.NET.Test.Sdk from 16.10.0 to 16.11.0
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.10.0 to 16.11.0.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.10.0...v16.11.0 )
---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-09-01 18:17:37 +00:00
Dean Herbert
e15198f077
Update missed tests
2021-08-26 13:47:10 +09:00
Dean Herbert
6dcd9427ac
Remove bindable usage in PathControlPoint
...
This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.
I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.
2021-08-26 12:33:53 +09:00
smoogipoo
0d2ab550dd
Update SR values in tests
2021-08-11 13:04:32 +09:00
smoogipoo
2196ae9ca2
Merge branch 'master' into display-sr-changes
2021-08-11 13:02:34 +09:00
Salman Ahmed
0d22b9223b
Add unit test for inverse muting transferal
2021-08-03 12:50:54 +03:00
Salman Ahmed
ea02571da9
Inline parameterised test case
2021-08-03 12:49:39 +03:00
Salman Ahmed
026c632539
Add test coverage
2021-08-01 20:19:44 +03:00
Bartłomiej Dach
c371e67d70
Update diffcalc test to match ground-truth formula
2021-08-01 15:32:10 +02:00
Dean Herbert
50a2abbe7f
Merge pull request #12683 from frenzibyte/legacy-beatmap-combo-offset
...
Apply combo offsets "colour hax" only on beatmap skins
2021-07-23 14:30:18 +09:00
Salman Ahmed
20adfabc97
Remove unnecessary parentheses
...
I... forgot to amend that.
2021-07-22 16:42:07 +03:00
Salman Ahmed
cd7b90363a
Check nested hitobjects while asserting accent colour
2021-07-22 16:40:28 +03:00
emu1337
84fd59777c
Merge branch 'master' into diffspike-balance
2021-07-20 19:39:41 +02:00
Salman Ahmed
300b3f22b1
Remove no longer correct usage of "legacy" in offsets
2021-07-20 14:35:21 +03:00
Salman Ahmed
9d92b795fa
Revert making ComboOffset
s legacy and define BeatmapSkinComboIndex
instead
2021-07-20 14:15:43 +03:00
Salman Ahmed
a1001542f3
Update outdated test cases
2021-07-20 10:28:30 +03:00
Salman Ahmed
554652b033
Merge branch 'refactor-combo-colour-retrieval' into legacy-beatmap-combo-offset
2021-07-20 10:11:52 +03:00
Naxess
53c0298b5e
Add too short spinners check and tests
2021-07-13 10:51:40 +02:00
Naxess
fec9448301
Add too short sliders check and tests
2021-07-13 10:50:41 +02:00
PercyDan54
e1c646b9b2
Remove redundant arguments
2021-07-05 23:52:39 +08:00
dependabot[bot]
0d3de488de
Bump NUnit3TestAdapter from 3.17.0 to 4.0.0
...
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter ) from 3.17.0 to 4.0.0.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases )
- [Commits](https://github.com/nunit/nunit3-vs-adapter/compare/V3.17...V4.0.0 )
---
updated-dependencies:
- dependency-name: NUnit3TestAdapter
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-07-01 17:02:17 +00:00
smoogipoo
2c1f788f2d
Merge methods
2021-06-30 19:52:25 +09:00
smoogipoo
b94d88be50
Make method static to better define its usage
2021-06-30 19:49:51 +09:00
smoogipoo
e23614556e
Fix slider testscene failures
2021-06-30 19:43:34 +09:00
smoogipoo
e9158ccc41
Fix gameplay tests incorrectly seeking via MusicController
2021-06-29 23:23:21 +09:00
Dean Herbert
4cb9c6a842
Merge pull request #13423 from frenzibyte/transformers-per-skin
...
Refactor ruleset skin transforming logic to be per-`ISkin` rather than one `ISkinSource`
2021-06-22 21:24:56 +09:00
Salman Ahmed
ece63b9ba1
Remove unused using directive
2021-06-22 12:03:55 +03:00
Salman Ahmed
31cbb36a64
Implement FindProvider
and AllSources
properly on all test ISkinSource
s
2021-06-22 12:03:14 +03:00
Salman Ahmed
b12adc6073
Remove all test skinning changes in favour of the ISkinSource.AllSources
path
2021-06-22 10:48:03 +03:00
Dean Herbert
6c3d2315d0
Merge pull request #13606 from Naxesss/low-diff-checks
...
Add low difficulty spacing checks
2021-06-22 16:29:37 +09:00
Dean Herbert
0ad189e357
Expose skin sources via ISkinSource
and revert to consuming based on hierarchy
2021-06-22 16:19:55 +09:00
Dean Herbert
1b0aadcc6f
Merge branch 'master' into transformers-per-skin
2021-06-22 16:03:15 +09:00
Naxess
629c98e6a0
Add time distance equality tests
2021-06-21 15:34:11 +02:00
Naxess
e11139eadf
Add low difficulty overlap tests
...
Moq is introduced to mock sliders' end time/position. This is already used similarly in `osu.Game.Tests`.
2021-06-21 15:33:50 +02:00