h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-09-30 11:57:24 +08:00
Code Issues Releases Wiki Activity
56,969 Commits 3 Branches 647 Tags 364 MiB
333165e052
Commit Graph

36152 Commits

Author SHA1 Message Date
Dean Herbert
8d9a85e9e5
Fix typos in xmldoc 
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2022-10-26 13:14:12 +09:00
Dean Herbert
2016d33055 Offset start of distance snap grid drawing if reference object's start time doesn't align 
Closes #20938.
 2022-10-26 13:11:26 +09:00
Dean Herbert
7249542167
Merge pull request #20912 from LittleEndu/carousel-do-not-select-random 
Make beatmap carousel select nearest to selection when selection was filtered
 2022-10-26 11:40:56 +09:00
Dean Herbert
d9d083752a Clamp backwards index to total current items to fix edge case of item removal 2022-10-26 11:03:11 +09:00
Joseph Madamba
8505848b1a Scroll beatmap listing to top when searching via tags/source 2022-10-25 18:06:49 -07:00
Bartłomiej Dach
48057412f5
Merge branch 'master' into grid-momentary-shortcuts 2022-10-25 22:17:08 +02:00
Bartłomiej Dach
f5ca447b8e
Rename one more "{duplicate -> clone}" reference 2022-10-25 21:34:41 +02:00
Bartłomiej Dach
bcdf24b972
Merge branch 'master' into add-editor-object-clone 2022-10-25 21:33:52 +02:00
Bartłomiej Dach
3d31c9bbc5
Merge branch 'master' into beat-snap-divisor-hotkey 2022-10-25 20:32:32 +02:00
Dean Herbert
cf3bf41b49 Harden and simplify logic to avoid weird issues 2022-10-25 18:57:15 +09:00
Dean Herbert
da93849b80 Rename some pieces and better document SampleBankInfo 2022-10-25 14:55:33 +09:00
Dean Herbert
2b850694fa Merge branch 'allow-distance-grid-snap' into grid-momentary-shortcuts 2022-10-25 14:10:45 +09:00
Dan Balasescu
6177df2a24
Merge branch 'master' into fix-17143 2022-10-25 13:44:58 +09:00
Dean Herbert
22ea9a8ab4 Add early return of carousel group has no items 2022-10-25 13:34:22 +09:00
cdwcgt
f9c6190426
Add DimAmount for UserDimContainer 2022-10-25 13:00:53 +09:00
Dean Herbert
2456a18bc1 Rewrite implementation to avoid duplicated LINQ returns 2022-10-25 12:48:17 +09:00
Dean Herbert
4d4f6e25ba Rename to "clone" instead of "duplicate" 2022-10-25 11:43:23 +09:00
Dean Herbert
1e579e06f8 Fix duplicate working incorrectly if there is no selection currently made 2022-10-25 11:42:12 +09:00
Dean Herbert
da74690ec9 Add test coverage of clone operations 2022-10-25 11:38:58 +09:00
Endrik Tombak
5a118cfdc3 Merge branch 'master' of https://github.com/ppy/osu into carousel-perform-selection 
 Conflicts:
	osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs
 2022-10-24 21:40:48 +03:00
cdwcgt
a2682b3ce3
background dim settings for editor 
View -> Background Dim

follow `DimLevel` and `BlurLevel`

Co-Authored-By: Dead_Bush_Sanpai <DeadBushSanpai@yandex.com>
 2022-10-24 23:55:33 +09:00
cdwcgt
de881cc5cb
useless #nullable disable 2022-10-24 23:17:28 +09:00
Dean Herbert
247cf589aa
Merge branch 'master' into directoryselector-hidden-toggle 2022-10-24 15:33:10 +09:00
Dean Herbert
995216cced
Merge pull request #20819 from Joppe27/taiko-kiai-flashing 
Implement taiko hitobject kiai flashing
 2022-10-24 15:31:13 +09:00
Dean Herbert
1d5df15027 Add ability to use Shift+Number to set current beat divisor in editor 2022-10-24 15:20:15 +09:00
Dean Herbert
d0e6bda9ef Stop HitObjectComposer from handling Shift+Number keys 2022-10-24 15:19:36 +09:00
Dean Herbert
e72a71a28e Add simple editor "duplicate objects" key binding 2022-10-24 14:01:34 +09:00
Dean Herbert
e9b3048a8b Change the order of global bindings to give overlays lowest priority 2022-10-24 13:58:00 +09:00
Bartłomiej Dach
a55f91f54b
Merge branch 'master' into read-current-distance-snap 2022-10-24 00:15:15 +02:00
Bartłomiej Dach
3a6a87db0f
Merge branch 'master' into fix-editor-distanct-snap-sv-accounting 2022-10-23 18:42:08 +02:00
Susko3
a35026d537 Downgrade AutoMapper to fix Android startup crash 2022-10-22 23:29:44 +02:00
Dean Herbert
9155fcf3cb Update framework 2022-10-22 23:25:08 +09:00
Dean Herbert
3d37a67590 Update framework 2022-10-22 14:15:17 +09:00
Salman Ahmed
b0a4cd4f30 Inline content creation in base add method 2022-10-22 03:43:14 +03:00
Salman Ahmed
6c82bc36ed Encapsulate report logic inside button implementation 
Avoids complicating the `DrawableComment` class, and allows for isolated
testability.
 2022-10-22 02:48:27 +03:00
Salman Ahmed
9b5e35d599 Remove dependency on DrawableComment from report popover and simplify logic 
Allows for testing the button and popover in isolation.
 2022-10-22 02:47:33 +03:00
Salman Ahmed
081cf1cc47 Adjust comment report popover design 2022-10-22 02:45:31 +03:00
Salman Ahmed
0491b1fd18
Merge branch 'master' into update-framework 2022-10-21 22:39:56 +03:00
Dean Herbert
c1ed775deb Update framework 2022-10-21 23:36:16 +09:00
Dean Herbert
f516e32949 Improve UI a bit 2022-10-21 23:35:53 +09:00
Dean Herbert
bb921ff9a7 Fix incorrect current DS value when inside a slider 2022-10-21 23:35:47 +09:00
ansel
15aeb4a137 Display text in buttons flow instead of toast 2022-10-21 17:25:41 +03:00
Dean Herbert
f6de366766 Combine display and button into one control 2022-10-21 23:21:07 +09:00
Dean Herbert
645a84b1d6 Display current distance snap and add button to update to use it 2022-10-21 22:58:36 +09:00
Dean Herbert
7dc03097ff Change distance snap to never account for slider velocity 
This is a nuanced detail that was implemented incorrectly from the
outset. When mapping, generally a mapper chooses the distance spacing
with no regard to the SV. It has always been common to have a lower
or higher distance spacing than SV, but with the way the lazer editor
has worked, the SV was multiplied into the distance snap grid display,
incorectly changing its spacing depending on the "reference object"
(which is usually the previous hitobject chronologically).
 2022-10-21 21:51:24 +09:00
Dean Herbert
447d420c99 Fix adjusting volume via settings playing tick samples twice 2022-10-21 21:03:39 +09:00
Dean Herbert
4803f606c2
Merge pull request #20845 from nekodex/settings-sidebar-sfx 
Add unique hover/select samples to settings sidebar buttons
 2022-10-21 20:56:58 +09:00
Dean Herbert
8b74b5807f Update resources 2022-10-21 20:53:37 +09:00
Dean Herbert
af84f708b7 Avoid serialising some more properties of SoloScoreInfo unless present 2022-10-21 19:30:35 +09:00
Jamie Taylor
7b1edff2b3
Add unique hover/select samples to settings sidebar buttons 2022-10-21 18:06:38 +09:00
Dean Herbert
6cdfddea62 Always enable distance spacing when adusting distance space multiplier 2022-10-21 16:10:55 +09:00
Dan Balasescu
703a8afb11
Merge pull request #20809 from peppy/fix-taiko-broken-drum-roll-ticks 
Fix taiko drum roll ticks sometimes overflowing outside the drum roll itself
 2022-10-21 12:56:14 +09:00
Dean Herbert
7dbd6e2469
Merge branch 'master' into taiko-kiai-flashing 2022-10-21 12:48:35 +09:00
Salman Ahmed
27ce3d8342 Fix input settings not displaying in visual test browser 2022-10-21 01:52:19 +03:00
Joseph Madamba
bf4a91f1f0 Fix skin toolbox component button not playing hover/click sounds 2022-10-20 13:16:03 -07:00
ansel
81bdf716ef Change test 2022-10-20 19:56:00 +03:00
ansel
0ef903230c Make report button a separate component 2022-10-20 18:47:42 +03:00
ansel
da4f04ace7 Make dropdown not resize 2022-10-20 18:22:55 +03:00
ansel
635900085c Disable button when there is no text 2022-10-20 18:12:20 +03:00
ansel
ed39481932 Use another string for title 2022-10-20 18:11:35 +03:00
Dean Herbert
5c13c443ff Fix incorrect fallback logic 
Regressed when attempting to share implementation of binary search.
 2022-10-20 23:08:44 +09:00
Dean Herbert
26860a903e Refactor implementation to support hitobjects nested multiple levels deep 2022-10-20 22:30:30 +09:00
Dean Herbert
a754dc6d3b
Expose binary search methods publicly 
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
 2022-10-20 14:34:07 +09:00
Dan Balasescu
fd7274095f
Merge pull request #20826 from peppy/fix-missing-beatmap-backgrounds 
Fix some older beatmaps having missing backgrounds
 2022-10-20 12:46:24 +09:00
Dean Herbert
cc311eef2a
Merge pull request #20834 from frenzibyte/fix-slider-ball-tint 
Enable slider ball tint on "classic" skin
 2022-10-20 12:34:45 +09:00
Dean Herbert
6b26547d03
Merge pull request #20835 from frenzibyte/improve-hide-mouse-on-keyboard 
Improve automatic cursor hiding logic and limit to gameplay screen
 2022-10-20 11:44:20 +09:00
Dean Herbert
2f8a4fd2d0
Merge branch 'master' into remove-current-item 2022-10-20 10:02:09 +09:00
Dean Herbert
77b25c4a5c
Merge pull request #20788 from frenzibyte/handle-submitting-player-request-timeout 
Fix potential exception in `SubmittingPlayer` token retrieval on request timeout
 2022-10-20 09:51:57 +09:00
Salman Ahmed
39650717ea Improve input detection to not make cursor flicker on combined input 2022-10-20 03:45:25 +03:00
Salman Ahmed
4bf4938b72 Keep cursor hiding feature to gameplay screens for now 2022-10-20 03:44:58 +03:00
Salman Ahmed
eb386d4bd5 Enable slider ball tint in default legacy skin 2022-10-20 03:29:25 +03:00
Dean Herbert
a7d4a74ed6
Update osu.Game/Tests/Visual/ScrollingTestContainer.cs 
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2022-10-20 08:07:56 +09:00
Dean Herbert
78943a21d8
Update osu.Game/Beatmaps/ControlPoints/IControlPoint.cs 
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2022-10-20 08:06:05 +09:00
ansel
57320074a0 Fix accidental breakage of changelog layout 2022-10-20 01:24:36 +03:00
Dean Herbert
59e2478b0e Fix some older beatmaps having missing backgrounds 
Closes https://github.com/ppy/osu/issues/20824.

Note that this will require a reimport of beatmaps as it is baked into the database. Probably not worth making a migration for at this point in time.
 2022-10-19 16:01:10 +09:00
Joppe27
9b123e7365 Adjust flash intensity and fade values to feel better 2022-10-19 00:51:44 +02:00
Joppe27
a76a039722 Rename KiaiFlashingDrawable and move to osu.Game 2022-10-18 23:40:43 +02:00
Dean Herbert
d237c818f6 Fix nested objects in overlapping scrolling hit object container ruleset not using correct reference time 2022-10-18 16:15:21 +09:00
Dean Herbert
ec3761ced9 Standardise control point search logic in OverlappingScrollAlgorithm 
Was using a very local algorithm which I cannot guarantee is correct.
I'd rather it just use the one used everywhere else.
 2022-10-18 16:01:05 +09:00
Dean Herbert
fbad33bef7 Adjust durations and make start off screen 2022-10-18 15:01:53 +09:00
Dean Herbert
6b42f1931a Remove autosize easing in SettingsToolboxGroup 
It just feels like unnecessary motion.
 2022-10-18 15:01:26 +09:00
Dean Herbert
84688b53a1 Merge branch 'fix-editor-padding' into player-loader-improvements 2022-10-18 14:52:59 +09:00
Dean Herbert
860214c22a Adjust paddings to feel better now that backgrounds are visible of toolboxes 2022-10-18 14:38:45 +09:00
Dean Herbert
6a7f6c76ff Fix osu! editor padding being applied to toolboxes 
The result of https://github.com/ppy/osu/pull/20739 and https://github.com/ppy/osu/pull/20738 having unintended side effects when applied together.
 2022-10-18 14:32:00 +09:00
Dean Herbert
0f809dcaa7 Merge branch 'master' into player-loader-improvements 2022-10-18 14:22:55 +09:00
Dean Herbert
72be4940fd
Merge branch 'master' into comment-report 2022-10-18 13:52:33 +09:00
Dean Herbert
ccbac08985
Merge pull request #20593 from ekrctb/catch-editor-height 
Allow arbitrary height catch editor
 2022-10-18 12:10:49 +09:00
ansel
3258a41ca3 Merge branch 'comment-report' of https://github.com/Feodor0090/osu into comment-report 2022-10-17 20:41:46 +03:00
ansel
cd77ae062e Localize the button 2022-10-17 20:41:23 +03:00
ansel
797acf334f Show username in popup 2022-10-17 20:41:13 +03:00
Feodor0090
6efe7b5334
Merge branch 'master' into comment-report 2022-10-17 16:08:13 +03:00
ansel
ceb4d624b5 Delete wip form 2022-10-17 13:43:35 +03:00
ansel
ffa22d8a68 Update popover not to use labelled drawables 2022-10-17 13:42:17 +03:00
ansel
d7e5bcbd3c Add popover containers to overlays 2022-10-17 13:41:46 +03:00
Dean Herbert
516320edd9
Merge branch 'master' into handle-submitting-player-request-timeout 2022-10-17 18:51:13 +09:00
Dan Balasescu
4220d6b3fc
Merge pull request #20780 from outfoxxed/fix-hiterror-icons 
Fix hit error bar icon orientation
 2022-10-17 18:48:31 +09:00
ansel
7ed26369a3 Make a new report form, closer to web 2022-10-17 12:41:57 +03:00
Dean Herbert
1e7b8cd227 Fix formatting issues 2022-10-17 13:22:06 +09:00
Salman Ahmed
ae05f374a2 Fix potential invalid operation exception in SubmittingPlayer token retrieval 2022-10-17 03:26:29 +03:00
outfoxxed
85de802793
Only create hit error bar icon containers once 
Move icon container creation to BDL, and only recreate the contained
icon when `recreateLabels` is called
 2022-10-16 11:47:21 -07:00
Bartłomiej Dach
d0a495717e
Merge branch 'master' into comment-copy-link 2022-10-16 19:56:06 +02:00
ansel
4a8d976cb4 Use api's endpoint 2022-10-16 20:20:34 +03:00
ansel
e1785f73a2 Make report's comment not optional 2022-10-16 20:14:05 +03:00
outfoxxed
d6030891a2
Reuse existing code in hit error bar fix 
Use `UprightAspectMaintainingContainer` instead of a local fix for
hit error bar orientation
 2022-10-16 10:06:38 -07:00
ansel
ba595ab8fa Display toast instead of notification 2022-10-16 19:57:21 +03:00
ansel
9822a092c4 Add localization for enum 2022-10-16 19:50:55 +03:00
outfoxxed
cd1885a17b
Fix hit error bar icon orientation 
Icons now keep their original orientation when the hit error bar is
flipped
 2022-10-16 02:55:10 -07:00
Salman Ahmed
1824b1deee
Merge branch 'master' into tablet-button-binding 2022-10-16 04:10:04 +03:00
Aki
91358f4a6a
Implement tablet button bindings 2022-10-15 15:16:14 +08:00
Salman Ahmed
324c749383
Merge branch 'master' into player-loader-improvements 2022-10-15 03:07:15 +03:00
Salman Ahmed
241ecb63a1 Hide manual input manager cursor in OsuGameTestScenes 
Allows checking that the cursor is actually hidden in
`TestSceneOsuGame.TestCursorHidesWhenIdle`.
 2022-10-15 00:20:22 +03:00
Salman Ahmed
06e6713237 Move mouse input detection inside MenuCursorContainer to allow testing 2022-10-15 00:20:22 +03:00
Salman Ahmed
ba72f13f54 Merge branch 'master' into hide-mouse-on-keyboard-input 2022-10-14 22:26:30 +03:00
Feodor0090
fb046e31c1
Merge branch 'master' into comment-report 2022-10-14 16:57:23 +03:00
ansel
dc0aa2295a Add test 2022-10-14 16:51:48 +03:00
ansel
3e9fd4c08c Implement reporting flow 2022-10-14 16:26:25 +03:00
ansel
7251d41deb Add request class 2022-10-14 16:15:28 +03:00
ansel
c65a8a83f3 Add basic UI for reporting 2022-10-14 15:52:09 +03:00
Dan Balasescu
10aabfc650
Merge pull request #20739 from peppy/settings-toolbox 
Adjust visuals of settings toolboxes (gameplay loading screen and editor)
 2022-10-14 20:31:05 +09:00
Dan Balasescu
dcb6357964 Add ability to remove the current item in multiplayer 2022-10-14 20:23:55 +09:00
Dean Herbert
32c3e35762 Change background colour to a lighter tint to avoid clash with slider bars 2022-10-14 19:38:27 +09:00
Dean Herbert
2404bb42b9 Use 10% alpha rather than 0% when toolbox is not hovered 2022-10-14 19:33:49 +09:00
Dan Balasescu
525f98c158 Fix max combo missing from playlists results screen 2022-10-14 18:01:54 +09:00
Dan Balasescu
8a88339e78 Allow combo colour normalisation to be disabled 2022-10-14 14:37:24 +09:00
Dan Balasescu
15db65c037 Extract to struct, add dictionary term 2022-10-14 14:12:53 +09:00
Dan Balasescu
b43bae122c Fix incorrect porting of code 2022-10-14 13:46:25 +09:00
Salman Ahmed
01c65d3cc1 Remove seemingly unnecessary/leftover code 2022-10-14 02:16:36 +03:00
Salman Ahmed
739b21ab3b Maintain mod selection on ruleset change for common mods 2022-10-14 02:15:58 +03:00
ansel
8a47628fe1 Use spacer drawable instead of spacing on links container 2022-10-14 00:04:13 +03:00
ansel
295e6f5a68 Move toast to it's namespace 2022-10-13 23:57:25 +03:00
ansel
34ff072a9b Change text 2022-10-13 22:47:48 +03:00
ansel
a0cca391f6 Add copy link button to comments 2022-10-13 22:18:26 +03:00
ansel
e97dbf3dbc Move copy toast to its own file 2022-10-13 22:12:32 +03:00
Salman Ahmed
ef72b66dad Remove beatmap card background workaround to fix broken corners 2022-10-13 16:09:54 +03:00
Salman Ahmed
6c316bcc9e Make beatmap card icon buttons fill up to the area 2022-10-13 16:09:54 +03:00
Salman Ahmed
aa8040d696 Add hover box to beatmap card icon button 2022-10-13 16:09:54 +03:00
Dean Herbert
3645269108 Improve logo transition and reduce delay of exiting player loader in optimal conditions 2022-10-13 17:29:47 +09:00
Dean Herbert
b33935e392 Fix player loading screen settings scaling in 
This always looked weird, and from the looks of the structure was
probably unintentional from the start (it is in the logo tracking
container for whatever reason).
 2022-10-13 17:12:36 +09:00
Dean Herbert
a93c350ca8 Start settings panels without background visible 2022-10-13 17:11:56 +09:00
Dean Herbert
6608ada925 Fix test failures due to missing colour provider dependency 2022-10-13 17:05:11 +09:00
Dean Herbert
15f9697c9f Roughly update design of editor buttons 2022-10-13 16:57:25 +09:00
Dean Herbert
4d99c7002b Add background behind editor toolbox groups 2022-10-13 16:36:19 +09:00
Dean Herbert
0f4a2a6059 Improve feel of settings toolbox group 2022-10-13 16:36:19 +09:00
Dean Herbert
c3902728f6 Reorganise beatmap snap control to work better in compact mode 2022-10-13 15:47:54 +09:00
Dean Herbert
a525b3f9f8 Reorder and rename toggle checkboxes to fit better 2022-10-13 15:44:33 +09:00
Dean Herbert
f6f5d33f53 Add slight padding to playfield (roughly matches stable) 2022-10-13 15:44:23 +09:00
Dan Balasescu
338115ff6a Move check to LegacyDifficultyControlPoint 2022-10-13 15:05:15 +09:00
Dan Balasescu
4149235e63 Limit minimum brightness of combo colours 2022-10-13 14:05:33 +09:00
Dean Herbert
ebc1088457
Merge pull request #20729 from frenzibyte/update-local-confirmation-dialog 
Request user confirmation on updating locally-modified beatmaps
 2022-10-13 12:36:37 +09:00
Dean Herbert
c9b4cacc20
Merge pull request #20724 from mk56-spn/Highest_Combo_Counter 
Add "longest combo" counter to HUD components.
 2022-10-13 12:26:49 +09:00
Dean Herbert
f573ee4521
Merge pull request #20512 from Feodor0090/comment-deletion 
Add ability to delete own comments
 2022-10-13 12:13:08 +09:00
Dean Herbert
e240f659c2 Refactor visibility states to read better 2022-10-13 11:22:40 +09:00
Dan Balasescu
565e5586fd
Merge pull request #20725 from peppy/fix-beatmap-skin-fallbakcs 
Fix legacy fallbacks not working correctly for beatmap skins
 2022-10-13 10:08:40 +09:00
Salman Ahmed
964ed01abb Add confirmation dialog for updating locally modified beatmaps 2022-10-13 02:40:15 +03:00
Salman Ahmed
4fb156ef4e Update xmlodc and add nullability attributes 2022-10-13 00:16:42 +03:00
Salman Ahmed
6199db11a2 Make OsuUserInputManager dependency nullable for tournament client 2022-10-12 17:55:32 +03:00
Salman Ahmed
7a6ecaff0d Remove default invisible cursor container from rulesets 2022-10-12 17:50:47 +03:00
Salman Ahmed
a44cfe2901 Hide menu cursor when user is idle 2022-10-12 17:50:31 +03:00
Salman Ahmed
8305d886e6 Refactor internal visibility logic to route back to PopIn/PopOut 2022-10-12 17:50:04 +03:00
Dean Herbert
19f3810020 Revert namespace change 
Let's not
 2022-10-12 18:50:47 +09:00
Dean Herbert
3da54814f8
Merge pull request #20641 from pfgithub/patch-fix-save-collections 
Preserve collections when saving a beatmap
 2022-10-12 18:36:45 +09:00
sw1tchbl4d3
df0501235d Introduce BpmMultiplierMania, remove after the fact clamps 2022-10-12 11:14:01 +02:00
Dean Herbert
8bf4ca4b53 Add legacy skin fallback when beatmap skin is providing resources 2022-10-12 17:47:20 +09:00
Dean Herbert
fd20515a6d Don't throw if LegacySkin doesn't have a transformer encapsulating it 
This allows for more flexibility in lookups.
 2022-10-12 17:29:17 +09:00
Dean Herbert
1c93551590 Remove completely incorrect check before applying ruleset transformer 2022-10-12 17:07:13 +09:00
Dan Balasescu
9473c350b5
Merge pull request #20266 from cdwcgt/catch-combo-hide 
Fade out CatchComboDisplay when hide HUD
 2022-10-12 16:59:07 +09:00
Dan Balasescu
3ac3c33cc3
Merge pull request #20712 from peppy/reduce-import-transaction-scope 
Reduce the scope of realm transactions during import operations
 2022-10-12 16:56:21 +09:00
Dario Headley
b72c8970eb Max Combo Counter added 2022-10-12 09:50:01 +02:00
Dan Balasescu
300888b423
Merge pull request #20720 from peppy/fix-welcome-intro-delay 
Fix incorrect delay for non-theme music on "welcome" intro
 2022-10-12 16:15:54 +09:00
Dean Herbert
e43c8e84b0 Use Show instead of Alpha=1 2022-10-12 15:48:42 +09:00
Dean Herbert
47fe4eb0bd Merge branch 'master' into comment-deletion 2022-10-12 15:48:26 +09:00
Dean Herbert
5ce890cdb5
Merge pull request #20568 from Susko3/update-displays-in-setting 
Sync displays dropdown in settings with OS displays
 2022-10-12 15:35:31 +09:00
Dean Herbert
d2d589a156 Expose HUD state via Player 2022-10-12 15:11:52 +09:00
Dean Herbert
1d6d047a69
Merge branch 'master' into master 2022-10-12 14:52:07 +09:00
Dean Herbert
d6998c810c Fix incorrect delay for non-theme music on "welcome" intro 2022-10-12 14:51:14 +09:00
Dean Herbert
db148d145b Fix incorrect offset logic for beatmaps without a preview point specified 2022-10-12 14:47:37 +09:00
Dean Herbert
721bfb5369 Rename parameter to read better 2022-10-12 14:46:35 +09:00
Dean Herbert
195ece02c6
Merge branch 'master' into update-displays-in-setting 2022-10-12 14:37:49 +09:00
Dean Herbert
ab24e87013
Merge branch 'master' into improve-drag-selection 2022-10-12 13:20:17 +09:00
Dean Herbert
b444f0fd0b
Merge pull request #20714 from frenzibyte/improve-flashlight-on-break 
Improve flashlight display on break periods
 2022-10-12 13:10:12 +09:00
Dean Herbert
a5948e7680
Merge pull request #20704 from ekrctb/scrolling-drag-box 
Anchor editor drag box on time (catch, mania)
 2022-10-12 11:48:05 +09:00
Salman Ahmed
84fdd2e107 Improve flashlight display on break periods 2022-10-11 17:16:57 +03:00
ekrctb
fcb9e2cc00 Refactor blueprint container drag code 2022-10-11 22:39:53 +09:00
Salman Ahmed
0a97ee71a9 Hide menu cursor when non-mouse input is applied 2022-10-11 16:23:51 +03:00
Salman Ahmed
60c92c8744 Enable NRT on MenuCursorContainer 2022-10-11 16:23:51 +03:00
Salman Ahmed
894127a948 Expose bindable for identifying last input source 2022-10-11 16:21:54 +03:00
Salman Ahmed
9b45a9cf76 Rename various cursor symbols 
- `IProvideCursor.MenuCursor` -> `IProvideCursor.Cursor`
 - `MenuCursor` -> `MenuCursorContainer
 2022-10-11 16:21:01 +03:00
Dean Herbert
390ff8b9da Reduce the scope of realm transactions during import operations 2022-10-11 21:58:28 +09:00
Dan Balasescu
cc0ca470f1
Merge pull request #20702 from peppy/update-prefer-no-video 
Fix beatmap update button not respecting user "prefer no video" setting
 2022-10-11 19:36:14 +09:00
Dan Balasescu
2ae41521eb
Merge pull request #20708 from peppy/mania-holding-sounds 
Implement hold "sliding" samples in osu!mania
 2022-10-11 17:31:44 +09:00
Dan Balasescu
88e82d3154
Merge pull request #20681 from peppy/fix-hidden-hud-interaction 
Fix HUD components being interactive even when the HUD is visually hidden
 2022-10-11 17:19:27 +09:00
NotGumballer91
d18466d740
Fix delay inconsistency in IntroCircles.cs 2022-10-11 16:16:57 +08:00
Dan Balasescu
6cdc9b2662
Merge pull request #20682 from peppy/fix-show-score-from-song-select 
Fix clicking a leaderboard score at song select transtiioning briefly to main menu
 2022-10-11 17:16:16 +09:00
NotGumballer91
5baad52a9e
Fix unintended delay on osu!theme 2022-10-11 16:15:56 +08:00
Dan Balasescu
045eb884b5
Merge pull request #20683 from peppy/storyboard-handle-backwards-events 
Add support for weird storyboards which have backwards events
 2022-10-11 17:12:22 +09:00
Dean Herbert
f41b79688f Avoid casting by accepting all Playfields but throwing on a bad choice 2022-10-11 16:54:41 +09:00
Dean Herbert
f060e6a780 Implement hold "sliding" samples in osu!mania 2022-10-11 16:31:37 +09:00
Dean Herbert
9bab02fab4 Remove unused using statement 2022-10-11 16:23:05 +09:00
Dean Herbert
eba3d37a11 Add xmldoc and simplify calling 2022-10-11 15:50:02 +09:00
Dean Herbert
6f6290a21a Use async flow for storing key binding changes to realm 2022-10-11 15:37:22 +09:00
Dean Herbert
a44ba579c5 Fix beatmap update button not respecting user "prefer no video" setting 
Closes #20701.
 2022-10-11 14:27:40 +09:00
ekrctb
6ab29a62d0 Anchor drag box on time (catch, mania) 
Not done for taiko because I cannot figure out how it should work with the overlapping scroll algorithm.
 2022-10-11 14:23:17 +09:00
ekrctb
1a24762f9b Improve drag box selection logic 
`AllowDeselectionDuringDrag` is remove.
Instead, selected hit objects are not automatically deselected
when clock is seeked to a later time (the hit object is dead).
Update drag box selection even if mouse is not moved
(in case clock is running or scroll wheel is used).
 2022-10-11 14:11:45 +09:00
Dan Balasescu
ccab04d141
Merge pull request #20645 from frenzibyte/flag-markdown 
Add support for inline country flags in wiki overlay
 2022-10-11 14:01:24 +09:00
Dean Herbert
cb21126623
Merge pull request #20586 from ekrctb/time-based-selection 
Use hit object time for timeline drag selection instead of relying on blueprint
 2022-10-11 13:20:15 +09:00
pfg
e619c9c1e6 fix style 2022-10-10 21:48:41 -04:00
pfg
de8d485305 Move 'transferCollections' to a shared location 2022-10-10 21:45:33 -04:00
NotGumballer91
a883f44ea2
Merge branch 'master' into master 2022-10-11 02:11:21 +08:00
NotGumballer91
ef840e98cf
Update IntroCircles.cs 2022-10-11 01:49:53 +08:00
NotGumballer91
8a4f2efa14
Update IntroScreen.cs 2022-10-11 01:49:49 +08:00
NotGumballer91
3cd6ce8e3f
Update WorkingBeatmap.cs 2022-10-11 01:48:55 +08:00
Dean Herbert
3d58df2b61 Merge branch 'master' into flag-markdown 2022-10-11 01:58:43 +09:00
Dean Herbert
d700040a0d Make country code parsing resilient to invalid cases 2022-10-11 01:39:53 +09:00
Dean Herbert
be5a413753 Update framework 2022-10-11 01:35:35 +09:00
Dean Herbert
5a43cb6bb2
Merge pull request #20606 from sw1tchbl4d3r/barline_generator_improvements 
Barline generator improvements
 2022-10-11 01:31:30 +09:00
sw1tchbl4d3
5a4196fd51 Make currentEffectPoint non-nullable 2022-10-10 15:34:29 +02:00
NotGumballer91
9a3689b6e9
Update IntroCircles.cs 2022-10-10 21:04:14 +08:00
NotGumballer91
749dc40062
Update WorkingBeatmap.cs 2022-10-10 21:03:11 +08:00
NotGumballer91
e3b405cc23
Update IWorkingBeatmap.cs 2022-10-10 21:02:23 +08:00
sw1tchbl4d3
d389808427 Make effect point search more efficient 2022-10-10 14:00:26 +02:00
Dean Herbert
28185178d6 Add support for weird storyboards which have backwards events 
Closes https://github.com/ppy/osu/issues/20632.
Not adding test coverage because this is just weird.
 2022-10-10 16:51:55 +09:00
sw1tchbl4d3
eae32ca483 Switch DefinitelyBigger to AlmostBigger to account for fp errors 2022-10-10 09:39:40 +02:00
sw1tchbl4d3
f8036658c7 Move clamps directly to the usages in the conversion algorithm 2022-10-10 09:36:18 +02:00
Dean Herbert
e57819d687
Merge pull request #20665 from frenzibyte/fix-smoke-blocked-on-relax 
Fix smoke being blocked with "Relax" mod enabled
 2022-10-10 16:36:03 +09:00
Dean Herbert
b783fdf667 Fix clicking a leaderboard score at song select transtiioning briefly to main menu 
- Regressed in #20567.
- Closes #20651.
 2022-10-10 16:20:18 +09:00
Dean Herbert
20adc522b9 Fix HUD components being interactive even when the HUD is visually hidden 2022-10-10 16:05:41 +09:00
Dean Herbert
26a473e85e Update resources (fixes osu!mania flashlight crash) 2022-10-10 14:24:36 +09:00
D.Headley
5d2e3dcf4a Remove leftover Enum 2022-10-09 22:52:54 +02:00
Salman Ahmed
2d4f390372 Remove non-smoke key bindings on "Relax" mod instead 2022-10-09 17:14:16 +03:00
sw1tchbl4d3
e0904e263f Fix legacy BpmMultiplier clamp value 2022-10-09 11:25:47 +02:00
Salman Ahmed
a9aba74351 Add markdown country flag support 2022-10-08 21:50:25 +03:00
Salman Ahmed
098a56a784 Add custom container extension support 2022-10-08 21:25:11 +03:00
pfg
edec613724 Remove unnecessary '?' 2022-10-08 13:58:42 -04:00
pfg
ff14453c2b Preserve collections when saving a beatmap 2022-10-08 12:42:29 -04:00
ansel
c384093802 Update main test and add failure scenario test 2022-10-08 18:53:41 +03:00
ansel
b697200460 Properly modify comment visual state on deletion 2022-10-08 18:41:08 +03:00
ansel
4e7c30504f Schedule action buttons visibility changes 2022-10-08 17:15:10 +03:00
ansel
abf56c27a1 Do not requere dialog overlay 2022-10-08 17:11:09 +03:00
sw1tchbl4d3
63ffaa6929 Respect OmitFirstBarLine effect 2022-10-07 20:38:32 +02:00
sw1tchbl4d3
903c8612c8 Move endTime to next timing point 2022-10-07 20:34:31 +02:00
Dean Herbert
072b64b8d4 Update all dependencies 2022-10-07 21:16:11 +09:00
Dan Balasescu
c18d4afdcc Merge branch 'master' into fix-leaderboard-first-place-fade 2022-10-07 19:55:16 +09:00
Dan Balasescu
0fb4ac4733
Merge pull request #20603 from peppy/bg-dim-reduce 
Adjust out-of-the-box background dim back down to 70%
 2022-10-07 19:40:13 +09:00
Dan Balasescu
57e4d6cc4a
Merge pull request #20562 from peppy/fix-score-submission-crash 
Fix potential crash when score submission token retrival fails
 2022-10-07 19:24:35 +09:00
Dean Herbert
a8742f0cc3 Adjust out-of-the-box background dim back down to 70% 
It was previously bumped from 60% to 80%, but I've recently
felt that this is too high as a default, and takes away from storyboards
and video backgrounds.
 2022-10-07 18:47:32 +09:00
Dean Herbert
a543222a2b Add ability to pad stage vertically 2022-10-07 15:45:35 +09:00
Dean Herbert
eea3d5adb8 Standardise column index naming and xmldoc 2022-10-07 15:24:36 +09:00
Dean Herbert
13e0a59f70 Add note about why LegacyManiaSkinConfigurationLookup exist 2022-10-07 15:24:36 +09:00
Dean Herbert
3947011baf Fix regression in legacy dual stage handling logic 2022-10-07 15:24:36 +09:00
Dan Balasescu
bce20e0a59 Merge branch 'master' into adjust-flashlight 2022-10-07 14:45:30 +09:00
Dan Balasescu
7385ef3e1b Extract combo scale to virtual function 2022-10-07 14:26:19 +09:00
Joseph Madamba
b27e70ca47 Fix language settings dropdown not updating when changing language in first run setup 2022-10-06 21:11:00 -07:00
ekrctb
6164e0896a Don't reselect already selected items in SelectAll 2022-10-07 10:46:07 +09:00
Dean Herbert
4980e53c9c
Merge pull request #20376 from goodtrailer/smoke 
Add cursor "smoke" trails
 2022-10-07 03:41:07 +09:00
ekrctb
9247ff3e0a Allow changing scrolling speed in catch editor 
Scroll speed is not saved and doesn't affect gameplay.
It is purely a feature for a better visualization.
It is currently bind to scroll speed increase/decrease.
Default F3/F4 crashes with editor shortcuts so it has to be changed.
 2022-10-06 18:06:16 +09:00
ekrctb
29cc554632 Ensure blueprint is added for selected hit object 2022-10-06 13:59:54 +09:00
ekrctb
0d448e6cc8 Fix items without blueprints are not deselected 2022-10-06 13:50:56 +09:00
Dean Herbert
e9ab465da6
Merge branch 'master' into localisation-settings 2022-10-06 13:22:08 +09:00
ekrctb
b0213c29e9 Use mid time instead of start time 
It is closer to the old blueprint-based behavior
 2022-10-05 22:19:22 +09:00
ekrctb
6753f6b01a Move AllowDeselectionDuringDrag down 
Because it is now ignored in the timeline implementation anyways
 2022-10-05 22:14:11 +09:00
ekrctb
3108c42ece Fix inspect issues 2022-10-05 22:04:43 +09:00
ekrctb
00b3d97f69 Improve timeline selection performance 
But selecting a large number of hit objects is still very slow
because all DHOs must be added
and also `AddBlueprintFor` has quadratic behaviors
 2022-10-05 21:58:05 +09:00
ekrctb
0613388aaa Make sure all selected items get deleted 2022-10-05 21:58:05 +09:00
ekrctb
0ffde02f79 Use hit object time for timeline selection 2022-10-05 21:51:01 +09:00
ekrctb
8d29e9e76b Move selection logic from DragBox to BlueprintContainer 2022-10-05 21:51:01 +09:00
Dan Balasescu
35d04fe33c
Merge pull request #20582 from peppy/fix-being-playing-unobserved 
Silence unobserved exceptions in `BeginPlayingInternal`
 2022-10-05 20:51:55 +09:00
Dan Balasescu
c52ddb0e50
Merge pull request #20570 from ekrctb/scrolling-lifetime 
Compute lifetime start from entry for scrolling hit objects
 2022-10-05 20:45:43 +09:00
Dean Herbert
365a78d358 Merge branch 'master' into smoke 2022-10-05 18:58:18 +09:00
Dean Herbert
64858cfb8e Update resources 2022-10-05 18:55:49 +09:00
Dean Herbert
4f084664ac Merge branch 'master' into comment-deletion 2022-10-05 14:34:50 +09:00
Dean Herbert
74db42394a Silence unobserved exceptions in BeginPlayingInternal 
Closes #20526.
 2022-10-05 14:31:13 +09:00
Dean Herbert
276021dd85 Remove now unnecessary ScheduleAfterChildren 2022-10-05 14:20:01 +09:00
Dean Herbert
e06ece7531 Update framework 2022-10-05 14:19:51 +09:00
Dean Herbert
c7d645b086 Merge branch 'master' into fix-gameplay-leaderboard-overlap 2022-10-05 14:15:50 +09:00
Dan Balasescu
d9c3f5834c
Merge pull request #20567 from peppy/fix-show-replay-crash 
Fix potential crash when attempting to display an imported score at song select
 2022-10-04 19:46:15 +09:00
Dean Herbert
75b9bf2cf9
Merge branch 'master' into intel-exclusive-warning 2022-10-04 19:02:01 +09:00
Dan Balasescu
7293ad751e Update packages 2022-10-04 18:59:35 +09:00
Dan Balasescu
41082ab928 Fix misplaced parenthesis 2022-10-04 18:21:29 +09:00
ekrctb
1cccd03480 Fix scrolling nested hit object lifetime not set 2022-10-04 15:17:14 +09:00
ekrctb
781f5420b0 Add test for scrolling hit object lifetime 2022-10-04 15:17:11 +09:00
ekrctb
5d80950eaf Compute lifetime from entry in scrolling container 2022-10-04 15:12:28 +09:00
Susko3
efc9bed4f0 Use IWindow.DisplaysChanged to update displays 2022-10-03 23:52:04 +02:00
Susko3
31fefc1ee2 Add nullable annotation to LayoutSettings 2022-10-03 23:23:02 +02:00
Susko3
e98b4b4fbd Make updateDisplayModeDropdowns regular method 2022-10-03 23:14:21 +02:00
Dean Herbert
0bac5ef465 Merge branch 'master' into smoke 2022-10-03 21:29:42 +09:00
Dean Herbert
dfb143ec0b Update resources 2022-10-03 21:14:57 +09:00
Dean Herbert
332d63b53b Always return to main menu before attempting to present a score from import 2022-10-03 20:29:44 +09:00
Dean Herbert
13ee5c179e Add missing parenthesis in log message 2022-10-03 18:42:40 +09:00
Dan Balasescu
deae7cff60 Adjust flashliht scaling to match classic 2022-10-03 18:38:29 +09:00
Dan Balasescu
0df217d85c Add ability to adjust flashlight smoothness 2022-10-03 18:24:56 +09:00
Dean Herbert
d9f678d942 Change song select random key binding to not handle key repeat 2022-10-03 18:16:54 +09:00
Dean Herbert
42aac16b37 Adjust leaderboard score panels sizing based on accuracy/combo width 2022-10-03 18:12:36 +09:00
Dean Herbert
65369e96eb Ensure token retrieval failure logic only runs once 2022-10-03 17:29:46 +09:00
Dean Herbert
c4dd23ed15 Log token retrieval failures even when gameplay is allowed to continue 2022-10-03 17:29:34 +09:00
Dean Herbert
4dbac917fc
Merge pull request #20547 from nanashi-1/solo-gameplay-leaderboard-max-combo 
Display highest combo rather than current combo for local play on leaderboard
 2022-10-03 16:57:05 +09:00
Salman Ahmed
a810afafb3 Reschedule results display delegate to avoid potential softlocks in the future 2022-10-02 15:37:56 +03:00
Salman Ahmed
59728b0ccb Fix results display delegate potentially cancelled while not exiting 2022-10-02 15:30:06 +03:00
nanashi-1
2493468800 display highest combo instead of current combo 2022-10-02 18:40:31 +08:00
ansel
85adfc2df7 Fix DI type 2022-09-28 18:26:36 +03:00
ansel
7645fe20f5 Merge branch 'master' into comment-deletion 2022-09-28 17:55:22 +03:00