Dan Balasescu
8f8246278a
Merge pull request #31527 from bdach/spectator-list-ready
...
Show spectating users during gameplay
2025-01-21 18:54:11 +09:00
Dean Herbert
c68a0bc7e3
Merge branch 'master' into multiplayer-free-style
2025-01-21 17:49:21 +09:00
Dean Herbert
c8cc36e9af
Add failing test coverage of random rewind button not working
2025-01-21 17:24:41 +09:00
Salman Alshamrani
2b5ea4e6e0
Fix recent editor textbox regressions
2025-01-20 03:17:01 -05:00
Dean Herbert
b5b407fe7c
Knock some sense into daily challenge profile test scene
2025-01-20 15:40:38 +09:00
Marvin Schürz
45e0d9154e
Adjust tests to worked with snapped start time
2025-01-20 01:38:18 +01:00
Bartłomiej Dach
3c4bfc0a01
Merge spectator list classes into one skinnable
2025-01-17 11:23:14 +01:00
Bartłomiej Dach
b215073957
Add completion marker to daily challenge profile counter
2025-01-17 10:26:59 +01:00
Dean Herbert
6bbfd362b8
Merge branch 'master' into user-panel-status
2025-01-17 17:37:09 +09:00
Dean Herbert
a8456ce9ac
Merge pull request #31513 from smoogipoo/remove-status-from-apiuser
...
Remove `Status` and `Activity` bindables from `APIUser`
2025-01-17 17:36:47 +09:00
Dan Balasescu
88829d5321
Merge pull request #31535 from peppy/beatmap-carousel-v2-right-click-scroll
...
Refactor absolute scrolling at song select
2025-01-17 17:02:14 +09:00
Bartłomiej Dach
7d026761fc
Merge pull request #31533 from peppy/fix-gameplay-offset-adjust-limitations
...
Fix gameplay offset adjustment limits not being enforced
2025-01-17 08:21:24 +01:00
Dan Balasescu
79fff136a9
Merge branch 'master' into beatmap-carousel-v2-right-click-scroll
2025-01-17 16:12:52 +09:00
Dan Balasescu
fe5b807e7d
Merge branch 'remove-status-from-apiuser' into user-panel-status
2025-01-17 15:59:39 +09:00
Dan Balasescu
5425d62186
Merge branch 'master' into remove-status-from-apiuser
2025-01-17 15:42:40 +09:00
Dan Balasescu
ae7e4bef86
Fix tests
2025-01-17 15:42:19 +09:00
Dean Herbert
224f39825f
Fix test potentially false-negative due to realm write delays
2025-01-17 14:16:38 +09:00
Bartłomiej Dach
1949c01103
Fix skin deserialisation test
2025-01-16 15:34:49 +01:00
Bartłomiej Dach
0c54853710
Merge branch 'spectator-list-visuals' into spectator-list-ready
2025-01-16 15:13:04 +01:00
Bartłomiej Dach
e3b780d0fb
Merge branch 'master' into spectator-list-visuals
2025-01-16 14:07:53 +01:00
Dean Herbert
a6057a9f54
Move absolute scroll support local to carousel and allow custom bindings
2025-01-16 20:47:59 +09:00
Dan Balasescu
65b88ab365
Use MetadataClient for local user status
2025-01-16 20:34:45 +09:00
Dan Balasescu
be892e2baa
Merge branch 'remove-status-from-apiuser' into user-panel-status
2025-01-16 20:34:37 +09:00
Bartłomiej Dach
6b921fc4e4
Merge pull request #31471 from peppy/beatmap-carousel-v2
...
Add basic framework for carousel displays (aka `BeatmapCarouselV2`)
2025-01-16 12:21:53 +01:00
Dan Balasescu
8400726887
Move bindables to OsuConfigManager & SessionStatics
2025-01-16 19:33:42 +09:00
Dean Herbert
56dfe4a231
Adjust test to work better when running in sequence
2025-01-16 18:56:21 +09:00
Dean Herbert
a4174a3644
Add failing test coverage showing offset adjust is not limited correctly
2025-01-16 18:05:58 +09:00
Dan Balasescu
aa3ae8324e
Add test for local user presence
2025-01-16 17:29:43 +09:00
Dan Balasescu
fd75ae2614
Merge branch 'remove-status-from-apiuser' into user-panel-status
2025-01-16 17:16:43 +09:00
Dan Balasescu
b54d959263
Expose as IBindable from IAPIProvider, writes via config
2025-01-16 17:05:18 +09:00
Bartłomiej Dach
43fc48a3f3
Add client methods allowing users to be notified of who is watching them
2025-01-15 14:18:01 +01:00
Bartłomiej Dach
582c5180b9
Implement spectator list display
...
- First step for https://github.com/ppy/osu/issues/22087
- Supersedes / closes https://github.com/ppy/osu/pull/22795
Roughly uses design shown in
https://github.com/ppy/osu/pull/22795#issuecomment-1579936284 with some
modifications to better fit everything else, and some customisation
options so it can fit better on other skins.
2025-01-15 14:17:53 +01:00
Dean Herbert
6027947657
Move animation handling to Carousel implementation to better handle add/removes
...
With the animation logic being external, it was going to make it very
hard to apply the scroll offset when a new panel is added or removed
before the current selection.
There's no real reason for the animations to be local to beatmap
carousel. If there's a usage in the future where the animation is to
change, we can add more customisation to `Carousel` itself.
2025-01-15 17:01:07 +09:00
Dan Balasescu
8985a38734
Display up-to-date online status in user panels
2025-01-15 16:55:25 +09:00
Bartłomiej Dach
614243fef4
Merge pull request #31506 from peppy/fix-storyboard-break-overhead
...
Fix stutter on intensive storyboards when entering break time with 100% background dim
2025-01-15 08:23:58 +01:00
Dan Balasescu
20108e3b74
Remove Status and Activity bindables from APIUser
...
As for the tests, I'm (ab)using the `IsOnline` state for the time being
to restore functionality.
2025-01-14 23:45:30 +09:00
Dean Herbert
7e8a80a0e5
Add difficulty, artist and title sort examples
...
Also:
- Adds hinting at grouping and header status of items
- Passes through criteria and prepare for grouping tests.
- Makes `Filters` list `protected` because naming clash with `Filter()`
on `BeatmapCarousel`.
2025-01-14 19:52:48 +09:00
Dean Herbert
d97a3270a5
Split out BeatmapCarousel classes and drop V2 suffix
2025-01-14 19:18:02 +09:00
Dean Herbert
8d41eda91a
Merge branch 'master' into beatmap-carousel-v2
2025-01-14 19:06:52 +09:00
Dean Herbert
b4d054fdc0
Merge pull request #31444 from smoogipoo/friend-presence-2
...
Add notifications for when friends go online or offline
2025-01-14 18:58:19 +09:00
Bartłomiej Dach
459577cc32
Merge pull request #31474 from peppy/scroll-container-double-precision
...
Update game `ScrollContainer` usage in line with framework changes
2025-01-14 10:56:55 +01:00
Bartłomiej Dach
058ff8af77
Make test class partial
2025-01-14 09:22:56 +01:00
Dean Herbert
7761a0c18a
Add failing test coverage showing storyboard not being updated when dimmed
2025-01-14 16:22:10 +09:00
Bartłomiej Dach
39a69d6454
Adjust test to pass
...
What I think was happening here is that the dump of the accuracy
counter's state was happening too early. The component is loaded
synchronously into the `ISerialisableDrawableContainer` before its
default position is set via the "apply defaults" `ArgonSkin` flow
- so the test needs to wait for that to take place first.
2025-01-13 13:14:34 +01:00
Bartłomiej Dach
8968ab19d9
Merge branch 'master' into fix-skin-editor-undo
2025-01-13 12:39:51 +01:00
Dean Herbert
ad04681b28
Add scroll position maintaining
2025-01-11 01:43:47 +09:00
Dean Herbert
5e9a7532d3
Add basic implementation of new beatmap carousel
2025-01-11 01:43:47 +09:00
Dean Herbert
94ea003d90
Update game ScrollContainer usage in line with framework changes
...
See https://github.com/ppy/osu-framework/pull/6467 .
2025-01-11 01:42:59 +09:00
Dean Herbert
73adc4dfd7
Merge pull request #31364 from bdach/editor-storyboard-display-2
...
Display storyboard in editor background
2025-01-10 15:09:44 +09:00
Dan Balasescu
7268b2e077
Add separate path for friend presence notifications
...
It proved to be too difficult to deal with the flow that clears user
states on stopping the watching of global presence updates. It's not
helped in the least that friends are updated via the API, so there's a
third flow to consider (and the timings therein - both server-spectator
and friends are updated concurrently).
Simplest is to separate the friends flow, though this does mean some
logic and state duplication.
2025-01-09 17:31:01 +09:00
Dean Herbert
0fe6b4be0d
Add reason for making test interactive-only
2025-01-09 13:33:55 +09:00
Dean Herbert
2a7a3d932e
Add test showing that rate adjustments cause discrepancies in replay frame precision
2025-01-09 13:30:04 +09:00
Bartłomiej Dach
bcd35c8899
Merge branch 'master' into editor-storyboard-display-2
2025-01-08 15:46:08 +01:00
Bartłomiej Dach
e7070bd812
Merge pull request #31448 from bdach/automatic-new-combo-after-break
...
Force new combo on objects succeeding a break
2025-01-08 11:22:30 +01:00
Bartłomiej Dach
fbfda2e044
Extend test coverage with combo index correctness checks
2025-01-08 10:28:04 +01:00
Dean Herbert
f216c22806
Merge pull request #31445 from bdach/reset-speed-on-test-play
...
Reset playback speed to 100% on entering test play
2025-01-08 16:16:28 +09:00
Bartłomiej Dach
d9f0f0d729
Merge branch 'master' into editor-storyboard-display-2
2025-01-08 08:12:55 +01:00
Dean Herbert
6f42b59e31
Upgrade more packages again
...
This also downgrades nunit to be aligned across all projects. Getting it
up-to-date is a bit high effort.
2025-01-08 03:13:11 +09:00
Bartłomiej Dach
d0a39a7733
Merge pull request #31442 from peppy/supporter-button-always-warns
...
Always show dialog when clicking supporter icon before opening browser
2025-01-07 15:14:53 +01:00
Bartłomiej Dach
5431a08b35
Merge pull request #31435 from peppy/star-range-display-quality
...
Fix star range display looking a bit bad when changing opacity
2025-01-07 14:58:00 +01:00
Bartłomiej Dach
973f606a9e
Add test coverage for expected behaviour
2025-01-07 13:59:26 +01:00
Bartłomiej Dach
3c03406b45
Add failing test
2025-01-07 11:23:47 +01:00
Dan Balasescu
51b62a6d8e
Display notification on friend presence changes
2025-01-07 19:12:33 +09:00
Dean Herbert
b8a10d9b0e
Mark recommendation test as flaky
...
Will revisit during song select refactoring no doubt.
2025-01-07 17:58:12 +09:00
Dean Herbert
a0496c60a4
Refactor StarRatingRangeDisplay test to be more usable
2025-01-07 16:42:06 +09:00
Bartłomiej Dach
01e9c0f15e
Merge pull request #31418 from peppy/intro-file-integrity
...
Ensure intro files exist in storage during startup
2025-01-07 08:14:40 +01:00
Dan Balasescu
77d9c955ea
Merge pull request #31306 from bdach/aspire-slider-breakage
...
Fix slider event generator incorrectly not generating repeats when tick distance is zero
2025-01-07 11:50:18 +09:00
Dean Herbert
ca9e16387a
Don't require track to be playing to fix test failures on some platforms
2025-01-06 18:27:00 +09:00
Dean Herbert
e15978cc65
Add test coverage of user deleting intro files
2025-01-04 15:26:42 +09:00
Dean Herbert
1161b7b3c0
Flip navigation test expectations in line with new behaviour
2025-01-04 00:55:12 +09:00
Dean Herbert
2d3595f768
Add test covering required behaviour
...
See https://github.com/ppy/osu/issues/30885 .
2025-01-02 16:20:09 +09:00
Dan Balasescu
9da27b5fe5
Merge pull request #31305 from bdach/round-coordinates-on-legacy-export
...
Round object coordinates to nearest integers on legacy export rather than truncating
2025-01-01 21:05:18 +09:00
Bartłomiej Dach
78c7ee1fff
Fix code quality
2024-12-31 15:18:38 +01:00
Bartłomiej Dach
cd07ddfe28
Update outdated assertions
2024-12-31 14:08:44 +01:00
Bartłomiej Dach
ecf64dfc57
Add failing test case
2024-12-27 12:38:31 +01:00
Bartłomiej Dach
0c02369bdc
Add failing test case
2024-12-27 11:01:47 +01:00
Bartłomiej Dach
ed397c8fee
Add failing assertions
2024-12-27 09:04:41 +01:00
Dan Balasescu
c3aa9d6f8a
Display user style in participant panel
2024-12-25 23:30:24 +09:00
Dan Balasescu
95fe8d67e4
Fix test
2024-12-25 16:51:50 +09:00
Dean Herbert
7b9f776a14
Merge pull request #31206 from peppy/christmas
...
Add christmas / seasonal mode
2024-12-23 16:49:38 +09:00
Dean Herbert
881623d47d
Merge branch 'master' into christmas
2024-12-20 23:11:20 -08:00
Dean Herbert
9b1d94b5be
Merge branch 'master' into skinnable-mod-display
2024-12-20 21:27:31 +09:00
Bartłomiej Dach
e62b329d4a
Merge pull request #31143 from peppy/no-pause-cooldown-break-intro
...
Skip the pause cooldown when in intro / break time
2024-12-20 12:29:46 +01:00
Dean Herbert
c16bfa010b
Merge branch 'master' into christmas
2024-12-20 20:07:48 +09:00
Bartłomiej Dach
3ec63d00cb
Silence test that apparently can't work on CI
2024-12-20 11:20:32 +01:00
Bartłomiej Dach
767be9d0d6
Merge pull request #31146 from peppy/global-volume-scroll-better-maybe
...
Move "global" scroll-adjusts-volume to a per-screen component-based implementation
2024-12-20 11:04:57 +01:00
Dean Herbert
5d17014698
Fix mouse wheel disable not working during gameplay
2024-12-20 16:31:06 +09:00
Dean Herbert
3fc9990411
Fix some failing tests
2024-12-20 15:35:31 +09:00
Dean Herbert
2a720ef200
Move christmas intro screen to seasonal namespace
2024-12-20 15:28:24 +09:00
Dean Herbert
e5dbf9ce45
Subclass osu logo instead of adding much code to it
2024-12-20 15:28:24 +09:00
Dean Herbert
8c7af79f96
Tidy up for pull request attempt
2024-12-20 14:46:21 +09:00
Dean Herbert
22f3831c0d
Add logo hat
2024-12-20 14:46:21 +09:00
Dean Herbert
0954e0b032
Add seasonal lighting
...
Replaces kiai fountains for now.
2024-12-20 14:46:20 +09:00
Dean Herbert
024029822a
Add christmas intro
2024-12-20 14:46:20 +09:00
Dean Herbert
55dff1f0ef
Merge branch 'master' into skinnable-mod-display
2024-12-20 14:08:51 +09:00
Dean Herbert
f9939e7f95
Remove invalid test
2024-12-20 00:50:53 +09:00
Bartłomiej Dach
68a5618e81
Add test coverage
2024-12-16 16:03:26 +09:00
Dean Herbert
bdd417c1a1
Move "global" scroll-adjusts-volume to a per-screen component-based implementation
2024-12-16 15:21:07 +09:00
Dean Herbert
64555debc2
Fix adjusting control point offset after undo/redo causing catastrophic failure
...
Closes https://github.com/ppy/osu/issues/31098 .
Low effort fix because it was already half broken. The test was testing
in isolation but in actual editor usage it wasn't working as expected.
2024-12-13 19:33:51 +09:00
Dan Balasescu
f84c67babd
Merge pull request #31101 from Joehuu/recommended-diff-beatmap-listing
...
Add recommended difficulty numerical value near filter in beatmap listing
2024-12-13 18:57:16 +09:00
Dan Balasescu
e2af8820de
Merge pull request #31107 from bdach/flaky-editor-test
...
Attempt to fix flaky editor beatmap creation test
2024-12-13 18:53:43 +09:00
Dan Balasescu
edbaaa9468
Fix test
2024-12-13 17:41:55 +09:00
Bartłomiej Dach
fdc41ace7e
Fix flaky editor beatmap creation test
...
As seen in
https://github.com/ppy/osu/actions/runs/12289146465/job/34294167417#step:5:1588
or
https://github.com/ppy/osu/actions/runs/12310133160/job/34358241666#step:5:53 .
Exception messages hint pretty strongly at this being a threading issue
and there does seem to be a rather frivolous lack of waiting for
`CreateNewDifficulty()` to do its thing, so I'm thinking maybe this will
help.
2024-12-13 17:35:41 +09:00
Dean Herbert
b470e30cc0
Add failing test showing player settings appearing in skin editor
2024-12-13 17:18:34 +09:00
Joseph Madamba
f7364de01a
Add test and null protections
2024-12-12 15:23:00 -08:00
Bartłomiej Dach
88241d5b95
Merge pull request #30838 from smoogipoo/better-room-status
...
Improve multiplayer room status handling
2024-12-12 13:05:59 +09:00
Dean Herbert
862b41c38e
Move BeatmapInfoWedgeV2 to correct namespace
2024-12-12 12:53:05 +09:00
Dean Herbert
a3998fbd52
Merge branch 'master' into better-room-status
2024-12-11 18:06:55 +09:00
Dean Herbert
a868c33380
Remove BeatmapCarousel testing backdoor
2024-12-11 16:28:51 +09:00
Dean Herbert
c94b393e30
Access beatmap store via abstract base class
...
The intention here is to make things more testable going forward.
Specifically, to remove the "back-door" entrance into `BeatmapCarousel`
where `BeatmapSets` can be set by tests and bypas/block realm retrieval.
2024-12-11 16:28:51 +09:00
Bartłomiej Dach
89e3c551ff
Merge pull request #30860 from frenzibyte/editor-multiple-background-audio-files
...
Allow choosing different background/audio files for individual difficulties
2024-12-11 14:12:58 +09:00
Dean Herbert
48bf2fa001
Merge pull request #30960 from bdach/bookmarks
...
Implement basic bookmark support in editor
2024-12-09 23:42:04 -08:00
Dean Herbert
7ec2d91e14
Merge branch 'master' into editor-multiple-background-audio-files
2024-12-10 14:19:55 +09:00
Dan Balasescu
1b8d9370aa
Merge pull request #30973 from frenzibyte/copy-effect-points
...
Preserve effect point specifications when creating blank difficulties
2024-12-09 16:13:52 +09:00
Dan Balasescu
a99a992ceb
Adjust test to load song select during setup
2024-12-09 13:48:05 +09:00
Bartłomiej Dach
459533aba6
Merge branch 'master' into bookmarks
2024-12-07 22:22:04 +09:00
Dean Herbert
2713ae601a
Remove unused using
2024-12-07 14:41:30 +09:00
Bartłomiej Dach
13759f5aa0
Back out test change
...
It was mostly a demonstrative thing to use in the heat in the moment for
the skinnable mod display and it breaks all other tests. So let's just
not.
2024-12-07 13:47:09 +09:00
Thomas Müller
db18492fbc
Update default osk for skinnable mod display
2024-12-07 13:12:09 +09:00
Thomas Müller
0a00f7a7c2
Implement skinnable mod display
...
Also makes the mod display initialization sequence (start expanded, then
unexpand) controlled by HUDOverlay rather than mod display itself. This
enabled different treatment depending on whether the mod display is
viewed in the skin editor or in the player.
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-12-07 12:06:33 +09:00
Dean Herbert
e22f3b7d05
Merge branch 'master' into named-pipe
2024-12-07 10:42:55 +09:00
Dean Herbert
5849a69a86
Merge pull request #30921 from huoyaoyuan/netcore-analyzer
...
Set up-to-date .NET code quality analyzers
2024-12-06 17:29:09 -08:00
Dean Herbert
8d0e1f9d18
Merge branch 'master' into improve-menu-sample-playback
2024-12-05 21:07:03 +09:00
Huo Yaoyuan
d92ea910cf
Merge branch 'master' into netcore-analyzer
2024-12-05 17:18:56 +08:00
Dean Herbert
791416c8f1
Merge pull request #30937 from frenzibyte/fix-quick-restart-not-saving-score
...
Fix score no longer being saved when quick-restarting after pass
2024-12-04 23:48:18 -08:00
Salman Alshamrani
8e0f6fc12d
Re-encode difficulties on resource change
2024-12-04 04:36:00 -05:00
Salman Alshamrani
60d91bada8
Merge branch 'master' into editor-multiple-background-audio-files
2024-12-04 04:31:15 -05:00
Salman Alshamrani
06824c1658
Add failing test case
2024-12-04 04:20:09 -05:00
Salman Alshamrani
2a6fbb59ff
Add failing test case
2024-12-04 02:32:00 -05:00
Bartłomiej Dach
808934581f
Move bookmarks out of BeatmapInfo
...
Not sure why I didn't do that in https://github.com/ppy/osu/pull/28473 ...
2024-12-03 14:17:14 +01:00
Dean Herbert
75781e3436
Update usages of IPC in line with framework changes
2024-12-03 16:34:23 +09:00
Dan Balasescu
be05f2a1c2
Merge pull request #30929 from timschumi/rate-change-ready
...
Account for rate changing mods when disabling the "Ready" button
2024-12-03 16:30:16 +09:00
Dan Balasescu
6ff1dec7b2
Add tests
2024-12-03 15:45:58 +09:00
Dean Herbert
5b2558cec2
Merge pull request #28473 from bdach/beatmap-info-purge
...
Move unnecessary properties from `BeatmapInfo` / realm to `IBeatmap`
2024-12-02 16:19:12 +09:00
Salman Alshamrani
9140893249
Fix score no longer being saved when quick-restarting after pass
2024-11-30 23:36:02 -05:00
Huo Yaoyuan
68f21709a8
Fix CA1865
2024-11-30 02:32:09 +08:00
Huo Yaoyuan
fa3c95c296
Merge branch 'master'
2024-11-30 01:07:08 +08:00
Dean Herbert
f56b2b9aef
Merge pull request #30793 from bdach/close-playlists
...
Add ability to close playlists within grace period after creation
2024-11-29 22:37:32 +09:00
Salman Alshamrani
489d7a30ec
Perform a single Save call rather than doing it in each difficulty
2024-11-28 18:37:13 -05:00
Salman Alshamrani
078d62fe09
Fix weird default in test scene
2024-11-28 17:54:03 -05:00
Salman Alshamrani
a8db35ac45
Merge branch 'master' into daily-challenge-tier-thresholds
2024-11-28 17:46:55 -05:00
Jamie Taylor
58cf1c11e4
Improve menu/context-menu sample playback
2024-11-29 06:54:48 +09:00
Bartłomiej Dach
2e6f43a75d
Merge branch 'master' into close-playlists
2024-11-28 14:01:36 +01:00
Huo Yaoyuan
f5a7716509
Apply minor performance rules
2024-11-28 20:41:44 +08:00
Hiviexd
6ed21229b7
update test
2024-11-28 12:49:48 +01:00
Bartłomiej Dach
98a156ae2d
Merge pull request #30874 from peppy/chat-order
...
Sort public chat channels alphabetically, private channels based on recent messages
2024-11-28 12:46:14 +01:00
Huo Yaoyuan
8f6e5c4754
Convert legacy ruleset to globalconfig
2024-11-28 19:34:56 +08:00
Dan Balasescu
077719903b
Merge pull request #30905 from peppy/fix-multiple-offset-applications
...
Clear previous `LastLocalUserScore` when returning to song select
2024-11-28 18:58:13 +09:00
Dean Herbert
c26c84ba45
Add test coverage governing new behaviour
2024-11-28 18:03:19 +09:00
Bartłomiej Dach
0d491e3159
Merge branch 'master' into fix-daily-challenge-leaderboard
2024-11-28 09:41:24 +01:00
