Dean Herbert
|
61a43770bd
|
Merge branch 'master' into duplicate-multi-room
|
2020-10-19 16:58:45 +09:00 |
|
Dean Herbert
|
79a17b2371
|
Reapply waveform colour fix
|
2020-10-19 16:57:08 +09:00 |
|
Dan Balasescu
|
b5cadd6a2c
|
Merge pull request #10555 from peppy/fix-score-display-zero-padding
Fix incorrect zero padding for classic scoring mode
|
2020-10-19 15:54:12 +09:00 |
|
Dean Herbert
|
ba99c5c134
|
Remove rolling delay on default combo counter
|
2020-10-19 14:39:02 +09:00 |
|
Dean Herbert
|
cb1784a846
|
Fix score displays using non-matching zero padding depending on user score display mode
|
2020-10-19 14:05:28 +09:00 |
|
Dean Herbert
|
467bb9b96f
|
Merge branch 'master' into beatmap-carousel-refactor
|
2020-10-19 13:17:11 +09:00 |
|
Dean Herbert
|
bff3856c83
|
Account for panel height when removing as off-screen
|
2020-10-19 13:13:32 +09:00 |
|
Dean Herbert
|
ee0efa0b4c
|
Fix off-by-one in display range retrieval logic
|
2020-10-19 13:05:42 +09:00 |
|
Dean Herbert
|
4590d9b93b
|
Remove outdated comment logic
|
2020-10-19 13:04:12 +09:00 |
|
Dan Balasescu
|
b7c12ff61e
|
Merge pull request #10530 from peppy/fix-catch-dual-combo-counter
Fix osu!catch showing two combo counters for legacy skins
|
2020-10-16 23:52:14 +09:00 |
|
smoogipoo
|
dfbc0965e4
|
Merge branch 'master' into peppy/skinnable-health-display
|
2020-10-16 23:17:17 +09:00 |
|
Dean Herbert
|
e87f515a4f
|
Merge pull request #10522 from Morilli/legacyskin-fixes
Add support for ScorePrefix and ScoreOverlap values in legacy skins
|
2020-10-16 20:54:03 +09:00 |
|
Berkan Diler
|
cc11283143
|
Use string.Starts-/EndsWith char overloads
|
2020-10-16 11:27:02 +02:00 |
|
Dean Herbert
|
8a3bce3cc3
|
Fix osu!catch showing two combo counters for legacy skins
|
2020-10-16 18:20:17 +09:00 |
|
Dean Herbert
|
a774de2270
|
Also add support in LegacyComboCounter
|
2020-10-16 17:52:22 +09:00 |
|
Dean Herbert
|
77bf050a80
|
Ignore IgnoreHits for flashiness
|
2020-10-16 17:24:43 +09:00 |
|
Dean Herbert
|
f0b15813e2
|
Add support for both legacy styles
|
2020-10-16 17:08:46 +09:00 |
|
Dean Herbert
|
a810f56ec8
|
Move "flash on hit only" logic to binding
|
2020-10-16 17:08:46 +09:00 |
|
Dean Herbert
|
c0a1f2158c
|
Add basic component structure for skinnable health displays
|
2020-10-16 17:08:46 +09:00 |
|
Dan Balasescu
|
829241a9f0
|
Merge pull request #10521 from peppy/fix-editor-seek-interval-when-playing
Fix editor not seeking by full beat when track is playing
|
2020-10-16 13:55:03 +09:00 |
|
Dean Herbert
|
aea31d1582
|
Fix editor not seeking by full beat when track is playing
This is expected behaviour as my osu-stable, and I still stand behind
the reasoning behind it.
Closes #10519.
|
2020-10-16 13:07:00 +09:00 |
|
Dean Herbert
|
88ffcb9234
|
Update EndsWith usages
|
2020-10-16 12:58:34 +09:00 |
|
Dean Herbert
|
88f74921fb
|
Update with new r# inspections
|
2020-10-16 12:49:39 +09:00 |
|
Dan Balasescu
|
583fdc3a95
|
Merge pull request #10510 from peppy/skinnable-accuracy-display
Add legacy skinning support for accuracy display
|
2020-10-15 21:20:48 +09:00 |
|
Dan Balasescu
|
5d8cf87155
|
Merge pull request #10511 from peppy/bottom-error-display
Add support for bottom-anchored hit error display
|
2020-10-15 20:51:09 +09:00 |
|
Dan Balasescu
|
70b050f212
|
Merge branch 'master' into skinnable-accuracy-display
|
2020-10-15 20:28:57 +09:00 |
|
Dan Balasescu
|
1ce0e83e59
|
Merge branch 'master' into skinnable-score-display
|
2020-10-15 19:16:03 +09:00 |
|
Dan Balasescu
|
93dfbd5d9e
|
Merge pull request #10505 from peppy/skin-disabler-refactor
Move ISampleDisabler implementation to Player and FrameStabilityContainer
|
2020-10-15 19:14:52 +09:00 |
|
Dean Herbert
|
70806deba1
|
Add support for bottom-anchored hit error display
|
2020-10-15 19:14:02 +09:00 |
|
Dean Herbert
|
d76365ed1b
|
Make container readonly
|
2020-10-15 18:38:41 +09:00 |
|
Dan Balasescu
|
5640d33d1a
|
Merge branch 'master' into skin-disabler-refactor
|
2020-10-15 18:32:50 +09:00 |
|
Dean Herbert
|
6983978c98
|
Correct top-right element offset by finding the lower top anchor element
|
2020-10-15 18:30:44 +09:00 |
|
Dean Herbert
|
b31a3fbabb
|
Add test
|
2020-10-15 18:11:30 +09:00 |
|
Dean Herbert
|
254eba9008
|
Add and consume skinnable accuracy counter
|
2020-10-15 17:53:16 +09:00 |
|
Dean Herbert
|
90ff8ff050
|
Merge branch 'skinnable-combo-counter' into skinnable-score-display
|
2020-10-15 17:52:06 +09:00 |
|
Dean Herbert
|
37e9f331ad
|
Simplify score font lookup
|
2020-10-15 17:49:55 +09:00 |
|
Dean Herbert
|
43e5cb90e2
|
Merge branch 'skinnable-combo-counter' into skinnable-score-display
|
2020-10-15 17:30:29 +09:00 |
|
Dean Herbert
|
9f51327e4b
|
Fix completely incorrect default positioning logic
|
2020-10-15 17:29:40 +09:00 |
|
Dean Herbert
|
5b5ba7df93
|
Remove unused offset
|
2020-10-15 17:22:34 +09:00 |
|
Dean Herbert
|
d8d085ede9
|
Align top-right elements with lowest point in score display
|
2020-10-15 17:14:42 +09:00 |
|
Dean Herbert
|
74c031cfbb
|
Fix ModOverlay not including "UNRANKED" text in size
|
2020-10-15 17:14:42 +09:00 |
|
Dean Herbert
|
b210147c2e
|
Update combo counter to read from default score display's position correctly
|
2020-10-15 17:14:42 +09:00 |
|
Dean Herbert
|
950c47287c
|
Fix positioning of score display in HUD overlay
|
2020-10-15 17:14:42 +09:00 |
|
Dean Herbert
|
e1da64398e
|
Add and consume skinnable score counter
|
2020-10-15 17:14:42 +09:00 |
|
Dean Herbert
|
219cbec6bd
|
Split out DefaultScoreCounter and make ScoreCounter abstract
|
2020-10-15 16:32:30 +09:00 |
|
Dean Herbert
|
d5f2aab52e
|
Tidy up SkinnableComboCounter class slightly
|
2020-10-15 15:37:40 +09:00 |
|
Dean Herbert
|
e0210f5c4c
|
Ignore failed casts to make tests happy
|
2020-10-14 23:52:58 +09:00 |
|
Dean Herbert
|
e3eaba7b2c
|
Move ISampleDisabler implementation to Player and FrameStabilityContainer
|
2020-10-14 19:39:48 +09:00 |
|
Dean Herbert
|
ac4f56403d
|
Adjust size/position
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
7f5ea57bd4
|
Clean-up pass (best effort) on LegacyComboCounter
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
9bb8a43bce
|
Combine LegacyComboCounter and ComboCounter classes
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
fbbea48c8c
|
Add score text skinnability
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
2fce064e32
|
Add basic legacy combo counter and updating positioning logic
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
6a6718ebab
|
Allow bypassing origin/anchor setting of skinnable components
It makes little sense to set these when using RelativeSizeAxes.Both
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
899bac6ca5
|
Rename catch combo counter for clarity
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
f5623ee21e
|
Setup skinnable combo counter component with default implementation
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
60603d2918
|
Add skin components and interfaces
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
98acf1e31d
|
Make field read only
|
2020-10-14 19:16:25 +09:00 |
|
Dean Herbert
|
a7f8e26e35
|
Adjust bottom-right elements positions based on song progress display
|
2020-10-14 18:51:53 +09:00 |
|
Dean Herbert
|
0cf3e90904
|
Update SongProgress height based on its dynamic height during resize
|
2020-10-14 18:44:22 +09:00 |
|
Dean Herbert
|
ace9fbc8d3
|
Confine available area for HUD components to excluse the song progress area
|
2020-10-14 18:44:22 +09:00 |
|
Dean Herbert
|
30e1fce7a4
|
Reduce alloc overhead of DrawableCarouselBeatmapSet using new function-based ctor
|
2020-10-14 15:10:50 +09:00 |
|
Dean Herbert
|
07e6609e6d
|
Disable difficulty calculation for set-level difficulty icons
|
2020-10-14 14:16:22 +09:00 |
|
Dean Herbert
|
e662dc5342
|
Add missing licence headers
|
2020-10-13 20:57:26 +09:00 |
|
Dean Herbert
|
8057ea1097
|
Fix formatting issues
|
2020-10-13 20:50:36 +09:00 |
|
Dean Herbert
|
3d416f4d64
|
Clean up beatmapSet resolution in DrawableCarouselBeatmapSet
|
2020-10-13 19:31:29 +09:00 |
|
Dean Herbert
|
75b6a5e17e
|
Remove unnecessary hack (fixed via framework update)
|
2020-10-13 19:31:29 +09:00 |
|
Dean Herbert
|
5d11db7753
|
Locallise ChildItems to DrawableCarouselBeatmapSet for clarity
|
2020-10-13 19:31:29 +09:00 |
|
Dean Herbert
|
37daefc2b5
|
Remove outdated comment
|
2020-10-13 19:12:33 +09:00 |
|
Dean Herbert
|
8eca28e8bc
|
Add comment about off-screen loading
|
2020-10-13 19:10:35 +09:00 |
|
Dean Herbert
|
834b0186f4
|
Adjust fade duration to be slightly shorter
|
2020-10-13 18:50:10 +09:00 |
|
Dean Herbert
|
2346644c04
|
Switch DelayedLoadUnloadWrappers to DelayedLoadWrappers
Due to pooling usage, there is no time we need to unload. Switching to
DelayedLoadWrapper cleans up the code and reduces overhead
substantially.
|
2020-10-13 18:47:40 +09:00 |
|
Dean Herbert
|
a1801f8ae4
|
Unmark todo for now
|
2020-10-13 18:47:36 +09:00 |
|
Dean Herbert
|
40a0ab7aaa
|
Avoid allocating CarouselItems for bounds checks
|
2020-10-13 18:33:31 +09:00 |
|
Dean Herbert
|
4f4f222514
|
Remove unnecessary fade (already applied by base DrawableCarouselItem)
|
2020-10-13 18:28:28 +09:00 |
|
Dean Herbert
|
83358d487f
|
Remove logging
|
2020-10-13 18:18:22 +09:00 |
|
Dean Herbert
|
3d9ea852ec
|
Remove masking override (no longer needed as our size is now correct)
|
2020-10-13 18:14:23 +09:00 |
|
Dean Herbert
|
69650c16fc
|
Simplify vertical position calculations by including spacing in height definition
|
2020-10-13 18:13:36 +09:00 |
|
Dean Herbert
|
b1ddb08a4e
|
Fix right click context menus appearing in incorrect locations
|
2020-10-13 18:01:12 +09:00 |
|
Dean Herbert
|
d9a6a6b245
|
Split content out into own class
|
2020-10-13 18:01:12 +09:00 |
|
Dean Herbert
|
9b2ebb8f0f
|
Fix main content DelayedLoadUnloadWrapper not getting a valid size before load
|
2020-10-13 17:45:41 +09:00 |
|
Dean Herbert
|
f3b937e358
|
Fix masking issues with certain aspect ratio displays
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
fdd4d95cdc
|
Fix difficulties being at incorrect vertical positions after filter is applied
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
1f0aa974dd
|
Fix failing tests
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
b536f571fd
|
Move header height propagation to update for safety
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
ded09b78cb
|
Avoid usage of AutoSize for DrawableCarouselItems in general
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
cecdf14f53
|
Avoid reconstructing beatmap difficulties that were recently displayed
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
1da49073ab
|
Calculate content height automatically
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
c08b5e8d03
|
Align beatmap difficulties correctly
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
cfec4f4fc1
|
Extract header element from base DrawableCarouselItem class
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
2aad482545
|
Fix x offsets of difficulties not being updated
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
1b7e3397c6
|
Use expiry to avoid ToArray
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
075bf23714
|
Better track off-screen drawables (and return to pool less often)
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
29983afcef
|
Replace pool/cleanup logic with simplest form possible
This will temporarily break panels that go off-screen, as they will
disappear immediately
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
06e84c8eb3
|
Add comments and split out update steps into a more logical flow
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
20b54fb904
|
Move transform clean-up to pooling free call
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
f6aa448523
|
Store y positions inside items rather than in a separate array
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
b92c22ad42
|
Add logging
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
9814e9ba7f
|
Split classes out to reduce loc burder on DrawableCarouselBeatmapSet
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
975cd5a840
|
Add back beatmap difficulty appear/disappear movement
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
fd8654cff3
|
Add back difficulty panel spacing
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
ce67f65084
|
Fix single results not showing up
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
220c8ba2c4
|
Fix incorrect vertical offsets when difficulties are filtered away
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
82f9ca3de9
|
Bind to filter event changes in base drawable item
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
813ee19728
|
Use existing event flow for rendering beatmap difficulties
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
8847cedf29
|
Add initial pass of vertical transforms
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
15325f5f51
|
Base bounds checks on +1 (to avoid worrying about current item heights)
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
bb03c5d77c
|
Temporarily disable masking temporarily to fix panels disappearing at extents
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
524419d5e4
|
Fix filtered items being considered for height calculation
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
0a144a1388
|
Correctly free panels after use to avoid finalizer disposal of subtree
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
c5a6f4b453
|
Fix scroll to selected beatmap
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
5c29aa8cce
|
Fix multiple difficulties being expanded at once
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
5c2f134665
|
Add back left offset for selected set
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
3cfc0dc82d
|
Add safeties to beatmap panel loading code
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
954d43ef56
|
Debounce state application events
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
ca1f5dcada
|
Add back panel padding
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
0400b34349
|
Load more components asynchronously after pool resolution
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
f3b24b9bb5
|
Avoid performing eager selection constantly on adding ranges of new children
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
0a978c6131
|
Add basic pooling setup
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
f17d661c1a
|
Add basic range-based invalidation
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
3143224e5b
|
Refactor how drawable carousel items are constructed
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
9193f5b0ba
|
Expose panel height from non-drawable models
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
a393bbe8f7
|
Remove direct drawable storage from carousel models
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
b08e7ce1f5
|
Update BaseColour specification
|
2020-10-13 17:37:24 +09:00 |
|
Dean Herbert
|
8431a5a23c
|
Merge pull request #10483 from Joehuu/add-extended-stats-keyboard-shortcut
|
2020-10-11 22:48:42 +09:00 |
|
Dean Herbert
|
a246991c50
|
Merge pull request #10472 from LeNitrous/expose-player-isbreaktime
Expose BreakTracker.IsBreakTime in Player
|
2020-10-11 22:36:24 +09:00 |
|
Dean Herbert
|
de6fe34361
|
Bind to local bindable and combine dual bindings
|
2020-10-11 21:51:48 +09:00 |
|
Dean Herbert
|
5fcdee6fd8
|
Remove cast and expose as IBindable
|
2020-10-11 21:46:55 +09:00 |
|
Joehu
|
8faa86b048
|
Add ability to toggle extended statistics using space or enter
|
2020-10-10 18:32:22 -07:00 |
|
unknown
|
6a52c98a42
|
make IsBreakTime its own bindable and bind it to BreakTracker on load
|
2020-10-11 06:15:20 +08:00 |
|
unknown
|
7bbdd6ab25
|
expose break time bindable
|
2020-10-10 21:07:17 +08:00 |
|
Dean Herbert
|
73c238fae3
|
Add the ability to search for local beatmaps via online IDs
Closes #10470.
|
2020-10-10 21:34:11 +09:00 |
|
Dean Herbert
|
b0f8a7794a
|
Make SelectionHandler require EditorBeatmap presence
|
2020-10-09 21:44:10 +09:00 |
|
Dean Herbert
|
681e88af40
|
Merge branch 'master' into editor-fix-button-states-after-paste
|
2020-10-09 20:51:09 +09:00 |
|
Dan Balasescu
|
ecfb7e94c5
|
Merge branch 'master' into fix-editor-batch-handling
|
2020-10-09 20:06:06 +09:00 |
|
Dan Balasescu
|
07f19342d1
|
Merge pull request #10428 from peppy/editor-reset-newcombo-on-placement
Reset new combo button state after successful placement
|
2020-10-09 19:48:47 +09:00 |
|
Dan Balasescu
|
bcc096ee49
|
Merge pull request #10446 from peppy/fix-timeline-tick-bar-lines
Fix bar lines ("down beat" as people call it) showing up too often in timeline
|
2020-10-09 19:24:29 +09:00 |
|
Dan Balasescu
|
62690e4873
|
Merge pull request #10432 from peppy/editor-reverse-pattern
Add "reverse pattern" support to editor selection handler
|
2020-10-09 19:19:24 +09:00 |
|
Dean Herbert
|
3838f405dd
|
Fix missed usages
|
2020-10-09 18:50:05 +09:00 |
|
Dean Herbert
|
edaf6db5c6
|
Reference EditorBeatmap directly for selected objects
|
2020-10-09 18:44:23 +09:00 |
|
Dean Herbert
|
21c6242f90
|
Fix bar lines ("down beat" as people call it) showing up too often in timeline
|
2020-10-09 18:35:44 +09:00 |
|
Dan Balasescu
|
a6d19cd2d6
|
Merge pull request #10431 from peppy/fix-distribution-graph-rounding
Fix incorrect timing distribution display due to lack of rounding
|
2020-10-09 18:12:29 +09:00 |
|
Dan Balasescu
|
a1226ccaa2
|
Merge pull request #10440 from peppy/fix-editor-song-after-exit
Fix editor playing deleted beatmap's track on exit-without-save
|
2020-10-09 17:58:31 +09:00 |
|
Dan Balasescu
|
4881a13f4b
|
Merge pull request #10443 from peppy/editor-timeline-tick-display-performance
Improve TimelineTickDisplay performance
|
2020-10-09 17:53:12 +09:00 |
|
Dean Herbert
|
5d888f687a
|
Account for the width of points so they don't suddenly appear at timeline edges
|
2020-10-09 16:49:51 +09:00 |
|
Dean Herbert
|
ceb1494c33
|
Only run regeneration when passing a new min/max tick boundary
|
2020-10-09 16:47:29 +09:00 |
|
Dean Herbert
|
017a8ce496
|
Only recalculate when display actually changes
|
2020-10-09 15:57:31 +09:00 |
|
Dean Herbert
|
9baf704942
|
Add local pooling to TimelineTickDisplay
|
2020-10-09 15:48:24 +09:00 |
|
Dean Herbert
|
8be19fd820
|
Increase height of contracted score panel to fit mods again
|
2020-10-09 13:26:09 +09:00 |
|
Dean Herbert
|
07558b5bc0
|
Merge branch 'master' into ruleset-result-types
|
2020-10-09 13:17:05 +09:00 |
|