2111 Commits

Author	SHA1	Message	Date
Dean Herbert	3d9ea852ec	Remove masking override (no longer needed as our size is now correct)	2020-10-13 18:14:23 +09:00
Dean Herbert	69650c16fc	Simplify vertical position calculations by including spacing in height definition	2020-10-13 18:13:36 +09:00
Dean Herbert	b1ddb08a4e	Fix right click context menus appearing in incorrect locations	2020-10-13 18:01:12 +09:00
Dean Herbert	d9a6a6b245	Split content out into own class	2020-10-13 18:01:12 +09:00
Dean Herbert	9b2ebb8f0f	Fix main content DelayedLoadUnloadWrapper not getting a valid size before load	2020-10-13 17:45:41 +09:00
Dean Herbert	f3b937e358	Fix masking issues with certain aspect ratio displays	2020-10-13 17:37:33 +09:00
Dean Herbert	fdd4d95cdc	Fix difficulties being at incorrect vertical positions after filter is applied	2020-10-13 17:37:33 +09:00
Dean Herbert	1f0aa974dd	Fix failing tests	2020-10-13 17:37:33 +09:00
Dean Herbert	b536f571fd	Move header height propagation to update for safety	2020-10-13 17:37:33 +09:00
Dean Herbert	ded09b78cb	Avoid usage of AutoSize for DrawableCarouselItems in general	2020-10-13 17:37:33 +09:00
Dean Herbert	cecdf14f53	Avoid reconstructing beatmap difficulties that were recently displayed	2020-10-13 17:37:33 +09:00
Dean Herbert	1da49073ab	Calculate content height automatically	2020-10-13 17:37:33 +09:00
Dean Herbert	c08b5e8d03	Align beatmap difficulties correctly	2020-10-13 17:37:33 +09:00
Dean Herbert	cfec4f4fc1	Extract header element from base DrawableCarouselItem class	2020-10-13 17:37:33 +09:00
Dean Herbert	2aad482545	Fix x offsets of difficulties not being updated	2020-10-13 17:37:33 +09:00
Dean Herbert	1b7e3397c6	Use expiry to avoid ToArray	2020-10-13 17:37:33 +09:00
Dean Herbert	075bf23714	Better track off-screen drawables (and return to pool less often)	2020-10-13 17:37:33 +09:00
Dean Herbert	29983afcef	Replace pool/cleanup logic with simplest form possible ... This will temporarily break panels that go off-screen, as they will disappear immediately	2020-10-13 17:37:33 +09:00
Dean Herbert	06e84c8eb3	Add comments and split out update steps into a more logical flow	2020-10-13 17:37:33 +09:00
Dean Herbert	20b54fb904	Move transform clean-up to pooling free call	2020-10-13 17:37:33 +09:00
Dean Herbert	f6aa448523	Store y positions inside items rather than in a separate array	2020-10-13 17:37:33 +09:00
Dean Herbert	b92c22ad42	Add logging	2020-10-13 17:37:33 +09:00
Dean Herbert	9814e9ba7f	Split classes out to reduce loc burder on DrawableCarouselBeatmapSet	2020-10-13 17:37:33 +09:00
Dean Herbert	975cd5a840	Add back beatmap difficulty appear/disappear movement	2020-10-13 17:37:33 +09:00
Dean Herbert	fd8654cff3	Add back difficulty panel spacing	2020-10-13 17:37:33 +09:00
Dean Herbert	ce67f65084	Fix single results not showing up	2020-10-13 17:37:33 +09:00
Dean Herbert	220c8ba2c4	Fix incorrect vertical offsets when difficulties are filtered away	2020-10-13 17:37:33 +09:00
Dean Herbert	82f9ca3de9	Bind to filter event changes in base drawable item	2020-10-13 17:37:33 +09:00
Dean Herbert	813ee19728	Use existing event flow for rendering beatmap difficulties	2020-10-13 17:37:33 +09:00
Dean Herbert	8847cedf29	Add initial pass of vertical transforms	2020-10-13 17:37:33 +09:00
Dean Herbert	15325f5f51	Base bounds checks on +1 (to avoid worrying about current item heights)	2020-10-13 17:37:33 +09:00
Dean Herbert	bb03c5d77c	Temporarily disable masking temporarily to fix panels disappearing at extents	2020-10-13 17:37:33 +09:00
Dean Herbert	524419d5e4	Fix filtered items being considered for height calculation	2020-10-13 17:37:33 +09:00
Dean Herbert	0a144a1388	Correctly free panels after use to avoid finalizer disposal of subtree	2020-10-13 17:37:33 +09:00
Dean Herbert	c5a6f4b453	Fix scroll to selected beatmap	2020-10-13 17:37:33 +09:00
Dean Herbert	5c29aa8cce	Fix multiple difficulties being expanded at once	2020-10-13 17:37:33 +09:00
Dean Herbert	5c2f134665	Add back left offset for selected set	2020-10-13 17:37:33 +09:00
Dean Herbert	3cfc0dc82d	Add safeties to beatmap panel loading code	2020-10-13 17:37:33 +09:00
Dean Herbert	954d43ef56	Debounce state application events	2020-10-13 17:37:33 +09:00
Dean Herbert	ca1f5dcada	Add back panel padding	2020-10-13 17:37:33 +09:00
Dean Herbert	0400b34349	Load more components asynchronously after pool resolution	2020-10-13 17:37:33 +09:00
Dean Herbert	f3b24b9bb5	Avoid performing eager selection constantly on adding ranges of new children	2020-10-13 17:37:33 +09:00
Dean Herbert	0a978c6131	Add basic pooling setup	2020-10-13 17:37:33 +09:00
Dean Herbert	f17d661c1a	Add basic range-based invalidation	2020-10-13 17:37:33 +09:00
Dean Herbert	3143224e5b	Refactor how drawable carousel items are constructed	2020-10-13 17:37:33 +09:00
Dean Herbert	9193f5b0ba	Expose panel height from non-drawable models	2020-10-13 17:37:33 +09:00
Dean Herbert	a393bbe8f7	Remove direct drawable storage from carousel models	2020-10-13 17:37:33 +09:00
Dean Herbert	73c238fae3	Add the ability to search for local beatmaps via online IDs ... Closes #10470.	2020-10-10 21:34:11 +09:00
Joehu	c6386ea605	Remember leaderboard mods filter selection in song select	2020-09-15 21:53:35 -07:00
Dean Herbert	3c70b3127c	Fix potential nullref in FilterControl during asynchronous load	2020-09-15 23:19:31 +09:00
Dan Balasescu	6cbff98295	Merge branch 'master' into add-collections-to-beatmap-options	2020-09-15 15:23:33 +09:00
Dean Herbert	2c7492d717	Add null check in SongSelect disposal for safety	2020-09-15 14:34:58 +09:00
Joehu	43daabc982	Remove unused using and move dialog to BDL	2020-09-14 12:10:00 -07:00
Joehu	c833f5fcc4	Reorder buttons to match stable	2020-09-14 11:23:41 -07:00
Joehu	57610ddad5	Fix beatmap options absorbing input from toolbar ruleset selector	2020-09-14 11:22:16 -07:00
Joehu	c30174cea3	Add manage collections button to beatmap options	2020-09-14 11:21:23 -07:00
Joehu	1a8a7ae7f8	Remove hardcoded key param from AddButton	2020-09-14 11:19:18 -07:00
Joehu	368aca015a	Move override methods to bottom	2020-09-14 11:18:00 -07:00
Bartłomiej Dach	a377cccb4d	Unsubscribe from track changed event on disposal	2020-09-14 17:10:35 +02:00
Bartłomiej Dach	f17b2f1359	Ensure track is looping in song select immediately	2020-09-12 20:43:17 +02:00
smoogipoo	5b80a7db5f	Re-namespace collections dropdown	2020-09-11 16:01:01 +09:00
Dean Herbert	033bd82953	Merge branch 'master' into fix-filtercontrol-order	2020-09-11 13:07:41 +09:00
Dean Herbert	b594a2a507	Import collections on initial import-from-stable step	2020-09-11 11:16:00 +09:00
smoogipoo	314cd13b74	Fix song select filter ordering	2020-09-10 23:36:22 +09:00
Dean Herbert	18d96738a1	Fix hard crash on deleting a collection with no collection selected	2020-09-10 19:52:34 +09:00
smoogipoo	6b56c6e83f	Rename to CollectionMenuItem	2020-09-09 23:11:19 +09:00
smoogipoo	43525614ad	Store raw BeatmapCollection in filter control	2020-09-09 23:10:21 +09:00
smoogipoo	1a023d2c88	Fix a few more tests	2020-09-09 16:33:48 +09:00
smoogipoo	0360f7d845	Move CollectionManager to OsuGame	2020-09-09 15:39:15 +09:00
smoogipoo	4ddf5f054b	Rename BeatmapCollectionManager -> CollectionManager	2020-09-09 15:31:08 +09:00
smoogipoo	a5e1e8d043	Rename More... to Manage...	2020-09-08 18:57:18 +09:00
smoogipoo	ae022d7559	Show all items in dropdown, set global max height	2020-09-08 18:55:53 +09:00
smoogipoo	4962213cc4	Rename manage collections filter/text	2020-09-08 18:42:55 +09:00
smoogipoo	f581df47c8	Add "New collection..." item to dropdown	2020-09-08 18:25:09 +09:00
smoogipoo	c2da3d9c84	Fix button input and tests	2020-09-08 14:36:38 +09:00
smoogipoo	8a3c8a6185	Show button when selected or preselected	2020-09-08 14:03:49 +09:00
smoogipoo	32e3f5d091	Adjust button styling	2020-09-08 13:45:26 +09:00
Dean Herbert	8b770626fa	Add missing '...' from some popup menu items	2020-09-08 12:18:08 +09:00
Dean Herbert	b15bbc882a	Move items up in menu	2020-09-08 12:04:35 +09:00
Dean Herbert	3e5ea6c42f	Change "Add to" to "Collections" ... Doesn't make send to be 'add to' when it can also remove	2020-09-08 12:00:00 +09:00
smoogipoo	ca4423af74	Fix tests	2020-09-08 00:07:12 +09:00
smoogipoo	e37c04cb6d	Change back to solid icon	2020-09-08 00:04:03 +09:00
smoogipoo	a1214512bc	Add filter control tests	2020-09-07 23:57:49 +09:00
smoogipoo	98e9c4dc25	General refactorings	2020-09-07 21:08:48 +09:00
smoogipoo	c1d255a04c	Split filter control into separate class	2020-09-07 20:44:39 +09:00
smoogipoo	120dfd50a6	Fix collection names not updating in dropdown	2020-09-07 20:29:28 +09:00
smoogipoo	b91a376f0a	Split dropdown into separate file	2020-09-07 20:06:38 +09:00
smoogipoo	6cc4517600	Merge branch 'master' into collection-database	2020-09-07 20:03:11 +09:00
smoogipoo	4b4dd02942	Make collection name a bindable	2020-09-05 04:43:59 +09:00
smoogipoo	345fb9d8e0	Rename classes	2020-09-05 03:55:43 +09:00
smoogipoo	ebd11ae0b7	Add a collection management dialog	2020-09-05 03:52:07 +09:00
Dan Balasescu	743c888986	Merge branch 'master' into expose-wedge-icons	2020-09-04 16:22:14 +09:00
Dan Balasescu	b631430a5b	Merge pull request #10045 from peppy/add-info-wedge-icons ... Update and add missing beatmap statistic icons to info wedge	2020-09-04 16:22:01 +09:00
smoogipoo	4399f5976c	Fix global mods being retained by rooms	2020-09-04 15:20:55 +09:00
Dean Herbert	25e142965d	Strongly type and expose default beatmap information icon implementations for other rulesets	2020-09-04 15:01:32 +09:00
Dean Herbert	cd253ab055	Further tweaks to get closer to design originals	2020-09-04 13:05:39 +09:00
Dean Herbert	d6b46936a0	Adjust sizing to match updated textures with less padding	2020-09-04 12:55:28 +09:00
Dean Herbert	a99e7a1dc2	Merge branch 'master' into add-info-wedge-icons	2020-09-03 21:57:58 +09:00
Dean Herbert	7a0c1411b6	Merge branch 'master' into timeshift-leaderboard-topscore	2020-09-03 18:11:04 +09:00
Dean Herbert	72cb65c22f	Update and add missing beatmap statistic icons to info wedge	2020-09-03 17:52:22 +09:00
smoogipoo	fca0324264	Disallow being able to add dummy beatmap	2020-09-02 23:34:38 +09:00
smoogipoo	d83264f538	Add max height	2020-09-02 22:56:13 +09:00
smoogipoo	7fcbc3a814	Respond to changes in beatmap	2020-09-02 22:06:17 +09:00
smoogipoo	661eac8f1d	Add add/remove button to dropdown items	2020-09-02 22:03:38 +09:00
smoogipoo	02a908752f	Fix stackoverflow	2020-09-02 21:52:56 +09:00
smoogipoo	5ebead2bfd	Prevent ValueChanged binds to external bindable	2020-09-02 21:44:07 +09:00
smoogipoo	d363a5d164	Add basic ordering	2020-09-02 21:19:15 +09:00
smoogipoo	094ddecc95	Add dropdowns to carousel items	2020-09-02 21:08:31 +09:00
smoogipoo	6d5e155106	Change to BindableList to notify of changes	2020-09-02 20:44:26 +09:00
smoogipoo	9dde37fe40	Hook up collection filter	2020-09-02 20:25:42 +09:00
smoogipoo	bb090a55e0	Add dropdown to filter control	2020-09-02 20:25:25 +09:00
Dan Balasescu	f08e7828da	Merge branch 'master' into beatmap-track-rework	2020-09-01 16:06:38 +09:00
Bartłomiej Dach	876fd21230	Apply shear to right-anchored items	2020-08-31 19:31:47 +02:00
Bartłomiej Dach	2e2f26449d	Change anchoring to TopRight	2020-08-31 19:23:19 +02:00
smoogipoo	8cf26979fb	Allow null user score	2020-08-31 20:16:28 +09:00
smoogipoo	ed74c39b55	Move UserTopScoreContainer into base leaderboard	2020-08-31 19:54:22 +09:00
Bartłomiej Dach	7d273d631b	Do not show star difficulty on wedge if zero	2020-08-31 11:05:42 +02:00
Bartłomiej Dach	4736845318	Add spacing between star rating and beatmap status	2020-08-31 10:56:06 +02:00
smoogipoo	c3bfce6ccf	Add star rating to beatmap wedge	2020-08-31 15:03:41 +09:00
Dean Herbert	b51db90147	Merge branch 'master' into beatmap-track-rework	2020-08-26 23:20:56 +09:00
Bartłomiej Dach	29b4d98aac	Show retry/fail graph when either list is present	2020-08-24 20:41:50 +02:00
Bartłomiej Dach	cc6ae8e3bd	Fix crash if only one count list is received from API	2020-08-24 20:41:31 +02:00
Keijia	b5b2e523ad	change switch cases	2020-08-22 12:10:31 +03:00
Keijia	0b6185cd14	add "hp" filter keyword	2020-08-22 01:09:35 +03:00
Dean Herbert	e465afa280	Merge branch 'master' into beatmap-track-rework	2020-08-14 20:02:43 +09:00
smoogipoo	0500d82b5b	Fix playlist items sharing mod instances	2020-08-13 19:48:41 +09:00
smoogipoo	7d35893ecd	Make MusicController non-nullable	2020-08-11 12:40:58 +09:00
smoogipoo	f058f5e977	Fix incorrect value being set	2020-08-06 16:24:14 +09:00
smoogipoo	5c05fe3988	Expose track from MusicController	2020-08-06 16:24:14 +09:00
smoogipoo	6e42b8219c	Move track to MusicController, compiles	2020-08-06 16:24:14 +09:00
smoogipoo	877b985e90	Remove local cancellation token	2020-07-24 16:11:28 +09:00
smoogipoo	b10b99a670	Change method signatures to remove tracked/untracked	2020-07-24 13:52:43 +09:00
smoogipoo	76284a0f01	Move cancellation out of condition	2020-07-23 23:18:51 +09:00
smoogipoo	107b5ca4f2	Add support for bindable retrieval	2020-07-21 23:13:04 +09:00
smoogipoo	9a52058a7a	Update carousel beatmap SR on mod/ruleset changes	2020-07-16 21:08:24 +09:00
smoogipoo	24f14751ce	Update beatmap details SR on ruleset/mod changes	2020-07-16 21:08:08 +09:00
Joehu	73e1bf0d89	Check sub screen's OnBackButton instead	2020-07-14 13:19:48 -07:00
Joehu	36041fc245	Fix back button not working correctly with multi song select's mod select	2020-07-14 00:29:57 -07:00
Joehu	4caf4d31d4	Fix mod select blocking home and alt f4 in song select	2020-07-14 00:00:10 -07:00
Dean Herbert	0718e9e4b6	Update outdated comment	2020-07-13 13:08:41 +09:00
Dean Herbert	ab11a112b7	Fix correct filter criteria not being applied to beatmap carousel if beatmaps take too long to load	2020-07-12 22:33:41 +09:00
Dean Herbert	f231b5925f	Add "show converted" checkbox to song select for convenience	2020-07-09 13:47:23 +09:00
Dean Herbert	bbbe8d6f68	Remove group selector for now, tidy up code somewhat	2020-07-09 13:47:11 +09:00
smoogipoo	af7494b232	Improve quality of song select beatmap wedge	2020-06-29 13:58:35 +09:00
smoogipoo	099416b4c3	Move check inside next difficulty selection	2020-06-26 21:03:34 +09:00
smoogipoo	8f6d52550f	Fix potential exception if button is pressed before selection	2020-06-26 20:32:13 +09:00
smoogipoo	1b4c31a84f	Remove double schedule	2020-06-26 20:14:08 +09:00
smoogipoo	e3d654d33f	Cleanup	2020-06-26 20:14:02 +09:00
Dean Herbert	d704a4597d	Use existing helper function for key repeat	2020-06-25 21:33:02 +09:00
Dean Herbert	d7742766d0	Add key/press repeat support to carousel	2020-06-25 19:47:23 +09:00
Viktor Rosvall	9e1bf71233	Added text explaining a second copy will be made	2020-06-24 11:29:38 +02:00
smoogipoo	f3b5149648	Move some suggestions to warnings, resolve issues	2020-06-03 16:48:44 +09:00
Dean Herbert	93572fc17d	Merge branch 'master' into present-recommended	2020-06-03 12:31:23 +09:00
Lucas A	275d95082a	Fix crash in testing environment.	2020-06-02 16:01:01 +02:00
Lucas A	f63c66396f	Apply review suggestions.	2020-06-02 13:32:52 +02:00
Lucas A	e9b09373e7	Fix crashing if selected ruleset doesn't have an autoplay mod.	2020-06-01 17:41:04 +02:00
Dean Herbert	d4b7c81f96	Merge branch 'master' into results-screen-condensed-panel	2020-05-30 23:13:52 +09:00
Dean Herbert	f989f1aa00	Change event flow to avoid firing store delete events on update	2020-05-27 16:08:47 +09:00
smoogipoo	de0b6ec9f1	Create abstract implementation	2020-05-26 17:00:41 +09:00
Dean Herbert	052ad79fc6	Convert dangerous events to IBindables	2020-05-19 16:44:22 +09:00
Dean Herbert	a5c1b461f6	Fix null reference in difficulty recommender	2020-05-12 11:14:51 +09:00
smoogipoo	401c516503	Expose searchable terms from beatmap info instead	2020-05-07 13:04:08 +09:00
smoogipoo	5186da8412	Fix potential song select nullref	2020-05-07 11:37:04 +09:00
Dan Balasescu	0eae8d078b	Merge branch 'master' into master	2020-05-05 13:33:29 +09:00
alex	0e2ccac33b	Add spaces to comments	2020-05-04 18:36:24 -07:00
Dean Herbert	06f58dd3e3	Ensure correct beatmap and ruleset when presenting a score from song select	2020-05-04 15:20:43 +09:00
Endrik Tombak	1c04d58d6e	Fix recommender's incorrect usage of current ruleset	2020-05-01 19:44:35 +03:00
Bartłomiej Dach	623611d9dc	Simplify ruleset ordering	2020-05-01 17:15:35 +02:00
Bartłomiej Dach	9f091f3a56	Do not query API for custom rulesets	2020-05-01 17:02:28 +02:00
Endrik Tombak	33a608fd15	Merge branch 'master' of https://github.com/ppy/osu into present-recommended ... Conflicts: osu.Game/Screens/Select/SongSelect.cs	2020-05-01 11:06:20 +03:00
Dean Herbert	000c34dc26	Move recommender to field construction	2020-04-30 21:01:53 +09:00
Dean Herbert	cf4e79cf38	Show loading spinner when carousel is not ready to be displayed	2020-04-30 11:51:06 +09:00
Dean Herbert	119000f1ab	Reduce database includes where possible	2020-04-28 21:43:35 +09:00
Endrik Tombak	657bf5ad86	Merge branch 'master' of https://github.com/ppy/osu into present-recommended	2020-04-25 10:13:57 +03:00
smoogipoo	fcfb2b9026	Merge branch 'master' into fix-select-new-from-sub-screen	2020-04-21 14:36:53 +09:00
Dan Balasescu	3b3a7bdd85	Merge branch 'master' into scroll-to-center	2020-04-21 10:21:08 +09:00
Bartłomiej Dach	e3cd3cf1da	Convert to auto-properties	2020-04-20 21:43:07 +02:00
Bartłomiej Dach	9b6e26583b	Add xmldocs	2020-04-20 21:42:43 +02:00
Dean Herbert	ee1ccb8bcb	Fix in a slightly different and hopefully more understandable way	2020-04-20 14:03:55 +09:00
Endrik Tombak	b57d709d15	Don't use Parent	2020-04-19 18:29:06 +03:00
Endrik Tombak	a8bfd21f3f	Merge branch 'master' of https://github.com/ppy/osu into scroll-to-center	2020-04-19 18:21:34 +03:00
Endrik Tombak	4aaa00e321	Fix CI complaints	2020-04-17 20:33:12 +03:00
Endrik Tombak	1ac9ee5990	Optimize recommender (for custom rulesets)	2020-04-17 18:15:11 +03:00
Dean Herbert	5833a7ac91	Fix presenting new ruleset and beatmap at once causing wedge display desync	2020-04-17 18:56:17 +09:00
Dean Herbert	d62094cd4b	Fix carousel not correctly updating when selection changes to a new beatmap from a child screen	2020-04-16 18:10:35 +09:00
Dean Herbert	03a74a4320	Apply same conditional check changes to DrawableCarouselBeatmapSet	2020-04-16 12:13:26 +09:00
Dean Herbert	91b13f91ea	Add exception disallowing potential edit when disabled at a property level	2020-04-16 12:11:12 +09:00
Dean Herbert	c4caf38feb	Simplify menu item checks (and add for other items)	2020-04-16 12:10:20 +09:00
Joehu	e2b28bfe88	Hide edit context menu item in multiplayer song select	2020-04-15 18:17:12 -07:00
Endrik Tombak	b5c1752f0a	Calculate best ruleset order only once	2020-04-15 18:14:51 +03:00
Endrik Tombak	bbef94b4df	Reset best order on ruleset change	2020-04-14 18:56:20 +03:00
Endrik Tombak	00d1cf1ce2	Recommend from all rulesets	2020-04-14 18:42:18 +03:00
Endrik Tombak	dd6c9173da	Move DifficultyRecommender to OsuGameBase	2020-04-14 18:42:00 +03:00
Endrik Tombak	b475316a4e	Simplify and comment	2020-04-12 20:40:08 +03:00
Endrik Tombak	63a1686dfb	Scroll to screen middle	2020-04-12 12:42:52 +03:00
Dean Herbert	73a3f1fe65	Remove unnecessary DI	2020-04-11 17:30:34 +09:00
Dean Herbert	7aac0e59a8	Reduce dictionary lookups	2020-04-11 17:13:35 +09:00
Dean Herbert	310cf830d4	Simplify api request logic	2020-04-11 17:13:35 +09:00
Dean Herbert	abea7b5299	Tidy up function passing, naming, ordering etc.	2020-04-11 17:13:35 +09:00
Dean Herbert	7f753f6b4d	Remove current ruleset from function call	2020-04-11 16:43:09 +09:00