1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-07 22:27:25 +08:00
Commit Graph

7234 Commits

Author SHA1 Message Date
Dean Herbert
d0b8409de5 Apply more renames 2022-09-18 18:19:00 +09:00
Drison64
c075d3de08 Create a test and a check if initial zoom value of ZoomableScrollContainer is in range 2022-09-17 22:43:40 +02:00
Dean Herbert
41e69fbca6 Remove "default" prefix from naming 2022-09-18 00:15:26 +09:00
Dean Herbert
51841988bf Rename references to DefaultSkin to have Triangles suffix 2022-09-17 23:57:25 +09:00
Dean Herbert
4c4fdfd153 Provide scores directly to Player instance rather than relying on DI 2022-09-16 18:15:17 +09:00
Dean Herbert
0ff4e343f8 Add failing test showing incorrect unread notification count 2022-09-16 16:29:54 +09:00
Dean Herbert
0227eddda1 Merge branch 'master' into gameplay-leaderboards 2022-09-16 15:44:58 +09:00
Dan Balasescu
fcba917419
Merge pull request #20320 from peppy/skin-transformers
Allow skin transformers to be created for all skins
2022-09-16 12:58:46 +09:00
Dan Balasescu
f86bbaae30
Merge branch 'master' into mods-effect-displays 2022-09-15 21:17:58 +09:00
Dean Herbert
c7f8f948b9 Rename CreateLegacySkinProvider to CreateSkinTransformer and apply to all skins 2022-09-15 20:18:10 +09:00
Dan Balasescu
96a89f4fca
Merge pull request #20319 from peppy/remove-ef-migration
Remove all entity framework code and migrations
2022-09-15 19:15:23 +09:00
Dean Herbert
ea513c539b
Merge pull request #20303 from peppy/hitobject-entry-nesting-stoled
Fix editor performance drop over time due to lingering nested object references
2022-09-15 17:15:01 +09:00
Dean Herbert
40a60f7145 Remove all entity framework code and migrations 2022-09-15 16:58:58 +09:00
Dan Balasescu
0329601e84 Fix inspection 2022-09-15 16:09:27 +09:00
Salman Ahmed
9824d09d49 Add test coverage 2022-09-15 04:30:09 +03:00
Dan Balasescu
ef6d60ffe9
Merge pull request #20273 from frenzibyte/duplicate-beatmap-listing-cards
Fix beatmap listing potentially showing duplicate beatmap cards
2022-09-14 10:25:24 +09:00
Dan Balasescu
4a49433e2e
Merge branch 'master' into notification-fling-right 2022-09-13 20:01:56 +09:00
Dean Herbert
566a61e770
Merge pull request #20244 from peppy/notification-fling
Add ability to "fling" notifications to dismiss them
2022-09-13 19:50:34 +09:00
Dean Herbert
6d167070f8 Add back DI leaderboard retrieval via bindable pathway 2022-09-13 18:45:11 +09:00
Dean Herbert
d2b80645ab Change Leaderboard to use IUser instead of APIUser 2022-09-13 18:00:21 +09:00
Salman Ahmed
fed9a47866 Add test coverage 2022-09-13 18:00:21 +09:00
Dean Herbert
27a81dfb9f
Merge pull request #20270 from OliBomby/fix-selectionblueprint-order
Fixed HitObjectOrderedSelectionContainer being able to become unsorted and causing crashes
2022-09-13 17:18:58 +09:00
Dan Balasescu
53ac9dbc38
Merge branch 'master' into notification-fling 2022-09-13 17:07:16 +09:00
Dean Herbert
608c893b23 Add basic test guarantees 2022-09-13 15:03:13 +09:00
Salman Ahmed
a6f68e4a90 Fix NRT inspections 2022-09-13 03:08:13 +03:00
OliBomby
a1f4724685 moved the location of the tests 2022-09-13 01:38:29 +02:00
Salman Ahmed
a5b962d9a3 Add failing test case 2022-09-13 01:37:23 +03:00
Dean Herbert
88107108ee Add ability to flick notifications to the right to store for later 2022-09-12 20:20:57 +09:00
Dean Herbert
802c5629c0
Merge branch 'master' into notification-fling 2022-09-12 20:09:21 +09:00
Dean Herbert
cb6d02ec3a
Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset
Remove the nullable disable annotation in the ruleset class
2022-09-12 19:07:23 +09:00
Dean Herbert
f56f6545c0 Add test coverage of flinging 2022-09-12 19:06:09 +09:00
Dean Herbert
c064853751 Merge branch 'master' into notification-fling 2022-09-12 18:56:15 +09:00
Dan Balasescu
4b37330316
Merge pull request #20248 from acid-chicken/fix/stats/td
Fix new hit distribution graph didn't account for size changes
2022-09-12 18:11:18 +09:00
Dan Balasescu
bcbc867694
Merge branch 'master' into mods-effect-displays 2022-09-12 16:35:28 +09:00
Dean Herbert
931049aec1 Merge branch 'master' into notification-dismiss 2022-09-12 16:27:41 +09:00
Dan Balasescu
31225066a1
Merge pull request #19308 from frenzibyte/top-rank-badge-order
Fix best rank badge not handling legacy scores properly
2022-09-12 16:20:21 +09:00
Dean Herbert
8e6b2796eb Merge branch 'master' into notification-fling 2022-09-12 16:19:36 +09:00
Dean Herbert
92beb6cbe7 Hide notification read light when in a toast state
Also adds test coverage of read state and light.
2022-09-12 15:17:45 +09:00
Dean Herbert
9b31aa6d7a Fix activation not firing with refactors 2022-09-12 15:04:30 +09:00
Dean Herbert
2b79e6b2de Add test coverage of update notification 2022-09-12 14:52:16 +09:00
Acid Chicken (硫酸鶏)
bb3d5bc9f4
test(osu.Game): add slider steps to change the size in timing distribution graph tests 2022-09-12 04:43:15 +09:00
ansel
064fe832c7 Fix test 2022-09-10 23:18:59 +03:00
MK56
8661dc3c93
Merge branch 'ppy:master' into Colour_hit_meter_improved 2022-09-10 21:16:23 +02:00
Mk-56spn
46d9262a60 test naming oversight 2022-09-10 20:38:34 +02:00
Mk-56spn
f6aef73f9e fixed shape bindable not working, test creation, removal of Clear(), adjusted settings names 2022-09-10 20:30:43 +02:00
Dean Herbert
a9094c6b03 Add test coverage of clicking close button to dismiss 2022-09-10 15:18:32 +09:00
Dean Herbert
efe3b1aa7b Allow dismissing notifications without performing action using middle / right click 2022-09-10 15:10:37 +09:00
andy840119
e62999fb16 Merge branch 'master' of https://github.com/ppy/osu into remove-the-nullable-disable-in-the-ruleset
# Conflicts:
#	osu.Game.Rulesets.Catch/CatchRuleset.cs
#	osu.Game.Rulesets.Osu/OsuRuleset.cs
#	osu.Game.Rulesets.Taiko/TaikoRuleset.cs
#	osu.Game/Rulesets/Ruleset.cs
2022-09-10 10:40:12 +08:00
Salman Ahmed
ae53e27e6c Adjust test coverage to read better 2022-09-09 19:39:06 +03:00
Salman Ahmed
dd10a06e3d Merge branch 'master' into top-rank-badge-order 2022-09-09 19:38:44 +03:00
Dean Herbert
8f9df9c7b4
Merge pull request #18642 from Joehuu/fix-play-button-touch
Fix beatmap card play button not working with touch inputs when not hovered
2022-09-09 19:41:05 +09:00
Dean Herbert
7d100c5eec Fix test in line with new expectations 2022-09-09 18:10:10 +09:00
Dean Herbert
e9ce968ae3 Merge branch 'master' into fix-play-button-touch 2022-09-09 18:08:18 +09:00
Dean Herbert
9ec399a25a Remove NRT overrides in new tests 2022-09-09 17:49:31 +09:00
Dean Herbert
68d1b7d7cf Reduce test count 2022-09-09 17:48:51 +09:00
Dean Herbert
27f745b980
Merge branch 'master' into fix_progress_bar_info 2022-09-09 17:34:13 +09:00
Mk-56spn
5852a09003 small fix 2022-09-09 08:21:33 +02:00
Dean Herbert
c6c59f050c
Merge pull request #20195 from cdwcgt/SkinEditorShortcut
Add arrow shortcuts to skin editor
2022-09-09 14:17:08 +09:00
Dan Balasescu
ba2ef424d4 Turn score ids into ulongs 2022-09-09 11:46:06 +09:00
Dan Balasescu
28477f3b97 Fix inspection 2022-09-09 08:55:35 +09:00
Mk-56spn
38ccd06d5e Test fix 2022-09-08 20:42:55 +02:00
Dean Herbert
f1fa442287
Merge pull request #19599 from ItsShamed/kps
Add clicks/second counter to HUD
2022-09-09 01:50:12 +09:00
cdwcgt
2e775e6886
Add test for object move 2022-09-08 23:47:55 +08:00
Dean Herbert
27aa3552dc Update in line with TrueGameplayRate changes 2022-09-09 00:00:08 +09:00
Dean Herbert
6945c43e0d
Merge pull request #20178 from smoogipoo/fix-match-creation-beatmap-select
Fix several weird scenarios with online play song selection
2022-09-08 23:07:09 +09:00
Dean Herbert
d4afc3629c
Merge branch 'master' into kps 2022-09-08 23:00:36 +09:00
Dan Balasescu
3c8ee1a20a
Merge pull request #20179 from peppy/update-framework
Update framework
2022-09-08 22:14:16 +09:00
Dan Balasescu
9aab502adc
Merge pull request #20157 from peppy/true-gameplay-rate
Refactor `TrueGameplayRate` to account for only gameplay adjustments, no matter what
2022-09-08 19:54:32 +09:00
Dan Balasescu
a90ca94a18 Remove outdated tests 2022-09-08 19:51:28 +09:00
Dan Balasescu
4fc03998a1
Merge pull request #20189 from peppy/fix-playlist-item-download-button-visibility
Fix playlist items showing download button briefly during initial display
2022-09-08 19:47:35 +09:00
Dan Balasescu
c585f08a3b Fix still inverted condition 2022-09-08 19:42:09 +09:00
Dean Herbert
15a4eb46c4 Rename test scene to match class name 2022-09-08 19:20:26 +09:00
Dean Herbert
096d1c3ff3
Merge pull request #20143 from acid-chicken/feat/stats/colored-td
Show judgement colours in hit distribution graph
2022-09-08 19:15:40 +09:00
Dean Herbert
13d9b2188b
Merge pull request #20145 from smoogipoo/multiple-countdowns
Implement support for multiple active countdowns in multiplayer
2022-09-08 19:15:30 +09:00
Dean Herbert
ee094e3a85 Rewrite tests 2022-09-08 19:05:13 +09:00
Dean Herbert
ed81297611 Fix playlist items showing download button briefly during initial local presence checks 2022-09-08 17:10:45 +09:00
Dean Herbert
7b079c134e Update test to actually test what was intended 2022-09-08 15:48:04 +09:00
Dean Herbert
3d9bf25c8a Apply NRT to TestScenePlaySongSelect
Very mess.
2022-09-08 14:49:57 +09:00
Dean Herbert
6aac0bd4e9 Update test to account for the fact that SSDQ is not zero anymore 2022-09-08 13:43:37 +09:00
Dan Balasescu
208bd0f391 Give OnlinePlaySongSelect a reference PlaylistItem 2022-09-07 21:34:29 +09:00
Dean Herbert
6a03b4e0de
Merge branch 'master' into true-gameplay-rate 2022-09-07 20:01:03 +09:00
Dean Herbert
770c1ade2f Add test coverage of track rate adjusting during multi spectator 2022-09-07 20:00:24 +09:00
Dan Balasescu
f8e37af2e0
Merge pull request #20171 from peppy/beatmap-carousel-nrt
Fix missing null checks on `selectedBeatmap` fields in `BeatmapCarousel`
2022-09-07 17:15:00 +09:00
Dan Balasescu
264c9bfaf6
Merge pull request #20173 from peppy/test-scene-storyboard-tidy
Tidy up `TestSceneStoryboard`
2022-09-07 17:07:19 +09:00
Dean Herbert
cb1bb99208 Tidy up test logic 2022-09-07 16:43:48 +09:00
Dean Herbert
b50116e9e4 Add missing null check in BeatmapCarousel tests 2022-09-07 16:22:11 +09:00
Dean Herbert
258b8f015c Add test coverage of storyboard using zero VectorScale 2022-09-07 15:39:19 +09:00
Dean Herbert
866bc553fe Tidy up TestSceneStoryboard 2022-09-07 15:38:49 +09:00
Dan Balasescu
dc71abdf56
Merge pull request #20144 from peppy/fix-notification-overlay-presence
Fix completion toasts sometimes not displaying
2022-09-07 14:55:33 +09:00
Acid Chicken (硫酸鶏)
3003fc1061
refactor(osu.Game): improve code quality 2022-09-07 02:29:15 +09:00
Salman Ahmed
90207b6032
Merge branch 'master' into feature/EditorDeleteDiff 2022-09-06 18:48:06 +03:00
Dean Herbert
c2107bd322 Fix test failures due to notifications being forwarded before player finishes loading 2022-09-06 23:36:27 +09:00
Dean Herbert
bc1212f4e6 Change NonGameplayAdjustments to GameplayAdjustments and convert TrueGameplayRate to extension method 2022-09-06 22:26:46 +09:00
Dean Herbert
579e7e1f17 Fix deleting a difficulty not updating the beatmap set hash 2022-09-06 18:12:47 +09:00
Dean Herbert
9f2ea54e40 Tidy up TestSceneLeadIn constant for loop offset to read better 2022-09-06 17:45:53 +09:00
Mk-56spn
cfa1ebd0cb Test fix 2022-09-06 03:00:13 +02:00
Dean Herbert
9e3228aa65 Fix completion notification not being posted if completion occurs during NotificationOverlay load 2022-09-06 04:07:49 +09:00
Dean Herbert
0514c96191 Fix incorrect count tracking when notification is manually disposed 2022-09-05 19:26:40 +09:00
Dean Herbert
229e1a8ef7 Fix notification overlay being present when it doesn't need to 2022-09-05 19:13:58 +09:00
Dan Balasescu
2923c10cd8 Rewrite rooms to store multiple active countdowns
Update test to the new structure
2022-09-05 19:03:26 +09:00
Dean Herbert
56886fed09 Add test coverage of progress notification completions showing 2022-09-05 18:39:11 +09:00
Acid Chicken (硫酸鶏)
6946015d17
style(osu.Game): fix multiple blank lines 2022-09-05 07:49:29 +00:00
Mk-56spn
aace334fb3 Fix some test issues 2022-09-05 04:49:48 +02:00
Acid Chicken (硫酸鶏)
19ab1433c6
test(osu.Game): add more test cases for HitTimingDistributionGraph 2022-09-05 03:46:23 +09:00
Dean Herbert
bc5340e33a
Merge branch 'master' into fix_progress_bar_info 2022-09-02 18:00:35 +09:00
Dean Herbert
dc02b59a05 Add extra coverage to tests
Also fixes a potential failure due to test beatmap having two difficulties with same name.
2022-09-02 17:57:20 +09:00
HiddenNode
7a8fa5c2e4 Fix filenames mismatch 2022-09-02 09:56:00 +01:00
Dean Herbert
65baf73d97 Add test scene 2022-09-02 16:50:28 +09:00
Dean Herbert
6a35b233e5 Merge branch 'master' into remove-dispose-updates 2022-09-01 23:03:19 +09:00
Dean Herbert
148e487c02 Add failing test of date submitted search failing 2022-09-01 19:59:27 +09:00
HiddenNode
921a9ef895 clean up 2022-08-31 22:18:52 +01:00
HiddenNode
a548b28158 Added test scene for SizePreservingSpriteText 2022-08-31 22:05:46 +01:00
Dean Herbert
ba20044af4 Fix missing nullability consideraition 2022-08-31 23:24:39 +09:00
Dan Balasescu
6cadcc206b
Merge pull request #20032 from peppy/toast-notification-tray
Add toast notification tray
2022-08-31 16:57:37 +09:00
Dan Balasescu
000412c50f
Merge pull request #20014 from peppy/fix-resume-skip-forward
Fix gameplay skipping forward during resume operation
2022-08-31 16:30:37 +09:00
Dan Balasescu
afe2862df4
Merge branch 'master' into toast-notification-tray 2022-08-31 16:07:11 +09:00
Dan Balasescu
e984dc4a19
Merge pull request #20042 from peppy/fix-composer-test-scenes
Test editor `ComposeScreen` tests not adding beatmap to hierarchy
2022-08-31 15:59:48 +09:00
Dean Herbert
7337d4c1aa Merge branch 'master' into kps 2022-08-31 15:41:42 +09:00
Dean Herbert
e9463f3c19 Test editor ComposeScreen tests not adding beatmap to hierarchy
Makes it hard to test anything because `EditorBeatmap`'s `Update` method
updates whether a beatmap has timing or not (enabling the placement
controls).

Also adds a basic timing point to allow for better testing.
2022-08-31 14:07:56 +09:00
Dean Herbert
7ce1cf7560 Add test coverage of skip button failure with equal time 2022-08-31 13:22:51 +09:00
Dean Herbert
c573396ab6 Fix IntroTestScene not clearing previous notifications hard enough 2022-08-31 12:46:54 +09:00
Dean Herbert
3d93e0ded1
Merge branch 'master' into fix-resume-skip-forward 2022-08-31 12:16:15 +09:00
Dean Herbert
9eb615f942 Fix remaining test failures by strengthening PlayerLoader tests
- Click using `TriggerClick` as notifications move around quite a bit.
- Ensure any notifications from a previous test method are cleaned up.
2022-08-31 01:40:30 +09:00
Dean Herbert
31a9980686 Update remaining test expectations with new behaviour 2022-08-31 00:57:30 +09:00
Dean Herbert
a62ba9e0d9 Remove notification blocking behaviour of first run setup 2022-08-31 00:57:18 +09:00
Dean Herbert
b8fda1a16f Apply NRT to notification classes
and tidy things up a bit.
2022-08-30 15:57:10 +09:00
Dan Balasescu
8b3742188f Fix test by also clearing out maximum statistics 2022-08-30 15:42:36 +09:00
HiddenNode
43f2ba6596 Added test scene 2022-08-29 22:00:33 +01:00
HiddenNode
d20e7da2d9 Changed epsilon 2022-08-29 21:03:22 +01:00
ansel
545e0bbcef Adjust inheritors and test 2022-08-29 22:49:25 +03:00
Dean Herbert
062a6fcc18 Fix failing large offset test
If we are going to continue to let the underlying clock process frames,
there needs to be a bit of lenience to allow the backwards seek on
resume (to play back over the freq ramp period).

The test is meant to be ensuring we don't skip the full offset amount,
so div10 seems pretty safe.
2022-08-30 01:21:55 +09:00
Dan Balasescu
0491addbbd
Merge pull request #19974 from peppy/no-gameplay-clock-editor-offset
Fix editor not applying offsets
2022-08-29 21:10:29 +09:00
Dean Herbert
82b9e1f0eb
Merge pull request #20011 from smoogipoo/scoring-refactor
Refactor scoring to remove async methods / simplify
2022-08-29 19:55:27 +09:00
Dean Herbert
ad5ef52922 Add test coverage of resuming after pause not skipping forward in time 2022-08-29 19:02:01 +09:00
Salman Ahmed
f2378d3fde
Merge branch 'master' into carousel-maintain-selection-over-update 2022-08-29 11:23:22 +03:00
Dean Herbert
2dafa041a7 Account for offset being applied to editor clock time in TestSceneEditorClock 2022-08-29 16:42:50 +09:00
Dean Herbert
a215d009fe Update Remove/RemoveRange/RemoveAll calls in line with framework changes 2022-08-29 15:57:40 +09:00
Dan Balasescu
423f6f90f2 Remove async calls from ScoreManager 2022-08-29 15:34:08 +09:00
Dean Herbert
e8ae6840ea Add test coverage of selection being retained 2022-08-29 15:23:34 +09:00
HiddenNode
d4a52baa56 Added visual test for UprightAspectMaintainingContainer 2022-08-29 00:07:42 +01:00
ansel
2a12194ff9 Test colours 2022-08-28 02:59:38 +03:00
ansel
90334a2b91 Add test scene 2022-08-27 20:12:45 +03:00
Dan Balasescu
289b6f1a58
Merge pull request #19924 from peppy/fix-playlist-overlay-test-failures
Fix intermittent test failures in `TestScenePlaylistOverlay`
2022-08-26 23:36:16 +09:00
Salman Ahmed
1fd1672d89
Merge branch 'master' into mod-validation-tests 2022-08-26 15:00:07 +03:00
Dean Herbert
6dc859973b
Merge branch 'master' into fix-playlist-overlay-test-failures 2022-08-26 20:25:53 +09:00
Dean Herbert
5ef8e26ebe Fix check not accounting for mods not existing in certain rulesets
Also check all instances, rather than first.
2022-08-26 19:59:26 +09:00
Dean Herbert
580754833f Merge branch 'master' into mod-validation-tests 2022-08-26 19:48:42 +09:00
Dean Herbert
9c9238d6e8 Fix TimelineTestScene's beatmap getting overwritten by EditorClockTestScene 2022-08-26 18:38:52 +09:00
Dean Herbert
4b72e55770 Fix various test scenes not adding EditorClock to the draw hierarchy 2022-08-26 18:08:43 +09:00
Dean Herbert
9050f54681 Split out test assertion methods to read better 2022-08-26 16:56:03 +09:00