1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-19 13:52:54 +08:00
Commit Graph

3273 Commits

Author SHA1 Message Date
Dean Herbert
3b0e3cd71a Remove using statements 2020-03-06 17:55:57 +09:00
Dean Herbert
40074f10db Remove unnecessary override 2020-03-06 17:55:05 +09:00
Dean Herbert
90dbb90470 Merge branch 'master' into disable-keycounter-breaks 2020-03-06 17:53:10 +09:00
Dan Balasescu
aafdfbca1f
Merge pull request #8129 from peppy/fix-dummy-track-completion-feedback
Fix DummyWorkingBeatmap's track completion attempting to change game-wide beatmap
2020-03-05 17:57:57 +09:00
smoogipoo
0c1775b522 Fix incorrect condition and add test 2020-03-05 17:12:14 +09:00
Dan Balasescu
f7777ecb01
Merge pull request #8142 from peppy/add-star-difficulty-max-migration
Fix song select max displayable star difficulty getting stuck at wrong maximum
2020-03-05 17:10:10 +09:00
Dean Herbert
646c8fe077 Add note about version override 2020-03-05 15:40:48 +09:00
Dean Herbert
a311ace626 Add migration test 2020-03-05 15:07:00 +09:00
Dean Herbert
5200633f9f Centralise TestPlayer implementations as much as possible 2020-03-05 11:25:07 +09:00
Andrei Zavatski
bf9e289f3a Merge master with conflicts resolved 2020-03-05 04:11:12 +03:00
Bartłomiej Dach
b8889318db Pass rulesets to solo game status 2020-03-04 22:13:31 +01:00
Bartłomiej Dach
afa3ce494d Set online status in activity test
The test would check nothing otherwise.
2020-03-04 22:07:02 +01:00
Bartłomiej Dach
5fa2638e81 Rename tests to adhere to convention 2020-03-04 22:05:48 +01:00
Bartłomiej Dach
1bd49d50c7 Remove unnecessary raw string prefixes 2020-03-04 22:05:08 +01:00
Bartłomiej Dach
5b25b5dfab Change brace style 2020-03-04 22:04:49 +01:00
Bartłomiej Dach
e3e66991b0 Move initialisation logic to [SetUp] 2020-03-04 22:02:36 +01:00
Andrei Zavatski
bd03dd9b70 Adjust class naming 2020-03-04 23:08:58 +03:00
Andrei Zavatski
6631b07442 Refactor to replace existing panels 2020-03-04 14:58:15 +03:00
Andrei Zavatski
8a437e1b54 Add ability to send pm via context menu 2020-03-04 12:42:21 +03:00
Andrei Zavatski
15e47d8432 Implement layout for UserGridCard 2020-03-04 12:20:49 +03:00
Andrei Zavatski
6ea3af1951 Implement layout for UserListCard 2020-03-04 10:35:43 +03:00
Andrei Zavatski
b7d34b399d Adjust background presentation for UserListCard 2020-03-04 09:10:51 +03:00
Andrei Zavatski
1b5222f396 Baisc UserListCard implementation 2020-03-04 08:53:14 +03:00
Andrei Zavatski
f425233527 Basic UserCard implementation 2020-03-04 08:41:21 +03:00
Andrei Zavatski
4d5445b5dc Rename Amount to Count 2020-03-04 00:31:06 +03:00
Andrei Zavatski
06b23b626e Simplify test scene setup 2020-03-04 00:15:10 +03:00
Andrei Zavatski
83dad93b6d Make Populate() accept list of users 2020-03-03 18:08:51 +03:00
Andrei Zavatski
160d64eecf FriendsOnlineStatusControl basic implementation 2020-03-03 17:37:01 +03:00
Andrei Zavatski
937d9da43b Implement OverlayUpdateStreamControl component 2020-03-03 17:01:58 +03:00
Andrei Zavatski
8dcdd6db6f Rename UpdateStream components to ChangelogUpdateStream 2020-03-03 16:20:36 +03:00
naoey
3d344a076d
Add test for disabled keycounter, don't discard change event values 2020-03-03 06:17:25 +05:30
naoey
1ce972dd5b
Remove unused variable 2020-02-29 21:53:49 +05:30
naoey
bca58ddb42
Make KeyCounter stop counting during breaks 2020-02-29 21:18:43 +05:30
Andrei Zavatski
54d83eff94 Use OverlayColourProfider for VotePill component 2020-02-26 19:35:20 +03:00
Dan Balasescu
37e9c2a683
Merge branch 'master' into user-list-toolbar 2020-02-26 10:11:21 +09:00
Dan Balasescu
ff063b229b
Merge pull request #7973 from peppy/fix-dho-lifetimes-via-judgements
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
2020-02-25 20:38:29 +09:00
Dean Herbert
61af80c1af
Merge pull request #7982 from EVAST9919/comments-crash-fix
Fix potential crash when clicking on show more button in comments
2020-02-25 20:14:58 +09:00
Dean Herbert
29e2e17144 Merge branch 'master' into fix-dho-lifetimes-via-judgements 2020-02-25 19:07:57 +09:00
Dean Herbert
a047456354 Revert changes to make HitObject abstract 2020-02-25 19:07:15 +09:00
Andrei Zavatski
c1455be855 Add tests 2020-02-25 10:29:03 +03:00
Andrei Zavatski
7bc9a9b3d8 Implement OverlayPanelDisplayStyleControl and UserListToolbar components 2020-02-24 07:28:33 +03:00
Andrei Zavatski
0cfe1ac823 Implement UserSortTabControl component 2020-02-24 05:47:21 +03:00
Dean Herbert
ffc7eaa3f2 Fix hitobjects with unknown lifetimes by enforcing non-null judgement
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
Dean Herbert
e8ebb31517 Expire old judgement lines if too many exist 2020-02-23 03:53:51 +09:00
Bartłomiej Dach
a512226036 Use attribute instead of CreateChildDependencies 2020-02-22 13:47:42 +01:00
Bartłomiej Dach
f248c0a98e Fix regressed direct panel test scene
Due to unnoticed past changes TestSceneDirectPanel has regressed in that
clicking the preview track button would crash due to an unregistered
IPreviewTrackOwner dependency.

Make the test scene itself implement that empty interface and cache
itself as IPreviewTrackOwner so that preview tracks lower down can
resolve the dependency.

As the test is purely visual and has no assertions, and the important
logic in that area (preview track playing logic) is already well-covered
enough elsewhere, no further changes were made.
2020-02-22 00:58:33 +01:00
Dean Herbert
db1e5abad7
Merge pull request #7786 from EVAST9919/subcomments-alter-new
Add ability to load long comment trees in CommentsContainer
2020-02-21 21:18:33 +09:00
smoogipoo
41c6d2f2e7 Merge remote-tracking branch 'origin/master' into subcomments-alter-new 2020-02-21 17:02:58 +09:00
Dean Herbert
7d145a7470 Add test for loading spinner with box 2020-02-21 16:21:44 +09:00
Dean Herbert
bbac95958c Fix incorrect test scene name 2020-02-21 16:20:55 +09:00
Dean Herbert
38d9a46ffb Add test for relative sizing scenarios 2020-02-21 16:20:17 +09:00
Dean Herbert
92f6f0207c Rename LoadingAnimation to LoadingSpinner 2020-02-21 15:33:31 +09:00
Dean Herbert
623b78d675 Combine all loading animation implementations 2020-02-21 15:32:46 +09:00
smoogipoo
2cb218c9c4 Merge remote-tracking branch 'origin/master' into comment-editor 2020-02-21 12:27:34 +09:00
Dean Herbert
cd666166d5
Merge pull request #7809 from voidedWarranties/proposal-difficulty-icon-select
Allow selecting/playing a specific difficulty using the beatmapset difficulty icons
2020-02-21 10:24:12 +09:00
Dean Herbert
3380dbbd71 Improve visual appearance of ProcessingOverlay 2020-02-20 19:49:22 +09:00
Dean Herbert
927115a085
Merge branch 'master' into room-inspector-redesign 2020-02-20 17:41:16 +09:00
Dean Herbert
e48166858c
Merge branch 'master' into overlined-display-refactor 2020-02-20 17:38:04 +09:00
Dean Herbert
5c16dbbea9
Merge pull request #7919 from smoogipoo/null-leaderboard-position
Support null leaderboard position
2020-02-20 16:27:24 +09:00
smoogipoo
d79ca97fe9 Make beatmap scores also support null position 2020-02-20 15:04:12 +09:00
Dan Balasescu
eb8a56055f
Merge pull request #7910 from EVAST9919/rankings-clickable-countries
Make country names in RankingsOverlay clickable
2020-02-20 15:00:01 +09:00
smoogipoo
1a689231c2 Support null leaderboard position 2020-02-20 14:51:25 +09:00
smoogipoo
177935d644 Remove unused using 2020-02-20 14:45:35 +09:00
Dean Herbert
0cf0099fd5
Merge pull request #7917 from smoogipoo/fix-drawableroom-async-test
Fix possible test failures due to async loads
2020-02-20 14:37:51 +09:00
smoogipoo
c5fd969568 Fix 0 size in test scene 2020-02-20 14:33:13 +09:00
Dan Balasescu
bf5c34a014
Merge branch 'master' into rankings-clickable-countries 2020-02-20 14:21:44 +09:00
smoogipoo
b2d9004212 Fix possible test failures due to async loads 2020-02-20 08:37:23 +09:00
Andrei Zavatski
8fcfb73d72 Implement BeatmapListingOverlay 2020-02-19 17:40:54 +03:00
Andrei Zavatski
1417c90173 Remove redundant blank line 2020-02-19 17:24:44 +03:00
Andrei Zavatski
a79398ddbd Fix incorrect caching in TestSceneRankingsOverlay 2020-02-19 17:09:22 +03:00
smoogipoo
ac416ae743 Implement new room inspector redesign 2020-02-19 17:47:59 +09:00
smoogipoo
ec73e8f0c7 Allow different sizing modes for OverlinedParticipants 2020-02-19 17:40:38 +09:00
smoogipoo
e3d37b808d Move overlined displays to a higher namespace 2020-02-19 17:33:09 +09:00
Andrei Zavatski
37003e11b9 Make fields readonly 2020-02-18 18:04:39 +03:00
Andrei Zavatski
bb22243903 TestScene improvements 2020-02-18 17:47:44 +03:00
Andrei Zavatski
7228900361 Implement BeatmapListingSearchSection component 2020-02-18 17:25:12 +03:00
Andrei Zavatski
3bf3becdd6 Merge remote-tracking branch 'refs/remotes/ppy/master' into subcomments-alter-new 2020-02-18 13:27:08 +03:00
Dean Herbert
b18f9e195e Merge branch 'master' into bindable-list-events 2020-02-18 18:47:06 +09:00
smoogipoo
ee13632375 Fix ogg beatmap/skin samples not loading 2020-02-18 13:21:55 +09:00
Dan Balasescu
75e0668b4e
Merge branch 'master' into new-direct-sort 2020-02-18 10:17:26 +09:00
Andrei Zavatski
410686c8b9 Use dropdown in BeatmapSearchFilterRow 2020-02-18 01:04:25 +03:00
Andrei Zavatski
c69818925b Merge remote-tracking branch 'refs/remotes/ppy/master' into new-betmap-search-filter 2020-02-17 23:35:12 +03:00
Andrei Zavatski
19872d9e24 Simplify test scene 2020-02-17 22:05:10 +03:00
Andrei Zavatski
20dc1a7dcd Merge remote-tracking branch 'refs/remotes/ppy/master' into new-direct-sort 2020-02-17 21:57:19 +03:00
smoogipoo
84ea279c94 Add test 2020-02-17 17:04:58 +09:00
smoogipoo
958c891d15 Update with framework-side bindable list changes 2020-02-17 15:06:14 +09:00
Andrei Zavatski
480e5677ed Use OverlayColourProvider for CounterPill in profile overlay 2020-02-17 04:29:41 +03:00
Andrei Zavatski
d985a22f77 Add missing blank line 2020-02-17 03:52:26 +03:00
Andrei Zavatski
fe7923b7e8 Add SortDirection Bindable and refactor to make everything work 2020-02-17 03:38:14 +03:00
Andrei Zavatski
2ba0bd872b Implement basic BeatmapListingSortTabControl 2020-02-17 02:35:46 +03:00
Andrei Zavatski
a9f366fda3 Implement OverlaySortTabControl component 2020-02-17 02:20:53 +03:00
Andrei Zavatski
ea285fd005 Refactor with including headers 2020-02-17 00:44:55 +03:00
Andrei Zavatski
e62fec58c1 Add ability to override text size 2020-02-16 16:38:05 +03:00
Andrei Zavatski
a71e410e5d Make the filter autosized 2020-02-16 15:04:21 +03:00
Andrei Zavatski
3888911eee Implement BeatmapSearchFilter component 2020-02-16 14:19:49 +03:00
Dean Herbert
80462014d9
Merge pull request #7848 from smoogipoo/fix-match-subscreen-crashes
Replace hashcode override with local equality comparer
2020-02-16 17:01:22 +09:00
Bartłomiej Dach
5a5e3b9410 Merge branch 'master' into align-score-right-content 2020-02-16 06:20:41 +01:00
Bartłomiej Dach
e5a66bdef3 Refactor drawable profile score to match web 2020-02-16 06:16:02 +01:00
voidedWarranties
8c81f1e684 Move CarouselBeatmap access to private, test using indices 2020-02-15 17:51:55 -08:00
Dan Balasescu
268f3333bd
Merge pull request #7841 from peppy/update-inspectcode
Update inspectcode version and fix new issues
2020-02-16 00:53:04 +09:00
smoogipoo
17e3470441 Replace hashcode override with local equality comparer 2020-02-16 00:23:52 +09:00
Bartłomiej Dach
01f9966933 Cover case of incorrect display in test scene 2020-02-15 16:05:15 +01:00
Dean Herbert
19d61c1255 Merge branch 'master' into match-subscreen-redesign 2020-02-15 15:29:33 +09:00
Dean Herbert
da68ae5461 Merge branch 'master' into match-songselect-playlist-logic 2020-02-15 12:27:51 +09:00
Dean Herbert
bb541f5ae4 Update inspectcode version and fix new issues 2020-02-15 11:54:29 +09:00
Dean Herbert
a4215106ff Merge branch 'master' into match-detail-area 2020-02-15 11:46:29 +09:00
Dean Herbert
af8eda2d24
Merge pull request #7829 from smoogipoo/match-playlist
Implement a rearrangeable beatmap playlist control
2020-02-15 11:42:26 +09:00
Dean Herbert
0b90e732a9
Merge branch 'master' into match-playlist 2020-02-15 11:09:17 +09:00
voidedWarranties
8e1ecddb1d Add testing 2020-02-14 17:23:24 -08:00
Andrei Zavatski
7cb11be810 Merge remote-tracking branch 'refs/remotes/ppy/master' into subcomments-alter-new 2020-02-14 20:55:51 +03:00
smoogipoo
61d539dc67 Fix first playlist item not getting selected 2020-02-14 23:39:39 +09:00
smoogipoo
b92f1ad68d Implement match subscreen re-design 2020-02-14 20:48:09 +09:00
smoogipoo
b762e5e8a5 Implement overlined components 2020-02-14 20:42:14 +09:00
smoogipoo
929eb4f035 Add match footer 2020-02-14 20:35:52 +09:00
smoogipoo
d5496321e2 Implement leaderboard chat display 2020-02-14 20:31:55 +09:00
smoogipoo
c75a774297 Extract participants list from the room inspector 2020-02-14 20:27:37 +09:00
smoogipoo
c0dba63278 Remove match info 2020-02-14 20:14:25 +09:00
Dean Herbert
73621e41fd Forcefully hide mute notification for navigation tests 2020-02-14 20:12:23 +09:00
smoogipoo
b0793b06ed Re-implement the match header 2020-02-14 20:10:36 +09:00
smoogipoo
1e80facfe8 Add subscreen test scene 2020-02-14 20:03:37 +09:00
smoogipoo
b5f048ce96 Merge branch 'match-songselect-playlist-logic' into match-subscreen-redesign 2020-02-14 19:59:15 +09:00
smoogipoo
0b86825d71 Merge branch 'match-playlist' into match-songselect-playlist-logic 2020-02-14 19:57:35 +09:00
smoogipoo
f31220c1ee Fix exception when adding duplicate items 2020-02-14 19:56:43 +09:00
Dean Herbert
14f632b532 Merge branch 'master' into match-detail-area 2020-02-14 19:54:17 +09:00
Dean Herbert
e6676ffa51 Merge branch 'match-playlist' into match-detail-area 2020-02-14 19:53:46 +09:00
Dean Herbert
05c48cd929 Fix volume mute tests regressing 2020-02-14 19:27:32 +09:00
Dean Herbert
47325601f4 Add failing test 2020-02-14 19:16:08 +09:00
smoogipoo
fbc5ffbadb Remove now unused members 2020-02-14 17:59:47 +09:00
smoogipoo
de646649de Use test beatmap instead of beatmap manager 2020-02-14 17:59:14 +09:00
smoogipoo
32fd713a9d Use test beatmap instead of beatmap manager 2020-02-14 17:57:25 +09:00
smoogipoo
f0f739707f Add playlist support to match song select 2020-02-14 17:51:42 +09:00
smoogipoo
5ec9f454d5 Implement the match beatmap detail area 2020-02-14 17:20:38 +09:00
smoogipoo
aceba8791c Clean up selection handling 2020-02-14 16:56:44 +09:00
smoogipoo
6a466ea2f5 Improve test cases 2020-02-14 16:48:30 +09:00
smoogipoo
d6768bba62 Make test playlist items unique 2020-02-14 16:09:30 +09:00
smoogipoo
5e871f9838 Make room playlist use the common rearrangeable design 2020-02-14 15:36:47 +09:00
Dean Herbert
b86b5e9adb Move nested class to bottom of file 2020-02-14 15:27:39 +09:00
Dean Herbert
c34f1f40ea Fix test text not being centered 2020-02-14 15:27:09 +09:00
Dean Herbert
aa7efe6141 Fix tests potentially failing due to timing issues 2020-02-14 15:26:55 +09:00
Dean Herbert
76cfe1f42c Merge branch 'master' into online-container 2020-02-14 15:18:27 +09:00
smoogipoo
eb14dbcd77 Initial implementation of rearrangeable playlist 2020-02-14 15:01:45 +09:00
Lucas A
049b0d93d1 Add back default content fade transitions 2020-02-13 21:40:25 +01:00
Bartłomiej Dach
0f25864fae Textbox -> TextBox rename pass 2020-02-13 21:04:53 +01:00
Bartłomiej Dach
5646083ed9 Adjust code style in test 2020-02-13 21:01:25 +01:00
Bartłomiej Dach
09b2e7beed Encapsulate test editors 2020-02-13 20:56:34 +01:00
Bartłomiej Dach
cc625e3b89 Move initialisation logic to [SetUp] 2020-02-13 20:44:02 +01:00
Lucas A
dac0148c94 Apply review suggestions. 2020-02-13 20:08:14 +01:00
Dean Herbert
4a04b434a9
Merge branch 'master' into remove-current-item 2020-02-13 21:41:23 +09:00
Dean Herbert
b9a296d3f9
Merge branch 'master' into remove-current-item 2020-02-13 19:34:15 +09:00
Dean Herbert
28ca1a5bcc
Merge branch 'master' into participants-bindable 2020-02-13 19:31:50 +09:00