Dean Herbert
ac761bb075
Use string.Empty
instead of arbitrary string
2021-06-02 14:43:35 +09:00
Dean Herbert
4759ac098f
Merge pull request #13293 from smoogipoo/update-dependencies
...
Update dependencies
2021-06-02 14:35:06 +09:00
Dean Herbert
4fd8c9c17b
Merge pull request #13284 from ppy/dependabot/nuget/ppy.LocalisationAnalyser-2021.525.0
...
Bump ppy.LocalisationAnalyser from 2021.524.0 to 2021.525.0
2021-06-02 14:34:37 +09:00
Dean Herbert
45984f035b
Make autoplay tests test via the ReplayPlayer
code path
2021-06-02 11:49:06 +09:00
smoogipoo
d3d8941ec8
Make method internal
2021-06-02 11:11:41 +09:00
Dean Herbert
911256603b
Rewrite comment to hopefully be more informative
2021-06-02 11:10:02 +09:00
smoogipoo
8ee2b3a2d2
Merge branch 'master' into fix-scrolling-lifetime
2021-06-02 11:08:28 +09:00
Dan Balasescu
ac83450791
Merge pull request #13256 from ekrctb/update-lifetime-2
...
Update DHO lifetime on entry lifetime change
2021-06-02 11:07:54 +09:00
Dean Herbert
8a76d97b63
Remove replay logic from DrawableRuleset
(and implement in DrawableEditorRulesetWrapper
)
2021-06-02 11:06:30 +09:00
smoogipoo
51e4b6c860
Merge remote-tracking branch 'ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.6' into update-dependencies
2021-06-02 09:21:26 +09:00
smoogipoo
4184cb88f6
Merge remote-tracking branch 'ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.6' into update-dependencies
2021-06-02 09:21:09 +09:00
smoogipoo
dc31e2925c
Merge remote-tracking branch 'ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-5.0.6' into update-dependencies
2021-06-02 09:20:37 +09:00
smoogipoo
e19568c91b
Merge remote-tracking branch 'ppy/dependabot/nuget/Sentry-3.4.0' into update-dependencies
2021-06-02 09:20:33 +09:00
smoogipoo
b0a229da87
Merge remote-tracking branch 'ppy/dependabot/nuget/ppy.LocalisationAnalyser-2021.525.0' into update-dependencies
2021-06-02 09:20:31 +09:00
dependabot[bot]
a758b38278
Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack
...
Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore ) from 5.0.5 to 5.0.6.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.5...v5.0.6 )
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:32 +00:00
dependabot[bot]
a10ef2ba65
Bump Humanizer from 2.8.26 to 2.10.1
...
Bumps [Humanizer](https://github.com/Humanizr/Humanizer ) from 2.8.26 to 2.10.1.
- [Release notes](https://github.com/Humanizr/Humanizer/releases )
- [Changelog](https://github.com/Humanizr/Humanizer/blob/main/release_notes.md )
- [Commits](https://github.com/Humanizr/Humanizer/compare/v2.8.26...v2.10.1 )
---
updated-dependencies:
- dependency-name: Humanizer
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:31 +00:00
dependabot[bot]
deaa381440
Bump Sentry from 3.3.4 to 3.4.0
...
Bumps [Sentry](https://github.com/getsentry/sentry-dotnet ) from 3.3.4 to 3.4.0.
- [Release notes](https://github.com/getsentry/sentry-dotnet/releases )
- [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md )
- [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.3.4...3.4.0 )
---
updated-dependencies:
- dependency-name: Sentry
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:30 +00:00
dependabot[bot]
bd8db2ce63
Bump ppy.LocalisationAnalyser from 2021.524.0 to 2021.525.0
...
Bumps [ppy.LocalisationAnalyser](https://github.com/ppy/osu-localisation-analyser ) from 2021.524.0 to 2021.525.0.
- [Release notes](https://github.com/ppy/osu-localisation-analyser/releases )
- [Commits](https://github.com/ppy/osu-localisation-analyser/compare/2021.524.0...2021.525.0 )
---
updated-dependencies:
- dependency-name: ppy.LocalisationAnalyser
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:28 +00:00
dependabot[bot]
ea9919e8fe
Bump Microsoft.AspNetCore.SignalR.Client from 5.0.5 to 5.0.6
...
Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore ) from 5.0.5 to 5.0.6.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.5...v5.0.6 )
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Client
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:27 +00:00
dependabot[bot]
069baab883
Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
...
Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore ) from 5.0.5 to 5.0.6.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.5...v5.0.6 )
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:27 +00:00
Dean Herbert
92ffc4627f
Update framework
2021-06-01 23:24:49 +09:00
Dean Herbert
f14c0eae99
Fix editor no longer creating autoplay frames
2021-06-01 17:28:41 +09:00
Dean Herbert
3668f1861f
Fix one more null issue
2021-06-01 17:10:09 +09:00
Dean Herbert
289dc00f38
Merge branch 'master' into autoplay-pause-support
2021-06-01 16:50:44 +09:00
Dean Herbert
145e42928b
Fix remaining null checks
2021-06-01 16:49:05 +09:00
Dean Herbert
1f8abcdf6c
Merge branch 'master' into fix-relative-link-resolution
2021-06-01 16:49:02 +09:00
Dean Herbert
6e861a9b7f
Revert incorrect ScoreProcessor
change
2021-06-01 16:39:50 +09:00
Dean Herbert
790f1dacc9
Ensure ScoreProcessor
is still hooked up in special case
2021-06-01 16:24:38 +09:00
Salman Ahmed
7c6400735f
Merge branch 'master' into remove-hud-component-lookup
2021-06-01 10:17:52 +03:00
Salman Ahmed
c090110ae2
Provide cell skin on content creation
2021-06-01 10:16:13 +03:00
Gagah Pangeran Rosfatiputra
b4dd935538
add corner radius and padding
2021-06-01 14:14:12 +07:00
Gagah Pangeran Rosfatiputra
5108dadfbc
use inline code in markdown text flow
2021-06-01 14:03:57 +07:00
Gagah Pangeran Rosfatiputra
1babb05fc7
add OsuMarkdownInlineCode
2021-06-01 14:03:31 +07:00
Dean Herbert
3ba0d29108
Fix incorrect beatmap being parsed down for autoplay generation
2021-06-01 15:44:24 +09:00
Dean Herbert
240f7facba
Add local concessions for autoplay test handling
2021-06-01 15:39:02 +09:00
Dean Herbert
dce24e3d4d
Merge pull request #12950 from gagahpangeran/osu-wiki-overlay
...
Initial implementation of Wiki Overlay
2021-06-01 15:20:56 +09:00
ekrctb
40949f6c1b
Simplify lifetime setter
...
Setting entry lifetime will cause `LifetimeChanged` event and `base.LifetimeStart`/`End` will be modified in the callback.
2021-06-01 14:46:43 +09:00
ekrctb
0f381f7758
Fix wrong code
2021-06-01 14:38:02 +09:00
Dean Herbert
6ef9b346e1
Fix newly found inspections from 2021.1EAP1
2021-06-01 14:33:21 +09:00
ekrctb
86020adf64
Revert invalid code transformation
2021-06-01 14:28:23 +09:00
Dean Herbert
cbf3ef5400
Create replay via the ICreateReplay
interface instead of explicitly ModAutoplay
2021-06-01 14:22:16 +09:00
Dean Herbert
9221213fe5
Fix potential nullref is beatmap load failed
2021-06-01 14:19:23 +09:00
Dean Herbert
14570b6fb1
Merge branch 'master' into autoplay-pause-support
2021-06-01 14:19:21 +09:00
Dean Herbert
a9f4bc6285
Never return a null argument
...
Enable nullable
2021-06-01 14:11:17 +09:00
Dean Herbert
27b7039520
Use constant
2021-06-01 14:02:32 +09:00
Dean Herbert
6e4730652e
Push private methods down
2021-06-01 14:01:08 +09:00
Dean Herbert
3ff97f787a
Localise all URL generation for now to avoid weird Schedule
logic
2021-06-01 13:56:59 +09:00
Dean Herbert
111bfd4d88
Fix relative URLs having a null argument after resolution to LinkDetails
2021-06-01 13:50:20 +09:00
ekrctb
d5714e63b9
Apply code styling suggestions
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-06-01 13:17:30 +09:00
ekrctb
86d1ba7ef2
Remove unused IScrollingHitObject
interface
2021-05-31 23:17:26 +09:00
Dan Balasescu
bd7814b487
Merge pull request #13257 from ekrctb/simplify-shoc
...
Multiple `ScrollingHitObjectContainer` logic simplification
2021-05-31 21:31:10 +09:00
ekrctb
ff04942295
Change timing of HitObjectContainer.OnAdd
/OnRemove
...
Now, `OnAdd` is always invoked after the DHO is added to the container.
This change is required by `ScrollingHitObjectContainer` to compute origin adjusted lifetime when origin position is relative to the parent drawable size.
2021-05-31 20:56:25 +09:00
Dan Balasescu
9036b13637
Merge pull request #13260 from peppy/legacy-skin-resource-improvements
...
Allow `LegacyDefaultSkin` to be constructed without extra resource store parameter
2021-05-31 20:49:21 +09:00
Dean Herbert
f60e9cb085
Remove weird override logic in TestCase
methods
2021-05-31 20:00:47 +09:00
Dean Herbert
e78391db7a
Fix usage of DI before it's ready in combo colour tests
2021-05-31 19:58:19 +09:00
Dean Herbert
17fa2426d4
Merge branch 'master' into legacy-skin-resource-improvements
2021-05-31 19:36:09 +09:00
Dean Herbert
ebfc24a499
Rename conflicting resources
2021-05-31 19:14:49 +09:00
Dean Herbert
65709ec7d7
Move leagcy resource store construction local to DefaultLegacySkin
2021-05-31 19:14:49 +09:00
Dan Balasescu
46b6f49a92
Merge pull request #13230 from peppy/non-nullable-beatmapset-files
...
Make `BeatmapSet.Files` non-nullable
2021-05-31 19:10:03 +09:00
Dean Herbert
d1ef5483bc
Merge pull request #12826 from frenzibyte/catch-hide-combo-workaround
...
Hide legacy HUD combo counters on osu!catch ruleset
2021-05-31 19:04:25 +09:00
Dean Herbert
b16d10bd95
Provide game-wide resources via IStorageResourceProvider
2021-05-31 18:57:47 +09:00
Dean Herbert
675fe37446
Change check order around to ensure re-fetches which return no results don't nullref
2021-05-31 18:35:18 +09:00
Dean Herbert
d4cb70735d
Merge branch 'master' into non-nullable-beatmapset-files
2021-05-31 18:19:57 +09:00
Dan Balasescu
d8768a8c01
Merge pull request #13254 from peppy/fix-editor-beatmap-creation-test-failure-again
...
Fix bindable lease failure in editor beatmap creation tests
2021-05-31 17:38:19 +09:00
ekrctb
948a14a627
Merge branch 'simplify-shoc' into fix-scrolling-lifetime
...
# Conflicts:
# osu.Game/Rulesets/UI/Scrolling/ScrollingHitObjectContainer.cs
2021-05-31 16:50:47 +09:00
ekrctb
86d1225aad
Reset lifetime to initial lifetime when layout is invalidated
2021-05-31 16:47:10 +09:00
ekrctb
6d96846776
Remove scrollLength
caching field
...
It was not clear when the field is updated.
2021-05-31 16:28:02 +09:00
ekrctb
742c5b442b
Remove delay of lifetime update
...
The scheduling is no longer necessary because `OnAdd` is changed to not invoked immediately for non-pooled DHOs.
2021-05-31 16:24:13 +09:00
ekrctb
3cedc0824d
Don't add nested hit objects to the sets
...
Only top-level hit objects are checked for layout computation caching.
Also, lifetime of nested hit objects are not managed by the HitObjectContainer.
2021-05-31 16:20:35 +09:00
ekrctb
56a0a24cba
Make SetInitialLifetime public
2021-05-31 15:33:28 +09:00
Salman Ahmed
4e186b0cf5
ContentVisible
-> HiddenByRulesetImplementation
2021-05-31 09:24:26 +03:00
Salman Ahmed
02d18c7a49
Merge branch 'master' into remove-hud-component-lookup
2021-05-31 09:23:04 +03:00
ekrctb
e25cca6fbe
Update drawable lifetime on entry lifetime change
2021-05-31 14:45:29 +09:00
Dan Balasescu
8c6277f0d8
Merge pull request #13235 from ekrctb/update-lifetime-1
...
Update hit object lifetime on `HitObject.DefaultsApplied`
2021-05-31 14:44:40 +09:00
Dean Herbert
5925beaf21
Fix bindable lease failure in editor beatmap creation tests
2021-05-31 14:24:46 +09:00
Dean Herbert
06bd696cc2
Remove previous
consumption logic in GetWorkingBeatmap
...
This should not be required since the introduction of `workingCache`,
which does the same thing in a more global way.
2021-05-31 14:11:58 +09:00
ekrctb
0c101d2859
Apply comment rewording suggestion
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2021-05-31 13:41:49 +09:00
smoogipoo
a4dca6f839
Reorder methods around load()
2021-05-31 13:39:18 +09:00
Dan Balasescu
1ba607b3ff
Merge branch 'master' into osu-game-base-cleanup
2021-05-31 13:32:09 +09:00
Salman Ahmed
fb111e23d8
Remove "temporarily"
2021-05-31 07:24:59 +03:00
Gagah Pangeran Rosfatiputra
113f90e92e
add back schedule is CurrentPath setter
2021-05-31 10:49:16 +07:00
smoogipoo
bca8a9ea53
Fix HandleFrame crashing when not playing
2021-05-31 10:02:02 +09:00
Bartłomiej Dach
ab077c6656
Merge branch 'master' into non-nullable-beatmapset-files
2021-05-31 00:10:03 +02:00
Salman Ahmed
3fbd4e276d
Add simple xmldoc
2021-05-31 00:07:29 +03:00
Bartłomiej Dach
78213e09d4
Merge branch 'master' into editor-exit-stability
2021-05-30 23:03:50 +02:00
Salman Ahmed
d12e93bfc6
Add skin traget resetting on setup/teardown steps
2021-05-31 00:02:55 +03:00
Gagah Pangeran Rosfatiputra
3c7f1ae996
Merge branch 'master' into osu-wiki-overlay
2021-05-30 20:27:12 +07:00
Dean Herbert
f3bde258a2
Merge pull request #13232 from ekrctb/initial-lifetime
...
Fix wrong/misleading comment of `InitialLifetimeOffset`
2021-05-30 22:26:47 +09:00
Dean Herbert
f35cf2d846
Merge branch 'master' into main-page-wiki
2021-05-30 21:01:05 +09:00
Salman Ahmed
fb81e5133f
Merge branch 'master' into catch-hide-combo-workaround
2021-05-30 14:16:46 +03:00
ekrctb
abb77b95b4
Fix comment grammar
2021-05-30 13:06:28 +09:00
Salman Ahmed
53cbf369d7
Fix potential nullref
2021-05-29 21:22:46 +03:00
Salman Ahmed
42618c713f
Merge branch 'master' into legacy-beatmap-skin-hud-fallback
2021-05-29 20:56:05 +03:00
Dean Herbert
4e7d19a3af
Merge branch 'master' into beatmap-skin
2021-05-29 16:51:17 +09:00
Dean Herbert
9b239e308b
Merge branch 'master' into beatmap-skin
2021-05-29 15:36:43 +09:00
ekrctb
265dfe5416
Add test case of DHO setting LifetimeStart in OnApply
2021-05-28 21:51:48 +09:00
ekrctb
43bf734816
Reset lifetime on HitObject.DefaultsApplied
2021-05-28 21:35:26 +09:00
Dean Herbert
8652ac05db
Merge branch 'editor-exit-stability' into non-nullable-beatmapset-files
2021-05-28 18:58:35 +09:00
Dean Herbert
ee5eb9576f
Fix completely wrong conditional logic
2021-05-28 18:38:50 +09:00
ekrctb
1d5e8f4a91
Fix wrong/misleading comment of InitialLifetimeOffset
2021-05-28 17:19:36 +09:00