Dean Herbert
c8521b49cd
Change S rank to require no miss
2024-01-22 21:43:32 +09:00
Dean Herbert
2ab0be7606
Merge pull request #26669 from bdach/fix-score-submission-test-failures-again-aaaaaaaaAAAAAA
...
Fix score submission test failures due to checking audio playback validity (again)
2024-01-22 20:07:51 +09:00
Bartłomiej Dach
9b2740f8a4
Fix score submission test failures due to checking audio playback validity (again)
...
As seen in https://github.com/ppy/osu/actions/runs/7607899979/job/20716013982?pr=26662#step:5:75
In https://github.com/ppy/osu/pull/26484 , I went "well if I'm moving the
enabling of validation of playback rate to `SubmittingPlayer` context,
then surely I can remove the local override in the test scene, right?"
Reader: Apparently I did not notice that `FakeImportingPlayer :
TestPlayer : SoloPlayer : SubmittingPlayer`. So no, I could not remove
the local override in the test scene.
You could probably attempt to conjure up some excuse about deep
inheritance hierarchies here but nah. Really just a failure to read
on my behalf as usual.
2024-01-22 11:15:42 +01:00
Bartłomiej Dach
77ef12ebb0
Merge branch 'master' into frame-stable-catchup-zoom
2024-01-22 10:37:06 +01:00
Dean Herbert
993e733fce
Merge pull request #26598 from frenzibyte/fix-storyboard-sprites-2
...
Remove handling for non-legacy texture lookup paths in `LegacySkin`
2024-01-22 17:50:55 +09:00
Dean Herbert
f12be60d8d
Make test actually test multiple icons
2024-01-22 17:18:22 +09:00
Bartłomiej Dach
493d495992
Merge pull request #26605 from peppy/simplify-gameplay-pause
...
Simplify gameplay pause sequence
2024-01-22 08:49:08 +01:00
Dean Herbert
3b7a47aded
Merge branch 'master' into update-framework
2024-01-21 13:49:44 +09:00
Andrei Zavatski
1393f52b2b
Rename Masking to ClampToDrawable
2024-01-21 05:20:42 +03:00
Dean Herbert
a69fd8198d
Update framework and other nuget packages
...
- Moq held back because dicks
- NUnit held back because large API changes (trivial but effort)
- SignalR held back due to api deprecations
2024-01-21 11:00:53 +09:00
smallketchup82
87369f8a80
Conform to code style & remove unused imports
2024-01-18 11:16:03 -05:00
Salman Ahmed
22cfc86050
Add failing test case
2024-01-18 14:24:49 +03:00
Dean Herbert
c4e9bcd140
Remove test guarantee of audio time not advancing
2024-01-18 20:06:53 +09:00
Dean Herbert
82e7643df5
Update IPC usages
...
Of note, I've disabled IPC on visual test runners as we generally don't
use IPC in these cases. Having it set means that the game will not open
while visual tests are open, which has been a complaint from devs in the
past.
2024-01-18 19:45:36 +09:00
smallketchup82
d80a5d44ee
Add tests for DifficultyIcon
2024-01-18 03:17:37 -05:00
Dean Herbert
799c74cfe5
Simplify gameplay pause sequence
2024-01-18 14:17:19 +09:00
Dean Herbert
fb4efd992d
Add a fake load to visual test to restore previous testing behaviour
2024-01-18 14:01:37 +09:00
Dean Herbert
c362a93a36
Change frame stable catch-up method to allow for much faster sync
2024-01-18 14:01:37 +09:00
Salman Ahmed
06da7f74de
Merge branch 'master' into fix-storyboard-sprites-2
2024-01-17 18:43:25 +03:00
Dean Herbert
e260e75fac
Merge pull request #26594 from frenzibyte/fix-storyboard-sprites-1
...
Change legacy beatmap skins to not handle `@2x` textures (to match stable)
2024-01-18 00:40:29 +09:00
Salman Ahmed
ede0a22693
Remove existing test coverage
2024-01-17 16:58:47 +03:00
Salman Ahmed
bcc7dd6af5
Add extended test coverage
2024-01-17 15:58:27 +03:00
Dean Herbert
6a8a45bb13
Merge pull request #26585 from frenzibyte/fix-editor-ux
...
Fix timing point changes not applying after selecting another one
2024-01-17 19:53:35 +09:00
Dean Herbert
1af5d1434c
Rename test method slightly
2024-01-17 19:53:23 +09:00
Bartłomiej Dach
5cb17bcacf
Merge pull request #26502 from frenzibyte/prevent-submission-with-invalid-mods
...
Add guard against submitting score with invalid mod instances
2024-01-17 11:39:32 +01:00
Dean Herbert
0ddd89a5b8
Merge pull request #26579 from bdach/accuracy-rank-lazer-score-reimport
...
Fix incorrect accuracy and rank population when decoding lazer replays
2024-01-17 19:33:26 +09:00
Salman Ahmed
5ad2918a75
Allow disabling high resolution texture lookups in LegacySkin
2024-01-17 12:56:29 +03:00
Dean Herbert
ee18123fc2
Merge pull request #26340 from stanriders/user-rank-card
...
Add user card with global/country ranks to login overlay
2024-01-17 17:22:33 +09:00
Salman Ahmed
05729706eb
Fix android build CI failing
...
No idea why this is only in android, but okay.
2024-01-17 08:53:28 +03:00
Salman Ahmed
23e5167cb5
Merge branch 'master' into drag-volume-controls
2024-01-17 08:37:34 +03:00
Salman Ahmed
a34d2a3424
Add small volume meter to test feel
2024-01-17 08:28:47 +03:00
Salman Ahmed
f11682d44f
Add failing test case
2024-01-17 08:15:01 +03:00
Bartłomiej Dach
1075b87fb8
Add failing test coverage
2024-01-16 22:38:52 +01:00
Salman Ahmed
485195d4c2
Fix submission test not asserting properly
2024-01-16 14:27:40 +03:00
Salman Ahmed
2935bd4809
Add test cases for helper method
2024-01-16 14:27:24 +03:00
Bartłomiej Dach
a3b7943e7d
Merge pull request #26560 from peppy/fix-skin-loss
...
Fix skin potentially being lost when opening and closing skin editor rapidly
2024-01-16 10:16:30 +01:00
Dean Herbert
0e41d0c9cf
Add failing test coverage of skin getting nuked
...
This doesn't fail in headless unfortunately.
Run a few times manually to confirm.
2024-01-16 15:22:38 +09:00
Dean Herbert
09e5b2fb46
Add test coverage of incorrect default state for Rank when hidden is applied
2024-01-16 13:21:15 +09:00
Bartłomiej Dach
40f612435d
Merge pull request #26178 from felipemarins/mod-search-text-box-select-all
...
Make mod search box text be selected when a new mod is selected/deselected
2024-01-15 20:08:02 +01:00
Bartłomiej Dach
a41108057f
Merge pull request #26287 from wooster0/no-scores-yet
...
Don't leave scores screen empty if no scores are present yet
2024-01-15 19:49:20 +01:00
Bartłomiej Dach
4d39c91972
Merge pull request #26449 from peppy/playlist-room-buttons
...
Allow interacting with playlist item buttons when not selected
2024-01-15 19:12:01 +01:00
Bartłomiej Dach
c0d4ed4789
Add test coverage of select-all-text-in-search when nothing matched
2024-01-15 19:07:52 +01:00
Bartłomiej Dach
e8394e6f74
Add test coverage
2024-01-15 19:05:33 +01:00
Bartłomiej Dach
988794cf90
Improve test coverage for empty results
2024-01-15 18:49:41 +01:00
Bartłomiej Dach
8a839f64ed
Add failing test coverage for placeholder shown when it shouldn't be
2024-01-15 18:47:46 +01:00
Bartłomiej Dach
d8d1d9264c
Fix test failure
2024-01-15 18:29:51 +01:00
Bartłomiej Dach
91f8144f98
Add test coverage
2024-01-15 14:58:46 +01:00
Bartłomiej Dach
d206acac63
Merge pull request #26540 from peppy/fix-double-counters
...
De-dupe displayed hits in judgement counter
2024-01-15 14:02:11 +01:00
Bartłomiej Dach
fe8540b441
Merge pull request #26541 from peppy/fix-collection-dropdown-crash
...
Fix collection dropdown crashing when all collections are deleted at once
2024-01-15 13:28:00 +01:00
Salman Ahmed
d346dd0650
Fix TestModReinstantiation failing due to custom mod being used
2024-01-15 15:01:13 +03:00
Bartłomiej Dach
96c472b870
Remove unused using directive
2024-01-15 12:33:25 +01:00
Bartłomiej Dach
6dee2860d2
Merge branch 'master' into fix-multiplayer-mods-cheesing
2024-01-15 12:19:29 +01:00
Bartłomiej Dach
0a02050a85
Fix test crashing at the end in visual test browser
2024-01-15 12:12:27 +01:00
StanR
b86c883a5d
Merge branch 'master' into user-rank-card
2024-01-15 16:37:48 +06:00
Salman Ahmed
494c1be655
Fix blatant error in TestSceneModAccuracyChallenge
2024-01-15 13:30:34 +03:00
Bartłomiej Dach
9da3aeb28b
Merge pull request #26492 from frenzibyte/fix-system-mods-selected-on-free-mods-overlay
...
Fix touch device mod getting selected as a free mod in playlists
2024-01-15 11:29:37 +01:00
Dean Herbert
a3b63391fa
Merge pull request #26356 from stanriders/global-user-statistics
...
Add `Statistics` bindable to `IAPIProvider` and update it from `SoloStatisticsWatcher`
2024-01-15 18:43:35 +09:00
Dean Herbert
2b45a9b7c6
Add failing test coverage showing collection dropdown crash
2024-01-15 17:10:16 +09:00
Dean Herbert
e6453853c2
De-dupe displayed hits in judgement counter
2024-01-15 16:02:59 +09:00
Dean Herbert
2d5a39b234
Add failing test coverage of duplicates in judgement counter display
2024-01-15 16:02:58 +09:00
Salman Ahmed
b1fae2bc6a
Add failing test case
2024-01-13 16:24:49 +03:00
Salman Ahmed
4cde8685d3
Add failing test case
2024-01-13 11:16:22 +03:00
Salman Ahmed
5303023e57
Add failing test case and fix selection assertion
2024-01-13 09:42:23 +03:00
Bartłomiej Dach
6572fa4378
Only validate playback rate when in submission context
...
Temporary workaround for https://github.com/ppy/osu/issues/26404 .
It appears that some audio files do not behave well with BASS, leading
BASS to report a contradictory state of affairs (i.e. a track that is
in playing state but also not progressing). This appears to be related
to seeking specifically, therefore only enable the validation of
playback rate in the most sensitive contexts, namely when any sort of
score submission is involved.
2024-01-12 14:59:15 +01:00
Bartłomiej Dach
593ca9f84f
Merge pull request #26468 from frenzibyte/fix-skin-parsing
...
Fix mania skin array decoder not handling malformed entries rigorously
2024-01-12 12:52:02 +01:00
Bartłomiej Dach
600e4b6ef3
Adjust skinnable health display test scene for usability
2024-01-11 10:17:32 +01:00
Bartłomiej Dach
861080d3ae
Move simulated drain to separate test case
...
Having it on at all times was causing other tests to fail.
2024-01-11 10:04:37 +01:00
Dean Herbert
c2706ca91b
Also show drain on argon health display test
2024-01-11 00:31:31 +09:00
Salman Ahmed
7b848e1458
Assert column line width length for extra safety
2024-01-10 17:51:27 +03:00
Salman Ahmed
84f704a6c2
Add failing test case
2024-01-10 17:41:46 +03:00
Dean Herbert
49d13cda6b
Fix failing test by setting health on source of truth
2024-01-10 23:09:43 +09:00
Dean Herbert
f912a1ba31
Merge branch 'master' into health-less-value-changed
2024-01-10 18:03:34 +09:00
wooster0
d5fdd0c0f9
make each test bind the handler only once, depending on its need
2024-01-09 21:44:05 +09:00
wooster0
ea37c70e0b
apply suggestion
2024-01-09 21:34:40 +09:00
wooster0
8ad697ff4c
apply some suggestions/corrections
2024-01-09 21:28:46 +09:00
Dean Herbert
8324b75fa4
Merge pull request #26437 from bdach/song-select-logo-crash
...
Fix crash when clicking osu! logo in song select immediately after exiting
2024-01-09 19:40:19 +09:00
Dean Herbert
f1b4c305b0
Change skinnable health test scene to drain
2024-01-09 17:09:19 +09:00
Dean Herbert
79ff767eba
Remove unused using
2024-01-09 14:51:30 +09:00
Dean Herbert
3cdc3b5786
Merge branch 'master' into fix-wiki-main-page-layout
2024-01-09 13:14:36 +09:00
Dean Herbert
7d57a668ab
Use main page constant in more places
2024-01-09 13:12:54 +09:00
Joseph Madamba
b03813d3b4
Update casing of hardcoded "Main_page" string in tests
2024-01-08 14:37:50 -08:00
Bartłomiej Dach
388f6599e0
Add failing test for not attempting to upgrade non-legacy scores
...
This was a source of confusion for users previously, wondering why their
non-legacy (non-stable) scores weren't being converted in line with new
scoring changes, when it was never actually our intention to support
anything of the sort.
2024-01-08 22:10:09 +01:00
Bartłomiej Dach
67df7b33fb
Add failing test coverage for not attempting to upgrade custom ruleset scores
2024-01-08 22:10:08 +01:00
Bartłomiej Dach
8a87301c55
Add test for crashing scenario
2024-01-08 21:34:54 +01:00
Bartłomiej Dach
5337d999b5
Merge branch 'master' into disable-intro-track-pause
2024-01-08 12:54:37 +01:00
Bartłomiej Dach
b869be2f46
Fix typo
2024-01-08 12:52:23 +01:00
Bartłomiej Dach
50eba9ebdb
Reduce code duplication in test
2024-01-08 12:52:14 +01:00
Zachary
e2769dbda1
Attempt at creating a test.
2024-01-06 19:29:41 +10:00
Dean Herbert
fbc40ffc65
Merge pull request #26381 from Joehuu/flash-ongoing-operations-dialog
...
Flash blocking ongoing operations dialog when trying to force quit
2024-01-05 18:34:06 +09:00
Joseph Madamba
b190333c17
Use repeat step for more delay between the two exits
2024-01-04 09:00:24 -08:00
Dean Herbert
35b9940c4e
Merge pull request #26140 from CaffeeLake/multiplier1x
...
Fix mod score multiplier rounding to 1.00x with specific mod combinations
2024-01-04 19:26:49 +09:00
Dean Herbert
085f5acd1a
Fix another rider inspection (why do these keep coming up at random)
2024-01-04 19:26:28 +09:00
Dean Herbert
fc1a2c594c
Add a bit more test coverage
2024-01-04 18:02:37 +09:00
Dean Herbert
44d35020d1
Add test coverage of failed multiplayer score
2024-01-04 17:54:52 +09:00
Dean Herbert
b1813b17a2
Few new rider inspection
2024-01-04 16:39:50 +09:00
Dean Herbert
0f11743fff
Merge pull request #26379 from wooster0/chat
...
Make chat command names case-insensitive
2024-01-04 16:17:42 +09:00
wooster0
cf5f0a2bdc
Make chat commands case-insensitive
...
Would be nice if I accidentally have caps lock enabled and write "/HELP" it still works.
2024-01-04 15:06:10 +09:00
wooster0
92c4566287
Fix typo
2024-01-04 12:20:05 +09:00
CaffeeLake
c7b0a7ff69
Merge branch 'master' into multiplier1x
2024-01-04 05:04:23 +09:00
StanR
e240443c46
Update LocalUser statistics, add test
2024-01-03 18:15:32 +06:00
CaffeeLake
4312e9e9a9
Add Test: floating point errors
2024-01-03 20:17:05 +09:00
StanR
3df7430d2e
Bind UserRankPanel values to Statistics bindable in APIAccess
2024-01-03 14:32:32 +06:00
Bartłomiej Dach
e686a6a1dd
Fix player submission test intermittent failures due to audio playback discrepancy logic kicking in
...
See https://github.com/ppy/osu/actions/runs/7384457927/job/20087439457#step:5:133 .
2024-01-03 09:17:01 +01:00
CaffeeLake
79ef032182
Merge branch 'master' into multiplier1x
2024-01-03 07:40:02 +09:00
StanR
c4be6fa974
Fix code quality, add new cards to the test scene
2024-01-03 00:37:24 +06:00
Dean Herbert
05d9aeefbc
Merge pull request #26248 from smoogipoo/slider-tail-judgement
...
Increase slider tails' worth to 150 points (up from 30)
2024-01-02 20:50:34 +09:00
CaffeeLake
ca0f09733a
Remove unnecessary using directives
...
Signed-off-by: CaffeeLake <PascalCoffeeLake@gmail.com>
2023-12-31 23:35:42 +09:00
Salman Ahmed
34acb435b8
Merge branch 'master' into multiplier1x
2023-12-31 16:48:00 +03:00
Salman Ahmed
4a94cfd35d
Fix failing test case
2023-12-31 16:47:12 +03:00
wooster0
0c85fd496f
Don't leave scores screen empty if no scores are present yet
...
Addresses https://github.com/ppy/osu/discussions/23787
I originally wanted to set `allowShowingResults` to false if there are
no results but because this involves an API request to fetch the scores
that would mean all the scores would have to be fetched all at once so
that it knows whether to hide or show the "View results" button on a
beatmap.
Because that would slow things down and be very inefficient, this still
allows the user to view the scores screen but if there aren't any
scores, it shows a text, which I think is at least for now better than
nothing.
As for the testing of this, I wasn't sure how to not generate scores
only for one specific test so I opted into not using `SetUpSteps` and
doing it that way.
2023-12-31 22:42:32 +09:00
Salman Ahmed
cd9250d08c
Add test coverage
2023-12-31 05:18:10 +03:00
Salman Ahmed
68dd103c89
Add failing test cases
2023-12-30 21:33:22 +03:00
Dan Balasescu
807443b648
Add HitResult.SliderTailHit
2023-12-30 10:38:47 +09:00
Dean Herbert
2b81f4f557
Merge pull request #26221 from bdach/system-title-only-on-top-level-menu
...
Do not display system title in inital menu state
2023-12-29 21:13:40 +09:00
Bartłomiej Dach
db78d73fa5
Do not display system title in inital menu state
...
Addresses https://github.com/ppy/osu/discussions/26199 .
2023-12-29 11:50:30 +01:00
Bartłomiej Dach
9bb0663b3b
Add test coverage of failure case
2023-12-29 10:36:53 +01:00
Bartłomiej Dach
68402bfd11
Add test coverage of failure scenario
2023-12-28 20:39:11 +01:00
Dean Herbert
8e3fe090f3
Merge pull request #26169 from bdach/universal-offset-from-session-plays
...
Implement automatic suggestion of global audio offset based on last plays
2023-12-28 22:57:30 +09:00
Bartłomiej Dach
24a80da83f
Merge branch 'master' into universal-offset-from-session-plays
2023-12-28 14:07:46 +01:00
Bartłomiej Dach
bb0737837b
Fix test failing due to querying button position during transform
2023-12-28 13:58:00 +01:00
Dean Herbert
6bc0f02e2d
Fix test initialising dialogs without cleaning up
2023-12-28 20:40:51 +09:00
Dean Herbert
f8347288c1
Add padding around text in dialogs
2023-12-28 20:29:56 +09:00
Dean Herbert
28e220ca50
Update popup dialog design
...
Had to be done. I hated the old ones so much.
As usual, disclaimer that this is an iterative design and will probably
be replaced in the future.
2023-12-28 19:04:35 +09:00
Dean Herbert
bd0e2b4dde
Remove disclaimer screen completely
2023-12-28 17:21:29 +09:00
Dean Herbert
1f2339244e
Add supporter display to main menu
2023-12-28 17:20:01 +09:00
Bartłomiej Dach
d9299a8a55
Implement visual appearance of "system title" message in main menu
2023-12-27 23:07:17 +01:00
Bartłomiej Dach
160342ceed
Implement automatic suggestion of audio offset based on last plays
2023-12-27 21:14:37 +01:00
Bartłomiej Dach
1b7af989ec
Migrate BeatmapOffsetControl to use session static directly
2023-12-27 19:19:27 +01:00
Bartłomiej Dach
53766285ce
Remove remaining hexacons usages
2023-12-27 17:42:18 +01:00
Dean Herbert
901674a130
Move back button inside sidebar to fix weird animation
2023-12-27 13:39:13 +09:00
Bartłomiej Dach
6f672b8cb3
Fix TestSceneKeyBindingPanel failures
2023-12-26 20:36:12 +01:00
Bartłomiej Dach
9ac79782d2
Add visibility toggle step to settings panel test scene
2023-12-26 20:21:15 +01:00
Dean Herbert
03e2463b06
Add test coverage and refactor to better handle equality edge case
2023-12-26 21:21:08 +09:00
Bartłomiej Dach
30b5b36f1d
Fix code quality inspection
2023-12-26 12:20:17 +01:00
Nathan Tran
4e3bdb2b56
Add test coverage
2023-12-26 00:57:06 -08:00
Bartłomiej Dach
32d8ee2d0c
Add test coverage
2023-12-23 13:42:19 +01:00
Dean Herbert
9f34dfa2ba
Add missing using statement
2023-12-23 16:25:52 +09:00
Simon G
01cf4ee15a
add test for length updates
2023-12-22 18:11:37 +01:00
Bartłomiej Dach
fbf19ea598
Merge branch 'master' into add-score-version
2023-12-21 13:06:53 +01:00
Bartłomiej Dach
5ff95db02c
Add test coverage of ClientVersion serialisation
2023-12-21 13:06:42 +01:00
Bartłomiej Dach
81bbdccee7
Rename ScoreInfo.{ -> Client}Version
2023-12-21 12:56:43 +01:00
Bartłomiej Dach
7e9d12e1d2
Merge pull request #25993 from smoogipoo/fix-total-score-conversion
...
Relocate numeric HitResult values, add accuracy conversion
2023-12-21 12:10:54 +01:00
Dean Herbert
a4baa0a716
Add versioning of local scores
...
For any potential future usage
2023-12-21 18:37:15 +09:00
Dean Herbert
0648201844
Cancel test more
2023-12-21 18:17:03 +09:00
Dan Balasescu
6b4b2a57fc
Expose only as one method
2023-12-21 14:58:23 +09:00
Dan Balasescu
4e3b994142
Relocate HitResult numeric score to ScoreProcessor
2023-12-21 14:52:31 +09:00
Dean Herbert
c5fb4d0f5c
Mark flaky test temporarily
2023-12-21 01:52:40 +09:00
Bartłomiej Dach
322cfaae1d
Merge branch 'master' into fix-standardised-score-conversion
2023-12-19 17:41:38 +01:00
Bartłomiej Dach
64b0534fb8
Merge pull request #25857 from peppy/fix-mod-settings-keyboard-adjust
...
Fix mod search textbox having focus while settings are visible
2023-12-19 15:44:17 +01:00
Bartłomiej Dach
d793d1cea1
Add test coverage of desired input handling behaviour
2023-12-19 14:52:16 +01:00
Bartłomiej Dach
e306cc35ba
Merge branch 'master' into fix-song-select-realm-refresh-performance
2023-12-19 14:14:46 +01:00
Dean Herbert
8f5d21dc70
Actually fix realm selection retention regression
2023-12-19 18:10:55 +09:00
Bartłomiej Dach
9c8df4e6d1
Run score conversion for previously-imported scores
2023-12-18 22:27:51 +01:00
Bartłomiej Dach
bf668174ec
Use nunit constraints in test for transparency
2023-12-18 19:02:23 +01:00
Dean Herbert
41485c19cf
Add realm refresh steps in an attempt to stabilise failing test
...
I think this is required because there is a higher chance of batched
updates with the new structure (and less calls to `BeatmapSetsChanged`
which causes re-selection).
2023-12-19 02:08:29 +09:00
Bartłomiej Dach
be16e0e538
Add failing test for adding collection w/ name colliding w/\ default items
2023-12-18 12:47:42 +01:00
Bartłomiej Dach
67a5e01c49
Update assertions in test
2023-12-14 15:19:29 +01:00
Dean Herbert
76653e61cb
Merge pull request #25575 from frenzibyte/collection-dropdown-improve-ux
...
Improve handling of beatmap collection changes in `CollectionDropdown`
2023-12-14 18:39:36 +09:00
Bartłomiej Dach
839a080247
Add test coverage for desired mod overlay search box behaviour
2023-12-14 09:52:38 +01:00
Salman Ahmed
31c9489cb9
Fix failing tests
2023-12-13 23:38:19 +03:00
Dean Herbert
c6b1a5f1ee
Merge pull request #25691 from bdach/fix-skin-editor-crash-again
...
Fix skin editor crashing in some circumstances when opened in main menu
2023-12-13 22:15:42 +09:00
Dan Balasescu
8c7570525a
Merge pull request #25744 from peppy/adjust-mod-multipliers
...
Adjust some mod multipliers for initial leaderboard sanity
2023-12-13 17:56:13 +09:00
Bartłomiej Dach
e865de7a6b
Update test assertions in line with half time mod multiplier changes
2023-12-13 09:25:56 +01:00
Dean Herbert
fdcf87569c
Merge pull request #25711 from smoogipoo/mania-convert-song-select-keycount
...
Display osu!mania keycount in song select carousel panels and details
2023-12-13 16:31:25 +09:00
Dean Herbert
ec6200b4ad
Merge pull request #25743 from peppy/merge-everything-at-once
...
Merge everything at once
2023-12-13 16:17:06 +09:00
Dean Herbert
eff81be6fd
Fix failing test and add coverage of conversion case
2023-12-13 16:01:52 +09:00
Dean Herbert
c2d3dcdd9c
Fix slider tests and incorrect nullability handling around freehandToolboxGroup
2023-12-13 15:15:49 +09:00
Dean Herbert
5e10f9f899
Fix failing tests due to more textboxes being present with searchable dropdowns
2023-12-13 15:11:47 +09:00
Dean Herbert
aa4faf5e8e
Merge pull request #25740 from smoogipoo/fix-ignoremiss-accuracy-update
...
Fix IgnoreMiss judgements not updating accuracy
2023-12-13 15:03:07 +09:00
Dan Balasescu
41ba1dcfce
Merge branch 'master' into editor/checks/delayed-hitsounds
2023-12-13 14:01:06 +09:00
Dean Herbert
343ecc469f
Merge branch 'master' into dropdown-search
2023-12-13 13:58:23 +09:00
Dan Balasescu
8977e74171
Fix editor test not waiting for editor to load
2023-12-13 13:15:49 +09:00
Dan Balasescu
daaadf3fc3
Fix IgnoreMiss judgements not updating accuracy
2023-12-13 11:51:45 +09:00
Salman Ahmed
10e8edff67
Merge branch 'master' into dropdown-search
2023-12-12 21:14:01 +03:00
Dan Balasescu
987fe9322e
Merge pull request #24166 from Zyfarok/scorev3
...
Modify osu! standardised scoring to introduce a combo exponent
2023-12-12 17:38:44 +09:00
Bartłomiej Dach
9a83d7be81
Ensure that SoloScoreInfo serialisation result does not contain interface members
2023-12-08 09:27:12 +01:00
Dean Herbert
ea0ad2a0ef
Merge branch 'master' into online-presence
2023-12-07 17:42:46 +09:00
Dean Herbert
3c29e9162c
Merge pull request #25693 from bdach/online-presence-structure-serialisation
...
Simplify user presence structures for serialisability
2023-12-07 17:39:21 +09:00
Dean Herbert
a500f55ec6
Merge pull request #25688 from peppy/match-default-sv
...
Change default slider velocity for new beatmaps to match osu!stable
2023-12-07 11:52:16 +09:00
Bartłomiej Dach
86e003aec1
Update currently online display tests
2023-12-06 19:37:35 +01:00
Bartłomiej Dach
602550b9c2
Fix test failures
2023-12-06 19:37:28 +01:00
Bartłomiej Dach
d66fa09320
Simplify UserStatus to be an enumeration type
...
There were absolutely no gains from having it be a reference type /
class, only complications, especially when coming from the serialisation
angle.
2023-12-06 18:52:27 +01:00
Bartłomiej Dach
faf60cec91
Extend test coverage of skin editor open to fail better
2023-12-06 10:11:41 +01:00
Bartłomiej Dach
4585a169b1
Merge pull request #25686 from peppy/fix-song-select-match
...
Fix searching at song select matching incorrect ruleset
2023-12-06 09:25:47 +01:00
Dean Herbert
43dc908257
Fix test value getting clobbered due to stupid stuff
...
Don't even ask. Just smile and nod.
2023-12-06 15:59:29 +09:00
Dean Herbert
79826dee58
Fix tests which were relying on SliderMultiplier==1
2023-12-06 13:50:10 +09:00
Dean Herbert
4da6d53c72
Merge pull request #25672 from frenzibyte/fix-argon-health-display-2
...
Fix `ArgonHealthDisplay` sometimes behaving weirdly on miss judgements (alternative)
2023-12-06 12:24:39 +09:00
Dean Herbert
8286d3896f
Fix searching at song select matching incorrect ruleset
...
Regressed with https://github.com/ppy/osu/pull/25679 .
2023-12-06 11:32:26 +09:00
Salman Ahmed
a67df76654
Add test coverage
2023-12-05 22:53:48 +03:00
Salman Ahmed
c55bfc03ee
Move private method
2023-12-05 22:06:53 +03:00
Salman Ahmed
20fd458fac
Perserve miss animation when followed by a hit at same frame
2023-12-05 21:59:28 +03:00
Salman Ahmed
986f4fa407
Add test scenarios for same-frame judgements
2023-12-05 21:59:28 +03:00
Dean Herbert
5a2240838b
Merge branch 'master' into multiplayer-abort
2023-12-05 17:01:54 +09:00
Salman Ahmed
17577a6606
Add visual test case for late miss in argon health display
2023-12-04 23:01:11 +03:00
Bartłomiej Dach
063694f544
Do not attempt to load gameplay scene if current beatmap is dummy
2023-12-04 14:42:51 +01:00
Bartłomiej Dach
43312619e3
Add test coverage for crashing on wrong ruleset
2023-12-04 14:42:51 +01:00
Bartłomiej Dach
7c041df0f1
Add test coverage for crashing on dummy beatmap
2023-12-04 14:42:42 +01:00
Bartłomiej Dach
d3e94cd5bf
Add test coverage for crashing on empty beatmap
2023-12-04 14:42:40 +01:00
Bartłomiej Dach
7deff70b4a
Extract beatmap import steps from gameplay scene switch helper
2023-12-04 13:34:36 +01:00
Dan Balasescu
8587652869
Fix countdown button being enabled
2023-12-04 11:00:11 +09:00
Dan Balasescu
9ccd33a1ec
Add comments to test
2023-12-04 10:20:53 +09:00
Dan Balasescu
c2644a5d5e
Correctly implement button enabled state
2023-12-04 10:18:37 +09:00
Bartłomiej Dach
30a4e77097
Merge branch 'master' into fix-overlapping-chat-links
2023-12-01 14:30:55 +01:00
Dan Balasescu
f3530a79b1
Add test
2023-12-01 21:34:20 +09:00
Bartłomiej Dach
d97ae8df6a
Remove commented out italic code
...
It's a holdover from the Exo days (anyone remember those?) and hasn't
been relevant for years, so why keep it.
2023-12-01 13:31:11 +01:00
Susko3
c395ae2460
Add failing tests
...
They throws `ArgumentOutOfRangeException` on the first drawable Update()
2023-12-01 00:51:20 +01:00
Susko3
7f9ae55f5e
Add passing tests
2023-12-01 00:48:55 +01:00
Susko3
1a33bfbb3a
Enable NRT
2023-12-01 00:37:16 +01:00
Susko3
fba6349c65
Remove unused properties
2023-12-01 00:36:40 +01:00
Susko3
21fedff54f
Check number of links shown
2023-12-01 00:29:37 +01:00
Susko3
7b1ccb38cb
Remove redundant string interpolation
2023-11-30 23:35:10 +01:00
Susko3
0520ac265f
Move to TestCase-based test
2023-11-30 23:34:43 +01:00
Susko3
52ffbcc6db
Move special cases to TestCase'd test
2023-11-30 23:29:22 +01:00
Susko3
3ca3f25492
Extract local method
2023-11-30 23:26:52 +01:00
Susko3
9a32c0368e
Remove redundant linkAmount parameter
2023-11-30 14:38:58 +01:00
Susko3
831fe5b9f2
Use collection assert to ease debugging
2023-11-30 14:36:23 +01:00
Dean Herbert
b2e1a63cd7
Merge pull request #25595 from smoogipoo/fix-bad-slider-lengths
...
Fix taiko and mania using the incorrect slider length when converting beatmaps
2023-11-30 16:59:48 +09:00
Dan Balasescu
295a1b01d6
Adjust catch score grade cutoffs
2023-11-29 19:05:31 +09:00
Dan Balasescu
26855a2c04
Add failing test
2023-11-28 21:14:34 +09:00
Bartłomiej Dach
98ab9853ce
Merge branch 'master' into show-spectator-fail-2
2023-11-27 12:24:59 +09:00
Bartłomiej Dach
19639de299
Merge branch 'master' into fix-spectator-quit-2
2023-11-27 11:36:10 +09:00
Bartłomiej Dach
1388e492b1
Merge branch 'master' into chat-drag-improvements
2023-11-27 10:46:55 +09:00
Dean Herbert
9015615336
Update test to work with new drag bar location
2023-11-24 19:45:04 +09:00
Dean Herbert
de1d921383
Merge branch 'master' into menu-skin-editor-button
2023-11-24 17:39:54 +09:00
Dean Herbert
55df8e81b9
Merge pull request #25560 from peppy/hexacons-sprite-icon
...
Replace all hexacon lookups with strongly typed properties
2023-11-24 17:38:58 +09:00
Dean Herbert
e3217bc82e
Merge branch 'master' into hp-drain-fix-breaks
2023-11-24 15:15:48 +09:00
Dan Balasescu
289cda71b2
Fix inspections
2023-11-24 15:06:51 +09:00
Dean Herbert
7ceb49fbc0
Add extra test coverage and handle case where still at loading screen
2023-11-24 15:05:39 +09:00
Dean Herbert
ef5dd24589
Update failing test coverage and fix onFail being called too often
2023-11-24 14:44:57 +09:00
Dean Herbert
51e2ce500d
Add test coverage of remote user failing immediately failing locally
2023-11-24 14:38:02 +09:00
Dean Herbert
73ad92189b
Add test coverage of remote player quitting immediately quitting locally
2023-11-24 14:26:09 +09:00
Dean Herbert
e06d79281d
Update tests to work with nested screen
2023-11-24 14:26:09 +09:00
Dean Herbert
dabbdf674b
Rename SoloSpectator to SoloSpectatorScreen
2023-11-24 14:26:08 +09:00
Dean Herbert
a02b6a5bcb
Update menu key shortcut test coverage
2023-11-24 13:18:17 +09:00
Dean Herbert
7e59a1d0be
Apply NRT to ButtonSystem
2023-11-24 13:18:17 +09:00
Dean Herbert
5905ca6492
Add second level menu for skin editors
2023-11-24 13:18:17 +09:00
Dean Herbert
340227a06d
Replace all hexacon lookups with strongly typed properties
2023-11-24 13:17:39 +09:00
Bartłomiej Dach
2a6885164c
Update tests to match new scoring expectations
2023-11-24 10:46:21 +09:00
Dean Herbert
686afa9697
Merge branch 'master' into fix-combo-handling
2023-11-24 10:30:52 +09:00
Dan Balasescu
10e16e4b04
Fix handling of combo offset without new combo, and incorrect lazer tests
2023-11-24 09:46:06 +09:00
Dan Balasescu
7bc2d6e6cd
Merge branch 'master' into fix-combo-handling
2023-11-23 16:22:01 +09:00
Dean Herbert
5d367c247c
Merge pull request #25547 from bdach/skin-editor-paste-catching-fire
...
Fix skin editor crashing when pasting with nothing in clipboard
2023-11-23 16:15:11 +09:00
Dan Balasescu
7998204cfe
Fix combo/combo colouring issues around spinners
2023-11-23 13:54:05 +09:00
Bartłomiej Dach
d4519f74ab
Merge branch 'master' into hp-drain-fix-breaks
2023-11-23 10:31:42 +09:00
Bartłomiej Dach
4edaaa3083
Add test coverage of skin editor copy-paste
2023-11-23 09:55:16 +09:00
Dan Balasescu
30309cdf11
Merge pull request #25415 from Poyo-SSB-forks/unify-ur
...
Change unstable rate calculation to account for rate-change mods
2023-11-23 09:53:28 +09:00
Bartłomiej Dach
81816e303c
Merge pull request #25540 from peppy/editor-test-failures
...
Attempt to fix intermittent failures on new tests
2023-11-23 09:42:34 +09:00
Bartłomiej Dach
3441a9a5b5
Add test coverage for classic scoring overflowing in osu! ruleset
2023-11-23 08:12:34 +09:00
Dean Herbert
aa8dc6bd80
Attempt to fix intermittent failures on new tests
...
See https://github.com/ppy/osu/pull/25418/checks?check_run_id=18886372597 .
2023-11-22 21:46:35 +09:00
Dan Balasescu
cb4568c4a1
Fix first object after break not starting a new combo
2023-11-22 17:22:48 +09:00
