7353 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	bbe2dfa458	Move out incompatibility displaying tooltip to own class	2022-02-23 23:18:15 +01:00
Bartłomiej Dach	8a0aba6c59	Implement mod panel for new mod select screen	2022-02-23 23:18:14 +01:00
Bartłomiej Dach	29d77a29aa	Merge branch 'master' into startup-protocol-handling	2022-02-23 21:10:27 +01:00
Bartłomiej Dach	1a358698fb	Merge branch 'master' into startup-protocol-handling	2022-02-22 22:42:16 +01:00
Dean Herbert	6de4e05e49	Fix current selection not being correctly maintained when BeatmapPicker updates its display	2022-02-22 17:17:08 +09:00
Dean Herbert	e744840d07	Ensure old results are cleared from beatmap overlay on logout	2022-02-22 14:56:04 +09:00
Dean Herbert	d6032a2335	Fix beatmap overlay not re-fetching results after login	2022-02-22 14:55:52 +09:00
Dean Herbert	fc1877b6fa	Move to extension method and revert logic to match previous implementation	2022-02-21 13:42:26 +09:00
Dean Herbert	79408f6afc	Add xmldoc and clean up ScoreboardTimeUtils extension methods a touch	2022-02-21 13:30:58 +09:00
Dean Herbert	abe1a3990a	Merge branch 'master' into leaderboard-score-timeref	2022-02-21 12:11:10 +09:00
Bartłomiej Dach	36a00c1ee2	Remove static OverlayColourProviders	2022-02-20 21:09:08 +01:00
Bartłomiej Dach	ce0db9d4db	Remove all references to static OverlayColourProviders	2022-02-20 21:09:08 +01:00
Bartłomiej Dach	79ba37bbab	Add Colour0 to OverlayColourProvider	2022-02-20 21:09:08 +01:00
Bartłomiej Dach	2592f0900d	Add comments about OverlayColourProvider vs OsuColour distinction	2022-02-20 21:08:58 +01:00
dekrain	15ed9ec4fa	Merge scoreboard and leaderboard implementations together	2022-02-19 20:47:02 +01:00
Dan Balasescu	ea5bb46fb8	Merge branch 'master' into net6	2022-02-16 00:40:04 +09:00
Salman Ahmed	f5d0eb41cb	Update further ChangeFocus usages	2022-02-15 02:42:39 +03:00
Bartłomiej Dach	4bd58cfde1	Update one more custom transform with BorderColour type change	2022-02-14 18:52:19 +01:00
Dean Herbert	b9d9fc56af	Move files to UI namespace	2022-02-14 17:51:39 +09:00
Dean Herbert	80ba06b0e3	Merge branch 'master' into expandable-controls	2022-02-14 16:57:45 +09:00
Salman Ahmed	ccd6648961	Update pinned score container header to use localised title	2022-02-11 09:22:09 +03:00
Salman Ahmed	4f7003928a	Add score container for pinned scores in ranks section	2022-02-10 21:32:18 +03:00
Dean Herbert	eda213e4de	Merge pull request #16827 from smoogipoo/spectator-state-rework ... Add user state to SpectatorState, allowing multiplayer to continue to results	2022-02-11 01:48:47 +09:00
Dean Herbert	44f2d8a448	Allow game folder migration to fail gracefully when cleanup cannot completely succeed	2022-02-10 19:30:26 +09:00
Dean Herbert	88bb9d4237	Fix migration errors not outputting the call stack to logs	2022-02-10 15:50:03 +09:00
Dean Herbert	c242a63b11	Fix playlist overlay null reference when attempting an empty selection ... As reported at https://github.com/ppy/osu/discussions/16829.	2022-02-09 10:16:45 +09:00
Dan Balasescu	886d1d2df6	Refactorings	2022-02-08 21:29:43 +09:00
Salman Ahmed	bbef12e72c	Refactor ExpandingControlContainer to no longer rely on controls	2022-02-04 05:45:12 +03:00
Dean Herbert	b2efce2656	Merge branch 'master' into expandable-controls	2022-02-03 19:23:34 +09:00
Dan Balasescu	81a22dbd29	Add back playing users list	2022-02-02 23:19:43 +09:00
Dan Balasescu	fcbba3d948	Rename PlayingUserStates -> WatchingUserStates	2022-02-02 23:11:29 +09:00
Dan Balasescu	f4210f7a30	Rework spectator components to use new user state	2022-02-01 21:53:25 +09:00
Dan Balasescu	502e6af008	Remove PlayingUsers list from SpectatorClient	2022-02-01 14:42:30 +09:00
Dean Herbert	9005bce0fa	Add "counter" keyword for key overlay setting	2022-01-31 16:37:51 +09:00
Dean Herbert	b7d8c9bf06	Fix a couple of cases of incorrect equality checks in the case both values are null	2022-01-28 14:29:56 +09:00
Salman Ahmed	2cc69d6b19	Replace IsControlDragged with an abstract ShouldBeExpanded	2022-01-27 15:57:56 +03:00
Dan Balasescu	b3f2392358	Resolve compilation error due to removed method	2022-01-26 19:04:18 +09:00
Dan Balasescu	cdca1285ab	Merge branch 'master' into playlist-overlay-optimisations	2022-01-26 19:01:33 +09:00
Dean Herbert	45636ce04b	Remove collection ToLive helper method to avoid confusion	2022-01-26 18:26:37 +09:00
Dean Herbert	d1a2256262	Refactor SkinSection to avoid unnecessary realm queries	2022-01-26 17:48:11 +09:00
Salman Ahmed	a34b8fc4d0	Merge branch 'master' into expandable-controls	2022-01-26 10:36:22 +03:00
Salman Ahmed	161ff45f8c	Resolve further UI-related issues	2022-01-26 10:36:18 +03:00
Salman Ahmed	eb83b7fe0a	Update existing implementation with changes	2022-01-26 10:18:17 +03:00
Salman Ahmed	6998266770	Add simplified implementation of an expandable slider	2022-01-26 10:18:06 +03:00
Salman Ahmed	b5e6352137	Revert SettingsItem<T>-related changes	2022-01-26 09:31:35 +03:00
Dean Herbert	9532454e2a	Remove ILive remnants	2022-01-26 15:12:07 +09:00
Dean Herbert	ba46827ac0	Merge branch 'master' into playlist-overlay-optimisations	2022-01-26 15:11:14 +09:00
Dan Balasescu	8f85f32f2b	Merge pull request #16619 from peppy/live-no-interface ... Remove `ILive<>` interface (and use `abstract Live<>` instead)	2022-01-26 14:54:14 +09:00
Dean Herbert	cd71ec0edd	Remove ILive<> interface (and use abstract Live<> instead)	2022-01-26 13:38:56 +09:00
Dean Herbert	7ca73f7e6d	Don't auto-unblock realm when user has manually pressed unblock button	2022-01-26 12:51:09 +09:00
Dean Herbert	dda513dd08	Change PlaylistOverlay to use ILive	2022-01-26 12:19:59 +09:00
Dean Herbert	64914c45a4	Remove unnecessary realm query helper method	2022-01-26 11:53:50 +09:00
Dean Herbert	cdef67ccd0	Log posted notifications ... To help with test failures and the likes.	2022-01-25 23:38:48 +09:00
Dean Herbert	1a776a9587	Completely remove subscription from MusicController	2022-01-25 16:53:02 +09:00
Dean Herbert	2a786f9ec0	Load text only after it comes on screen (and tidy up selection handling logic)	2022-01-25 16:51:21 +09:00
Dean Herbert	ace2bd2208	Apply some initial optimisations to PlaylistItem	2022-01-25 16:51:21 +09:00
Dean Herbert	8a4f3a7ce0	Reimplement subscription logic in PlaylistOverlay directly	2022-01-25 16:51:21 +09:00
Dean Herbert	958cfde608	Stop detaching and exposing beatmaps from MusicController	2022-01-25 16:51:21 +09:00
Dean Herbert	d7342880f5	Update remaining cases of clashes with realm.Write and realm.RegisterForNotifications	2022-01-25 13:09:48 +09:00
Dean Herbert	e23b10e6a5	Update remaining cases of clashing variable name in realm.Run(realm..	2022-01-25 13:04:05 +09:00
Bartłomiej Dach	da771044a7	Merge branch 'master' into realm-clean-up	2022-01-24 19:15:31 +01:00
Dean Herbert	3bc86ee68f	Merge branch 'master' into music-controller-less-population	2022-01-24 20:44:37 +09:00
Dean Herbert	6eb2c28e41	Rename RealmContextFactory to RealmAccess	2022-01-24 20:38:07 +09:00
Dean Herbert	b0919722ac	Guard against potential exception while blocking realm	2022-01-24 18:25:48 +09:00
Dean Herbert	40aa873190	Rename register methods to better explain their purpose	2022-01-24 14:37:36 +09:00
Dean Herbert	d7a9c5fd41	Add settings buttons to allow temporarily blocking realm access	2022-01-24 14:36:57 +09:00
Dean Herbert	351c766ea1	Fix one remaining instance of realm query as property	2022-01-23 23:20:03 +09:00
Dean Herbert	e9e3e024a1	Update all usages of QueryAsyncWithNotifications to use new Register pathway	2022-01-23 20:28:04 +09:00
Salman Ahmed	648e7f6bbc	Handle controls with dragging state wrapped in underlying components ... I'm not 100% sure about this approach but it'll do for now.	2022-01-23 05:41:16 +03:00
Salman Ahmed	f4c7a332c3	Add IExpandable support for SettingsItem<T>	2022-01-23 05:41:16 +03:00
Salman Ahmed	326f12f847	Add IExpandable support for SettingsToolboxGroup	2022-01-23 05:41:16 +03:00
Salman Ahmed	62a2bccd76	Abstractify expansion logic from ExpandingButtonContainer	2022-01-23 05:41:16 +03:00
Dean Herbert	287d70d728	Merge branch 'realm-stable-subscriptions' into music-controller-less-population	2022-01-22 14:37:39 +09:00
Dean Herbert	6a076a684e	Merge branch 'realm-context-use-update-when-feasible' into realm-stable-subscriptions	2022-01-22 13:14:25 +09:00
Dean Herbert	25dbe6b27c	Fix unused null assignment	2022-01-22 12:58:30 +09:00
Dean Herbert	7025191fdd	Move target field outside of Run usage ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2022-01-22 12:02:44 +09:00
Salman Ahmed	81b07dee56	Introduce IExpandable interface	2022-01-21 18:41:19 +03:00
Dean Herbert	ad3a01dc06	Use a more reliable method of reviving the update thread realm after blocking	2022-01-21 22:44:56 +09:00
Dean Herbert	a86c0014fe	Remove unnecessary exception/check	2022-01-21 20:07:43 +09:00
Dean Herbert	63226f7def	Remove pointless initial MusicController beatmap set population ... Looks to pass tests and all usages look safe enough.	2022-01-21 20:05:35 +09:00
Dean Herbert	1f157d729d	Update existing subscriptions to new style ... Fix missing detach calls in `MusicController`	2022-01-21 20:05:03 +09:00
Dean Herbert	114c9e8c1f	Update all usages of CreateContext to use either Run or Write	2022-01-21 17:27:08 +09:00
Dean Herbert	a5d2047f05	Fix various cases of creating realm contexts from update thread when not necessary	2022-01-21 01:44:56 +09:00
Dan Balasescu	4f86a2cb61	Merge pull request #16525 from bdach/beatmap-listing-overflow-and-scrolling ... Improve usability of expanded card content on beatmap listing	2022-01-20 14:14:44 +09:00
Bartłomiej Dach	b8184a3005	Fix news sidebar assuming returned posts are always from given year	2022-01-19 23:13:30 +01:00
Bartłomiej Dach	4cad5890c6	Add test coverage for news sidebar showing wrong headers	2022-01-19 23:12:35 +01:00
Bartłomiej Dach	33ab356dc5	Fix expanded card content being clipped on beatmap listing overlay	2022-01-19 22:10:05 +01:00
Dean Herbert	d10d657073	Merge pull request #16421 from Susko3/textbox-AllowIme-false ... Add `AllowIme => false` to text boxes where applicable	2022-01-18 18:02:47 +09:00
Dean Herbert	39c9c4985b	Merge branch 'master' into textbox-AllowIme-false	2022-01-18 17:03:51 +09:00
Dean Herbert	1b62a685f3	Merge branch 'master' into realm-integration/score-and-beatmaps	2022-01-18 15:07:59 +09:00
Dan Balasescu	e9c96908d5	Merge pull request #16481 from peppy/fix-scores-container-tests ... Rewrite `TestSceneScoresContainer` to work again	2022-01-17 20:39:14 +09:00
Dean Herbert	12fd279b7d	Add test to check full flow of rebinding gameplay key bindings ... Addresses a regression found in realm PR that was not covered by tests.	2022-01-17 16:00:17 +09:00
Dean Herbert	51ade3251d	Improve ScoresContainer loading overlay logic to work better with tests	2022-01-17 15:15:39 +09:00
Dean Herbert	88bf406c22	Fix null reference in equality comparison causing beatmap set overlay to crash	2022-01-17 13:05:55 +09:00
Dean Herbert	5601f6f1fe	Merge branch 'master' into realm-integration/score-and-beatmaps	2022-01-17 12:29:02 +09:00
Susko3	6e4214de4d	Move VersionManager from osu.Desktop to osu.Game	2022-01-15 19:42:38 +01:00
Bartłomiej Dach	03e4ec4214	Merge branch 'master' into realm-integration/score-and-beatmaps	2022-01-15 14:45:42 +01:00
Susko3	19467e58c1	Remove unused params from BDL methods	2022-01-15 01:06:39 +01:00
Dean Herbert	3a95425a9e	Remove left-over methods in MusicController	2022-01-14 19:55:49 +09:00
Dean Herbert	51251e3204	Fix CI reported warnings	2022-01-12 22:39:00 +09:00
Dean Herbert	017285b694	Update MusicController to handle deletions more correctly	2022-01-12 17:49:11 +09:00
Dean Herbert	72656ae01e	Fix beatmap restore/undelete flows	2022-01-12 17:49:11 +09:00
Dean Herbert	46206f70d6	Fix beatmap mass deletion flow	2022-01-12 17:49:11 +09:00
Dean Herbert	e8dcbaf29a	Fix intro screen hitting null reference if intro beatmap is unavailable	2022-01-12 17:49:11 +09:00
Dean Herbert	c33e163178	Bind ruleset to toolbar later for safety	2022-01-12 17:49:10 +09:00
Dean Herbert	3811bd8520	Fix some null inspections	2022-01-12 17:00:16 +09:00
Dean Herbert	33060990b7	Temporarily disable WorkingBeatmapCache and fix multiple invalid data flows	2022-01-12 17:00:16 +09:00
Dean Herbert	1d536fd0bc	Start introducing ILive	2022-01-12 17:00:16 +09:00
Dean Herbert	abd72c496b	"Update" MusicController	2022-01-12 17:00:16 +09:00
Dean Herbert	00e3af3366	Update model manager and many related classes to get things compiling again	2022-01-12 17:00:00 +09:00
Dean Herbert	4f6a05ce3d	Reimplement all query methods	2022-01-12 16:57:27 +09:00
Dean Herbert	53792811b2	more fixes (almost compiles, except ruleset and manager)	2022-01-12 16:57:27 +09:00
Dean Herbert	3ecd889fef	Replace EF RulesetStore with realm version ... Pass full EF context factory to `RealmContextFactory` for migration purposes	2022-01-12 16:39:36 +09:00
Dean Herbert	11e07c1137	Add button to compact realm on demand ... In general we're doing things correctly so the realm file shouldn't expand (unless mass deletions are made from it), but this is a nice way to manually confirm the behaviour. Sometimes if using realm studio with osu! running, for instance, the realm file size can blow out of proportion. This will recover from such cases. Note that calling `RealmFactory.Compact` itself is not enough, as it will fail unless all instances of the realm have been closed.	2022-01-12 15:22:36 +09:00
Susko3	a0842838e7	Add AllowIme => false where applicable ... Also adds `AllowWordNavigation => false` to password text box.	2022-01-12 00:15:17 +01:00
r00ster	a8c3fdd383	Update outdated OpenTabletDriver FAQ links	2022-01-11 16:11:07 +01:00
Dan Balasescu	af9fad00c3	Merge branch 'master' into async-deadlock-safety	2022-01-10 16:11:09 +09:00
Bartłomiej Dach	2e9ba40ae2	Add references to web implementation wrt property used	2022-01-09 14:46:15 +01:00
Bartłomiej Dach	12c8243a9b	Fade out inactive player rows on user ranking table	2022-01-09 14:42:26 +01:00
Bartłomiej Dach	9e84e31eac	Add score time to beatmap set overlay scoreboard table	2022-01-07 19:18:16 +01:00
Bartłomiej Dach	87f7c7e691	Implement scoreboard-specific time formatting	2022-01-07 19:18:16 +01:00
Bartłomiej Dach	881fa2b86b	Add basic test scene for scoreboard time	2022-01-07 19:18:16 +01:00
Dean Herbert	3cd996eb4a	Merge branch 'master' into async-deadlock-safety	2022-01-07 17:28:59 +09:00
Bartłomiej Dach	8f744c99ee	Fix settings toolbox toggle button starting in incorrect state ... While displaying replays, the colour of the toolbox toggle button would not match the actual state of the rest of the toolbox, i.e. both buttons would be white, even though the "playback settings" section was expanded and as such should have a yellow toggle button. In the case of the replay player, the failure scenario was as follows: 1. `SettingsToolboxGroup` calls `updateExpanded()` in its BDL to update the initial state of the toolbox, including the toggle button colour, by adding a colour fade transform. 2. An ancestor of both the toolbox groups - `PlayerSettingsOverlay`, which is a `VisibilityContainer` - calls `FinishTransforms(true)` in its `LoadCompleteAsync()`, therefore instantly applying the colour from point (1) to the toggle button instantly. 3. However, `IconButton` inherits from `OsuAnimatedButton`. And `OsuAnimatedButton` changes its colour in `LoadComplete()`, therefore undoing the instant application from point (2). This conjunction of circumstances is instrumental to reproducing the bug, because if the `FinishTransforms(true)` call wasn't there, point (3) wouldn't matter - the transform would get applied at some indeterminate point in the future, ignoring the write from `OsuAnimatedButton`. As for the fix, move the `updateExpanded()` call in `SettingsToolboxGroup` to `LoadComplete()` to avoid the above unfortunate order. Applying initial visual state in `LoadComplete()` is the idiomatic style of doing things these days anyhow.	2022-01-06 20:45:56 +01:00
Dean Herbert	e02863f780	Avoid accessing DrawWidth from invalidation	2022-01-07 01:24:30 +09:00
Dean Herbert	f703c5f038	Add comment and reduce how often ChildrenOfType is invoked in ExpandingButtonContainer	2022-01-06 23:38:54 +09:00
Dean Herbert	5aca2dd4ce	Hide header text when it won't fit in the toolbox group	2022-01-06 23:08:50 +09:00
Dean Herbert	690b425380	Move enum local to usage	2022-01-06 22:56:56 +09:00
Dean Herbert	00177a3ae1	Update usages to new naming	2022-01-06 22:54:43 +09:00
Dean Herbert	3ea7588a91	Update continuation usages to use GetCompletedResult	2022-01-06 22:53:07 +09:00
Dean Herbert	cea9cab4dc	Use ExpandingButtonContainer in editor composer	2022-01-06 21:10:45 +09:00
Dean Herbert	5baaf356aa	Split out SettingsToolboxGroup from PlayerSettingsGroup	2022-01-06 21:05:00 +09:00
Dean Herbert	77980196c5	Split out expanding container logic from settings sidebar	2022-01-06 21:02:29 +09:00
Dean Herbert	39650ce7e9	Merge pull request #16307 from peppy/beatmap-listing-bottom-padding ... Add padding to the bottom of the beatmap listing overlay to avoid hovered panels exceeding visible bounds	2022-01-04 14:14:42 +09:00
Dean Herbert	73b40e6833	Replace usage of .Result with .WaitSafelyForResult	2022-01-04 11:51:41 +09:00
Bartłomiej Dach	de33b420ab	Add safety against performing operation on non-alive foundContent	2022-01-03 20:02:46 +01:00
Bartłomiej Dach	586f158920	Remove initial foundContent value ... It always is replaced on the first search anyway, and just remains forever in the overlay otherwise.	2022-01-03 19:52:42 +01:00
Bartłomiej Dach	6650a468e0	Fix and simplify very broken beatmap listing content swap-out logic ... The beatmap listing content swap-out logic was already a source of several problems, and several attempts of fixing it were made. But as it turns out it was terminally broken in several aspects. * The `BypassAutoSizeAxes` juggling was finicky and ugly, and didn't really look much different than an instant fade. Therefore, all fade durations and manipulations of `BypassAutoSizeAxes` are removed. * The transform sequence juggling the `BypassAutoSizeAxes` manipulations was enqueued on the content which is being in the process of fading out. That was partially fixed in 25e38560, but as it turns out, that only works if `lastContent` is one of the two placeholder drawables (results not found / supporter required to use filter). It would not work if `lastContent` is a `ReverseChildIDFillFlowContainer` with cards from a previous search in it.	2022-01-03 19:51:46 +01:00
Bartłomiej Dach	ef9f56e585	Fix bad check if content is placeholder ... The `lastContent == foundContent` check, last touched in a49a4329, is terminally broken, as it would always be false. `foundContent` is mutated when a new card load task is started in `onSearchFinished()`, which is *before* the aforementioned check. The code prior to a49a4329 was checking against the two static reused placeholder drawables which was the correct check to apply, and this commit reverts to using a variant of that check.	2022-01-03 19:51:20 +01:00
Bartłomiej Dach	97439c3df1	Rename method to reflect what it actually does	2022-01-03 19:30:17 +01:00
Bartłomiej Dach	7c246670b4	Add padding to bottom of spotlights ranking view to avoid hovered panels exceeding visible bounds	2022-01-03 18:43:20 +01:00
Dean Herbert	b9851b278d	Add padding to the bottom of the beatmap listing overlay to avoid hovered panels exceeding visible bounds ... Closes https://github.com/ppy/osu/issues/16120.	2022-01-03 13:18:28 +09:00
Dean Herbert	6356180b6a	Remove unnecessary code and fix double nesting causing filtering to not work	2022-01-03 12:53:58 +09:00
Dean Herbert	bb54f438aa	Merge branch 'master' into positional-sounds-strength-adjustment	2022-01-03 12:40:56 +09:00
Joseph Madamba	7de43e3aba	Fix most open compound words in identifiers being closed	2021-12-27 20:26:28 -08:00
Joseph Madamba	98524d60a4	Fix clear identifier typos	2021-12-27 20:26:28 -08:00
Dan Balasescu	d36fe3af09	Merge pull request #16238 from peppy/fix-incorrect-delegate-capture ... Fix incorrect delegate capture leading to slow leak of audio tracks	2021-12-24 21:34:04 +09:00
Dean Herbert	2ee3e61983	Merge branch 'master' into beatmap-card/extra-on-listing	2021-12-24 19:02:51 +09:00
Dean Herbert	cc7089c3f4	Cancel more liberally	2021-12-24 19:00:09 +09:00
Dean Herbert	d602aebebb	Add missing cancellation token and rename load task variable to match purpose	2021-12-24 18:58:31 +09:00
Dean Herbert	842d508aee	Fix incorrect delgate capture leading to slow leak of audio tracks ... During profile, it was found that the `Completed` delegate was incorrectly also capturing `lastTrack`, leading to an unexpected reference chain that led to a memory leak over a long period of time. This solves the issue by moving the delegate construction to its own method, where it won't capture the other variables.	2021-12-24 18:39:29 +09:00
Bartłomiej Dach	5cbaa028eb	Use extracted ruleset config cache implementation in DI	2021-12-23 19:02:10 +01:00
Bartłomiej Dach	a49a4329ee	Add capability to switch between card sizes	2021-12-23 15:55:37 +01:00
Bartłomiej Dach	d0427ec85f	Add support card size tab control to beatmap listing	2021-12-23 15:55:37 +01:00
Bartłomiej Dach	1876617d8e	Implement beatmap card size tab control	2021-12-23 15:55:36 +01:00
Bartłomiej Dach	25e38560ce	Fix placeholder drawables on beatmap listing not always hiding correctly ... `BeatmapListingOverlay.addContentToPlaceholder()`, in order to make transitions between different beatmap listing content (whether it is actual cards, or placeholders for no beatmaps found/supporter-specific filters chosen), would set `BypassAutoSizeAxes = Y` on content as it is fading out, to make the transition smoother. The property in question was supposed to be getting restored to `None` on the next show. In testing scenarios, it sometimes turned out that this wasn't the case, therefore making the placeholders effectively not show - while they were present and fully opaque, they would be the only child of an auto-sized container with `BypassAutoSizeAxes = Y`, so the parent auto-sized to a zero height, which logically follows from the premise, but is not what was desired. This in turn was caused by the fact that the `BypassAutoSizeAxes = Y` set was scheduled, and sometimes it would be scheduled in such a way that the drawable would cease to be present on the next frame due to its alpha being past the cutoff point of 0.0001. Therefore the scheduled set would not execute until the *next* time the placeholder was shown, therefore causing the bug. Fix by ensuring that the placeholder drawables are always present if their schedulers have any tasks enqueued, on top of the usual checks of alpha and scale performed via the base implementation.	2021-12-22 15:05:23 +01:00
Bartłomiej Dach	88d4e95ad8	Rename BeatmapCard{ => Normal}	2021-12-21 08:26:21 +01:00
Bartłomiej Dach	a6ccbafc77	Fix rank graph showing for unranked users	2021-12-19 13:40:22 +01:00
mk-56	fd5af1fbe7	Code refactor and name changes ... cleaned code up with Jetbrains i hope it suffices	2021-12-17 13:16:06 +01:00
Bartłomiej Dach	54790bb758	Merge branch 'master' into fix-realm-post-storage-migration-failure	2021-12-17 00:19:46 +01:00
Dean Herbert	aa0813ff05	Merge pull request #16109 from smoogipoo/chat-overlay-multiplayer-removal ... Don't show multiplayer channels in chat overlay	2021-12-16 17:39:45 +09:00
Dan Balasescu	3f1d747b7a	Merge pull request #16090 from peppy/fix-scroll-speed-toast-sample-spam ... Fix toast popups spamming samples when adjusting osu!mania scroll speed during gameplay	2021-12-16 17:31:36 +09:00
Dan Balasescu	488374b4a2	Don't show multiplayer channels in chat overlay	2021-12-16 16:41:47 +09:00
Susko3	643cee4f83	Merge branch 'master' into number-textbox-only-numbers	2021-12-15 09:13:19 +01:00
Susko3	b326ccc196	Move logic to framework and update all usages	2021-12-15 07:13:24 +01:00
Dean Herbert	0c11fe7413	Fix toast popups spamming samples when adjusting osu!mania scroll speed during gameplay ... Not the most robust of fixes, but as per the reasoning described in the issue thread, a proper fix will take considerably more effort. This intends to fix the issue first and foremost, as it sounds so bad I'd want to mute my sound before adjusting currently. Closes #15718.	2021-12-15 12:45:23 +09:00
Dean Herbert	441b7baa93	Provide a realm factory to usages of ToLive/RealmLive	2021-12-14 14:26:34 +09:00
Dean Herbert	bff02bedbf	Rename APIScoreInfo to APIScore	2021-12-10 16:11:49 +09:00
Dean Herbert	bf1418bafc	Use OnlineID instead of legacy IDs for equality and lookups	2021-12-10 16:11:48 +09:00
Susko3	0b0ff36154	Allow only number characters parseable by int.TryParse ... char.IsNumber() is too broad, allowing full width and other numbers.	2021-12-07 20:06:22 +01:00
Dean Herbert	d6e68feadc	Merge pull request #15948 from bdach/beatmap-card/difficulty-dropdown ... Add difficulty dropdown to beatmap card	2021-12-07 23:40:06 +09:00
Bartłomiej Dach	999bba439f	Clarify usages of reverse child ID flow with inline comments	2021-12-06 21:02:40 +01:00
Dean Herbert	452fa93444	Merge branch 'master' into realm-integration/skins-rebase	2021-12-06 15:21:02 +09:00
Bartłomiej Dach	af10223ac4	Add reverse fill flows & depth specs at usage sites for correct Z-ordering	2021-12-05 20:07:46 +01:00
Bartłomiej Dach	38702beabf	Merge branch 'master' into i-ruleset-store	2021-12-04 15:05:39 +01:00
Dan Balasescu	4145a16d5b	Merge pull request #15920 from peppy/clean-up-unused-resolves ... Clean up unused resolved properties	2021-12-03 20:08:48 +09:00
Dean Herbert	1eed2436e6	Clean up unused resolved properties	2021-12-03 18:49:49 +09:00
Dean Herbert	2acf46154a	Remove many unused resolutions of RulesetStore	2021-12-03 18:16:29 +09:00
Dean Herbert	e75e209053	Cache and consume IRulesetStore where feasible	2021-12-03 18:16:01 +09:00
Dean Herbert	aaa46960b3	Reword mouse wheel disable setting to better explain its purpose	2021-12-03 17:18:07 +09:00
Dean Herbert	e855a49833	Add test coverage of default skin edit and export	2021-12-02 14:01:18 +09:00
Dean Herbert	0a14acfd83	Fix incorrect conditional on export/mutate feasability of skin	2021-12-02 13:41:58 +09:00
Dean Herbert	65f0a80c97	Merge branch 'master' into realm-integration/skins-rebase	2021-12-02 13:37:20 +09:00
Dean Herbert	c82195390f	Update usage of SubscribeForNotifications	2021-12-02 13:24:16 +09:00
Dean Herbert	8ce7467e97	Fix ordering of skins in dropdown being reverse of expected	2021-12-01 12:50:47 +09:00
Dean Herbert	03e1305b3f	Fix toast display potentially causing a child mutation before load complete	2021-12-01 01:55:17 +09:00
Dean Herbert	6877867467	Make default fallback logic more robust	2021-11-29 18:28:25 +09:00
Dean Herbert	0d18c83d75	Simplify deletion by adding always present conditionals to Delete method	2021-11-29 18:28:25 +09:00
Dean Herbert	f6a3709060	Store default skins to database	2021-11-29 18:28:25 +09:00
Dean Herbert	c629a7a36f	Fix random selection and avoid using legacy events for handling skin import/deletion	2021-11-29 18:28:25 +09:00
Dean Herbert	744a5b33f5	Rewrite SkinSection to use realm subscriptions and databased defaults	2021-11-29 18:28:25 +09:00
Dean Herbert	3db5646fa8	Create Guid constants for system skins (and store skin choice to configuration as guid)	2021-11-29 18:28:25 +09:00
mk-56	c3fb793762	Fixed the problems that were brought up and deleted the old bind logic	2021-11-28 14:06:53 +01:00
mk-56	ff9c68dd6a	cleanup	2021-11-28 03:28:35 +01:00
MK56	753c1c7fea	Merge branch 'ppy:master' into positional-sounds-strength-adjustment	2021-11-28 02:59:36 +01:00
mk-56	eaa464e548	Initial implementation of adjustable positional hitobject audio strength	2021-11-28 02:58:08 +01:00
Dean Herbert	51a7c60eec	Merge pull request #15835 from bdach/off-thread-transforms-unbind ... Fix instances of components adding off-thread transforms on unbind	2021-11-28 09:27:43 +09:00
Bartłomiej Dach	db49d99cc0	Ensure correct disabled ruleset callback scheduling in ruleset selector	2021-11-27 15:28:23 +01:00
Bartłomiej Dach	05f7ea6b6d	Remove mentions of "panel" and "direct" from names of old download buttons	2021-11-27 15:08:03 +01:00
Bartłomiej Dach	a043d1e427	Move old beatmap download button to more general namespace	2021-11-27 15:06:57 +01:00
Bartłomiej Dach	251ab183a0	Move beatmap play button nearer its only remaining usage	2021-11-27 15:04:05 +01:00
Bartłomiej Dach	7419682334	Move icon pill to beatmap card-specific namespace	2021-11-27 15:01:48 +01:00
Bartłomiej Dach	6773877a40	Remove no-longer-used beatmap panels	2021-11-27 15:00:06 +01:00
Bartłomiej Dach	f4b7db5a7b	Ensure correct disabled beatmap callback scheduling in now playing overlay	2021-11-27 14:36:34 +01:00
Dean Herbert	89b4e5cffb	Rename mass deletion confirmation dialog	2021-11-26 18:18:45 +09:00
Bartłomiej Dach	ec2265d5bb	Use beatmap cards in spotlights layout	2021-11-25 22:30:47 +01:00
Bartłomiej Dach	42b09fd1ec	Use beatmap cards in user profile overlay	2021-11-25 22:30:47 +01:00
Bartłomiej Dach	0f9ebe3d5d	Use beatmap cards in beatmap listing overlay	2021-11-25 22:30:46 +01:00
Dan Balasescu	f712aeee01	Merge pull request #15795 from peppy/realm-integration/separate-download-flow ... Split out download logic from main manager classes	2021-11-25 20:59:23 +09:00
Dan Balasescu	d3a4890c31	Merge branch 'master' into realm-integration/stable-export-flow	2021-11-25 19:06:18 +09:00
Dean Herbert	e2ebcf7a26	Remove unnecessary manager parameter ... Confused why I added this in the first place..	2021-11-25 18:36:03 +09:00
Dean Herbert	716543b5b3	Move beatmap download logic out of BeatmapManager	2021-11-25 17:29:41 +09:00
Dean Herbert	79459c1aeb	Fix typo in class and variable names	2021-11-25 17:12:15 +09:00
Dean Herbert	cc1b91e4bd	Split out legacy model export logic into LegacyModelExporter classes	2021-11-25 16:41:12 +09:00
Dean Herbert	9dcb20a821	Rename Stable to Legacy and add xmldoc	2021-11-25 15:39:05 +09:00
Dean Herbert	183b95cbc2	Rename BeatmapSetOnlineStatus to BeatmapOnlineStatus ... This variable is used at more than just a set level.	2021-11-24 18:42:49 +09:00
Dan Balasescu	8ce5324c8b	Merge pull request #15772 from peppy/remove-model-list-inits ... Initialise `BeatmapSet.Beatmaps` list at construction time	2021-11-24 16:41:19 +09:00
Dean Herbert	a7853fc9cc	Fix cases of known-non-null	2021-11-24 14:26:25 +09:00
Dan Balasescu	84268c3d85	Merge branch 'master' into realm-ruleset-keybinding-short-name	2021-11-24 13:48:48 +09:00
Dan Balasescu	6183d1cd46	Merge pull request #15769 from peppy/model-equality-consistency ... Update cases where equality can be used instead of primary key equality	2021-11-24 13:45:57 +09:00
Dean Herbert	729f681938	Update cases where equality can be used instead of primary key equality	2021-11-24 12:49:57 +09:00
Dean Herbert	0eea026afb	Remove null checks on CreateInstance() calls	2021-11-24 12:23:09 +09:00
Bartłomiej Dach	0d409fa33e	Merge branch 'master' into realm-ruleset-keybinding-short-name	2021-11-23 20:18:58 +01:00
Dan Balasescu	fd4d5e98a7	Merge pull request #15745 from bdach/settings-number-box-stack-overflow ... Fix crashes on trying to play back replays of seeded mods with seed value over 1 billion	2021-11-23 16:36:05 +09:00
Dean Herbert	0989d6a92e	Merge branch 'realm-ruleset-setting-short-name' into realm-ruleset-keybinding-short-name	2021-11-23 14:55:40 +09:00
Dean Herbert	feb983d5bd	Rename Debug namespace to avoid collisions	2021-11-23 13:09:41 +09:00
Bartłomiej Dach	4a9f080f3c	Accept full range of int in SettingsNumberBox ... This fixes stack overflow exceptions that would arise when a `Current.Value` of 1 billion or more was set on a `SettingsNumberBox`. The stack overflow was caused by the "maximum 9 digits" spec. If a value technically within `int` bounds, but larger than 1 billion (in the range [1,000,000,000; 2,147,483,647], to be more precise), a feedback loop between the setting control's `Current` and its inner text box's `Current` would occur, wherein the last digit would be trimmed and then re-appended again forevermore. To resolve, remove the offending spec and rely on `int.TryParse` entirely to be able to discern overflow range. Additionally, UX of the text box is slightly changed to notify when the `int` range is exceeded with a red flash. This behaviour would not have been possible to implement without recent framework-side fixes to text box (removal of text set scheduling).	2021-11-22 20:49:14 +01:00
Dean Herbert	d94b27a8a2	Switch realm ruleset key bindings to use ruleset's ShortName as key	2021-11-22 18:52:30 +09:00
Dan Balasescu	698b6c4242	Merge pull request #15668 from peppy/key-repeat ... Update `KeyBindingContainer` usage to block key repeat where applicable	2021-11-18 15:21:35 +09:00
Dean Herbert	db4e4c982c	Add hover effect to supporter button	2021-11-18 13:35:42 +09:00
Dean Herbert	66c307e0ee	Remove usage of key repeat helper method	2021-11-18 13:13:36 +09:00
Dean Herbert	3de8125eac	Update UI cases where repeat should not be handled	2021-11-18 13:13:36 +09:00
Joseph Madamba	cd5e379c48	Link osu!supporter icon to its web page	2021-11-17 14:43:34 -08:00
Dean Herbert	726a0cc091	Merge branch 'master' into beatmap-collection-inteface-types	2021-11-16 15:31:10 +09:00
Dean Herbert	68e2699043	Fix oversight in playlist matching logic	2021-11-16 12:35:18 +09:00
Dean Herbert	285b161da7	Update other usages of online ID comparisons to use new extension method	2021-11-15 14:44:08 +09:00
Dean Herbert	a4c11e8813	Use extension method to compare online IDs	2021-11-15 14:34:50 +09:00
Bartłomiej Dach	58bad0ab25	Merge branch 'master' into fix-setting-header-text-overflow	2021-11-12 20:34:07 +01:00
Bartłomiej Dach	cb2d1f3f04	Use horizontally symmetrical padding rather than margin	2021-11-12 20:28:42 +01:00
Dean Herbert	6a098a8634	Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface	2021-11-12 17:46:24 +09:00
Bartłomiej Dach	a1b55d6490	Add failing test case	2021-11-09 13:34:36 +01:00
Lucas A	b7e7b0f850	Trim whitespace.	2021-11-08 21:42:51 +01:00
Lucas A	e6f39c4cad	Fix settings header text overflowing with some locales.	2021-11-08 21:38:01 +01:00
Susko3	8a23b648fe	Move HoverClickSounds to the clickable button	2021-11-08 14:32:00 +01:00
Dean Herbert	49c26a465c	Debounce and schedule updates to key combinations	2021-11-08 18:29:11 +09:00
Dean Herbert	b4225804ed	Add missing null check	2021-11-08 18:26:12 +09:00
Dean Herbert	f5842e7587	Shorten variable names	2021-11-08 18:24:37 +09:00
Dean Herbert	82f24b0502	Revert "Change font to default" ... This reverts commit cc286f165d.	2021-11-08 18:16:06 +09:00
Dean Herbert	3183b20e2f	Merge branch 'master' into use-ReadableKeyCombinationProvider	2021-11-08 18:15:49 +09:00
Dean Herbert	8b85c2c8de	Merge pull request #15491 from peppy/remove-stupid-weak-reference-bindable-events ... Revert weird event flow in model manager/importers	2021-11-08 15:19:58 +09:00