Andrei Zavatski
f3202fb123
Naming adjustments
2020-08-12 11:24:26 +03:00
Andrei Zavatski
84655b0798
Change hover colour for news title
2020-08-11 20:17:29 +03:00
Andrei Zavatski
fdfda453c7
Merge remote-tracking branch 'refs/remotes/ppy/master' into dashboard-news
2020-08-11 20:14:52 +03:00
smoogipoo
688e447950
Fix potential hierarchy mutation from async context
2020-08-12 01:33:06 +09:00
smoogipoo
070d71ec27
More cleanups
2020-08-12 00:48:38 +09:00
smoogipoo
031d29ac34
Inspect current track directly
2020-08-11 13:53:23 +09:00
smoogipoo
b64142dff9
Fix incorrect load state being used
2020-08-11 12:37:00 +09:00
Dean Herbert
dd2f677aa4
Merge pull request #9633 from Joehuu/fix-keybind-clearing
2020-08-11 11:01:03 +09:00
Andrei Zavatski
d8f8930691
Remove HomeNewsPanelFooter
2020-08-09 05:28:43 +03:00
Andrei Zavatski
a72a48624d
Remove NewsPostDrawableDate
2020-08-09 05:16:08 +03:00
smoogipoo
87ce1e3558
Remove impossible null case (DummyWorkingBeatmap)
2020-08-08 00:58:04 +09:00
smoogipoo
b8373e89b7
Move beatmap bind to BDL load()
2020-08-07 23:08:09 +09:00
smoogipoo
e87f50f74f
Rename method
2020-08-07 22:31:41 +09:00
smoogipoo
b6fb7a0d39
Fix possibly setting null track
2020-08-07 22:05:58 +09:00
smoogipoo
5002d69f69
Update inspections
2020-08-07 20:51:56 +09:00
smoogipoo
61b632516e
Ensure CurrentTrack is never null
2020-08-07 19:43:16 +09:00
Andrei Zavatski
cddd4f0a97
Implement HomeShowMoreNewsPanel
2020-08-07 13:18:31 +03:00
Andrei Zavatski
76d35a7667
Implement HomeNewsGroupPanel
2020-08-07 12:59:45 +03:00
smoogipoo
bf21fdd6da
Merge branch 'master' into beatmap-track-rework
2020-08-07 18:41:34 +09:00
Andrei Zavatski
2e0f567d5d
Implement HomeNewsPanel component
2020-08-07 11:33:02 +03:00
Dean Herbert
9685df0eca
Only update key binding on next usage to avoid large blocking calls
2020-08-06 18:24:20 +09:00
Joehu
f9c369b23c
Fix toolbar music button tooltip overflowing off-screen
2020-08-06 01:20:03 -07:00
Joehu
d574cac702
Add keybinding to toolbar button's tooltip
2020-08-06 01:18:45 -07:00
Joehu
7bcb68ffac
Handle overlay toggling with toolbar buttons instead
2020-08-06 01:17:24 -07:00
Joehu
ad959ce523
Make toolbar button abstract
2020-08-06 01:06:51 -07:00
smoogipoo
fe8c462498
Remove intermediate container
2020-08-06 17:00:17 +09:00
smoogipoo
0f7fde5d2c
Revert unnecessary change
2020-08-06 16:24:14 +09:00
smoogipoo
0edd509397
Only change track when audio doesn't equal
2020-08-06 16:24:14 +09:00
smoogipoo
e9fc783b1d
Add back loop-on-completion
2020-08-06 16:24:14 +09:00
smoogipoo
5c05fe3988
Expose track from MusicController
2020-08-06 16:24:14 +09:00
smoogipoo
6e42b8219c
Move track to MusicController, compiles
2020-08-06 16:24:14 +09:00
Dan Balasescu
bba23dc928
Merge pull request #9780 from peppy/add-toolbar-tooltips
...
Add missing toolbar tooltips for right-hand icons
2020-08-06 13:45:01 +09:00
Dean Herbert
e3f314349a
Don't use title case
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2020-08-06 12:27:30 +09:00
Dean Herbert
bf1bb32674
Add missing toolbar tooltips for right-hand icons
2020-08-05 19:09:55 +09:00
Dean Herbert
3916d98e52
Add comment for clarity
2020-08-05 18:50:37 +09:00
Dean Herbert
8644d04a84
Merge branch 'master' into news-fix
2020-08-05 18:50:35 +09:00
Andrei Zavatski
af320e4a61
Fix NewsOverlay running request on startup
2020-08-03 10:03:42 +03:00
Andrei Zavatski
630322ff85
Adjust font weights in line with web
2020-08-03 09:55:06 +03:00
Andrei Zavatski
057d6f03e5
Merge remote-tracking branch 'refs/remotes/ppy/master' into dashboard-beatmap-panel
2020-08-03 09:54:47 +03:00
Dan Balasescu
6511d6416b
Merge branch 'master' into fix-keybind-clearing
2020-08-03 15:26:09 +09:00
smoogipoo
435c9de8b9
Re-privatise buttons
2020-08-03 15:25:23 +09:00
Dean Herbert
4189e918a3
Merge branch 'master' into news
2020-08-03 14:16:45 +09:00
Joehu
7aafc018ad
Prevent updating bind target when hovering cancel and clear buttons instead
2020-08-02 12:52:12 -07:00
Joehu
ba77fa2945
Add test for clear button
2020-08-02 12:41:35 -07:00
Joehu
b96e32b0bb
Add xmldoc for updateBindTarget
2020-08-02 12:26:09 -07:00
Andrei Zavatski
dc559093cd
Rename namespace from Dashboard to Home
2020-08-02 21:47:09 +03:00
Andrei Zavatski
bddc61756a
Rework padding
2020-08-02 21:44:34 +03:00
Andrei Zavatski
7d83cdbf1c
Make title in DrawableBeatmapList a property
2020-08-02 21:35:24 +03:00
Andrei Zavatski
ca57c70961
Naming adjustments
2020-08-02 21:33:14 +03:00
Salman Ahmed
2190e6443a
Apply height constraints to all settings dropdown
2020-08-01 10:02:46 +03:00
Andrei Zavatski
5b1e3e8622
Remove redundant FillFlowContainer from DashboardBeatmapPanel
2020-08-01 09:11:53 +03:00
Andrei Zavatski
b5f688e63a
Implement DashboardBeatmapListing component
2020-08-01 07:04:39 +03:00
Andrei Zavatski
7624804edf
Implement DashboardPopularBeatmapPanel component
2020-08-01 06:23:06 +03:00
Andrei Zavatski
ce47a34991
Implement DashboardNewBeatmapPanel component
2020-08-01 06:14:24 +03:00
Andrei Zavatski
74f70136fd
Implement DashboardBeatmapPanel component
2020-08-01 06:00:24 +03:00
Dean Herbert
e8f75a78e8
Also fix second instance of same execution
2020-07-31 22:02:12 +09:00
Dean Herbert
4d2a677080
Fix next track starting before previous one is paused
...
Closes #9651 .
2020-07-31 20:33:18 +09:00
Dean Herbert
e6a2409415
Merge branch 'master' into panel-load-debounce
2020-07-30 16:03:17 +09:00
Andrei Zavatski
e1856503c2
Merge master with conflicts resolved
2020-07-30 08:41:45 +03:00
Dean Herbert
e5991d6e14
Change method structure for hover/unhover state setting (shouldn't be called "Fade")
2020-07-30 13:49:04 +09:00
Andrei Zavatski
45ddc7a2e9
Rename ShowMoreButton in comments namespace to ShowMoreRepliesButton
2020-07-30 05:02:01 +03:00
Andrei Zavatski
d4496eb982
Update ShowMoreButton in line with web
2020-07-30 04:51:09 +03:00
Andrei Zavatski
d7fab98af0
Update comments container footer in line with web
2020-07-29 06:39:23 +03:00
smoogipoo
42e88c53d7
Embed behaviour into UserCoverBackground
2020-07-28 20:50:55 +09:00
Andrei Zavatski
2d502cebda
Update DrawableComment layout
2020-07-28 02:36:25 +03:00
Andrei Zavatski
6737c57e33
Adjust colour of edit info
2020-07-28 01:10:13 +03:00
Andrei Zavatski
69691b3739
Use DrawableDate to represent creation date
2020-07-28 00:53:51 +03:00
Andrei Zavatski
46d1de7fa7
ShowMoreButton rework
2020-07-28 00:43:06 +03:00
Andrei Zavatski
1b5a23311e
Update ChevronButton position/colour
2020-07-28 00:29:17 +03:00
Andrei Zavatski
788395f8bf
Revert changes regarding FrontPageDisplay and OverlayView
2020-07-25 15:08:06 +03:00
Andrei Zavatski
c6ae2f520e
Fix FrontPageDisplay is adding more news posts on api state change
2020-07-25 10:39:10 +03:00
Andrei Zavatski
7e5147761f
Use OverlayView for FrontPageDisplay
2020-07-25 09:26:29 +03:00
Andrei Zavatski
b821d619b5
Merge remote-tracking branch 'refs/remotes/ppy/master' into news
2020-07-25 09:13:12 +03:00
Dean Herbert
dfcd26be2d
Merge pull request #9439 from Game4all/gameplay-disable-winkey
2020-07-24 19:34:48 +09:00
Dean Herbert
11f48ee4db
Merge branch 'master' into overlay-header-padding
2020-07-22 16:22:20 +09:00
Dean Herbert
fea6389f69
Hide HUD elements during break time by default
2020-07-22 12:41:06 +09:00
Andrei Zavatski
ad9492804a
Apply suggestions
2020-07-21 22:56:44 +03:00
Andrei Zavatski
0a71194ea6
Fix SpotlightSelector is a VisibilityContainer without a reason
2020-07-21 22:46:08 +03:00
Andrei Zavatski
0145ca09e5
Apply changes to overlays
2020-07-21 20:11:10 +03:00
Andrei Zavatski
e96f8f1cb6
Make content side padding adjustable for OverlayHeader
2020-07-21 20:02:22 +03:00
Joehu
a8991bb8bf
Fix keybind clear button always clearing first keybind regardless of target
2020-07-20 20:13:09 -07:00
Andrei Zavatski
5cdccd96fe
Merge remote-tracking branch 'refs/remotes/ppy/master' into friends_brick
2020-07-20 22:12:14 +03:00
Andrei Zavatski
a6562be3eb
Remove unused classes from social namespace
2020-07-18 23:27:33 +03:00
Andrei Zavatski
3e773fde27
Remove SocialOverlay component as never being used
2020-07-18 23:15:22 +03:00
Andrei Zavatski
81d95f8584
Implement UserBrickPanel component
2020-07-18 20:24:38 +03:00
Andrei Zavatski
ab23e7dfd4
Protect the NewsCard from clicks while hovering DateContainer
2020-07-16 23:14:51 +03:00
Andrei Zavatski
2d9909cdd8
Make news cards clickable
2020-07-16 15:18:01 +03:00
Andrei Zavatski
68d2888a8c
Add NewsOverlay to the game
2020-07-16 14:48:40 +03:00
Andrei Zavatski
17c598568d
Merge remote-tracking branch 'refs/remotes/ppy/master' into news
2020-07-16 14:38:50 +03:00
Dean Herbert
61b298d74d
Merge pull request #9571 from smoogipoo/fix-mod-selection
2020-07-16 16:04:43 +09:00
smoogipoo
96724bde32
Fix chat name backgrounds not dimming
2020-07-16 15:05:01 +09:00
smoogipoo
94834e4920
Select mods via exact types
2020-07-15 19:35:52 +09:00
Dan Balasescu
4a480d8563
Merge branch 'master' into comments-buttons
2020-07-15 16:42:17 +09:00
Andrei Zavatski
0043bd74ba
Rework SpotlightSelector header layout
2020-07-15 08:27:46 +03:00
Andrei Zavatski
df9ea5cc2f
Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-spotlights-filter
2020-07-15 08:08:02 +03:00
smoogipoo
d8ebb8e3eb
Move override to a bit better location
2020-07-15 13:17:22 +09:00
Joehu
79f6092344
Fix back button not glowing when closing mod select with escape
2020-07-14 13:31:15 -07:00
Andrei Zavatski
85c8757572
Return true on click
2020-07-14 21:18:46 +03:00
Andrei Zavatski
3d9e174ae8
Make sort changes affect request result
2020-07-14 18:09:09 +03:00
Andrei Zavatski
c2c80d2a98
Refactor SpotlightSelector layout
2020-07-14 17:34:01 +03:00
Andrei Zavatski
28006ac33f
Remove unnecessary action from ShowRepliesButton
2020-07-14 15:12:18 +03:00
Andrei Zavatski
4c2294f0cd
Refactor LoadRepliesButton to inherit LoadingButton
2020-07-14 15:02:29 +03:00
Andrei Zavatski
7c71cc6b61
Remove unneeded class from DrawableComment
2020-07-14 03:06:51 +03:00
Andrei Zavatski
56349e65f3
Rename arrow direction method
2020-07-14 03:01:14 +03:00
Andrei Zavatski
f6e4ecd960
Merge remote-tracking branch 'refs/remotes/ppy/master' into comments-buttons
2020-07-14 02:46:29 +03:00
Dean Herbert
7b7b92aa10
Fix potential crash when trying to ensure music is playing
2020-07-13 17:28:16 +09:00
Andrei Zavatski
6eec2f9429
Implement RankingsSortTabControl component
2020-07-13 01:22:05 +03:00
Andrei Zavatski
598e48678e
Refactor NewsHeader
2020-07-12 15:45:48 +03:00
Andrei Zavatski
3601a2d93f
Merge remote-tracking branch 'refs/remotes/ppy/master' into news
2020-07-12 14:45:48 +03:00
Andrei Zavatski
be36a4b768
Make ctor protected
2020-07-12 12:39:48 +03:00
Andrei Zavatski
c3524cbe57
Make icon private but expose a protected method
2020-07-12 12:32:26 +03:00
Andrei Zavatski
da40f29b44
Make button text a property
2020-07-12 12:27:26 +03:00
Andrei Zavatski
024ccc75ee
Adjust margins/paddings
2020-07-11 09:03:03 +03:00
Andrei Zavatski
84392d0d13
Add loading spinner
2020-07-11 08:50:35 +03:00
Andrei Zavatski
b1b2e961bc
Update arrow colour on hover
2020-07-11 08:13:11 +03:00
Andrei Zavatski
42d3288f17
Update old buttons usage
2020-07-11 08:01:11 +03:00
Andrei Zavatski
0861ee0c8e
Make Icon rotate when clicking ShowRepliesButton
2020-07-11 07:54:37 +03:00
Andrei Zavatski
da249abd19
Implement CommentRepliesButton
2020-07-11 07:47:17 +03:00
Andrei Zavatski
789c921af1
Move replies button to a new line
2020-07-11 06:47:52 +03:00
Yao Chung Hu
d40f209f4b
Move Playfield Border to OsuPlayfield Ruleset
2020-07-10 07:36:21 -05:00
Dan Balasescu
895c129151
Merge pull request #9492 from peppy/ensure-music-playing-mainmenu-lounge
...
Ensure music playing when returning to lounge or main menu
2020-07-10 21:23:24 +09:00
Dan Balasescu
1ee0a8cd6d
Merge pull request #9495 from peppy/download-button-tooltips
...
Add tooltips to download buttons
2020-07-10 20:57:09 +09:00
Dan Balasescu
be2c892c30
Merge branch 'master' into ensure-music-playing-mainmenu-lounge
2020-07-10 20:48:16 +09:00
Dean Herbert
840380e0de
Fix LocallyAvailable state case getting cleared
2020-07-10 20:30:59 +09:00
Dean Herbert
1760cc2427
Fix behavioural regression by splitting methods out
2020-07-10 18:03:56 +09:00
smoogipoo
ed926de77f
Fix up/improve dropdown styling/positioning
2020-07-10 17:25:28 +09:00
smoogipoo
d0c2a1b9d3
Move dropdown out of display style selector
2020-07-10 17:25:07 +09:00
Dean Herbert
49b88971d1
Display all usable beatmaps in playlist, including protected
2020-07-10 17:20:27 +09:00
Yao Chung Hu
321815f535
Add playfield bounds box with toggle and dim slider
2020-07-09 14:01:28 -05:00
Dean Herbert
115bb40816
Select via select action
2020-07-09 18:25:14 +09:00
Dan Balasescu
fcf3d1ca89
Merge branch 'master' into opaque-toolbar
2020-07-09 15:00:17 +09:00
Andrei Zavatski
f663dd1803
Fix incorrect file name
2020-07-09 04:02:14 +03:00
Andrei Zavatski
aeb664aca7
Delete broken file
2020-07-09 04:00:53 +03:00
Andrei Zavatski
3ba8ec0fd7
Don't set null value to show front page
2020-07-09 03:40:14 +03:00
Andrei Zavatski
dfa22b1e4c
Styles improvements
2020-07-09 02:37:42 +03:00
Andrei Zavatski
62e2bc1198
Fix potential double-request situation
2020-07-09 01:29:27 +03:00
Andrei Zavatski
900f2d309b
Classes naming adjustments
2020-07-09 01:26:56 +03:00
Andrei Zavatski
57b935ec50
Remove outdated elements
2020-07-08 20:17:15 +03:00
Andrei Zavatski
0b4213f330
Implement FrontPageDisplay
2020-07-08 20:07:29 +03:00
Andrei Zavatski
49d998c8db
Refactor NewsOverlay to use displays logic
2020-07-08 18:24:13 +03:00
Dean Herbert
12e3a3c38a
Adjust toolbar fade in/out on toggle
2020-07-08 15:11:26 +09:00
Dean Herbert
0684ac90c6
Make toolbar opaque
...
This is the general direction we're going with future designs. Just
applying this now because it makes a lot of screens feel much better
(multiplayer lobby / match, song select etc. where there are elements
adjacent to the bar which cause the transparency to feel a bit awkward).
2020-07-08 14:43:12 +09:00
Bartłomiej Dach
c88a802b05
Adjust font size to match web design
2020-07-07 23:04:39 +02:00
Andrei Zavatski
bdec13d4a4
Move DateTooltip to it's on file
2020-07-07 16:46:17 +03:00
Andrei Zavatski
447cd17cf6
Merge remote-tracking branch 'refs/remotes/ppy/master' into news
2020-07-07 16:36:41 +03:00
Dean Herbert
8152e0791d
Fix potential nullref
2020-07-07 21:48:42 +09:00
Andrei Zavatski
c86bb2e755
Use DrawableDate tooltip for DateContainer
2020-07-07 00:01:06 +03:00
Andrei Zavatski
68d9f9de46
Use DateTimeOffset
2020-07-06 23:55:20 +03:00
Andrei Zavatski
040b2a5aa8
Merge remote-tracking branch 'refs/remotes/ppy/master' into news
2020-07-06 23:51:39 +03:00
smoogipoo
dbbee481f6
Expose dialog body text getter
2020-07-06 22:01:45 +09:00
Lucas A
022e4b6335
Apply review suggestions.
2020-07-06 11:15:56 +02:00
Andrei Zavatski
fdb7727e95
Rename NewsPost to APINewsPost
2020-07-06 07:28:44 +03:00
Andrei Zavatski
7550097eb6
Implement NewsCard
2020-07-06 07:27:53 +03:00
Lucas A
641ea5b950
Make the disabling of the win key during gameplay a toggleable setting.
2020-06-30 13:12:33 +02:00
Dean Herbert
8f7f6881d3
Merge branch 'master' into update-framework
2020-06-16 16:46:22 +09:00
Dean Herbert
c79d8a4251
Update ChannelTabControl in line with TabControl changes
2020-06-16 00:18:09 +09:00
Dean Herbert
97067976f7
Add null check
2020-06-15 22:23:06 +09:00
Dean Herbert
53b7057ee0
Don't show update button when updates are not feasible
2020-06-15 22:19:11 +09:00
Dean Herbert
2a6faf6a8e
Merge branch 'master' into update-button
2020-06-15 22:06:02 +09:00
Dean Herbert
ad5bd1f0c0
Update in line with other/unspecified switch
...
See 289f0f0a20
.
2020-06-15 18:45:52 +09:00
Dean Herbert
7e0dc97fb4
Merge branch 'master' into genre-language-updates
2020-06-15 18:45:21 +09:00
Dean Herbert
1770b70b81
Change implementation to ensure flashBackground is not present by default
2020-06-15 16:14:35 +09:00
Dean Herbert
fe62b26d73
Merge branch 'master' into home-shortcut
2020-06-15 15:51:24 +09:00
Joehu
941fdf5e76
Fix flash background naming
2020-06-14 22:16:17 -07:00
Joehu
b41567c66c
Split hover and flash to separate boxes
2020-06-14 22:02:21 -07:00
Joehu
1f7679e829
Fix home button not flashing when pressing shortcut
2020-06-14 11:24:23 -07:00
Joehu
b8fa1a2c41
Add shortcut to go home
2020-06-14 11:22:38 -07:00
Bartłomiej Dach
aab606b237
Cancel scheduled asynchronous load of comments
2020-06-13 13:00:05 +02:00
clayton
7bc70e644a
Add Unspecified language
2020-06-13 00:20:34 -07:00
clayton
7212ab3a1a
Add new beatmap genres and languages
2020-06-12 23:48:30 -07:00
Dean Herbert
4f809767a5
Disable button while update check is in progress
2020-06-12 18:36:36 +09:00
Dean Herbert
6296cd62d0
Merge branch 'master' into update-button
2020-06-12 18:00:36 +09:00
smoogipoo
88aed1d504
Merge branch 'master' into update-inspectcode-version
2020-06-09 20:12:39 +09:00
Craftplacer
101604e741
Redesign classes and generally improve code
2020-06-08 00:39:33 +02:00
Craftplacer
e95ffcb528
Merge remote-tracking branch 'upstream/master' into update-button
2020-06-07 22:51:03 +02:00
Craftplacer
4e56981554
Merge remote-tracking branch 'upstream/master' into update-button
...
# Conflicts:
# osu.Game/Overlays/Settings/Sections/General/UpdateSettings.cs
2020-06-07 22:43:53 +02:00
smoogipoo
9c1542f897
Fix crash when pressing clear button twice
2020-06-04 22:17:00 +09:00
smoogipoo
f3b5149648
Move some suggestions to warnings, resolve issues
2020-06-03 16:48:44 +09:00
Andrei Zavatski
9aa54ed89e
Fix serach control background never being updated
2020-05-29 19:53:32 +03:00
Andrei Zavatski
affad47248
Fix genre/language search doesn't work
2020-05-29 19:44:53 +03:00
Dean Herbert
f989f1aa00
Change event flow to avoid firing store delete events on update
2020-05-27 16:08:47 +09:00
Dean Herbert
8ab65e4c5d
Move implementation into own class
2020-05-24 23:15:24 +09:00
Dean Herbert
c071fe6140
Add the ability to export skins
2020-05-24 13:44:11 +09:00
Dean Herbert
052ad79fc6
Convert dangerous events to IBindables
2020-05-19 16:44:22 +09:00
Dan Balasescu
533010f168
Merge branch 'master' into avoid-host-disable
2020-05-17 15:59:39 +09:00
Dean Herbert
9d3df14179
Remove unused variable
2020-05-16 11:03:27 +09:00
Dean Herbert
c47f02c3b7
Update second instance of disabling bindable
2020-05-16 08:24:02 +09:00
Dean Herbert
8bbb0c98e0
Merge branch 'master' into migration-ui
2020-05-15 17:39:18 +09:00
Dean Herbert
aec2520ef4
Avoid disabling a host-level bindable from osu! code
2020-05-15 17:31:06 +09:00
Dean Herbert
94cf99bf97
Fix mute button falling off the screen when UI scaling is used
2020-05-15 12:22:59 +09:00
Dean Herbert
155e918ca3
Remove unused parameter
2020-05-14 21:40:28 +09:00
Dean Herbert
42f446faa9
Fix remaining test failure
2020-05-14 21:10:04 +09:00
Dean Herbert
a582611647
Add test coverage
2020-05-14 19:05:35 +09:00
Dean Herbert
4e4a779d68
Improve overall UI
2020-05-14 17:41:55 +09:00
Dean Herbert
0b73063a89
Add basic (working) migration UI
2020-05-14 17:41:55 +09:00
Dean Herbert
c836c9319b
Combine pagination logic into BeatmapListingFilterControl
2020-05-14 15:35:11 +09:00
Dean Herbert
04c9973526
Clean up cancellation logic
2020-05-14 14:33:31 +09:00
Dean Herbert
fa3373e5f3
Reorder file and change naming slightly
2020-05-14 14:24:43 +09:00
Dean Herbert
5e09a1b334
Use Action rather than custom handler
2020-05-14 14:23:12 +09:00
「空白」
43450b5485
Resolve remaining InspectCode issues
...
> CI should now pass build test
2020-05-14 01:57:03 +09:00