1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-15 07:32:55 +08:00
Commit Graph

131 Commits

Author SHA1 Message Date
Salman Ahmed
7aaa88cac2 Convert data type of DistanceSpacing to float 2022-04-28 10:24:36 +03:00
Salman Ahmed
71533808e9 Add test case for DistanceSpacingMultiplier in distance snapping test scene 2022-04-28 07:14:43 +03:00
Salman Ahmed
500322ff21 Update failing snap test scenes 2022-02-15 02:21:53 +03:00
Bartłomiej Dach
b978010b48
Remove unused allowMissing parameter in audio file check test
No longer used since 7f95400f46.
2022-02-01 21:53:21 +01:00
Dean Herbert
b5f670cc5b Add far too many fixes for ruleset non-nullable requirements 2022-01-12 23:24:11 +09:00
Dean Herbert
4f66e8f881 Fix issues with editor check tests 2022-01-12 16:39:36 +09:00
Joseph Madamba
7de43e3aba Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
Dean Herbert
c7bc03e6f7 Add helper method for editor check tests 2021-11-24 14:22:41 +09:00
Dean Herbert
c2f8d9f677 Update tests which set Files lists directly 2021-11-24 14:00:14 +09:00
Naxesss
72ee2b1556 Refactor to avoid duplicate code 2021-11-10 06:18:40 +01:00
Naxesss
5dc6a9ed21 Add background stream closed test 2021-11-10 05:04:30 +01:00
Dean Herbert
d1e6d1cb98 Update some other missed incorrect null/empty usages 2021-11-04 14:50:43 +09:00
Dean Herbert
67d9590a79 Fix new inspections 2021-11-04 14:02:09 +09:00
smoogipoo
aa380a11c1 Merge branch 'master' into no-more-difficulty-control-points-info 2021-10-14 12:02:10 +09:00
Bartłomiej Dach
c7db286b94
Merge branch 'master' into file-sanity-checks 2021-10-14 00:17:29 +02:00
Dean Herbert
7f95400f46 Add proper stream disposal to tests 2021-10-12 11:04:41 +09:00
Naxesss
bb9cbd3e66 Undo disposal of Stream for use in mocking
Because the Stream object is accessed when the mocked object calls `GetStream`, we cannot close it here.

The resource should be released upon teardown anyway.
2021-10-12 00:35:58 +02:00
Naxesss
47b4d03145 Dispose of Streams when used 2021-10-12 00:13:38 +02:00
Naxesss
01d77fb741 Remove redundant Bass.Init call in test setup 2021-10-11 23:58:06 +02:00
smoogipoo
bc37cb6f43 Merge branch 'master' into no-more-difficulty-control-points-info 2021-10-08 18:41:17 +09:00
Dean Herbert
b339c149d8 Copy BaseDifficulty to Beatmap<T> and move all write operations across 2021-10-06 15:10:45 +09:00
Dean Herbert
1952ebece9 Update tests to use more correct control point definitions 2021-09-06 22:04:51 +09:00
Dean Herbert
b2a14b13dc Update outdated tests 2021-09-03 17:11:12 +09:00
Dean Herbert
d4e5a612ea Update IPositionalSnapProvider to take a HitObject as reference, rather than raw time
This allows fetching the correct `DifficultyControlPoint` from the
hitobject. Nothing more.
2021-09-03 17:11:12 +09:00
Dean Herbert
a3d9ab1e2e Move approach rate to EffectControlPoint 2021-09-03 16:58:16 +09:00
Dean Herbert
9fae2c350d Fix test regressions 2021-08-30 17:25:36 +09:00
Naxess
6da2a3d51f Add zero-length objects check and tests 2021-07-13 10:50:11 +02:00
Naxess
c8f58cbf6c Add audio in video check and tests 2021-07-13 04:17:41 +02:00
Naxess
a4a1919842 Add too short audio files check and tests 2021-07-13 03:46:45 +02:00
Naxess
0a8fd01b99 Add zero byte check and tests 2021-07-13 03:45:21 +02:00
Naxess
b58644106c Add nested hitobject tests for few hitsounds check 2021-06-27 15:58:00 +02:00
Naxess
1dbac76da5 Use local variables for common sample lists 2021-06-27 15:57:41 +02:00
Naxess
1d5bff1660 Add concurrent hitobjects test for few hitsounds check
See https://github.com/ppy/osu/pull/13669#discussion_r659314980
2021-06-27 15:26:52 +02:00
Naxess
c2ceb83bbb Move MockNestedHitObject to own class 2021-06-27 15:16:40 +02:00
Naxess
5642d321b7 Fix comments in few hitsounds check tests 2021-06-26 23:43:08 +02:00
Naxess
82b64f5589 Add hitsounded with break test 2021-06-26 19:57:12 +02:00
Naxess
a5abc664f3 Add few hitsounds check tests 2021-06-26 19:21:15 +02:00
Naxess
7b9569a117 Add muted object check tests 2021-06-26 19:21:01 +02:00
smoogipoo
e8bc2cac5b Fix test not being marked as headless 2021-05-19 13:36:39 +09:00
smoogipoo
ab6a79f84c Simplify 2021-05-18 19:15:46 +09:00
smoogipoo
97f4f7bbd1 Remove Component inheritance 2021-05-18 18:59:45 +09:00
smoogipoo
633f841a0f Rename to HitObjectUsageEventBuffer 2021-05-18 18:57:02 +09:00
smoogipoo
a31a6947bb Add test 2021-05-18 18:49:05 +09:00
Dean Herbert
9069db0743 Fix case of hitObjects variables 2021-05-14 16:22:19 +09:00
Naxess
9860e482af Use TestWorkingBeatmap instead of null in tests
Fixes the warning that #12801 will give.
2021-05-14 05:32:52 +02:00
Naxess
94538b3842 Remove accidental whitespace 2021-05-13 12:56:36 +02:00
Naxess
19800f5f7f Move IBeatmap arg into context 2021-05-13 11:24:22 +02:00
Naxess
c13b93e6f1 Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.

See next commit for example.
2021-05-12 02:29:18 +02:00
Naxess
200352b750 Rename unsnap check templates 2021-04-27 13:56:05 +02:00
Naxess
0f0870c8b8 Sort objects by time in concurrent check test 2021-04-27 00:36:26 +02:00
Naxess
ce258febf6 Rename CheckUnsnaps -> CheckUnsnappedObjects
Will potentially have `CheckUnsnappedKiai` or similar later, so this is worth specifying.

Also consistent with `CheckConcurrentObjects`, which will likely have a `CheckConcurrentLines` later.
2021-04-26 20:32:44 +02:00
Naxess
b8cdcf56c0 Add concurrent object check tests 2021-04-26 20:22:24 +02:00
Naxess
71f880aa94 Fix duplicate code in unsnap test 2021-04-26 17:44:46 +02:00
Naxess
9178aa1d7d Add unsnap check tests 2021-04-26 04:48:56 +02:00
Naxess
c0318a4d3e Fix usage of _ in Moq lambdas 2021-04-20 13:29:14 +02:00
Naxess
6a1e4ff99f Add file hash to file presence test
Necessary because we now find the storage path of the file rather than just the file itself.
2021-04-20 13:28:32 +02:00
Naxess
2bb079ea14 Add audio quality check tests 2021-04-20 01:36:15 +02:00
Naxess
be6a02a17e Simplify background quality test names 2021-04-20 01:32:22 +02:00
Naxess
8656176ab8 Add the playable beatmap as check argument
This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.

So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.

This should be preferred over `workingBeatmap.Beatmap`.
2021-04-20 01:31:51 +02:00
Naxess
010720de74 Factor out general file presence checking
This allows us to use the same method of checking for other files that should exist, for example the audio file.

By using the same method, they all share test cases too.
2021-04-18 02:07:33 +02:00
Naxess
0502fbb429 Add background quality check tests 2021-04-18 01:21:51 +02:00
Naxess
448574e7e6 Use WorkingBeatmap instead of IBeatmap
This lets us access things like the background, track, etc. which are necessary for quality and filesize checks.

Also improves the structure of the `CheckBackgroundTest` class in the process.
2021-04-17 17:33:53 +02:00
Dean Herbert
b45d7de4ec Update asserts to use better nunit specifications 2021-04-13 15:04:01 +09:00
Naxess
6d3f9fa9ce Use is class instead of Equals with template index
Ensures ordering of `PossibleTemplates` does not affect tests.
2021-04-13 02:29:25 +02:00
Naxess
0bcc39bd36 Remove redundant space 2021-04-13 02:17:35 +02:00
Naxess
47cf4bcf25 Add CheckBackground tests 2021-04-13 01:22:24 +02:00
smoogipoo
5760e1c1fc Make HitSampleInfo immutable 2020-12-01 15:37:51 +09:00
Dan Balasescu
6bea78619a
Update comment
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-11-30 13:33:29 +09:00
Dean Herbert
a9c59eed02 Add test coverage of fail scenario 2020-11-27 16:56:26 +09:00
Dean Herbert
c2a5fd2832 Add test coverage 2020-11-08 00:17:11 +09:00
Dean Herbert
7ffab38728 Add test coverage of TransactionalCommitComponent 2020-10-08 18:04:07 +09:00
Dean Herbert
1f2dd13b49 Update tests 2020-10-06 22:10:13 +09:00
Dean Herbert
0cb3926e1d Add event on EditorChangeHandler state change 2020-10-02 15:44:34 +09:00
Dean Herbert
3cf430f494 Avoid saving state changes if nothing has changed (via binary comparison) 2020-09-28 15:30:51 +09:00
Craftplacer
db413686bb Add BeatmapSkin to EditorBeatmap 2020-08-30 21:12:45 +02:00
Craftplacer
00b68b050c Merge remote-tracking branch 'upstream/master' into combo-colors 2020-08-30 10:16:38 +02:00
Dean Herbert
6c7475f085 Fix snapped distances potentially exceeding the source distance
This results in slider placement including "excess" length, where the
curve is not applied to the placed path. This is generally not what we
want.

I considered adding a bool parameter (or enum) to change the
floor/rounding mode, but on further examination I think this is what we
always expect from this function.
2020-08-25 18:58:01 +09:00
Craftplacer
c4a7fac760 Add required parameters and other various changes 2020-08-15 22:03:24 +02:00
Craftplacer
69590113d6 Temporary changes 2020-08-12 06:40:21 +02:00
smoogipoo
c96bc5c51c Fix undo/redo behaving poorly with simultaneous objects 2020-04-30 20:39:41 +09:00
Salman Ahmed
e3a3144236
Rename editor tests namespace from "Editor" to "Editing" 2020-04-23 11:07:55 +03:00