Dean Herbert
ab458320c4
Fix some lingering inspections
2022-11-09 17:46:24 +09:00
maromalo
b7ef9b176d
Make score type consistent
2022-11-06 19:59:27 -03:00
Dean Herbert
e02c477008
Merge pull request #21017 from andy840119/remove-nullable-disable-in-the-checks
...
Remove nullable disable in the checks.
2022-11-06 18:39:03 +09:00
Bartłomiej Dach
84179fb087
Merge branch 'master' into combo-colour-brightness-limit
2022-11-05 16:48:56 +01:00
andy840119
b0673636ca
Remove nullable disable annotation in the osu ruleset.
2022-11-05 16:49:55 +08:00
Bartłomiej Dach
6c819cba02
Add test coverage for regressed scenarios
2022-11-04 19:46:23 +01:00
Dean Herbert
923d44a769
Update dependencies
2022-11-04 17:00:58 +09:00
Dean Herbert
3ec9686e58
Fix test failures and rename configuration value to match better
2022-11-02 18:15:18 +09:00
Dean Herbert
cd8dc9b17b
Rename "Target" to "Target Practice"
2022-11-01 19:47:20 +09:00
Dan Balasescu
2d829c3beb
Merge pull request #20945 from peppy/fix-misplaced-slider-head
...
Fix slider heads getting misplaced after flipping in editor
2022-10-27 12:51:27 +09:00
Bartłomiej Dach
f787da892b
Merge branch 'master' into grid-momentary-shortcuts
2022-10-26 21:30:24 +02:00
Dean Herbert
614011d612
Update TestSceneObjectOrderedHitPolicy
to provide better output
2022-10-26 15:25:50 +09:00
Dean Herbert
cab9a1c012
Add test coverage of distance snap grid failing visually
2022-10-26 13:10:54 +09:00
Dean Herbert
5f10b81af1
Move distance snap grid test cursor behind grid to better visualise centre-points
2022-10-26 13:10:54 +09:00
Dean Herbert
cbcebfa130
Remove switch back to selection tool to simplify test flow
2022-10-26 12:18:56 +09:00
Bartłomiej Dach
48057412f5
Merge branch 'master' into grid-momentary-shortcuts
2022-10-25 22:17:08 +02:00
Dean Herbert
521fbd2ea3
Merge pull request #20345 from mk56-spn/Freeze_frame_implementation
...
Add "Freeze Frame" mod
2022-10-26 01:28:23 +09:00
Dean Herbert
16ef0b09e8
Add test coverage of momentary toggles
2022-10-25 14:36:35 +09:00
Dean Herbert
a9755295e4
Update tests in line with new behaviour
2022-10-25 14:32:08 +09:00
Dean Herbert
3d72ff28c3
Add test scene for "Freeze Frame" mod
2022-10-25 13:25:38 +09:00
Salman Ahmed
f444bb9ba6
Update existing test case
2022-10-20 03:55:53 +03:00
Salman Ahmed
7e9229a117
Merge branch 'master' into no-scope-no-smoke
2022-10-15 16:42:34 +03:00
Salman Ahmed
ba72f13f54
Merge branch 'master' into hide-mouse-on-keyboard-input
2022-10-14 22:26:30 +03:00
Salman Ahmed
b1b97505ac
Fix smoke displayed in "No scope" mod
2022-10-14 22:16:14 +03:00
Dan Balasescu
10aabfc650
Merge pull request #20739 from peppy/settings-toolbox
...
Adjust visuals of settings toolboxes (gameplay loading screen and editor)
2022-10-14 20:31:05 +09:00
Salman Ahmed
516e99df72
Add test coverage for flashlight mod
2022-10-14 02:38:43 +03:00
Dean Herbert
6608ada925
Fix test failures due to missing colour provider dependency
2022-10-13 17:05:11 +09:00
Salman Ahmed
09cc89cfa0
Update existing usages of Cursor
to handle null value
2022-10-13 00:17:08 +03:00
D.Headley
83aedb1930
Make mod use new Combo, remove pointless test
2022-10-12 12:42:26 +02:00
OliBomby
b22e201289
Fixed stream convert float precision edge case
2022-10-08 23:43:23 +02:00
MK56
8fe89d5de2
Merge branch 'ppy:master' into Freeze_frame_implementation
2022-10-07 22:23:51 +02:00
Dean Herbert
072b64b8d4
Update all dependencies
2022-10-07 21:16:11 +09:00
Alden Wu
2c0cd9ea52
Add more smoke tests
2022-10-05 19:09:34 -07:00
Alden Wu
eaab0deef3
Fix InspectCode issues
2022-10-03 19:20:51 -07:00
Alden Wu
ccef189b81
Add barebones test for smoke
2022-10-03 18:19:05 -07:00
Dean Herbert
a94b4e402e
Merge branch 'master' into argon-spinner
2022-09-23 14:22:53 +09:00
Pasi4K5
d538295ad5
Add TestSceneOsuModRandom
2022-09-22 23:04:43 +02:00
Salman Ahmed
a771d4031f
Separate triangles-specific test steps to own scene
2022-09-22 21:27:06 +03:00
Dan Balasescu
5dbe73ad0e
Merge pull request #20398 from peppy/fix-missing-notelock-shake
...
Fix "note lock" shake not always animating
2022-09-22 20:07:38 +09:00
Dan Balasescu
4528c1037b
Resolve CI inspections
2022-09-22 19:26:27 +09:00
Dean Herbert
b844d76311
Move Shake
logic local to hitcircle/slider
2022-09-22 15:04:20 +09:00
Dean Herbert
4492a26b59
Merge branch 'master' into argon-skin
2022-09-21 13:00:16 +09:00
Dan Balasescu
8bf196d561
Merge pull request #20354 from peppy/default-skin-refactor
...
Rename default skin to make way for new version
2022-09-21 11:48:38 +09:00
Dean Herbert
f6b29d8ebc
Make TestSceneHitCircle
show more than one cirle to make testing easier
2022-09-19 12:38:34 +09:00
Dean Herbert
d0b8409de5
Apply more renames
2022-09-18 18:19:00 +09:00
Dean Herbert
41e69fbca6
Remove "default" prefix from naming
2022-09-18 00:15:26 +09:00
Dean Herbert
51841988bf
Rename references to DefaultSkin
to have Triangles
suffix
2022-09-17 23:57:25 +09:00
Salman Ahmed
fe72237118
Remove unused using
2022-09-16 20:08:50 +03:00
Salman Ahmed
f512106bee
Adjust test scene to match expectations
...
- Adds a scenario where no button is pressed before second hitobject.
- Adjusts press time to not conflict with break start time.
2022-09-16 20:00:44 +03:00
MK56
3fe94b1620
Merge branch 'ppy:master' into Freeze_frame_implementation
2022-09-16 14:29:44 +02:00
Mk-56spn
6db8f51c02
Improve Tests
...
Fix divisor in test
Add Copyright header
2022-09-16 13:45:18 +02:00
Dean Herbert
c7f8f948b9
Rename CreateLegacySkinProvider
to CreateSkinTransformer
and apply to all skins
2022-09-15 20:18:10 +09:00
Dean Herbert
65d1c40dd5
Remove remaining package references and replace with SQLitePCLRaw
direct reference
...
This may require further consideration for test and iOS projects.
2022-09-15 16:58:58 +09:00
Mk-56spn
cb17fb2091
Create Test Scene
2022-09-09 23:13:19 +02:00
Dean Herbert
6a35b233e5
Merge branch 'master' into remove-dispose-updates
2022-09-01 23:03:19 +09:00
Dean Herbert
a15ea71aed
Merge branch 'master' into fix-merge-crash
2022-08-31 13:28:57 +09:00
Dean Herbert
706ac3e44f
Merge pull request #19982 from OliBomby/fix-illegal-merge
...
Fixed 0 length merge being allowed
2022-08-30 12:28:18 +09:00
Dean Herbert
a215d009fe
Update Remove
/RemoveRange
/RemoveAll
calls in line with framework changes
2022-08-29 15:57:40 +09:00
OliBomby
ff2eac79d1
fix same time merge causing crash
2022-08-27 17:43:32 +02:00
OliBomby
16e0ec2f88
Fixed 0 length merge being allowed
2022-08-27 13:53:50 +02:00
Dean Herbert
90ff0864c0
Merge branch 'master' into no-gameplay-clock-editor-offset
2022-08-26 20:25:21 +09:00
Dean Herbert
69cbc0125b
Merge pull request #19964 from nanashi-1/merge-hitobject-hitsound-fix
...
Fix hitobjects merge feature in editor not adding any hitsounds
2022-08-26 20:05:02 +09:00
Dean Herbert
cb1c4a1bb1
Move sample checks to be inline in other existing tests
2022-08-26 19:18:15 +09:00
Dean Herbert
03dcfed384
Merge branch 'master' into slider-splitter
2022-08-26 19:10:33 +09:00
Dean Herbert
4b72e55770
Fix various test scenes not adding EditorClock
to the draw hierarchy
2022-08-26 18:08:43 +09:00
nanashi-1
78717956d5
add visual test
2022-08-26 16:55:18 +08:00
nanashi-1
16fee7ac1c
add visual test
2022-08-25 19:31:47 +08:00
OliBomby
631ea9a3ed
added a gap between objects and made it theoretically possible to retain sample control point
2022-08-23 23:29:59 +02:00
OliBomby
7732fb21d5
fix code quality
2022-08-20 16:09:02 +02:00
OliBomby
614ae815c0
Added tests for making sure flipping and rotating retains perfect control point type
2022-08-20 15:57:39 +02:00
OliBomby
91e6f4c4ee
fix TestPerfectCurveChangeToBezier
2022-08-19 19:31:47 +02:00
OliBomby
d1519343f6
Improved visual tests for slider splitting
2022-08-19 18:29:01 +02:00
OliBomby
89eb0a4079
Added TestScene for slider splitting
2022-08-19 01:10:54 +02:00
Dan Balasescu
5d8d584afb
Fix some backwards asserts
2022-08-18 18:08:46 +09:00
Dean Herbert
a5ac69a554
Update various dependencies
2022-08-17 16:57:56 +09:00
Dean Herbert
615c5cf6ae
Merge branch 'master' into slider-merger
2022-08-17 13:36:15 +09:00
OliBomby
d021218d78
added test for objects which cant be merged
2022-08-16 23:05:35 +02:00
OliBomby
d140e0df14
remove nullable disable annotation
2022-08-15 21:15:23 +02:00
OliBomby
7c2ada9b20
Revert "remove copyright notice from new file"
...
This reverts commit b5e5411348
.
2022-08-15 21:11:06 +02:00
OliBomby
b5e5411348
remove copyright notice from new file
2022-08-15 18:07:55 +02:00
OliBomby
d261be8734
added visual tests
2022-08-15 17:19:04 +02:00
Dean Herbert
6d78218142
Update usages of GameplayClockContainer.GameplayClock
to access properties directly
2022-08-15 18:08:49 +09:00
Dean Herbert
0087935708
Update TestSceneSpinnerRotation
to use constraint-based assertions
2022-08-15 18:05:39 +09:00
Dan Balasescu
9f28c4c033
Adjust test values
2022-08-11 19:47:32 +09:00
Dan Balasescu
5a1c05918f
Fix test failures
2022-08-02 20:18:45 +09:00
Dan Balasescu
b4e55f7309
Apply IRenderer changes
2022-08-02 19:50:57 +09:00
andy840119
8fa5765573
Remove nullable disable annotation in the Osu test case.
2022-07-26 23:58:50 +08:00
Dan Balasescu
cfb2adfd27
Merge branch 'master' into velocitychanges
2022-07-19 19:57:47 +09:00
Dan Balasescu
842fe32003
Update test values
2022-07-19 19:57:36 +09:00
Dean Herbert
be3187c3a4
Remove remnant nullable disables
2022-07-13 22:05:56 +09:00
James
886efbcbdf
add test scene for Single Tap mod
2022-07-12 23:18:24 +01:00
Dean Herbert
3d9252e4b8
Merge branch 'master' into osu-mod-repel
2022-07-12 15:19:05 +09:00
Dean Herbert
44d2e001ed
Update various dependencies
2022-07-11 20:16:49 +09:00
Dean Herbert
958c0fb390
Remove Appveyor.TestLogger
2022-07-11 15:01:16 +09:00
Gabe Livengood
b3f23d93e8
Merge branch 'master' into osu-mod-repel
2022-07-06 17:05:09 -04:00
Dan Balasescu
385bd5a1b2
Merge pull request #18965 from peppy/mark-flaky-tests
...
Mark, document and silence remaining flaky tests on standard CI runs
2022-07-03 21:41:14 +09:00
Dean Herbert
cdc4caa8c4
Merge pull request #18945 from goodtrailer/separate-ball-followcircle
...
Separate slider ball and followcircle skinnables into default/legacy classes
2022-07-01 17:54:29 +09:00
Dean Herbert
b597843579
Mark and document remaining flaky tests
2022-07-01 16:17:40 +09:00
Dan Balasescu
6c2d02fefd
Fix tests
2022-06-30 12:37:03 +09:00
goodtrailer
0e0e9968ac
Split ball and followcircle into default/legacy files
2022-06-29 01:23:35 -07:00
Dean Herbert
8cda55e224
Merge pull request #18795 from smoogipoo/full-size-follow-circle
...
Track the full size of the follow circle at all times
2022-06-28 19:20:34 +09:00
Dean Herbert
35745c83b7
Replace dodgy SetUpSteps
overriding with usage of HasCustomSteps
2022-06-28 15:19:02 +09:00
Dean Herbert
5a7d339cc8
Centralise and harden editor-ready-for-use check
...
Not only does this combine the check into one location, but it also adds
a check on the global `WorkingBeatmap` being updated, which is the only
way I can see the following failure happening:
```csharp
05:19:07 osu.Game.Tests: osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation.TestAddAudioTrack
05:19:07 Failed TestAddAudioTrack [161 ms]
05:19:07 Error Message:
05:19:07 TearDown : System.NullReferenceException : Object reference not set to an instance of an object.
05:19:07 Stack Trace:
05:19:07 --TearDown
05:19:07 at osu.Game.Database.ModelManager`1.<>c__DisplayClass7_0.<AddFile>b__0(TModel managed) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 36
05:19:07 at osu.Game.Database.ModelManager`1.<>c__DisplayClass8_0.<performFileOperation>b__0(Realm realm) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 49
05:19:07 at osu.Game.Database.RealmExtensions.Write(Realm realm, Action`1 function) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\RealmExtensions.cs:line 14
05:19:07 at osu.Game.Database.ModelManager`1.performFileOperation(TModel item, Action`1 operation) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 46
05:19:07 at osu.Game.Database.ModelManager`1.AddFile(TModel item, Stream contents, String filename) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 36
05:19:07 at osu.Game.Screens.Edit.Setup.ResourcesSection.ChangeAudioTrack(FileInfo source) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Screens\Edit\Setup\ResourcesSection.cs:line 115
05:19:07 at osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation.<TestAddAudioTrack>b__13_0() in C:\BuildAgent\work\ecd860037212ac52\osu.Game.Tests\Visual\Editing\TestSceneEditorBeatmapCreation.cs:line 101
05:19:07 at osu.Framework.Testing.Drawables.Steps.AssertButton.checkAssert()
05:19:07 at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
05:19:07 at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
```
2022-06-27 16:22:01 +09:00
Dean Herbert
31a447fda0
Update parameter discards
2022-06-24 21:26:19 +09:00
Dean Herbert
f71f6302fd
Remove unnecessary null
casts
2022-06-24 14:50:11 +09:00
Dan Balasescu
043aa82a31
Add test
2022-06-21 18:09:00 +09:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Gabe Livengood
2fe34f188f
shamelessly copy osumodmagnetised
2022-06-09 18:52:10 -04:00
Gabe Livengood
569c39942a
replace easement with easing
2022-06-09 18:26:18 -04:00
Gabe Livengood
e5171aaebf
update tests to match new bindable names
2022-06-07 09:48:53 -04:00
Bartłomiej Dach
a8e1c5ba87
Fix remaining cases of incorrect GameplayState
construction in tests
...
Manual attempts to initialise replaced by a new `TestGameplayState`
helper for ease of use.
2022-05-28 15:23:29 +02:00
Gabe Livengood
5d838628d7
add test, fix formatting, expose easing function
2022-05-27 23:15:19 -04:00
Dean Herbert
2e21d75b10
Move metronome into own class and rename to avoid conflict with mod sounds
2022-05-20 17:30:04 +09:00
Dean Herbert
f22ff4e087
Remove editor animation toggling (replaced by overlap markers)
2022-05-12 19:28:56 +09:00
Dean Herbert
fda61943b0
Update distance snap test when cursor at centre of grid to be in line with expectations
2022-05-12 13:11:55 +09:00
Dean Herbert
fecf92e16f
Update libraries to latest versions
2022-05-11 19:54:59 +09:00
Salman Ahmed
b119726b28
Reword test step
2022-05-06 15:38:38 +03:00
Dean Herbert
daed42513e
Fix outdated test asserts
2022-05-06 18:44:25 +09:00
Dean Herbert
9fd98b8060
Also add test coverage of adjsuting the distance spacing multiplier
2022-05-05 18:49:12 +09:00
Dean Herbert
4fe23bced2
Update tests with new assumptions and a better snap implementation
2022-05-05 18:49:12 +09:00
Salman Ahmed
269e15c167
Add test coverage of distance spacing multiplier working with distance snap grid
2022-05-05 18:49:12 +09:00
Dean Herbert
de9b3d33eb
Rename misleading DistanceSpacing
variable
2022-05-05 17:08:09 +09:00
Dean Herbert
19cf9dc20b
Merge branch 'snapping-tidy-distance'
2022-05-05 16:51:32 +09:00
Dean Herbert
977e6d8a80
Add xmldoc for IDistanceSnapProvider
and related properties
2022-05-05 16:25:45 +09:00
Dean Herbert
f6fc926f1a
Add xmldoc and rename methods in IPositionSnapProvider
for legibility
2022-05-05 15:58:21 +09:00
Dean Herbert
faeefc5e18
Merge pull request #16576 from frenzibyte/osu-distance-spacing
...
Add "distance spacing" support in editor for osu! ruleset
2022-05-03 12:15:18 +09:00
Salman Ahmed
fef94d49f4
Revert "Convert data type of DistanceSpacing
to float"
...
This reverts commit 7aaa88cac2
.
2022-04-29 08:02:07 +03:00
Salman Ahmed
723d70be70
Change TestInputSingularWithBreak
to reproduce case of pressing before second object
2022-04-29 05:38:14 +03:00
Salman Ahmed
7442ae283c
Tidy up test cases a touch
2022-04-29 05:25:22 +03:00
Salman Ahmed
abb88b0907
Move distance spacing application to DistanceSnapGrid
2022-04-28 10:54:38 +03:00
Salman Ahmed
7aaa88cac2
Convert data type of DistanceSpacing
to float
2022-04-28 10:24:36 +03:00
Salman Ahmed
2e8372fe90
Minor cleanup
...
Just from reading diff.
2022-04-28 07:14:43 +03:00
Salman Ahmed
a5defbe496
Keep distance spacing reset to one on test scenes with slider snapping for now
2022-04-28 06:44:50 +03:00
Salman Ahmed
835898dd30
Introduce DistancedHitObjectComposer
and supersede OsuToolboxComposite
2022-04-28 06:44:50 +03:00
Salman Ahmed
8ed39009fd
Encapsulate distance spacing control handling to a "distance toolbox composite"
...
Encapsulated in a way which can allow further extensibility for the
right-side area of toolboxes.
2022-04-24 08:33:03 +03:00
Salman Ahmed
70a93c0e7e
Move DistanceSpacingMultiplier
bindable to its own IDistanceSnapProvider
interface
2022-04-24 08:33:00 +03:00
Salman Ahmed
4f8f27a58b
Merge branch 'master' into osu-distance-spacing
2022-04-24 05:23:30 +03:00
Salman Ahmed
610d61dce9
Fix TestSceneSliderApplication
not applying legacy skin transformer
2022-04-23 03:34:05 +03:00
Salman Ahmed
858c8f927f
Attach comment explaining purpose of CallBase
2022-04-20 00:27:02 +03:00
Salman Ahmed
fd20c2bdcd
Change circle/overlay sprite fields to protected
for better test assertion
2022-04-20 00:24:28 +03:00
Salman Ahmed
813dc2dd78
Fix wrong prefix for default priority lookup in test
2022-04-19 19:46:29 +03:00
Salman Ahmed
f92a41b6c3
Replace local TestSkin
implementation with simplified Moq setups
2022-04-19 08:04:13 +03:00
Salman Ahmed
8d0dd3961e
Add failing test cases
2022-04-19 07:12:07 +03:00
Dean Herbert
ee8451c8ca
Merge branch 'master' into osu-diff-calc-max-combo
2022-04-04 14:20:44 +09:00
Dean Herbert
de625125d6
Rename magnetised mod attraction strength property to match new naming
2022-04-01 13:03:48 +09:00
Dean Herbert
a987cda30d
Rename "Aim Assist" to "Magnetised" to better suit the mod's behaviour
...
As proposed in https://github.com/ppy/osu/discussions/17375 .
2022-04-01 12:15:52 +09:00
Dan Balasescu
32e55e7d78
Merge branch 'master' into osu-diff-calc-max-combo
2022-03-31 15:08:08 +09:00
Dean Herbert
0cac935939
Shorten class name of ModCreatedReplayUser
2022-03-31 11:34:23 +09:00
Dean Herbert
4b2c01a8c1
Bring all mod implementations up-to-date
2022-03-29 16:59:03 +09:00
Dean Herbert
5fb51b578f
Update dependencies
...
Mainly for a `Clowd.Squirrel` bump to fix https://github.com/ppy/osu/discussions/17190 .
2022-03-09 19:09:51 +09:00