Dean Herbert
f32d56e213
Bring HoldForMenuButton tests up-to-date in code quality
2022-01-28 14:48:17 +09:00
Dean Herbert
5288eedd31
Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID
2022-01-27 15:38:03 +09:00
Dean Herbert
cd71ec0edd
Remove ILive<> interface (and use abstract Live<> instead)
2022-01-26 13:38:56 +09:00
Dean Herbert
778d2a71b4
Remove Task from the inner-most Import method in RealmArchiveModelImporter
...
One of my pending work items for post-realm merge.
The lowest-level import task is no longer asynchronous, as we don't want
it to span multiple threads to allow easier interaction with realm.
Removing the `Task` spec simplifies a heap of usages.
Individual usages should decide whether they want to run the import
asynchronously, by either using an alternative override or spooling up a
thread themselves.
2022-01-25 15:30:29 +09:00
Bartłomiej Dach
735414bc49
Replace TimeSignatures enum with struct for storage of arbitrary meter
2022-01-22 20:50:31 +01:00
Dean Herbert
7f65f3a47f
Remove all usage of BaseDifficulty (and access Difficulty instead)
2022-01-18 22:57:39 +09:00
Dean Herbert
90166829c3
Update tests which were importing scores without a valid beatmap
2022-01-17 14:47:19 +09:00
Bartłomiej Dach
03e4ec4214
Merge branch 'master' into realm-integration/score-and-beatmaps
2022-01-15 14:45:42 +01:00
Susko3
19467e58c1
Remove unused params from BDL methods
2022-01-15 01:06:39 +01:00
Dean Herbert
8d4a3cc569
Remove pointless Metadata set
2022-01-14 23:27:33 +09:00
Dean Herbert
5cbd731864
Add RulesetInfo hashcode implementation and tidy up equality
2022-01-12 17:49:10 +09:00
Dean Herbert
605898ec53
Add missing "non-null" elements missing from some tests
2022-01-12 17:49:10 +09:00
Dean Herbert
6251713796
Add missing Ruleset in ReplayRecorder tests
2022-01-12 17:00:17 +09:00
Dean Herbert
31a3161189
Make tests compile again
2022-01-12 17:00:16 +09:00
Dean Herbert
213d89b479
Update null fallback cases involving OnlineID
2022-01-12 16:39:36 +09:00
Dan Balasescu
af9fad00c3
Merge branch 'master' into async-deadlock-safety
2022-01-10 16:11:09 +09:00
Dean Herbert
3cd996eb4a
Merge branch 'master' into async-deadlock-safety
2022-01-07 17:28:59 +09:00
Dean Herbert
00177a3ae1
Update usages to new naming
2022-01-06 22:54:43 +09:00
Bartłomiej Dach
66613cbaa4
Wait for async continuation in score submission test
...
The previous assert step was optimistically assuming that the async
continuation that writes the value of
`FakeImportingPlayer.ImportedScore` always completes before it, but
that's not necessarily true even if the continuation is instant (it is
still subject to things like task scheduling and TPL thread pool
limits).
To ensure no spurious failures, swap out the assert step for an until
step instead.
2022-01-06 13:09:25 +01:00
Bartłomiej Dach
84765b99b3
Handle score submission request in submission test scene
...
Was previously not handled at all, therefore displaying request failures
in the test log output. While that was mostly a red herring and
shouldn't have caused any actual *test* failures, it is still better to
handle this explicitly in a realistic manner.
2022-01-06 12:57:26 +01:00
Dean Herbert
73b40e6833
Replace usage of .Result with .WaitSafelyForResult
2022-01-04 11:51:41 +09:00
Bartłomiej Dach
7cdba2f7c3
Add test coverage of score submission if player is exited during import
2022-01-03 22:00:47 +01:00
Dean Herbert
04d8fd3a58
Improve reliability of TestStoryboardSkipOutro
...
Aims to resolve failures as seen at
https://github.com/peppy/osu/runs/4677353822?check_suite_focus=true .
Have run quite a lot locally with no failures (while removing the skip step 100% fails).
2022-01-01 15:32:39 +09:00
Bartłomiej Dach
34b0101ff4
Add visual test coverage of "hidden by ruleset" combo option
2021-12-26 16:49:18 +01:00
Dean Herbert
f3f491374b
Remove unused load checks
2021-12-22 18:17:00 +09:00
Bartłomiej Dach
54790bb758
Merge branch 'master' into fix-realm-post-storage-migration-failure
2021-12-17 00:19:46 +01:00
Dan Balasescu
eb3050b2ac
Fix incorrect test
2021-12-14 15:08:00 +09:00
Dean Herbert
441b7baa93
Provide a realm factory to usages of ToLive/RealmLive
2021-12-14 14:26:34 +09:00
Dean Herbert
309290a3c9
Use new method in more places that can benefit from it
2021-12-13 16:56:43 +09:00
Dean Herbert
bff02bedbf
Rename APIScoreInfo to APIScore
2021-12-10 16:11:49 +09:00
Dean Herbert
a969fe3ef8
Add test coverage showing intended UX of user's volume levels being retained when unmuting
2021-12-08 13:37:47 +09:00
Dean Herbert
9033169177
Merge pull request #15951 from peppy/fix-failing-recorder-tests-w
...
Fix intermittent test failures in scenes using `SpectatorClient`
2021-12-06 18:40:27 +09:00
Dan Balasescu
568364b604
Fix indentation
2021-12-06 17:38:57 +09:00
Dean Herbert
0d3d22d3e1
Update TestSceneReplayReocorder to be safer about disposal
2021-12-06 17:09:12 +09:00
Dean Herbert
50a5f52f92
Remove duplicated test scene (see TestSceeneReplayRecorder)
2021-12-06 17:09:11 +09:00
Dean Herbert
d58b85b381
Refactor TestScenSpectatorPlayback to properly clean up without async disposal
2021-12-06 17:09:11 +09:00
Dean Herbert
452fa93444
Merge branch 'master' into realm-integration/skins-rebase
2021-12-06 15:21:02 +09:00
Dean Herbert
1eed2436e6
Clean up unused resolved properties
2021-12-03 18:49:49 +09:00
Dean Herbert
f6a3709060
Store default skins to database
2021-11-29 18:28:25 +09:00
Dean Herbert
23146d59d1
Use ILive for current skin
2021-11-29 18:28:25 +09:00
Dean Herbert
f283770f34
Update mock RulesetInfo usage to set OnlineID instead of ID
2021-11-24 15:50:26 +09:00
Dean Herbert
b9923e5396
Remove subclassing of RulesetInfo
2021-11-22 16:39:17 +09:00
Dean Herbert
d7b178ea37
Update test scenes which should not handle key repeat
2021-11-18 13:13:36 +09:00
Dean Herbert
7c2e79f911
Update all simple cases of switching to IWorkingBeatmap
2021-11-17 20:56:57 +09:00
Dean Herbert
62d670a3ca
Update DifficultyCalculator to take an IWorkingBeatmap
2021-11-15 19:16:48 +09:00
Dean Herbert
5be22916bb
Add test coverage against frequency ramp increasing between fail animation and fail screen
2021-11-14 14:41:17 +09:00
Dean Herbert
6a098a8634
Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface
2021-11-12 17:46:24 +09:00
Bartłomiej Dach
dbdbfc4723
Add failing test case for PP counter not initially updating
2021-11-11 16:33:31 +01:00
Bartłomiej Dach
9bad912dd0
Add failing test case
2021-11-11 13:22:06 +01:00
Bartłomiej Dach
03a315b9f5
Fix missing beatmap in replay download test scene
...
Was causing nullrefs in `GetDisplayTitle()`.
2021-11-09 14:33:06 +01:00
Bartłomiej Dach
74c37e248d
Merge branch 'master' into master
2021-11-09 08:40:52 +01:00
Dean Herbert
78aef9ce86
Merge branch 'master' into remove-stupid-weak-reference-bindable-events
2021-11-08 13:35:49 +09:00
Bartłomiej Dach
6d30248cef
Merge branch 'master' into use-class-rename
2021-11-07 15:41:00 +01:00
Dean Herbert
0ecf5f201c
Rename User to APIUser and move to correct namespace
2021-11-07 11:26:01 +09:00
Dean Herbert
b8fb22b769
Add missing test coverage of score import process being tracked correctly
2021-11-06 16:45:55 +09:00
Chinmay Patil
77e853ce25
Optimized UR Counter and removed redundant code
2021-11-05 12:16:58 -06:00
Salman Ahmed
b723975767
Replace pragma with add/remove => throw
2021-11-05 09:10:38 +03:00
Salman Ahmed
af6ae1cce5
Remove hacky code with explicit pragma disable
2021-11-05 03:49:35 +03:00
Chinmay Patil
8923561b05
Removed Unnessicary class in the Test file, and optimized UR counter
2021-11-04 14:27:48 -06:00
Chinmay Patil
a76878e053
A bit more formatting
2021-11-04 09:52:16 -06:00
Chinmay Patil
c568888500
Edited to remove unessicary blank lines
2021-11-04 09:47:52 -06:00
Chinmay Patil
223efe55d5
Added Tests for UR counter
2021-11-04 09:23:29 -06:00
Dean Herbert
d1e6d1cb98
Update some other missed incorrect null/empty usages
2021-11-04 14:50:43 +09:00
Bartłomiej Dach
5dcff7d8b7
Merge branch 'master' into score-refactor/less-create-score-info
2021-11-01 11:41:20 +01:00
Bartłomiej Dach
6a44cf3ff1
Add missing beatmap spec in test scene
2021-11-01 09:44:08 +01:00
Dean Herbert
269a8df0ec
Fix HasReplay not being corrrectly implemented by APIScoreInfo
2021-11-01 13:20:37 +09:00
Dean Herbert
17a83f701a
Store mods as APIMods for the time being
2021-10-29 15:13:49 +09:00
Dean Herbert
1944c255a7
Implement score interfaces
2021-10-29 13:49:30 +09:00
Dean Herbert
817369903a
Rename API score classes
2021-10-29 13:40:56 +09:00
Dean Herbert
6944151486
Apply batch fixing of built-in types using var
2021-10-27 13:04:41 +09:00
Bartłomiej Dach
95ed9a431c
Add test coverage for no submission for ruleset with null ID
2021-10-19 00:06:07 +02:00
Dan Balasescu
8643c725cc
Merge pull request #15175 from peppy/fail-animation-flash-controlled-by-setting
...
Don't flash screen red on fail if the user has disabled red tinting
2021-10-18 15:27:10 +09:00
Dean Herbert
762949f49f
Don't flash screen red on fail if the user has disabled red tinting
2021-10-18 14:20:38 +09:00
Dean Herbert
0d992a0493
Add failing test showing epilepsy warning is not fading on early exit
2021-10-18 13:30:24 +09:00
Bartłomiej Dach
b34086a792
Add failing test case for incorrect RulesetID population in submission flow
2021-10-16 16:10:42 +02:00
Bartłomiej Dach
29ec498f6c
Add failing test case for player sending wrong ruleset ID to spectator server
2021-10-16 13:34:24 +02:00
Dan Balasescu
e49f1f6e6b
Merge branch 'master' into no-more-difficulty-control-points-info
2021-10-13 20:17:57 +09:00
Dean Herbert
26a1e40d24
Fix storyboard outro during fail test not being lenient enough
2021-10-13 13:48:57 +09:00
Bartłomiej Dach
8dcfc3dd7e
Replace no-op seeks with wait steps
2021-10-12 18:31:20 +02:00
Bartłomiej Dach
b1ad3161dd
Add failing test case for frame stable clock direction flip scenario
2021-10-11 21:25:02 +02:00
smoogipoo
bc37cb6f43
Merge branch 'master' into no-more-difficulty-control-points-info
2021-10-08 18:41:17 +09:00
Dan Balasescu
bece807857
Merge pull request #14980 from peppy/difficulty-move-to-beatmap
...
Copy `BaseDifficulty` to `Beatmap<T>` and move the majority of write operations across
2021-10-07 18:43:44 +09:00
Dean Herbert
697f53c445
Fix test failure due to reference of Player.Mods
2021-10-07 15:00:47 +09:00
Dean Herbert
b339c149d8
Copy BaseDifficulty to Beatmap<T> and move all write operations across
2021-10-06 15:10:45 +09:00
Dean Herbert
d6f25e07cc
Add assert coverage of non-downloadable states
2021-10-06 05:49:18 +09:00
Dean Herbert
31c0c7a888
Remove pointless (and incorrect) click step
2021-10-06 05:49:04 +09:00
Dean Herbert
777763a550
Add more comprehensive (and failing) test coverage of replay download button
2021-10-06 05:29:00 +09:00
Dean Herbert
98fef6ece2
Handle judgement reverts with actual display updates
2021-10-05 19:08:30 +09:00
Dean Herbert
0859c336de
Also dim counter during initial calculation phase
2021-10-05 17:24:36 +09:00
Dean Herbert
04538a69e4
Add assert tests
2021-10-05 17:10:24 +09:00
Dean Herbert
eeb5f3d519
Add basic test scene
2021-10-05 16:51:43 +09:00
smoogipoo
86df4919f7
Fix skin fallbacks test
2021-10-05 11:06:26 +09:00
smoogipoo
031c5a441e
Merge branch 'master' into realtime-pp-display
2021-10-04 20:19:37 +09:00
Dean Herbert
853cf6feaa
Rename last remaining BeatmapInfo Beatmap usage
2021-10-04 17:35:53 +09:00
Dean Herbert
32afd3f426
Replace all basic usages
2021-10-02 02:22:23 +09:00
smoogipoo
4e3d9da22d
Increase test lenience
2021-10-01 22:58:40 +09:00
Dan Balasescu
625711e6d2
Merge pull request #14776 from peppy/fix-pause-with-audio-offset
...
Avoid accounting for the pause pitch adjust effect when "fixing" hardware offset adjustments
2021-09-28 18:44:22 +09:00
Dean Herbert
46bafb6252
Merge branch 'master' into no-more-difficulty-control-points-info
2021-09-28 13:53:56 +09:00
Bartłomiej Dach
761548e533
Merge branch 'master' into 14470-ur-not-updating
2021-09-20 22:07:33 +02:00
sh0ckR6
93ca615c02
Add tests for clearing HitErrorMeter
...
Works with both `BarHitErrorMeter` and `ColourHitErrorMeter`
2021-09-19 14:15:22 -04:00
Opelkuh
366dbf5c3d
Add test for time jumps
2021-09-19 15:35:03 +02:00
Opelkuh
761da45f6a
Revert af4c3727d77a16e2534df9bbf452336b5c544342
2021-09-19 14:00:56 +02:00
Opelkuh
1d7d779f66
Merge branch 'master' into add-legacy-star-particles
2021-09-19 04:34:35 +02:00
Opelkuh
3f8454cb76
Remove abstract from ParticleSpewer
2021-09-19 03:19:16 +02:00
Opelkuh
ef530ed87c
Normalize particle velocity based on max duration
2021-09-18 23:45:58 +02:00
Opelkuh
846cde53b3
Add RelativePositionAxes support
2021-09-18 22:54:12 +02:00
Dean Herbert
45caeb84d3
Fix incorrect type specification when restoring bindable value
2021-09-17 16:28:47 +09:00
Dean Herbert
2c071a4d22
Add test coverage of pausing with a large audio offset
2021-09-17 15:43:38 +09:00
smoogipoo
f9d5abff8a
Update with keybinding changes
2021-09-16 18:26:12 +09:00
Dean Herbert
2df4073946
SpawnParticle -> CreateParticle (and set time outside of virtual call)
...
Allows easier overriding (no need to call the `base.CreateParticle` call
and worry about overwriting the time value.
2021-09-16 16:52:46 +09:00
Dean Herbert
a2dcef7c0a
Use local (or barebones BeatmapInfo) where feasible
2021-09-15 13:40:05 +09:00
smoogipoo
4b3ab42ffd
Ensure beatmap is populated
2021-09-15 13:18:46 +09:00
Opelkuh
b009772206
Fix code inspect failure
2021-09-13 21:44:28 +02:00
Opelkuh
224244801f
Remove Particles namespace
2021-09-13 21:44:27 +02:00
Opelkuh
7327603fc8
Fix outdated test step description
2021-09-13 21:44:26 +02:00
Opelkuh
cfcb46034c
Remove ParticleJet
2021-09-13 21:44:23 +02:00
Opelkuh
328c9a5dd0
Change ParticleSpewer.Active to a Bindable
2021-09-13 21:44:18 +02:00
Opelkuh
1a60ce164e
Add ParticleJet
2021-09-13 21:44:16 +02:00
Dean Herbert
9cf79a80c2
Replace many more calls to CreateAllMods with more specific calls
2021-09-10 12:04:55 +09:00
Dean Herbert
cf633973a9
Refactor exposed mod retrieval methods for better safety
2021-09-10 11:09:13 +09:00
Dean Herbert
766d789845
Rename ApproachRate to ScrollSpeed for now (to reduce complexity/confusion)
2021-09-06 21:06:13 +09:00
Dean Herbert
d587dc6203
Populate new approach rate where required
2021-09-03 17:11:12 +09:00
Dean Herbert
a3d9ab1e2e
Move approach rate to EffectControlPoint
2021-09-03 16:58:16 +09:00
Dean Herbert
4dd60e3299
Merge branch 'master' into taiko-drum-refacor
2021-08-30 14:12:52 +09:00
Dean Herbert
f078a9d2bf
Fix incorrect step type
2021-08-26 17:17:39 +09:00
Dean Herbert
6dcd9427ac
Remove bindable usage in PathControlPoint
...
This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.
I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.
2021-08-26 12:33:53 +09:00
Dean Herbert
7e6e2a7e29
Remove unused assignment
2021-08-25 17:39:06 +09:00
Dean Herbert
fc85ae0e34
Add test coverage
2021-08-25 16:56:44 +09:00
smoogipoo
342f2d756d
Fix test not working intermittently
2021-08-24 15:18:05 +09:00
Dan Balasescu
c95bf735fe
Merge branch 'master' into multiplayer-chat
2021-08-20 11:54:42 +09:00
Salman Ahmed
6ed3e469f7
Fix wrong attribute used for setup method
2021-08-18 06:50:01 +03:00
Salman Ahmed
f592350856
Fix config pollution in HUD overlay test scene
2021-08-18 04:59:08 +03:00
Dean Herbert
0d283aa6a3
Expose LocalUserPlaying from Player
2021-08-17 16:16:49 +09:00
Dean Herbert
8555a465ac
Merge pull request #14318 from bdach/editor-colours-save
...
Add support for saving edited combo colours and displaying them in composer
2021-08-16 17:07:53 +09:00
Salman Ahmed
9d99741663
Add failing test case
2021-08-16 06:56:59 +03:00
Bartłomiej Dach
6108451449
Retrieve separated skin instance from working beatmap for editing
2021-08-15 21:18:09 +02:00
Dean Herbert
e84224f64c
Rename AddPlayer method now that there's no conflict
2021-08-12 16:20:37 +09:00
Dean Herbert
68dbbc17e8
Add support for automatic scrolling in gameplay leaderboard
2021-08-12 16:20:37 +09:00
Dean Herbert
f4591b01d7
Add test step to show leaderboard in expanded state by default
2021-08-12 15:21:00 +09:00
Dean Herbert
9b9dacf3fe
Update usages of Drawable.Click()
2021-08-04 17:30:33 +09:00
smoogipoo
11b9ba86cb
Fix TestSceneSpectator reusing cached spectator client
2021-08-03 18:28:08 +09:00
Salman Ahmed
6b8de2a10b
Add test coverage for excluded cases in score submission
2021-07-11 03:35:35 +03:00
Dean Herbert
6ae631b03a
Remove previous seek testing logic from common test scene
2021-07-09 16:52:03 +09:00
Dean Herbert
9083b28114
Add test coverage of seeking and pausing
2021-07-09 14:47:11 +09:00
Dean Herbert
e612d7568c
Merge pull request #13771 from LumpBloom7/volume-meter-switch
...
Add ability to navigate between volume meters via Alt+Left/Right arrows
2021-07-07 21:50:44 +09:00
Dan Balasescu
09a5516cc6
Merge pull request #13811 from smoogipoo/remove-unused-using
...
Remove unused usings
2021-07-07 16:30:07 +09:00
Dan Balasescu
05c4e0254b
Merge pull request #13796 from peppy/fix-skin-providing-container
...
Rewrite `SkinProvidingContainer`
2021-07-07 15:43:24 +09:00
smoogipoo
faf95c7161
Remove unused usings
2021-07-07 15:35:14 +09:00
Dean Herbert
35672f372a
Shorten test beatmap to avoid timeouts in score submission test
2021-07-07 14:58:01 +09:00
Derrick Timmermans
4451598bcf
Fix remaining quality complaints
2021-07-06 15:17:19 +02:00
