Bartłomiej Dach
e5be8838e6
Fix yet another failure
2024-02-20 18:42:01 +01:00
Bartłomiej Dach
8abcc70b93
Add medal overlay to game
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
b334b78b63
Make medal overlay respect overlay disable via activation mode
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
e4971ae121
Add display queueing when multiple medals are granted in quick succession
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
2e5b61302a
Implement basic medal display flow
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
4911f5208b
Demote medal "overlay" to animation
...
I need the actual overlay to be doing way more things (receiving the
actual websocket events, queueing the medals for display, handling
activation mode), so the pre-existing API design of the overlay just
will not fly.
2024-02-20 16:31:31 +01:00
Dean Herbert
398eaee5d0
Merge pull request #27238 from bdach/disable-nested-managers-when-skin-editor-open
...
Disable nested input managers on edited screen when skin editor is open
2024-02-19 19:27:26 +08:00
Bartłomiej Dach
f5666185ab
Merge pull request #27239 from peppy/fix-cached-beatmap
...
Fix `WorkingBeatmapCache` caching beatmap in wrong state leading to crash
2024-02-19 12:06:45 +01:00
Bartłomiej Dach
444ac5ed4d
Add failing test coverage
2024-02-19 09:59:25 +01:00
Dean Herbert
6b6a6aea54
Apply NRT to LogoTrackingContainer
2024-02-18 23:35:26 +08:00
Dean Herbert
415a65bf59
Add failing tests for beatmap inconsistencies
2024-02-18 19:32:21 +08:00
Salman Ahmed
414e55c90e
Add visual test case
2024-02-18 01:38:51 +03:00
Joseph Madamba
8169d1ac80
Add twenty star counter in visual test
2024-02-16 22:47:38 -08:00
Salman Ahmed
583e71634f
Always bring master/music volume to 50%
2024-02-16 11:20:07 +03:00
Salman Ahmed
6a1d118b21
Adjust tests again
2024-02-16 10:52:27 +03:00
Mike Will
22dafd8e9c
fix typo
2024-02-15 18:56:09 -05:00
Salman Ahmed
df40f55c07
Merge branch 'master' into mute_detection
2024-02-16 01:35:02 +03:00
Salman Ahmed
6751f95eb6
Adjust test cases and approximate equality
2024-02-16 01:28:53 +03:00
Dean Herbert
409dfd33e7
Merge pull request #27178 from Joehuu/truncate-osu-dropdown-items
...
Truncate long dropdown menu item text and show tooltip
2024-02-15 16:11:36 +08:00
Joseph Madamba
401bd91dc4
Add visual test showing overflow on dropdown menu items
2024-02-14 22:57:38 -08:00
Dean Herbert
59efd22ba2
Merge branch 'master' into score-statistics-updates-working-2
2024-02-15 02:55:12 +08:00
Dean Herbert
3da1d05d98
Merge branch 'master' into ignore-soft-deleted-beatmaps-in-notification
2024-02-14 22:56:47 +08:00
Bartłomiej Dach
d189fa0f69
Rename flag
2024-02-14 11:53:41 +01:00
Salman Ahmed
c24af5bfeb
Add test coverage
2024-02-14 04:17:55 +03:00
Salman Ahmed
a96a66bc9e
Add failing test case
2024-02-14 02:04:20 +03:00
Bartłomiej Dach
14052ae1cc
Implement transient stats display on user toolbar button
2024-02-13 14:28:24 +01:00
Bartłomiej Dach
da4ebd0681
Refactor SoloStatisticsWatcher to no longer require explicit subscription callbacks
2024-02-13 13:49:01 +01:00
Dean Herbert
f7a223f328
Merge pull request #27053 from frenzibyte/unranked-pp-placeholder
...
Add support for displaying "unranked PP" placeholder
2024-02-13 18:59:55 +08:00
Salman Ahmed
5bebe9fe0d
Add test case for profile scores made on loved beatmaps
2024-02-12 21:33:18 +03:00
Bartłomiej Dach
ae5f108f01
Add visual test coverage of user profile info section
2024-02-10 13:08:26 +01:00
Joseph Madamba
c9c39ecb2f
Add RankHighest to APIUser
2024-02-09 16:06:16 -08:00
Andrei Zavatski
f03c4a0961
Merge branch 'master' into results-clean
2024-02-06 21:09:23 +03:00
Dan Balasescu
c18cd65081
Merge pull request #26694 from chandler14362/hit-object-result-allocations
...
Avoid closure allocations when applying hit object results
2024-02-06 17:49:26 +09:00
Andrei Zavatski
fc4234214e
Merge branch 'master' into results-clean
2024-02-06 08:03:10 +03:00
Salman Ahmed
b0da0859d8
Add visual test cases
2024-02-05 23:29:24 +03:00
Bartłomiej Dach
c1feccb4cf
Add test coverage for selection behaviour
2024-02-05 19:53:19 +01:00
Bartłomiej Dach
1582536f04
Merge pull request #26924 from EVAST9919/user-card-containers
...
Rework `UserPanel`s to reduce container nesting
2024-02-05 18:46:42 +01:00
Bartłomiej Dach
39fe078984
Merge branch 'master' into hit-object-result-allocations
2024-02-05 13:24:10 +01:00
Bartłomiej Dach
efe6bb25b1
Refactor result application around again to remove requirement for fields
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-02-05 13:21:01 +01:00
Bartłomiej Dach
ad69259eb8
Merge branch 'master' into fix-results-f-rank
2024-02-05 13:05:37 +01:00
Bartłomiej Dach
989e46c791
Use better test step name
2024-02-05 13:05:28 +01:00
Dean Herbert
c64d414d1b
Merge pull request #26934 from bdach/which-mods-for-pp
...
Display which mods grant pp
2024-02-04 19:15:11 +08:00
Andrei Zavatski
397def9ceb
Move layout specification outside the GradedCircles class
2024-02-04 02:58:15 +03:00
Andrei Zavatski
7b2adc857a
Merge branch 'master' into results-clean
2024-02-04 02:41:12 +03:00
Bartłomiej Dach
dbd4397bef
Attempt to salvage test by using until step
2024-02-02 13:32:16 +01:00
Bartłomiej Dach
fe0433e6ec
Remove redundant default value assignments
2024-02-02 13:24:59 +01:00
Dan Balasescu
b44f77cee1
Update R# + fix inspections
2024-02-02 21:00:28 +09:00
Mike Will
e4ec8c111b
give better volume names to addVolumeSteps
2024-02-02 05:48:57 -05:00
Mike Will
906560f66d
Fix mute button test
...
Lowering the master volume in the previous test meant that the
volume levels would end up being modified.
2024-02-02 04:06:22 -05:00
Mike Will
5d9200b4fe
Update tests to reflect new restore target volume
2024-02-02 02:59:02 -05:00
Bartłomiej Dach
091618db1a
Add test coverage of full account creation flow
2024-02-02 07:25:07 +01:00
Mike Will
dfd966e039
Improve silence detection in MutedNotification
...
Instead of checking the master and music volumes separately to
see if they're <= 1%, check the aggregate of the two volumes to
see if it's <= -60 dB.
When muted notification is activated, restore the aggregate volume
level to -30 dB.
2024-02-02 00:48:42 -05:00
Salman Ahmed
5a1b0004db
Add failing test case
2024-02-02 01:26:03 +03:00
Bartłomiej Dach
865f4d76ff
Add unranked indicator to song select footer too
2024-02-01 21:51:41 +01:00
Bartłomiej Dach
966093f7ce
Transform score multiplier display to also show ranked state
2024-02-01 21:32:37 +01:00
Andrei Zavatski
b0f6a87a2b
Add stress test in TestSceneDashboardOverlay
2024-02-01 16:22:07 +03:00
Salman Ahmed
6ab8960fdc
Add step for toggling skins in results screen test scene
2024-02-01 16:08:48 +03:00
Salman Ahmed
35c3f5e250
Merge branch 'master' into fix-results-f-rank
2024-02-01 15:29:07 +03:00
Dean Herbert
a1fe5eedd5
Merge pull request #26751 from frenzibyte/fix-multiplayer-fail-freezing-score
...
Fix score processor no longer applying results when failing in multiplayer match
2024-01-29 19:51:31 +09:00
Dean Herbert
cbbe2f9dc0
Merge pull request #25480 from peppy/2fa
...
Add two factor authentication flow
2024-01-29 19:14:55 +09:00
Bartłomiej Dach
a41ba7c381
Fix more nullable inspections
2024-01-29 08:44:27 +01:00
Dean Herbert
fb24c66342
Mark ResultsScreen.Score as nullable
...
Is nullable in playlist results at very least.
2024-01-29 16:43:26 +09:00
Andrei Zavatski
809ca81b9c
Add TestSceneGradedCircles
2024-01-29 05:29:29 +03:00
Salman Ahmed
64b61108ad
Move solution to multiplayer flow instead
2024-01-28 00:42:04 +03:00
Salman Ahmed
5f68999893
Fix TestSceneFailJudgement asserts no longer being correct
2024-01-27 23:23:32 +03:00
Salman Ahmed
ea641bb8d2
Rename GameplayState.HasFailed to properly clarify its meaning
2024-01-27 23:23:10 +03:00
Salman Ahmed
d38779f962
Add failing test case
2024-01-27 23:22:56 +03:00
Salman Ahmed
2ccd0e3692
Add visual and failing test cases
2024-01-27 01:45:39 +03:00
Bartłomiej Dach
a2e69d37e8
Add basic testing of failure flow
2024-01-26 11:17:32 +01:00
Dean Herbert
e54502eef1
Add full editor save test coverage
2024-01-26 13:59:32 +09:00
Dean Herbert
a77db5d837
Add failing test coverage of editor metadata not saving
2024-01-26 13:59:32 +09:00
Chandler Stowell
93bd3ce5ae
update DrawableHitCircle.ApplyResult to pass this to its callback
2024-01-25 11:25:41 -05:00
Bartłomiej Dach
3d3506b906
Merge branch 'decouple-notification-websocket-from-chat' into 2fa
2024-01-25 14:51:42 +01:00
Dean Herbert
d66a2c452f
Merge branch 'master' into multiplayer-difficulty-tooltip
2024-01-25 21:18:16 +09:00
Dean Herbert
baaf33d995
Merge pull request #26689 from myQwil/divisor_cycle
...
Prevent custom divisor ranges from halting divisor preset cycling
2024-01-25 20:46:16 +09:00
OliBomby
c2d57dc77c
Merge remote-tracking branch 'upstream/master' into edit-nodesample
2024-01-25 11:33:29 +01:00
Dean Herbert
f22bfa350a
Add test coverage of hidden scores on accuracy circle
2024-01-25 15:02:44 +09:00
Nguyên Minh Hồ
e1f8bc9692
Rename CanRotate property of SelectionRotationHandler to a more descriptive name
2024-01-25 12:10:50 +07:00
Mike Will
9e1c242713
Prevent custom divisor ranges from halting preset cycling
...
A custom divisor like 24 or 32 will result in a range containing
many divisors that are already in the `Common` and `Triplets` presets.
When this happens, it can become impossible to cycle between presets,
because the preset can only be changed if the new divisor isn't already
contained within the current preset's range.
2024-01-24 18:31:39 -05:00
Bartłomiej Dach
2f8747776e
Fix nullability inspection
2024-01-24 22:01:59 +01:00
Dean Herbert
b272d34960
Merge pull request #26630 from peppy/s-rank-change
...
Change S rank to require no miss
2024-01-24 13:27:40 +09:00
Bartłomiej Dach
0d7834af5f
Ensure all remaining test usages of IAPIAccess.Login() also authenticate with second factor
2024-01-23 18:04:41 +01:00
Bartłomiej Dach
d7e957087e
Fix account creation overlay test not clearing second auth factor
2024-01-23 17:00:16 +01:00
Bartłomiej Dach
d0d09a8657
Fix login overlay test not clearing second auth factor
2024-01-23 17:00:14 +01:00
Bartłomiej Dach
2cfaa1c103
Merge branch 'master' into 2fa
2024-01-23 16:51:23 +01:00
Andrei Zavatski
da992ccc55
Implement per-axis triangles clamping
2024-01-23 04:54:27 +03:00
Dean Herbert
83f9118b22
Adjust results screen to handle S->A rank adjustment when misses are present
2024-01-22 21:43:32 +09:00
Dean Herbert
c8521b49cd
Change S rank to require no miss
2024-01-22 21:43:32 +09:00
Dean Herbert
2ab0be7606
Merge pull request #26669 from bdach/fix-score-submission-test-failures-again-aaaaaaaaAAAAAA
...
Fix score submission test failures due to checking audio playback validity (again)
2024-01-22 20:07:51 +09:00
Bartłomiej Dach
9b2740f8a4
Fix score submission test failures due to checking audio playback validity (again)
...
As seen in https://github.com/ppy/osu/actions/runs/7607899979/job/20716013982?pr=26662#step:5:75
In https://github.com/ppy/osu/pull/26484 , I went "well if I'm moving the
enabling of validation of playback rate to `SubmittingPlayer` context,
then surely I can remove the local override in the test scene, right?"
Reader: Apparently I did not notice that `FakeImportingPlayer :
TestPlayer : SoloPlayer : SubmittingPlayer`. So no, I could not remove
the local override in the test scene.
You could probably attempt to conjure up some excuse about deep
inheritance hierarchies here but nah. Really just a failure to read
on my behalf as usual.
2024-01-22 11:15:42 +01:00
Bartłomiej Dach
77ef12ebb0
Merge branch 'master' into frame-stable-catchup-zoom
2024-01-22 10:37:06 +01:00
Dean Herbert
f12be60d8d
Make test actually test multiple icons
2024-01-22 17:18:22 +09:00
Bartłomiej Dach
493d495992
Merge pull request #26605 from peppy/simplify-gameplay-pause
...
Simplify gameplay pause sequence
2024-01-22 08:49:08 +01:00
Dean Herbert
3b7a47aded
Merge branch 'master' into update-framework
2024-01-21 13:49:44 +09:00
Andrei Zavatski
1393f52b2b
Rename Masking to ClampToDrawable
2024-01-21 05:20:42 +03:00
OliBomby
9459c66981
fix test
2024-01-20 15:53:08 +01:00
OliBomby
bc0e6baba7
fix test
2024-01-20 01:13:05 +01:00
smallketchup82
87369f8a80
Conform to code style & remove unused imports
2024-01-18 11:16:03 -05:00
Salman Ahmed
22cfc86050
Add failing test case
2024-01-18 14:24:49 +03:00
Dean Herbert
c4e9bcd140
Remove test guarantee of audio time not advancing
2024-01-18 20:06:53 +09:00
Dean Herbert
82e7643df5
Update IPC usages
...
Of note, I've disabled IPC on visual test runners as we generally don't
use IPC in these cases. Having it set means that the game will not open
while visual tests are open, which has been a complaint from devs in the
past.
2024-01-18 19:45:36 +09:00
smallketchup82
d80a5d44ee
Add tests for DifficultyIcon
2024-01-18 03:17:37 -05:00
Dean Herbert
799c74cfe5
Simplify gameplay pause sequence
2024-01-18 14:17:19 +09:00
Dean Herbert
fb4efd992d
Add a fake load to visual test to restore previous testing behaviour
2024-01-18 14:01:37 +09:00
Dean Herbert
c362a93a36
Change frame stable catch-up method to allow for much faster sync
2024-01-18 14:01:37 +09:00
Dean Herbert
6a8a45bb13
Merge pull request #26585 from frenzibyte/fix-editor-ux
...
Fix timing point changes not applying after selecting another one
2024-01-17 19:53:35 +09:00
Dean Herbert
1af5d1434c
Rename test method slightly
2024-01-17 19:53:23 +09:00
Bartłomiej Dach
5cb17bcacf
Merge pull request #26502 from frenzibyte/prevent-submission-with-invalid-mods
...
Add guard against submitting score with invalid mod instances
2024-01-17 11:39:32 +01:00
Dean Herbert
ee18123fc2
Merge pull request #26340 from stanriders/user-rank-card
...
Add user card with global/country ranks to login overlay
2024-01-17 17:22:33 +09:00
Salman Ahmed
05729706eb
Fix android build CI failing
...
No idea why this is only in android, but okay.
2024-01-17 08:53:28 +03:00
Salman Ahmed
23e5167cb5
Merge branch 'master' into drag-volume-controls
2024-01-17 08:37:34 +03:00
Salman Ahmed
a34d2a3424
Add small volume meter to test feel
2024-01-17 08:28:47 +03:00
Salman Ahmed
f11682d44f
Add failing test case
2024-01-17 08:15:01 +03:00
Salman Ahmed
485195d4c2
Fix submission test not asserting properly
2024-01-16 14:27:40 +03:00
Dean Herbert
0e41d0c9cf
Add failing test coverage of skin getting nuked
...
This doesn't fail in headless unfortunately.
Run a few times manually to confirm.
2024-01-16 15:22:38 +09:00
Bartłomiej Dach
40f612435d
Merge pull request #26178 from felipemarins/mod-search-text-box-select-all
...
Make mod search box text be selected when a new mod is selected/deselected
2024-01-15 20:08:02 +01:00
Bartłomiej Dach
a41108057f
Merge pull request #26287 from wooster0/no-scores-yet
...
Don't leave scores screen empty if no scores are present yet
2024-01-15 19:49:20 +01:00
Bartłomiej Dach
4d39c91972
Merge pull request #26449 from peppy/playlist-room-buttons
...
Allow interacting with playlist item buttons when not selected
2024-01-15 19:12:01 +01:00
Bartłomiej Dach
c0d4ed4789
Add test coverage of select-all-text-in-search when nothing matched
2024-01-15 19:07:52 +01:00
Bartłomiej Dach
e8394e6f74
Add test coverage
2024-01-15 19:05:33 +01:00
Bartłomiej Dach
988794cf90
Improve test coverage for empty results
2024-01-15 18:49:41 +01:00
Bartłomiej Dach
8a839f64ed
Add failing test coverage for placeholder shown when it shouldn't be
2024-01-15 18:47:46 +01:00
Bartłomiej Dach
d8d1d9264c
Fix test failure
2024-01-15 18:29:51 +01:00
Bartłomiej Dach
91f8144f98
Add test coverage
2024-01-15 14:58:46 +01:00
Bartłomiej Dach
d206acac63
Merge pull request #26540 from peppy/fix-double-counters
...
De-dupe displayed hits in judgement counter
2024-01-15 14:02:11 +01:00
Bartłomiej Dach
fe8540b441
Merge pull request #26541 from peppy/fix-collection-dropdown-crash
...
Fix collection dropdown crashing when all collections are deleted at once
2024-01-15 13:28:00 +01:00
Salman Ahmed
d346dd0650
Fix TestModReinstantiation failing due to custom mod being used
2024-01-15 15:01:13 +03:00
Bartłomiej Dach
96c472b870
Remove unused using directive
2024-01-15 12:33:25 +01:00
Bartłomiej Dach
6dee2860d2
Merge branch 'master' into fix-multiplayer-mods-cheesing
2024-01-15 12:19:29 +01:00
Bartłomiej Dach
0a02050a85
Fix test crashing at the end in visual test browser
2024-01-15 12:12:27 +01:00
StanR
b86c883a5d
Merge branch 'master' into user-rank-card
2024-01-15 16:37:48 +06:00
Salman Ahmed
494c1be655
Fix blatant error in TestSceneModAccuracyChallenge
2024-01-15 13:30:34 +03:00
Bartłomiej Dach
9da3aeb28b
Merge pull request #26492 from frenzibyte/fix-system-mods-selected-on-free-mods-overlay
...
Fix touch device mod getting selected as a free mod in playlists
2024-01-15 11:29:37 +01:00
Dean Herbert
a3b63391fa
Merge pull request #26356 from stanriders/global-user-statistics
...
Add `Statistics` bindable to `IAPIProvider` and update it from `SoloStatisticsWatcher`
2024-01-15 18:43:35 +09:00
Dean Herbert
2b45a9b7c6
Add failing test coverage showing collection dropdown crash
2024-01-15 17:10:16 +09:00
Dean Herbert
e6453853c2
De-dupe displayed hits in judgement counter
2024-01-15 16:02:59 +09:00
Dean Herbert
2d5a39b234
Add failing test coverage of duplicates in judgement counter display
2024-01-15 16:02:58 +09:00
Salman Ahmed
b1fae2bc6a
Add failing test case
2024-01-13 16:24:49 +03:00
Salman Ahmed
4cde8685d3
Add failing test case
2024-01-13 11:16:22 +03:00
Salman Ahmed
5303023e57
Add failing test case and fix selection assertion
2024-01-13 09:42:23 +03:00
Bartłomiej Dach
6572fa4378
Only validate playback rate when in submission context
...
Temporary workaround for https://github.com/ppy/osu/issues/26404 .
It appears that some audio files do not behave well with BASS, leading
BASS to report a contradictory state of affairs (i.e. a track that is
in playing state but also not progressing). This appears to be related
to seeking specifically, therefore only enable the validation of
playback rate in the most sensitive contexts, namely when any sort of
score submission is involved.
2024-01-12 14:59:15 +01:00
Bartłomiej Dach
600e4b6ef3
Adjust skinnable health display test scene for usability
2024-01-11 10:17:32 +01:00
Bartłomiej Dach
861080d3ae
Move simulated drain to separate test case
...
Having it on at all times was causing other tests to fail.
2024-01-11 10:04:37 +01:00
Dean Herbert
c2706ca91b
Also show drain on argon health display test
2024-01-11 00:31:31 +09:00
Dean Herbert
49d13cda6b
Fix failing test by setting health on source of truth
2024-01-10 23:09:43 +09:00
Dean Herbert
f912a1ba31
Merge branch 'master' into health-less-value-changed
2024-01-10 18:03:34 +09:00
wooster0
d5fdd0c0f9
make each test bind the handler only once, depending on its need
2024-01-09 21:44:05 +09:00
wooster0
ea37c70e0b
apply suggestion
2024-01-09 21:34:40 +09:00
wooster0
8ad697ff4c
apply some suggestions/corrections
2024-01-09 21:28:46 +09:00
Dean Herbert
8324b75fa4
Merge pull request #26437 from bdach/song-select-logo-crash
...
Fix crash when clicking osu! logo in song select immediately after exiting
2024-01-09 19:40:19 +09:00
Dean Herbert
f1b4c305b0
Change skinnable health test scene to drain
2024-01-09 17:09:19 +09:00
Dean Herbert
79ff767eba
Remove unused using
2024-01-09 14:51:30 +09:00
Dean Herbert
7d57a668ab
Use main page constant in more places
2024-01-09 13:12:54 +09:00
Joseph Madamba
b03813d3b4
Update casing of hardcoded "Main_page" string in tests
2024-01-08 14:37:50 -08:00
Bartłomiej Dach
8a87301c55
Add test for crashing scenario
2024-01-08 21:34:54 +01:00
Bartłomiej Dach
5337d999b5
Merge branch 'master' into disable-intro-track-pause
2024-01-08 12:54:37 +01:00
Bartłomiej Dach
b869be2f46
Fix typo
2024-01-08 12:52:23 +01:00
Bartłomiej Dach
50eba9ebdb
Reduce code duplication in test
2024-01-08 12:52:14 +01:00
Zachary
e2769dbda1
Attempt at creating a test.
2024-01-06 19:29:41 +10:00
Dean Herbert
fbc40ffc65
Merge pull request #26381 from Joehuu/flash-ongoing-operations-dialog
...
Flash blocking ongoing operations dialog when trying to force quit
2024-01-05 18:34:06 +09:00
Joseph Madamba
b190333c17
Use repeat step for more delay between the two exits
2024-01-04 09:00:24 -08:00
Dean Herbert
35b9940c4e
Merge pull request #26140 from CaffeeLake/multiplier1x
...
Fix mod score multiplier rounding to 1.00x with specific mod combinations
2024-01-04 19:26:49 +09:00
Dean Herbert
085f5acd1a
Fix another rider inspection (why do these keep coming up at random)
2024-01-04 19:26:28 +09:00
Dean Herbert
44d35020d1
Add test coverage of failed multiplayer score
2024-01-04 17:54:52 +09:00
Dean Herbert
b1813b17a2
Few new rider inspection
2024-01-04 16:39:50 +09:00
wooster0
92c4566287
Fix typo
2024-01-04 12:20:05 +09:00
CaffeeLake
c7b0a7ff69
Merge branch 'master' into multiplier1x
2024-01-04 05:04:23 +09:00
StanR
e240443c46
Update LocalUser statistics, add test
2024-01-03 18:15:32 +06:00
StanR
3df7430d2e
Bind UserRankPanel values to Statistics bindable in APIAccess
2024-01-03 14:32:32 +06:00
Bartłomiej Dach
e686a6a1dd
Fix player submission test intermittent failures due to audio playback discrepancy logic kicking in
...
See https://github.com/ppy/osu/actions/runs/7384457927/job/20087439457#step:5:133 .
2024-01-03 09:17:01 +01:00
StanR
c4be6fa974
Fix code quality, add new cards to the test scene
2024-01-03 00:37:24 +06:00
OliBomby
de14da95fa
Remove other grid types
2024-01-01 15:44:20 +01:00
OliBomby
9796fcff52
Merge position snap grid tests into single file
2024-01-01 15:24:54 +01:00
OliBomby
31d1799480
Create TestSceneCircularPositionSnapGrid.cs
2024-01-01 15:24:54 +01:00
OliBomby
8425c7226c
fix rectangular and triangular grid tests
2024-01-01 15:24:54 +01:00
OliBomby
f223487e1c
improve code
2024-01-01 15:13:10 +01:00
OliBomby
92c3b142a4
Added Triangular snap grid
2024-01-01 15:11:50 +01:00
OliBomby
f3b88c318b
Add rotation to snap grid visual
2024-01-01 15:11:49 +01:00
CaffeeLake
ca0f09733a
Remove unnecessary using directives
...
Signed-off-by: CaffeeLake <PascalCoffeeLake@gmail.com>
2023-12-31 23:35:42 +09:00
Salman Ahmed
34acb435b8
Merge branch 'master' into multiplier1x
2023-12-31 16:48:00 +03:00
Salman Ahmed
4a94cfd35d
Fix failing test case
2023-12-31 16:47:12 +03:00
wooster0
0c85fd496f
Don't leave scores screen empty if no scores are present yet
...
Addresses https://github.com/ppy/osu/discussions/23787
I originally wanted to set `allowShowingResults` to false if there are
no results but because this involves an API request to fetch the scores
that would mean all the scores would have to be fetched all at once so
that it knows whether to hide or show the "View results" button on a
beatmap.
Because that would slow things down and be very inefficient, this still
allows the user to view the scores screen but if there aren't any
scores, it shows a text, which I think is at least for now better than
nothing.
As for the testing of this, I wasn't sure how to not generate scores
only for one specific test so I opted into not using `SetUpSteps` and
doing it that way.
2023-12-31 22:42:32 +09:00
Salman Ahmed
68dd103c89
Add failing test cases
2023-12-30 21:33:22 +03:00
Dean Herbert
2b81f4f557
Merge pull request #26221 from bdach/system-title-only-on-top-level-menu
...
Do not display system title in inital menu state
2023-12-29 21:13:40 +09:00
Bartłomiej Dach
db78d73fa5
Do not display system title in inital menu state
...
Addresses https://github.com/ppy/osu/discussions/26199 .
2023-12-29 11:50:30 +01:00
Bartłomiej Dach
9bb0663b3b
Add test coverage of failure case
2023-12-29 10:36:53 +01:00
Bartłomiej Dach
68402bfd11
Add test coverage of failure scenario
2023-12-28 20:39:11 +01:00
Dean Herbert
8e3fe090f3
Merge pull request #26169 from bdach/universal-offset-from-session-plays
...
Implement automatic suggestion of global audio offset based on last plays
2023-12-28 22:57:30 +09:00
Bartłomiej Dach
24a80da83f
Merge branch 'master' into universal-offset-from-session-plays
2023-12-28 14:07:46 +01:00
Bartłomiej Dach
bb0737837b
Fix test failing due to querying button position during transform
2023-12-28 13:58:00 +01:00
Dean Herbert
6bc0f02e2d
Fix test initialising dialogs without cleaning up
2023-12-28 20:40:51 +09:00
Dean Herbert
f8347288c1
Add padding around text in dialogs
2023-12-28 20:29:56 +09:00
Dean Herbert
28e220ca50
Update popup dialog design
...
Had to be done. I hated the old ones so much.
As usual, disclaimer that this is an iterative design and will probably
be replaced in the future.
2023-12-28 19:04:35 +09:00
Dean Herbert
bd0e2b4dde
Remove disclaimer screen completely
2023-12-28 17:21:29 +09:00
Dean Herbert
1f2339244e
Add supporter display to main menu
2023-12-28 17:20:01 +09:00
Bartłomiej Dach
d9299a8a55
Implement visual appearance of "system title" message in main menu
2023-12-27 23:07:17 +01:00
Bartłomiej Dach
160342ceed
Implement automatic suggestion of audio offset based on last plays
2023-12-27 21:14:37 +01:00
Bartłomiej Dach
1b7af989ec
Migrate BeatmapOffsetControl to use session static directly
2023-12-27 19:19:27 +01:00
Bartłomiej Dach
53766285ce
Remove remaining hexacons usages
2023-12-27 17:42:18 +01:00
Dean Herbert
901674a130
Move back button inside sidebar to fix weird animation
2023-12-27 13:39:13 +09:00
Bartłomiej Dach
6f672b8cb3
Fix TestSceneKeyBindingPanel failures
2023-12-26 20:36:12 +01:00
Bartłomiej Dach
9ac79782d2
Add visibility toggle step to settings panel test scene
2023-12-26 20:21:15 +01:00
Dean Herbert
03e2463b06
Add test coverage and refactor to better handle equality edge case
2023-12-26 21:21:08 +09:00
Bartłomiej Dach
30b5b36f1d
Fix code quality inspection
2023-12-26 12:20:17 +01:00
Nathan Tran
4e3bdb2b56
Add test coverage
2023-12-26 00:57:06 -08:00
Bartłomiej Dach
32d8ee2d0c
Add test coverage
2023-12-23 13:42:19 +01:00
Dean Herbert
9f34dfa2ba
Add missing using statement
2023-12-23 16:25:52 +09:00
Simon G
01cf4ee15a
add test for length updates
2023-12-22 18:11:37 +01:00
Bartłomiej Dach
81bbdccee7
Rename ScoreInfo.{ -> Client}Version
2023-12-21 12:56:43 +01:00
Dean Herbert
a4baa0a716
Add versioning of local scores
...
For any potential future usage
2023-12-21 18:37:15 +09:00
Dean Herbert
0648201844
Cancel test more
2023-12-21 18:17:03 +09:00
Dean Herbert
c5fb4d0f5c
Mark flaky test temporarily
2023-12-21 01:52:40 +09:00
Bartłomiej Dach
64b0534fb8
Merge pull request #25857 from peppy/fix-mod-settings-keyboard-adjust
...
Fix mod search textbox having focus while settings are visible
2023-12-19 15:44:17 +01:00
Bartłomiej Dach
d793d1cea1
Add test coverage of desired input handling behaviour
2023-12-19 14:52:16 +01:00
Bartłomiej Dach
e306cc35ba
Merge branch 'master' into fix-song-select-realm-refresh-performance
2023-12-19 14:14:46 +01:00
Dean Herbert
8f5d21dc70
Actually fix realm selection retention regression
2023-12-19 18:10:55 +09:00
Bartłomiej Dach
bf668174ec
Use nunit constraints in test for transparency
2023-12-18 19:02:23 +01:00
Dean Herbert
41485c19cf
Add realm refresh steps in an attempt to stabilise failing test
...
I think this is required because there is a higher chance of batched
updates with the new structure (and less calls to `BeatmapSetsChanged`
which causes re-selection).
2023-12-19 02:08:29 +09:00
Bartłomiej Dach
be16e0e538
Add failing test for adding collection w/ name colliding w/\ default items
2023-12-18 12:47:42 +01:00
Bartłomiej Dach
67a5e01c49
Update assertions in test
2023-12-14 15:19:29 +01:00
Dean Herbert
76653e61cb
Merge pull request #25575 from frenzibyte/collection-dropdown-improve-ux
...
Improve handling of beatmap collection changes in `CollectionDropdown`
2023-12-14 18:39:36 +09:00
Bartłomiej Dach
839a080247
Add test coverage for desired mod overlay search box behaviour
2023-12-14 09:52:38 +01:00
Salman Ahmed
31c9489cb9
Fix failing tests
2023-12-13 23:38:19 +03:00
Dean Herbert
c6b1a5f1ee
Merge pull request #25691 from bdach/fix-skin-editor-crash-again
...
Fix skin editor crashing in some circumstances when opened in main menu
2023-12-13 22:15:42 +09:00
Dan Balasescu
8c7570525a
Merge pull request #25744 from peppy/adjust-mod-multipliers
...
Adjust some mod multipliers for initial leaderboard sanity
2023-12-13 17:56:13 +09:00
Bartłomiej Dach
e865de7a6b
Update test assertions in line with half time mod multiplier changes
2023-12-13 09:25:56 +01:00
Dean Herbert
fdcf87569c
Merge pull request #25711 from smoogipoo/mania-convert-song-select-keycount
...
Display osu!mania keycount in song select carousel panels and details
2023-12-13 16:31:25 +09:00
Dean Herbert
eff81be6fd
Fix failing test and add coverage of conversion case
2023-12-13 16:01:52 +09:00
Dean Herbert
c2d3dcdd9c
Fix slider tests and incorrect nullability handling around freehandToolboxGroup
2023-12-13 15:15:49 +09:00
Dean Herbert
5e10f9f899
Fix failing tests due to more textboxes being present with searchable dropdowns
2023-12-13 15:11:47 +09:00
Dean Herbert
343ecc469f
Merge branch 'master' into dropdown-search
2023-12-13 13:58:23 +09:00
Dan Balasescu
8977e74171
Fix editor test not waiting for editor to load
2023-12-13 13:15:49 +09:00
Salman Ahmed
10e8edff67
Merge branch 'master' into dropdown-search
2023-12-12 21:14:01 +03:00
Dean Herbert
ea0ad2a0ef
Merge branch 'master' into online-presence
2023-12-07 17:42:46 +09:00
Dean Herbert
3c29e9162c
Merge pull request #25693 from bdach/online-presence-structure-serialisation
...
Simplify user presence structures for serialisability
2023-12-07 17:39:21 +09:00
Dean Herbert
a500f55ec6
Merge pull request #25688 from peppy/match-default-sv
...
Change default slider velocity for new beatmaps to match osu!stable
2023-12-07 11:52:16 +09:00
Bartłomiej Dach
86e003aec1
Update currently online display tests
2023-12-06 19:37:35 +01:00
Bartłomiej Dach
602550b9c2
Fix test failures
2023-12-06 19:37:28 +01:00
Bartłomiej Dach
d66fa09320
Simplify UserStatus to be an enumeration type
...
There were absolutely no gains from having it be a reference type /
class, only complications, especially when coming from the serialisation
angle.
2023-12-06 18:52:27 +01:00
Bartłomiej Dach
faf60cec91
Extend test coverage of skin editor open to fail better
2023-12-06 10:11:41 +01:00
Bartłomiej Dach
4585a169b1
Merge pull request #25686 from peppy/fix-song-select-match
...
Fix searching at song select matching incorrect ruleset
2023-12-06 09:25:47 +01:00
Dean Herbert
43dc908257
Fix test value getting clobbered due to stupid stuff
...
Don't even ask. Just smile and nod.
2023-12-06 15:59:29 +09:00
Dean Herbert
79826dee58
Fix tests which were relying on SliderMultiplier==1
2023-12-06 13:50:10 +09:00
Dean Herbert
4da6d53c72
Merge pull request #25672 from frenzibyte/fix-argon-health-display-2
...
Fix `ArgonHealthDisplay` sometimes behaving weirdly on miss judgements (alternative)
2023-12-06 12:24:39 +09:00
Dean Herbert
8286d3896f
Fix searching at song select matching incorrect ruleset
...
Regressed with https://github.com/ppy/osu/pull/25679 .
2023-12-06 11:32:26 +09:00
Salman Ahmed
a67df76654
Add test coverage
2023-12-05 22:53:48 +03:00
Salman Ahmed
c55bfc03ee
Move private method
2023-12-05 22:06:53 +03:00
Salman Ahmed
20fd458fac
Perserve miss animation when followed by a hit at same frame
2023-12-05 21:59:28 +03:00
Salman Ahmed
986f4fa407
Add test scenarios for same-frame judgements
2023-12-05 21:59:28 +03:00
Dean Herbert
5a2240838b
Merge branch 'master' into multiplayer-abort
2023-12-05 17:01:54 +09:00
