3093 Commits

Author	SHA1	Message	Date
Dean Herbert	51bd32bf7e	Restore comment regarding usage of MinBy	2024-01-09 01:08:47 +09:00
Dean Herbert	e77d203a24	Refactor delayed load logic to hopefully read better	2024-01-09 01:08:17 +09:00
Dean Herbert	d3710f0bfd	Remove scores from song select leaderboard when leaving the screen	2024-01-06 20:53:20 +09:00
Dean Herbert	81c6fd5589	Load items closer to the centre of the screen as a priority	2024-01-04 19:25:12 +09:00
Dean Herbert	adac3b65ce	Fix beatmap carousel not preloading panels when off-screen	2024-01-04 19:25:12 +09:00
Salman Ahmed	4dc11c4c48	Update existing code to use helper method	2023-12-31 05:18:07 +03:00
CaffeeLake	bca0600482	Use 0.99x or 1.01x ... Signed-off-by: CaffeeLake <PascalCoffeeLake@gmail.com>	2023-12-31 00:47:09 +09:00
Dean Herbert	ffc8778d67	Fix song select leaderboard tab ordering not matching stable	2023-12-28 14:13:35 +09:00
Nathan Tran	060bf8beff	Fix rewind backtracking	2023-12-25 15:27:32 -08:00
Simon G	b31b9e96d0	adjust beatmap length and drain based on rate changing mods	2023-12-22 03:04:48 +01:00
Dean Herbert	7fa4dcf0fb	Fix selection retention logic copy paste failure	2023-12-20 19:27:57 +09:00
Dean Herbert	e003462f7d	Fix beatmap updates causing one extra carousel selection	2023-12-20 19:15:02 +09:00
Dean Herbert	64f62e7d90	Fix song select running updates when screen is not active ... Who would have guessed that `Schedule` calls were there for a reason! I've tidied things up. Most of the changes I've made here are not required – the schedule is the main thing here. The reason the sound was playing is because one-too-many schedules was removed causing beatmap updates to update carousel specifics while still at the player loader screen. Note that the selection sound still plays on returning to song select, but this is not a regression. I'm looking at fixing this in a separate PR because I'm in a good place as far as understanding the logic right now and it would be a waste to leave it broken. Closes https://github.com/ppy/osu/issues/25875.	2023-12-20 17:31:09 +09:00
Bartłomiej Dach	9a5027e556	Merge pull request #25900 from peppy/editor-from-any-carousel ... Allow choosing "Edit" from any beatmap carousel item	2023-12-20 08:35:42 +01:00
Dan Balasescu	3818977a36	Merge pull request #25898 from peppy/song-select-stats ... Update song select to always show difficulty stats	2023-12-20 14:39:35 +09:00
Dean Herbert	85e5d74a16	Apply proposed changes	2023-12-20 12:42:06 +09:00
Bartłomiej Dach	e306cc35ba	Merge branch 'master' into fix-song-select-realm-refresh-performance	2023-12-19 14:14:46 +01:00
Dean Herbert	bbfdd6892d	Allow choosing "Edit" from any beatmap carousel item	2023-12-19 19:58:49 +09:00
Dean Herbert	502e3edac3	Add missing invalidation call	2023-12-19 19:39:48 +09:00
Dean Herbert	3b848e8503	Tidy up visual look	2023-12-19 19:28:02 +09:00
Dean Herbert	07bb0805e9	Move advanced stats to a more permanent location on song select	2023-12-19 19:10:43 +09:00
Dean Herbert	0a64d631e2	Add support for dual-column advanced stats	2023-12-19 19:09:47 +09:00
Dean Herbert	8f5d21dc70	Actually fix realm selection retention regression	2023-12-19 18:10:55 +09:00
Dean Herbert	7e9c1b2acb	Use sender's realm (because we can)	2023-12-19 17:27:52 +09:00
Bartłomiej Dach	7c05d66bd7	Add more detail to exception	2023-12-19 08:57:18 +01:00
Dean Herbert	44efa2c540	Fix incorrect ordering of items at song select when certain sort modes are used	2023-12-19 15:09:03 +09:00
Dean Herbert	d81cabc063	Revert "Improve performance of attemptSelection using new cached count and LastSelected" ... This reverts commit 25df42630e.	2023-12-18 22:46:02 +09:00
Dean Herbert	25e3a8e82e	Fix a few of silly issues	2023-12-18 22:45:58 +09:00
Dean Herbert	25df42630e	Improve performance of attemptSelection using new cached count and LastSelected	2023-12-18 20:47:08 +09:00
Dean Herbert	5755fa214a	Cache non-filtered beatmap counts to massively improve count performance	2023-12-18 20:44:08 +09:00
Dean Herbert	034c5cd654	Debounce count updates for good measure	2023-12-18 20:43:23 +09:00
Dean Herbert	6fa1f5ef9b	Simplify invalidation logic ... The only case where this was checking is guaranteed by realm to only be called once.	2023-12-18 20:31:02 +09:00
Dean Herbert	87b7699fcc	Avoid calling invalidation logic per beatmap set updated ... Realm will batch the updates. We don't want to do expensive operations per set when we don't need to.	2023-12-18 20:31:02 +09:00
Dean Herbert	32cc3f9ef7	Combine multiple similar invalidation logic into single event	2023-12-18 20:31:02 +09:00
Dean Herbert	48e89b903c	Merge pull request #25760 from bdach/if-i-speak-i-am-in-big-trouble-pt-1 ... Fix `AdjustedAttributesTooltip` being broken by design	2023-12-15 12:26:10 +09:00
Dan Balasescu	fbef40bb1f	Reduce some allocations in SongSelect in the mania ruleset	2023-12-15 11:01:15 +09:00
Bartłomiej Dach	9e5b6b97ff	Fix AdjustedAttributesTooltip being broken by design ... Fixes issue described in the following comment: https://github.com/ppy/osu/pull/25759#issuecomment-1855954637 That is just not how the tooltip system is supposed to be used. To name the individual sins: - Caching and returning a tooltip instance like the classes that used tooltips is incorrect. The lifetime of tooltip instances is managed by the tooltip container. `GetCustomTooltip()` is called by it exclusively. It should return a fresh instance every time. - Not putting actual data in `IHasCustomTooltip.TooltipContent` is wrong. - Having `Tooltip.SetContent()` be a no-op is *grossly and flagrantly* wrong. I'm not even sure which particular combination of the above transgressions caused the issue as it presented itself, but at this time I frankly do not care.	2023-12-14 16:15:56 +01:00
Givikap120	b22a7cf520	Update AdvancedStats.cs	2023-12-14 14:31:58 +02:00
Givikap120	c2373bb37b	change the order of attributes ... + simplifying the bug fix	2023-12-14 14:31:19 +02:00
Givikap120	8698835db2	fixed bug ... fixed the bug where it's not updates tooltip when there are no mods	2023-12-14 14:00:35 +02:00
Dean Herbert	5062c53e36	Refactor everything for sanity	2023-12-13 17:33:39 +09:00
Dean Herbert	fb44fb18e0	Update in line with upstream changes	2023-12-13 16:42:20 +09:00
Dean Herbert	0259ab761b	Merge branch 'master' into arod_rate_adjust	2023-12-13 16:35:18 +09:00
Dean Herbert	fdcf87569c	Merge pull request #25711 from smoogipoo/mania-convert-song-select-keycount ... Display osu!mania keycount in song select carousel panels and details	2023-12-13 16:31:25 +09:00
Dean Herbert	5e10f9f899	Fix failing tests due to more textboxes being present with searchable dropdowns	2023-12-13 15:11:47 +09:00
Dan Balasescu	c31ff84417	Fix possible nullref	2023-12-13 13:32:27 +09:00
Givikap120	2d94841929	fixed one test	2023-12-10 02:00:32 +02:00
Givikap120	faf54bca43	Merge branch 'master' into arod_rate_adjust	2023-12-10 01:49:18 +02:00
Givikap120	1d0c37e138	fixed test errors	2023-12-10 00:40:05 +02:00
Dan Balasescu	b36db3518c	Add keycount to song select details panel and carousel panels	2023-12-09 22:31:51 +09:00
Dean Herbert	8286d3896f	Fix searching at song select matching incorrect ruleset ... Regressed with https://github.com/ppy/osu/pull/25679.	2023-12-06 11:32:26 +09:00
Dean Herbert	45e499778f	Search terms before performing other criteria checks ... Very minor, but putting the more common case towards the start of the method allows early return.	2023-12-05 15:28:56 +09:00
Dean Herbert	42010574b5	Avoid list construction when doing filtering	2023-12-05 15:26:14 +09:00
Dean Herbert	27e778ae09	Avoid sorting items when already in the correct sort order	2023-12-05 14:47:32 +09:00
Dean Herbert	7fda38d0b0	Use ordinal comparison when searching at song select ... Bypasses various overheads. In theory should be fine? (until it's not on some language)	2023-12-05 14:14:13 +09:00
Givikap120	c2a44cf118	Made custom tooltip	2023-11-23 23:30:18 +02:00
Dean Herbert	9172632b0b	Rename method and adjust xmldoc to be very explicit about how wrong this is	2023-11-17 17:04:20 +09:00
Dean Herbert	d1cea10f21	Add note about localisation	2023-11-17 16:52:40 +09:00
Bartłomiej Dach	70d2de5669	Move song select touch detector to solo implementation ... It should not run in multiplayer. Even if we wanted to allow touch-only playlist items at some point, the current behaviour of multiplayer song selects with respect to touch device mod is currently just broken.	2023-11-14 16:35:16 +09:00
Givikap120	26d493986c	Fixed precision and updated AdvancedStats	2023-11-12 18:05:18 +02:00
Dean Herbert	6bd5eda2a0	Merge branch 'master' into arod_rate_adjust	2023-11-12 15:49:07 +09:00
Givikap120	60c3e7250b	fixed naming incconvinence	2023-11-10 15:13:40 +02:00
Bartłomiej Dach	97fee6143c	Rename touch "input handlers" to detectors	2023-11-06 10:08:19 +01:00
Givikap120	d0b2b4f7b9	Update AdvancedStats.cs	2023-11-04 21:57:42 +02:00
Givikap120	820519c37d	improved tooltip	2023-11-04 21:55:46 +02:00
Givikap120	57170501cd	Improve code quality	2023-11-04 17:25:09 +02:00
Bartłomiej Dach	8784dd42c0	Do not attempt to turn on Touch Device in song select with autoplay active	2023-11-02 22:56:43 +01:00
Bartłomiej Dach	c588f434e5	Fix song select touch handler causing crashes when song select is suspended	2023-11-02 21:24:58 +01:00
Bartłomiej Dach	2f6ff893b5	Automatically activate and deactivate touch device mod in song select	2023-11-02 19:45:48 +01:00
Susko3	366e41f111	Use local workaround instead of disabling clipboard entirely	2023-10-28 12:23:23 +02:00
Bartłomiej Dach	2fa2217381	Fix left side of carousel blocking volume adjust hotkeys ... Closes https://github.com/ppy/osu/issues/25234. A little ad-hoc, but probably fine...?	2023-10-26 16:26:35 +02:00
Bartłomiej Dach	5d6a58d443	Add failing test scene for scroll handling in song select	2023-10-26 16:24:16 +02:00
Bartłomiej Dach	19be0055d5	Merge pull request #24921 from Pasi4K5/diff-name-search ... Add ability to search for difficulty names using square brackets	2023-10-24 12:07:02 +02:00
Dean Herbert	c9161a7bfc	Remove incorrect copy paste fail	2023-10-24 17:32:01 +09:00
Bartłomiej Dach	abfe2ce0fe	Fix comment	2023-10-24 10:05:20 +02:00
Dean Herbert	fcb366af4d	Add diff= support for more advanced usages	2023-10-24 16:09:05 +09:00
Dean Herbert	6865d8894d	Simplify implementation and remove unsupported test coverage	2023-10-24 16:01:32 +09:00
Dean Herbert	1274829193	Block scroll and click operations on the left side of song select	2023-10-24 14:51:40 +09:00
Pasi4K5	c5339f440e	Apply code review suggestions	2023-10-23 23:30:54 +02:00
Dean Herbert	0ae0b0c353	Fix carousel "reset position" marging not scaling with UI scale correctly	2023-10-20 20:04:26 +09:00
Dean Herbert	137a1d948d	Allow interacting with the carousel anywhere in empty space at song select	2023-10-20 20:04:11 +09:00
Dean Herbert	e081fa48a2	Fix various other inspections	2023-10-17 17:48:51 +09:00
Dean Herbert	7139592e43	Fix collections not being sorted correctly in context menus	2023-10-16 16:03:12 +09:00
Dean Herbert	936a21a661	Fix redundant bindable initialisation in SongSelect	2023-10-06 16:51:56 +09:00
Pasi4K5	c927f90a48	Replace regex with a custom algorithm and update test scene.	2023-09-29 13:46:33 +02:00
Pasi4K5	23c20ca5f4	Add xmldocs	2023-09-29 13:44:11 +02:00
Dean Herbert	ae31a8fadf	Reduce delay before loading beatmap after selection change at song select ... This was originally set high because of performance concerns. We have since improved things quite drastically. Even with a very low debounce my song select is amazingly smooth. This is about as low as we can got unless we want chaos when key repeating left/right arrows (it's not as bad as you think, maybe worth testing during review and see if it feels more expected?). Of note, stable has key repeat disabled on left/right arrows and zero debounce. Addresses concerns in https://github.com/ppy/osu/discussions/24916.	2023-09-26 16:21:09 +09:00
Pasi4K5	74896fd6b2	Fix multiple difficulty search queries not working in some cases.	2023-09-25 13:38:47 +02:00
Pasi4K5	793d1bf970	Add ability to search for difficulty names	2023-09-25 12:52:49 +02:00
Salman Ahmed	5266cdc722	Add explanatory note	2023-09-21 20:41:10 +03:00
Dean Herbert	9af4e75dfc	Disable clipboard export for song select textbox ... In combination with https://github.com/ppy/osu-framework/pull/5997, closes https://github.com/ppy/osu/issues/24867	2023-09-22 01:24:29 +09:00
Givikap120	1a70110a4e	Added BeatmapAttributesDisplay support	2023-09-12 16:44:44 +03:00
Givikap120	c61212c523	Merge pull request #1 from Givikap120/master ... add display to calibrate	2023-09-12 13:02:19 +03:00
Bartłomiej Dach	589f56d20c	Merge branch 'master' into map_info_on_mod_settings	2023-09-11 09:55:54 +02:00
Givikap120	ed213dad6c	minor format fix (again)	2023-09-08 20:38:24 +03:00
Givikap120	a01537c763	minor format fix	2023-09-08 20:37:07 +03:00
Givikap120	02e2b8546c	fixed all stated problems	2023-09-08 20:32:55 +03:00
Joseph Madamba	d0780fb765	Add comment explaining the max width	2023-09-06 15:01:55 -07:00
Joseph Madamba	97bd90c0ff	Link new song select wedge title and artist to search text box	2023-09-06 14:41:10 -07:00
Bartłomiej Dach	b5e812eb3e	Merge pull request #24723 from bdach/beatmap-carousel-split-missing-status ... Fix status on carousel beatmap set not showing in split difficulty mode	2023-09-06 09:35:38 +02:00
Bartłomiej Dach	63e92f8fab	Fix status on carousel beatmap set not showing in split difficulty mode	2023-09-06 08:25:19 +02:00
Dean Herbert	dded7fe6ca	Merge branch 'master' into beatmap-options-popover	2023-09-06 15:16:34 +09:00
Joseph Madamba	73604d171a	Make "general" a common string	2023-09-05 23:00:07 -07:00
Joseph Madamba	701e24e8d3	Move hide button to end and make it work	2023-09-05 18:50:31 -07:00
Joseph Madamba	6d2e57b73e	Add localisation support to beatmap options popover	2023-09-05 18:43:42 -07:00
Joseph Madamba	69fa8747f0	Explicitly add beatmapinfo param to edit call	2023-09-05 18:35:35 -07:00
Joseph Madamba	9565039192	Hide beatmap options popover when beatmap changes	2023-09-05 18:24:54 -07:00
Joseph Madamba	9f10082ffc	Revert param removal of delete beatmap and clear scores methods	2023-09-05 18:24:53 -07:00
Joseph Madamba	8e8fae0fba	Fix left padding adding shear width	2023-09-05 15:21:23 -07:00
Joseph Madamba	3f92dae55c	Move star rating display and status pill out of reloadable content	2023-09-05 15:20:20 -07:00
Joseph Madamba	676240928e	Move actual star updating to star rating display	2023-09-05 14:57:55 -07:00
Joseph Madamba	5becac6431	Make beatmap non-nullable ... Doesn't seem like it'll be null after first set: 5454d1caa1/osu.Game/OsuGameBase.cs (L363)	2023-09-05 14:43:43 -07:00
Joseph Madamba	b63c1e4257	Remove mods dependency ... BPM is not in the wedge anymore.	2023-09-05 12:14:17 -07:00
Joseph Madamba	6e6dd86a51	Remove buffered container comment ... While it is true that there is a transparency overlap, it is only seen when entering/exiting song select. And there are other components game-wide that exhibit the same issue when transparency changes. Should be reconsidered another time.	2023-09-05 11:10:06 -07:00
Dean Herbert	4cd4eb3b0a	Move "general" to top for key binding compatibility	2023-09-05 16:46:49 +09:00
Dean Herbert	84d8d33ad7	Add headers and generally improve the UI of the popover	2023-09-05 16:44:55 +09:00
Dean Herbert	4ff3630484	Add a slight delay before hiding the popover to better visualise button click	2023-09-05 16:14:01 +09:00
Dean Herbert	a8c9c2bf17	Remove buffered container (doesn't seem like it's doing anything anymore)	2023-09-05 15:59:00 +09:00
Joseph Madamba	98d027d207	Fix star counter animating weird and delayed	2023-09-04 21:39:41 -07:00
Joseph Madamba	9accd0ded2	Fix star rating rolling counter regression	2023-09-04 21:21:56 -07:00
Joseph Madamba	82fb9dc2ef	Simplify text initialization	2023-09-04 12:59:21 -07:00
Joseph Madamba	e70510ef19	Move drawable and binding logic to standard places	2023-09-04 12:56:20 -07:00
Joseph Madamba	2df2002735	Move negative corner radius margin to constructor	2023-09-04 12:42:01 -07:00
Joseph Madamba	e8a793425b	Use right padding instead of negative x offset	2023-09-04 12:38:40 -07:00
Joseph Madamba	bf71099e57	Fix truncating sprite text usage	2023-09-04 12:04:20 -07:00
Joseph Madamba	2fbd67cf26	Merge branch 'master' into beatmap_wedge_clean_ii	2023-09-04 11:24:20 -07:00
Joseph Madamba	f616648730	Remove icon blending	2023-09-04 09:40:35 -07:00
Joseph Madamba	6c0bd13308	Add xmldoc to newly exposed methods	2023-09-04 00:53:14 -07:00
Joseph Madamba	5abf271b56	Implement beatmap options popover	2023-09-04 00:53:09 -07:00
Magnus-Cosmos	d674856e29	Use existing localisations in BeatmapInfoWedge	2023-09-02 22:49:29 -04:00
Givikap120	5e5fe84a88	Update AdvancedStats.cs	2023-09-03 02:19:02 +03:00
Givikap120	0779cd8f4f	minor design fixes	2023-09-03 02:17:04 +03:00
Givikap120	2e2d4d0d60	Merge branch 'map_info_on_mod_settings' of https://github.com/Givikap120/osu into map_info_on_mod_settings	2023-09-03 02:09:18 +03:00
Givikap120	b0398b6259	functionality is done	2023-09-03 02:09:01 +03:00
Givikap120	f8adc911cd	Merge branch 'ppy:master' into map_info_on_mod_settings	2023-08-28 23:17:04 +03:00
Givikap120	50235cc245	somewhat working prototype	2023-08-28 23:16:33 +03:00
Bartłomiej Dach	97d1c6e9fc	Merge branch 'master' into carousel-difficulty-split	2023-08-28 11:07:43 +02:00
Bartłomiej Dach	b9795eb3d4	Fix changes to beatmap sets being undone on switching sort mode	2023-08-28 11:02:22 +02:00
Bartłomiej Dach	80ec18d117	Fix incorrect selection restore code in split case ... The fallback to "any of the added sets" needs to be applied after they've all been added, rather than with every added one. Otherwise, in flows that expect a particular difficulty to be selected in the end (such as exiting from editor) would end up switching away from the edited beatmap.	2023-08-28 10:06:26 +02:00
Bartłomiej Dach	0af6cc1394	Fix online ID not being propagated in split difficulty mode ... Would result in failures to re-download the beatmap in update flows, for instance.	2023-08-28 10:05:59 +02:00
Givikap120	290f8db341	fixed stated problems ... removed functions from `Ruleset.cs` and added a `GetEffectiveDifficulty()` instead	2023-08-26 02:13:14 +03:00
Givikap120	8a1fc7c340	Basic stuff (not working for now)	2023-08-26 01:20:41 +03:00
Dean Herbert	10b1450138	Rename remove method to better explain return type being IEnumerable	2023-08-25 18:10:54 +09:00
Givikap120	d5ac93f631	Added "value is rate changed" indication ... Now if AR or OD value is not "true" and changed through rate - it will appear with symbol `*` Instead of `11` it wil show as `11*`	2023-08-25 01:25:12 +03:00
Givikap120	772633178c	Moved ruleset decl in right place	2023-08-25 01:02:12 +03:00
Givikap120	17b9b1649a	Fixed "works only for std" problem ... 1) Now it use AR/OD calculation from Ruleset class 2) Implemented needed functions in each of default rulesets	2023-08-25 00:58:26 +03:00
Dean Herbert	89eeff515b	Reduce complexity of selection restore	2023-08-25 00:52:54 +09:00
Givikap120	ed886a4dc3	Added a true AR/OD display when using DT/HT	2023-08-24 16:49:42 +03:00
Dean Herbert	9e94f38091	Fix typo in local variable	2023-08-24 18:33:15 +09:00
Dean Herbert	018be4c20f	Fix selection not being retained when switching between split mode	2023-08-22 18:49:02 +09:00