1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-22 04:07:25 +08:00
osu-lazer/osu.Game/Screens/Select
Dean Herbert 64f62e7d90
Fix song select running updates when screen is not active
Who would have guessed that `Schedule` calls were there for a reason!

I've tidied things up. Most of the changes I've made here are not
required – the schedule is the main thing here. The reason the sound was
playing is because one-too-many schedules was removed causing beatmap
updates to update carousel specifics while still at the player loader
screen.

Note that the selection sound still plays on returning to song select,
but this is not a regression. I'm looking at fixing this in a separate
PR because I'm in a good place as far as understanding the logic right
now and it would be a waste to leave it broken.

Closes https://github.com/ppy/osu/issues/25875.
2023-12-20 17:31:09 +09:00
..
Carousel Merge pull request #25900 from peppy/editor-from-any-carousel 2023-12-20 08:35:42 +01:00
Details Apply proposed changes 2023-12-20 12:42:06 +09:00
Filter Automated pass 2023-06-24 01:00:03 +09:00
FooterV2 Make "general" a common string 2023-09-05 23:00:07 -07:00
Leaderboards Bring realm library up-to-date 2023-07-06 13:37:43 +09:00
Options Use new overlay pop-in/pop-out samples 2023-08-17 18:36:36 +09:00
BeatmapCarousel.cs Fix song select running updates when screen is not active 2023-12-20 17:31:09 +09:00
BeatmapClearScoresDialog.cs make ResetConfirmDialog properly utilise its parent's logic 2023-03-05 20:57:26 +01:00
BeatmapDeleteDialog.cs make ResetConfirmDialog properly utilise its parent's logic 2023-03-05 20:57:26 +01:00
BeatmapDetailArea.cs functionality is done 2023-09-03 02:09:01 +03:00
BeatmapDetailAreaDetailTabItem.cs Automated pass 2023-06-24 01:00:03 +09:00
BeatmapDetailAreaLeaderboardTabItem.cs Automated pass 2023-06-24 01:00:03 +09:00
BeatmapDetailAreaTabControl.cs Partial everything 2022-11-27 00:00:27 +09:00
BeatmapDetailAreaTabItem.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
BeatmapDetails.cs Apply proposed changes 2023-12-20 12:42:06 +09:00
BeatmapInfoWedge.cs Tidy up visual look 2023-12-19 19:28:02 +09:00
BeatmapInfoWedgeBackground.cs Automated pass 2023-06-24 01:00:03 +09:00
BeatmapInfoWedgeV2.cs Add comment explaining the max width 2023-09-06 15:01:55 -07:00
FilterControl.cs Fix failing tests due to more textboxes being present with searchable dropdowns 2023-12-13 15:11:47 +09:00
FilterCriteria.cs Add more detail to exception 2023-12-19 08:57:18 +01:00
FilterQueryParser.cs Add diff= support for more advanced usages 2023-10-24 16:09:05 +09:00
Footer.cs Partial everything 2022-11-27 00:00:27 +09:00
FooterButton.cs Partial everything 2022-11-27 00:00:27 +09:00
FooterButtonMods.cs Partial everything 2022-11-27 00:00:27 +09:00
FooterButtonOptions.cs Automated pass 2023-06-24 01:00:03 +09:00
FooterButtonRandom.cs Show "rewind" text on random button when beginning a right mouse press 2023-05-17 14:51:40 +09:00
LocalScoreDeleteDialog.cs Make ScoreInfo.BeatmapInfo nullable 2023-07-04 14:50:34 +09:00
NoResultsPlaceholder.cs Partial everything 2022-11-27 00:00:27 +09:00
PlayBeatmapDetailArea.cs Partial everything 2022-11-27 00:00:27 +09:00
PlaySongSelect.cs Allow choosing "Edit" from any beatmap carousel item 2023-12-19 19:58:49 +09:00
SkinDeleteDialog.cs make ResetConfirmDialog properly utilise its parent's logic 2023-03-05 20:57:26 +01:00
SongSelect.cs Merge pull request #25900 from peppy/editor-from-any-carousel 2023-12-20 08:35:42 +01:00
SongSelectTouchInputDetector.cs Rename touch "input handlers" to detectors 2023-11-06 10:08:19 +01:00
WedgeBackground.cs Only apply dim changes when background blur is disabled 2023-02-15 14:16:34 +09:00