Dean Herbert
136ecb45e2
Rename dummy channel and move to a nested class inside the ChannelListing itself
2022-05-19 19:26:14 +09:00
Dean Herbert
16075d2a2f
Merge pull request #18321 from smoogipoo/legacy-catmull
...
Fix compatibility issues with legacy Catmull sliders
2022-05-19 15:42:21 +09:00
Dean Herbert
d187ca2d8c
Merge pull request #18246 from jai-x/new-chat-cache-loaded-channels
...
Add drawable channel caching to new chat overlay
2022-05-19 15:15:47 +09:00
Salman Ahmed
5d3878a737
Add test coverage for slow-loading channels
2022-05-18 22:58:39 +03:00
Dan Balasescu
fe49a7e678
Add failing tests
2022-05-18 17:10:19 +09:00
Dan Balasescu
49340888c0
Fix compile errors
2022-05-18 10:56:42 +09:00
Dean Herbert
1b7ec1be26
Add basic test coverage of new screen
2022-05-17 18:15:14 +09:00
Dean Herbert
218642c300
Update unsafe file write usages
2022-05-16 18:05:27 +09:00
Jai Sharma
ae5b6c3e10
Use dummy channel to show selector and remove ChannelListSelector
...
Add dummy channel `DummySelectorChannel` which should be set as the
current channel in the channel manager when the selector in the chat
overlay should be shown.
Refactors the `ChannelListItem` to not show mention pill and close
button when the channel is the dummy selector channel.
Ensure that the `ChannelList` selects the dummy channel on clicking the
selector item.
Removes `ChannelListSelector` as it is no longer needed.
Removes the `setCurrent` parameter from `ChannelManager.JoinChannel`
method as it is no longer needed.
2022-05-15 20:24:49 +01:00
Dean Herbert
328561f5c8
Merge pull request #18263 from frenzibyte/spotlight-beatmap-badge
...
Add support for "spotlight" label in beatmap overlay/listing
2022-05-15 12:32:20 +09:00
Dean Herbert
b6575c216b
Allow selecting all mods at free mod select using ctrl+a
2022-05-15 03:25:14 +09:00
Dean Herbert
282c8aec86
Fix typo in test step
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-05-15 03:09:15 +09:00
Dean Herbert
a759cf2dab
Add key binding to deselect all mods
...
Defaults to `Backspace`.
2022-05-15 02:51:58 +09:00
Salman Ahmed
d5027cdfbd
Add FeaturedInSpotlight property to API beatmapsets
2022-05-14 19:46:13 +03:00
Jai Sharma
bd68ffa805
Fix textbox focus test in ChatOverlayV2
2022-05-14 12:16:00 +01:00
Dean Herbert
a346456daf
Add test coverage of new traversal keys
2022-05-14 03:01:42 +09:00
Dean Herbert
c0abce918f
Add enum to snap method as alternative to mutliple nested invocations
2022-05-12 16:19:07 +09:00
Dan Balasescu
5f2d9bf04c
Merge pull request #18211 from frenzibyte/audio-adjustment-breakage-alt
...
Fix mods potentially adjusting track while not selected
2022-05-12 15:44:19 +09:00
Salman Ahmed
82c4a5fe9f
Merge branch 'master' into new-chat-visibility-behaviour
2022-05-12 09:04:24 +03:00
Dan Balasescu
678cde3310
Merge pull request #18230 from bdach/mod-overlay/data-flow-refactor
...
Restructure data flow in mod select overlay
2022-05-12 14:40:49 +09:00
Dean Herbert
3d64dc53a6
Merge branch 'master' into audio-adjustment-breakage-alt
2022-05-12 14:18:28 +09:00
Dean Herbert
6ba0760b17
Merge branch 'master' into new-chat-visibility-behaviour
2022-05-12 13:59:35 +09:00
Dan Balasescu
effc92475b
Merge pull request #18227 from frenzibyte/fix-results-screen-test-failure
...
Fix intermittent test failures in results screen
2022-05-12 11:19:13 +09:00
Jai Sharma
c45e8f619b
Update ChannelList test scene
2022-05-11 22:52:25 +01:00
Bartłomiej Dach
7ac6073f13
Fix column test scene to work
2022-05-11 22:31:25 +02:00
Bartłomiej Dach
315c67a316
Add failing test case for ruleset without all mod types
2022-05-11 22:03:41 +02:00
Bartłomiej Dach
9b7ff9f2ee
Rename modSelect{Screen -> Overlay}2 variable
2022-05-11 18:05:09 +02:00
Bartłomiej Dach
62f6caf76d
Rename ModSelect{Screen -> Overlay} test scenes
2022-05-11 18:04:39 +02:00
Salman Ahmed
9d30b490ad
Fix intermittent test failures in results screen
2022-05-11 18:28:30 +03:00
Salman Ahmed
a97986df1c
Merge branch 'master' into update-libraries
2022-05-11 15:58:45 +03:00
Dean Herbert
fecf92e16f
Update libraries to latest versions
2022-05-11 19:54:59 +09:00
Salman Ahmed
d51689e9ae
Unfocus textbox when dismissing popover in test scene
2022-05-11 11:25:41 +03:00
Salman Ahmed
f797514bce
Add failing test cases
2022-05-11 09:51:59 +03:00
Salman Ahmed
e43ce28ada
Remove references of "difficulty point" in sample point test scene
...
Fat-fingered.
2022-05-11 09:51:09 +03:00
Dean Herbert
53259251af
Merge branch 'master' into mod-overlay/rename-new
2022-05-11 10:15:59 +09:00
Dean Herbert
dd316befb4
Merge pull request #18214 from bdach/mod-overlay/delete-old
...
Remove old mod overlay code
2022-05-11 10:09:42 +09:00
Bartłomiej Dach
76c63f1d0a
Rename ModSelect{Screen -> Overlay} in place of removed old design
2022-05-10 22:56:50 +02:00
Bartłomiej Dach
c4c7556fb2
Make remains of TestSceneModSettings non-visual
...
As they're not really testing anything visual.
2022-05-10 22:07:26 +02:00
Bartłomiej Dach
33634cba1e
Remove old mod buttons
2022-05-10 21:58:22 +02:00
Bartłomiej Dach
24c59e2f2f
Remove old user mod select overlay
2022-05-10 21:52:17 +02:00
Bartłomiej Dach
4a3447f59f
Remove old free mod select overlay
2022-05-10 21:45:57 +02:00
Bartłomiej Dach
9cfe2cc310
Move TestCustomisableModRuleset out of TestSceneModSettings
2022-05-10 21:43:57 +02:00
Salman Ahmed
a0f1c48e80
Fix ModTimeRampTest failing due to changes in Update method
2022-05-10 19:24:36 +03:00
Dean Herbert
0eb29d56f2
Rename new test method to be english
2022-05-10 18:06:03 +03:00
Dean Herbert
87f6f74795
Add failing test coverage of adding a file to a detached beatmap across threads
2022-05-10 21:04:30 +09:00
Dean Herbert
9aadc274bf
Show first run dialog on first run of the game
2022-05-10 18:21:35 +09:00
Salman Ahmed
14a21e9224
Workaround interface mocks in TestSceneFirstRunSetupOverlay breaking with hot reload
2022-05-10 11:41:41 +03:00
Dean Herbert
a5b454edc7
Remove unnecessary DI caching of SentryLogger
2022-05-10 16:09:16 +09:00
Dan Balasescu
886a4815fa
Merge pull request #18180 from frenzibyte/fix-toolbox-double-tap
...
Fix `SettingsToolboxGroup` not clearing transforms before updating autosize
2022-05-10 13:48:02 +09:00
Salman Ahmed
beb86a7f7c
Remove usage of player settings in TestSceneSettingsToolboxGroup
2022-05-09 23:57:27 +03:00
Bartłomiej Dach
38e463d31d
Add failing test case for invalid mod adjustment management
2022-05-09 22:16:04 +02:00
Jai Sharma
ebb64d1f1a
Use AddUntilStep to wait for channel to load and become visible
2022-05-09 20:15:43 +01:00
Salman Ahmed
5726cf660f
Improve test coverage to use existing ThemeComparisonTestScene
2022-05-09 21:19:34 +03:00
Salman Ahmed
ceb6276d2f
Add failing test case
2022-05-09 18:19:29 +03:00
Jai Sharma
9ec8b609a8
Update channel visibility tests to be more correct
2022-05-09 12:11:25 +01:00
Jai Sharma
5f3bea846b
Simplify fetching of DrawableChannel
2022-05-09 12:11:25 +01:00
Salman Ahmed
deda1c83e6
Add failing test case
2022-05-09 13:48:51 +03:00
Salman Ahmed
0fe121f48a
Move and rename settings toolbox group test scene
2022-05-09 13:25:33 +03:00
Dan Balasescu
a16f2349aa
Fix next queued item not selecting after gameplay
2022-05-09 17:55:42 +09:00
Dean Herbert
ab1d46b71c
Merge pull request #17270 from frenzibyte/multiplayer-disable-adaptive-speed
...
Disable mod "Adaptive Speed" in multiplayer
2022-05-09 17:31:47 +09:00
Dan Balasescu
e9cc3ab54a
Merge pull request #18164 from Joehuu/fix-exit-dialog-bad-state
...
Fix popup dialog potentially not clicking last button when dismissed
2022-05-09 17:22:03 +09:00
Salman Ahmed
1677f1d696
Merge branch 'master' into results-screen-scaling
2022-05-09 11:11:55 +03:00
Joseph Madamba
bc839be4d8
Add failing rapid back button exit test
2022-05-08 14:40:29 -07:00
Salman Ahmed
077c77d524
Add method for scaling results screen in tests
2022-05-08 16:00:07 +03:00
Bartłomiej Dach
38c004d734
Add test coverage for hiding mod columns
2022-05-08 14:54:06 +02:00
Bartłomiej Dach
cbd1169495
Move cache declarations of ISamplePlaybackDisabler to interface
2022-05-08 10:38:58 +02:00
Bartłomiej Dach
9ae019eb39
Move ISamplePlaybackDisabler to more general namespace
2022-05-08 10:38:58 +02:00
Bartłomiej Dach
bdea6d8654
Add failing test for mod overlay not closing on entering skin editor
2022-05-07 22:47:19 +02:00
Bartłomiej Dach
a3e61fddcb
Rename skin editor scene library test scene to be more general
2022-05-07 22:43:53 +02:00
Bartłomiej Dach
836de49135
Adjust skin editor scene library test for extensibility
2022-05-07 22:43:47 +02:00
Bartłomiej Dach
5d6d7bb324
Fix incorrect assert in multiplayer song select test scene
2022-05-07 13:15:16 +02:00
Bartłomiej Dach
e7e7486a8e
Merge branch 'mod-overlay/back-button' into mod-overlay/integration
2022-05-07 10:59:30 +02:00
Bartłomiej Dach
9d3e67b10d
Update free mod select/deselect all test after back button addition
2022-05-07 10:25:23 +02:00
Bartłomiej Dach
1c029552d7
Add test coverage for mod select back button
2022-05-07 10:23:49 +02:00
Bartłomiej Dach
e1953c484c
Add test coverage for selecting/deselecting all mods on free mod select
2022-05-07 09:50:08 +02:00
Bartłomiej Dach
35c106efaa
Add test coverage for deselecting all mods on user mod select
2022-05-07 09:29:33 +02:00
Dean Herbert
dd63657dfb
Merge pull request #18065 from huoyaoyuan/code-style
...
Enforce code style analysis shipped with .NET SDK
2022-05-07 14:58:19 +09:00
Bartłomiej Dach
380cd1e036
Add test coverage for lack of customisation on free mod select
2022-05-06 21:35:22 +02:00
Salman Ahmed
f222affe88
Merge branch 'master' into fix-toolbox-expansion
2022-05-06 17:54:14 +03:00
Salman Ahmed
144d33f0d2
Merge branch 'master' into distance-snapping-test
2022-05-06 17:29:27 +03:00
Bartłomiej Dach
e527574ede
Merge branch 'master' into fix-toolbox-expansion
2022-05-06 13:47:36 +02:00
Bartłomiej Dach
19297375e2
Update tests to reflect new expected behaviour
2022-05-06 13:47:13 +02:00
Dean Herbert
98eab9668d
Merge pull request #18119 from bdach/mod-overlay/broken-hover
...
Fix mod panels not hovering correctly after closing customisation area via mouse on new mod select
2022-05-06 20:42:33 +09:00
Dean Herbert
daed42513e
Fix outdated test asserts
2022-05-06 18:44:25 +09:00
Bartłomiej Dach
8f217d1e97
Add failing test case for broken hover behaviour
2022-05-06 11:37:50 +02:00
Dean Herbert
32b40bdabf
Rename DistanceBetweenTick to be plural
2022-05-06 15:45:36 +09:00
Dean Herbert
060461a431
Add test coverage of multiplayer gameplay exit flow
2022-05-06 15:22:22 +09:00
Dean Herbert
641584a049
Merge branch 'master' into multiplayer-disable-adaptive-speed
2022-05-06 14:00:44 +09:00
Jai Sharma
7ffe3b132f
Use BindableFloat in chat height tests
2022-05-05 23:13:43 +01:00
Bartłomiej Dach
a2ab79620a
Update song select exit via click test to match new expectations
2022-05-05 22:16:57 +02:00
Bartłomiej Dach
d296f78dfe
Replace references to old mod select classes in multiplayer match screen test
2022-05-05 22:16:57 +02:00
Bartłomiej Dach
ecc2805099
Replace references to old mod select classes in match song select test
...
Also note the change from `songSelect.ChildrenOfType<>()...` to
`this.ChildrenOfType<>()...` - because the new design is registered at
game-level, the mod select is not a child of the song select screen
anymore.
2022-05-05 22:16:57 +02:00
Bartłomiej Dach
199bdb8e7d
Replace reference to old mod select in multiplayer test
2022-05-05 22:16:56 +02:00
Bartłomiej Dach
17c19063f7
Fix user dim test scene accumulating no fail instances in SelectedMods
...
The old design was apparently somehow tolerant of multiple instances of
the same mod in `SelectedMods`, but the new one is not.
Fix the test, because appending to a list of mods that was getting
modified by previous tests is generally not how tests should be
written.
2022-05-05 22:16:56 +02:00
Bartłomiej Dach
8f65e0e60f
Add failing test coverage for toggling mod overlay with hotkey
2022-05-05 22:16:56 +02:00
Bartłomiej Dach
ac08498f35
Use plum colour scheme in multiplayer to match rest of multiplayer screens
2022-05-05 22:16:54 +02:00
Bartłomiej Dach
407db7ff9d
Replace old mod select overlay with new design
2022-05-05 22:16:54 +02:00
Bartłomiej Dach
8002726c9c
Add test coverage for dismissing customisation area with Escape
2022-05-05 19:17:36 +02:00
Dean Herbert
9d48bb41c9
Merge branch 'master' into new-chat-overlay
2022-05-05 23:12:31 +09:00
Jai Sharma
5657e7f11e
Fix chat height saving/loading test
2022-05-05 14:52:03 +01:00
Jai Sharma
9cb52f8879
Add tests for chat height saving/loading
2022-05-05 14:21:26 +01:00
Dean Herbert
5029710de7
Merge branch 'master' into distance-snapping-test
2022-05-05 22:00:40 +09:00
Bartłomiej Dach
a859ca0b89
Merge branch 'master' into playlist-keyboard-traversal
2022-05-05 14:45:58 +02:00
Dan Balasescu
e46f99bdba
Merge branch 'master' into dialog-overlay-thread-woes
2022-05-05 20:57:51 +09:00
Salman Ahmed
8501a41619
Bring back separate bool properties as non-cascading
2022-05-05 14:37:38 +03:00
Dan Balasescu
39d10487b9
Merge branch 'master' into snapping-tidy-distance
2022-05-05 19:55:55 +09:00
Dean Herbert
e7205d8593
Reset all test data before each test method to avoid channels stuck in joined state
2022-05-05 19:09:56 +09:00
Dean Herbert
4efaa41670
Merge branch 'master' into new-chat-overlay
2022-05-05 18:57:00 +09:00
Salman Ahmed
269e15c167
Add test coverage of distance spacing multiplier working with distance snap grid
2022-05-05 18:49:12 +09:00
Dean Herbert
de9b3d33eb
Rename misleading DistanceSpacing variable
2022-05-05 17:08:09 +09:00
Dean Herbert
19cf9dc20b
Merge branch 'snapping-tidy-distance'
2022-05-05 16:51:32 +09:00
Dean Herbert
977e6d8a80
Add xmldoc for IDistanceSnapProvider and related properties
2022-05-05 16:25:45 +09:00
Dean Herbert
f6fc926f1a
Add xmldoc and rename methods in IPositionSnapProvider for legibility
2022-05-05 15:58:21 +09:00
Salman Ahmed
86aa2125fe
Add test coverage for multiplayer mod validity methods
2022-05-05 08:13:29 +03:00
Salman Ahmed
a26793cd65
Add missing Test prefix
2022-05-05 06:12:24 +03:00
Salman Ahmed
f28978b856
Handle against playlists which disallow selection
...
`SelectedItem.Disabled` is also not checked against in the select-via-click flow inside `DrawableRoomPlaylistItem` (only `AllowSelection` is checked).
2022-05-05 05:48:35 +03:00
Dean Herbert
a27fcda9f1
Fix failing tests due to CurrentDialog being unexpectedly not set after Push
2022-05-05 01:52:39 +09:00
Salman Ahmed
8f04db5df5
Bring back behaviour of checking incompatibility on gameplay validity
2022-05-04 17:21:19 +03:00
Salman Ahmed
e9ecf26b6a
Merge branch 'master' into multiplayer-disable-adaptive-speed
2022-05-04 17:12:03 +03:00
Jai Sharma
1a85e1267b
Ensure focus is directed to ChatTextBox from ChatOverlay and add tests
2022-05-04 14:43:40 +01:00
Dean Herbert
e920bbd497
Merge pull request #18081 from bdach/mod-overlay/test-coverage-parity
...
Port test coverage from old mod select overlay to new design
2022-05-04 20:24:50 +09:00
Dean Herbert
cf220f171b
Add test coverage of cross-thread transforms if a dialog is pushed too early
2022-05-04 20:23:36 +09:00
Bartłomiej Dach
ec27fa8e85
Add test coverage for keyboard selection
2022-05-04 13:15:10 +02:00
Bartłomiej Dach
6380216263
Nudge click location to avoid placement failures
2022-05-04 11:56:44 +02:00
Bartłomiej Dach
a759e641eb
Enforce composer aspect ratio to avoid depending on ambient window size
2022-05-04 11:56:29 +02:00
Dean Herbert
f899c3e68f
Add test coverage of circle placement around editor toolboxes
2022-05-04 17:56:53 +09:00
Huo Yaoyuan
8e96af8ff0
Update indentation to be clearer
2022-05-04 13:43:59 +08:00
Bartłomiej Dach
f5fa41356e
Rewrite mod instance management again to pass tests
2022-05-03 22:31:34 +02:00
Bartłomiej Dach
216dfb7e91
Expand incompatibility test to cover logic more thoroughly
2022-05-03 21:45:40 +02:00
Bartłomiej Dach
970361676b
Fix setting items not creating if mods initially not empty
2022-05-03 21:45:40 +02:00
Bartłomiej Dach
89d8ed8e20
Port existing test coverage
2022-05-03 21:45:39 +02:00
Dean Herbert
4fb66a812f
Merge branch 'master' into sheared-search-textbox
2022-05-03 14:12:59 +09:00
Huo Yaoyuan
5513710b2e
Fix IDE0055
2022-05-03 13:09:19 +08:00
Ganendra Afrasya
e6fbb19951
Implement new search textbox design
2022-05-03 11:13:07 +07:00
Dean Herbert
faeefc5e18
Merge pull request #16576 from frenzibyte/osu-distance-spacing
...
Add "distance spacing" support in editor for osu! ruleset
2022-05-03 12:15:18 +09:00
Dean Herbert
53d65e8215
Merge pull request #18021 from frenzibyte/overlay-ruleset-selector-redesign
...
Update overlay ruleset selector inline with osu-web design
2022-05-02 17:53:01 +09:00
Jai Sharma
bcce807311
Fix chat command test as reference equality checks on PM channels doesn't seem to to work
2022-05-01 12:20:54 +01:00
Jai Sharma
de393f735f
Implement basic layout and behaviour of new chat overlay
...
Provides initial implementation of new chat overlay in component
`ChatOverlayV2`. Contains only the basic functionality required for
a functioning chat overlay according to the new design with the intent
of added the rest of the functionality in subsequent PRs.
Backports existing tests for the current chat overlay except for ones
testing keyboard shortcuts (since they haven't been added) and tab
closing behaviour (since no tabs).
2022-04-30 23:59:47 +01:00
Dean Herbert
670b51324e
Add basic test at top of first run scene to make adjusting UI easier
2022-04-29 23:45:02 +09:00
Dean Herbert
5c04ab18ec
Merge pull request #18011 from frenzibyte/rewind-shift-click
...
Allow rewinding random in song select with "Shift + Left Click"
2022-04-29 23:10:29 +09:00
Salman Ahmed
55c03dc04d
Fix silly mistake in ordering and update test colour scheme
2022-04-29 12:40:46 +03:00
Salman Ahmed
5e19bdbf43
Refactor beatmap ruleset selector test scene
2022-04-29 12:23:02 +03:00
Salman Ahmed
fae8d86e15
Fix regressed profile ruleset selector test scene
...
Due to the changes in `APIUser`, which change equality to be based on ID.
2022-04-29 12:20:35 +03:00
Salman Ahmed
856ca96b66
Allow right-clicking to rewind on random button
2022-04-29 10:12:24 +03:00
Dean Herbert
1f1845d69b
Merge branch 'master' into multiplayer-force-start-2
2022-04-29 14:45:40 +09:00
Salman Ahmed
fef94d49f4
Revert "Convert data type of DistanceSpacing to float"
...
This reverts commit 7aaa88cac2
2022-04-29 08:02:07 +03:00
Dan Balasescu
fc21de8138
Merge pull request #18008 from peppy/add-tutorial
...
Add first run "beatmaps" screen
2022-04-29 13:10:45 +09:00
Dean Herbert
652e022fd6
Merge pull request #17973 from bdach/mod-overlay/dim-columns-offscreen
...
Dim offscreen columns on new mod select overlay
2022-04-29 11:55:27 +09:00
Dean Herbert
a75051cd00
Merge branch 'master' into add-tutorial
2022-04-29 11:25:17 +09:00
Salman Ahmed
294340279e
Add inputting test coverage
2022-04-29 04:14:09 +03:00
