Huo Yaoyuan
f5a7716509
Apply minor performance rules
2024-11-28 20:41:44 +08:00
Huo Yaoyuan
13d7c6a2d8
Enable recommended rules for maintainability
2024-11-28 20:41:41 +08:00
Huo Yaoyuan
c57ace0b5f
Enable recommended rules for documentation
2024-11-28 20:41:32 +08:00
Bartłomiej Dach
d0e80ce982
Merge pull request #30895 from peppy/watch-replay-reliability
...
Fix watch replay button sometimes not loading the replay on first click
2024-11-28 13:16:40 +01:00
Hiviexd
66093872e8
Adjust daily challenge tier thresholds to match expectations
2024-11-28 12:49:30 +01:00
Bartłomiej Dach
98a156ae2d
Merge pull request #30874 from peppy/chat-order
...
Sort public chat channels alphabetically, private channels based on recent messages
2024-11-28 12:46:14 +01:00
Bartłomiej Dach
c14fe21219
Fix LCA call crashing in actual usage
...
It's not allowed to call `LoadComponentsAsync()` on a background thread:
fd64f2f0d4/osu.Framework/Graphics/Containers/CompositeDrawable.cs (L147)
2024-11-28 11:19:00 +01:00
Dan Balasescu
1575eed5ba
Merge pull request #30893 from peppy/realm-perf-improvements
...
Improve realm update performance
2024-11-28 19:08:22 +09:00
Dan Balasescu
077719903b
Merge pull request #30905 from peppy/fix-multiple-offset-applications
...
Clear previous `LastLocalUserScore` when returning to song select
2024-11-28 18:58:13 +09:00
Bartłomiej Dach
b0958c8d41
Attempt to fix test failures
2024-11-28 10:29:53 +01:00
Dean Herbert
ced8dda1a2
Clear previous LastLocalUserScore when returning to song select
...
This seems like the lowest friction way of fixing
https://github.com/ppy/osu/issues/30885 .
We could also only null this on application, but this feels worse
because
- It would require local handling (potentially complex) in
`BeatmapOffsetControl` if we want to continue displaying the graph and
button after clicking it.
- It would make the session static very specific in usage and
potentially make future usage not possible due to being nulled in only
a very specific scenario.
One might argue that it would be nice to have this non-null until the
next play, but if such a usage comes up I'd propose we rename this
session static and add a new one with that purpose.
2024-11-28 18:01:28 +09:00
Bartłomiej Dach
0d491e3159
Merge branch 'master' into fix-daily-challenge-leaderboard
2024-11-28 09:41:24 +01:00
Dan Balasescu
5d7aafaab3
Merge pull request #30894 from HenintsoaSky/star-fountains-toggle-setting
...
Add a toggle for star fountains during gameplay
2024-11-28 17:35:11 +09:00
Salman Alshamrani
b1d0939142
Add localisation support
2024-11-28 02:37:31 -05:00
Salman Alshamrani
4a1401a33d
Rewrite bindable flow to make more sense
2024-11-28 02:37:27 -05:00
Dean Herbert
70eee8882a
Remove unnecessary null check
2024-11-28 15:42:37 +09:00
Dean Herbert
32b34c1967
Rename container to make more sense
2024-11-28 15:20:51 +09:00
Dean Herbert
4d9d5adbf4
Rename parameter to be more clear
2024-11-28 15:13:59 +09:00
Dean Herbert
e0fdcaf523
Merge pull request #30848 from Joehuu/dicord-fix-beatmap-button-visibility
...
Fix discord "view beatmap" button being shown when editing and hide identifiable information is set
2024-11-28 13:29:09 +09:00
Salman Alshamrani
24c0799680
Move beatmap ID lookup to UesrActivity
2024-11-27 16:54:51 -05:00
Salman Alshamrani
f792b6de00
Fix comment
2024-11-27 06:07:10 -05:00
Salman Alshamrani
4ae3ccfe48
Make BackButtonVisibility in game class private
2024-11-27 06:05:02 -05:00
Salman Alshamrani
efb68e4232
Refactor ResourcesSection to support new form of selection
2024-11-27 05:53:22 -05:00
Salman Alshamrani
b70fb4b0fe
Add FormBeatmapFileSelector for intermediate user-choice step
2024-11-27 05:52:43 -05:00
Dean Herbert
0f73941808
Combine new implementation back into the old one and use everywhere
2024-11-27 17:47:42 +09:00
Dean Herbert
7fdf13911b
Adjust the colour of non-pinned settings groups' headers to be more legible
2024-11-27 17:47:27 +09:00
Dean Herbert
782ce24ca6
Move player settings out of right flow
2024-11-27 17:09:15 +09:00
Dean Herbert
9c707ed341
Rename class and fix padding considerations
2024-11-27 16:47:54 +09:00
Dean Herbert
5ce55e9cb4
Merge branch 'master' into multi-spectator-settings-sidebar
2024-11-27 16:35:05 +09:00
Dean Herbert
4fcc76270a
Ensure events are unbound on disposal as a safety
2024-11-27 15:46:55 +09:00
Dean Herbert
5260a401d4
Use RealmLive in SaveFailedScoreButton
...
This also optimises the manager classes to better support `Live` usage
where the managed object is already in a good state (ie. doesn't require
re-fetching).
2024-11-27 15:25:42 +09:00
Salman Alshamrani
dfbccc2144
Knock some sense into the playlists results screen implementation
...
As we're moving towards using the `/playlist/<id>/scores/<id>` endpoint,
the existing playlists results screen classes needed some restructuring.
2024-11-27 01:20:43 -05:00
Dean Herbert
aa3d3a6344
Remove unnecessary local subscription in BeatmapCarousel
...
Not sure why I left this around during the refactor. This is 100%
handled by the `DetachedBeatmapStore`.
Removing this subscription reduces overheads by a huge amount for users
with large beatmap databases. My hypothesis is that subscriptions are
more expensive based on **the number of results matching**. This one
matches almost every beatmap so removing it is a large win.
2024-11-27 14:24:57 +09:00
HenintsoaSky
a477bb7bfe
Renaming of 'StarFountainEnabled'
2024-11-27 07:38:33 +03:00
Dean Herbert
573aaf6637
Merge pull request #27128 from frenzibyte/user-statistics-provider
...
Introduce `UserStatisticsProvider` component and add support for respecting selected ruleset
2024-11-27 13:13:47 +09:00
Salman Alshamrani
9083daf363
Fix epic code failure
...
I wasn't feeling well last night.
2024-11-26 20:04:36 -05:00
Salman Alshamrani
3e1b4f4ac5
Rename AllowBackButton to AllowUserExit and rewrite visibility flow structure
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-11-26 16:52:39 -05:00
HenintsoaSky
80a66085a9
rename and remove again
2024-11-27 00:41:02 +03:00
HenintsoaSky
460471e73f
Rename of the setting
2024-11-27 00:27:22 +03:00
HenintsoaSky
df74a177ae
Add option to disable star fountain in gameplay
2024-11-27 00:13:32 +03:00
Joseph Madamba
9173a74552
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip
2024-11-26 12:13:08 -08:00
Joseph Madamba
f04862ea74
Edit one more word not using british english
2024-11-26 12:11:29 -08:00
Bartłomiej Dach
33c2eb1af7
Merge pull request #30881 from peppy/fix-editor-state-leaking
...
Fix hitobjects' samples getting in bad state when changing selection between objects
2024-11-26 13:54:50 +01:00
Bartłomiej Dach
3e373ae85e
Merge pull request #30868 from peppy/ur-perf-fix
...
Improve performance of UR calculations
2024-11-26 13:54:17 +01:00
Dan Balasescu
4c7976bb93
Remove unused using
2024-11-26 21:11:48 +09:00
Dan Balasescu
af0c6fc51b
Add Room.HasEnded helper method
2024-11-26 21:09:28 +09:00
Bartłomiej Dach
46d1f00590
Fix Beatmap.Countdown not being copied on conversion
2024-11-26 11:39:03 +01:00
Bartłomiej Dach
cf905d0f5c
Merge branch 'master' into beatmap-info-purge
2024-11-26 10:21:16 +01:00
Dean Herbert
bf29e3ae71
Simplify hide code by moving to common method
2024-11-26 18:00:32 +09:00
Dean Herbert
71294c312b
Change point of queueing to avoid loading-from-in-queue
2024-11-26 17:58:50 +09:00
Dean Herbert
98044c108e
Revert "Ensure DrawableMedal loading doesn't ever block on online resources"
...
This reverts commit 8585327858
2024-11-26 17:41:12 +09:00
tsrk.
41c309fb72
chore(MenuTip): update text according to recent changes
...
Signed-off-by: tsrk. <tsrk@tsrk.me>
2024-11-26 09:35:18 +01:00
Dean Herbert
3ecb3b674d
Don't reset state when changing from one selection to another in the editor
...
This was causing state pollution in the new selection. I can't see why
this needs to happen when a selection changes to another.
This fixes https://github.com/ppy/osu/issues/30839 and also the same
issue happening for the new combo toggle.
Tests all seem to pass, and I can't immediately find anything broken,
but YMMV.
2024-11-26 17:33:41 +09:00
Dan Balasescu
d3d111de7d
Merge pull request #30832 from peppy/mania-precise-scroll-speed
...
Allow setting osu!mania scroll speed to single decimal precision
2024-11-26 17:30:56 +09:00
Dean Herbert
1e6c04e98b
Remove debug logging
2024-11-26 16:11:06 +09:00
Salman Alshamrani
42c68ba43e
Add inline comment
2024-11-26 01:28:58 -05:00
Salman Alshamrani
b76460f100
Schedule the thing
...
Queuing up requests on change to `api.LocalUser` is bad because the API
state is updated after `LocalUser` is updated, therefore we have to
schhhhhedullllllllleeeeeeeeeeeeeeee.
2024-11-26 01:26:44 -05:00
Dean Herbert
e3ea38a366
Add setting to allow hold-for-pause to still exist
...
Users have asked for this multiple times since last release.
Not sure on the best default value, but I'm going with the
stable/classic one, at least for the initial release to avoid needing
migrations.
In the future we may reconsider this for new users.
2024-11-26 15:14:19 +09:00
Salman Alshamrani
7201bac60d
Remove DailyChallengePlayer
2024-11-26 01:10:19 -05:00
Salman Alshamrani
c1416f9920
Bring back user-based endpoint for viewing result screen from playlists lounge
2024-11-26 01:10:12 -05:00
Salman Alshamrani
d150aeef2b
Use score-based endpoint everywhere
2024-11-26 01:01:59 -05:00
Dean Herbert
e8fae85e8d
Fix hidden dissmissing logic
2024-11-26 14:45:40 +09:00
Dean Herbert
672dbe6e03
Better control of show/hide of overlay
2024-11-26 14:42:30 +09:00
Dean Herbert
d057dc9a95
Refactor MedalOverlay to be more readable
...
Shouldn't really have any functionality changes, just fixing some old
code that I can't easily parse these days.
2024-11-26 14:19:39 +09:00
Dean Herbert
8585327858
Ensure DrawableMedal loading doesn't ever block on online resources
2024-11-26 14:08:53 +09:00
Salman Alshamrani
dfa21574fd
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip
2024-11-25 23:52:56 -05:00
Dean Herbert
17347563ee
Fix incorrect null handling
2024-11-26 13:25:57 +09:00
Dean Herbert
f708466a9b
Add test coverage
2024-11-26 13:25:55 +09:00
Dean Herbert
d6cf1db0f5
Add basic xmldoc to results class
2024-11-26 12:16:26 +09:00
Dean Herbert
d903d381d5
Rename NextProcessableIndex to EventCount in line with actual functionality
2024-11-26 12:10:34 +09:00
Dean Herbert
9ca17f9b6b
Merge pull request #30748 from stanriders/scale-profile-beatmaps
...
Scale down beatmap cards
2024-11-25 22:53:51 +09:00
Bartłomiej Dach
0a3f3c3210
Add guard against fetching statistics for non-legacy rulesets
2024-11-25 13:14:22 +01:00
Dean Herbert
bbe8f2ec44
Only update unstable rate counter when an applicable hitobject is reached
2024-11-25 21:13:18 +09:00
Dean Herbert
ea68d4b33a
Use class instead of record for lower allocations
2024-11-25 21:13:18 +09:00
Dean Herbert
5668258182
Add incremental processing
2024-11-25 21:13:17 +09:00
Bartłomiej Dach
78c01c1b5a
Merge branch 'master' into beatmap-defaults-match-stable
2024-11-25 12:55:08 +01:00
Dean Herbert
33d725e889
Address unstable rate calculations as a list for marginal gains
2024-11-25 19:44:11 +09:00
Dean Herbert
605fe71f46
Make empty hitwindows readonly static and slightly improve comparison performance
2024-11-25 19:17:32 +09:00
Bartłomiej Dach
1410e8837a
Merge branch 'master' into better-room-status
2024-11-25 09:48:40 +01:00
Dean Herbert
82bdd8fbfc
Merge pull request #30861 from frenzibyte/fix-multiplayer-missing-hold-delay
...
Fix pause shortcut on multiplayer no longer requiring hold
2024-11-25 16:22:56 +09:00
Dean Herbert
876c2e468a
Merge pull request #30858 from frenzibyte/fix-match-settings-overlay-typo
2024-11-25 15:58:17 +09:00
Salman Alshamrani
1468385559
Reset new file states after syncing
2024-11-24 22:38:48 -05:00
tsrk.
cfaf972813
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip
2024-11-24 18:24:43 +01:00
Dean Herbert
c34827a4ed
Merge pull request #30862 from frenzibyte/dont-scare-the-player
...
Don't play fail animation if restarting on fail
2024-11-24 23:11:19 +09:00
tsrk.
8611ed31c2
refactor(MenuTip): add localisation support
...
Signed-off-by: tsrk. <tsrk@tsrk.me>
2024-11-24 14:22:56 +01:00
Dean Herbert
888f02e3a6
Merge pull request #30855 from SupDos/tips-remove-fps
...
Remove FPS shortcut tip
2024-11-24 19:57:08 +09:00
Salman Alshamrani
ae9119eef0
Hide back button when quick-restarting unless load time takes long
2024-11-24 05:40:06 -05:00
Salman Alshamrani
2420793466
Allow controlling back button visibility state from screens
2024-11-24 05:39:43 -05:00
Salman Alshamrani
6d0d7f3e75
Don't play fail animation if restarting on failure
2024-11-24 04:45:48 -05:00
Salman Alshamrani
f3155bfc7d
Fix pause shortcut on multiplayer not delayed
2024-11-24 04:24:31 -05:00
Salman Alshamrani
631bfadd68
Replace event subscription with callback in UserStatisticsWatcher
...
Also no longer cancels previous API requests as there's no actual need to do it.
2024-11-24 04:11:13 -05:00
Salman Alshamrani
3480da22d2
Remove no-op SaveState call
2024-11-24 01:13:39 -05:00
Salman Alshamrani
95a6226413
Only enable button if there are different filenames
2024-11-24 01:11:36 -05:00
Salman Alshamrani
a872f74974
Make sync button only affect changed resource type
2024-11-24 01:02:34 -05:00
Salman Alshamrani
c8b13b726d
Add localisation support
2024-11-24 00:45:17 -05:00
Salman Alshamrani
e348b3a7aa
Only enable button if there are multiple difficulties
2024-11-24 00:34:03 -05:00
Salman Alshamrani
8e20dc7e9d
Add option to update all difficulties with new background/audio file
2024-11-24 00:32:50 -05:00
Salman Alshamrani
871c365fd8
Preserve existing beatmap background/audio files if used elsewhere
2024-11-24 00:32:27 -05:00
Salman Alshamrani
956da0383f
Merge branch 'master' into multiplayer-remove-expired-item-removal
2024-11-23 22:19:21 -05:00
Salman Alshamrani
8f5d513d46
Fix room auto start duration setting applied to the wrong component
2024-11-23 22:16:29 -05:00
Salman Alshamrani
6b78553559
Merge branch 'master' into tips-remove-fps
2024-11-23 20:57:14 -05:00
SupDos
2f096f71d3
Remove FPS shortcut tip
2024-11-24 02:34:30 +01:00
Salman Alshamrani
608bda135a
Merge branch 'master' into fix-song-ticker-contrast
2024-11-23 20:14:33 -05:00
Salman Alshamrani
2f45ebeec8
Remove using directive
2024-11-23 20:13:57 -05:00
Salman Alshamrani
eed02c2ab1
Fix daily challenge results screen beginning score fetch from user highest
2024-11-23 15:45:29 -05:00
Sheppsu
3713bb48b7
expand and contract settings from hover
2024-11-23 01:09:58 -05:00
Salman Alshamrani
c9dc6628fc
Merge branch 'master' into remove-macos-recommendation
2024-11-22 23:14:09 -05:00
Dean Herbert
ce41c000a1
Merge pull request #30812 from smoogipoo/playlist-populate-on-enter
...
Fix joining playlists room sometimes not selecting the first item
2024-11-22 23:57:45 +09:00
Dan Balasescu
5ebaab7e9a
Add localisation
2024-11-22 21:21:04 +09:00
Dan Balasescu
82a63228de
Improve handling of multiplayer room status
2024-11-22 21:21:04 +09:00
Dean Herbert
9930922769
Fix chat channel listing not being ordered to expectations
...
- Public channels (and announcements) are now alphabetically ordered.
- Private message channels are now ordered by most recent activity.
Closes https://github.com/ppy/osu/issues/30835 .
2024-11-22 19:53:26 +09:00
Dean Herbert
c844d65a81
Use TryGetValue wherever possible
...
Rider says so.
2024-11-22 19:11:16 +09:00
Bartłomiej Dach
ead7e99c59
Fix incorrect comment
2024-11-22 11:06:36 +01:00
Dean Herbert
c590bef4c3
Remove legacy default setter for SamplesMatchPlaybackRate now that it's the default
2024-11-22 19:05:29 +09:00
Dean Herbert
086a34f5c0
Merge branch 'master' into beatmap-info-purge
2024-11-22 18:47:32 +09:00
Dean Herbert
e33e0e16e8
Merge branch 'master' into scale-profile-beatmaps
2024-11-22 18:33:37 +09:00
Dean Herbert
04ed954387
Fix song ticker having very bad contrast against bright backgrounds
...
Closes #30814 .
2024-11-22 18:17:55 +09:00
Bartłomiej Dach
8b68859d9d
Fix Room.CopyFrom() skipping a field
...
Was making the close button not display when creating a room anew.
2024-11-22 09:57:57 +01:00
Bartłomiej Dach
cfc38df889
Add close button to playlists footer
2024-11-22 09:57:56 +01:00
Bartłomiej Dach
69c2c988a1
Add extra check to ensure closed rooms can't be closed harder
2024-11-22 09:54:56 +01:00
Dean Herbert
29757ffdf2
Allow setting osu!mania scroll speed to single decimal precision
...
Addresses https://github.com/ppy/osu/discussions/30663 .
2024-11-22 17:36:28 +09:00
Dan Balasescu
39504c348d
Cleanup CopyFrom() method
...
Though the code appears slightly different, it should be semantically
equivalent. APIUser equality is implemented on `Id` and `Host` should
never transition from non-null to null.
2024-11-22 17:22:30 +09:00
Dan Balasescu
e59ac9e7c8
No longer remove expired playlist items from Room model
2024-11-22 17:19:26 +09:00
Bartłomiej Dach
3b2f43012e
Merge branch 'master' into close-playlists
2024-11-22 09:02:41 +01:00
Bartłomiej Dach
479ff7eb41
Merge pull request #30799 from peppy/fix-player-loader-focus-fux
...
Fix beatmap load not continuing when when settings slider is focused
2024-11-22 08:57:10 +01:00
Dean Herbert
a76b4418b9
Change some beatmap default settings to match stable
...
- Countdown should [be off by
default](9a07485638/osu9a07485638/osu
2024-11-22 16:55:37 +09:00
Bartłomiej Dach
512d2c6e3b
Merge branch 'master' into multiplayer-nrt
2024-11-22 08:09:42 +01:00
Bartłomiej Dach
4a129ac0bf
Merge pull request #30766 from Darius-Wattimena/catch-improve-info-on-selected
...
Add snapping info to the catch selected objects inspector
2024-11-22 08:08:33 +01:00
Dean Herbert
6a0ac4c29e
Merge pull request #29640 from smoogipoo/mania-imperfect-ss
...
Make mania award SS even if there are GREAT judgements
2024-11-22 14:42:32 +09:00
Dean Herbert
41addaae9a
Rename variable to imply it is now a function
2024-11-22 13:11:32 +09:00
Salman Alshamrani
5dffc322af
Recreate beatmap every test run in ModTestScene
2024-11-21 17:48:33 -05:00
Dan Balasescu
2a7266cb23
Fix tests
2024-11-22 01:26:35 +09:00
Dan Balasescu
f738fb2a89
Populate rooms as soon as they're joined
2024-11-21 23:48:04 +09:00
Dan Balasescu
84ac3097c2
Populate parameter description
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-11-21 22:47:46 +09:00
Bartłomiej Dach
74170ea28e
Merge branch 'master' into patch-1
2024-11-21 13:06:19 +01:00
Dan Balasescu
209380cbac
Enable NRT in TestMultiplayerRoomManager
2024-11-21 21:03:12 +09:00
Dan Balasescu
cc59434ea4
Fix crash due to being too forgiving of nulls
...
This one is super duper annoying to test, because we already have e.g.
`TestScenePlaylistsScreen`. The only way to test it would be to use an
`OsuGameTestScene`.
Maybe this is okay?
2024-11-21 20:52:34 +09:00
Dan Balasescu
dc45816566
Fix inspection
2024-11-21 20:41:14 +09:00
Dan Balasescu
6870c99eb2
Enable NRT for multiplayer and playlists
2024-11-21 20:32:09 +09:00
Bartłomiej Dach
0e4d078beb
Merge branch 'master' into catch-improve-info-on-selected
2024-11-21 12:17:54 +01:00
Dean Herbert
033b7c17d5
Add back macOS precheck
2024-11-21 18:13:00 +09:00
Dan Balasescu
7018672275
Fix playlist room status resetting on enter
2024-11-21 18:11:41 +09:00
Dan Balasescu
fe8e9d455a
Add failing test
2024-11-21 18:09:39 +09:00
Cadence Ember
37394a5027
Use consistent decimal places in BeatmapAttributeText
2024-11-21 14:04:42 +13:00
Dean Herbert
2c0140f865
Merge pull request #30798 from frenzibyte/fix-precision
...
Add sane precision values to all settings
2024-11-21 03:00:49 +09:00
Dean Herbert
ae98f63b51
Fix beatmap load not continuing when when settings slider is focused
...
Regressed with recent sliderbar focus changes.
Closes #30716 .
2024-11-21 02:28:35 +09:00
Salman Alshamrani
40b95901e3
Fix more cases of settings with no defined precision values
2024-11-20 12:11:38 -05:00
Salman Alshamrani
1ef02fec06
Fix "positional hitsounds level" setting not specifying a precision constraint
2024-11-20 12:08:57 -05:00
Bartłomiej Dach
a679f0736e
Add ability to close playlists within grace period after creation
2024-11-20 12:36:12 +01:00
Fivoka
7726ca02b0
Changed multiplier from 2 to 3.5
2024-11-20 12:29:29 +01:00
