Lucas A
ed4c025c7e
Fix other tests and move TestPlaySongSelect class declaration.
2021-05-17 12:55:59 +02:00
Lucas A
fe11426238
Disable appearance of the stable import prompt waiting for user interaction in tests, which caused them to fail.
2021-05-17 12:55:59 +02:00
Dean Herbert
da0913ca2d
Make SongProgress a skinnable component
2021-05-17 18:52:56 +09:00
Andrei Zavatski
fc6e65b7db
Delete TestSceneNewsSideBar.cs
2021-05-17 12:02:06 +03:00
Andrei Zavatski
01090de1fd
Fix filenames does not match contained type
2021-05-17 11:55:55 +03:00
Andrei Zavatski
586c5c7365
Emulate year changes in the test scene
2021-05-17 11:36:53 +03:00
Dean Herbert
ae1e62288d
Reorder tests to not have the first test show nothing
2021-05-17 16:16:50 +09:00
Dean Herbert
22561cda19
MonthDropdown -> MonthSection
2021-05-17 16:02:21 +09:00
Dean Herbert
50e2b5a327
SideBar -> Sidebar
2021-05-17 16:00:36 +09:00
Swords
264d8b9b86
Finishing requested changes, and tidy up
2021-05-16 14:48:00 +10:00
Andrei Zavatski
881d82ccb6
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-15 19:08:48 +03:00
Swords
b5e1f78c06
Merge branch 'master' into single-bind-reset-button
2021-05-15 20:29:56 +10:00
Swords
c282f0e603
Fixing tests
...
For some reason moving the mouse and clicking doesn't work with "dotnet test", but works when you run the osu.Game.Tests project.
2021-05-15 19:42:33 +10:00
Dean Herbert
dc56250a3c
Merge branch 'master' into player-loader-star-rating
2021-05-15 15:39:57 +09:00
Dean Herbert
94b7e89ac0
Merge pull request #12747 from frenzibyte/current-star-rating
...
Allow changing current star difficulty of a `StarRatingDisplay`
2021-05-15 15:39:39 +09:00
Dean Herbert
bdcb1a624e
Merge pull request #12759 from Naxesss/beatmap-verifier-context
...
Encapsulate check arguments in context object
2021-05-15 15:39:12 +09:00
Swords
ecc260030a
Merge branch 'master' into single-bind-reset-button
2021-05-15 12:05:42 +10:00
Swords
304caf8bdf
Adding Requested changed
2021-05-15 11:24:08 +10:00
Bartłomiej Dach
7665bdfbbb
Merge branch 'master' into null-assignment-warning-enable
2021-05-15 01:08:34 +02:00
Bartłomiej Dach
d581e0a252
Ignore possible nulls in NotifyCollectionChangedArgs
...
Safe to access by the virtue of the preceding case labels on
`args.Action`. And they're in test code anyways.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
e62e473bb2
Ignore possible null in multiplayer test
...
A null value will fail the test anyhow.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
b51d038088
Ignore possible path-related nulls
...
They're all in test code anyway, so any issue there will cause a test to
fail.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
f2d0f7db99
Remove list null-checks in LogoTrackingContainer test
...
If the null-checks were tripped, the test would crash anyway. It is not
possible to call `.Any()` and get a valid result instead of an exception
on a null reference.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
c9facf70f9
Use conditional nullability attribute
...
As it turns out, C# 8 provides an attribute that allows annotating that
an `out` parameter's nullability depends on the method's return value,
which is exactly what is desired here.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
1c92b3a8f5
De-duplicate star rating display creation in test
2021-05-14 22:03:44 +02:00
Swords
843da30f9d
Reformatting
2021-05-15 01:52:16 +10:00
Swords
6a52622b3f
Merge branch 'single-bind-reset-button' of https://github.com/holaswords/osu into single-bind-reset-button
2021-05-15 01:31:40 +10:00
Swords
1603b92211
Reformatting
2021-05-15 01:30:54 +10:00
Swords
85174793b1
Merge branch 'master' into single-bind-reset-button
2021-05-15 01:07:32 +10:00
Swords
0725088fde
Well it works, just pretty ugly looking.
2021-05-15 01:01:17 +10:00
Salman Ahmed
93007c1635
Merge branch 'current-star-rating' into player-loader-star-rating
2021-05-14 16:06:00 +03:00
Salman Ahmed
6cc678f497
Remove nullability and transition support from star rating display
2021-05-14 16:05:40 +03:00
Salman Ahmed
db361efecf
Add test beatmap difficulty cache with calc. blocking support
2021-05-14 15:53:56 +03:00
Salman Ahmed
34aab11ff3
Add null star rating display test case
2021-05-14 14:25:46 +03:00
Salman Ahmed
0655825057
Separate changing star rating display to own test
2021-05-14 14:25:13 +03:00
Dean Herbert
9069db0743
Fix case of hitObjects variables
2021-05-14 16:22:19 +09:00
Dean Herbert
48672f8afd
Add very basic test logic to ensure PlayerLoader is present for playlists
2021-05-14 15:02:36 +09:00
Naxess
9860e482af
Use TestWorkingBeatmap instead of null in tests
...
Fixes the warning that #12801 will give.
2021-05-14 05:32:52 +02:00
Andrei Zavatski
94543bf000
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-13 16:00:46 +03:00
Dan Balasescu
d5b14b6b99
Merge branch 'master' into remove-skinnable-hud-classes
2021-05-13 21:06:48 +09:00
Dan Balasescu
746862dcb1
Merge pull request #12750 from peppy/skin-serialisation
...
Add skin editor saving / loading support
2021-05-13 20:58:03 +09:00
Naxess
94538b3842
Remove accidental whitespace
2021-05-13 12:56:36 +02:00
Dan Balasescu
a3869c02f4
Merge branch 'master' into fix-two-hovered-handles
2021-05-13 19:24:42 +09:00
Dean Herbert
c8b7cfc753
Merge branch 'skin-serialisation' into remove-skinnable-hud-classes
2021-05-13 19:05:08 +09:00
Naxess
19800f5f7f
Move IBeatmap arg into context
2021-05-13 11:24:22 +02:00
Dean Herbert
e0e9106921
Enable autoplay in skin editor tests
2021-05-13 14:55:11 +09:00
Naxess
e7c7786db3
Merge branch 'master' into beatmap-verifier-context
2021-05-13 07:40:33 +02:00
Dean Herbert
8b9ac86d4b
Merge branch 'master' into skin-serialisation
2021-05-13 12:35:06 +09:00
smoogipoo
5b03092968
Fix possible test failure
2021-05-13 11:53:50 +09:00
Andrei Zavatski
13a956f6fc
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-12 20:08:17 +03:00
Dean Herbert
55e1f97f59
Remove unused using statement
2021-05-12 19:06:40 +09:00
Dean Herbert
0a895fff15
Remove remaining test usage of SkinnableXXX HUD components
2021-05-12 18:53:25 +09:00
Salman Ahmed
80e231d90a
Add failing test case
2021-05-12 11:42:55 +03:00
Dean Herbert
c6f0a6aed3
Merge pull request #12538 from smoogipoo/multiplayer-spectator-screen
...
Implement the multiplayer spectator screen
2021-05-12 17:24:35 +09:00
smoogipoo
273cd18b8a
Use test streaming client in gameplay leaderboard test
2021-05-12 14:19:36 +09:00
smoogipoo
21fc0ba43b
Combine test spectator streaming client implementations
2021-05-12 13:05:02 +09:00
Naxess
c13b93e6f1
Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks
...
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
See next commit for example.
2021-05-12 02:29:18 +02:00
Andrei Zavatski
085c3d067f
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-11 23:41:45 +03:00
Andrei Zavatski
b0297c6324
Fix incorrect no posts handling and add corresponding test
2021-05-11 20:52:11 +03:00
Andrei Zavatski
822d99e69f
Remove pointless test scenes
2021-05-11 20:42:13 +03:00
Dean Herbert
048677846b
Change HealthDisplay to be a CompositeDrawable
2021-05-11 23:10:30 +09:00
Andrei Zavatski
b79a0237a3
Fix TestSceneNewsYearsPanel error
2021-05-11 16:54:19 +03:00
Andrei Zavatski
c2ba16f977
Use relative sizing for MonthDropdown
2021-05-11 16:51:59 +03:00
Andrei Zavatski
208224cc0d
CI fixes
2021-05-11 16:08:09 +03:00
Andrei Zavatski
705aad262a
Rename MonthPanel to MonthDropdown
2021-05-11 15:42:40 +03:00
Andrei Zavatski
0a9c3c9413
Move metadata change logic to it's own method
2021-05-11 15:39:50 +03:00
Andrei Zavatski
9603712aa1
Cache metadata in NewsSideBar
2021-05-11 15:33:27 +03:00
Andrei Zavatski
82436334b2
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-11 13:52:51 +03:00
smoogipoo
f5bc389998
Fix flaky tests
2021-05-11 19:31:32 +09:00
smoogipoo
bc4213eea1
Add test for changing back to idle on deletion
2021-05-11 19:26:58 +09:00
smoogipoo
7fe8737d94
Add failing tests
2021-05-11 19:21:44 +09:00
smoogipoo
811282a975
Add failing test
2021-05-11 19:01:41 +09:00
Dean Herbert
61ea3f2e64
Remove unnecessary test step creating needless skins
2021-05-11 18:39:15 +09:00
Dean Herbert
2396ba42a6
Change HealthDisplay to be a CompositeDrawable
2021-05-11 18:39:14 +09:00
Dean Herbert
004798d61d
Update Legacy components to not require skin in ctor
2021-05-11 18:39:14 +09:00
smoogipoo
10a4a5decb
Merge branch 'master' into multiplayer-spectator-screen
2021-05-11 17:33:09 +09:00
Dan Balasescu
7d9cdd3bc2
Merge branch 'master' into skin-components-list
2021-05-11 17:27:48 +09:00
Salman Ahmed
004ce95f33
Merge branch 'current-star-rating' into player-loader-star-rating
2021-05-11 09:53:10 +03:00
smoogipoo
7c8dd91674
Rename test to better match tested class
2021-05-11 09:29:15 +09:00
Dean Herbert
6bb52ebcf8
Merge pull request #12570 from frenzibyte/corner-rotation-controls
...
Add rotation controls to editor selection box corners
2021-05-10 23:09:44 +09:00
Andrei Zavatski
220eef0351
Remove overcomplicated date logic in MonthPanel
2021-05-10 17:00:18 +03:00
Andrei Zavatski
fbf8b198cd
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-10 16:47:15 +03:00
Dan Balasescu
e7355da201
Merge branch 'master' into osu-markdown
2021-05-10 20:02:04 +09:00
Dean Herbert
2ecd638f7f
Merge branch 'master' into skin-components-list
2021-05-10 18:13:10 +09:00
Andrei Zavatski
0d243be457
CI fixes
2021-05-10 10:07:43 +03:00
Andrei Zavatski
4b97224932
Implement NewsSideBar component
2021-05-10 09:53:52 +03:00
Dean Herbert
97e72849af
Fix regressed HitErrorDisplay behaviour (and localise binding to meter implementations)
2021-05-10 15:24:13 +09:00
Salman Ahmed
ca772b60b1
Use regular test steps rather than one-time set up and scheduling
2021-05-10 08:56:30 +03:00
Salman Ahmed
301dab1ce8
Refactor StarRatingDisplay to be mutable with a current bindable
2021-05-10 08:56:30 +03:00
Andrei Zavatski
7971a2ef48
Implement MonthPanel component
2021-05-10 08:47:00 +03:00
Andrei Zavatski
7ca3e13712
Implement basic years panel
2021-05-10 07:43:01 +03:00
Dean Herbert
52ce16f9f1
Merge branch 'master' into player-loader-star-rating
2021-05-10 12:46:10 +09:00
Dean Herbert
9ba412d27e
Add the osu! logo to the test scene
...
Makes no sense to add a test intended to test visual behaviour with one
of the main elements missing. Not sure how you would be able to test the
flow with the logo's presence.
2021-05-10 12:44:08 +09:00
Dean Herbert
b7acf9de52
Make test work without manually clicking things
2021-05-10 12:36:56 +09:00
Dean Herbert
2b90bc4f1f
Remove unnecessary ruleset switching steps
2021-05-10 12:35:37 +09:00
Dean Herbert
0c973feb53
Tidy up test scene
2021-05-10 12:34:21 +09:00
Dean Herbert
3c3500d070
Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces
2021-05-10 12:23:18 +09:00
Dean Herbert
1d38fa29b5
Remove unused using statement
2021-05-10 12:23:04 +09:00
Dean Herbert
1bbbe80420
Fix missing instances of HealthProcessor caching
2021-05-10 12:22:24 +09:00
Dean Herbert
132bb7832d
Fix some regressions when updating test scenes
2021-05-10 12:06:33 +09:00
Dean Herbert
b274fdf20d
Merge branch 'master' into skin-components-bind-outwards-health
2021-05-10 11:13:44 +09:00
Joseph Madamba
8964d51de9
Add ability to sort by source in song select
2021-05-09 14:10:38 -07:00
Dean Herbert
2bcf1ed306
Merge pull request #12715 from Cublibre/fix-early-exit-crash
...
Fix InvalidOperationException when exiting a map at the end
2021-05-09 23:21:19 +09:00
Bartłomiej Dach
eb716455b7
Merge branch 'master' into skin-components-bind-outwards-accuracy
2021-05-09 12:13:18 +02:00
Andrei Zavatski
879c08e666
Use UntilStep instead of Assert to check button visibility
2021-05-09 10:06:36 +03:00
Andrei Zavatski
f0c1784d05
Use FirstOrDefault instead of First
2021-05-09 09:12:37 +03:00
Swords
1a465c60ca
Rename Tests
2021-05-09 16:07:18 +10:00
Ibby
075350e125
Adding a reset button to individual keybinds
2021-05-09 15:51:17 +10:00
Andrei Zavatski
8868439ce4
Another approach to fix test scene failure
2021-05-09 06:49:12 +03:00
Andrei Zavatski
0818deac17
Fix potential test scene failure due to showMoreButton not being loaded in time
2021-05-09 06:06:34 +03:00
Christine Chen
ae2b5a0806
Actually test that player was exited
2021-05-08 22:42:14 -04:00
Andrei Zavatski
342c5a5938
Add tests to indicate the issue
2021-05-09 04:49:40 +03:00
Salman Ahmed
8fba655d2e
Allow changing ruleset during test
2021-05-08 23:02:38 +03:00
Bartłomiej Dach
efb9164658
Restore previous test scene logic
2021-05-08 21:35:12 +02:00
Bartłomiej Dach
0bc6a026eb
Merge branch 'master' into skin-components-bind-outwards-accuracy
2021-05-08 21:08:53 +02:00
Salman Ahmed
f701c331f2
Add initial fade in to the metadata display
...
Avoids first frame discrepancies from appearing in the test scene, those can be delt with later on, if needed.
2021-05-08 21:19:46 +03:00
Bartłomiej Dach
dec5400c0a
Merge branch 'master' into skin-components-bind-outwards-score-display
2021-05-08 19:58:19 +02:00
Bartłomiej Dach
9e0ea494fd
Merge branch 'master' into skin-components-bind-outwards
2021-05-08 19:04:56 +02:00
Christine Chen
25312b3e88
Don't restart completion delegate on exit, revert exit behavior to lazer
2021-05-08 11:47:44 -04:00
Salman Ahmed
ca55287dd0
Pass empty facade and replace random property with method instead
2021-05-08 18:43:45 +03:00
Salman Ahmed
3575d9847c
Use regular test steps rather than one-time set up and scheduling
2021-05-08 18:21:29 +03:00
Salman Ahmed
d9605e8070
Remove test scene description
2021-05-08 18:18:23 +03:00
Salman Ahmed
26c0010fe6
Fix test not handling 0 beatmap sets
2021-05-08 13:03:50 +03:00
Salman Ahmed
dca5efc59a
Remove no longer necessary ruleset info requirement
2021-05-08 13:00:39 +03:00
Salman Ahmed
0410edecaf
Refactor StarRatingDisplay to be mutable with a current bindable
2021-05-08 12:55:34 +03:00
Salman Ahmed
b4801faf32
Pass ruleset info to constructor instead
...
Follows the way working beatmap is passed, not sure why mods are passed as a bindable though, don't wanna bother too much with that.
2021-05-08 11:57:13 +03:00
Salman Ahmed
169a283402
Add visual test scene
2021-05-08 11:47:18 +03:00
Christine Chen
8c564a69ed
Fix InvalidOperationException when exiting a map at the end
2021-05-07 21:11:03 -04:00
Dean Herbert
1cb10c2a22
Remove unnecessary binding logic from HUDOverlay
2021-05-07 17:51:46 +09:00
Dean Herbert
a7acecc52b
Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces
2021-05-07 17:51:41 +09:00
Dean Herbert
3044b1c432
Add missing cache rules
2021-05-07 17:50:44 +09:00
Dean Herbert
6c255a0572
Fix drain start time being weirdly incorrect
2021-05-07 17:47:33 +09:00
Dean Herbert
8e78cac058
Fix HealthProcessor cached as derived type in test
2021-05-07 17:31:29 +09:00
Dean Herbert
04d35826a3
Merge branch 'skin-components-bind-outwards-accuracy' into remove-hud-overlay-unused-pieces
2021-05-07 17:25:39 +09:00
Dean Herbert
84a4ff333e
Update skin editor test scene to cache a ScoreProcessor
2021-05-07 17:22:56 +09:00
Dean Herbert
755588258e
Update HealthDisplay components to use DI to attach data source
2021-05-07 17:22:45 +09:00
Dean Herbert
4ac234bf7f
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy
2021-05-07 17:15:57 +09:00
Dean Herbert
6dc591fc44
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display
2021-05-07 17:15:37 +09:00
Dean Herbert
9d27b11e49
Update skin editor test scene to cache a ScoreProcessor
2021-05-07 17:10:31 +09:00
Dean Herbert
01eff7f316
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display
2021-05-07 16:30:08 +09:00
Dean Herbert
93f10330e3
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy
2021-05-07 16:29:10 +09:00
Dean Herbert
ad398165a2
Update AccuracyCounter components to use DI to attach data source
2021-05-07 16:27:25 +09:00
Dean Herbert
17b93361d5
Merge branch 'master' into skin-components-bind-outwards
2021-05-07 16:20:24 +09:00
Dean Herbert
a2e4fb5b6b
Update ScoreCounter components to bind outwards
2021-05-07 16:16:48 +09:00
Dean Herbert
165f443ab5
Merge branch 'master' into add-missing-author-links
2021-05-07 14:32:44 +09:00
Dean Herbert
48b834d12a
Merge branch 'master' into mbd-beatmap-set-cover
2021-05-07 13:19:17 +09:00
Gagah Pangeran Rosfatiputra
67f51959db
Merge branch 'master' into osu-markdown
2021-05-06 16:23:20 +07:00
Gagah Pangeran Rosfatiputra
91283d41ce
add paragraph test
2021-05-06 15:13:43 +07:00
Dean Herbert
aff32b0d19
Merge branch 'master' into skin-components-list
2021-05-06 14:17:33 +09:00
Bartłomiej Dach
3cac837acf
Merge branch 'master' into skin-bindables
2021-05-05 20:16:27 +02:00
