20187 Commits

Author	SHA1	Message	Date
Dean Herbert	59bfa08684	Forcefully re-apply DrawableHitObject state transforms on post-load DefaultsApplied	2020-09-25 18:26:54 +09:00
Dean Herbert	4cc02abc76	Update framework	2020-09-25 18:11:49 +09:00
Dean Herbert	dbfa05d3b3	Fix placement object not getting updated with initial state	2020-09-25 18:00:17 +09:00
Dean Herbert	b561429f92	Add toolbar toggle buttons for hit samples	2020-09-25 17:53:41 +09:00
Dean Herbert	346d14d40b	Rename variables to match	2020-09-25 17:45:19 +09:00
Dean Herbert	22511c36c3	Ensure toggles are not instantiated more than once for safety	2020-09-25 17:43:09 +09:00
Dean Herbert	51cc644b7b	Fix set access to SelectionHandler ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2020-09-25 17:42:49 +09:00
Dan Balasescu	7b09f73fe5	Merge branch 'master' into new-combo-toggle	2020-09-25 17:33:12 +09:00
Dan Balasescu	e1fc8d76fb	Merge branch 'master' into editor-dont-block-keys-unnecessarily	2020-09-25 17:31:41 +09:00
Dean Herbert	b8e9f19b92	Move common HitSampleInfo lookup to static method	2020-09-25 17:30:31 +09:00
Dean Herbert	98c6027352	Remove unused using	2020-09-25 17:07:58 +09:00
Dan Balasescu	9b29c9e185	Merge branch 'master' into editor-ternary-states	2020-09-25 16:58:15 +09:00
Dean Herbert	b70a20e7f1	Avoid consuming keystrokes in editor when a modifier key is held down	2020-09-25 16:56:39 +09:00
Dean Herbert	da820c815e	Add shortcut keys to toolbox gorup titles	2020-09-25 16:46:06 +09:00
Dean Herbert	a6298c60eb	Fix button spacing	2020-09-25 16:44:37 +09:00
Dean Herbert	ae68dcd962	Add ternary toggle buttons to editor toolbox selection	2020-09-25 16:38:12 +09:00
Dan Balasescu	039e1b2032	Merge pull request #10217 from peppy/fix-taiko-editor-type-stats ... Fix changing rim/strong types in taiko editor not applying correctly	2020-09-25 15:43:43 +09:00
Dean Herbert	0f8551e9ea	Merge branch 'editor-ternary-states' into new-combo-toggle	2020-09-25 15:36:33 +09:00
Dean Herbert	bac6515d09	Merge branch 'master' into editor-ternary-states	2020-09-25 15:35:52 +09:00
Dean Herbert	a859fe78ee	Expose update ternary state method and use better state determination function	2020-09-25 15:32:36 +09:00
Dean Herbert	50290f3cb4	Rework ternary states to fix context menus not updating after already displayed	2020-09-25 15:10:13 +09:00
Dan Balasescu	f1efc0ba42	Merge pull request #10240 from peppy/fix-setup-textbox-commit ... Ensure setup screen text boxes commit on losing focus	2020-09-25 14:58:26 +09:00
Dan Balasescu	69d057a8b3	Merge branch 'master' into fix-taiko-editor-type-stats	2020-09-25 14:53:47 +09:00
Dan Balasescu	e828cf1607	Merge branch 'master' into editor-load-audio	2020-09-25 14:49:54 +09:00
Dan Balasescu	440adc305d	Merge pull request #10233 from peppy/file-selector ... Add a basic file selector with extension filtering support	2020-09-25 14:44:32 +09:00
Dan Balasescu	d9fee594ea	Merge pull request #10238 from peppy/fix-hoc-keyboard-shortcut-hard-crash ... Fix hard crash on hitting an out of range key (Q~P)	2020-09-25 14:44:14 +09:00
Dean Herbert	7f9a5f5f0d	Ensure setup screen text boxes commit on losing focus	2020-09-25 14:25:24 +09:00
Dean Herbert	a6adf8334e	Use existing method to update combo state of selection	2020-09-25 14:19:35 +09:00
Dean Herbert	e009264f10	Add new combo toggle to main composer interface	2020-09-25 14:10:30 +09:00
Dean Herbert	bca774a0d4	Allow BlueprintContainer to specify toggles	2020-09-25 14:09:31 +09:00
Dean Herbert	3c191cfe25	Add basic xmldoc to HitObjectComposer	2020-09-25 14:08:47 +09:00
Dean Herbert	325bfdbf71	Fix hard crash on hitting an out of range key (Q~P)	2020-09-25 13:25:42 +09:00
Dean Herbert	26ba7d3100	Remove unused method (was moved to a more local location)	2020-09-25 13:20:19 +09:00
Dean Herbert	892d440ed0	Add fallback path for potential null ParentGameplayClock	2020-09-25 13:19:07 +09:00
Dan Balasescu	952e84396a	Merge branch 'master' into editor-object-object-snapping	2020-09-25 13:17:30 +09:00
Dean Herbert	7df8b5bce7	Merge branch 'master' into fix-spinner-rpm-user-rate-adjust	2020-09-25 13:17:03 +09:00
Dean Herbert	ea971ecb90	Remove local file handling from SetupScreen	2020-09-25 13:16:30 +09:00
Dean Herbert	50ba320a51	Expand available file operations in ArchiveModelManager	2020-09-25 13:16:30 +09:00
Dean Herbert	71e1f981fe	Merge branch 'file-selector' into editor-load-audio	2020-09-25 12:44:00 +09:00
Dean Herbert	a890e5830d	Add more file icons	2020-09-25 12:42:28 +09:00
Dean Herbert	1b8b417b85	Merge branch 'master' into file-selector	2020-09-25 12:33:18 +09:00
Dean Herbert	f047ff10bf	Remove local specification for file selector search path	2020-09-25 12:30:05 +09:00
Dean Herbert	b1e72c311e	Add null check because we can	2020-09-25 12:28:41 +09:00
Dean Herbert	a17eac3692	Rename reload method to not mention beatmap unnecessarily	2020-09-25 12:27:08 +09:00
Dean Herbert	981585930d	Merge branch 'master' into editor-load-audio	2020-09-25 12:24:16 +09:00
Dean Herbert	44a6637c36	Use SingleOrDefault	2020-09-25 12:20:37 +09:00
Dean Herbert	90c4c172bf	Merge branch 'master' into fix-editor-screen-settings-remembering	2020-09-25 12:19:45 +09:00
Dean Herbert	b9196718b7	Merge branch 'master' into editor-object-object-snapping	2020-09-25 12:15:10 +09:00
Dean Herbert	c3df7e1fa8	Fix scroll container's scrollbar not respecting minimum size on first resize	2020-09-25 01:05:12 +09:00
Dean Herbert	dc85bcd470	Merge pull request #10229 from smoogipoo/fix-ruleset-disposal ... Fix rulesets disposing game-wide texture store	2020-09-24 22:54:45 +09:00
Dean Herbert	011b176244	Add test coverage of audio track changing	2020-09-24 22:00:13 +09:00
Dean Herbert	cc9ae32811	Fix summary timeline not updating to new track length correctly	2020-09-24 21:05:29 +09:00
Dean Herbert	833ff1c1d7	Fix test failures due to editor dependency	2020-09-24 20:56:35 +09:00
Dean Herbert	7e7e2fd64a	Use bindable for track to fix rate adjustments not applying correctly	2020-09-24 20:56:35 +09:00
Dean Herbert	978f6edf38	Add basic track reloading support while inside the editor	2020-09-24 20:56:35 +09:00
Dean Herbert	65e6dd2ac3	Remove the previous audio file before adding a new one	2020-09-24 20:56:35 +09:00
Dean Herbert	4d714866cd	Add ability to actually import a new audio file to the beatmap / database	2020-09-24 20:56:35 +09:00
Dean Herbert	4b9581bca0	Add audio selection to song setup screen	2020-09-24 20:56:35 +09:00
Dean Herbert	937d5870b3	Add a basic file selector with extension filtering support	2020-09-24 20:54:25 +09:00
Dean Herbert	158d307126	Avoid destroying editor screens when changing between modes	2020-09-24 17:03:54 +09:00
Dan Balasescu	abec9224cf	Merge pull request #10230 from peppy/editor-toggle-shortcuts ... Add ability to toggle editor toggles using keyboard shortcuts (Q~P)	2020-09-24 16:55:39 +09:00
Dan Balasescu	ad30c20b8c	Merge pull request #10227 from peppy/editor-negative-current-time ... Fix editor not showing sign when time goes negative	2020-09-24 16:27:05 +09:00
Dean Herbert	44be0ab762	Add basic osu! object to object snapping	2020-09-24 16:24:35 +09:00
Dean Herbert	6ebea3f6f2	Add ability to toggle editor toggles using keyboard shortcuts (Q~P)	2020-09-24 16:24:25 +09:00
Dan Balasescu	f84b5087bd	Merge pull request #10226 from peppy/results-fix-relayout-misalignment ... Fix score panel being incorrectly vertically aligned on screen resize	2020-09-24 15:50:31 +09:00
smoogipoo	62c2dbc310	Nest classes + make private	2020-09-24 14:33:43 +09:00
Dan Balasescu	02d8355321	Merge pull request #10224 from peppy/results-statistics-replay-button ... Add more descriptive description and download button when statistics not available	2020-09-24 14:31:38 +09:00
smoogipoo	600b823a30	Fix game texture store being disposed by rulesets	2020-09-24 14:30:18 +09:00
Dean Herbert	33fad27ec2	Avoid API change to DrawableHitObject	2020-09-24 13:28:29 +09:00
Dean Herbert	00b0228b61	Merge branch 'master' into fix-taiko-editor-type-stats	2020-09-24 13:18:13 +09:00
Dean Herbert	9c074e0ffb	Fix editor not showing sign when time goes negative	2020-09-24 13:10:54 +09:00
Dean Herbert	5612357574	Fix score panel being incorrectly vertically aligned on screen resize	2020-09-24 12:49:32 +09:00
Dean Herbert	fda6e88dd3	Fix braces style	2020-09-24 12:39:08 +09:00
Dean Herbert	cb903ec9e2	Fix extended statistics not being vertically centered	2020-09-24 12:21:46 +09:00
Dean Herbert	f4d2c2684d	Add more descriptive description and download button when statistics not available	2020-09-24 12:21:08 +09:00
Dean Herbert	fb9d2cb05c	Merge pull request #10218 from peppy/update-framework	2020-09-23 21:45:36 +09:00
Dean Herbert	26d1c4322d	Merge pull request #10200 from peppy/fix-hit-object-container-unbinding ... Fix HitObjectContainer not correctly unbinding from startTime fast enough	2020-09-23 21:17:31 +09:00
Dan Balasescu	37af9e767f	Merge branch 'master' into fix-taiko-change-handling	2020-09-23 19:47:29 +09:00
Dan Balasescu	d1e41e41f7	Merge pull request #10214 from peppy/new-combo-editor-toggle ... Add the ability to toggle new combo state from composer context menu	2020-09-23 19:46:55 +09:00
Dean Herbert	e8d099c01d	Update framework	2020-09-23 19:28:20 +09:00
Dean Herbert	fee379b4b9	Reword xmldoc for legibility	2020-09-23 18:12:07 +09:00
Dean Herbert	9a0e5ac154	Handle type/strength changes from samples changes	2020-09-23 18:09:40 +09:00
Dean Herbert	ccb3ef5020	Merge branch 'new-combo-editor-toggle' into fix-taiko-change-handling	2020-09-23 17:08:27 +09:00
Dean Herbert	02201d0ec6	Fix incorrect cast logic	2020-09-23 17:08:25 +09:00
Dean Herbert	487fc2a2c6	Add missing change handler scopings to taiko context menu operations	2020-09-23 16:58:22 +09:00
Dean Herbert	2d67faeb72	Add xmldoc	2020-09-23 16:40:56 +09:00
Dean Herbert	a1ec167982	Add the ability to toggle new combo state from composer context menu	2020-09-23 16:38:16 +09:00
Joehu	c5b684bd2e	Fix typo in log when beatmap fails to load	2020-09-23 00:30:20 -07:00
Dan Balasescu	d6ae66384d	Merge branch 'master' into fix-hit-object-container-unbinding	2020-09-23 15:16:58 +09:00
Dean Herbert	c38cd50723	Fix editor not using beatmap combo colours initially on load	2020-09-23 13:16:50 +09:00
Dean Herbert	80fb8f074c	Merge branch 'master' into add-editor-keybindings	2020-09-23 12:32:04 +09:00
Dean Herbert	260ca31df0	Change default mute key to Ctrl+F4 for now	2020-09-23 12:31:50 +09:00
Dan Balasescu	fbaa6675c2	Merge branch 'master' into fix-hit-object-container-unbinding	2020-09-23 12:05:14 +09:00
Dan Balasescu	3d90bb5e38	Merge pull request #10203 from peppy/fix-fail-animation ... Fix fail animation breaking on post-fail judgements	2020-09-23 11:57:49 +09:00
Dan Balasescu	6d58973452	Merge pull request #10208 from peppy/reduce-all-hitobject-enumerator-complexity ... Reduce complexity of AllHitObjects enumerator when nested playfields are not present	2020-09-23 11:50:10 +09:00
Bartłomiej Dach	941ff81d8d	Merge branch 'master' into fix-hit-object-container-unbinding	2020-09-22 16:38:35 +02:00
Dean Herbert	e0a2321822	Reduce complexity of AllHitObjects enumerator when nested playfields are not present	2020-09-22 18:17:04 +09:00
Dean Herbert	0e01ac2d90	Merge branch 'master' into fix-new-samples-starting-while-gameplay-paused	2020-09-22 16:16:54 +09:00
Dean Herbert	3062fe4411	Add editor key bindings to switch between screens	2020-09-22 15:55:25 +09:00
Dean Herbert	3276b9ae9c	Fix fail animation breaking on post-fail judgements	2020-09-22 15:08:53 +09:00
Dean Herbert	552968f65f	Remove unnecessary using	2020-09-22 13:38:52 +09:00
Dean Herbert	7c40071b21	Revert changes to SkinnableTestScene but change load order	2020-09-22 13:35:35 +09:00
Salman Ahmed	bfe332909c	Remove "hide combo counter on break time" feature for being too complex ... The combo counter will be hidden at most one second after the break has started anyways, so why not just remove this feature if the way of implementing it is complicated to be merged within the legacy counter implementation.	2020-09-21 14:32:14 +03:00
Dean Herbert	508278505f	Make local clock private	2020-09-21 19:40:57 +09:00
Dean Herbert	3f788da06d	Fix SPM changing incorrectly with playback rate changes	2020-09-21 19:39:54 +09:00
Dean Herbert	dd5b15c64f	Fix HitObjectContainer not correctly unbinding from startTime fast enough	2020-09-21 18:27:15 +09:00
Dean Herbert	1e09d8fd1a	Merge branch 'master' into catch-combo-counter	2020-09-21 17:53:00 +09:00
S Stewart	d2f498a268	remove unnec using	2020-09-19 15:13:52 -05:00
S Stewart	c49dcca1ff	spacing oops	2020-09-19 14:55:52 -05:00
S Stewart	e0cef6686d	Change collection deletion notif to be consistent	2020-09-19 14:54:14 -05:00
Salman Ahmed	735b6b0d6f	Remove a pointless portion of the inline comment	2020-09-19 05:54:40 +03:00
Salman Ahmed	6aa84424e4	Merge remote-tracking branch 'upstream/master' into fix-new-samples-starting-while-gameplay-paused	2020-09-19 05:53:04 +03:00
Dean Herbert	1fcf443314	Ensure BeatmapProcessor.PostProcess is run before firing HitObjectUpdated events	2020-09-18 19:33:03 +09:00
Joehu	393ee1c9f5	Fix hovered osu tab items not showing hover state when deselected	2020-09-17 23:09:09 -07:00
Joehu	2ad7e6ca88	Fix hovered channel tabs color when unselected	2020-09-17 19:10:58 -07:00
Joehu	83d23c9547	Use new icon in chat overlay	2020-09-17 14:56:08 -07:00
Dean Herbert	141fbbf5bb	Merge pull request #10180 from smoogipoo/beatmap-conversion-cancellation ... Make beatmap conversion support cancellation tokens	2020-09-17 22:30:46 +09:00
smoogipoo	de5ef8a471	Rework to support obsoletion	2020-09-17 21:37:32 +09:00
smoogipoo	e71991a53c	Add default token	2020-09-17 18:37:48 +09:00
smoogipoo	c7d24203ce	Make beatmap conversion support cancellation tokens	2020-09-17 17:40:05 +09:00
smoogipoo	73a7b759cb	Add missing obsoletion notice	2020-09-17 17:04:44 +09:00
Dan Balasescu	0d889f8cc0	Merge pull request #10173 from Joehuu/fix-profile-section-tab-control-input ... Fix profile section tab control not absorbing input from behind	2020-09-17 16:53:18 +09:00
Dean Herbert	3529a1bfea	Fix global bindings being lost when running tests under headless contexts	2020-09-17 13:01:14 +09:00
Dean Herbert	c7e4b192ae	Merge branch 'master' into better-skin-hashing	2020-09-17 12:30:14 +09:00
Joehu	9063c60b9c	Fix profile section tab control not absorbing input from behind	2020-09-16 12:00:27 -07:00
Joehu	c6386ea605	Remember leaderboard mods filter selection in song select	2020-09-15 21:53:35 -07:00
Salman Ahmed	35c7677d0a	Fix gameplay samples potentially start playing while player is paused	2020-09-16 01:59:07 +03:00
Dean Herbert	53f9381ad9	Merge branch 'master' into better-skin-hashing	2020-09-16 00:25:33 +09:00
Dean Herbert	3c70b3127c	Fix potential nullref in FilterControl during asynchronous load	2020-09-15 23:19:31 +09:00
Dan Balasescu	8f5115b4e8	Merge branch 'master' into fix-test-storage-weirdness	2020-09-15 19:32:52 +09:00
Dean Herbert	f7c9c80566	Force OsuGameTests to use a unique storage each run	2020-09-15 19:01:32 +09:00
Dan Balasescu	0761aab42f	Merge branch 'master' into catch-combo-counter	2020-09-15 17:20:31 +09:00
Dan Balasescu	fc15b4546d	Merge pull request #10140 from peppy/editor-clipboard ... Editor clipboard support	2020-09-15 17:15:49 +09:00
Dean Herbert	d03bfec807	Merge branch 'master' into fix-test-storage-weirdness	2020-09-15 16:54:06 +09:00
Dean Herbert	7f2ce14f36	Merge pull request #9294 from smoogipoo/morth-taiko-changes	2020-09-15 16:11:17 +09:00
Dan Balasescu	16ae83c499	Merge branch 'master' into editor-clipboard	2020-09-15 16:05:43 +09:00
Dan Balasescu	6cbff98295	Merge branch 'master' into add-collections-to-beatmap-options	2020-09-15 15:23:33 +09:00
Dan Balasescu	3e1c517700	Merge pull request #10160 from peppy/ss-dispose-null-check ... Add null check in SongSelect disposal for safety	2020-09-15 15:06:17 +09:00
Dean Herbert	914785ce17	Merge branch 'master' into fix-test-storage-weirdness	2020-09-15 14:49:10 +09:00
Dean Herbert	0446bc8610	Fix game.ini getting left over by PlayerTestScene subclasses	2020-09-15 14:43:24 +09:00
Dean Herbert	2c7492d717	Add null check in SongSelect disposal for safety	2020-09-15 14:34:58 +09:00
Dean Herbert	879979ef57	Move host lookup to inside lazy retrieval to handle edge cases	2020-09-15 14:25:31 +09:00
Dean Herbert	234152b2fe	Use host storage as LocalStorage for headless test runs	2020-09-15 14:17:40 +09:00
Joehu	43daabc982	Remove unused using and move dialog to BDL	2020-09-14 12:10:00 -07:00
Joehu	c833f5fcc4	Reorder buttons to match stable	2020-09-14 11:23:41 -07:00
Joehu	57610ddad5	Fix beatmap options absorbing input from toolbar ruleset selector	2020-09-14 11:22:16 -07:00
Joehu	c30174cea3	Add manage collections button to beatmap options	2020-09-14 11:21:23 -07:00
Joehu	1a8a7ae7f8	Remove hardcoded key param from AddButton	2020-09-14 11:19:18 -07:00
Joehu	368aca015a	Move override methods to bottom	2020-09-14 11:18:00 -07:00
Bartłomiej Dach	a377cccb4d	Unsubscribe from track changed event on disposal	2020-09-14 17:10:35 +02:00