Dean Herbert
|
e43d91ad5d
|
Fix another case of incorrect null checking in editor verification processing
|
2021-11-04 15:18:10 +09:00 |
|
Dean Herbert
|
1e73b09e57
|
Fix another couple of cases of incorrect string null/empty checking
|
2021-11-04 14:22:28 +09:00 |
|
smoogipoo
|
81aaef719f
|
Add xmldoc to CalculateTimed()
|
2021-11-02 17:55:00 +09:00 |
|
smoogipoo
|
168a7a588b
|
Add xmldoc to ctor also
|
2021-11-02 17:19:14 +09:00 |
|
smoogipoo
|
efba7a9c4d
|
Missed hyphen
|
2021-11-02 17:18:02 +09:00 |
|
smoogipoo
|
0cdd2898fe
|
Expose non-adjusted time from CalculateTimed()
|
2021-11-02 17:17:14 +09:00 |
|
Dean Herbert
|
34d4715220
|
Allow for long online IDs and implement in ScoreInfo
|
2021-10-29 11:48:36 +09:00 |
|
Dean Herbert
|
5c7623e68e
|
Merge pull request #15255 from goodtrailer/node-samples-ilist
Change IHasRepeats.NodeSamples to IList from List
|
2021-10-28 14:24:26 +09:00 |
|
Dean Herbert
|
add39fbd4f
|
Merge branch 'master' into fix-skin-layout-editor-crash
|
2021-10-28 06:24:24 +09:00 |
|
Dean Herbert
|
6944151486
|
Apply batch fixing of built-in types using var
|
2021-10-27 13:04:41 +09:00 |
|
Dean Herbert
|
d5b4c68d3a
|
Merge branch 'master' into fix-slider-path-extension-incorrectness
|
2021-10-26 17:36:50 +09:00 |
|
Dan Balasescu
|
6a6d3a5e8a
|
Merge pull request #15304 from peppy/fix-editor-new-beatmap-sample-change-crash
Fix editor crash when attempting to change sample/velocity from timeline on new beatmap
|
2021-10-26 17:13:56 +09:00 |
|
Dean Herbert
|
dae7cdc4c5
|
Ensure HitObject-local control points are non-default after ApplyDefaults
We will probably want to make this whole flow more efficient in the
future, but this should suffice for now.
|
2021-10-26 16:06:03 +09:00 |
|
Dean Herbert
|
81fee02c2b
|
Fix slider paths being extended even when the last two points are equal
|
2021-10-26 15:47:59 +09:00 |
|
Jason Won
|
a582976851
|
reversing slider maintains shape
|
2021-10-26 00:05:46 -04:00 |
|
goodtrailer
|
0affe7b79d
|
Remove unnecessary using
|
2021-10-23 02:25:20 -07:00 |
|
goodtrailer
|
4440b9ca11
|
Change IHasRepeats.NodeSamples to IList from List
|
2021-10-23 01:59:07 -07:00 |
|
Dean Herbert
|
93482414d6
|
Remove SkinConfiguration subclasses and allow configuration parsing for all skin types
|
2021-10-22 14:42:23 +09:00 |
|
Dean Herbert
|
2c5ba1d8e2
|
Change OnlineID to non-nullable to allow for indexing in Realm
|
2021-10-18 15:53:40 +09:00 |
|
Dean Herbert
|
8fb9aec730
|
Fix threaded realm usage not disposing context fast enough
|
2021-10-15 16:39:53 +09:00 |
|
Dean Herbert
|
e47ccbd08a
|
Fix realm transactional overhead when rapidly changing RulesetConfigManager values
|
2021-10-15 13:50:26 +09:00 |
|
smoogipoo
|
aa380a11c1
|
Merge branch 'master' into no-more-difficulty-control-points-info
|
2021-10-14 12:02:10 +09:00 |
|
Bartłomiej Dach
|
c7db286b94
|
Merge branch 'master' into file-sanity-checks
|
2021-10-14 00:17:29 +02:00 |
|
Dan Balasescu
|
e49f1f6e6b
|
Merge branch 'master' into no-more-difficulty-control-points-info
|
2021-10-13 20:17:57 +09:00 |
|
Dean Herbert
|
82f7f99f37
|
Refactor to use scoped using (and also correctly dispose TagLib portion)
|
2021-10-12 10:46:26 +09:00 |
|
Naxesss
|
f2f97602f2
|
Dispose of video resource later
We need the Stream to stay open here because `StreamFileAbstraction` uses it later in the block.
|
2021-10-12 00:40:39 +02:00 |
|
Naxesss
|
47b4d03145
|
Dispose of Streams when used
|
2021-10-12 00:13:38 +02:00 |
|
Naxesss
|
ce69dd3588
|
Use Prescan flag for audio length check
|
2021-10-11 23:57:23 +02:00 |
|
Bartłomiej Dach
|
56eae703fe
|
Avoid changing frame stable clock direction if time hasn't changed between frames
|
2021-10-11 21:39:48 +02:00 |
|
Naxesss
|
8f093b9a11
|
Use TagLib instead of ManagedBass
|
2021-10-11 13:56:26 +02:00 |
|
Naxesss
|
f0cd18a721
|
Only check each video file once
|
2021-10-11 13:55:50 +02:00 |
|
Naxesss
|
6aa054b5fa
|
Change to non-BASS error template
|
2021-10-11 13:53:23 +02:00 |
|
Dan Balasescu
|
8884091422
|
Merge pull request #15014 from joseph-ireland/remove-initial-strain
Change initial strain value in skills from 1 to 0
|
2021-10-10 15:56:20 +09:00 |
|
smoogipoo
|
bc37cb6f43
|
Merge branch 'master' into no-more-difficulty-control-points-info
|
2021-10-08 18:41:17 +09:00 |
|
Joseph Ireland
|
185bb9c122
|
change initial strain from 1 to 0 to allow simpler implementations
|
2021-10-07 09:30:18 +01:00 |
|
Dan Balasescu
|
d50443fdf2
|
Merge branch 'master' into difficulty-move-to-beatmap
|
2021-10-07 16:50:10 +09:00 |
|
Dean Herbert
|
433e7cd403
|
Fix rate mods not working if pp counter is displayed
|
2021-10-06 21:26:30 +09:00 |
|
Dean Herbert
|
b339c149d8
|
Copy BaseDifficulty to Beatmap<T> and move all write operations across
|
2021-10-06 15:10:45 +09:00 |
|
Dan Balasescu
|
e837a3511d
|
Merge branch 'master' into beatmap-difficulty-more-interface-usage
|
2021-10-06 12:18:51 +09:00 |
|
Dan Balasescu
|
4bbff2ebf7
|
Merge branch 'master' into new-interfaces
|
2021-10-06 11:38:17 +09:00 |
|
Dean Herbert
|
4d5696959b
|
Remove unnecessary access modifier in interface
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
|
2021-10-06 05:52:28 +09:00 |
|
Dean Herbert
|
bd84a8b749
|
Merge branch 'new-interfaces' into beatmap-difficulty-more-interface-usage
|
2021-10-05 18:21:21 +09:00 |
|
Dean Herbert
|
599d82e383
|
Avoid returning a live IEnumerable
|
2021-10-05 17:01:07 +09:00 |
|
Dean Herbert
|
676df55a0e
|
Fade display out during rewind (as the value displayed is no longer valid)
|
2021-10-05 15:39:29 +09:00 |
|
Dean Herbert
|
b6af93d434
|
Apply some code quality refactoring
|
2021-10-05 15:14:49 +09:00 |
|
Dean Herbert
|
1d99bc280f
|
Merge branch 'master' into new-interfaces
|
2021-10-04 20:42:40 +09:00 |
|
smoogipoo
|
031c5a441e
|
Merge branch 'master' into realtime-pp-display
|
2021-10-04 20:19:37 +09:00 |
|
Dean Herbert
|
fd6b10656c
|
Add TODO reminder about ruleset reference transfer quirk
|
2021-10-04 16:55:16 +09:00 |
|
smoogipoo
|
69c2b7dc59
|
Merge branch 'master' into rename-beatmap-info-beatmap-fields
|
2021-10-04 16:03:22 +09:00 |
|
Dean Herbert
|
ec61c3c5ee
|
Rename all remaining cases
|
2021-10-03 00:55:29 +09:00 |
|
Dean Herbert
|
32afd3f426
|
Replace all basic usages
|
2021-10-02 02:22:23 +09:00 |
|
smoogipoo
|
a1f880a36a
|
Split classes
|
2021-10-01 21:00:39 +09:00 |
|
smoogipoo
|
5820a71652
|
Fix mania difficulty calculator crashing
|
2021-10-01 19:57:45 +09:00 |
|
Dean Herbert
|
05996cc2e9
|
Add changes that got forgotted in branch surgery
|
2021-10-01 17:04:53 +09:00 |
|
Dean Herbert
|
a92d499d7a
|
Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
|
2021-10-01 16:55:50 +09:00 |
|
Dean Herbert
|
8595eb2d11
|
Switch BeatmapDifficulty usages to use interface type
|
2021-10-01 16:55:50 +09:00 |
|
Dean Herbert
|
d309636460
|
Update all EF based models to implement new read only interfaces
|
2021-10-01 16:55:50 +09:00 |
|
smoogipoo
|
84bddf0885
|
Initial PP counter implementation
|
2021-09-30 17:00:24 +09:00 |
|
Dean Herbert
|
46bafb6252
|
Merge branch 'master' into no-more-difficulty-control-points-info
|
2021-09-28 13:53:56 +09:00 |
|
Dean Herbert
|
16e60eed56
|
Reduce NestedHitObject enumerator overhead
This was especially bad due to it allocating on any and every start time
change, even the first (see usage in `HitObject.ctor`).
|
2021-09-20 15:09:27 +09:00 |
|
Dean Herbert
|
a743a3f306
|
Change combo bind logic to be non-weird
|
2021-09-17 19:15:14 +09:00 |
|
smoogipoo
|
2d39131202
|
Refactor taiko flashlight a bit
|
2021-09-17 18:41:03 +09:00 |
|
smoogipoo
|
f9d5abff8a
|
Update with keybinding changes
|
2021-09-16 18:26:12 +09:00 |
|
Dean Herbert
|
a1d325cb22
|
Mark key and value non-nullable (at realm end) and simplify Value logic
|
2021-09-15 17:16:05 +09:00 |
|
Dean Herbert
|
a150fb2996
|
Add nullability directive and make variant non-nullable
|
2021-09-15 17:16:05 +09:00 |
|
Dean Herbert
|
dcfe9c67e3
|
Make ruleset id non-nullable
|
2021-09-15 17:12:04 +09:00 |
|
Dean Herbert
|
80ecf81be3
|
Rename all databased setting classes to be specific to rulesets for now
|
2021-09-15 17:12:04 +09:00 |
|
Dean Herbert
|
520e550764
|
Bring back SettingsStore to avoid changing ruleset API for now
Also fixes some remaining test failures due to locally constructed
rulesets that are not being tracked by the game.
|
2021-09-15 17:12:02 +09:00 |
|
Dean Herbert
|
c36a67d06e
|
Fix some tests failing due to using a locally constructed ruleset
|
2021-09-15 17:04:38 +09:00 |
|
Dean Herbert
|
a2f1752344
|
Make settings works with current caching structure
Will likely pull out that `RulesetConfigCache` next, but this is an
"everything works" state.
|
2021-09-15 16:31:13 +09:00 |
|
Dean Herbert
|
187c557ea8
|
Begin migrating settings implementation across to realm
|
2021-09-15 16:22:14 +09:00 |
|
Dean Herbert
|
a7ae3cc03e
|
Change SampleControlPoint time to use leniency in bindable changed event too
|
2021-09-14 16:24:55 +09:00 |
|
Dean Herbert
|
cd227213e6
|
Ensure time of HitObject related ControlPoints are kept in sync with the hitobject
|
2021-09-10 15:59:30 +09:00 |
|
Dean Herbert
|
714f55b6bc
|
Clone control points when copying to HitObjects
|
2021-09-10 14:36:39 +09:00 |
|
Dean Herbert
|
464797fecf
|
Allow ModIcon to be constructed using an IMod
|
2021-09-10 12:43:12 +09:00 |
|
Dean Herbert
|
c3531e1361
|
Move more specification from Mod to IMod
|
2021-09-10 12:42:53 +09:00 |
|
Dean Herbert
|
719392de39
|
Change CreateInstance to use Activator.CreateInstance instead of clone
|
2021-09-10 12:05:10 +09:00 |
|
Dean Herbert
|
cf633973a9
|
Refactor exposed mod retrieval methods for better safety
|
2021-09-10 11:09:13 +09:00 |
|
Dean Herbert
|
2edb851008
|
Add ability to lookup mod from a type specification
|
2021-09-09 16:50:59 +09:00 |
|
Dean Herbert
|
4d0530ca9d
|
Add new methods to ruleset for quicker mod lookups
|
2021-09-09 16:46:14 +09:00 |
|
Dean Herbert
|
693ecdf62a
|
Refactor some incorrect/outdated terminology
|
2021-09-06 21:32:43 +09:00 |
|
Dean Herbert
|
3c7a34bdbd
|
Move mania-specific conversion to converter
|
2021-09-06 21:06:13 +09:00 |
|
Dean Herbert
|
766d789845
|
Rename ApproachRate to ScrollSpeed for now (to reduce complexity/confusion)
|
2021-09-06 21:06:13 +09:00 |
|
Dean Herbert
|
0500cd578a
|
Merge branch 'master' into no-more-difficulty-control-points-info
|
2021-09-06 21:06:12 +09:00 |
|
Dean Herbert
|
25420af078
|
Rename method to drop redundant ruleset suffix
|
2021-09-05 13:34:23 +09:00 |
|
Dean Herbert
|
6894ed3426
|
Fix new ordering of retrieval meaning EndTime is not available in time
|
2021-09-03 17:11:12 +09:00 |
|
Dean Herbert
|
74f385bad8
|
Assign default control points earlier in HitObject construction
|
2021-09-03 17:11:12 +09:00 |
|
Dean Herbert
|
1aff4c2238
|
Ensure all hitobject level control points are populated before calling virtual defaults application
|
2021-09-03 17:11:12 +09:00 |
|
Dean Herbert
|
d587dc6203
|
Populate new approach rate where required
|
2021-09-03 17:11:12 +09:00 |
|
Dean Herbert
|
d4e5a612ea
|
Update IPositionalSnapProvider to take a HitObject as reference, rather than raw time
This allows fetching the correct `DifficultyControlPoint` from the
hitobject. Nothing more.
|
2021-09-03 17:11:12 +09:00 |
|
Dean Herbert
|
a3d9ab1e2e
|
Move approach rate to EffectControlPoint
|
2021-09-03 16:58:16 +09:00 |
|
Dean Herbert
|
b41b1e2394
|
Write out DifficultyControlPoints into HitObjects
|
2021-09-03 16:58:16 +09:00 |
|
Bartłomiej Dach
|
ce1912781e
|
Add extension point for ruleset-specific beatmap setup sections
|
2021-09-02 23:29:14 +02:00 |
|
Dean Herbert
|
cdd0262ca1
|
Merge pull request #14598 from smoogipoo/adjust-classic-scoring
Make classic scoring a constant multiple of standardised scoring
|
2021-09-02 19:18:03 +09:00 |
|
Dan Balasescu
|
6c649b7bbe
|
Merge branch 'master' into no-more-sample-control-points-info
|
2021-09-02 18:09:05 +09:00 |
|
smoogipoo
|
e2f7aaeb71
|
Fix 0 score with bonus-only maps
|
2021-09-02 17:00:13 +09:00 |
|
Dean Herbert
|
b907c2f4f6
|
Fix osu! judgements getting scaled twice over different durations
|
2021-09-02 16:31:43 +09:00 |
|
smoogipoo
|
31433c4b89
|
Apply @spaceman_atlas' quadratic factor
|
2021-09-02 16:26:17 +09:00 |
|
smoogipoo
|
bd0f385cdb
|
Make classic scoring a constant multiple of standardised scoring
|
2021-09-01 14:53:11 +09:00 |
|
Dean Herbert
|
d988aa1680
|
Actually serialise SampleControlPoints along with HitObjects
|
2021-08-31 15:14:03 +09:00 |
|