11752 Commits

Author	SHA1	Message	Date
Dan Balasescu	136cdcfb29	Merge pull request #29059 from frenzibyte/fix-results-fetching-twice ... Fix results screen fetching scores twice when scrolled to edge	2024-08-05 14:23:47 +09:00
Dean Herbert	419d5a76ce	Merge branch 'master' into fix-pause-in-osu-again	2024-08-05 12:00:21 +09:00
jkh675	2098fb8a9d	Fix code quality	2024-08-05 00:08:02 +08:00
jkh675	1b25633e47	Fix headless test	2024-08-04 23:45:42 +08:00
jkh675	2720bcf285	Fix ruleset unit test	2024-08-04 22:37:54 +08:00
jkh675	7cebf4c3d2	Fix code quality	2024-08-04 21:18:03 +08:00
jkh675	38dacfeaa2	Fix unit test	2024-08-04 21:12:09 +08:00
jkh675	273bd73a99	Fix unit test error	2024-08-04 19:50:57 +08:00
jkh675	6f9866d542	Add unit test for OsuTooltip	2024-08-04 18:56:19 +08:00
Dean Herbert	7765d0ff70	Merge pull request #29157 from frenzibyte/user-profile-daily-challenge-streak-display ... Add daily challenge stats display to user profile overlay	2024-08-03 23:57:19 +09:00
Dean Herbert	531cf64ddb	Add failing test showing date added changing when importing as update with no change	2024-08-02 20:46:02 +09:00
Caiyi Shyu	c85dc40f91	Merge branch 'master' into hover-open-mod-customise	2024-08-02 19:07:27 +08:00
Salman Ahmed	dc9f6a07cb	Fix inspections	2024-08-02 11:16:32 +03:00
Salman Ahmed	c3b2d81066	Add failing test case	2024-08-02 10:19:44 +03:00
Dean Herbert	310def64f4	Merge branch 'master' into user-profile-daily-challenge-streak-display	2024-08-02 15:40:46 +09:00
Dean Herbert	816dee181a	Rename classes to remove "streak" terminology ... Since the primary display isn't showing a streak.	2024-08-02 15:33:30 +09:00
Caiyi Shyu	051d52c23f	Update ModCustomisationPanel to use ExpandedState enum	2024-08-01 19:25:45 +08:00
Dean Herbert	e9ed9ff58b	Merge pull request #29188 from bdach/daily-challenge/better-messaging ... Add notification on daily challenge conclusion & start of new one	2024-07-31 13:35:25 +09:00
Dean Herbert	5ebb5ad670	Fix test failure due to TestMetadataClient providing null statistics array	2024-07-31 02:53:10 +09:00
Dean Herbert	d75c170ba1	Merge branch 'master' into daily-challenge/better-messaging	2024-07-30 19:04:48 +09:00
Dean Herbert	71649005bf	Elongate usernames in DrawableChannel test	2024-07-30 17:52:55 +09:00
Dean Herbert	71acb7e9fc	Merge pull request #29137 from normalid-awa/feature/visual/chatline-background-altering ... Alternate background colour of chat lines to better visually distinguish wrapped lines	2024-07-30 17:51:41 +09:00
Bartłomiej Dach	1b57a2a136	Show new daily challenge notification globally	2024-07-30 10:36:26 +02:00
Bartłomiej Dach	a05f810724	Attempt to fix tests more	2024-07-30 10:07:38 +02:00
Bartłomiej Dach	ae38e66036	Add failing test coverage	2024-07-30 08:39:01 +02:00
Salman Ahmed	91dfe4515b	Fix daily challenge display showing incorrect statistic	2024-07-30 08:12:03 +03:00
Salman Ahmed	7c3d592a84	Fix user profile overlay test scene being broke	2024-07-30 07:06:59 +03:00
Bartłomiej Dach	5032a149e7	Merge pull request #29187 from peppy/daily-challenge-pieces-not-always-present ... Favour updating daily challenge statistics when they come on screen	2024-07-29 15:48:26 +02:00
Bartłomiej Dach	b77a10b6db	Fix tests maybe	2024-07-29 15:28:52 +02:00
Dean Herbert	1daeb7ebd0	Rename typo in test naming	2024-07-29 22:19:38 +09:00
Bartłomiej Dach	b46f3c97da	Add notification on daily challenge conclusion & start of new one ... Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day on #general. The notifications are constrained to the daily challenge screen only to not spam users who may not care.	2024-07-29 14:30:10 +02:00
Dean Herbert	7afcd72872	Fix potentially too many scores displaying in breakdown while in gameplay	2024-07-29 20:58:42 +09:00
Dean Herbert	76cd2df699	Add ability to test daily challenge carousel items when hidden	2024-07-29 20:43:47 +09:00
Dean Herbert	997b3eb498	Fix typos and visuals	2024-07-29 20:24:51 +09:00
Shreyas Kadambi	ae61df0abe	Add back accidentally removed test	2024-07-28 11:47:00 -04:00
Shreyas Kadambi	1c9c3c92fd	Add tests for expected timestamp format	2024-07-28 11:30:42 -04:00
normalid	e58bdbb8a9	Improve unit test	2024-07-28 15:08:36 +08:00
Salman Ahmed	82fbd5b045	Rename file	2024-07-28 06:40:16 +03:00
Salman Ahmed	e82c54a31c	Integrate daily challenge streak display with user profile overlay	2024-07-28 05:58:30 +03:00
Salman Ahmed	17f5d58be2	Add daily challenge streak display and tooltip	2024-07-28 05:58:27 +03:00
Joseph Madamba	bc25e5d706	Remove unnecessary depth and padding set	2024-07-27 19:13:11 -07:00
Joseph Madamba	850bcaef7a	Merge remote-tracking branch 'upstream/master' into pr/28991	2024-07-27 19:09:02 -07:00
Joseph Madamba	b4ca07300a	Use same size button for everything	2024-07-27 18:43:54 -07:00
normalid	4e44a6e7f8	Clean up code	2024-07-27 18:55:17 +08:00
normalid	73a98b45e9	FIx code quality	2024-07-27 18:48:45 +08:00
normalid	7f4bfb25a9	Implement unit test	2024-07-27 18:24:32 +08:00
Caiyi Shyu	bd017aea38	fix TestPreexistingSelection failing	2024-07-26 23:58:52 +08:00
Caiyi Shyu	a3576a55c2	add test for hovering ModCustomisationPanel	2024-07-26 22:45:12 +08:00
Dean Herbert	4fa6a19409	Merge pull request #29108 from bdach/daily-challenge/better-breakdown ... Improve score breakdown on daily challenge	2024-07-26 23:12:04 +09:00
Dean Herbert	1607075e0c	Merge pull request #29099 from bdach/daily-challenge/totals-display ... Implement component for displaying running totals in daily challenge	2024-07-26 21:44:58 +09:00
Bartłomiej Dach	fc0ade2c61	Highlight where local user's best is on the breakdown	2024-07-26 14:32:01 +02:00
Bartłomiej Dach	174dc91f4b	Implement component for displaying running totals in daily challenge ... Total pass count and cumulative total score, to be more precise.	2024-07-26 09:51:39 +02:00
Bartłomiej Dach	e489ae8f72	Merge pull request #29055 from peppy/event-feed-improvements ... Improve daily challenge event feed	2024-07-26 08:37:47 +02:00
Bartłomiej Dach	09a1fd2cd1	Merge pull request #29057 from frenzibyte/daily-challenge-replay-download-button ... Fix daily challenge not showing a replay button in results screen	2024-07-26 08:03:17 +02:00
Salman Ahmed	3e8917cadb	Add test case against resetting score in download button	2024-07-26 05:08:13 +03:00
Salman Ahmed	f3dd1facf1	Add failing test case	2024-07-25 09:16:09 +03:00
Salman Ahmed	e1ccf68801	Revert "Add failing test case" ... This reverts commit 0182f3d7c3.	2024-07-25 08:51:48 +03:00
Dean Herbert	f1dda4ab1e	Fix too many event rows displaying after spending a long time in gameplay/results	2024-07-25 14:31:22 +09:00
Dean Herbert	bba151a776	Make event feed test show more realistic content automatically	2024-07-25 14:31:21 +09:00
Salman Ahmed	0182f3d7c3	Add failing test case	2024-07-25 07:39:58 +03:00
Salman Ahmed	b3e3bf7cec	Add lenience to avoid floating point errors	2024-07-24 23:26:23 +03:00
Salman Ahmed	6645dac71d	Fix dragging number boxes overwritten by select-all-on-focus feature	2024-07-24 23:19:04 +03:00
Bartłomiej Dach	12a9086aa3	Fix test failure ... After the legacy key counter was moved to ruleset-specific component containers, `TestSceneSkinnableHUDOverlay` no longer had a key counter, because it wasn't creating a ruleset-specific HUD component container due to 4983e5f33e/osu.Game/Screens/Play/HUDOverlay.cs (L131-L133) Therefore, to fix, do just enough persuading to make it create one.	2024-07-24 18:30:18 +02:00
Dean Herbert	4983e5f33e	Merge pull request #29039 from bdach/multiple-selection-sample-popover ... Make sample popover change properties of all samples in multiple selection	2024-07-24 22:49:20 +09:00
Bartłomiej Dach	087dd759be	Adjust layout to ballpark-match stable ... I dunno what the wiki is claiming with the "24px" figure or why but I'm not playing conversion games either. Dimensions ballparked via screenshots captured at x768 resolution. Also removes a weird homebrew method to keep the text upright. There is one canonical way to do this, namely `UprightAspectMaintainingContainer`. And the other key counters were already using it.	2024-07-24 14:52:56 +02:00
Bartłomiej Dach	ace5071d88	Add better test scene	2024-07-24 14:25:51 +02:00
Bartłomiej Dach	55382a4ba6	Add test coverage for expected sample popover behaviour	2024-07-24 12:08:13 +02:00
normalid	0306ef4096	Update test assets	2024-07-24 14:13:45 +08:00
normalid	95f287104e	Add visual test seane	2024-07-24 12:24:58 +08:00
normalid	661f58a397	Add test coverage	2024-07-24 12:18:05 +08:00
Bartłomiej Dach	c2fa30bf81	Add test coverage for break generation respecting pre-empt time	2024-07-23 13:38:25 +02:00
Bartłomiej Dach	25d63ac6a5	Move editor beatmap processor test cases off of OsuHitObjects ... Most of them are about to become obsolete once consideration for `TimePreempt` is re-added.	2024-07-23 13:28:49 +02:00
Bartłomiej Dach	dd8be62d07	Merge pull request #28849 from frenzibyte/custom-profile-colour ... Add custom hue support to user profile overlay	2024-07-22 09:41:32 +02:00
Bartłomiej Dach	088b8aff11	Merge pull request #28881 from smoogipoo/fix-judgement-cut ... Fix judgement animation getting cut early	2024-07-22 09:24:57 +02:00
Layendan	6a4872faa8	Remove nullable disable	2024-07-21 23:56:47 -07:00
Layendan	e4cccb5e31	Fix lint errors	2024-07-22 12:22:52 +09:00
Layendan	a575566638	Add tests	2024-07-22 12:22:51 +09:00
Salman Ahmed	d7651ef387	Add extensive test cases for correct input handling while paused in osu! & non-osu!	2024-07-19 18:48:35 +03:00
Dean Herbert	d9297438ba	Merge pull request #28900 from smoogipoo/fix-more-tests ... Fix more test failures	2024-07-19 19:38:52 +09:00
Dan Balasescu	7a4758d8cc	Attempt to fix TestSelectableMouseHandling test failure ... https://github.com/ppy/osu/pull/28900/checks?check_run_id=27652166871 This is an attempt. Going frame-by-frame I noticed that there's one frame in which the text is loaded but the FillFlowContainer/GridContainer haven't properly validated so the text is not positioned correctly (it's overflowing the panel to the left). If the cursor is moved at this exact time, then it may not be properly positioned for the following assertion, even though it is _somewhere_ on the panel. If the above is the case, then this is a known o!f issue, but not a simple one to solve. I haven't reproed this locally.	2024-07-19 17:49:16 +09:00
Dan Balasescu	d7ae9505b2	Fix TestCancelNavigationToEditor test failure ... https://github.com/ppy/osu/actions/runs/10002179087/job/27648253709 The editor could be pushed before the exit actually occurs.	2024-07-19 15:04:21 +09:00
Bartłomiej Dach	79cf644b8d	Enable NRT while we're here	2024-07-19 07:34:00 +02:00
Bartłomiej Dach	73edb32440	Add failing test coverage	2024-07-19 07:30:57 +02:00
Dan Balasescu	3f4e56be3c	Fix TestPostAsOwner test failure ... https://github.com/smoogipoo/osu/actions/runs/9990112749/job/27610257309 Comments are loaded asynchronously, both from the initial request and the following message-post request. By sheer timing luck, these could be out of order and the assertion on the posted message could fail.	2024-07-18 20:54:05 +09:00
Dan Balasescu	33a81d8181	Use constraint to improve assertion message	2024-07-18 18:34:08 +09:00
Dan Balasescu	f3cd3d7d3b	Fix TestAllSamplesStopDuringSeek test failure ... https://github.com/smoogipoo/osu/actions/runs/9986761756/job/27599851263 This is a bit of a workaround, likely timing related. I don't foresee an until step in this case to cause false-passes.	2024-07-18 16:26:42 +09:00
Dan Balasescu	1906c2f725	Fix TestTouchScreenDetectionAtSongSelect test failure ... https://github.com/ppy/osu/actions/runs/9985890747/job/27597501295 In this case, the settings overlay is taking a very long time to load (on a background thread), and pops in when it finishes loading because it's been requested to open. The opens the settings overlay, closes it (by pressing escape, this does not actually close it because it's not loaded yet), and then enters song select by pressing 'P' 3 times. The settings overlay finishes loading at just the right opportune moment to eat one of the 'P' key presses.	2024-07-18 16:26:16 +09:00
Salman Ahmed	7a39435017	Fix intermitent test failure in TestSceneArgonHealthDisplay	2024-07-18 01:20:50 +03:00
Bartłomiej Dach	53b6f9e385	Fix test not waiting properly for background processing to complete	2024-07-16 14:04:51 +02:00
Bartłomiej Dach	6db135279f	Restore test coverage of original fail case	2024-07-16 14:04:50 +02:00
Dan Balasescu	ae5b0aa54b	Fix BackgroundDataStoreProcessor test failure	2024-07-16 19:59:13 +09:00
Bartłomiej Dach	76d016df34	Fix code inspection	2024-07-16 11:31:16 +02:00
Dan Balasescu	d4ea604ad0	Add test	2024-07-16 18:19:00 +09:00
Dean Herbert	2c102fc9d0	Fix test failure in TestMetadataTransferred	2024-07-14 01:36:51 +09:00
Salman Ahmed	be1d3c0ea4	Add test coverage	2024-07-13 11:58:54 +03:00
Dean Herbert	eb3f480a2a	Merge pull request #28683 from frenzibyte/footer-v2-integration ... Replace local footer in existing sheared overlays (e.g. mod select & first-run setup) with `ScreenFooter`	2024-07-12 22:45:06 +09:00
Bartłomiej Dach	518dc17518	Merge pull request #28788 from bdach/timeline-redesign ... Redesign editor timelines to address most frequent user complaints	2024-07-12 10:58:59 +02:00
Bartłomiej Dach	452fbed681	Merge pull request #28808 from frenzibyte/fix-all-notifications ... Fix confirm exit dialog potentially showing incorrect number of ongoing operations	2024-07-12 10:56:29 +02:00
Dean Herbert	43addc8400	Fix test regression	2024-07-12 16:29:41 +09:00
Salman Ahmed	3ea0f58daa	Update TestSceneFreeModSelectOverlay to work again	2024-07-11 15:31:23 +03:00
Salman Ahmed	7a5624fd0e	Add screen footer to ScreenTestScene	2024-07-11 15:30:07 +03:00
Bartłomiej Dach	f1fa34e5d5	Merge pull request #28800 from peppy/file-mounting-v3 ... Add ability to edit beatmap content externally	2024-07-11 10:47:36 +02:00
Dean Herbert	c139478aa2	Merge pull request #28805 from frenzibyte/select-all-on-focus ... Select all text when focusing sample bank/volume textboxes in editor (and number boxes in general)	2024-07-11 17:33:30 +09:00
Bartłomiej Dach	a859978efd	Add failing test steps for locally modified state not being set	2024-07-11 09:43:00 +02:00
Dean Herbert	b5bb94e4ec	Merge branch 'master' into file-mounting-v3	2024-07-11 15:54:54 +09:00
Bartłomiej Dach	a9c8c6e74d	Attempt to fix test failures by forcing refresh	2024-07-11 08:18:16 +02:00
Salman Ahmed	8ca8648a09	Add failing test case	2024-07-10 16:14:12 +03:00
Salman Ahmed	7d667ac46b	Fix confirm exit dialog overflowing from too many ongoing operations	2024-07-10 16:06:53 +03:00
Salman Ahmed	94f51c92e0	Select all text when focusing a number box	2024-07-10 15:16:10 +03:00
Dean Herbert	106d558147	Add test coverage of difficulty being retained	2024-07-10 18:34:47 +09:00
Dean Herbert	aa16c72e06	Add test coverage of external editing	2024-07-10 18:34:47 +09:00
Dean Herbert	72091b43df	Simplify editor navigation tests	2024-07-10 18:34:47 +09:00
Salman Ahmed	f0a7a3f856	Add failing test case for edge case	2024-07-10 11:51:49 +03:00
Salman Ahmed	002679ebb0	Ask for VisibilityContainer explicitly	2024-07-10 11:14:22 +03:00
Bartłomiej Dach	95783bd6c2	Merge pull request #28789 from peppy/fix-deletes-reappearing ... Fix deleted beatmap sets potentially reappearing due to pending update requests	2024-07-10 09:14:10 +02:00
Dean Herbert	9a88281ab0	Merge branch 'master' into footer-v2-integration	2024-07-10 15:33:05 +09:00
Dean Herbert	4fe3f39d22	Merge pull request #28682 from frenzibyte/footer-v2-overlay-content ... Add implementation for `ScreenFooter` to house footer content of sheared overlays	2024-07-10 15:08:00 +09:00
Dean Herbert	cd9973b6f9	Merge pull request #28740 from bdach/daily-challenge/better-results ... Improve results displays in daily challenge screen	2024-07-10 14:17:21 +09:00
Dean Herbert	0e2e44a2f5	Add failing test case showing editor save then delete failure	2024-07-09 20:41:22 +09:00
Salman Ahmed	ed1f3a1eb4	Merge branch 'master' into footer-v2-integration	2024-07-09 13:48:40 +03:00
Salman Ahmed	b17af86491	Merge branch 'master' into footer-v2-overlay-content	2024-07-09 13:41:44 +03:00
Dean Herbert	ee9e329db3	Inhibit original callback from firing when sending initial changeset	2024-07-09 16:05:58 +09:00
Dean Herbert	c8b9c117cd	Add failing test showing realm not sending through null ChangeSet	2024-07-09 15:47:43 +09:00
Dean Herbert	c100d1ab65	Merge pull request #28769 from peppy/carousel-realm-simplification ... Simplify realm model tracking in `BeatmapCarousel` (and fix hard delete handling)	2024-07-09 01:40:10 +09:00
Bartłomiej Dach	877b5768fc	Merge branch 'master' into sorted-breaks	2024-07-08 15:59:32 +02:00
Salman Ahmed	da4067d059	Add failing test case	2024-07-08 16:06:34 +03:00
Bartłomiej Dach	2cad8d3684	Merge branch 'master' into time-accurate	2024-07-08 14:19:57 +02:00
OliBomby	2822ba2377	Fix CurrentTimeAccurate being inaccurate if seeking smoothly in the same frame and a transform is already active	2024-07-08 13:30:11 +02:00
Bartłomiej Dach	6433f29651	Add failing test case	2024-07-08 13:21:38 +02:00
Dean Herbert	c0a1696538	Merge pull request #28762 from frenzibyte/change-chevron-display ... Change display of "expanded" chevrons in many UI components to use scale instead of rotation	2024-07-08 20:05:59 +09:00
Dean Herbert	e51d510ea3	Add failing test for beatmap set hard deletion	2024-07-08 20:05:17 +09:00
Salman Ahmed	2fcc61edfa	Merge branch 'master' into audio-ducking-fx	2024-07-08 12:50:46 +03:00
Bartłomiej Dach	14a93bfc1a	Merge pull request #28553 from frenzibyte/mod-select-customisation-panel ... Detach mod customisation area from the footer and replace with an overlay panel display	2024-07-08 11:26:21 +02:00
Salman Ahmed	784a9ae743	Merge branch 'master' into audio-ducking-fx	2024-07-08 12:26:10 +03:00
Joseph Madamba	257de9d08b	Fix arrow direction test	2024-07-08 01:00:36 -07:00
Dean Herbert	3650f3c479	Allow multiple ducks with same parameters	2024-07-08 13:52:40 +09:00
Dean Herbert	aa36a844be	Reduce precision requirement for tests	2024-07-08 13:49:25 +09:00
Dean Herbert	0067450b22	Change volume parameter to double	2024-07-08 13:47:57 +09:00
Salman Ahmed	2bfa03c6d8	Rename test scene file	2024-07-08 07:37:42 +03:00
OliBomby	9013c119ab	update tests	2024-07-05 14:33:15 +02:00
Dean Herbert	5907e0d1eb	Make DuckDuration non-zero by default	2024-07-05 18:39:13 +09:00
Dean Herbert	7efb4ce30a	Fix multiple disposals resulting in assert being hit	2024-07-05 18:39:12 +09:00
Dean Herbert	65418aca1a	Add basic test coverage	2024-07-05 18:35:54 +09:00
Bartłomiej Dach	d6c1b5d399	Add failing test coverage	2024-07-05 08:54:47 +02:00
Bartłomiej Dach	6907d3d3b5	Merge branch 'master' into nodesample-inherit	2024-07-05 08:12:47 +02:00
Bartłomiej Dach	ab8623ec48	Merge pull request #28727 from OliBomby/inherit-addition ... Allow inheriting addition bank from previous hitobject when using auto bank assignment	2024-07-05 08:12:30 +02:00
Dean Herbert	f0ad7a97cb	Merge branch 'master' into daily-challenge/better-results	2024-07-04 23:56:09 +09:00
Dean Herbert	aa72c09c3a	Merge pull request #28659 from bdach/daily-challenge/integration ... Use room watching functionality to receive realtime daily challenge updates	2024-07-04 23:55:46 +09:00
OliBomby	00f7a34139	Add test coverage	2024-07-04 15:25:43 +02:00
Bartłomiej Dach	c524c23db6	Merge branch 'master' into inherit-addition	2024-07-04 15:24:59 +02:00
Bartłomiej Dach	ea9dd841c0	Merge pull request #28728 from OliBomby/inherit-volume ... Always inherit the volume from the previous hit object on placement	2024-07-04 15:24:34 +02:00
Bartłomiej Dach	e005b46df9	Extend test coverage	2024-07-04 15:19:28 +02:00
Bartłomiej Dach	08a77bfe38	Extend test coverage	2024-07-04 15:10:49 +02:00
Bartłomiej Dach	ea4e6cf1d7	Add test coverage	2024-07-04 14:39:11 +02:00
Bartłomiej Dach	5fa586848d	Replace old bad daily challenge leaderboard with new implementation ... - Actually shows scores rather than playlist aggregates (which are useful... in playlists, where there is more than one item) - Actually allows scores to be shown by clicking on them - Doesn't completely break down visually on smaller window sizes The general appearance is not as polished as the old one in details but I wanted something quick that we can get out by next weekend. Also includes the naive method of refetching scores once a new top 50 score is detected. I can add a stagger if required.	2024-07-04 13:52:08 +02:00
Bartłomiej Dach	b29e535ca5	Add results screen for displaying arbitrary daily challenge scores ... At this point its primary usage is the daily challenge event feed, but the leaderboard will be using this too shortly. Because the playlists results screen that exists in `master` is hard-coupled to showing the *local user's* best result on a given playlist by way of hard-coupling itself to the relevant API request, allowing show of *arbitrary* score by ID requires a whole bunch of subclassery as things stand. Oh well. Class naming is... best effort, due to the above.	2024-07-04 13:45:24 +02:00
Salman Ahmed	7a0a5620e1	Add failing test case	2024-07-04 14:06:18 +03:00
Dean Herbert	73d71d3d77	Merge pull request #28705 from bdach/editor-test-play ... Reimplement missing gameplay test hotkeys from stable	2024-07-04 13:44:25 +09:00
Salman Ahmed	899c8d39fe	Merge branch 'master' into verify-title-markers	2024-07-04 07:07:59 +03:00
OliBomby	d0715c5f12	scale along rotated axis	2024-07-03 16:23:19 +02:00
Bartłomiej Dach	e73faaefd2	Merge branch 'master' into editor-test-play	2024-07-03 13:54:47 +02:00
Dean Herbert	5f56ed6872	Merge branch 'master' into navigate-to-timestamp	2024-07-03 20:42:32 +09:00
Bartłomiej Dach	6fda0db9ba	Fix test	2024-07-03 11:03:52 +02:00
Bartłomiej Dach	17ce9cd162	Merge branch 'master' into grids-2	2024-07-03 10:57:05 +02:00
Dean Herbert	824a00b018	Merge pull request #28707 from bdach/remove-breaks ... Add option to remove breaks via timeline context menu	2024-07-03 16:29:25 +09:00
Dan Balasescu	537e3a1642	Merge pull request #28619 from bdach/fix-tail-volume-not-saving ... Fix slider tail volume not saving	2024-07-03 16:13:18 +09:00
Salman Ahmed	f1012070c4	Merge branch 'master' into mod-select-customisation-panel	2024-07-03 07:36:52 +03:00
Salman Ahmed	abfdf90b54	Remove unused using directive	2024-07-03 07:11:35 +03:00
Arthur Araujo	21829e7ef4	Fix test method names	2024-07-02 21:12:15 -03:00
Arthur Araujo	7cb3d7445c	Add verify checks for title markers	2024-07-02 17:20:00 -03:00
Bartłomiej Dach	6453522b34	Add failing test coverage for changing banks/samples not working on node samples	2024-07-02 16:21:56 +02:00
Bartłomiej Dach	3f08605277	Add test coverage	2024-07-02 15:02:09 +02:00
Bartłomiej Dach	3d61a217ec	Add test coverage	2024-07-02 14:34:36 +02:00
Salman Ahmed	1d94c96a8e	Display customisation header in disabled state when no customisable mod selected	2024-07-02 14:40:16 +03:00
Bartłomiej Dach	d4a8f6c8b0	Do not add extra sample control point after end of IHasRepeats objects	2024-07-02 09:13:07 +02:00
Dean Herbert	005af280f2	Isolate bindable breaks list to EditorBeatmap	2024-07-02 11:31:55 +09:00
Salman Ahmed	dce1b4ec6c	Merge branch 'master' into ruleset-specific-combo-counter	2024-07-01 08:31:40 +03:00
Salman Ahmed	0c34e7bebb	Store layout version in SkinLayoutVersion instead and refactor migration code	2024-07-01 08:30:37 +03:00
Salman Ahmed	d1d1f93c43	Merge branch 'mod-select-customisation-panel' into footer-v2-overlay-content	2024-06-30 11:48:23 +03:00
Salman Ahmed	901663b3ff	Fix test failure	2024-06-30 11:00:00 +03:00
Salman Ahmed	e57a0029f1	Remove local footer from ShearedOverlayContainer	2024-06-30 06:50:36 +03:00
Salman Ahmed	5dd822ea38	Migrate first-run setup overlay footer content	2024-06-30 06:50:36 +03:00
Salman Ahmed	48bf3f1385	Migrate mod select overlay footer content	2024-06-30 06:50:36 +03:00
Salman Ahmed	467d7c4f54	Refactor game-wide layout order of footer to fix depth issues with overlays and improve UX ... With this new order, the logo can be easily moved to display in front of the footer in `SongSelectV2` without breaking experience when footer-based overlays are present. Such overlays (i.e. mod select overlay) will also be dimmed alongside the current screen when a game-wide overlay is open (e.g. settings).	2024-06-30 06:50:36 +03:00
Salman Ahmed	900d15e777	Add test coverage	2024-06-30 06:50:22 +03:00
Salman Ahmed	c6c75ae48d	Merge branch 'master' into footer-v2-side-buttons	2024-06-29 08:19:49 +03:00
Bartłomiej Dach	df97215298	Use room watching functionality to receive realtime daily challenge updates	2024-06-28 13:35:16 +02:00
Salman Ahmed	f462aa59df	Add test coverage for the issues that were pointed out recently	2024-06-28 11:23:52 +03:00
Bartłomiej Dach	ace6427d40	Expand test coverage ... - Covers fail case that wasn't covered before - Removes arbitrary wait step that was inevitably going to cause intermittent test failures	2024-06-28 09:30:28 +02:00
Bartłomiej Dach	b36e0f0875	Merge branch 'master' into fix/editor-test-exit	2024-06-28 09:17:40 +02:00
Salman Ahmed	86b8357b8b	Improve UX & input handling when customisation panel is open	2024-06-28 08:53:31 +03:00
Dan Balasescu	3b3f914cd2	Merge branch 'master' into pp_counter_fix	2024-06-28 12:40:56 +09:00
Bartłomiej Dach	e35744118c	Merge pull request #28638 from OliBomby/beat-divisor ... Fix editor not loading arbitrary beat divisors	2024-06-27 13:31:44 +02:00
Bartłomiej Dach	772a68cb3e	Add test coverage for correct beat divisor save	2024-06-27 12:38:29 +02:00
Dean Herbert	f07a635447	Merge pull request #28630 from peppy/fix-long-note-break-woes	2024-06-27 15:50:25 +09:00
Bartłomiej Dach	981340debe	Add safety test coverage for removal of breaks at end of beatmap	2024-06-27 07:45:59 +02:00
Salman Ahmed	e4335a543e	Add failing test case ... Includes a refactor of `ThemeComparisonTestScene` to allow accessing a manual input manager.	2024-06-27 06:41:44 +03:00
Dean Herbert	bbacfc8d23	Add failing test coverage of osu!mania automated break creation scenarios	2024-06-27 12:10:10 +09:00
Bartłomiej Dach	fff27e619d	Fix slider tail volume not saving ... Closes https://github.com/ppy/osu/issues/28587. As outlined in the issue thread, the tail volume wasn't saving because it wasn't actually attached to a hitobject properly, and as such the `LegacyBeatmapEncoder` logic, which is based on hitobjects, did not pick them up on save. To fix that, switch to using `NodeSamples` for objects that are `IHasRepeats`. That has one added complication in that having it work properly requires changes to the decode side too. That is because the intent is to allow the user to change the sample settings for each node (which are specified via `NodeSamples`), as well as "the rest of the object", which generally means ticks or auxiliary samples like `sliderslide` (which are specified by `Samples`). However, up until now, `Samples` always queried the control point which was _active at the end time of the slider_. This obviously can't work anymore when converting `NodeSamples` to legacy control points, because the last node's sample is _also_ at the end time of the slider. To bypass that, add extra sample points after each node (just out of reach of the 5ms leniency), which are supposed to control volume of ticks and/or slides. Upon testing, this *sort of* has the intended effect in stable, with the exception of `sliderslide`, which seems to either respect or _not_ respect the relevant volume spec dependent on... not sure what, and not sure I want to be debugging that. It might be frame alignment, or it might be the phase of the moon.	2024-06-26 15:52:16 +02:00
Bartłomiej Dach	8f0198ba0f	Add test coverage for encode-after-decode stability of slider sample volume specs	2024-06-26 15:42:13 +02:00