h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-12 09:27:51 +08:00
Code Issues Releases Wiki Activity
55,549 Commits 3 Branches 653 Tags 368 MiB
ed9f0555c1
Commit Graph

9082 Commits

Author SHA1 Message Date
Dean Herbert
690e048864 Ensure all initial imports are completed before running playlist overlay tests steps 2022-08-23 17:33:53 +09:00
Dean Herbert
553897f2f0 Remove AddClock method to CreateManagedClock 2022-08-23 13:52:43 +09:00
Khang
a81672f3dc Use an infinite tick distance instead of directly disabling tick generation for SliderEventGenerator 2022-08-22 23:31:24 -04:00
Khang
9f08c474ca Treat NaN slider velocity timing points as 1.0x but without slider ticks 2022-08-22 21:58:38 -04:00
Khang
e8d4bc4497 Allow NaN during beatmap parsing if desired 2022-08-22 21:04:26 -04:00
Dan Balasescu
5d3d8681d4 Invert creation of clocks in multi spectator 2022-08-22 19:14:06 +09:00
Ryuki
b597049524
Code cleanup for CPS tests 
- Remove null-forgiving operator usages
- Fix code quality issues mentionned by NVika
 2022-08-22 10:47:37 +02:00
Dean Herbert
058d67f8e8
Merge pull request #19695 from naoei/ruleset-localization 
Change most ruleset-accessible string types to Localisable strings
 2022-08-22 16:13:23 +09:00
Dan Balasescu
0815b01b75
Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation 
Fix selecting preset containing Difficulty Adjust automatically opening customisation panel
 2022-08-22 15:44:00 +09:00
Dean Herbert
af2e82d7d5 Move operation of setting GameplayClockContainer.StartTime to Reset call 2022-08-22 14:11:06 +09:00
Ryuki
c56390cd7b
Use less custom classes for CPS tests 2022-08-22 00:03:24 +02:00
Nao
189a407cb1
Merge branch 'master' into ruleset-localization 2022-08-20 21:39:10 -04:00
Ryuki
3ac6500423
Add new test resources for CPS counter 2022-08-21 03:00:51 +02:00
Dean Herbert
da407aa827
Merge branch 'master' into kps 2022-08-20 15:24:58 +09:00
Dean Herbert
15d49b0357 Update TestSceneSpectator to user new assert style 2022-08-19 01:46:19 +09:00
Ryuki
3de35a1518
Update calculator and tests to match changes on clocks 2022-08-18 18:40:02 +02:00
Dean Herbert
cc86909633 Increase lenience on TestSceneLeadIn tests 
I've gone through these in detail and can't find an issue with the
actual flow of things. For whatever reason, the new structure has a
slightly higher delay, likely due to performing less `Seek` calls
(previously a `Seek` was called after the clock start which may have
been making this more accurate on the first `Player.Update`).

I don't think it really matters that this is slightly off, but we'll see
how this plays out.
 2022-08-19 01:39:00 +09:00
Dean Herbert
2eba8650ca Update TestSceneLeadIn to use new assert style 2022-08-18 19:26:19 +09:00
Dean Herbert
43879633db Ensure setting a StartTime on a GameplayClockContainer always resets to the new time 2022-08-18 18:54:10 +09:00
Dean Herbert
728cd96508 Update TestSceneLeadIn to use new assert style 2022-08-18 18:54:10 +09:00
Dan Balasescu
fa167b1d12
Merge pull request #19779 from peppy/no-gameplay-clock 
Remove all remaining usage of `GameplayClock`
 2022-08-18 18:52:57 +09:00
Dan Balasescu
7878231a73
Merge pull request #19817 from peppy/various-test-fixes 
Refactor some tests
 2022-08-18 14:39:43 +09:00
Dean Herbert
e7ddbc41c8
Merge branch 'master' into no-gameplay-clock 2022-08-17 22:21:10 +09:00
Dan Balasescu
11301f52b7
Merge pull request #19814 from peppy/update-framework 
Update framework (and other dependencies)
 2022-08-17 19:24:01 +09:00
Dean Herbert
553ae4781f Remove unnecessary local implementation in TestScenePlaybackControl 2022-08-17 19:21:54 +09:00
Dean Herbert
4ef4d66f49 Add some extra initial state checks to TestSceneEditorSeekSnapping 2022-08-17 19:21:46 +09:00
Dan Balasescu
3a0017c87b Fix flaky quick retry test 2022-08-17 17:09:44 +09:00
Dean Herbert
a5ac69a554 Update various dependencies 2022-08-17 16:57:56 +09:00
Dean Herbert
20256aad11 Merge branch 'master' into no-gameplay-clock 2022-08-17 15:21:20 +09:00
Dan Balasescu
24fd411720
Merge pull request #19594 from BlauFx/improve_retry_behaviour 
Skip song intro on quick restart
 2022-08-16 20:18:12 +09:00
Dean Herbert
9a1a7bae89 Make test actually test things 2022-08-16 14:40:02 +09:00
Dean Herbert
6761f869f9 Modify flow to avoid weird bindable and value resetting 2022-08-16 14:17:35 +09:00
Dean Herbert
a15e6f19aa Fix running TestScenePlayerLoader interactively leaving volume in a bad state 2022-08-16 13:40:46 +09:00
Dean Herbert
c9baadcf88 Merge branch 'master' into improve_retry_behaviour 2022-08-16 13:06:04 +09:00
Bartłomiej Dach
a494e55d93
Adjust test scene to reflect new behaviour 2022-08-15 20:43:19 +02:00
Bartłomiej Dach
f0ad31b650
Add failing test case 2022-08-15 20:38:22 +02:00
Bartłomiej Dach
5ff2e41a55
Add preset column to mod select test scene 2022-08-15 18:38:37 +02:00
Dean Herbert
1696a905ba Reduce exposed properties in GameplayClockContainer 2022-08-15 20:22:36 +09:00
Dean Herbert
704568ae3b Remove remaining usage of GameplayClock 2022-08-15 20:22:36 +09:00
Dean Herbert
87760bbc06 Fix IsCatchingUp not being in correct state 2022-08-15 20:17:48 +09:00
Dean Herbert
04d88b8216 Use constraint based assertions in TestSceneFrameStabilityContainer 2022-08-15 19:19:19 +09:00
Dean Herbert
27569e2ed5 Remove FrameStableClock (and redirect usages to FrameStabilityContainer) 2022-08-15 19:19:19 +09:00
Dean Herbert
f81c7644b4 Make GameplayClockContainer also an IGameplayClock and expose to remaining tests 2022-08-15 18:30:53 +09:00
Dean Herbert
c8764cb333 Move all usage of GameplayClock to IGameplayClock 2022-08-15 18:30:53 +09:00
Dean Herbert
6d78218142 Update usages of GameplayClockContainer.GameplayClock to access properties directly 2022-08-15 18:08:49 +09:00
Dean Herbert
58146598c8 Update TestSceneEditorClock to use constraint-based assertions 2022-08-15 18:08:05 +09:00
Nao
c940f5abcb
Merge branch 'master' into ruleset-localization 2022-08-14 15:17:44 -04:00
naoei
784ce4d23d Add test coverage for localisable setting source 2022-08-14 15:06:33 -04:00
Ryuki
2aa3a1b50d
Rename all "KeysPerSecond" usages to "ClicksPerSecond" 2022-08-14 20:12:11 +02:00
Ryuki
9dc806506e
Make ActionListener and KeysPerSecondCalculator not rely on events to add timestamps 2022-08-14 19:31:14 +02:00
Dean Herbert
a90967715c Add test coverage of new imports not correctly being filtered by collection filter 2022-08-12 15:06:34 +09:00
Dean Herbert
5111bad86c Refactor TestScenePlaylistOverlay to use realm for testing 
Removes the dual-purpose flow which existed only for testing.
 2022-08-12 15:06:34 +09:00
Ryuki
3c6461b9e4
Remove KPS acronym usage 2022-08-11 10:01:39 +02:00
Ryuki
0e1efbd865
Rename DrawableCookieziRuleset to MockDrawableRuleset 2022-08-11 01:04:06 +02:00
Ryuki
d58d5eebe2
Add basic tests for KPS 
Created private mock classes to use them in place of `GameplayClock` and
`DrawableRuleset`.
 2022-08-11 00:51:13 +02:00
naoei
3e38baca3c Change ruleset mod description types 2022-08-10 16:09:11 -04:00
Dean Herbert
7c6e5a1085 Add test coverage of case insensitive audio equality 2022-08-10 16:06:56 +09:00
Dean Herbert
d59f4720f1
Merge pull request #19664 from peppy/test-assertions 
Update multiple tests to use new assert output for easier to understand failures
 2022-08-09 23:15:16 +09:00
Dan Balasescu
41af03dec5
Merge pull request #19597 from frenzibyte/hotfix-multi-spectator-results-screen 
Fix multi-spectator potentially getting stuck for passed players (hotfix)
 2022-08-09 21:11:10 +09:00
Dan Balasescu
2de9e5f40f
Fix test failure 2022-08-09 20:23:45 +09:00
Dean Herbert
1270ee9624 Update multiple tests to use new assert output for easier to understand failures 2022-08-09 19:19:54 +09:00
Dean Herbert
aa9ced7f04 Add test coverage of ToolbarUserButton 2022-08-09 15:51:10 +09:00
Ryuki
edb8e5e33e
Temporarily emptying TestSceneKeysPerSecondCounter until a good test can be found 2022-08-09 02:43:41 +02:00
BlauFx
e4879aa450
Add test 2022-08-08 21:12:38 +02:00
Bartłomiej Dach
eba070a0f8
Add weak test coverage of broken audio playback after soft-delete 2022-08-08 20:30:37 +02:00
Dean Herbert
a8dee17513 Fix missing DummyRenderer in skin resources tests 2022-08-08 13:06:01 +09:00
Dean Herbert
e1189da824 Merge branch 'master' into irenderer-glwrapper 2022-08-08 12:31:53 +09:00
Dean Herbert
0537c471dc
Merge pull request #19582 from smoogipoo/apimod-json-cleanup 
Don't serialise empty mod settings
 2022-08-08 11:49:08 +09:00
Salman Ahmed
f75dced305 Fix possible null assignment inspection in TestScenePreviewTrackManager 2022-08-08 02:00:24 +03:00
Bartłomiej Dach
839409d7ac
Add preset column to solo mod select overlay 2022-08-07 16:20:31 +02:00
Bartłomiej Dach
de64b83532
Add test coverage for desired user selection behaviour 2022-08-07 16:20:16 +02:00
Bartłomiej Dach
25daaa56e2
Add test coverage for desired external selection behaviour 2022-08-07 15:30:20 +02:00
Dean Herbert
4a95638756
Merge branch 'master' into mod-overlay/delete-preset 2022-08-07 12:34:25 +09:00
Dean Herbert
5946124278
Merge pull request #19612 from bdach/mod-overlay/common-delete-dialog 
Unify implementations of deletion dialogs
 2022-08-07 12:18:03 +09:00
Bartłomiej Dach
6f6beddab5
Add test coverage for mod preset deletion flow 2022-08-06 21:58:55 +02:00
Bartłomiej Dach
9b3183b2b4
Implement mod preset deletion flow 2022-08-06 21:58:55 +02:00
Bartłomiej Dach
26b9adbe0c
Adjust collection deletion test to match new expectations 2022-08-06 21:07:21 +02:00
Bartłomiej Dach
cc353b872c
Add test coverage for other approval events 2022-08-06 18:21:57 +02:00
Salman Ahmed
789e8b4d8d Fix multi-spectator test updating state after removing user 
Removing user triggers `playingUsers.Remove`, but doing so before
updating the state leads to `EndGameplay` being called with `State ==
Playing` rather than `Quit`.
 2022-08-06 05:41:26 +03:00
Ryuki
0c07df2c26
Remove DT from KPS test 2022-08-05 21:02:37 +02:00
Ryuki
b4e0fa7c53
Rewrite tests for KPS 2022-08-05 15:53:06 +02:00
Dan Balasescu
cf362a6b4f
Merge pull request #19529 from peppy/locally-modified-pill 
Show "locally modified" pill when local modifications have been made
 2022-08-05 21:12:13 +09:00
Dan Balasescu
c4b9b2a14b Merge branch 'master' into irenderer-glwrapper 2022-08-05 20:35:06 +09:00
Dean Herbert
7c952f8069 Add more test coverage of locally-modified state change 2022-08-05 14:25:10 +09:00
Dan Balasescu
0de00e9b3f Don't serialise empty mod settings 2022-08-05 14:00:53 +09:00
Ryuki
42d1bdfc95
Move KPS calculation to a standalone class 2022-08-05 04:17:01 +02:00
Dan Balasescu
c11a24b3ff Remove unused using 2022-08-04 15:05:52 +09:00
Dan Balasescu
6632367c6d Ensure skin samples are looked up in correct order 2022-08-04 14:48:12 +09:00
Bartłomiej Dach
ac9321204c
Merge branch 'master' into mod-overlay/create-preset 2022-08-03 21:21:52 +02:00
Dean Herbert
7022d9e5f8 Fix test step names being too long 2022-08-03 21:13:49 +09:00
Dean Herbert
bacbf5b7f0 Update existing test expectations 2022-08-03 20:20:06 +09:00
Dean Herbert
24d84890e4 Change all filter control button state test to until steps 
There's multiple schedules at play which could be adding multi-frame
delays. let's play it safe and try and fix flaky tests.

Example of `Schedule` which could cause an issue:
392cb352cc/osu.Game/Collections/CollectionDropdown.cs (L77-L78)

Example of test failure:
https://github.com/ppy/osu/runs/7648118894?check_suite_focus=true
 2022-08-03 20:03:07 +09:00
Bartłomiej Dach
add2971eb4
Implement preset creation flow with test coverage 2022-08-02 22:05:54 +02:00
Bartłomiej Dach
1b3074d098
Implement popover for creating mod presets 2022-08-02 22:03:33 +02:00
Dan Balasescu
5a1c05918f Fix test failures 2022-08-02 20:18:45 +09:00
Dan Balasescu
b4e55f7309 Apply IRenderer changes 2022-08-02 19:50:57 +09:00
Dan Balasescu
dc49862466 Merge branch 'irenderer-shaders' into irenderer-textures 2022-08-02 19:25:24 +09:00
Bartłomiej Dach
923d9a4e5f
Add failing assertions to demonstrate autosize failure 2022-08-01 22:04:14 +02:00
Dean Herbert
c0e5f11c90
Merge pull request #19532 from frenzibyte/fix-new-items-sort-stability 
Fix newly imported beatmaps not using correct comparer for sorting
 2022-08-02 02:20:51 +09:00
Dean Herbert
01cc9bd7ef
Merge pull request #19479 from frenzibyte/carousel-update-on-resume 
Fix song select not updating selected beatmap card on editor resume
 2022-08-02 00:48:18 +09:00
Salman Ahmed
682192dbd7 Add failing test case 2022-08-01 18:43:01 +03:00
Salman Ahmed
7c9f8648a5
Merge branch 'master' into remove-nullable-disable-in-the-audio-namespace 2022-08-01 15:25:12 +03:00
Dan Balasescu
d4eec9122f
Merge pull request #19516 from peppy/fix-editor-track-disposal-crash 
Fix editor potentially playing a track post-disposal
 2022-08-01 18:12:21 +09:00
Dan Balasescu
225033c3b2
Merge pull request #19517 from peppy/add-more-missing-realm-refreshres 
Add more missing realm `Refresh()` calls to new beatmap import tests
 2022-08-01 17:54:51 +09:00
Dan Balasescu
1d27c4f020
Merge pull request #19504 from peppy/skin-serialisation-test-coverfage 
Add test coverage of deserialisation of skin layouts
 2022-08-01 17:17:16 +09:00
Dean Herbert
ee68113913 Add more missing realm Refresh() calls to new beatmap import tests 
As noticed at https://github.com/ppy/osu/runs/7605101313?check_suite_focus=true
 2022-08-01 17:06:46 +09:00
Dean Herbert
2519706ad6 Add test coverage of editor crash 2022-08-01 16:53:49 +09:00
Dan Balasescu
47860bb966
Remove unused using 2022-08-01 16:33:59 +09:00
Dean Herbert
3b6349a145 Add test coverage of remaining components which weren't already included 2022-08-01 14:16:26 +09:00
Dean Herbert
d112743cea Improve test coverage of skin serialisation to ensure full coverage 
Will fail when new skinnable components are added until they have
coverage in resources.
 2022-08-01 14:04:12 +09:00
Bartłomiej Dach
5a34122a85
Fix test breakage after realm migration 2022-07-31 23:53:46 +02:00
Bartłomiej Dach
9d3cdae4bb
Fix test scene to handle restarts properly 2022-07-31 23:53:46 +02:00
Bartłomiej Dach
9dea8e3d12
Add test coverage of preset soft deletion 2022-07-31 23:53:46 +02:00
Bartłomiej Dach
c837848238
Add extended test coverage of preset realm subscription 2022-07-31 23:53:45 +02:00
Bartłomiej Dach
345f103119
Migrate mod preset column to use realm 2022-07-31 23:53:45 +02:00
Dean Herbert
f9f9b65c86 Add test coverage of deserialisation skin layouts 2022-08-01 01:14:05 +09:00
Dean Herbert
db4c6aa3d3 Add test skin layout json resources 2022-08-01 01:13:47 +09:00
andy840119
5dd641bc60 Remove the nullable disable annotation in the test project. 2022-07-31 22:02:07 +08:00
Salman Ahmed
b95aff3e5f Add failing test case 2022-07-30 18:50:41 +03:00
Susko3
38a8b9cf0a Add battery info for desktop platforms 2022-07-30 14:26:19 +02:00
Dean Herbert
43e612f6d4
Merge pull request #19455 from peppy/confirm-playlist-discard 
Add confirmation dialog when about to discard a playlist
 2022-07-30 19:17:49 +09:00
Salman Ahmed
8ca8484f0e Fix failing tests 2022-07-30 11:49:33 +03:00
Salman Ahmed
ec1a7994cc Switch method to statement body for better readability 
Almost thought the method was not wrapped in an `AddStep`.
 2022-07-30 10:11:01 +03:00
Salman Ahmed
0c125db197 Fix potential nullref on TestSceneAutoplay check steps 2022-07-30 10:11:01 +03:00
Dan Balasescu
e06f39a69f Apply IRenderer shader changes 2022-07-30 01:29:11 +09:00
Salman Ahmed
3bc1774c87
Merge branch 'master' into pie-chart-progress 2022-07-29 16:54:59 +03:00
Salman Ahmed
3b1a76b190 Remove redundant/overwritten specifications 2022-07-29 16:45:29 +03:00
Salman Ahmed
905bbdc8ee Remove caching of GameplayClockContainer in favour of GameplayClock 
Also fixes `SongProgress` being displayed in skin editor on non-gameplay
screens, due to `GameplayClock` not marked as a required dependency.
 2022-07-29 16:45:29 +03:00
Dan Balasescu
6703b8df02
Merge pull request #19454 from peppy/filter-control-tests-realm-refresh 
Ensure realm is in a good state before asserts in `TestSceneFilterControl`
 2022-07-29 17:57:38 +09:00
Dean Herbert
07e3765b34 Ensure collection is added to dropdown before trying to click it 2022-07-29 17:25:30 +09:00
Dean Herbert
0a2265b0e8 Add test coverage of playlist exit confirmation 2022-07-29 17:11:37 +09:00
Dean Herbert
eb92c35335
Merge pull request #19442 from smoogipoo/fix-beginplaying-misordering 
Move spectator begin/end playing to SubmittingPlayer
 2022-07-29 16:09:50 +09:00
Dean Herbert
e07e761c10 Ensure realm is in a good state before asserts in TestSceneFilterControl 2022-07-29 15:59:53 +09:00
Dan Balasescu
aaa6f963bd Fix potential test failures due to Setup/SetUpSteps ordering 2022-07-29 15:27:39 +09:00
Ryuki
2df24019fd
Merge branch 'master' into kps 2022-07-28 18:38:09 +02:00
Ryuki
079150849a
Add some tests 2022-07-28 18:37:50 +02:00
Ryuki
b2e7da5aa0
Add basic Queue based implementation of KPS 2022-07-28 18:37:12 +02:00
Dean Herbert
45879f7836
Merge pull request #19443 from smoogipoo/fix-intermittent-hud-tests 
Fix intermittent HUD tests
 2022-07-28 23:20:46 +09:00
Dean Herbert
e664690fe2 Remove unnecessary LoadTrack call 2022-07-28 22:19:46 +09:00
Dean Herbert
3005ff1b9f Merge branch 'master' into pie-chart-progress 2022-07-28 22:19:27 +09:00
Dan Balasescu
a59d7f6710
Merge branch 'master' into collections-track-beatmap-updates 2022-07-28 22:05:34 +09:00
Dan Balasescu
aa03df905f
Merge pull request #19441 from peppy/test-working-beatmap-unfuck 
Reduce calls to `LoadTrack` by implicitly running on test/dummy classes
 2022-07-28 22:05:25 +09:00
Dan Balasescu
11e0022fad Merge branch 'master' into realm-collections 2022-07-28 21:00:08 +09:00
Dan Balasescu
ce694123eb Move spectator begin/end playing to SubmittingPlayer 2022-07-28 20:44:04 +09:00
Dean Herbert
7108553883 Tidy up various things everywhere 2022-07-28 18:25:14 +09:00
Dean Herbert
a21aee4e9c Reduce calls to LoadTrack by implicitly running on test/dummy classes 2022-07-28 18:11:40 +09:00
Dan Balasescu
1039338d80 Fix intermittent HUD tests 2022-07-28 17:58:07 +09:00
Dan Balasescu
1da9830145
Merge pull request #19435 from peppy/remove-beatmap-manager-ruleset-store 
Remove unused `RulesetStore` from `BeatmapManager` constructor
 2022-07-28 17:46:12 +09:00
Dan Balasescu
6d4023b933 Adjust comment 2022-07-28 16:56:11 +09:00
Dan Balasescu
cd01c5d3ac Fix assertion 2022-07-28 16:34:31 +09:00
Nitrous
0d36907cad
apply code quality fixes 2022-07-28 15:30:45 +08:00
Nitrous
70ed347b06
simplify helper methods 2022-07-28 15:19:35 +08:00
Dean Herbert
2b9d46d803 Remove unused RulesetStore from BeatmapManager constructor 2022-07-28 16:19:05 +09:00
Nitrous
db62d4be3a
apply suggestions 
- refactor `SongProgress`
- make`UpdateProgress` more readable
- enable NRT on new classes
- refactor `TestSceneSongProgress` to use `GameplayClockContainer`
 2022-07-28 15:15:41 +08:00
Dan Balasescu
6bf293e130 Fix managed object reused between test runs 2022-07-28 15:45:33 +09:00
Dean Herbert
8ac886a247 Update test to account for sort order 2022-07-28 15:20:25 +09:00
Dean Herbert
67c44552cb Add realm Refresh calls to ensure tests are stable 2022-07-28 15:18:04 +09:00
Dean Herbert
485d140a21 Add realm refresh calls to fix intermittent test failures on new update tests 2022-07-28 15:15:41 +09:00
Dean Herbert
2ae5a34c0e Add test coverage of beatmap updates transferring collection hashes 2022-07-28 15:02:58 +09:00
Dean Herbert
ad482b8afc Tidy up naming of collection dropdowns 2022-07-28 13:57:21 +09:00
Dean Herbert
34a2d1a6e1 Fix ManageCollectionsDialog and remove weird placeholder logic 2022-07-28 13:57:21 +09:00
Dean Herbert
67c7f324ee Simplify CollectionFilterDropdown filter flow weirdness 2022-07-28 13:57:21 +09:00
Dean Herbert
0913cf013c Split out tests and fix variable conflict 2022-07-28 13:24:14 +09:00
Dean Herbert
aa65b73f19
Merge branch 'master' into add-notif-externalbutton 2022-07-28 12:17:36 +09:00
Dean Herbert
8da499fb0f Add proper test coverage 2022-07-28 12:16:21 +09:00
Nitrous
9088caa377
move LegacyComboCounter to osu.Game.Skinning 2022-07-28 08:36:26 +08:00
Dean Herbert
438067a18b Convert realm data propagation to more correctly use Live<T> 
wip
 2022-07-27 19:35:09 +09:00
Dean Herbert
41393616d8 Replace BeatmapCollection with RealmBeatmapCollection 2022-07-27 19:35:09 +09:00
Dean Herbert
9c543fef48 Remove CollectionManager 2022-07-27 18:45:33 +09:00
Nitrous
6af6f03e29
refactor song progress test scene 2022-07-27 15:57:47 +08:00
Nitrous
1e013bd4e9
move song progress graph to its own test scene 2022-07-27 15:57:23 +08:00
Dean Herbert
494486ad09 Fix potential test failure if scores are added to the beatmap which is subsequently removed 2022-07-27 16:27:10 +09:00
Nitrous
37e642b0bd
make SongProgress abstract 
- move unrelated logic to `DefaultSongProgress`
- make `LegacySongProgress` inherit `SongProgress`
 2022-07-27 15:19:21 +08:00
Dean Herbert
6b73f7c7ec Split out legacy import path from realm manager 2022-07-27 15:04:09 +09:00
Dan Balasescu
8f7dff5c2c
Merge pull request #19378 from peppy/beatmap-update-test 
Add separate beatmap update flow to handle edge cases better
 2022-07-26 18:49:20 +09:00
Dean Herbert
6ff44ed2c6
Merge pull request #19399 from frenzibyte/carousel-order-stability 
Maintain sort stability by using carousel item ID as a fallback
 2022-07-26 17:33:30 +09:00
Dean Herbert
7f75184a01
Merge branch 'master' into beatmap-update-test 2022-07-26 17:27:36 +09:00
Dean Herbert
ee694c1257 Add test coverage of no online ID scenario 2022-07-26 17:27:23 +09:00
Dean Herbert
1221cb1a42 Add comprehensive test coverage of update scenarios 2022-07-26 17:22:52 +09:00
Dan Balasescu
28e81b7c32
Merge pull request #19392 from peppy/fix-test-leftovers 
Avoid leaving left-over files after test run completes
 2022-07-26 16:33:14 +09:00
Dean Herbert
846291d203 Refactor new tests to not suck as much as the old importer tests 2022-07-26 16:33:00 +09:00
Salman Ahmed
91ffa7007f Improve existing test coverage to cover order changes from other sort modes 2022-07-26 10:24:51 +03:00
Dean Herbert
8370ca9765 Add ImportAsUpdate method to IModelImporter to avoid otehr changes 2022-07-26 15:49:04 +09:00
Dean Herbert
4efe09e7c2
Merge pull request #19377 from frenzibyte/fix-timeline-tests 
Fix intermittent timeline zoom test failures
 2022-07-26 15:18:35 +09:00
Dean Herbert
ac553d22ea Fix left over resource file which isn't actually imported 2022-07-26 15:08:18 +09:00
Dean Herbert
59d3cc52c4 Avoid leaving left-over files after test run completes 2022-07-26 15:08:18 +09:00
Dean Herbert
7d8a78ef01 Move tests to own class 2022-07-26 14:53:20 +09:00
Dean Herbert
ef10145d6f Rename MenuCursorContainer and clean up code 2022-07-26 14:11:52 +09:00
Salman Ahmed
e5355f314d Use longer hash string 2022-07-25 15:19:32 +03:00
Dean Herbert
9c411c2250 Fix test nullability assertions 2022-07-25 20:06:37 +09:00
Dean Herbert
92dd1bcddb Add test coverage of actual update flow 2022-07-25 19:51:19 +09:00
Dean Herbert
2e14d8730c Move implementation of updating a beatmap to BeatmapImporter 2022-07-25 19:51:19 +09:00
Dean Herbert
6a3e8e31de Centralise calls to reset online info of a BeatmapInfo 2022-07-25 19:51:19 +09:00
Dean Herbert
ec477a3ebf Add basic coverage of current behaviour of beatmap reimport 2022-07-25 19:51:19 +09:00
Salman Ahmed
1b6ebcfd87 Remove SubmittableScore and replace with SoloScoreInfo extension method 2022-07-25 13:43:43 +03:00
Salman Ahmed
d04df19c7e Remove APIScore and replace its final usage 2022-07-25 13:13:46 +03:00
Dan Balasescu
068063a43a
Merge pull request #19371 from peppy/fix-working-cache-invalidation 
Fix calls to `GetWorkingBeatmap` invalidating cache too often
 2022-07-25 18:29:46 +09:00
Dan Balasescu
1d48cee230
Merge pull request #19373 from peppy/fix-negative-star-rating-display 
Fix star ratings which are still being calculated showing as "-1" at song select
 2022-07-25 18:20:30 +09:00
Salman Ahmed
bc2b629ee7 Let tests wait until track load before testing zoom 2022-07-25 12:07:50 +03:00
Salman Ahmed
123930306b Refactor ZoomableScrollContainer to allow setting up zoom range and initial zoom after load 2022-07-25 12:07:50 +03:00
Salman Ahmed
93175eaf6e Re-enable timeline zoom test and remove flaky attribute 2022-07-25 11:39:23 +03:00
Dean Herbert
6bf2645b1a Fix StarRatingDisplay not handling negative numbers as "pending" 2022-07-25 15:44:54 +09:00
Salman Ahmed
6bdd1f43a2 Add visual test coverage 2022-07-25 09:40:20 +03:00
Dean Herbert
bbbc0a863f Add test coverage of WorkingBeatmap retrieval from BeatmapManager 2022-07-25 15:30:49 +09:00
Salman Ahmed
7facd6d822
Merge branch 'master' into beatmap-overlay-null-pp 2022-07-25 07:38:59 +03:00
Salman Ahmed
6c95c49da3 Mark test score with null PP for visual testing 2022-07-25 07:31:52 +03:00
Dan Balasescu
0226b358ee Disable timeline test for now 2022-07-25 13:20:33 +09:00
Dean Herbert
12e2e63a1c
Merge pull request #19349 from bdach/mod-overlay/presets-column 
Implement basic appearance of mod preset column
 2022-07-25 13:10:47 +09:00
Salman Ahmed
fa9daa6899 Fix TestSceneReplayRecorder not using score provided by gameplay state 2022-07-25 05:21:27 +03:00
Salman Ahmed
feef16b09b Add potentially failing test case 2022-07-25 04:18:30 +03:00
Bartłomiej Dach
6a67d76d7c
Add basic mod preset column implementation 2022-07-24 16:39:04 +02:00
Salman Ahmed
0c16ef3e2e Add failing test case 2022-07-24 08:34:24 +03:00
solstice23
ea97122425
Separate positive and negative test cases 2022-07-23 21:47:51 +08:00
solstice23
63210d5662
Merge branch 'master' into search-filter 2022-07-23 18:13:53 +08:00
solstice23
3f2c341369
Simplify length parsing 2022-07-23 18:13:19 +08:00
Salman Ahmed
2829a7e836
Merge branch 'master' into beatmap-overlay-modded-stats 2022-07-23 10:38:13 +03:00
Salman Ahmed
c937c0548e Add test coverage 2022-07-23 10:16:11 +03:00
Salman Ahmed
3aecd288e2 Enable NRT on TopLocalRank 2022-07-23 09:27:03 +03:00
Salman Ahmed
727fe76b60 Fix TopLocalRank hacking around presence to hide on null rank 
Fixed this here because that blocks `Schedule` from running, and I don't
want to add another override to the `IsPresent` flag.
 2022-07-23 09:22:22 +03:00
Salman Ahmed
1220250bb6 Improve test scene and add failing test case 2022-07-23 08:03:48 +03:00
Bartłomiej Dach
d0e15d04cc
Merge branch 'master' into mod-overlay/preset-panel 2022-07-22 19:23:09 +02:00
Dan Balasescu
d9105c9785
Merge pull request #19272 from peppy/beatmap-background-reprocessing 
Add background beatmap processing
 2022-07-22 20:33:26 +09:00
Dean Herbert
63fe4f265f
Merge pull request #19263 from frenzibyte/fix-failed-score-statistics 
Populate failed scores with "miss" results for all remaining hitobjects
 2022-07-22 20:16:16 +09:00
Dan Balasescu
6b69ff19c8
Remove unused using 2022-07-22 17:24:46 +09:00
Salman Ahmed
e5ab6652fd Fix one more case of referencing old mod select overlay in tests 2022-07-22 11:12:24 +03:00
Dean Herbert
e20458421a Update flaky timeline zoom test to output something useful 2022-07-22 16:05:20 +09:00
solstice23
7c222505e9
Simplify length parsing 2022-07-22 14:24:17 +08:00
solstice23
80e82763e3
Add negative test cases 2022-07-22 12:09:47 +08:00
Bartłomiej Dach
bdff7f1ef4
Implement basic appearance of mod preset panels 2022-07-21 23:29:21 +02:00
solstice23
de25830b2b
Add more test cases 2022-07-22 03:27:08 +08:00
solstice23
0dcb3644f5
Merge branch 'master' into search-filter 2022-07-22 01:32:25 +08:00
solstice23
52fad1e14d
Add test cases for search length criteria 2022-07-21 18:59:48 +08:00
Dean Herbert
1374738a0d Add test coverage 2022-07-21 18:20:46 +09:00
Salman Ahmed
559254db31
Merge branch 'master' into fix-update-button-test-failure 2022-07-21 11:15:43 +03:00
Dan Balasescu
defadeef47
Merge pull request #19250 from peppy/fps-counter 
Add game-side FPS counter
 2022-07-21 16:26:38 +09:00
Dean Herbert
fc0c9f76bd Fix UpdateBeatmapSetButton intermittent test failure 
Carousel would only expire items when off-screen. This meant that for a
case (like a test) where items are generally always on-screen,
`UpdateBeatmapSet` calls would result in panels remaining hidden but not
cleaned up.
 2022-07-21 16:24:48 +09:00
Salman Ahmed
9df49db45f Include bonus/ignore judgements in statistics fill logic 2022-07-21 08:13:09 +03:00
Salman Ahmed
5513a8b6b4 Fix changelog overlay tests failing due to missing CreatedAt date 2022-07-21 07:21:27 +03:00
Salman Ahmed
3c2a885872 Add test coverage 2022-07-21 06:01:48 +03:00
Dean Herbert
0c3d43026d Add initial structure for fps counter 2022-07-20 23:49:19 +09:00
Dean Herbert
62133fa069
Merge pull request #19246 from frenzibyte/fix-wiki-navigation 
Fix wiki overlay not handling path redirection properly
 2022-07-20 20:08:11 +09:00
Dan Balasescu
d2a3c2594d Fix inspections 2022-07-20 16:33:52 +09:00
Dan Balasescu
f9c02c34b6 Merge branch 'master' into beatmap-update-online-flow 2022-07-20 15:15:51 +09:00
Salman Ahmed
e7f35701db Add failing test case 2022-07-20 09:06:11 +03:00
Dean Herbert
af4d7feb9b
Merge pull request #19244 from frenzibyte/highlight-perfect-ticks 
Highlight perfect slider tick/end values in beatmap info leaderboards
 2022-07-20 14:44:03 +09:00
Dan Balasescu
6c0d7f8099
Merge pull request #19235 from andy840119/remove-nullable-disable-in-the-mods 
Remove nullable disable annotation in the mods.
 2022-07-20 14:39:32 +09:00
Dan Balasescu
ebb9861377
Merge branch 'master' into remove-nullable-disable-in-the-mods 2022-07-20 13:28:28 +09:00
Salman Ahmed
ae6aab2555
Merge branch 'master' into edit-map-carousel 2022-07-20 02:43:47 +03:00
Salman Ahmed
4d1f9a1329 Adjust test scene to cover slider ticks 2022-07-20 00:53:10 +03:00
為什麼
2a83404dbe Use array.empty instead of null value. 2022-07-19 20:39:41 +08:00