Dean Herbert
f703c5f038
Add comment and reduce how often ChildrenOfType is invoked in ExpandingButtonContainer
2022-01-06 23:38:54 +09:00
Dean Herbert
5aca2dd4ce
Hide header text when it won't fit in the toolbox group
2022-01-06 23:08:50 +09:00
Dean Herbert
690b425380
Move enum local to usage
2022-01-06 22:56:56 +09:00
Dean Herbert
00177a3ae1
Update usages to new naming
2022-01-06 22:54:43 +09:00
Dean Herbert
3ea7588a91
Update continuation usages to use GetCompletedResult
2022-01-06 22:53:07 +09:00
Dean Herbert
cea9cab4dc
Use ExpandingButtonContainer in editor composer
2022-01-06 21:10:45 +09:00
Dean Herbert
5baaf356aa
Split out SettingsToolboxGroup from PlayerSettingsGroup
2022-01-06 21:05:00 +09:00
Dean Herbert
77980196c5
Split out expanding container logic from settings sidebar
2022-01-06 21:02:29 +09:00
Dean Herbert
39650ce7e9
Merge pull request #16307 from peppy/beatmap-listing-bottom-padding
...
Add padding to the bottom of the beatmap listing overlay to avoid hovered panels exceeding visible bounds
2022-01-04 14:14:42 +09:00
Dean Herbert
73b40e6833
Replace usage of .Result with .WaitSafelyForResult
2022-01-04 11:51:41 +09:00
Bartłomiej Dach
de33b420ab
Add safety against performing operation on non-alive foundContent
2022-01-03 20:02:46 +01:00
Bartłomiej Dach
586f158920
Remove initial foundContent value
...
It always is replaced on the first search anyway, and just remains
forever in the overlay otherwise.
2022-01-03 19:52:42 +01:00
Bartłomiej Dach
6650a468e0
Fix and simplify very broken beatmap listing content swap-out logic
...
The beatmap listing content swap-out logic was already a source of
several problems, and several attempts of fixing it were made. But as it
turns out it was terminally broken in several aspects.
* The `BypassAutoSizeAxes` juggling was finicky and ugly, and didn't
really look much different than an instant fade. Therefore, all fade
durations and manipulations of `BypassAutoSizeAxes` are removed.
* The transform sequence juggling the `BypassAutoSizeAxes` manipulations
was enqueued on the content which is being in the process of fading
out. That was partially fixed in 25e38560
2022-01-03 19:51:46 +01:00
Bartłomiej Dach
ef9f56e585
Fix bad check if content is placeholder
...
The `lastContent == foundContent` check, last touched in a49a4329a49a4329
2022-01-03 19:51:20 +01:00
Bartłomiej Dach
97439c3df1
Rename method to reflect what it actually does
2022-01-03 19:30:17 +01:00
Bartłomiej Dach
7c246670b4
Add padding to bottom of spotlights ranking view to avoid hovered panels exceeding visible bounds
2022-01-03 18:43:20 +01:00
Dean Herbert
b9851b278d
Add padding to the bottom of the beatmap listing overlay to avoid hovered panels exceeding visible bounds
...
Closes https://github.com/ppy/osu/issues/16120 .
2022-01-03 13:18:28 +09:00
Dean Herbert
6356180b6a
Remove unnecessary code and fix double nesting causing filtering to not work
2022-01-03 12:53:58 +09:00
Dean Herbert
bb54f438aa
Merge branch 'master' into positional-sounds-strength-adjustment
2022-01-03 12:40:56 +09:00
Joseph Madamba
7de43e3aba
Fix most open compound words in identifiers being closed
2021-12-27 20:26:28 -08:00
Joseph Madamba
98524d60a4
Fix clear identifier typos
2021-12-27 20:26:28 -08:00
Dan Balasescu
d36fe3af09
Merge pull request #16238 from peppy/fix-incorrect-delegate-capture
...
Fix incorrect delegate capture leading to slow leak of audio tracks
2021-12-24 21:34:04 +09:00
Dean Herbert
2ee3e61983
Merge branch 'master' into beatmap-card/extra-on-listing
2021-12-24 19:02:51 +09:00
Dean Herbert
cc7089c3f4
Cancel more liberally
2021-12-24 19:00:09 +09:00
Dean Herbert
d602aebebb
Add missing cancellation token and rename load task variable to match purpose
2021-12-24 18:58:31 +09:00
Dean Herbert
842d508aee
Fix incorrect delgate capture leading to slow leak of audio tracks
...
During profile, it was found that the `Completed` delegate was
incorrectly also capturing `lastTrack`, leading to an unexpected
reference chain that led to a memory leak over a long period of time.
This solves the issue by moving the delegate construction to its own
method, where it won't capture the other variables.
2021-12-24 18:39:29 +09:00
Bartłomiej Dach
5cbaa028eb
Use extracted ruleset config cache implementation in DI
2021-12-23 19:02:10 +01:00
Bartłomiej Dach
a49a4329ee
Add capability to switch between card sizes
2021-12-23 15:55:37 +01:00
Bartłomiej Dach
d0427ec85f
Add support card size tab control to beatmap listing
2021-12-23 15:55:37 +01:00
Bartłomiej Dach
1876617d8e
Implement beatmap card size tab control
2021-12-23 15:55:36 +01:00
Bartłomiej Dach
25e38560ce
Fix placeholder drawables on beatmap listing not always hiding correctly
...
`BeatmapListingOverlay.addContentToPlaceholder()`, in order to make
transitions between different beatmap listing content (whether it is
actual cards, or placeholders for no beatmaps found/supporter-specific
filters chosen), would set `BypassAutoSizeAxes = Y` on content as it is
fading out, to make the transition smoother. The property in question
was supposed to be getting restored to `None` on the next show.
In testing scenarios, it sometimes turned out that this wasn't the case,
therefore making the placeholders effectively not show - while they
were present and fully opaque, they would be the only child of
an auto-sized container with `BypassAutoSizeAxes = Y`, so the parent
auto-sized to a zero height, which logically follows from the premise,
but is not what was desired.
This in turn was caused by the fact that the `BypassAutoSizeAxes = Y`
set was scheduled, and sometimes it would be scheduled in such a way
that the drawable would cease to be present on the next frame due to its
alpha being past the cutoff point of 0.0001. Therefore the scheduled set
would not execute until the *next* time the placeholder was shown,
therefore causing the bug.
Fix by ensuring that the placeholder drawables are always present if
their schedulers have any tasks enqueued, on top of the usual checks of
alpha and scale performed via the base implementation.
2021-12-22 15:05:23 +01:00
Bartłomiej Dach
88d4e95ad8
Rename BeatmapCard{ => Normal}
2021-12-21 08:26:21 +01:00
Bartłomiej Dach
a6ccbafc77
Fix rank graph showing for unranked users
2021-12-19 13:40:22 +01:00
mk-56
fd5af1fbe7
Code refactor and name changes
...
cleaned code up with Jetbrains i hope it suffices
2021-12-17 13:16:06 +01:00
Bartłomiej Dach
54790bb758
Merge branch 'master' into fix-realm-post-storage-migration-failure
2021-12-17 00:19:46 +01:00
Dean Herbert
aa0813ff05
Merge pull request #16109 from smoogipoo/chat-overlay-multiplayer-removal
...
Don't show multiplayer channels in chat overlay
2021-12-16 17:39:45 +09:00
Dan Balasescu
3f1d747b7a
Merge pull request #16090 from peppy/fix-scroll-speed-toast-sample-spam
...
Fix toast popups spamming samples when adjusting osu!mania scroll speed during gameplay
2021-12-16 17:31:36 +09:00
Dan Balasescu
488374b4a2
Don't show multiplayer channels in chat overlay
2021-12-16 16:41:47 +09:00
Susko3
643cee4f83
Merge branch 'master' into number-textbox-only-numbers
2021-12-15 09:13:19 +01:00
Susko3
b326ccc196
Move logic to framework and update all usages
2021-12-15 07:13:24 +01:00
Dean Herbert
0c11fe7413
Fix toast popups spamming samples when adjusting osu!mania scroll speed during gameplay
...
Not the most robust of fixes, but as per the reasoning described in the
issue thread, a proper fix will take considerably more effort. This
intends to fix the issue first and foremost, as it sounds so bad I'd
want to mute my sound before adjusting currently.
Closes #15718 .
2021-12-15 12:45:23 +09:00
Dean Herbert
441b7baa93
Provide a realm factory to usages of ToLive/RealmLive
2021-12-14 14:26:34 +09:00
Dean Herbert
bff02bedbf
Rename APIScoreInfo to APIScore
2021-12-10 16:11:49 +09:00
Dean Herbert
bf1418bafc
Use OnlineID instead of legacy IDs for equality and lookups
2021-12-10 16:11:48 +09:00
Susko3
0b0ff36154
Allow only number characters parseable by int.TryParse
...
char.IsNumber() is too broad, allowing full width and other numbers.
2021-12-07 20:06:22 +01:00
Dean Herbert
d6e68feadc
Merge pull request #15948 from bdach/beatmap-card/difficulty-dropdown
...
Add difficulty dropdown to beatmap card
2021-12-07 23:40:06 +09:00
Bartłomiej Dach
999bba439f
Clarify usages of reverse child ID flow with inline comments
2021-12-06 21:02:40 +01:00
Dean Herbert
452fa93444
Merge branch 'master' into realm-integration/skins-rebase
2021-12-06 15:21:02 +09:00
Bartłomiej Dach
af10223ac4
Add reverse fill flows & depth specs at usage sites for correct Z-ordering
2021-12-05 20:07:46 +01:00
Bartłomiej Dach
38702beabf
Merge branch 'master' into i-ruleset-store
2021-12-04 15:05:39 +01:00
Dan Balasescu
4145a16d5b
Merge pull request #15920 from peppy/clean-up-unused-resolves
...
Clean up unused resolved properties
2021-12-03 20:08:48 +09:00
Dean Herbert
1eed2436e6
Clean up unused resolved properties
2021-12-03 18:49:49 +09:00
Dean Herbert
2acf46154a
Remove many unused resolutions of RulesetStore
2021-12-03 18:16:29 +09:00
Dean Herbert
e75e209053
Cache and consume IRulesetStore where feasible
2021-12-03 18:16:01 +09:00
Dean Herbert
aaa46960b3
Reword mouse wheel disable setting to better explain its purpose
2021-12-03 17:18:07 +09:00
Dean Herbert
e855a49833
Add test coverage of default skin edit and export
2021-12-02 14:01:18 +09:00
Dean Herbert
0a14acfd83
Fix incorrect conditional on export/mutate feasability of skin
2021-12-02 13:41:58 +09:00
Dean Herbert
65f0a80c97
Merge branch 'master' into realm-integration/skins-rebase
2021-12-02 13:37:20 +09:00
Dean Herbert
c82195390f
Update usage of SubscribeForNotifications
2021-12-02 13:24:16 +09:00
Dean Herbert
8ce7467e97
Fix ordering of skins in dropdown being reverse of expected
2021-12-01 12:50:47 +09:00
Dean Herbert
03e1305b3f
Fix toast display potentially causing a child mutation before load complete
2021-12-01 01:55:17 +09:00
Dean Herbert
6877867467
Make default fallback logic more robust
2021-11-29 18:28:25 +09:00
Dean Herbert
0d18c83d75
Simplify deletion by adding always present conditionals to Delete method
2021-11-29 18:28:25 +09:00
Dean Herbert
f6a3709060
Store default skins to database
2021-11-29 18:28:25 +09:00
Dean Herbert
c629a7a36f
Fix random selection and avoid using legacy events for handling skin import/deletion
2021-11-29 18:28:25 +09:00
Dean Herbert
744a5b33f5
Rewrite SkinSection to use realm subscriptions and databased defaults
2021-11-29 18:28:25 +09:00
Dean Herbert
3db5646fa8
Create Guid constants for system skins (and store skin choice to configuration as guid)
2021-11-29 18:28:25 +09:00
mk-56
c3fb793762
Fixed the problems that were brought up and deleted the old bind logic
2021-11-28 14:06:53 +01:00
mk-56
ff9c68dd6a
cleanup
2021-11-28 03:28:35 +01:00
MK56
753c1c7fea
Merge branch 'ppy:master' into positional-sounds-strength-adjustment
2021-11-28 02:59:36 +01:00
mk-56
eaa464e548
Initial implementation of adjustable positional hitobject audio strength
2021-11-28 02:58:08 +01:00
Dean Herbert
51a7c60eec
Merge pull request #15835 from bdach/off-thread-transforms-unbind
...
Fix instances of components adding off-thread transforms on unbind
2021-11-28 09:27:43 +09:00
Bartłomiej Dach
db49d99cc0
Ensure correct disabled ruleset callback scheduling in ruleset selector
2021-11-27 15:28:23 +01:00
Bartłomiej Dach
05f7ea6b6d
Remove mentions of "panel" and "direct" from names of old download buttons
2021-11-27 15:08:03 +01:00
Bartłomiej Dach
a043d1e427
Move old beatmap download button to more general namespace
2021-11-27 15:06:57 +01:00
Bartłomiej Dach
251ab183a0
Move beatmap play button nearer its only remaining usage
2021-11-27 15:04:05 +01:00
Bartłomiej Dach
7419682334
Move icon pill to beatmap card-specific namespace
2021-11-27 15:01:48 +01:00
Bartłomiej Dach
6773877a40
Remove no-longer-used beatmap panels
2021-11-27 15:00:06 +01:00
Bartłomiej Dach
f4b7db5a7b
Ensure correct disabled beatmap callback scheduling in now playing overlay
2021-11-27 14:36:34 +01:00
Dean Herbert
89b4e5cffb
Rename mass deletion confirmation dialog
2021-11-26 18:18:45 +09:00
Bartłomiej Dach
ec2265d5bb
Use beatmap cards in spotlights layout
2021-11-25 22:30:47 +01:00
Bartłomiej Dach
42b09fd1ec
Use beatmap cards in user profile overlay
2021-11-25 22:30:47 +01:00
Bartłomiej Dach
0f9ebe3d5d
Use beatmap cards in beatmap listing overlay
2021-11-25 22:30:46 +01:00
Dan Balasescu
f712aeee01
Merge pull request #15795 from peppy/realm-integration/separate-download-flow
...
Split out download logic from main manager classes
2021-11-25 20:59:23 +09:00
Dan Balasescu
d3a4890c31
Merge branch 'master' into realm-integration/stable-export-flow
2021-11-25 19:06:18 +09:00
Dean Herbert
e2ebcf7a26
Remove unnecessary manager parameter
...
Confused why I added this in the first place..
2021-11-25 18:36:03 +09:00
Dean Herbert
716543b5b3
Move beatmap download logic out of BeatmapManager
2021-11-25 17:29:41 +09:00
Dean Herbert
79459c1aeb
Fix typo in class and variable names
2021-11-25 17:12:15 +09:00
Dean Herbert
cc1b91e4bd
Split out legacy model export logic into LegacyModelExporter classes
2021-11-25 16:41:12 +09:00
Dean Herbert
9dcb20a821
Rename Stable to Legacy and add xmldoc
2021-11-25 15:39:05 +09:00
Dean Herbert
183b95cbc2
Rename BeatmapSetOnlineStatus to BeatmapOnlineStatus
...
This variable is used at more than just a set level.
2021-11-24 18:42:49 +09:00
Dan Balasescu
8ce5324c8b
Merge pull request #15772 from peppy/remove-model-list-inits
...
Initialise `BeatmapSet.Beatmaps` list at construction time
2021-11-24 16:41:19 +09:00
Dean Herbert
a7853fc9cc
Fix cases of known-non-null
2021-11-24 14:26:25 +09:00
Dan Balasescu
84268c3d85
Merge branch 'master' into realm-ruleset-keybinding-short-name
2021-11-24 13:48:48 +09:00
Dan Balasescu
6183d1cd46
Merge pull request #15769 from peppy/model-equality-consistency
...
Update cases where equality can be used instead of primary key equality
2021-11-24 13:45:57 +09:00
Dean Herbert
729f681938
Update cases where equality can be used instead of primary key equality
2021-11-24 12:49:57 +09:00
Dean Herbert
0eea026afb
Remove null checks on CreateInstance() calls
2021-11-24 12:23:09 +09:00
Bartłomiej Dach
0d409fa33e
Merge branch 'master' into realm-ruleset-keybinding-short-name
2021-11-23 20:18:58 +01:00
Dan Balasescu
fd4d5e98a7
Merge pull request #15745 from bdach/settings-number-box-stack-overflow
...
Fix crashes on trying to play back replays of seeded mods with seed value over 1 billion
2021-11-23 16:36:05 +09:00
Dean Herbert
0989d6a92e
Merge branch 'realm-ruleset-setting-short-name' into realm-ruleset-keybinding-short-name
2021-11-23 14:55:40 +09:00
Dean Herbert
feb983d5bd
Rename Debug namespace to avoid collisions
2021-11-23 13:09:41 +09:00
Bartłomiej Dach
4a9f080f3c
Accept full range of int in SettingsNumberBox
...
This fixes stack overflow exceptions that would arise when a
`Current.Value` of 1 billion or more was set on a `SettingsNumberBox`.
The stack overflow was caused by the "maximum 9 digits" spec. If a value
technically within `int` bounds, but larger than 1 billion (in the range
[1,000,000,000; 2,147,483,647], to be more precise), a feedback loop
between the setting control's `Current` and its inner text box's
`Current` would occur, wherein the last digit would be trimmed and then
re-appended again forevermore.
To resolve, remove the offending spec and rely on `int.TryParse`
entirely to be able to discern overflow range. Additionally, UX of the
text box is slightly changed to notify when the `int` range is exceeded
with a red flash.
This behaviour would not have been possible to implement without recent
framework-side fixes to text box (removal of text set scheduling).
2021-11-22 20:49:14 +01:00
Dean Herbert
d94b27a8a2
Switch realm ruleset key bindings to use ruleset's ShortName as key
2021-11-22 18:52:30 +09:00
Dan Balasescu
698b6c4242
Merge pull request #15668 from peppy/key-repeat
...
Update `KeyBindingContainer` usage to block key repeat where applicable
2021-11-18 15:21:35 +09:00
Dean Herbert
db4e4c982c
Add hover effect to supporter button
2021-11-18 13:35:42 +09:00
Dean Herbert
66c307e0ee
Remove usage of key repeat helper method
2021-11-18 13:13:36 +09:00
Dean Herbert
3de8125eac
Update UI cases where repeat should not be handled
2021-11-18 13:13:36 +09:00
Joseph Madamba
cd5e379c48
Link osu!supporter icon to its web page
2021-11-17 14:43:34 -08:00
Dean Herbert
726a0cc091
Merge branch 'master' into beatmap-collection-inteface-types
2021-11-16 15:31:10 +09:00
Dean Herbert
68e2699043
Fix oversight in playlist matching logic
2021-11-16 12:35:18 +09:00
Dean Herbert
285b161da7
Update other usages of online ID comparisons to use new extension method
2021-11-15 14:44:08 +09:00
Dean Herbert
a4c11e8813
Use extension method to compare online IDs
2021-11-15 14:34:50 +09:00
Bartłomiej Dach
58bad0ab25
Merge branch 'master' into fix-setting-header-text-overflow
2021-11-12 20:34:07 +01:00
Bartłomiej Dach
cb2d1f3f04
Use horizontally symmetrical padding rather than margin
2021-11-12 20:28:42 +01:00
Dean Herbert
6a098a8634
Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface
2021-11-12 17:46:24 +09:00
Bartłomiej Dach
a1b55d6490
Add failing test case
2021-11-09 13:34:36 +01:00
Lucas A
b7e7b0f850
Trim whitespace.
2021-11-08 21:42:51 +01:00
Lucas A
e6f39c4cad
Fix settings header text overflowing with some locales.
2021-11-08 21:38:01 +01:00
Susko3
8a23b648fe
Move HoverClickSounds to the clickable button
2021-11-08 14:32:00 +01:00
Dean Herbert
49c26a465c
Debounce and schedule updates to key combinations
2021-11-08 18:29:11 +09:00
Dean Herbert
b4225804ed
Add missing null check
2021-11-08 18:26:12 +09:00
Dean Herbert
f5842e7587
Shorten variable names
2021-11-08 18:24:37 +09:00
Dean Herbert
82f24b0502
Revert "Change font to default"
...
This reverts commit cc286f165d
2021-11-08 18:16:06 +09:00
Dean Herbert
3183b20e2f
Merge branch 'master' into use-ReadableKeyCombinationProvider
2021-11-08 18:15:49 +09:00
Dean Herbert
8b85c2c8de
Merge pull request #15491 from peppy/remove-stupid-weak-reference-bindable-events
...
Revert weird event flow in model manager/importers
2021-11-08 15:19:58 +09:00
Susko3
cc286f165d
Change font to default
...
Non-english letters look tiny with size 10
and don't fit into the look.
2021-11-08 06:56:57 +01:00
Susko3
c3069ad002
Change to use ReadableKeyCombinationProvider
...
Changes all usages of `KeyCombination.ReadableString()` to
`ReadableKeyCombinationProvider.GetReadableString()`.
Subscribing to `KeymapChanged` is only required in `KeyButton`.
All other places query `GetReadableString()` every time.
2021-11-08 06:55:26 +01:00
Dan Balasescu
1c40d5bc08
Merge branch 'master' into remove-stupid-weak-reference-bindable-events
2021-11-08 14:41:32 +09:00
Dean Herbert
6b6dd93e9e
Fix LinkFlowContainer not creating user links supporting full IUser specification
2021-11-08 14:17:47 +09:00
Dean Herbert
dede0e56ce
Merge branch 'master' into user-lookup-by-username-cleanup
2021-11-08 13:38:26 +09:00
Dean Herbert
78aef9ce86
Merge branch 'master' into remove-stupid-weak-reference-bindable-events
2021-11-08 13:35:49 +09:00
Bartłomiej Dach
6d30248cef
Merge branch 'master' into use-class-rename
2021-11-07 15:41:00 +01:00
Dean Herbert
0ecf5f201c
Rename User to APIUser and move to correct namespace
2021-11-07 11:26:01 +09:00
Bartłomiej Dach
6a1c27d67a
Merge branch 'master' into fix-more-null
2021-11-06 15:36:15 +01:00
Bartłomiej Dach
c40f887492
Remove unnecessary local variable
2021-11-06 15:20:29 +01:00
Salman Ahmed
34c8e53e94
Merge branch 'master' into update-cached-buffered-container-usage
2021-11-06 09:38:55 +03:00
Dean Herbert
bc17446055
Merge branch 'master' into user-lookup-by-username-cleanup
2021-11-06 14:38:30 +09:00
Salman Ahmed
51e7b9950e
Define local current bindable to bind value change instead
2021-11-05 18:07:14 +03:00
Dean Herbert
54f72d68ca
Revert weird event flow in model manager/importers
2021-11-05 19:12:49 +09:00
Salman Ahmed
f013a1e37f
Move CreateContent() to BDL
2021-11-05 10:13:42 +03:00
Dean Herbert
6399c695e8
Update usages of BufferedContainer in line with framework changes
2021-11-05 15:54:49 +09:00
Salman Ahmed
3a3ec1436b
Re-enable possible null refernece exception inspections and move code
2021-11-05 09:14:50 +03:00
Dean Herbert
9f9ef570ee
Also propagate Status in temporary BeatmapInfo usage
2021-11-05 14:44:58 +09:00
Dean Herbert
b1f1cc0bf3
Perform all user profile displays using an IUser interface
2021-11-05 13:55:34 +09:00
Dean Herbert
ba74dd93b2
Remove weird fetchOnline logic
2021-11-05 13:55:34 +09:00
Salman Ahmed
f528488aa2
Mark as non-null and move current bind to BDL instead
2021-11-05 05:42:19 +03:00
Salman Ahmed
4245af28e1
Disable other false-positive null inspections with comment
2021-11-05 04:50:58 +03:00
Salman Ahmed
36d99a2e34
Move action to private named method to avoid null inspection
2021-11-05 03:51:08 +03:00
Dean Herbert
b9983add15
Rename User to APIUser and move to correct namespace
2021-11-04 18:21:31 +09:00
Dean Herbert
08d94f864f
Update ScoresContainer to not use ToBeatmapInfo
2021-11-04 17:09:53 +09:00
Dean Herbert
5a078da4d9
Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues
2021-11-04 16:50:14 +09:00
Dean Herbert
8f459e6ce8
Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues
2021-11-04 16:44:17 +09:00
Bartłomiej Dach
494d582830
Fix PlaylistItem attempting to read from OsuColour dependency too early
2021-11-02 23:19:45 +01:00
Bartłomiej Dach
e4e8390a8a
Update ScreenEntry colour usage to update correctly on language change
2021-11-02 21:42:03 +01:00
Bartłomiej Dach
d218e7d935
Remove manual romanisation handling in PlaylistItem
2021-11-02 21:42:02 +01:00
Bartłomiej Dach
ed00cd9fc5
Remove simple localisable .ToString() calls
2021-11-02 21:42:02 +01:00
Bartłomiej Dach
11de924704
Use LocalisableStrings where possible to leverage localisable text flow
2021-11-02 21:42:02 +01:00
Bartłomiej Dach
98367fc482
Update usages of GetLocalised{-> Bindable}String
2021-11-02 21:42:01 +01:00
Dean Herbert
47914c49ba
Fix missed null consideration
2021-11-03 04:54:36 +09:00
Dean Herbert
392559ae3e
Fix beatmap download notifications not showing beatmap name correctly
2021-11-03 03:23:41 +09:00
Dean Herbert
caa9d8997b
Merge branch 'master' into score-refactor/less-create-score-info
2021-11-01 22:59:11 +09:00
Bartłomiej Dach
793c384ecd
Remove unnecessary null-conditional access
2021-11-01 12:02:37 +01:00
Bartłomiej Dach
5dcff7d8b7
Merge branch 'master' into score-refactor/less-create-score-info
2021-11-01 11:41:20 +01:00
Dean Herbert
b21e0e7efb
Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays
2021-11-01 18:07:51 +09:00
Bartłomiej Dach
f5feed138d
Merge branch 'master' into score-refactor/isolated-serialisation
2021-11-01 09:43:51 +01:00
Dean Herbert
63c9512ab1
Update dashboard components to use APIBeatmapSet
2021-11-01 16:04:01 +09:00
Dean Herbert
b98faf6159
Merge branch 'master' into score-refactor/isolated-serialisation
2021-11-01 15:49:25 +09:00
Dean Herbert
21e0074d3b
Add missing AddInternal call for BeatmapSetHeaderContent's download tracker
2021-11-01 14:43:32 +09:00
Dean Herbert
19feae4a8e
Merge branch 'master' into beatmap-refactor/download-tracker
2021-11-01 13:15:36 +09:00
Bartłomiej Dach
8053b2c320
Merge branch 'master' into score-refactor/isolated-serialisation
2021-10-30 15:07:34 +02:00
Dean Herbert
e9473db77c
Reorder to have video settings next to renderer
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-10-30 20:37:55 +09:00
Opelkuh
4d988340eb
Add hardware acceleration toggle
2021-10-30 01:02:53 +02:00
Dean Herbert
5311fe2d02
Merge branch 'master' into beatmap-refactor/beatmap-overlays
2021-10-29 22:37:29 +09:00
Dean Herbert
a16c8f1ebc
Update all beatmap overlay views to use APIBeatmap/APIBeatmapSet
2021-10-29 18:50:55 +09:00
Dean Herbert
8ad33d43d0
Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays
2021-10-29 18:01:17 +09:00
Dean Herbert
31403daa20
Change DrawableProfileScore to use APIScoreInfo
2021-10-29 15:14:52 +09:00
Dean Herbert
3f030cebf4
Remove local score copying in GetScoresRequest to allow APIScoreInfo.Beatmap to be APIBeatmap
2021-10-29 14:14:25 +09:00
Dean Herbert
817369903a
Rename API score classes
2021-10-29 13:40:56 +09:00
Bartłomiej Dach
6f863ca204
Adjust game-side text flow containers to part-based model
2021-10-29 06:34:08 +02:00
Dean Herbert
3b095e1626
Merge branch 'master' into beatmap-refactor/download-tracker
2021-10-29 11:50:54 +09:00
Dan Balasescu
e5a7589859
Merge pull request #15317 from peppy/beatmap-refactor/uncontested
...
Update `UpdateableBeatmapBackgroundSprite` to accept `IBeatmapInfo`
2021-10-28 17:24:49 +09:00
Dean Herbert
1e1f8c472a
Add icons to various progress notification states
2021-10-28 16:34:12 +09:00
Dean Herbert
7245baba69
Remove IBeatmapSetOnlineInfo implementation from BeatmapSetInfo to avoid null cases
2021-10-28 00:50:45 +09:00
Dean Herbert
746d6a4c16
Fix some oversights and test failures
2021-10-27 23:42:27 +09:00
Dean Herbert
f014ceaead
Update remaining usages of download tracking
2021-10-27 21:00:46 +09:00
Dean Herbert
6339064dbd
Remove old versions of DownloadTrackingComposite
2021-10-27 21:00:46 +09:00
Dean Herbert
6944151486
Apply batch fixing of built-in types using var
2021-10-27 13:04:41 +09:00
Dean Herbert
5e5b86a1f4
Merge pull request #15156 from Susko3/use-ShowFileInNativeExplorer
...
Update usages of `OpenInNativeExplorer` to use `PresentFileExternally` / `PresentExternally`
2021-10-26 15:53:03 +09:00
Dan Balasescu
efe6763226
Merge branch 'master' into move-online-beatmap-metrics
2021-10-26 14:24:40 +09:00
Dean Herbert
53ff0802cb
Merge branch 'master' into use-ShowFileInNativeExplorer
2021-10-26 13:58:30 +09:00
Bartłomiej Dach
6802e9ec10
Remove FixedWidth and add AutoSizeAxes specs to all usages
2021-10-25 20:24:48 +02:00
Dean Herbert
2c308f3008
Rename BeatmapMetrics to APIFailTimes
2021-10-25 15:34:41 +09:00
Dean Herbert
045dd94a6e
Move online metrics out of BeatmapSetInfo model
2021-10-25 15:12:39 +09:00
Bartłomiej Dach
5ab3337a10
Update beatmap set status pill appearance
2021-10-24 20:40:34 +02:00
Susko3
51c5d0aec7
Update to be in line with framework changes
2021-10-24 13:21:41 +02:00
Dean Herbert
c701579c69
Refactor BeatmapMetadataContainer and usages to use interface types
2021-10-22 21:38:50 +09:00
Dean Herbert
69e7810dad
Enable nullable and switch classes to structs
2021-10-21 18:54:36 +09:00
Dean Herbert
32d01f022f
Rename usages which rely on online backing
2021-10-21 16:58:42 +09:00
smoogipoo
2c979d6420
Merge branch 'master' into localise-toasts
2021-10-20 15:04:07 +09:00
Dean Herbert
37841ca3aa
Remove incorrect ToString calls causing localisation to not actually apply
2021-10-20 10:41:34 +09:00
Bartłomiej Dach
80da153697
Recolour a few other existing dropdowns with same hover & selection colours
2021-10-19 22:47:18 +02:00
Bartłomiej Dach
ef03787fe0
Split dropdown accent colour into hover and selection colours
2021-10-19 22:09:51 +02:00
Dean Herbert
c97cfdd978
Merge branch 'master' into localise-toasts
2021-10-19 16:37:14 +09:00
Bartłomiej Dach
6d9d85685f
Fix settings item having zero height
2021-10-18 23:30:38 +02:00
Bartłomiej Dach
88a1b31fae
Remove grid usage in SettingsItem
2021-10-18 22:07:32 +02:00
Bartłomiej Dach
6c3637a62a
Remove grid usage in KeyBindingRow
2021-10-18 22:07:30 +02:00
Bartłomiej Dach
830f49bca6
Remove doubled-up opacity specification
2021-10-18 19:43:48 +02:00
Bartłomiej Dach
2a41e8bd1f
Remove unneeded extra padding from settings number box
2021-10-17 21:50:04 +02:00
Bartłomiej Dach
552fc1dc8a
Adjust key binding rows to accommodate new default value indicator
2021-10-17 21:50:04 +02:00
Bartłomiej Dach
f422ebb281
Adjust SettingsItem to accommodate new default value indicator
2021-10-17 21:50:03 +02:00
Bartłomiej Dach
818f35c35f
Restyle default value indicator
2021-10-17 21:50:03 +02:00
Bartłomiej Dach
ed2f9dd443
Adjust settings slider spacings
2021-10-15 00:31:06 +02:00
Dean Herbert
06249c4ab2
Fix incorrect usages of Scheduler.AddOnce
2021-10-14 17:52:19 +09:00
Bartłomiej Dach
d205483a36
Revert ThemedDropdown-related changes
2021-10-13 21:57:50 +02:00
Bartłomiej Dach
a2f3a7cba8
Add "themed" dropdown variant and use in settings sidebar
2021-10-12 21:58:43 +02:00
Bartłomiej Dach
1fba932e84
Adjust settings dropdown spacings
2021-10-12 21:41:33 +02:00
Dan Balasescu
cabbb1697a
Merge pull request #15054 from peppy/settings-ordering
...
Initial settings usability pass
2021-10-12 22:00:30 +09:00
Dean Herbert
24b87cf655
Change some icons to be more descriptive (still placeholder)
2021-10-12 15:09:59 +09:00
Dean Herbert
59202d27c7
Add some missing labels
2021-10-12 15:09:59 +09:00
Dean Herbert
5ca1d1d12c
Reorder graphics settings and move gameplay related pieces out
2021-10-12 15:09:59 +09:00
Dean Herbert
c4347de57e
Move ruleset settings to own section
2021-10-12 14:58:43 +09:00
Dean Herbert
8285f065c2
Reorganise gameplay settings into more sections
2021-10-12 14:58:43 +09:00
Dean Herbert
1d3d67c5f1
Move gameplay cursor settings to gameplay section
2021-10-12 13:56:10 +09:00
Dean Herbert
a986870a99
Reorder sections to be more in line with how often they are adjusted
2021-10-12 13:41:35 +09:00
Dean Herbert
e058214346
Merge branch 'master' into fix-audio-filter-test-failures
2021-10-12 12:06:12 +09:00
Bartłomiej Dach
ff382259ca
Use rounded buttons in tablet rotation preset settings
2021-10-11 23:17:09 +02:00
Joseph Madamba
4fc84e71cd
Localise more toast related strings
2021-10-11 01:02:26 -07:00
Dean Herbert
484a95229e
Update toast implementations temporarily to expedite getting tests back in line
2021-10-11 16:36:04 +09:00
Joseph Madamba
af9bb6f277
Fix padding of shortcut in toast when widest
2021-10-10 19:37:46 -07:00
Joseph Madamba
7b37b15976
Localise some music action toasts
2021-10-10 19:36:50 -07:00
Joseph Madamba
545cfc7bf1
Localise tracked setting toasts
2021-10-10 19:35:25 -07:00
Bartłomiej Dach
b30dd2d4ed
Use rounded button in settings sidebar
2021-10-10 21:45:41 +02:00
Dean Herbert
49b341daff
Remove HoverTarget shared state update path
...
Felt quite convoluted to follow. Have just duplicated the single shared
line instead.
2021-10-10 11:55:47 +09:00
Dean Herbert
ccc6d8ff40
Improve the animation of the active indicator
2021-10-10 11:34:01 +09:00
Bartłomiej Dach
fe26d8e8df
Share sidebar colouring logic by splitting out SidebarIconButton
2021-10-10 00:34:12 +02:00
Bartłomiej Dach
b8616bf910
Adjust appearance of keybinding subpanel
2021-10-10 00:34:12 +02:00
Bartłomiej Dach
855a74b8a0
Adjust vertical spacings in individual subsections
2021-10-10 00:34:11 +02:00
Bartłomiej Dach
e23a54f1e6
Adjust setting section appearance & spacings
2021-10-10 00:31:01 +02:00
Bartłomiej Dach
4c293b637f
Restyle settings panel header
2021-10-09 23:40:15 +02:00
Bartłomiej Dach
315581f4c8
Adjust horizontal spacing in settings panel
2021-10-09 23:40:15 +02:00
Bartłomiej Dach
f6df93f013
Introduce basic parts of colour scheme to settings sidebar
2021-10-09 23:40:14 +02:00
Dan Balasescu
9be56829c9
Merge pull request #14935 from Susko3/fix-SettingsTextBox-using-null-as-default
...
Fix usages of `SettingsTextBox` having `null` as the default
2021-10-08 18:36:02 +09:00
Dean Herbert
9dc035757f
Fix weird textbox behaviour when entering a random mod seed overflowing int backing
2021-10-08 14:01:36 +09:00
Dean Herbert
2856aef4eb
Add exception to catch any incorrect defaults of Bindable<string>
2021-10-08 13:52:38 +09:00
Dean Herbert
e578046b20
Rename Filter -> AudioFilter
2021-10-07 18:50:08 +09:00
Dean Herbert
0348c6c7e5
Apply some renaming and code quality fixes
2021-10-07 18:49:22 +09:00
Dean Herbert
f98dd1b811
Merge branch 'master' into popup-filter-effect
2021-10-07 18:40:21 +09:00
Jamie Taylor
266e62794e
Tweak cutoff effect for new Q value
2021-10-06 11:52:05 +09:00
Dan Balasescu
4bbff2ebf7
Merge branch 'master' into new-interfaces
2021-10-06 11:38:17 +09:00
Dan Balasescu
9491e5a547
Merge pull request #14954 from peppy/rename-result-response
...
Rename `APIRequest.Result` to `Response`
2021-10-06 10:52:33 +09:00
