Dan Balasescu
6c6de9ce53
Fix typo
2022-06-27 20:40:02 +09:00
Dean Herbert
50c1c066de
Add various logging of global WorkingBeatmap state changes
2022-06-27 18:41:31 +09:00
Dean Herbert
31a447fda0
Update parameter discards
2022-06-24 21:26:19 +09:00
Dean Herbert
30eebf3511
Merge branch 'master' into c-sharp-10
2022-06-24 21:22:33 +09:00
Bartłomiej Dach
26c5b59f6d
Replace usages of string.To{Lower,Upper}()
2022-06-24 11:57:45 +02:00
Dean Herbert
f71f6302fd
Remove unnecessary null casts
2022-06-24 14:50:11 +09:00
Dean Herbert
d9c1a9d71f
Use new property to specify no tooltip, rather than passing only ruleset
2022-06-24 14:06:18 +09:00
Dean Herbert
7dec530ca5
Split out simple DifficultyIcon with no calculation overhead and update usages
2022-06-23 19:27:35 +09:00
Dean Herbert
b660119de7
Merge pull request #18796 from bdach/mod-overlay/legacy-key-bindings
...
Add setting option to toggle between mod overlay hotkey styles
2022-06-22 20:28:18 +09:00
Dan Balasescu
b81c7c7951
Merge pull request #18804 from Joehuu/online-view-chat-overlay
...
Add back online view container to chat overlay
2022-06-22 14:41:06 +09:00
Dan Balasescu
ff440fc1a4
Fix too many buttons inside condition
2022-06-22 13:44:41 +09:00
Dan Balasescu
321920bc85
Remove one more nullable disable
2022-06-22 13:44:41 +09:00
Dan Balasescu
1018c9852d
Cleanup nullability
2022-06-22 13:44:41 +09:00
Dan Balasescu
23254d2ff2
Fix broken files
2022-06-22 13:44:41 +09:00
Joseph Madamba
07e0cd53a4
Add back online view container to chat overlay
2022-06-21 19:23:16 -07:00
Joseph Madamba
50728f3fbc
Fix overlay header tab item not working with localisable string
2022-06-21 18:31:09 -07:00
Supersonicboss1
4aa86b0a80
fixed duplicates and cleaned up code
2022-06-21 23:41:25 +01:00
Supersonicboss1
e4931f977c
improved UI of maintenance section in settings
2022-06-21 23:00:03 +01:00
Bartłomiej Dach
7013909322
Remove unnecessary protected virtual
2022-06-21 16:43:04 +02:00
Bartłomiej Dach
f564ed589f
Alter sequential hotkey style to always use visible index
...
Previous behaviour was once mentioned off-hand as unintuitive.
2022-06-21 15:22:18 +02:00
Bartłomiej Dach
9e5cc89edb
Fix classic hotkeys toggling filtered mods
2022-06-21 15:01:33 +02:00
Bartłomiej Dach
da1814e7c3
Restructure everything to fix free mod overlay issue
2022-06-21 14:48:41 +02:00
Bartłomiej Dach
7b7b8c1892
Implement behaviour for classic selection style
2022-06-21 14:24:30 +02:00
Bartłomiej Dach
234120ff43
Forward entire event to IModHotkeyHandler
...
Required for shift handling in the classic implementation.
2022-06-21 13:37:17 +02:00
Bartłomiej Dach
658f5341c7
Set up flow for switching between hotkey styles
2022-06-21 13:34:58 +02:00
Bartłomiej Dach
5abd8a07d2
Add setting for changing mod select hotkey style
2022-06-21 13:33:17 +02:00
Bartłomiej Dach
73124d2b1f
Encapsulate mod hotkey selection logic in strategy pattern
2022-06-21 12:49:01 +02:00
Bartłomiej Dach
ee96d84ffa
Merge branch 'master' into input-settings
2022-06-20 22:55:43 +02:00
Dean Herbert
6515b249ec
Change data migration to do an immediate exit, rather than attempted exit
2022-06-19 12:39:58 +09:00
Dean Herbert
50e40756c4
Rename GracefullyExit to AttemptExit
2022-06-19 12:34:44 +09:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Salman Ahmed
e4ddf03ad6
Fix toolbar music button handling keys while not hovered
2022-06-16 20:22:57 +03:00
Bartłomiej Dach
9c4f6d2ce0
Merge branch 'master' into first-run-setup-notification-interruption
2022-06-16 15:14:40 +02:00
Dean Herbert
251923c106
Convert NotificationOverlay to NRT
2022-06-16 17:28:08 +09:00
Dean Herbert
6b30ee0950
Tidy up DI and binding logic
2022-06-16 17:26:43 +09:00
Bartłomiej Dach
f88c568c8d
Update flag sizes after switch to twemoji assets
...
The old flags used a size of 150x100, while the new assets based on
twemoji use a size of 150x108. Update existing usages to match this new
aspect ratio better.
2022-06-15 21:45:47 +02:00
Salman Ahmed
e7dcbddbeb
Fix potential null reference
2022-06-15 18:53:49 +03:00
Salman Ahmed
026bad7fc4
Use notification processing mode logic instead
2022-06-15 18:13:24 +03:00
Dean Herbert
7571ab6c63
Merge branch 'master' into new-dialog-sfx
2022-06-15 19:47:00 +09:00
Dean Herbert
584345a97e
Merge pull request #18693 from frenzibyte/toolbar-volume-control
...
Add basic volume control support in toolbar music button
2022-06-15 17:50:10 +09:00
Dean Herbert
b3aa4fcf02
Adjust a channel rather than the overall sample
2022-06-15 17:33:07 +09:00
Dean Herbert
94aa2248ca
Move filter reset to more appropriate location
2022-06-15 17:32:21 +09:00
Dean Herbert
1f1633ddc2
Remove Update method processing of samples in PopupDialogDangerousButton
2022-06-15 16:50:23 +09:00
Salman Ahmed
583619b915
Use GlobalAction.DecreaseVolume instead
2022-06-15 10:21:27 +03:00
Dean Herbert
873806c2ea
Add keyboard adjustment support
2022-06-15 15:58:22 +09:00
Dean Herbert
3df9d7c9e1
Add a bit more animation when adjusting
2022-06-15 15:56:59 +09:00
Dean Herbert
5eb56ab814
Ensure Master volume is updated when scrolling on toolbar button
2022-06-15 15:41:40 +09:00
Jamie Taylor
af87722be8
Add audio feedback for 'Dangerous' dialog buttons
2022-06-15 15:41:27 +09:00
Jamie Taylor
930ec2a197
Add specific samples for dialog 'Ok' and 'Cancel' buttons
2022-06-15 15:41:27 +09:00
Salman Ahmed
ddeee09a51
Fix important notifications interrupting first-run setup
2022-06-15 03:40:05 +03:00
Salman Ahmed
1f31e3fb51
Add volume UI to toolbar music button
2022-06-14 22:15:12 +03:00
Salman Ahmed
7f23677972
Add volume control support via toolbar music button
2022-06-14 22:15:12 +03:00
Dean Herbert
49ec2572b8
Allow scrolling overflow of ruleset buttons in the toolbar
2022-06-15 01:43:10 +09:00
Salman Ahmed
d89c11e49e
Allow Toolbar to block scroll input from passing through
2022-06-14 19:10:13 +03:00
Dean Herbert
77fcf35d1d
Remove unlimited frame limiter warning
...
This should not be required now that we have a 1,000 Hz limiter in
place.
2022-06-13 15:40:27 +09:00
Dan Balasescu
e5d6dc1ba5
Merge pull request #18606 from peppy/latency-comparer
...
Add latency certifier system
2022-06-10 19:41:44 +09:00
Dan Balasescu
c9dfffbc0e
Merge pull request #18619 from peppy/fix-collection-performance
...
Fix performance overhead of large collections
2022-06-10 15:01:31 +09:00
Dean Herbert
c625c929e5
Update button text to match new terminology
2022-06-10 14:16:56 +09:00
Dean Herbert
4a5e86e451
Rename Beatmaps to BeatmapHashes for clarity
2022-06-10 14:03:51 +09:00
Dean Herbert
3b229624dd
Simplify contains check to use LINQ the whole way
2022-06-10 14:02:58 +09:00
Dan Balasescu
bc7262a3dd
Merge pull request #18627 from Joehuu/always-show-mod-selector-beatmap-info
...
Always show mod selector on beatmap info leaderboards regardless of supporter
2022-06-09 18:18:12 +09:00
Joseph Madamba
f3371e8bc8
Always show mod selector on beatmap info leaderboards regardless of supporter
2022-06-08 13:22:49 -07:00
Jai Sharma
c2ed41d097
Remove CanBeNull specification from DI attributes
2022-06-08 15:10:19 +01:00
Jai Sharma
04b434b8ce
Update ChatLine timestamp and message colours
2022-06-08 14:04:01 +01:00
Jai Sharma
dfa31df2af
Use #nullable enable in ChatLine
2022-06-08 14:04:01 +01:00
Dean Herbert
c22bffaa01
Fix filter failure when no collection is selected
2022-06-08 19:30:18 +09:00
Dean Herbert
187086e4ec
Merge pull request #18609 from ALANVF/settings-delete-skin
...
Add button to delete the current skin
2022-06-08 19:18:59 +09:00
Dean Herbert
42cd7d9e6e
Change CollectionManager to only store MD5 hashes instead of full BeatmapInfo
2022-06-08 18:23:09 +09:00
Dan Balasescu
3a90aa0b9b
Fix code styling
2022-06-08 17:57:59 +09:00
Dean Herbert
5157a78ae6
Isolate nested sample screens from main game to avoid toolbar interactions
2022-06-08 16:53:06 +09:00
theangryepicbanana
6c05329144
Close #5820 (Ability to delete a single skin)
2022-06-07 18:01:40 -04:00
Jai Sharma
2f635fa854
Refactor ChatLine and fix DrawableChannel flow padding
...
Refactors `ChatLine` component to use more sensible override properties
and layout using grid container. Moves creation of username component
into its own method to simplify BDL.
Updates padding of base `DrawableChannel` flow padding.
Removes usage of `ChatOverlayDrawableChannel` since it's overrides are
no longer needed.
Updates usage of `StandAloneChatDisplay` to use new override properties
of `DrawableChannel`.
2022-06-07 22:35:45 +01:00
Dean Herbert
9da99a0ddf
Rename to latency certifier
2022-06-07 23:34:55 +09:00
Dean Herbert
95dea00725
Tidy up code and namespaces
2022-06-07 23:10:08 +09:00
Dean Herbert
20cfa5d83f
Add button to access latency comparer from game
2022-06-07 17:28:31 +09:00
Bartłomiej Dach
4df7711af8
Merge branch 'master' into volume-metre-keyboard-fix
2022-06-06 23:45:42 +02:00
Dean Herbert
b104b7a90d
Rename method to mention "all"
2022-06-06 20:12:20 +09:00
Dean Herbert
cb383d4bdc
Merge branch 'master' into delete-all-beatmap-videos-sbs
2022-06-06 20:08:05 +09:00
Jai Sharma
c0aaeff2b3
Update DaySeparator to use new design throughout
...
Moves `DaySeparator` chat component to it's own file and update it to
match new chat design. Makes use of several virtual attributes that can
be overridden to update spacing and layout in other usage contexts.
Remove redundant usage of `ChatOverlayDaySeparator`, since the new
design is now part of the base class.
Create `StandAloneDaySeparator` to use in `StandAloneChatDisplay` which
overrides attributes to match correct spacing and layout for its design.
Ensure that `DrawableChannel.CreateDaySeparator` returns type of
`DaySeparator` instead of `Drawable`.
2022-06-04 18:02:14 +01:00
Joseph Madamba
58c8562cb0
Fix username placeholder text casing and missing localisation on registration form
2022-06-03 20:09:20 -07:00
Dean Herbert
d0e098fbcd
Allow using arrow keys to navigate volume controls when controls are already visible
2022-06-04 01:04:46 +09:00
Dean Herbert
712253a35b
Make non-localisable strings in VolumeMeter verbatim
2022-06-04 01:04:23 +09:00
Dean Herbert
64616a6d73
Remove completely gimped implementation in VolumeMeter
2022-06-04 00:18:54 +09:00
Jamie Taylor
6115275bc2
Use 'default' sampleset for toolbar and repurpose 'toolbar' select sample temporarily
2022-06-03 22:33:06 +09:00
Jamie Taylor
2878bb592f
Use more appropriate sounds for certain components
2022-06-03 22:32:12 +09:00
Jamie Taylor
365819865e
Remove 'submit' sample usages
2022-06-03 22:31:35 +09:00
Salman Ahmed
cd999cf7ac
Fix back-to-front conditional
2022-06-03 10:51:20 +03:00
Salman Ahmed
1a835f0622
Add warning note when running fullscreen on macOS
2022-06-03 10:32:59 +03:00
Dean Herbert
5bd9d88219
Fix tutorial download state not matching correctly when already available locally
...
Closes https://github.com/ppy/osu/issues/18468 .
This doesn't stop the tutorial from downloading a second time, but at
least displays the correct status afterwards. Avoiding the download is a
bit more involved and requires a change to the flow. Probably not worth
it just yet.
To test, recommend switching to production environment, as dev server
doesn't have correct metadata for tutorial resulting in weirdness.
2022-06-02 16:34:24 +09:00
Dean Herbert
42598ce22a
Refactor warning to notice in method names and usages
2022-06-01 16:51:58 +09:00
Dean Herbert
f7110116de
Only display exclusive fullscreen hinting on windows
2022-05-31 14:04:56 +09:00
Dean Herbert
53844d3df1
Refactor settings item "warning" text to allow non-warning state
2022-05-31 14:01:42 +09:00
Dan Balasescu
99ee3a7d8d
Merge branch 'master' into detect-exclusive-fullscreen
2022-05-31 09:42:42 +09:00
Dean Herbert
1d5a156c15
Merge pull request #18427 from sw1tchbl4d3r/currently_playing_search
...
Add search bar for the `CurrentlyPlayingDisplay`
2022-05-30 23:03:00 +09:00
Dean Herbert
f65d2db77f
Remove "V2" suffix from ChatOverlay components
2022-05-30 17:54:09 +09:00
Dan Balasescu
5f9a69e5c2
Add localisation
2022-05-30 17:19:03 +09:00
Dan Balasescu
dea7a27553
Adjust wording, add text for capable state
2022-05-30 17:18:29 +09:00
Dean Herbert
9e678101cf
Merge pull request #18442 from jai-x/new-chat-announce-channel
...
Display Announce type channels separately in new chat overlay
2022-05-30 16:53:15 +09:00
Dean Herbert
5478ac21ea
Merge branch 'master' into currently_playing_search
2022-05-30 16:48:53 +09:00
Jai Sharma
8f596520f3
Remove old chat overlay components
2022-05-29 20:08:43 +01:00
Bartłomiej Dach
e329c160b3
Simplify channel retrieval expression
2022-05-29 18:58:27 +02:00
Bartłomiej Dach
e69f8716cd
Fix incorrect indent size
2022-05-29 18:56:37 +02:00
Bartłomiej Dach
f9f8a32380
Merge branch 'master' into new-chat-announce-channel
2022-05-29 18:55:43 +02:00
Dean Herbert
7c97719db1
Move Schedule to only drawable pieces
2022-05-29 21:28:09 +09:00
Dean Herbert
c7570fbce5
Fix potential ObjectDisposedException on realm notification in SkinSection
2022-05-29 15:15:03 +09:00
sw1tchbl4d3
ede3ab9dc0
Add OnFocus handler to CurrentlyPlayingDisplay
2022-05-28 12:04:44 +02:00
Salman Ahmed
06832a4baf
Fix beatmap badge colours not updated inline with recent changes
2022-05-28 01:05:43 +03:00
sw1tchbl4d3
cd84200ad9
Add HoldFocus and ReleaseFocusOnCommit attributes to searchbar
2022-05-27 21:23:37 +02:00
Jai Sharma
c5845f307a
Code quality
2022-05-27 20:12:00 +01:00
Dean Herbert
254039b8fe
Address remaining code quality concerns
2022-05-28 04:01:51 +09:00
Jai Sharma
e950c8c1d0
Refactor ChannelList to use new ChannelGroup class for each type of channel
2022-05-27 19:46:53 +01:00
Jai Sharma
320b6ca631
Display Announce type channels separately in new chat overlay
2022-05-27 16:18:22 +01:00
Bartłomiej Dach
e511c1dfff
Merge branch 'master' into use-normalised-precise-scrolling
2022-05-27 16:55:13 +02:00
sw1tchbl4d3
e2951d70d1
Address code style issues
2022-05-27 16:38:54 +02:00
sw1tchbl4d3
e1fd37fd44
Use new padding constant where appropriate
2022-05-27 12:40:31 +02:00
sw1tchbl4d3
6a0cf26722
Make text localisable and add padding constant
2022-05-27 12:36:43 +02:00
sw1tchbl4d3
7c459faaf0
Remove unneeded search_bar_width and more
2022-05-27 10:05:59 +02:00
sw1tchbl4d3
4967d03606
Update currently playing search bar to resemble existing UI
2022-05-27 09:58:40 +02:00
Joseph Madamba
105d581f24
Use existing web localisation for chat strings
2022-05-26 22:23:03 -07:00
Joseph Madamba
3554563114
Fix beatmap info scores container not hiding when there's no leaderboard
2022-05-26 19:50:54 -07:00
Joseph Madamba
2b5aa35b56
Fix beatmap info status pill being incorrect on multiple status beatmaps
2022-05-26 17:52:17 -07:00
sw1tchbl4d3
a8e453e660
Remove now unnecessary username filter check
2022-05-27 00:43:29 +02:00
sw1tchbl4d3
de5b60ab66
Move filtering from manual loops to SearchContainer
2022-05-27 00:40:23 +02:00
sw1tchbl4d3
3183621d3d
Add search bar for the CurrentlyPlayingDisplay
2022-05-26 22:57:24 +02:00
Dean Herbert
a98d0cf0d8
Simplify channel filter method
2022-05-26 18:48:11 +09:00
Dean Herbert
b2607196b8
Merge branch 'master' into new-chat-integrate
2022-05-26 18:38:26 +09:00
Dan Balasescu
08935cff86
Detect exclusive fullscreen on Windows
2022-05-26 18:37:04 +09:00
Noah M
b550cbc5a3
Fix failing code quality checks
2022-05-25 17:01:30 -05:00
Bartłomiej Dach
a1b8fa0992
Disable "select all mods" button if all are selected
2022-05-25 23:06:12 +02:00
Bartłomiej Dach
071e158a29
Expose available mod state outwardly as a bindable
2022-05-25 23:06:12 +02:00
Bartłomiej Dach
f0303d76e8
Split off "select all mods" button to separate class
2022-05-25 22:18:30 +02:00
Bartłomiej Dach
a3f2962558
Disable "deselect all mods" button if none are selected
2022-05-25 22:15:02 +02:00
Bartłomiej Dach
a4bd399b0c
Split off "deselect all mods" button to separate class
2022-05-25 22:14:45 +02:00
Jai Sharma
f94afa5f8c
Code quality
2022-05-25 18:28:18 +01:00
Jai Sharma
997fc716e8
Split out the channel list labels from the channel list item flow
2022-05-25 15:15:46 +01:00
Jai Sharma
c0da05dda0
Use an array of channels to exclude from the overlay
2022-05-25 15:15:26 +01:00
Jai Sharma
cd90d29315
Ensure channel traversal shortcut scrolls channel list item into view
2022-05-25 12:37:28 +01:00
Jai Sharma
4a36f3aa4c
Ensure channel traversal shortcut is using visual order
2022-05-25 12:29:04 +01:00
Dean Herbert
49ab031e75
Allow traversing in both directions using ctrl-tab shortcuts
2022-05-25 18:42:49 +09:00
Dean Herbert
a92089c443
Change filter method to consider all non-system channels as joinable
2022-05-25 18:42:33 +09:00
Dan Balasescu
79c8752bb4
Merge pull request #18408 from peppy/first-run-ui-scale-first
...
Move UI scale setup to the beginning of the first run setup
2022-05-25 12:56:03 +09:00
Dean Herbert
de5d2df100
Move UI scale setup to the beginning of the first run setup
2022-05-25 12:19:26 +09:00
Dan Balasescu
f468d1eb16
Merge branch 'master' into editor-tidy-up
2022-05-25 11:58:34 +09:00
Jai Sharma
f6810d3f59
Add keyboard shortcuts to ChatOverlayV2 with tests
2022-05-24 23:05:25 +01:00
Bartłomiej Dach
61c093c109
Merge branch 'master' into rounded-button-colour-default
2022-05-24 22:47:47 +02:00
Jai Sharma
fce527b0df
Schedule channel manager bindable events to ensure they happen after the first poll
2022-05-24 21:25:27 +01:00
Bartłomiej Dach
2dd0b3f8d9
Merge branch 'master' into fix-mod-panel-click-area
2022-05-24 21:52:37 +02:00
Dean Herbert
0bcf8c846c
Change editor colour scheme to aquamarine
2022-05-24 18:43:22 +09:00
Dean Herbert
f00dd27fcd
Move OverlayColourProvider provisioning of RoundedButton to SettingsButton for now
2022-05-24 18:11:54 +09:00
Joseph Madamba
1f935cacf4
Add spotlighted beatmaps filter to beatmap listing
2022-05-23 18:47:04 -07:00
