1015 Commits

• Adjust inline comment
  Bartłomiej Dach · 2023-07-20 20:51:39 +02:00
  07e0a703d7
• Merge branch 'master' into editor-cyclic-selection
  Bartłomiej Dach · 2023-07-20 20:19:46 +02:00
  708dd355cd
• Add xmldoc to ApplySelectionOrder()
  Bartłomiej Dach · 2023-07-20 19:16:04 +02:00
  511948ba56
• Fix double-click handling when cyclic selection is enabled

  Removes the limitations of cyclic selection as a result.

  Dean Herbert · 2023-07-19 17:21:20 +09:00
  cf3949c9e2
• Change editor to always perform selection of closest object
  Dean Herbert · 2023-07-19 16:56:16 +09:00
  5ade093c5a
• Update design of timeline centre marker and adjust surrounding paddings
  Dean Herbert · 2023-07-14 16:37:57 +09:00
  57abb15724
• Implement longer design for timing point piece
  Dean Herbert · 2023-07-14 16:37:56 +09:00
  00e9746174
• Update metrics of checkboxes and backgrounds to match design better
  Dean Herbert · 2023-07-14 14:29:02 +09:00
  01750dd091
• Move beat divisor control inside of TimelineArea and adjust metrics to match design
  Dean Herbert · 2023-07-14 14:19:04 +09:00
  5b2e704264
• Apply NRT to timeline related classes
  Dean Herbert · 2023-07-14 14:04:12 +09:00
  ebaf63b764
• Change BeatDivisorControl to retrive bindable divisor via DI
  Dean Herbert · 2023-07-14 14:03:25 +09:00
  56acc9e3dd
• Use slightly different condition for better UX
  Bartłomiej Dach · 2023-07-01 21:39:08 +02:00
  9eec1337b3
• Fix edge cases where selection buttons go outside playfield bounds

  Addresses
  https://github.com/ppy/osu/discussions/23599#discussioncomment-6300885.

  Bartłomiej Dach · 2023-07-01 21:27:17 +02:00
  183777f8df
• Fix selection handlers eating hotkey presses they didn't handle
  Bartłomiej Dach · 2023-06-28 20:48:22 +02:00
  e4e08c0f5f
• Trigger state change when flipping via hotkey in the editor

  This will trigger a change even if nothing happens. But I think that's
  okay (not easy to avoid) because the change handler should be aware that
  nothing changed, if anything.
  
  Closes https://github.com/ppy/osu/issues/24065.

  Dean Herbert · 2023-06-28 13:52:51 +09:00
  29376ffcc0
• Fix hotkey presses generating unnecessary undo history

  The buttons don't check whether the operation they correspond to is
  possible to perform in the current state of the selection box, so not
  checking `Can{Reverse,Rotate}` causes superfluous undo states to be
  added without any real changes if an attempt is made to reverse or
  rotate a selection that cannot be reversed or rotated.

  Bartłomiej Dach · 2023-06-27 22:25:04 +02:00
  9be2d9d62e
• Mention hotkeys in button tooltips
  Bartłomiej Dach · 2023-06-27 22:04:15 +02:00
  17ed45d07c
• Switch to == true
  Bartłomiej Dach · 2023-06-27 22:02:15 +02:00
  54280f06be
• Enable NRT in SelectionBox
  Bartłomiej Dach · 2023-06-27 22:01:44 +02:00
  ad3a470eaf
• Add support for Ctrl + < / > to rotate selection in editor

  As discussed in https://github.com/ppy/osu/discussions/24048.

  Dean Herbert · 2023-06-27 17:01:41 +09:00
  c6d952abe3
• Add a visual effect when keyboard shortcuts are used to trigger selection box buttons
  Dean Herbert · 2023-06-27 17:01:13 +09:00
  7ddbf4eaa7
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Fix slightly incorrect calculations
  Dean Herbert · 2023-06-19 20:23:46 +09:00
  84fc6e92db
• Merge branch 'master' into fix-distance-snap-grid-centering
  Dean Herbert · 2023-06-19 20:22:09 +09:00
  4314f9f46a
• Privatise setter
  Bartłomiej Dach · 2023-06-16 16:24:07 +02:00
  28696f595f
• Fix distance snap grid circles not correctly being centered on snap point
  Dean Herbert · 2023-06-16 17:21:32 +09:00
  d965d39c44
• Fix incorrect mapping when distance spacing is not 1.0x
  Dean Herbert · 2023-06-16 17:15:45 +09:00
  36954e55ad
• Add setting to limit distance snapping to current time

  As discussed in https://github.com/ppy/osu/discussions/23815#discussioncomment-6124116.

  Dean Herbert · 2023-06-09 15:54:33 +09:00
  78b2e6f3df
• Merge branch 'master' into beat-divisor-better-defaults
  Bartłomiej Dach · 2023-06-08 20:35:03 +02:00
  4b3b22f046
• Select all text when popover is initially shown

  Depends on https://github.com/ppy/osu-framework/pull/5823.

  Dean Herbert · 2023-06-09 02:27:22 +09:00
  c1743dbe1d
• Remove unused method
  Bartłomiej Dach · 2023-06-07 23:38:06 +02:00
  3c8f387a6c
• Remove unused virtual spec
  Bartłomiej Dach · 2023-06-07 23:38:06 +02:00
  d9281ac8c7
• Use existing next/previous methods (and remove looping behaviour)
  Dean Herbert · 2023-06-08 01:01:29 +09:00
  3a01498789
• Add ability to cycle beat snap divisor using hotkeys

  Defaults to Ctrl+Shift+Wheel (as per stable).
  
  Closes #23785.

  Dean Herbert · 2023-06-07 17:15:15 +09:00
  2c89af608a
• Remove redundant nullable suppression directives
  Salman Ahmed · 2023-06-07 08:20:41 +03:00
  62cb6a98ca
• Adjust inline comment
  Bartłomiej Dach · 2023-06-01 21:18:00 +02:00
  c2d89a32a9
• Fix nullability
  Andrei Zavatski · 2023-06-01 21:21:01 +03:00
  03eb7c7830
• Use combined area of children as a mask instead
  Andrei Zavatski · 2023-06-01 15:32:17 +03:00
  949fe32740
• Remember the last used custom divisor when cycling divisor types
  Dean Herbert · 2023-06-01 17:11:49 +09:00
  32207d4112
• Apply NRT to BeatDivisorControl
  Dean Herbert · 2023-06-01 16:58:14 +09:00
  bcde2cbc73
• Use better defaults of 1/4 and 1/6 when cycling types
  Dean Herbert · 2023-06-01 16:28:03 +09:00
  f52ed41f10
• Fix editor timeline hitobjects popping in
  Andrei Zavatski · 2023-05-30 16:41:42 +03:00
  d119447a10
• Merge pull request #23649 from peppy/keep-selection-buttons-on-screen

  Ensure editor selection buttons remain on screen when selection is near edge

  Dean Herbert · 2023-05-26 20:51:45 +09:00
  725734bc03
• Merge branch 'master' into sample-set-controls
  Bartłomiej Dach · 2023-05-25 21:58:16 +02:00
  96fe7cbe54
• Fix ComposeBlueprintContainer briefly assigning auto bank

  Seems to have had no consequence due to the way
  `AutomaticBankAssignment` works (that flag is checked in
  `PlacementBlueprint.UpdateTimeAndPosition()`, which runs essentially
  every frame), but let's avoid putting it there at all ever.

  Bartłomiej Dach · 2023-05-25 21:49:29 +02:00
  7d8f08c0ea
• Polish a few extreme edge cases
  Bartłomiej Dach · 2023-05-25 16:39:54 +02:00
  3ad5f8b9c9
• Ensure selection is reset after immediately deleting objects

  Closes https://github.com/ppy/osu/issues/23518.

  Dean Herbert · 2023-05-25 23:20:32 +09:00
  949de35664
• Use alternative layouting implementation
  Bartłomiej Dach · 2023-05-25 16:17:44 +02:00
  beeca5a8dd
• Simplify SelectionHandler's DeselectAll implementation

  We are already doing other operations in this class directly on `SelectedItems`, so might as well change this one to match

  Dean Herbert · 2023-05-25 18:46:31 +09:00
  1049257b56