Dean Herbert
005af280f2
Isolate bindable breaks list to EditorBeatmap
2024-07-02 11:31:55 +09:00
Dan Balasescu
f942595829
Fix ManiaModInvert permanently messing up the beatmap
2024-07-01 15:02:00 +09:00
Dan Balasescu
3b3f914cd2
Merge branch 'master' into pp_counter_fix
2024-06-28 12:40:56 +09:00
Dean Herbert
fd6b77ea92
Fix distance snap control being removed
2024-06-27 23:59:38 +09:00
Dan Balasescu
0379abd714
Prevent multiple invocations of failure procedure
2024-06-26 13:57:18 +09:00
PercyDan54
2de0852551
Fix transient rank value applied to bindable
2024-06-25 18:06:50 +08:00
Dean Herbert
c58bb62408
Merge branch 'master' into hit-animations
2024-06-23 04:32:47 +09:00
sometimes
89d3f67eb3
fix accuracyProcess typo
2024-06-20 22:06:00 -04:00
Bartłomiej Dach
ad2cd0ba8f
Adjust behaviour of hit animations toggle to match user expectations
2024-06-20 13:42:32 +02:00
Dean Herbert
57774ae767
Merge branch 'master' into slider-anchor-type-switching
2024-06-20 19:01:22 +09:00
Dean Herbert
14104e57d4
Merge branch 'master' into timeline-drag-selection-crash
2024-06-20 15:16:10 +09:00
Dean Herbert
0eb533f2fd
Merge pull request #28444 from bdach/scrolling-ruleset-editor-reloads
...
Reload scrolling hitobject composer on control point changes
2024-06-20 15:15:26 +09:00
Bartłomiej Dach
4022a8b06c
Implement automatic break period generation
2024-06-19 10:22:06 +02:00
Bartłomiej Dach
6a6ccbc09f
Make list of breaks bindable
2024-06-19 07:44:03 +02:00
Bartłomiej Dach
5551bae7ce
Merge branch 'master' into navigate-to-timestamp
2024-06-18 18:32:33 +02:00
Bartłomiej Dach
f764ec24cd
Correct xmldoc
2024-06-18 18:32:24 +02:00
Bartłomiej Dach
7ee29667db
Parse plain numbers as millisecond count when parsing timestamp
2024-06-18 16:48:04 +02:00
Givikap120
1ddfc8f011
Updated the tests according to new logic
...
and fixed one minor CI code quality thing
2024-06-18 15:48:21 +03:00
Givikap120
ec2b8f3bc3
Changed timed difficulty attributes to be "per-HitObject" instead of "per-DifficultyHitObject"
2024-06-18 15:41:41 +03:00
Bartłomiej Dach
44b9a06639
Allow more lenient parsing of incoming timestamps
2024-06-18 13:13:50 +02:00
Bartłomiej Dach
2421751419
Fix code quality inspections
2024-06-18 08:33:02 +02:00
Bartłomiej Dach
310265c43f
Add slider placement binding description in tooltip
2024-06-18 08:16:25 +02:00
Dean Herbert
316125d47a
Merge pull request #23443 from OliBomby/edit-nodesample
...
Make NodeSamples editable
2024-06-18 11:12:02 +09:00
Bartłomiej Dach
7cfe8d8df2
Reduce editor opacity of several editor components when hovering over composer
...
Addresses https://github.com/ppy/osu/discussions/24384 .
2024-06-17 12:14:28 +02:00
Dan Balasescu
41446a08b6
Annotate ControlPoint and Mod for AOT trimming support
2024-06-17 16:19:33 +09:00
Bartłomiej Dach
bdeea37a44
Commit active placement when starting drag selection via timeline
...
This was reported in https://github.com/ppy/osu/pull/28474 , albeit the
code changes proposed there did not fix the issue at all.
See 8b6385f7d0
2024-06-14 09:32:40 +02:00
Dan Balasescu
91f2cf8cc3
Use more descriptive HitObject names for debugger displays
2024-06-13 15:18:39 +09:00
Bartłomiej Dach
922837dd3a
Reload scrolling composer on control point changes
2024-06-11 12:01:35 +02:00
Bartłomiej Dach
10af642342
Split mania difficulty section implementation off completely from base
...
- "Circle size" / key count needs completely different handling.
- Approach rate does not exist in mania.
2024-06-11 11:30:20 +02:00
Salman Ahmed
6f729be573
Merge branch 'master' into LeaderBoardScore_clean
2024-06-07 22:42:49 +03:00
Bartłomiej Dach
86b13074a0
Merge branch 'master' into edit-nodesample
2024-06-06 13:42:25 +02:00
Dean Herbert
091104764e
Fix AssemblyRulesetStore not marking rulesets as available
2024-06-02 17:33:06 +09:00
Dean Herbert
4162d0babe
Merge pull request #28297 from Hecatia-Lapislazuli/near-straight-slider-crash-fix
...
Fix for nearly straight sliders causing a crash
2024-05-31 20:00:47 +09:00
Aurelian
9111da81d2
Updated comments
2024-05-31 08:20:19 +02:00
Bartłomiej Dach
a6c776dac8
Use hopefully safer implementation of anchoring judgements to objects
2024-05-29 11:11:43 +02:00
Aurelian
542809a748
Reduced subpoints limit to be a more practical value
2024-05-29 09:39:46 +02:00
Aurelian
6c4def1c09
Added check for infinite subpoints for PerfectCurve
2024-05-27 20:32:18 +02:00
Dean Herbert
740a3377fa
Merge branch 'master' into LeaderBoardScore_clean
2024-05-27 17:18:41 +09:00
Dean Herbert
11c3d11db9
Fix cinema mod not hiding playfield skin layer
2024-05-27 14:52:28 +09:00
Salman Ahmed
5955378004
Replace "X mods" text with a pill indicator
2024-05-25 16:11:24 +03:00
Aurelian
b2c4e0e951
Reworked linear line check, and optimized scaled flat slider test
2024-05-24 14:05:56 +02:00
Aurelian
fff52be59a
Addressed code quality issues
2024-05-24 09:30:24 +02:00
Aurelian
d948e0fc5c
Nearly straight sliders are treated as linear
2024-05-24 08:26:17 +02:00
Dean Herbert
d0b1ebff5a
Revert "Temporary rollback of framework / SDL3"
...
This reverts commit d7d569cf4e
2024-05-22 16:29:39 +08:00
Dean Herbert
d7d569cf4e
Temporary rollback of framework / SDL3
2024-05-21 14:36:16 +08:00
Dean Herbert
a3960bf715
Add inline comment explaining LifetimeEnd set for future visitors
2024-05-15 14:17:28 +08:00
Dean Herbert
cfb2c8272b
Set a rudimentary lifetime end to improve seek performance in scrolling rulesets
2024-05-14 05:02:08 +08:00
apollo-dw
9b60abe486
Merge branch 'ppy:master' into no-combo-scaling
2024-05-11 13:24:16 +01:00
Dean Herbert
a780abb0b4
Merge pull request #27912 from bdach/pre-mod-multiplier-score
...
Store total score without mod multipliers to local database and to replays, and send it on score submission
2024-05-10 22:46:34 +08:00
Dan Balasescu
3b8b56cbcb
Apply required changes after framework masking updates
2024-05-09 20:18:53 +09:00
Bartłomiej Dach
c9414da5d4
Merge branch 'master' into pre-mod-multiplier-score
2024-05-08 13:39:44 +02:00
Bartłomiej Dach
14658824e7
Adjust distance snap grid momentary toggle logic to not hide it on spacing adjust
2024-05-02 14:11:44 +02:00
Bartłomiej Dach
fe9e6168fe
Merge pull request #28050 from peppy/delay-resume-visibility
...
Tweak resume overlay to allow better visibility of hit objects underneath
2024-05-01 15:49:31 +02:00
Dean Herbert
87e814e201
Fix incorrect xmldoc and adjust colour provider to match Player
2024-05-01 20:30:36 +08:00
Dean Herbert
fd3f4a9e7b
Preserve storyboard events when saving a beatmap in the editor
...
Until we have full encoding support for storyboards, this stop-gap
measure ensures that storyboards don't just disappear from existence.
2024-04-30 00:01:56 +08:00
Bartłomiej Dach
cbbf2dd158
Fix DifficultyBindable bound desync between maxValue and CurrentNumber.MaxValue
2024-04-23 18:58:40 +02:00
Bartłomiej Dach
787e60f706
Fix LegacyDrainingHealthProcessor drain rate computation diverging to infinity
2024-04-23 18:57:14 +02:00
Bartłomiej Dach
1f010c4bfd
Merge pull request #27808 from smoogipoo/fix-incorrect-pp-counter
...
Fix gameplay PP counter not matching results screen
2024-04-23 08:43:49 +02:00
Bartłomiej Dach
70a5288a68
Do not attempt to pass files that don't look like audio to BASS
2024-04-22 10:45:09 +02:00
Bartłomiej Dach
78f97d0ec7
Merge branch 'master' into verify-check-incorrect-audio-formats
2024-04-22 10:34:14 +02:00
Bartłomiej Dach
ceeb9b0819
Use explicit reference equality check
2024-04-22 10:27:30 +02:00
Bartłomiej Dach
1bcf835d22
Remove redundant array type specification
2024-04-22 10:25:46 +02:00
Arthur Araujo
49563f4e5b
Use bitwise to check hitsound formats
2024-04-22 04:44:38 -03:00
Arthur Araujo
92b85beff6
Remove ChannelType from messages
2024-04-19 08:01:23 -03:00
Arthur Araujo
68e86b5105
Remove unsued import and add a blankline before yield break;
2024-04-19 07:39:31 -03:00
Arthur Araujo
eac9dededf
Use periods instead of semicolons
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-04-19 07:20:59 -03:00
Arthur Araujo
ac03856ebd
Fix test methods names
2024-04-17 08:22:05 -03:00
Arthur Araujo
8d94f8d995
Remove BassFlags.Prescan and free the decodeStream
2024-04-17 08:14:19 -03:00
Bartłomiej Dach
e0178802b8
Populate TotalScoreWithoutMods on scores set locally
2024-04-17 08:52:47 +02:00
Arthur Araujo
c32d99250f
Deal with corrupt audio files
...
This removes the corrupt file check from CheckTooShortAudioFiles and makes the audio formats checks deal with it instead to avoid redundant messages.
2024-04-16 06:53:55 -03:00
Arthur Araujo
9ef27104ce
Add checks for audio formats
2024-04-16 06:15:21 -03:00
Dan Balasescu
343b3ba0e6
Don't re-filter unless mods may change the filter
2024-04-15 21:07:36 +09:00
Dan Balasescu
e9b319f4c6
Ensure all remaining objects are added in the last iteration
2024-04-12 00:11:54 +09:00
Dan Balasescu
19cc847be6
Implement a less failure-prone method
2024-04-11 23:40:40 +09:00
Dan Balasescu
f5555b9fa4
Also add potentially missed intermediate parents
2024-04-11 16:53:08 +09:00
Bartłomiej Dach
518addf323
Merge branch 'master' into fix-catmull-bulbs
2024-04-10 11:25:02 +02:00
Dan Balasescu
fefcd17db9
Fix gameplay PP counter not matching results screen
2024-04-08 22:34:11 +09:00
Bartłomiej Dach
cb82fb0487
Merge branch 'master' into mania-key-count-mod-query
2024-04-03 09:29:32 +02:00
Dean Herbert
94cbe1838f
Replace usages of is null with == null
2024-04-03 01:50:39 +08:00
Dean Herbert
51e9348d27
Merge pull request #26702 from honguyenminh/fix-rotate-editor-button-disabled
...
Fix rotate tool button in editor disabled when selecting 1 circle
2024-04-02 14:31:43 +08:00
Dan Balasescu
4806ea54f1
Only optimise Catmull segments in osu ruleset
2024-04-01 17:22:50 +09:00
Dean Herbert
95b50576bd
Merge pull request #27698 from bdach/banish-rulesets-that-do-stupid-crap-to-the-BLAGOLE
...
Attempt to disable custom rulesets that can be linked to an unhandled crash
2024-04-01 15:47:47 +08:00
Nguyên Minh Hồ
6f782266b5
Fix inspection
2024-03-30 17:28:57 +07:00
Nguyên Minh Hồ
5d497ba4a8
Simplify TooltipText for EditorRadioButton
2024-03-30 16:04:22 +07:00
Nguyên Minh Hồ
113dbcd10f
Merge branch 'master' into fix-rotate-editor-button-disabled
2024-03-30 13:56:31 +07:00
Dan Balasescu
9fd6449fd8
Add mods to FilterCriteria, pass to ruleset method
2024-03-28 23:03:26 +09:00
Dan Balasescu
10edb54614
Add ability to query key count with mods
2024-03-28 22:51:12 +09:00
Dan Balasescu
5febd40bd9
Add HP and AR to LegacyBeatmapConversionDifficultyInfo
2024-03-28 22:30:39 +09:00
Dan Balasescu
600098d845
Fix bulbs on Catmull sliders
2024-03-27 04:05:04 +09:00
Bartłomiej Dach
b74f8dba41
Merge branch 'master' into verify-abnormal-difficulty-settings
2024-03-26 11:13:16 +01:00
Bartłomiej Dach
1866b4b6b1
Refactor abstract check to reduce duplication
2024-03-26 11:13:03 +01:00
Bartłomiej Dach
4979305b2d
Ensure TryDisableCustomRulesetsCausing() never actually crashes itself
2024-03-25 11:34:29 +01:00
Arthur Araujo
8a05fecad5
Fix formatting issue
2024-03-23 23:28:55 -03:00
Arthur Araujo
6fbe1a5b8d
Add video resolution check
2024-03-23 19:22:47 -03:00
Bartłomiej Dach
c7c0330265
Attempt to disable rulesets that can be linked to an unhandled crash
2024-03-22 19:05:58 +01:00
Arthur Araujo
a4822fd615
Make CheckAbnormalDifficultySettings abstract
2024-03-22 01:37:06 -03:00
Salman Ahmed
1efa08a1b8
Merge branch 'master' into convert-path-string-new
2024-03-22 05:15:04 +03:00
Bartłomiej Dach
3e764ae4f0
Merge pull request #27639 from 64ArthurAraujo/verify-unused-audio-at-end
...
Add verify checks to unused audio at the end
2024-03-21 12:19:53 +01:00
Bartłomiej Dach
983385bafc
Merge pull request #27677 from smoogipoo/fix-catch-banana-fail
...
Fix catch banana shower judgement causing fail when at 0 HP
2024-03-21 11:23:51 +01:00
Arthur Araujo
b132734f9c
Fix codefactor issues
2024-03-20 18:54:38 -03:00
Arthur Araujo
c605e463a4
Add mania keycount check
2024-03-20 15:52:16 -03:00
Arthur Araujo
4904c49c38
Add abnormal difficulty settings checks
2024-03-20 09:31:58 -03:00
Dan Balasescu
c78e203df5
Fix infinite health processor loop when no top-level objects
...
This is unlikely to occur in actual gameplay, but occurs in the
follow-up test.
2024-03-20 17:30:37 +09:00
Bartłomiej Dach
2b83e6bc4c
Fix check crash on empty beatmap
2024-03-19 19:17:22 +01:00
Salman Ahmed
bbdcb38f5d
Merge branch 'master' into convert-path-string-new
2024-03-19 02:51:24 +03:00
Salman Ahmed
a8ce6a0bba
Use Slice method instead of index range operators for readability
2024-03-19 02:43:36 +03:00
Arthur Araujo
5241c999c1
Add different warning to maps with storyboard/video
2024-03-18 16:08:41 -03:00
Arthur Araujo
c23212f4ef
Use GetLastObjectTime to calculate mapped length
2024-03-18 14:02:33 -03:00
Arthur Araujo
915a9682b5
Fix issue type and display percentage left
2024-03-18 13:51:36 -03:00
Arthur Araujo
a3f3dcf853
Inline percentage calculation
2024-03-18 13:27:43 -03:00
Arthur Araujo
f7aff76592
Fix codefactor issues
2024-03-16 23:03:06 -03:00
Arthur Araujo
63816adbc0
Add verify checks to unused audio at the end
2024-03-16 21:20:12 -03:00
Dan Balasescu
0beaa8e8c5
Merge branch 'master' into tcm-resume
2024-03-14 12:22:46 +09:00
Bartłomiej Dach
20c760835a
Fix audio in video check crashing on unexpected failures
2024-03-13 13:55:49 +01:00
nathen
8a26cdaaab
Merge master
2024-03-09 22:33:13 -05:00
Bartłomiej Dach
44d0dc6113
Fix 1px flashlight gaps when gameplay scaling mode is active
...
Closes https://github.com/ppy/osu/issues/27522 .
Concerns mostly taiko and catch.
Not much of a proper fix rather than a workaround but it is what it is.
I tried a few other things, including setting `MaskingSmoothness = 0` on
the scaling container itself, to no avail.
2024-03-08 11:07:30 +01:00
Bartłomiej Dach
3d8fdc52a4
Merge pull request #27501 from turbedi/throw_helper
...
Use ThrowHelper methods in more places
2024-03-07 11:36:21 +01:00
Dean Herbert
65ce4ca390
Never set waitingOnFrames if a replay is not attached
2024-03-06 04:37:11 +08:00
Berkan Diler
a891303484
Use ArgumentOutOfRangeException throw helper methods
2024-03-05 10:20:30 +01:00
Berkan Diler
9bac60a98f
Use ArgumentNullException.ThrowIfNull in more places
2024-03-05 10:19:47 +01:00
Dan Balasescu
bce3bd55e5
Fix catch by moving cursor-specific handling local
2024-03-04 16:08:17 +09:00
Dan Balasescu
5bd037fe8f
Merge branch 'master' into catch-fail-on-banana
2024-03-04 13:13:26 +09:00
Dean Herbert
19ed78eef5
Log backwards seeks to sentry
2024-03-01 12:40:05 +08:00
Dean Herbert
cc8b838bd4
Add comprehensive log output to help figure out problematic clocks
2024-02-29 23:05:28 +08:00
Dean Herbert
4184a5c1ef
Add flag to allow backwards seeks in tests
2024-02-29 23:05:28 +08:00
Huo Yaoyuan
a11e63b184
Make the code more clear
2024-02-29 20:02:04 +08:00
Dean Herbert
3a780e2b67
Add logging when workaround is hit
2024-02-29 18:27:50 +08:00
Dean Herbert
3355764a68
"Fix" tests
2024-02-29 18:21:44 +08:00
Dean Herbert
76e8aee9cc
Disallow backwards seeks during frame stable operation when a replay is not attached
2024-02-29 14:15:32 +08:00
Huo Yaoyuan
f28f19ed7e
Fix method indent size
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2024-02-29 10:47:16 +08:00
Huo Yaoyuan
e86ebd6cdb
Fix formatting
2024-02-29 00:24:24 +08:00
Huo Yaoyuan
470d2be2e1
The overhead of LINQ is not ignorable
2024-02-29 00:07:00 +08:00
Huo Yaoyuan
bcb91f348d
Use ArrayPool instead of stackalloc
2024-02-28 22:51:36 +08:00
Huo Yaoyuan
fe34577ee2
Update parsing.
2024-02-28 22:42:08 +08:00
Huo Yaoyuan
4bff54d35d
Add ToString on PathControlPoint for debugging
2024-02-28 22:37:14 +08:00
Huo Yaoyuan
f49aa4d815
Parse points and segments for path string
2024-02-28 22:01:39 +08:00
Bartłomiej Dach
46ec477191
Merge pull request #27386 from peppy/fix-use-current-distance-snap
...
Fix "Use current" snap not working
2024-02-26 12:30:35 +01:00
Bartłomiej Dach
353485a707
Merge branch 'master' into flashlight-playfield-based-size-
2024-02-26 10:55:06 +01:00
Bartłomiej Dach
115d82664b
Assert proportional scaling rather than assume average
...
Because if scaling is ever actually non-proportional then this should be
somewhat loud.
Also use the absolute value to prevent funny things happening if/when
someone does negative scale.
2024-02-26 10:53:04 +01:00
Dean Herbert
9a46e738bd
Fix inspections
2024-02-26 15:45:29 +08:00
Dean Herbert
4c744ccb69
Fix "Use current" snap not working
...
Regressed with https://github.com/ppy/osu/pull/27249 .
I was suspicious of this specific operation at the time but didn't test properly.
2024-02-26 14:11:54 +08:00
Andrei Zavatski
9e3defebda
Remove unused using
2024-02-25 19:05:40 +03:00
Andrei Zavatski
c3fa97d062
Reduce allocations in HitObjectLifetimeEntry
2024-02-25 18:02:42 +03:00
Dean Herbert
e8d2abc4f7
Merge pull request #27364 from EVAST9919/spinner-alloc
...
Reduce osu spinner allocations
2024-02-25 09:36:02 +08:00
Andrei Zavatski
1fb19e7129
Reduce allocations in DrawableSpinner
2024-02-24 20:18:30 +03:00
Dan Balasescu
006416057b
Merge pull request #27144 from cdwcgt/allow-muted-ranked
...
Allow pp for muted mod for any combination of settings
2024-02-25 00:31:37 +09:00
Andrei Zavatski
c758640311
Reduce allocations in ComposerDistanceSnapProvider
2024-02-19 20:49:56 +03:00
Dean Herbert
4d4d69521f
Merge pull request #27114 from EVAST9919/judgements-rework
...
Cache created judgement in `HitObject`
2024-02-18 18:07:58 +08:00
Dean Herbert
9655e8c48a
Adjust xmldoc slightly
2024-02-18 17:54:29 +08:00
Andrei Zavatski
22f5a66c02
Reduce allocations during beatmap selection
2024-02-17 15:46:38 +03:00
