Dean Herbert
51bd83b3f4
Update override matching test to match expectations
2021-07-09 13:30:14 +09:00
Dean Herbert
9786e1a932
Ensure run-from-screen song select reaches correct point in execution
...
Fixes issues as seen at
https://github.com/ppy/osu/runs/3023581865?check_suite_focus=true . Song
select may take a few frames to perform initial selection as there is a
bit of internal async logic. This ensures that the beatmap has been
updated before continuing with test execution.
2021-07-09 12:36:56 +09:00
Dean Herbert
7153983dd4
Add test coverage
2021-07-08 18:29:54 +09:00
Dean Herbert
533db01cc0
Add comprehensive tests of difficulty adjust settings
2021-07-08 17:49:00 +09:00
Dean Herbert
a6e94dd491
Add back extended limits support
2021-07-08 17:49:00 +09:00
Dean Herbert
c4313d6e96
Initial implementation of new flow (only working for approach rate)
2021-07-08 17:48:08 +09:00
Dean Herbert
e612d7568c
Merge pull request #13771 from LumpBloom7/volume-meter-switch
...
Add ability to navigate between volume meters via Alt+Left/Right arrows
2021-07-07 21:50:44 +09:00
Dean Herbert
83283a706e
Add test scene
2021-07-07 20:51:13 +09:00
Dean Herbert
f7dc689832
Merge pull request #13804 from bdach/migrate-directory-selector
...
Migrate file/directory selectors to use framework component instead of local implementation
2021-07-07 20:10:26 +09:00
Dan Balasescu
09a5516cc6
Merge pull request #13811 from smoogipoo/remove-unused-using
...
Remove unused usings
2021-07-07 16:30:07 +09:00
Dan Balasescu
066d0a1ef1
Merge branch 'master' into migrate-directory-selector
2021-07-07 15:57:34 +09:00
Dan Balasescu
05c4e0254b
Merge pull request #13796 from peppy/fix-skin-providing-container
...
Rewrite `SkinProvidingContainer`
2021-07-07 15:43:24 +09:00
smoogipoo
faf95c7161
Remove unused usings
2021-07-07 15:35:14 +09:00
Dan Balasescu
34a867a335
Merge branch 'master' into fix-skin-providing-container
2021-07-07 15:00:35 +09:00
Dean Herbert
35672f372a
Shorten test beatmap to avoid timeouts in score submission test
2021-07-07 14:58:01 +09:00
Bartłomiej Dach
f45418dde7
Replace game-side directory/file selector with framework extensions
2021-07-06 22:11:54 +02:00
Derrick Timmermans
4451598bcf
Fix remaining quality complaints
2021-07-06 15:17:19 +02:00
Derrick Timmermans
ffe18ebe51
Resolve build errors
2021-07-06 14:11:46 +02:00
smoogipoo
6bc0020825
Fix intermittent spectate button test failures
2021-07-06 20:28:55 +09:00
smoogipoo
b209868d96
Fix another potential failure
2021-07-06 17:57:24 +09:00
smoogipoo
8b12ec9586
Fix intermittent ready button test failures
2021-07-06 17:52:27 +09:00
Dean Herbert
d75d67577a
Fix regressed tests
2021-07-06 17:37:34 +09:00
Dan Balasescu
32e6c9c5d3
Merge pull request #13786 from peppy/multiplayer-test-fixes
...
Fix multiplayer test failures due to leaderboard load process
2021-07-06 16:33:41 +09:00
Derrick Timmermans
d495196b66
Share item cycling logic with GameplayMenuOverlay
2021-07-05 19:22:55 +02:00
PercyDan54
e1c646b9b2
Remove redundant arguments
2021-07-05 23:52:39 +08:00
Dean Herbert
10e7c846e5
Add local UserLookupCache to avoid online requests being fired from multiplayer tests
2021-07-05 19:41:00 +09:00
Dean Herbert
9c2fed4806
Move setup steps to SetUpSteps and add empty test case
2021-07-05 19:10:27 +09:00
Henry Lin
3c37140426
Remove an unused local variable
2021-07-05 09:52:13 +08:00
Henry Lin
bfb603cfeb
Change the test for unimplemented mod to use a mock ruleset and mod
2021-07-05 09:51:24 +08:00
Bartłomiej Dach
c143a50b73
Merge branch 'master' into fix-zero-hit-score-submit
2021-07-04 15:31:38 +02:00
Bartłomiej Dach
19f02dc3d9
Ensure tests with no token have at least one hit
...
Because submission can be prevented by both not having been issued a
correct submission token, and by not actually registering any hits in
gameplay, ensure that tests that don't receive a token register at least
one hit, to avoid potentially having test cases that test the "no token"
flow pass erroneously because they never had any hits in the first
place.
2021-07-04 14:34:52 +02:00
Dean Herbert
2a74b1c539
Add test coverage of new scenarios
2021-07-04 17:27:02 +09:00
Dean Herbert
ec71deec51
Remove some mentions of "lazer"
...
I am aware there are more throughout the codebase but intentionally left
the remaining mentioned for one reason or another. The intention here is
to mainly change user-facing versioning to change the positioning of the
"lazer" term (to be where we would expect "cuttingedge" or "beta" to
be).
2021-07-04 12:41:27 +09:00
Dean Herbert
b0f257fa04
Merge pull request #13685 from gagahpangeran/wiki-image-block
...
Fix image overflow in wiki overlay
2021-07-02 20:21:20 +09:00
Dan Balasescu
9eb6ae4d45
Merge pull request #13721 from peppy/submit-on-player-exit
...
Submit scores on player exit
2021-07-02 18:25:26 +09:00
Dean Herbert
4e52aee5a0
Merge branch 'master' into wiki-image-block
2021-07-02 18:19:46 +09:00
Dan Balasescu
211c248692
Merge pull request #13744 from peppy/fix-async-void-calls
...
Fix some incorrectly invoked `async` calls
2021-07-02 18:10:30 +09:00
Dean Herbert
d67fc87dcb
Add some basic testability of external colour setting
2021-07-02 17:24:15 +09:00
Dean Herbert
7b0f970e7d
Fix ongoing operation being begun in an async context
2021-07-02 16:09:02 +09:00
Dean Herbert
f2d9d78455
Fix some incorrectly invoked async calls
2021-07-02 14:43:48 +09:00
Dean Herbert
30467191b2
Remove local handling of NoFail addition
2021-07-02 14:21:48 +09:00
Bartłomiej Dach
434c048d87
Merge branch 'master' into colour-picker
2021-07-02 01:03:00 +02:00
smoogipoo
4c95af4b16
Add star rating range display
2021-07-01 20:35:31 +09:00
Dean Herbert
a6323b7d87
Use APIException
2021-07-01 17:54:59 +09:00
Dean Herbert
74c63e15be
Mark score failed on fail and exit
2021-07-01 17:48:09 +09:00
Dean Herbert
6e8d4e382e
Add test coverage of token failure scenarios
2021-07-01 17:20:40 +09:00
Dean Herbert
397d2491b3
Update test scenes to actually cover submission logic
2021-07-01 16:55:44 +09:00
Dean Herbert
719852435f
Fix intermittent PerformFromScreen test failures due to incorrect screen sequence
...
These tests were manually pushing the `PlayerLoader` / `Player`
instances to `SongSelect`, which bypasses safeties in place which avoid
the exact issue that came up in https://github.com/ppy/osu/runs/2951759236
(see `AllowSelection` flag specifically).
2021-07-01 15:10:29 +09:00
Bartłomiej Dach
583242d96d
Add osu!-styled colour picker control
2021-06-30 23:25:50 +02:00
Dean Herbert
4a54e7cdb8
Add tests covering score preparation flow
2021-06-30 20:23:24 +09:00
smoogipoo
aa7405afa1
Increase number of sent frames to prevent timing issues
2021-06-30 20:16:57 +09:00
Dean Herbert
741ecbb2df
Merge branch 'master' into spectator-start-at-end-2
2021-06-30 15:06:30 +09:00
Dean Herbert
4337577448
Remove unused private methods
2021-06-30 14:31:27 +09:00
Dean Herbert
a019f2cc5c
Merge branch 'master' into rework-multiplayer-test-scenes
2021-06-30 13:49:05 +09:00
Dean Herbert
825181121d
Merge branch 'master' into spectator-start-at-end-2
2021-06-30 01:50:14 +09:00
smoogipoo
331b7237ab
Attempt to fix one more intermittent test failure
2021-06-29 23:02:20 +09:00
smoogipoo
6dd3c6fe93
Make MultiSpectatorScreen and tests more resillient to timing
2021-06-29 22:45:51 +09:00
smoogipoo
1b2d00f796
Trigger successes
2021-06-29 20:13:39 +09:00
smoogipoo
8e04d73b67
Merge branch 'rework-multiplayer-test-scenes' into spectator-start-at-end-2
2021-06-29 17:06:57 +09:00
smoogipoo
bcdf36e77b
Merge branch 'master' into spectator-start-at-end-2
2021-06-29 15:53:58 +09:00
smoogipoo
92fa99700e
Merge branch 'master' into rework-multiplayer-test-scenes
2021-06-29 15:39:59 +09:00
smoogipoo
06beeee4d8
Cleanup match header test
2021-06-29 15:39:01 +09:00
Gagah Pangeran Rosfatiputra
a1fe9df378
add test to check sprite image width
2021-06-29 10:14:51 +07:00
Dan Balasescu
697b07acb1
Merge branch 'master' into fix-beatmap-import-fk-failure
2021-06-29 11:36:31 +09:00
Gagah Pangeran Rosfatiputra
0e29ae037b
add wide image test
2021-06-28 20:50:29 +07:00
Gagah Pangeran Rosfatiputra
ab977d91f0
fix image test not load
...
looks like forgot to change this after `CurrentPath` shenanigan
2021-06-28 20:40:22 +07:00
Dean Herbert
f939e2603a
Merge branch 'master' into localisable-tooltips
2021-06-28 15:29:42 +09:00
Dan Balasescu
9c0840268a
Merge pull request #13598 from JimmyC7834/supporter-only-filter-content
...
Add supporter required placeholder in beatmap listing overlay
2021-06-28 10:27:56 +09:00
Bartłomiej Dach
709e555566
Rename test steps for legibility
2021-06-26 20:27:15 +02:00
Bartłomiej Dach
b7c4fe2052
Rewrite test helpers to also handle clearing filters
2021-06-26 20:25:43 +02:00
Bartłomiej Dach
51888d0d5a
Rename test methods
2021-06-26 20:24:42 +02:00
Bartłomiej Dach
50c27d2635
Update usages of IHasTooltip in line with framework localisation changes
2021-06-25 19:10:04 +02:00
smoogipoo
d035633f95
Load participants list after joining room
2021-06-25 20:56:13 +09:00
smoogipoo
3e5ae7ea58
Don't join room in participants test
2021-06-25 20:44:00 +09:00
smoogipoo
1ed61b9b98
Fix up dependencies class names
2021-06-25 20:11:38 +09:00
smoogipoo
57f2b4f812
Fix incorrect parent class
2021-06-25 20:09:03 +09:00
smoogipoo
04cc390c41
Fix TestSceneMultiplayer resolving the wrong client
2021-06-25 19:16:54 +09:00
smoogipoo
a27a647ae7
Rename RoomDependencies -> OnlinePlayDependencies
2021-06-25 18:07:47 +09:00
smoogipoo
c0d2b41d4c
Move SpectatorClient into multiplayer dependencies
2021-06-25 17:55:16 +09:00
Dean Herbert
51dd7fc238
Merge pull request #13622 from aitani9/mod-settings-dropdown-height
...
Decrease the max dropdown height in mod settings
2021-06-25 17:42:47 +09:00
smoogipoo
7aefbe3da1
Move UserLookupCache inside dependencies
2021-06-25 17:37:02 +09:00
Dean Herbert
5883922177
Remove mod multiplier completely
2021-06-25 16:36:31 +09:00
smoogipoo
d6ab08c958
Remove manual dependencies in TestSceneMultiplayerGameplayLeaderboard
2021-06-25 15:30:28 +09:00
smoogipoo
81a812e216
Rework MultiplayerTestScene to make use of OnlinePlayTestScene
2021-06-25 15:00:10 +09:00
smoogipoo
aa5d22d04a
Remove "test container", make everything go through OnlinePlayTestScene
2021-06-25 13:02:19 +09:00
smoogipoo
8fba7d2423
Remove MultiplayerTestScene inheritance from simple test scenes
2021-06-24 21:02:29 +09:00
smoogipoo
a21cf87b5f
Split room manager and allow overrides
2021-06-24 19:14:05 +09:00
smoogipoo
5115299e9a
Merge RoomManagerTestScene into OnlinePlaySubScreenTestScene
2021-06-24 19:09:31 +09:00
smoogipoo
a7b5c3bed1
Add OnlinePlaySubScreenTestScene
2021-06-24 17:01:28 +09:00
smoogipoo
4af119a407
Re-namespace
2021-06-24 16:29:06 +09:00
smoogipoo
c9ec4b9da4
Remove RoomTestScene inheritance from simple test scenes
2021-06-24 16:02:20 +09:00
Dean Herbert
cd6f175375
Ensure beatmap is reloaded before each playlist room test run
2021-06-24 13:29:06 +09:00
Dean Herbert
1bbfbb0d8e
Fix test that never should have worked
...
This was only working by luck until now. It was "correctly" matching on
null online ID (see logic at
abc96057b2/osu.Game/Screens/OnlinePlay/Match/RoomSubScreen.cs (L199-L207)
2021-06-23 19:30:11 +09:00
Dean Herbert
151dfdfb79
Merge pull request #13627 from Joehuu/fix-multiplayer-exit-logic
...
Fix multiplayer leave dialog not working on all exit operations
2021-06-23 14:56:57 +09:00
Joseph Madamba
dc428da06c
Fix test regression
2021-06-22 19:30:52 -07:00
Joseph Madamba
49000b9501
Add multiplayer leave navigation tests
2021-06-22 19:30:40 -07:00
Salman Ahmed
37f7486fb1
Fix potential null reference in LINQ method
2021-06-22 12:25:29 +03:00
Salman Ahmed
31cbb36a64
Implement FindProvider and AllSources properly on all test ISkinSources
2021-06-22 12:03:14 +03:00
Dean Herbert
0ad189e357
Expose skin sources via ISkinSource and revert to consuming based on hierarchy
2021-06-22 16:19:55 +09:00
Dean Herbert
1b0aadcc6f
Merge branch 'master' into transformers-per-skin
2021-06-22 16:03:15 +09:00
JimmyC7834
0d17fb4259
fixed code
2021-06-22 13:53:21 +08:00
JimmyC7834
b42aedeb81
fixed code style
2021-06-21 14:43:54 +08:00
JimmyC7834
996503eb2d
fixed filter text display, added visual tests
2021-06-20 21:23:54 +08:00
JimmyC7834
e7aeba8d03
added more visual tests
2021-06-20 18:28:43 +08:00
JimmyC7834
42fdfbb9a1
added visual tests
2021-06-20 17:17:07 +08:00
Dean Herbert
c369beeaaa
Merge branch 'master' into realm-key-binding-store
2021-06-18 16:52:35 +09:00
Dean Herbert
246ab41cc6
Remove special casing for user exit during storyboard outro
2021-06-17 18:11:15 +09:00
Dean Herbert
4b45d8318e
Merge branch 'master' into transformers-per-skin
2021-06-16 16:37:28 +09:00
Dean Herbert
66efc3c4de
Merge branch 'master' into realm-key-binding-store
2021-06-16 13:23:13 +09:00
Bartłomiej Dach
30703d518c
Add failing assert for seasonal background equality
2021-06-15 23:19:33 +02:00
Dean Herbert
acc06ca398
Merge branch 'master' into realm-key-binding-store
2021-06-16 02:14:58 +09:00
Dean Herbert
fcb0b8d825
Add test coverage
2021-06-14 15:06:33 +09:00
Dean Herbert
b06477a1f5
Split out tests into individual test methods
2021-06-14 14:35:24 +09:00
Dean Herbert
26312bf60a
Merge branch 'master' into chat-mention
2021-06-11 20:03:44 +09:00
smoogipoo
0a8daab4f7
Pause master clock when too far ahead
2021-06-11 19:15:53 +09:00
smoogipoo
e9ebbd298d
Add a few more tests
2021-06-11 18:13:54 +09:00
Dean Herbert
16e3a19738
Fix notification overlay not being in correct place in test scene
2021-06-11 16:18:51 +09:00
Dean Herbert
f00967388a
Refactor tests a bit
2021-06-11 16:17:42 +09:00
Bartłomiej Dach
417aaacc53
Add test coverage for romanised data transfer
2021-06-10 22:18:39 +02:00
smoogipoo
58d71e4aea
Remove local "next frame" storage
2021-06-10 22:41:38 +09:00
Salman Ahmed
dde84e5cbd
Merge branch 'master' into transformers-per-skin
2021-06-10 11:58:52 +03:00
Dean Herbert
5e80f454ce
Merge branch 'master' into results-screen-sfx
2021-06-10 17:25:35 +09:00
Dean Herbert
9a3ca09501
Merge pull request #13384 from bdach/fixed-label-width
...
Align label widths of editor setup screen controls
2021-06-10 14:55:49 +09:00
Dean Herbert
9044a20120
Merge branch 'master' into realm-key-binding-store
2021-06-10 13:58:08 +09:00
Gagah Pangeran Rosfatiputra
39e1f77d53
add image table with image content test
2021-06-10 09:37:33 +07:00
Dean Herbert
3d508f9266
Merge branch 'master' into results-screen-sfx
2021-06-10 11:28:35 +09:00
Salman Ahmed
6538d44708
Make SkinProvidingContainer able to perform lookup on multiple skins
...
Currently `protected` functionality for use in custom `SkinProvidingContainer`s, can be exposed to public constructors if it need to later on, but I'm not sure about doing that opposed to just nesting multiple `SkinProvidingContainer`.
2021-06-09 22:49:31 +03:00
Salman Ahmed
cf40282f1f
Convert LegacySkinTransformers to accept raw ISkins rather than a full ISkinSource
2021-06-09 22:49:31 +03:00
Bartłomiej Dach
7fe878299f
Merge branch 'master' into wiki-article
2021-06-09 16:24:45 +02:00
Dean Herbert
b02b8ae2bc
Merge pull request #13381 from smoogipoo/improve-hit-error-judgements
...
Improve hit error judgement displays
2021-06-09 19:40:17 +09:00
Dean Herbert
8fda04c2d9
Merge branch 'master' into results-screen-sfx
2021-06-09 18:00:11 +09:00
Bartłomiej Dach
5487012060
Add test coverage for default skin background cycling
2021-06-09 07:48:16 +02:00
Bartłomiej Dach
f628ec25ef
Add test coverage for keeping same background instance
2021-06-08 22:31:09 +02:00
Bartłomiej Dach
d86ace4d11
Add test coverage for skin background source
2021-06-08 22:03:59 +02:00
Bartłomiej Dach
88266eac63
Add option to fix label width of a LabelledDrawable
2021-06-08 16:57:32 +02:00
smoogipoo
c8e14d7710
Ignore non-scorable and bonus judgements
2021-06-08 23:09:23 +09:00
Dean Herbert
25af4dfa8a
Merge pull request #13375 from smoogipoo/fix-multi-nullref
...
Fix possible nullref when exiting song select too fast
2021-06-08 20:47:40 +09:00
smoogipoo
ab9290772b
Fix a similar case with online play sub-screens
2021-06-08 17:54:54 +09:00
Dean Herbert
6017ef3825
Merge branch 'master' into fix-skin-sample-lookup
2021-06-08 17:37:36 +09:00
smoogipoo
490ab9e96a
Fix typo
2021-06-08 17:09:03 +09:00
smoogipoo
7fa0ac6ed7
Fix possible nullref when exiting song select too fast
2021-06-08 17:03:50 +09:00
Dan Balasescu
791855dfa0
Merge branch 'master' into legacy-skin-default-fallback
2021-06-08 16:54:26 +09:00
Dean Herbert
95852ccdf8
Merge branch 'master' into results-screen-sfx
2021-06-08 15:14:31 +09:00
Bartłomiej Dach
1b4771655a
Adjust test scene to avoid cross-test interference
...
* Move steps from ctor to a separate basic test.
* Wait for barrage to complete in basic test, as not doing so polluted
state of other tests.
* Reset score processor after every test.
2021-06-07 13:16:07 +02:00
Bartłomiej Dach
37d062c7cd
Add failing assertions to hit error meter test
2021-06-07 13:16:07 +02:00
Bartłomiej Dach
122a624b7f
Remove bogus CatchHitWindows
...
`CatchHitWindows` were a vestige from the past, and were not actually
used anywhere except for the hit error meter test, giving off an
appearance that the hit error meter was working properly.
`CatchHitObject` actually specifies empty hit windows.
2021-06-07 13:16:07 +02:00
Bartłomiej Dach
b192c46316
Merge branch 'master' into wiki-article
2021-06-07 11:19:20 +02:00
Dean Herbert
729e05241f
Add more test coverage
2021-06-07 17:32:10 +09:00
Dean Herbert
f677f9b5f4
Stop BackgroundScreenDefault from reloading beatmap background when already correct
2021-06-07 17:22:36 +09:00
Dean Herbert
d26c9a66c2
Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup
2021-06-07 12:01:19 +09:00
