vun
122064d03f
Minor refactoring to reduce amount of looping
2022-10-09 07:09:05 +08:00
Dan Balasescu
bce20e0a59
Merge branch 'master' into adjust-flashlight
2022-10-07 14:45:30 +09:00
Dan Balasescu
5f3b58b7e0
Adjust taiko flashlight to closely match classic
2022-10-07 14:44:45 +09:00
Dan Balasescu
234c6ac799
Pin taiko PP calculator accuracy to osu-stable values
2022-10-05 20:21:15 +09:00
vun
47781a8f94
Fix code inspect issues and SR test cases
2022-10-03 17:31:45 +08:00
vun
25976e1f10
Correct xmldocs
2022-10-03 14:20:01 +08:00
vun
c933b62df6
Correct xmldoc
2022-10-03 14:16:53 +08:00
Jay L
6752655b5a
xml, remove speedbonus cap
2022-10-02 16:08:14 +10:00
Jay L
4b562f782f
decrease finger count
2022-10-02 15:28:39 +10:00
Jay L
a276e40033
reintroduce fl bonus to converts
2022-10-02 09:05:58 +10:00
vun
e6093f94df
Apply nerfs to HD/FL bonuses with converts
2022-09-30 20:56:16 +08:00
vun
02092ede64
Refactor previous and next colour change into TaikoDifficultyHitObjectColour
2022-09-30 11:42:48 +08:00
vun
09a38fec94
Implement mono tl nerf for stamina, disable convert specific nerfs
2022-09-30 09:10:56 +08:00
vun
d84c956af9
Refactor to move first-object detection to evaluation
2022-09-29 15:27:26 +08:00
Dan Balasescu
1890a66b28
Merge pull request #20509 from o-dasher/cleanup-setting-sources
...
Removes unnecessary setting sources specifications
2022-09-28 17:55:42 +09:00
Dan Balasescu
cbed268ac9
Merge pull request #20510 from sw1tchbl4d3r/high_bpm_judgements
...
Clamp `LifetimeStart` of `HitObject`s to their judgement windows
2022-09-28 17:49:35 +09:00
sw1tchbl4d3
0cffbb7562
Clamp LifetimeStart
of HitObject
's to their judgement windows
2022-09-27 16:54:24 +02:00
o-dasher
f3e25eacad
Removes unnecessary setting sources specifications
2022-09-27 09:25:58 -04:00
cdwcgt
344015a6e6
do not move timeline when EndPlacement
2022-09-27 20:12:40 +09:00
cdwcgt
9c4ae768f1
show object in timeline before placed
...
just BeginPlacement()
2022-09-27 20:08:32 +09:00
o-dasher
537796c3a1
Cleanup mod bindings
2022-09-25 15:49:22 -04:00
Dean Herbert
c7f8f948b9
Rename CreateLegacySkinProvider
to CreateSkinTransformer
and apply to all skins
2022-09-15 20:18:10 +09:00
andy840119
3d7367a842
Move the CreateConvertibleReplayFrame() into the base ruleset class for avoid api breaking change in the customized ruleset.
2022-09-10 11:07:23 +08:00
andy840119
2f91b5c846
Add missing import.
2022-09-10 10:46:10 +08:00
andy840119
e62999fb16
Merge branch 'master' of https://github.com/ppy/osu into remove-the-nullable-disable-in-the-ruleset
...
# Conflicts:
# osu.Game.Rulesets.Catch/CatchRuleset.cs
# osu.Game.Rulesets.Osu/OsuRuleset.cs
# osu.Game.Rulesets.Taiko/TaikoRuleset.cs
# osu.Game/Rulesets/Ruleset.cs
2022-09-10 10:40:12 +08:00
Dan Balasescu
a2f8ff825e
Also ignore drum roll strong judgement
2022-09-06 23:26:25 +09:00
Dan Balasescu
792b410c04
Merge branch 'master' into classic_drumrolls
2022-09-06 16:29:45 +09:00
Salman Ahmed
ff4a051c05
Merge branch 'master' into remove-dispose-updates
2022-09-03 16:14:50 +03:00
Dan Balasescu
9645bfe708
Bump difficulty calculator versions
2022-09-02 16:27:25 +09:00
Dean Herbert
6a35b233e5
Merge branch 'master' into remove-dispose-updates
2022-09-01 23:03:19 +09:00
sw1tchbl4d3
a9aa928ce6
Fix test, make strong hits have LargeBonus judgement
2022-08-30 15:00:46 +02:00
sw1tchbl4d3
b185194d07
Apply comments by smoogi
2022-08-30 14:44:44 +02:00
Dan Balasescu
e3e204001e
Merge pull request #19907 from peppy/ruleset-api-versioning
...
Add ruleset API versioning
2022-08-29 18:50:01 +09:00
Dean Herbert
a215d009fe
Update Remove
/RemoveRange
/RemoveAll
calls in line with framework changes
2022-08-29 15:57:40 +09:00
Dean Herbert
90b9c02ac6
Remove "internal"
identifier as unnecessary
2022-08-29 14:01:15 +09:00
Dan Balasescu
85705d97a5
Merge pull request #19853 from Lawtrohux/pp-rescale-effective-misses
...
osu!taiko performance point adjustments & effective misses
2022-08-25 14:43:03 +09:00
Dan Balasescu
8eab36f8c9
Actually fix possible NaN value
2022-08-25 14:02:10 +09:00
Dan Balasescu
136dcee3b5
Merge pull request #19571 from vunyunt/colour-encoding-2
...
Rewrite of the colour skill & refactoring of difficulty calculation within osu!taiko
2022-08-25 13:56:50 +09:00
vun
fb9bb2d42d
Declare Parent as non-nullable
2022-08-24 08:57:13 +08:00
Jay L
3acbcac4d1
fix NaN PP on 0 object count
2022-08-22 19:45:51 +10:00
Dean Herbert
f5710d8000
Add ruleset API versioning
2022-08-22 16:35:08 +09:00
naoei
9386d352b8
Make StatisticItem.Name not nullable
2022-08-20 21:48:35 -04:00
Nao
189a407cb1
Merge branch 'master' into ruleset-localization
2022-08-20 21:39:10 -04:00
Jay L
c1da509119
round numerical value
...
this is painfully annoying me
2022-08-19 23:23:40 +10:00
Jay L
faf143b11a
fix comment
2022-08-19 23:15:38 +10:00
Jay L
b30fba1430
emc attribute
2022-08-19 22:57:40 +10:00
Jay L
fea31cc895
introduce effective misscount, accuracy rescale
2022-08-19 22:57:28 +10:00
vun
f3e1287f04
Remove redundant using statement
2022-08-19 16:19:45 +08:00
vun
684efefb50
Add FirstHitObject as a property of encoding classes
2022-08-19 16:13:36 +08:00
vun
a26de0a10f
Add HitType property to MonoStreak
2022-08-19 16:05:34 +08:00
vun
51176e9577
Naming changes
2022-08-19 15:45:43 +08:00
vun
5dcd4ce7c5
Naming changes
2022-08-19 15:31:03 +08:00
Dan Balasescu
c4dee1cf6d
Merge pull request #19832 from peppy/fix-taiko-span-blueprint-overlay
...
Fix taiko blueprints displaying incorrectly for drum rolls
2022-08-18 17:57:14 +09:00
Dean Herbert
ad28bfc9b2
Fix taiko blueprints displaying incorrectly for drum rolls
2022-08-18 17:18:11 +09:00
Dean Herbert
48fac9f8a5
Fix taiko drum rolls with zero length being placeable in editor
...
Addresses https://github.com/ppy/osu/discussions/19808 .
2022-08-18 16:50:36 +09:00
vun
40b1554fea
Change FindRepetitionInterval to start with one previous encoding
2022-08-18 14:12:03 +08:00
Dan Balasescu
8e0049c005
Add back null check
2022-08-15 21:57:41 +09:00
Dan Balasescu
c03e47317a
Fix notes not being added to list
2022-08-15 21:56:03 +09:00
Dan Balasescu
4d4ee05981
Whoops I meant to remove these
2022-08-15 21:56:03 +09:00
Dan Balasescu
78283ce3c5
Remove TaikoDifficultyPreprocessor
2022-08-15 21:43:09 +09:00
Dan Balasescu
21d2998032
Privatise internals of TaikoColourDifficultyPreprocessor
2022-08-15 21:35:57 +09:00
Dan Balasescu
94c6beeaf7
Use ctor in a place that looks visually weird
...
I read through this thinking "why doesn't Previous get assigned to
currentEncoding here? But it's because the initializer runs right after
the ctor and before the "method" returns. So really there's 3 operations
running on one line here - ctor, init, and assignment.
2022-08-15 21:30:46 +09:00
Dan Balasescu
502e31dd37
General refactoring
2022-08-15 21:26:54 +09:00
Dan Balasescu
d686e841c5
Merge branch 'master' into colour-encoding-2
2022-08-15 20:56:50 +09:00
naoei
45e9eda9e7
Localise hit result name
2022-08-14 14:57:02 -04:00
naoei
18ce784ae0
Allow StatisticItem's name param to be nullable
2022-08-14 14:51:35 -04:00
naoei
3e38baca3c
Change ruleset mod description types
2022-08-10 16:09:11 -04:00
sw1tchbl4d3
e0426836c1
Make swells and drumrolls optional by default
2022-08-05 16:30:07 +02:00
Justin
e6761ef6b1
Merge branch 'master' into classic_drumrolls
2022-08-05 12:17:44 +00:00
Dan Balasescu
b4e55f7309
Apply IRenderer changes
2022-08-02 19:50:57 +09:00
andy840119
eb73f9e88c
Remove un-need using.
2022-08-02 10:23:52 +08:00
andy840119
b1d320bf67
Use non-nullable instead in the taiko ruleset.
2022-08-02 00:48:23 +08:00
Salman Ahmed
b32ff68a95
Enable NRT on taiko legacy skin transformer and tests
2022-07-30 09:43:51 +03:00
Salman Ahmed
0940e703b3
Fix normal skin hitsounds prioritised over default taiko hitsounds
2022-07-30 09:15:28 +03:00
Salman Ahmed
e0107fc3dc
Use RequiredParentSizeToFit
to handle misc geometry changes
2022-07-29 21:11:43 +03:00
NaiPofo
4e32d510c3
Invalidate flashlightProperties on DrawInfo
2022-07-29 20:08:32 +02:00
為什麼
860e9d42ff
Mark the property as nullable and add some assert check.
2022-07-27 22:31:48 +08:00
為什麼
d766052be4
Remove nullable disable annotation in the Taiko ruleset.
2022-07-27 22:28:13 +08:00
sw1tchbl4d3
0a0f3c93dd
Rename OkResult, rephrase "strong bonus"
2022-07-24 20:55:13 +02:00
Justin
a4f3a0d201
Merge branch 'master' into classic_drumrolls
2022-07-24 18:33:04 +00:00
Dan Balasescu
27ec8f3ae6
Merge pull request #17200 from hongaaronc/master
...
Add basic touch support for osu!taiko
2022-07-22 20:58:42 +09:00
Dean Herbert
7baa1a7e85
Attempt to fix crashing from weird input interactions
2022-07-22 20:19:13 +09:00
vun
fc08d77090
Remove review-specific comment
2022-07-22 18:31:59 +08:00
vun
7d4593eb6d
Fix comments
2022-07-22 18:20:35 +08:00
Dean Herbert
ee5e27638e
Fix method name not matching actual implementation
2022-07-22 18:19:33 +09:00
Dean Herbert
9e5e03af5d
Adjust colours to match default skin for now
2022-07-22 18:16:01 +09:00
Dean Herbert
ec98693cca
Add back standard mouse bindings support and only handle mouse when inside the visible zone
2022-07-22 18:09:19 +09:00
Dean Herbert
4279ac866c
Tidy up unnecessary changes and remove unused classes
2022-07-22 17:58:52 +09:00
Dean Herbert
2d2d98ab6e
Add final design pass
2022-07-22 17:53:25 +09:00
vun
17d418d319
Merge remote-tracking branch 'ppy/master' into colour-encoding-2
2022-07-22 16:31:28 +08:00
vun
6359c1a4fe
Fix outdated comment
2022-07-22 16:31:19 +08:00
Dean Herbert
aeeedc40b4
Add first pass design
2022-07-22 17:17:38 +09:00
Dean Herbert
bd6ff40b43
Combine touch and mouse handling into single path
2022-07-22 17:03:08 +09:00
Dean Herbert
b604eb6262
Simplify implementation
2022-07-22 16:59:09 +09:00
Dean Herbert
7015cf0b1b
Move touch input drum to own file for now
2022-07-22 16:39:26 +09:00
Dean Herbert
c32af3c041
Merge branch 'master' into hongaaronc/master
2022-07-22 15:55:38 +09:00
vun
4433f902ea
Fix and add comments
2022-07-22 10:49:53 +08:00
vun
e4086b058b
Implement stateless colour evaluator and required encoding changes
2022-07-21 19:15:22 +08:00
Dean Herbert
aca19a005e
Add versioning to difficulty calculators
2022-07-21 18:15:25 +09:00
vun
7917a60e3c
Move TaikoDifficultyHitObject creation back to TaikoDifficultyCalculator
2022-07-21 15:45:03 +08:00
Jay L
b7567f7db2
Share sigmoid, Fix Preprocessor XML
2022-07-21 10:52:41 +10:00
Jay L
08dd9c79db
Fix Convert-related nerf
...
This addresses recent player unsatisfaction with converts being underweighted.
2022-07-21 09:55:19 +10:00
Jay L
cb63ec282e
Partial Review changes
2022-07-20 23:33:38 +10:00
Dan Balasescu
7dfc18a0e3
Merge pull request #19208 from frenzibyte/remove-score-multiplier-on-custom-mod-settings
...
Remove score multiplier on difficulty-increasing mods with customised settings
2022-07-20 20:12:59 +09:00
Dean Herbert
f6e46da117
Merge branch 'master' into taiko-target-classic-position
2022-07-20 19:09:57 +09:00
Salman Ahmed
4210ec6502
Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings
2022-07-19 19:21:26 +03:00
Dan Balasescu
471e1b935d
Merge pull request #19181 from taiko-pp-committee/performance-balancing-merge
...
osu!taiko performance points balancing
2022-07-19 21:01:12 +09:00
Salman Ahmed
1051009827
Change bindable properties in all HitObject
s to be lazily initialised
2022-07-19 05:39:10 +03:00
Salman Ahmed
28150dc15d
Merge branch 'master' into taiko-target-classic-position
2022-07-18 20:45:29 +03:00
Salman Ahmed
32ba58109b
Remove score multiplier on difficulty-increasing mods with customised settings
2022-07-18 07:29:03 +03:00
Jay L
e82e11ead5
Fix SpeedBonus xml
2022-07-17 14:56:07 +10:00
Jay L
5532f56a30
performance points balancing
2022-07-17 14:10:49 +10:00
vun
a66fd87274
Fix speed bonus comment
2022-07-16 19:48:29 +08:00
vun
8beb5568b8
Fix speed bonus
2022-07-16 19:45:35 +08:00
Jay L
8a17b509d9
Increase SpeedBonus Cap to 600BPM
2022-07-16 21:20:25 +10:00
vunyunt
9994f13031
Merge branch 'ppy:master' into colour-encoding-2
2022-07-15 21:19:49 +08:00
Jay L
c8b7902a63
Reintroduce Convert Nerf, Rescale Multiplier
2022-07-15 22:10:20 +10:00
Jay L
7e3f62a5a5
Codequality parse
2022-07-15 21:07:01 +10:00
vun
45c055bfa1
Move rhythm preprocessing to its own folder
2022-07-14 17:25:21 +08:00
vun
1cb18f8474
Refactor colour encoding to avoid circular dependencies
2022-07-14 16:29:23 +08:00
為什麼
1725a76fa0
Remove the nullable disable annotation for all rulesets.
2022-07-10 10:15:27 +08:00
為什麼
857377e145
Move CreateConvertibleReplayFrame() into legacy ruleset interface because technically only legacy ruleset use it to convert the legacy frame.
...
But seems some of the customized ruleset use it for save the replay frame.
2022-07-10 10:15:27 +08:00
vun
6660379a0e
TAIKO-6 Tweak encoding and parameters, reduce rhythm weight
2022-07-07 16:04:46 +08:00
vun
f6dedc77fb
Fixed encoding logic, parameter adjustments
2022-07-05 17:01:11 +08:00
vun
505a24a68e
Implement new colour encoding and evaluator
2022-07-05 14:41:40 +08:00
andy840119
0a1543c6e8
Use AsNonNull()
instead.
2022-07-02 19:48:32 +08:00
andy840119
59c83a3423
Mark as non-null because next object in here will always has value.
2022-07-02 13:33:51 +08:00
andy840119
19721a9bbb
Remove the nullable disable annotation and fix the breaking api.
2022-07-02 13:33:05 +08:00
vun
5f8d21f33d
Per encoding evaluation
2022-07-01 14:27:23 +08:00
vun
cba47f8202
[WIP] Colour evaluator for new colour encoding
2022-06-28 10:38:58 +08:00
Dan Balasescu
0fd2c010e5
Remove NRT disables from attributes classes
2022-06-27 16:07:15 +09:00
Dan Balasescu
0579780bb8
Add IBeatmapOnlineInfo parameter and use to extract more data
2022-06-27 16:07:15 +09:00
vunyunt
55e5b41c03
Merge branch 'ppy:master' into colour-encoding-2
2022-06-25 22:50:06 +08:00
vun
8c162585b8
Comment out logging for debugging purposes
2022-06-25 22:49:19 +08:00
vun
15372267e1
Implement new colour encoding
2022-06-25 22:42:56 +08:00
Dean Herbert
31a447fda0
Update parameter discards
2022-06-24 21:26:19 +09:00
Bartłomiej Dach
3497e966fd
Revert no longer needed access modifier change
2022-06-24 13:01:16 +02:00
Bartłomiej Dach
f47b74a938
Move OkResult
from drawable swell to judgement
2022-06-24 13:00:12 +02:00
Bartłomiej Dach
bcb9cba2d7
Reorder classes for legibility, group into regions
2022-06-24 12:56:47 +02:00
Bartłomiej Dach
52de8bae9b
Apply NRT to TaikoModClassic
2022-06-24 12:54:33 +02:00
Bartłomiej Dach
26c5b59f6d
Replace usages of string.To{Lower,Upper}()
2022-06-24 11:57:45 +02:00
vun
f42aac9954
TAIKO-6 Pre-evaluate colour to avoid per-note evaluation
2022-06-23 17:10:30 +08:00
vun
c5fd48372b
Flatten speed bonus for stamina
2022-06-22 17:17:19 +08:00
sw1tchbl4d3
6c8042642a
Reduce code duplication
2022-06-20 17:22:41 +02:00
sw1tchbl4d3
98527fec26
Make mod selfcontained
2022-06-19 15:11:12 +02:00
vun
3529514587
Disablle nullable in TaikoDifficultyHitObjectColour
2022-06-19 17:26:11 +08:00
vun
57964311be
Revert performance calculator to upstream
2022-06-19 17:20:53 +08:00
vun
95c43d9384
Merge remote-tracking branch 'ppy/master' into colour-rework
2022-06-19 17:18:05 +08:00
vun
da1d99d5b6
Parameter tweaks, change repetition interval definition
2022-06-19 17:14:31 +08:00
sw1tchbl4d3
a5bf16e873
Make drum rolls and swells optional with Classic
mod
2022-06-19 02:10:23 +02:00