Vinicius Barbosa
|
06fffc499b
|
Removed unused variables and directives
|
2021-05-18 16:56:07 +02:00 |
|
Vinicius Barbosa
|
76a377f3e0
|
Fixed applause sound stopping after switching scores
|
2021-05-18 15:30:45 +02:00 |
|
Lucas A
|
775e0fbde5
|
Mark StableImportManager as nullable.
|
2021-05-18 15:27:20 +02:00 |
|
Dean Herbert
|
41d8bc291c
|
Merge pull request #12783 from smoogipoo/hoc-event-queue
Add a HitObjectUsageEventBuffer to handle HOC events appropriately
|
2021-05-18 22:22:53 +09:00 |
|
smoogipoo
|
c6160d5304
|
Only ignore online score id for database import
|
2021-05-18 21:17:41 +09:00 |
|
smoogipoo
|
d93ac7ac98
|
Change class xmldoc a bit
|
2021-05-18 19:15:46 +09:00 |
|
smoogipoo
|
ab6a79f84c
|
Simplify
|
2021-05-18 19:15:46 +09:00 |
|
smoogipoo
|
97f4f7bbd1
|
Remove Component inheritance
|
2021-05-18 18:59:45 +09:00 |
|
smoogipoo
|
633f841a0f
|
Rename to HitObjectUsageEventBuffer
|
2021-05-18 18:57:02 +09:00 |
|
smoogipoo
|
bfc0205e9b
|
Fix (began, finished) event
|
2021-05-18 18:49:11 +09:00 |
|
Dean Herbert
|
d661e98fa6
|
Move common functionality out of OsuSelectionHandler and implement flip support
|
2021-05-18 18:34:06 +09:00 |
|
smoogipoo
|
61a41d97a4
|
Add some xmldocs + comments
|
2021-05-18 17:39:45 +09:00 |
|
Dean Herbert
|
ed957df162
|
Add simple xmldoc to TransferBlueprintFor method
|
2021-05-18 16:40:56 +09:00 |
|
Dean Herbert
|
55cc533a37
|
Merge branch 'master' into hoc-event-queue
|
2021-05-18 16:31:20 +09:00 |
|
Dean Herbert
|
a96603f025
|
Merge pull request #12782 from smoogipoo/rework-hitobject-blueprints
Rename hitobject blueprints and tie them to HitObjects
|
2021-05-18 16:30:58 +09:00 |
|
Dean Herbert
|
10c730b37d
|
Add new default locations for hit bar error displays
|
2021-05-18 15:50:50 +09:00 |
|
Dean Herbert
|
829d326e36
|
Remove alignment logic completely for the time being
This was overly complex and does not play well with the new layout
customisation system. We can add it back as required.
|
2021-05-18 14:55:34 +09:00 |
|
smoogipoo
|
75c0d4d972
|
Merge branch 'rework-hitobject-blueprints' into hoc-event-queue
|
2021-05-18 14:33:52 +09:00 |
|
smoogipoo
|
882d54a8f8
|
Remove now unnecessary Apply() method
|
2021-05-18 14:26:26 +09:00 |
|
smoogipoo
|
e621cfc4ea
|
Add Apply() method for applying new DHOs
|
2021-05-18 14:14:10 +09:00 |
|
smoogipoo
|
f1f3606fd0
|
Fix unresolved xmldocs
|
2021-05-18 13:11:58 +09:00 |
|
Dan Balasescu
|
9d423245d8
|
Fix up xmldocs
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
|
2021-05-18 13:02:23 +09:00 |
|
Lucas A
|
79740dd2d8
|
Merge conditionnal expression.
|
2021-05-17 22:01:05 +02:00 |
|
Dan Balasescu
|
ea4dfd3374
|
Merge pull request #12842 from peppy/song-progress-skinnable
Add layout customisation support for `SongProgress`
|
2021-05-17 20:15:01 +09:00 |
|
Lucas A
|
fe11426238
|
Disable appearance of the stable import prompt waiting for user interaction in tests, which caused them to fail.
|
2021-05-17 12:55:59 +02:00 |
|
Lucas A
|
f60dbbfbbd
|
Reword import dialogs.
Co-authored-by: Dean Herbert <pe@ppy.sh>
|
2021-05-17 12:55:58 +02:00 |
|
Lucas A
|
a7b740fd1d
|
Reword ImportFromStablePopup and display the popup regardless of whether a stable install is detected.
|
2021-05-17 12:55:58 +02:00 |
|
Lucas A
|
851e33fd15
|
Hook up StableImportManager.
|
2021-05-17 12:55:57 +02:00 |
|
Dean Herbert
|
7137315fa7
|
Remove HitErrorDisplay container and hook up data
|
2021-05-17 19:46:50 +09:00 |
|
Dean Herbert
|
ecf70c1707
|
Remove unnecessary container
|
2021-05-17 18:55:18 +09:00 |
|
Dean Herbert
|
b80768b44a
|
Hook up seeking flow
|
2021-05-17 18:52:56 +09:00 |
|
Dean Herbert
|
0c433cda86
|
Update HUDOverlay logic to add automatic layout for bottom-aligned components
|
2021-05-17 18:52:56 +09:00 |
|
Dean Herbert
|
da0913ca2d
|
Make SongProgress a skinnable component
|
2021-05-17 18:52:56 +09:00 |
|
Dan Balasescu
|
4151f18f74
|
Merge pull request #12804 from peppy/fix-autoplay-load-fail-nullref
Fix a potential nullref when starting `Player` with autoplay disabled and beatmap fails to load
|
2021-05-17 18:40:05 +09:00 |
|
Dean Herbert
|
1f3ae901ce
|
Expose DrawableRuleset for consupmtion by HUD components
|
2021-05-17 18:23:01 +09:00 |
|
Dan Balasescu
|
ce7c503e6e
|
Merge branch 'master' into playlist-unicode
|
2021-05-17 11:47:10 +09:00 |
|
Salman Ahmed
|
34d1490754
|
Remove null conditional
Shouldn't guard against that here.
|
2021-05-15 10:00:05 +03:00 |
|
Dean Herbert
|
dc56250a3c
|
Merge branch 'master' into player-loader-star-rating
|
2021-05-15 15:39:57 +09:00 |
|
Dean Herbert
|
94b7e89ac0
|
Merge pull request #12747 from frenzibyte/current-star-rating
Allow changing current star difficulty of a `StarRatingDisplay`
|
2021-05-15 15:39:39 +09:00 |
|
Dean Herbert
|
bdcb1a624e
|
Merge pull request #12759 from Naxesss/beatmap-verifier-context
Encapsulate check arguments in context object
|
2021-05-15 15:39:12 +09:00 |
|
Bartłomiej Dach
|
7665bdfbbb
|
Merge branch 'master' into null-assignment-warning-enable
|
2021-05-15 01:08:34 +02:00 |
|
Bartłomiej Dach
|
8b4e6d2911
|
Remove no longer necessary FinishTransforms(true) call
As the component no longer has any transition transforms applied.
|
2021-05-14 22:03:35 +02:00 |
|
Salman Ahmed
|
7c2fc9b412
|
Update usage due to nullability removal
|
2021-05-14 16:12:33 +03:00 |
|
Salman Ahmed
|
93007c1635
|
Merge branch 'current-star-rating' into player-loader-star-rating
|
2021-05-14 16:06:00 +03:00 |
|
Salman Ahmed
|
6cc678f497
|
Remove nullability and transition support from star rating display
|
2021-05-14 16:05:40 +03:00 |
|
Salman Ahmed
|
0dc3bfd0c1
|
Apply simple transforms to star rating display when ready if not
|
2021-05-14 15:55:26 +03:00 |
|
Dean Herbert
|
f5dd18f266
|
Use existing LoadedBeatmapSuccessfully bool instead
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
|
2021-05-14 16:53:51 +09:00 |
|
Dean Herbert
|
67a99c83a3
|
Tidy bindable changed code up
|
2021-05-14 16:24:52 +09:00 |
|
Salman Ahmed
|
8338f702c3
|
Remove not required null conditional
|
2021-05-14 09:32:56 +03:00 |
|
Dean Herbert
|
dc576c19b4
|
Fix a potential nullref when starting Player with autoplay enabled and beatmap fails to load
|
2021-05-14 15:10:02 +09:00 |
|
Dean Herbert
|
48672f8afd
|
Add very basic test logic to ensure PlayerLoader is present for playlists
|
2021-05-14 15:02:36 +09:00 |
|
Dean Herbert
|
b36c991ba1
|
Fix single case of incorrect usage
|
2021-05-14 12:04:38 +09:00 |
|
Salman Ahmed
|
9e8c0a7e70
|
Fix online play subscreens not pushing player loaders when starting gameplay
|
2021-05-14 04:25:29 +03:00 |
|
smoogipoo
|
362a09ca73
|
Fix up + reduce complexity of HOCEventQueue
|
2021-05-13 21:41:49 +09:00 |
|
smoogipoo
|
aaf31af326
|
Add blueprint transferral
|
2021-05-13 21:16:19 +09:00 |
|
smoogipoo
|
86042e1763
|
Implement HitObjectContainerEventQueue
|
2021-05-13 21:15:47 +09:00 |
|
Dan Balasescu
|
d5b14b6b99
|
Merge branch 'master' into remove-skinnable-hud-classes
|
2021-05-13 21:06:48 +09:00 |
|
Dan Balasescu
|
746862dcb1
|
Merge pull request #12750 from peppy/skin-serialisation
Add skin editor saving / loading support
|
2021-05-13 20:58:03 +09:00 |
|
smoogipoo
|
ffb6135a1b
|
Rework hitobject blueprints to take in hitobject models
|
2021-05-13 19:53:32 +09:00 |
|
Dan Balasescu
|
3c471837f8
|
Merge branch 'master' into skin-serialisation
|
2021-05-13 19:49:55 +09:00 |
|
Dan Balasescu
|
a3869c02f4
|
Merge branch 'master' into fix-two-hovered-handles
|
2021-05-13 19:24:42 +09:00 |
|
Dean Herbert
|
c8b7cfc753
|
Merge branch 'skin-serialisation' into remove-skinnable-hud-classes
|
2021-05-13 19:05:08 +09:00 |
|
Naxess
|
19800f5f7f
|
Move IBeatmap arg into context
|
2021-05-13 11:24:22 +02:00 |
|
Dean Herbert
|
106fa97a11
|
Rename SkinnableElementTargetContainer to SkinnableTargetContainer
|
2021-05-13 17:07:38 +09:00 |
|
Dean Herbert
|
7921dc7ece
|
Rename ISkinnableComponent to ISkinnableDrawable
|
2021-05-13 17:06:00 +09:00 |
|
Dean Herbert
|
cdcd31b546
|
Replace ISkinSerialisable with IsEditable property
|
2021-05-13 17:03:17 +09:00 |
|
Naxess
|
b37cb3bdbe
|
Change interpreted difficulty from bindable to regular value
There's no reason for why checks would need this to be bindable. A 1-directional binding is more appropriate.
|
2021-05-13 09:00:30 +02:00 |
|
Naxess
|
4eeeaf6a1a
|
Keep track of local bound copy
|
2021-05-13 07:57:32 +02:00 |
|
Naxess
|
e7c7786db3
|
Merge branch 'master' into beatmap-verifier-context
|
2021-05-13 07:40:33 +02:00 |
|
Dean Herbert
|
5b71d8ca37
|
Merge pull request #12758 from Naxesss/verify-settings-ui
Add setting UI components to the verify screen
|
2021-05-13 14:35:35 +09:00 |
|
Dean Herbert
|
b81f86bd4d
|
Move DI resolution to inside BDL parameters
|
2021-05-13 13:54:06 +09:00 |
|
Dean Herbert
|
c6648112e5
|
Simplify binding flow in InterpretationSection
|
2021-05-13 13:51:41 +09:00 |
|
Dean Herbert
|
cdcbaf4291
|
Tidy up specification of SettingsSection
|
2021-05-13 13:45:10 +09:00 |
|
Dean Herbert
|
3b862798e9
|
Standardise naming of methods related to SkinnableInfo
|
2021-05-13 13:14:49 +09:00 |
|
Naxess
|
47948d7b34
|
Set default for bindable in object initializer
Fixes the CI failure.
|
2021-05-13 06:08:48 +02:00 |
|
Naxess
|
fb305130de
|
Also refresh when interpreted difficulty changes
|
2021-05-13 06:00:21 +02:00 |
|
Naxess
|
ee0a6ba93e
|
Use local bound copy in InterpretationSection as well
Else we're relying on the `VerifyScreen`'s bindable instance, and by extension the `VerifyScreen` instance itself.
|
2021-05-13 05:59:49 +02:00 |
|
Dean Herbert
|
6caf4e3879
|
Add xmldoc to SkinnableInfo
|
2021-05-13 12:57:28 +09:00 |
|
Naxess
|
e80d8f6922
|
Keep track of local bound copy
|
2021-05-13 05:46:47 +02:00 |
|
Naxess
|
04c1585eb2
|
Use more consistent lambda discards
|
2021-05-13 05:38:45 +02:00 |
|
Dean Herbert
|
8b9ac86d4b
|
Merge branch 'master' into skin-serialisation
|
2021-05-13 12:35:06 +09:00 |
|
Naxess
|
e86834b740
|
Use local bound copy for HiddenIssueTypes
|
2021-05-13 05:25:20 +02:00 |
|
Naxess
|
c8d21f2c3f
|
Isolate refreshing to IssueList
|
2021-05-13 05:25:02 +02:00 |
|
Naxess
|
fbb76ba598
|
Split ShowIssueTypes dict into hidden and configurable lists
This way `VerifyScreen` is decoupled from which options `VisibilitySection` provides.
Bindings are a bit less neat, though.
|
2021-05-13 04:50:32 +02:00 |
|
Naxess
|
dd8423c4c4
|
Set interpreted difficulty to correct default
|
2021-05-13 04:36:20 +02:00 |
|
Naxess
|
6806e40ad9
|
Remove unnecessary local variable
This now exists in `VerifyScreen`, which we can access from here.
|
2021-05-13 04:30:40 +02:00 |
|
Naxess
|
56bd897666
|
Move ShowIssueTypes to VerifyScreen
|
2021-05-13 04:29:27 +02:00 |
|
Dan Balasescu
|
4e7c079560
|
Merge pull request #12753 from peppy/health-bar-hud-overlay-dependency
Remove downwards dependency from `HUDOverlay` to `HealthDisplay`
|
2021-05-12 19:27:02 +09:00 |
|
Dean Herbert
|
0a895fff15
|
Remove remaining test usage of SkinnableXXX HUD components
|
2021-05-12 18:53:25 +09:00 |
|
Salman Ahmed
|
96d3586294
|
Fix rotation handle visibility logic not handling two handles hovered at once
|
2021-05-12 11:42:55 +03:00 |
|
Dean Herbert
|
c6f0a6aed3
|
Merge pull request #12538 from smoogipoo/multiplayer-spectator-screen
Implement the multiplayer spectator screen
|
2021-05-12 17:24:35 +09:00 |
|
Dean Herbert
|
d2e0e8ad94
|
Reverse direction of binding to allow for better abstract class definitions
|
2021-05-12 16:53:58 +09:00 |
|
Dean Herbert
|
17e3764576
|
Rename Settings to have a more localised name
|
2021-05-12 16:38:04 +09:00 |
|
Dean Herbert
|
494a1b01a5
|
Move SkinnableElementTargetContainer out of HUD namespace
|
2021-05-12 15:59:33 +09:00 |
|
Dean Herbert
|
4aad7b96ea
|
Merge branch 'health-bar-hud-overlay-dependency' into skin-serialisation
|
2021-05-12 12:54:37 +09:00 |
|
Dean Herbert
|
184dbaf202
|
Improve safety of bindings in HealthDisplay
|
2021-05-12 12:53:30 +09:00 |
|
Naxess
|
64d96b06a6
|
Add interpreted difficulty info to BeatmapVerifierContext
Enables checks to make use of the difficulty level as shown in the settings UI.
|
2021-05-12 02:30:21 +02:00 |
|
Naxess
|
c13b93e6f1
|
Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
See next commit for example.
|
2021-05-12 02:29:18 +02:00 |
|
Naxess
|
4aeaec6ecc
|
Add InterpretationSection and its bindable in IssueList
We'll eventually connect that bindable so that checks can access it.
|
2021-05-12 01:32:18 +02:00 |
|
Naxess
|
ad78aec1ef
|
Refresh IssueList on changes in VisibilitySection
|
2021-05-12 01:30:45 +02:00 |
|