38639 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	78f41f7109	Fix spelling	2023-05-25 17:33:41 +02:00
Bartłomiej Dach	b59f4aee99	Merge pull request #23660 from peppy/simplify-deselect ... Fix crash when deleting dragged object in skin editor	2023-05-25 17:27:41 +02:00
Bartłomiej Dach	3ad5f8b9c9	Polish a few extreme edge cases	2023-05-25 16:39:54 +02:00
Dean Herbert	949de35664	Ensure selection is reset after immediately deleting objects ... Closes https://github.com/ppy/osu/issues/23518.	2023-05-25 23:20:32 +09:00
Bartłomiej Dach	beeca5a8dd	Use alternative layouting implementation	2023-05-25 16:17:44 +02:00
Dean Herbert	804671ca74	Split out grid snapping modes into "relative" and "global" types	2023-05-25 21:41:19 +09:00
Dean Herbert	b3c2d120bf	Fix OnResume / OnSuspending potentially getting called before OnEntering on a sub screen	2023-05-25 20:39:11 +09:00
Dean Herbert	7a5349d747	Remove constructor from MultiplayerPlaylistItem which is only used in tests	2023-05-25 20:09:40 +09:00
Dean Herbert	a6a380dd41	Merge branch 'master' into organize-room-pills	2023-05-25 19:57:28 +09:00
Dean Herbert	609c7227ee	Fix changes to font weight in a couple of combined implementations	2023-05-25 19:55:11 +09:00
Dean Herbert	57c63dbb29	Add xmldoc for GetDisplayScore	2023-05-25 19:24:15 +09:00
Dean Herbert	1049257b56	Simplify SelectionHandler's DeselectAll implementation ... We are already doing other operations in this class directly on `SelectedItems`, so might as well change this one to match	2023-05-25 18:46:31 +09:00
Dean Herbert	1e14b02493	Fix bindable feedback loop	2023-05-25 17:58:38 +09:00
Dean Herbert	37c6e632d0	Switch to using new extension method for length calculations	2023-05-25 17:38:35 +09:00
Dean Herbert	cf9fda0cf2	Merge branch 'beatmap-length-calcualtions' into pause-screen-progress	2023-05-25 17:34:08 +09:00
Dean Herbert	058edb5d5f	Centralise beatmap playable duration and bounds lookups	2023-05-25 17:32:48 +09:00
Bartłomiej Dach	578a0e7494	Merge branch 'master' into beat-divisor-visual-improvements	2023-05-24 22:28:26 +02:00
Bartłomiej Dach	6ec4ecfdd7	Mention fallback default in GetDivisorForBeatIndex()	2023-05-24 22:17:51 +02:00
Bartłomiej Dach	133c954c93	Merge branch 'master' into pause-screen-progress	2023-05-24 21:57:26 +02:00
Bartłomiej Dach	6392c2007c	Merge pull request #23637 from peppy/add-shadow-settings-notifications ... Add shadow to notifications and settings overlays to better distinguish from other overlays	2023-05-24 21:34:14 +02:00
Bartłomiej Dach	8b6cd1310a	Merge branch 'master' into editor-escape-deselects	2023-05-24 20:18:44 +02:00
Bartłomiej Dach	cd3602406b	Remove unused using directive	2023-05-24 18:54:48 +02:00
Dean Herbert	b14b1072c2	Allow deselecting any selection in the editor using the Back binding (escape key)	2023-05-24 19:24:14 +09:00
Dean Herbert	3b9e1e8a94	Ensure editor selection buttons remain on screen when selection is near edge ... Addresses https://github.com/ppy/osu/discussions/23599.	2023-05-24 19:16:53 +09:00
Stéén	dcfc99a092	Merge branch 'master' into make_pause_menu_translatable	2023-05-24 12:13:34 +02:00
Dean Herbert	79c9a48ff7	Show song progress at pause/fail screen	2023-05-24 18:36:37 +09:00
Dean Herbert	456f3005d6	Apply nullability to GameplayMenuOverlay and use TextFlowContainer for text	2023-05-24 18:28:04 +09:00
Dean Herbert	8ada8b1c8c	Remove description line from pause/fail screen ... These were in the designs but read pretty bad / evil. I can't think of any text to go in their place that makes sense, so let's just nuke it.	2023-05-24 17:48:35 +09:00
Dean Herbert	3a05dffa50	Add "auto" bank selection during placement	2023-05-24 17:11:12 +09:00
Dean Herbert	fc22c75464	Don't use switch for single case statement	2023-05-24 16:14:05 +09:00
Dean Herbert	a22ad98cb7	Fix hotkeys not actually working	2023-05-24 14:56:11 +09:00
Dean Herbert	a9ba16a2be	Update to support non-control-point sample changes	2023-05-24 14:20:38 +09:00
Dean Herbert	298989ffd2	Merge branch 'master' into sample-set-controls	2023-05-24 14:03:04 +09:00
Dean Herbert	561b759bf9	Tidy up implementation and ensure non-solid ticks start at zero alpha	2023-05-24 13:49:29 +09:00
Dean Herbert	8f1f1955df	Merge pull request #66 from Gyoshi/beat-divisor-visual-improvements ... Add ghost ticks to exhibit current divisor on `BeatDivisorControl`	2023-05-24 13:41:48 +09:00
Dean Herbert	e5451d1d79	Centralise definition of overlay shadow opacity and reduce slightly	2023-05-24 12:40:35 +09:00
Joseph Madamba	067328233c	Remove OsuScreen.ApplyLogoArrivingDefaults()	2023-05-23 13:17:43 -07:00
Robin Oger	d852883421	Merge remote-tracking branch 'origin/make_pause_menu_translatable' into make_pause_menu_translatable	2023-05-23 21:37:20 +02:00
Robin Oger	a24da89908	Change to sentence casing ... See: https://github.com/ppy/osu/pull/23640#discussion_r1202879352	2023-05-23 21:37:12 +02:00
Stéén	b9b97069b3	Merge branch 'master' into make_pause_menu_translatable	2023-05-23 21:28:00 +02:00
Robin Oger	0ea3eea8d6	Make GameplayMenuOverlay translatable ... This allows translator to translate the pause and failed in game menus	2023-05-23 19:21:44 +02:00
Gyoshi	7fe19d1992	Last instead of Max divisor to match code elsewhere	2023-05-23 18:45:49 +02:00
Gyoshi	c5ef3ae181	Code styling	2023-05-23 18:44:20 +02:00
Gyoshi	b5f8093941	Use RangePadding to align mouse with slider	2023-05-23 18:16:14 +02:00
Gyoshi	7b1e8ede54	Small format	2023-05-23 15:11:27 +02:00
Gyoshi	1b32370c6a	Remove duplicate code by making GetDivisorForBeatIndex method more general	2023-05-23 15:05:38 +02:00
Gyoshi	37a796306d	Small format & comment	2023-05-23 14:30:35 +02:00
Johannes vd Berg	ebda35c3c9	Add ghost ticks to exhibit current divisor on BeatDivisorControl	2023-05-23 12:57:25 +02:00
Dan Balasescu	7658536b5a	Fix CI issues	2023-05-23 19:32:19 +09:00
Dan Balasescu	fee3d43596	Merge branch 'master' into scorev2	2023-05-23 19:07:54 +09:00
Dean Herbert	02d8e3a11e	Mark FullscreenOverlay's shadow effect as Hollow to save on shader overhead	2023-05-23 18:50:14 +09:00
Dean Herbert	6f4e2b37ed	Add shadow to notifications and settings overlays to better distinguish from other overlays	2023-05-23 18:50:14 +09:00
Dan Balasescu	d45b54399b	Add back minimum/maximum accuracy	2023-05-23 18:15:32 +09:00
Dan Balasescu	3598ca9125	Adjust xmldoc	2023-05-23 18:05:10 +09:00
Dean Herbert	adf9a596b5	Fix weird state when attempting to enter gameplay skin editor scene from multiplayer ... Closes https://github.com/ppy/osu/issues/23626.	2023-05-23 17:58:44 +09:00
Dan Balasescu	8570f825ed	Consider all accuracy judgements in accuracy progress	2023-05-23 17:47:35 +09:00
Dan Balasescu	f8101fbbc7	Rename variables	2023-05-23 17:44:17 +09:00
Dean Herbert	ff5dde0ebe	Merge pull request #23575 from Joehuu/fix-inverted-video-only-check ... Fix old widescreen videos with black bars not correctly filling screen (again)	2023-05-23 16:47:52 +09:00
Dean Herbert	7c039b0b67	Merge pull request #23618 from bdach/fix-taiko-swells-drumrolls-silent ... Fix hitsounds not playing before and during taiko drum rolls and swells	2023-05-23 16:44:04 +09:00
Dan Balasescu	62d504af92	Fix base implementation of ComputeTotalScore	2023-05-23 15:59:24 +09:00
Dan Balasescu	e1feeded12	Change statistics type, remove overridability	2023-05-23 15:36:34 +09:00
Bartłomiej Dach	38b4bd8aef	Fix undo not behaving as expected sometimes	2023-05-22 22:45:39 +02:00
Bartłomiej Dach	e0b7539c2a	Fix sample changes not being applied in patcher	2023-05-22 22:45:23 +02:00
Bartłomiej Dach	f253d17a7f	Fix slider velocity changes not being applied in patcher	2023-05-22 22:19:10 +02:00
Dean Herbert	7742904d2a	Merge pull request #23593 from Dimmitsaras/unfocused-notifications ... Always show chat message notifications if window is unfocused	2023-05-22 14:17:20 +09:00
Dean Herbert	09c66bea8f	Merge pull request #23606 from Joehuu/fix-news-sidebar-link-clicking-area ... Fix clicking area of news sidebar post links	2023-05-22 14:17:08 +09:00
Joseph Madamba	7392109bce	Apply same behavioral changes to NewsCard	2023-05-21 19:28:12 -07:00
Joseph Madamba	2279aad360	Apply NRT to NewsCard	2023-05-21 19:27:20 -07:00
Dean Herbert	b3527b92b6	Handle case in tests where current display becomes null	2023-05-22 09:25:44 +09:00
Bartłomiej Dach	19816ae013	Update framework	2023-05-21 20:38:27 +02:00
Bartłomiej Dach	6df1d29862	Merge branch 'master' into use-atomic-ReplaceRange	2023-05-21 20:32:59 +02:00
Joseph Madamba	88c112612f	Remove hardcoded website url ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-05-21 10:35:22 -07:00
Bartłomiej Dach	5229cf7343	Add failing test cases for drum roll/swell sample playback	2023-05-21 18:57:01 +02:00
timiimit	9d14ea9d27	Merge branch 'ppy:master' into update-multiplayer-room-diff-range	2023-05-21 16:37:00 +02:00
timiimit	4441718437	Merge branch 'ppy:master' into organize-room-pills	2023-05-21 16:36:53 +02:00
Joseph Madamba	8aefb62532	Rename PostButton to PostLink	2023-05-20 16:38:56 -07:00
Joseph Madamba	ec5f0bbf42	Fix clicking area of news sidebar post links ... Side effect is that the hover color is yellow and pressing it opens an external dialog, but those are temporary (pending implementation of link underline to make `Light1` hover more readable and set at a higher level and news pages).	2023-05-20 16:32:04 -07:00
Bartłomiej Dach	de5917b645	Merge branch 'master' into unfocused-notifications	2023-05-20 19:32:52 +02:00
Bartłomiej Dach	a677d87d39	Touch up inline comments	2023-05-20 19:29:59 +02:00
Bartłomiej Dach	8e0a97ca49	Remove usage of HasSubmenu ... Property has been removed in the appropriate framework-side PR and instead folded into `IsActionable`. See: https://github.com/ppy/osu-framework/pull/5658#discussion_r1114834647	2023-05-20 18:02:12 +02:00
Bartłomiej Dach	67c044773b	Merge branch 'master' into fix-menu-state-display	2023-05-20 17:57:00 +02:00
Bartłomiej Dach	afdddb0195	Merge pull request #23582 from peppy/placement-blueprint-timeline-combo-fixes ... Fix timeline blueprint display not showing correct combo number / colour during placement	2023-05-20 15:02:55 +02:00
Bartłomiej Dach	0e11adaaac	Merge pull request #23564 from peppy/fix-missing-sample-additions ... Fix sample banks not transferring when adjusting via editor	2023-05-20 14:36:45 +02:00
Dan Balasescu	25d72d370e	Always add non-bonus change to combo portion	2023-05-20 00:24:43 +09:00
Dan Balasescu	30a296bd09	Rename parameters	2023-05-19 17:27:02 +09:00
Dan Balasescu	6c6f8621c1	Add score processor statistics to replay header	2023-05-19 16:29:24 +09:00
Dan Balasescu	d74bf2a096	Refactor for safety	2023-05-19 14:37:26 +09:00
Dan Balasescu	2ae34530f7	Avoid NaN values during ApplyBeatmap processing()	2023-05-19 14:14:34 +09:00
Dan Balasescu	7cbf48ffcf	Fix TestSceneScoring and incorrect combo calculations	2023-05-19 14:09:19 +09:00
Dan Balasescu	035d0d5c9c	Fix multiplayer leaderboard not working	2023-05-19 13:16:57 +09:00
Dan Balasescu	8b56a3f87d	Remove ClassicScoreMultiplier and DefaultScoreProcessor	2023-05-19 12:24:52 +09:00
Dan Balasescu	00e0411369	Fix/rework ModAccuracyChallenge calculation	2023-05-18 20:45:02 +09:00
Dan Balasescu	ef86be6d21	Fix base score added for non-accuracy-affecting objects	2023-05-18 20:32:50 +09:00
Dan Balasescu	c33e4fe75e	Remove unnecessary override	2023-05-18 20:10:28 +09:00
Dan Balasescu	808818768b	Add TotalScore to replay frame headers	2023-05-18 20:08:49 +09:00
Dan Balasescu	f3591f83a2	Remove ScoreManager.GetTotalScore()	2023-05-18 20:08:49 +09:00
Dan Balasescu	510b8e4c78	Remove ScoreManager.Mode, handle per-use	2023-05-18 20:08:49 +09:00
Dan Balasescu	829e47d30b	Add MaxTotalScore for performance breakdown calculator	2023-05-18 17:47:25 +09:00
Dan Balasescu	f2483a1cf8	Add some helper methods, fix precision differences ... Introduces some error at all times, but if we're to store scores everywhere as `long`, then the same precision should be applied to the "during gameplay" path as well.	2023-05-18 17:44:31 +09:00
Dean Herbert	ee522253cb	Remove a couple of unnecessary volume declarations	2023-05-18 14:12:57 +09:00
Bartłomiej Dach	9ca1c7f7b7	Merge pull request #23580 from peppy/fix-profile-button-depth ... Ensure scroll-to-top button is displayed above all overlay content	2023-05-17 21:23:46 +02:00
Dimmitsaras	7ac6688a0f	Chat message notifications always play on unfocused window	2023-05-17 18:34:39 +03:00
Dean Herbert	b58ab28765	Make EditorClock non-nullable in PlacementBlueprint	2023-05-17 21:40:52 +09:00
Dean Herbert	214d7e07fa	Add TODO regarding failing stack display code	2023-05-17 17:52:17 +09:00
Dean Herbert	0b25818bd2	Update combo information on placement blueprint	2023-05-17 17:26:19 +09:00
Dean Herbert	9563d4f730	Fix weird purple tint on placement object in timeline	2023-05-17 17:26:19 +09:00
Dean Herbert	8d925c8a8a	Move combo information updating to an interface level helper method	2023-05-17 17:26:19 +09:00
Dean Herbert	e43f2c2c43	Improve previous hitobject lookup efficient and correctness	2023-05-17 17:19:29 +09:00
Dean Herbert	7d7d402d4e	Apply NRT to PlacementBlueprint	2023-05-17 17:19:29 +09:00
Dean Herbert	87ff28b022	Update beat divisor control to show ticks in more visually correct locations ... As proposed in https://github.com/ppy/osu/discussions/23527.	2023-05-17 16:34:12 +09:00
Dean Herbert	730bc3a961	Apply NRT and simplify some remaining code	2023-05-17 16:18:13 +09:00
Dean Herbert	e97d027230	Make OnlinePlayPill class abstract	2023-05-17 16:13:03 +09:00
Dean Herbert	79e1d978e7	Ensure scroll-to-top button is displayed above all overlay content	2023-05-17 15:42:38 +09:00
Dean Herbert	764f0323f4	Show "rewind" text on random button when beginning a right mouse press	2023-05-17 14:51:40 +09:00
Dean Herbert	94b184712d	Fix random button hover state not correctly being reset on right click	2023-05-17 14:51:40 +09:00
Dean Herbert	dc421bd2af	Revert "Merge pull request #23570 from huoyaoyuan/inspect-code-cs11" ... This reverts commit ab2bd123e7, reversing changes made to 267e63320f.	2023-05-17 14:49:47 +09:00
Dean Herbert	510ebe1f23	Fix weird optional usage in HitSampleInfo.With	2023-05-17 14:11:52 +09:00
Dean Herbert	dc51d5ecf3	Rename GetSampleInfo to better describe what method does ... Also add full xmldoc	2023-05-17 14:07:48 +09:00
Dean Herbert	a8bc337006	Change default volume when constructing a HitSampleInfo to non-zero	2023-05-17 14:06:02 +09:00
Susko3	fec47fa690	Merge branch 'master' into use-atomic-ReplaceRange ... This reverts 0dcf1b540e	2023-05-17 06:56:54 +02:00
Joseph Madamba	d6fa44240d	Fix storyboard video-only check being inverted	2023-05-16 21:51:32 -07:00
Dean Herbert	0d3c64dc32	Merge pull request #23572 from bdach/avoid-display-settings-feedback ... Work around issues with bindable/event feedback in layout settings	2023-05-17 12:03:45 +09:00
Susko3	2d7fe68311	Prevent feedback by using atomic .ReplaceRange() ... `display.NewValue` will never be null, checked on SDL + osuTK/Android. On Android it's a 0x0 display, importantly not null.	2023-05-16 21:57:31 +02:00
Bartłomiej Dach	0dcf1b540e	Attempt to preserve old resolution when switching displays	2023-05-16 21:14:09 +02:00
Bartłomiej Dach	88ce627c8e	Avoid bindable/event feedback when changing resolution	2023-05-16 21:02:23 +02:00
Huo Yaoyuan	ddfdd712bd	Update InspectCode to 2022.3.3 and enable C# 11	2023-05-17 00:07:06 +08:00
Dean Herbert	d9ae822966	Fix bank not correctly being assigned when adding sample additions in editor	2023-05-16 18:52:52 +09:00
Dean Herbert	83dcd78826	Make HitSampleInfo.Bank non-nullable	2023-05-16 18:12:56 +09:00
timiimit	cc6e4df93e	Remove wrongly added back namepspace	2023-05-16 10:27:46 +02:00
timiimit	4ef74eb3f9	Fix RoomStatusPill text colour	2023-05-16 10:22:52 +02:00
timiimit	81b7737660	Fix text colour of RoomSpecialCategoryPill	2023-05-16 10:20:16 +02:00
timiimit	a9991d9dd4	Remove another unused namespace	2023-05-16 10:14:14 +02:00
timiimit	40daa41a52	Fix naming & namespaces	2023-05-16 10:06:48 +02:00
timiimit	04893064f0	Make used pills inherit from a common one	2023-05-16 09:53:11 +02:00
timiimit	10d6f9ea5a	Create common online play pill	2023-05-16 09:52:26 +02:00
timiimit	0fd718478a	Merge branch 'master' into update-multiplayer-room-diff-range	2023-05-15 07:36:43 +02:00
timiimit	83ceb3457f	Add xmldoc comment	2023-05-15 07:36:15 +02:00
timiimit	cb8d5f459f	Remove bad comment	2023-05-15 07:36:15 +02:00
Bartłomiej Dach	592fcafcd4	Merge pull request #23451 from timiimit/fix-default-progress-graph-flipping ... Fix default progress graph not updating after flip	2023-05-14 19:19:10 +02:00
timiimit	f7a2321175	Merge branch 'master' into update-multiplayer-room-diff-range	2023-05-14 12:28:58 +02:00
Bartłomiej Dach	cc2dfc8371	Merge branch 'master' into editor-slider-placement-tool-change	2023-05-14 12:26:37 +02:00
timiimit	86a834fb56	Fix TODO comment	2023-05-14 12:20:16 +02:00
timiimit	fd80ffd52b	Fix display update condition	2023-05-14 12:09:15 +02:00
timiimit	5d68701321	Copy StarRange when creating PlaylistItem	2023-05-14 12:08:37 +02:00
timiimit	f1f30b94a6	Add StarRating Property	2023-05-14 11:05:47 +02:00
Bartłomiej Dach	e6786e0244	Merge branch 'master' into editor-slider-placement-input	2023-05-14 10:52:22 +02:00
Bartłomiej Dach	325de2dc22	Merge pull request #23507 from peppy/editor-blueprint-end-placement ... Move blueprint validity conditions to allow more correct external usage of `EndPlacement`	2023-05-14 10:24:04 +02:00
Bartłomiej Dach	58410c6fc0	Merge pull request #23506 from peppy/tablet-settings-keywords ... Fix some tablet settings being hidden when searching using "area" keyword	2023-05-14 09:44:55 +02:00
Bartłomiej Dach	732bd7812b	Merge pull request #23529 from peppy/no-hold-during-gameplay ... Fix hold-for-right-click showing during gameplay	2023-05-13 15:33:13 +02:00
Dean Herbert	8c542c6c51	Fix hold-for-right-click showing during gameplay	2023-05-13 21:32:30 +09:00