Dean Herbert
|
d704a4597d
|
Use existing helper function for key repeat
|
2020-06-25 21:33:02 +09:00 |
|
Dean Herbert
|
d7742766d0
|
Add key/press repeat support to carousel
|
2020-06-25 19:47:23 +09:00 |
|
Viktor Rosvall
|
9e1bf71233
|
Added text explaining a second copy will be made
|
2020-06-24 11:29:38 +02:00 |
|
smoogipoo
|
f3b5149648
|
Move some suggestions to warnings, resolve issues
|
2020-06-03 16:48:44 +09:00 |
|
Lucas A
|
275d95082a
|
Fix crash in testing environment.
|
2020-06-02 16:01:01 +02:00 |
|
Lucas A
|
f63c66396f
|
Apply review suggestions.
|
2020-06-02 13:32:52 +02:00 |
|
Lucas A
|
e9b09373e7
|
Fix crashing if selected ruleset doesn't have an autoplay mod.
|
2020-06-01 17:41:04 +02:00 |
|
Dean Herbert
|
d4b7c81f96
|
Merge branch 'master' into results-screen-condensed-panel
|
2020-05-30 23:13:52 +09:00 |
|
Dean Herbert
|
f989f1aa00
|
Change event flow to avoid firing store delete events on update
|
2020-05-27 16:08:47 +09:00 |
|
smoogipoo
|
de0b6ec9f1
|
Create abstract implementation
|
2020-05-26 17:00:41 +09:00 |
|
Dean Herbert
|
052ad79fc6
|
Convert dangerous events to IBindables
|
2020-05-19 16:44:22 +09:00 |
|
Dean Herbert
|
a5c1b461f6
|
Fix null reference in difficulty recommender
|
2020-05-12 11:14:51 +09:00 |
|
smoogipoo
|
401c516503
|
Expose searchable terms from beatmap info instead
|
2020-05-07 13:04:08 +09:00 |
|
smoogipoo
|
5186da8412
|
Fix potential song select nullref
|
2020-05-07 11:37:04 +09:00 |
|
Dan Balasescu
|
0eae8d078b
|
Merge branch 'master' into master
|
2020-05-05 13:33:29 +09:00 |
|
alex
|
0e2ccac33b
|
Add spaces to comments
|
2020-05-04 18:36:24 -07:00 |
|
Dean Herbert
|
06f58dd3e3
|
Ensure correct beatmap and ruleset when presenting a score from song select
|
2020-05-04 15:20:43 +09:00 |
|
Dean Herbert
|
000c34dc26
|
Move recommender to field construction
|
2020-04-30 21:01:53 +09:00 |
|
Dean Herbert
|
cf4e79cf38
|
Show loading spinner when carousel is not ready to be displayed
|
2020-04-30 11:51:06 +09:00 |
|
Dean Herbert
|
119000f1ab
|
Reduce database includes where possible
|
2020-04-28 21:43:35 +09:00 |
|
smoogipoo
|
fcfb2b9026
|
Merge branch 'master' into fix-select-new-from-sub-screen
|
2020-04-21 14:36:53 +09:00 |
|
Dan Balasescu
|
3b3a7bdd85
|
Merge branch 'master' into scroll-to-center
|
2020-04-21 10:21:08 +09:00 |
|
Bartłomiej Dach
|
e3cd3cf1da
|
Convert to auto-properties
|
2020-04-20 21:43:07 +02:00 |
|
Bartłomiej Dach
|
9b6e26583b
|
Add xmldocs
|
2020-04-20 21:42:43 +02:00 |
|
Dean Herbert
|
ee1ccb8bcb
|
Fix in a slightly different and hopefully more understandable way
|
2020-04-20 14:03:55 +09:00 |
|
Endrik Tombak
|
b57d709d15
|
Don't use Parent
|
2020-04-19 18:29:06 +03:00 |
|
Endrik Tombak
|
a8bfd21f3f
|
Merge branch 'master' of https://github.com/ppy/osu into scroll-to-center
|
2020-04-19 18:21:34 +03:00 |
|
Dean Herbert
|
5833a7ac91
|
Fix presenting new ruleset and beatmap at once causing wedge display desync
|
2020-04-17 18:56:17 +09:00 |
|
Dean Herbert
|
d62094cd4b
|
Fix carousel not correctly updating when selection changes to a new beatmap from a child screen
|
2020-04-16 18:10:35 +09:00 |
|
Dean Herbert
|
03a74a4320
|
Apply same conditional check changes to DrawableCarouselBeatmapSet
|
2020-04-16 12:13:26 +09:00 |
|
Dean Herbert
|
91b13f91ea
|
Add exception disallowing potential edit when disabled at a property level
|
2020-04-16 12:11:12 +09:00 |
|
Dean Herbert
|
c4caf38feb
|
Simplify menu item checks (and add for other items)
|
2020-04-16 12:10:20 +09:00 |
|
Joehu
|
e2b28bfe88
|
Hide edit context menu item in multiplayer song select
|
2020-04-15 18:17:12 -07:00 |
|
Endrik Tombak
|
b475316a4e
|
Simplify and comment
|
2020-04-12 20:40:08 +03:00 |
|
Endrik Tombak
|
63a1686dfb
|
Scroll to screen middle
|
2020-04-12 12:42:52 +03:00 |
|
Dean Herbert
|
73a3f1fe65
|
Remove unnecessary DI
|
2020-04-11 17:30:34 +09:00 |
|
Dean Herbert
|
7aac0e59a8
|
Reduce dictionary lookups
|
2020-04-11 17:13:35 +09:00 |
|
Dean Herbert
|
310cf830d4
|
Simplify api request logic
|
2020-04-11 17:13:35 +09:00 |
|
Dean Herbert
|
abea7b5299
|
Tidy up function passing, naming, ordering etc.
|
2020-04-11 17:13:35 +09:00 |
|
Dean Herbert
|
7f753f6b4d
|
Remove current ruleset from function call
|
2020-04-11 16:43:09 +09:00 |
|
Dean Herbert
|
a843793957
|
Un-nest class
|
2020-04-11 16:41:11 +09:00 |
|
Endrik Tombak
|
deaf24f141
|
Fix oversight on null
|
2020-04-09 19:30:40 +03:00 |
|
Endrik Tombak
|
35f97dfc75
|
Style changes
|
2020-04-09 18:59:18 +03:00 |
|
Endrik Tombak
|
f40bdcd34e
|
Initial rewrite, moving API logic to SongSelect
|
2020-04-09 18:47:28 +03:00 |
|
Dean Herbert
|
260de77304
|
Merge branch 'master' into select-recommended
|
2020-04-09 15:30:35 +09:00 |
|
Dean Herbert
|
4bfc738f5b
|
Merge pull request #7639 from santerinogelainen/master
Add top rank to the beatmap carousel
|
2020-04-08 23:36:47 +09:00 |
|
smoogipoo
|
ed3e0a01e1
|
Re-namespace into song select
|
2020-04-07 15:31:22 +09:00 |
|
Joehu
|
57b6a91449
|
Remove unnecessary input override on footer button mods
Was used when it expanded on hover, but doesn't anymore.
|
2020-04-05 14:57:44 -07:00 |
|
Santeri Nogelainen
|
163de36777
|
Merge remote-tracking branch 'upstream/master'
|
2020-04-04 22:29:15 +03:00 |
|
Santeri Nogelainen
|
1e8badb14a
|
Move all logic to TopLocalRank and remove CarouselBeatmapRank
|
2020-04-04 22:28:36 +03:00 |
|
Joehu
|
493b654011
|
Remove horizontal margin from mod display
Can skew center alignment on fill flow containers.
Fixes affected areas. Vector2(5, 0) is similar to MarginPadding { Left = 10 }.
|
2020-04-03 11:30:02 -07:00 |
|
Dean Herbert
|
b47a532df3
|
Adjust code formatting slightly
|
2020-03-30 00:07:48 +09:00 |
|
Endrik Tombak
|
b4f0500706
|
Invert logic
|
2020-03-28 20:21:21 +02:00 |
|
Endrik
|
2c27894527
|
Use All instead of ToList Any
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
|
2020-03-28 19:58:33 +02:00 |
|
Santeri Nogelainen
|
6bde102207
|
Merge remote-tracking branch 'upstream/master'
|
2020-03-28 18:14:17 +02:00 |
|
Santeri Nogelainen
|
faa2b49be4
|
Fix namespace for CarouselBeatmapRank, make UpdateableRank in TopLocalRank readonly
|
2020-03-28 18:13:39 +02:00 |
|
Santeri Nogelainen
|
1c711147f3
|
Move all carousel rank logic into separate classes (TopLocalRank and CarouselBeatmapRank)
|
2020-03-28 17:22:01 +02:00 |
|
Endrik Tombak
|
87854fc4fa
|
Rename variable
|
2020-03-28 13:23:31 +02:00 |
|
Endrik Tombak
|
6a0c5c87aa
|
Use already existing variable
|
2020-03-28 13:06:03 +02:00 |
|
Endrik Tombak
|
fc3f9ff6fa
|
Don't use drawables for select next
|
2020-03-28 12:54:48 +02:00 |
|
Endrik Tombak
|
bbbaaae3ee
|
Write tests
|
2020-03-26 19:18:16 +02:00 |
|
Endrik Tombak
|
ee112c6f50
|
Move and change logic
|
2020-03-26 18:42:08 +02:00 |
|
Endrik Tombak
|
2f5dc93d61
|
Select recommended difficulty
|
2020-03-26 00:19:54 +02:00 |
|
Dean Herbert
|
b1d4261402
|
Fix track looping state not being reset when entering editor from song select
Closes #8432.
|
2020-03-25 15:50:19 +09:00 |
|
Dean Herbert
|
2a1e7a7ff0
|
Merge branch 'master' into fix-select-filter-not-absorbing-input
|
2020-03-24 14:03:58 +09:00 |
|
Dan Balasescu
|
6279c78e3c
|
Merge branch 'master' into fix-keypad-autoplay-shortcut
|
2020-03-24 13:34:31 +09:00 |
|
Joehu
|
5bc5119389
|
Handle OnHover on song select filter and footer
|
2020-03-23 16:03:33 -07:00 |
|
Joehu
|
96d962ab30
|
Fix autoplay keyboard shortcut not working with keypad enter key
|
2020-03-23 11:25:40 -07:00 |
|
Joehu
|
96848405fd
|
Fix song select filter not absorbing input from carousel
|
2020-03-23 10:54:45 -07:00 |
|
Dean Herbert
|
47c7673c9e
|
Fix crash when holding a key down while entering player
|
2020-03-23 17:04:54 +09:00 |
|
Dan Balasescu
|
d0c7b49376
|
Merge branch 'master' into fix-carousel-root-selects-from-nothing
|
2020-03-23 11:34:04 +09:00 |
|
Dean Herbert
|
29009c85c0
|
Fix typo in comment
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
|
2020-03-22 00:32:53 +09:00 |
|
Dean Herbert
|
9b60b535e5
|
Fix selection not occurring when switching from empty ruleset on first load
|
2020-03-20 15:01:26 +09:00 |
|
Dean Herbert
|
be4a97c289
|
Correctly bypass last selected when it is filtered
|
2020-03-20 13:01:24 +09:00 |
|
Dean Herbert
|
8f9e97b4cc
|
Fix carousel not remembering last selection correctly
|
2020-03-19 18:07:39 +09:00 |
|
smoogipoo
|
1c4296f5e7
|
Implement the new results screen
|
2020-03-17 17:43:16 +09:00 |
|
Dean Herbert
|
5e3668b2ea
|
Merge pull request #8260 from smoogipoo/add-workingbeatmap-timeout
Add beatmap loading timeout to prevent runaway loading scenarios
|
2020-03-17 11:17:35 +09:00 |
|
Dan Balasescu
|
e835f88c0c
|
Merge pull request #8255 from peppy/fix-carousel-scroll-while-import
Fix carousel scrolling being inoperable during beatmap import
|
2020-03-16 12:50:45 +09:00 |
|
Dan Balasescu
|
3e65f13c67
|
Merge branch 'master' into fix-carousel-scroll-while-import
|
2020-03-16 12:06:50 +09:00 |
|
Dean Herbert
|
9bb3a6c677
|
Merge branch 'master' into click-group-difficulty-icons
|
2020-03-16 12:01:09 +09:00 |
|
Dean Herbert
|
d6be8eec0c
|
Merge branch 'master' into click-disabled-difficulty-icons
|
2020-03-16 11:30:57 +09:00 |
|
Dan Balasescu
|
f390c1995d
|
Apply comment suggestions
Co-Authored-By: Dean Herbert <pe@ppy.sh>
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
|
2020-03-16 11:29:28 +09:00 |
|
Dan Balasescu
|
bd05462a7f
|
Merge branch 'master' into carousel-selection-fallback-improvement
|
2020-03-16 10:53:10 +09:00 |
|
Dan Balasescu
|
25a35a1370
|
Merge branch 'master' into always-apply-ruleset-filter
|
2020-03-16 10:32:36 +09:00 |
|
Dean Herbert
|
340d362d69
|
Appease inspectcode
|
2020-03-15 03:51:30 +09:00 |
|
smoogipoo
|
c33ca6e99c
|
Decorate usages with exception management
|
2020-03-13 14:28:11 +09:00 |
|
Dean Herbert
|
ac70fcc544
|
Change logic to be more resilient by identifying user scroll events
|
2020-03-13 12:30:27 +09:00 |
|
Dean Herbert
|
5f8d180b5e
|
Fix carousel scrolling being inoperable during beatmap import
|
2020-03-13 11:51:26 +09:00 |
|
Dean Herbert
|
04f1da04db
|
Remove incorrect xmldoc from SelectBeatmap function
|
2020-03-13 10:52:08 +09:00 |
|
Dean Herbert
|
3f8b454ff4
|
Reword comment to match new filtering behaviour
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
|
2020-03-13 10:01:28 +09:00 |
|
Dean Herbert
|
ca9cfbe51d
|
Move selection fallback logic out of BeatmapCarousel to SongSelect
|
2020-03-12 18:42:08 +09:00 |
|
Dean Herbert
|
6e11c3014c
|
Allow grouped difficulty icons to be clicked
|
2020-03-12 18:42:08 +09:00 |
|
Dean Herbert
|
ce5d01ed19
|
Allow filtered difficulty icons to be clicked
|
2020-03-12 18:42:08 +09:00 |
|
Dean Herbert
|
fc058f8896
|
Remove unnecessary this. prefix
|
2020-03-12 18:03:18 +09:00 |
|
Dean Herbert
|
933a8ffc8a
|
Add test coverage
|
2020-03-12 17:10:51 +09:00 |
|
Dean Herbert
|
28ac5af91c
|
Fix beatmap carousel tests loading beatmap manager beatmaps in test browser
|
2020-03-12 16:53:23 +09:00 |
|
Dean Herbert
|
63edcddaf1
|
Apply ruleset filter in all cases (even when bypassing filter for selection purposes)
|
2020-03-12 15:06:26 +09:00 |
|
Dan Balasescu
|
e6685c88fc
|
Merge pull request #8205 from peppy/always-scroll-to-selection
Fix changing ruleset at song select not scrolling the current selection back into view
|
2020-03-11 14:38:57 +09:00 |
|
Dan Balasescu
|
f8f8e3628f
|
Merge branch 'master' into always-scroll-to-selection
|
2020-03-11 13:38:28 +09:00 |
|
Dan Balasescu
|
9119e32f63
|
Merge branch 'master' into better-filter-bypass
|
2020-03-11 13:37:55 +09:00 |
|
Dean Herbert
|
ed837d3115
|
Use framework extension method for FromHex
|
2020-03-11 10:18:41 +09:00 |
|
Dean Herbert
|
a2d3f20409
|
Merge branch 'master' into better-filter-bypass
|
2020-03-11 02:55:14 +09:00 |
|
Dean Herbert
|
8294dd0b71
|
Fix changing ruleset at song selectnot scrolling the current selection back into view
|
2020-03-10 19:59:49 +09:00 |
|
Dean Herbert
|
979988235d
|
Increase flexibility of StarCounter component
|
2020-03-08 15:56:22 +09:00 |
|
Dean Herbert
|
0477ef6c13
|
Force a selection after filtering to ensure correct difficulty is selected
|
2020-03-05 21:45:19 +09:00 |
|
Dean Herbert
|
332f56a7f8
|
Fix nullref in tests
|
2020-03-05 20:34:24 +09:00 |
|
Dean Herbert
|
f8776a0be4
|
Display all difficulties from overriding selection
|
2020-03-04 22:59:49 +09:00 |
|
Dean Herbert
|
a62550b323
|
Reapply filters on next change after a forced beatmap display
|
2020-03-04 20:14:18 +09:00 |
|
Dean Herbert
|
e890e45420
|
Fix Ctrl+Enter behaviour regression
|
2020-03-02 19:44:25 +09:00 |
|
Dean Herbert
|
48f2f615cd
|
Merge branch 'master' into fix-volume-bninding-handling
|
2020-03-02 19:28:36 +09:00 |
|
Dean Herbert
|
489bf16bea
|
Add SelectNext and SelectPrevious global actions
|
2020-03-02 18:55:28 +09:00 |
|
smoogipoo
|
7ad6ad0bb0
|
Remove hacks that bypassed layout shortcomings
|
2020-02-27 13:32:23 +09:00 |
|
Dean Herbert
|
623b78d675
|
Combine all loading animation implementations
|
2020-02-21 15:32:46 +09:00 |
|
Dean Herbert
|
cd666166d5
|
Merge pull request #7809 from voidedWarranties/proposal-difficulty-icon-select
Allow selecting/playing a specific difficulty using the beatmapset difficulty icons
|
2020-02-21 10:24:12 +09:00 |
|
Dean Herbert
|
db4fe4f728
|
Merge branch 'master' into adjust-beatmap-overlay
|
2020-02-21 09:52:44 +09:00 |
|
smoogipoo
|
f9145ce5b4
|
Fix playlist items added with the wrong IDs
|
2020-02-17 17:02:19 +09:00 |
|
TheWildTree
|
64a9b9c6fb
|
Remove redundant using directives
|
2020-02-16 21:52:08 +01:00 |
|
TheWildTree
|
4d180a685a
|
Adjust font sizes and spacing in BeatmapSetOverlay
|
2020-02-16 21:43:33 +01:00 |
|
voidedWarranties
|
8c81f1e684
|
Move CarouselBeatmap access to private, test using indices
|
2020-02-15 17:51:55 -08:00 |
|
recapitalverb
|
2778c6617c
|
Merge branch 'master' into remove-duplicated-load
|
2020-02-15 15:13:35 +07:00 |
|
Dean Herbert
|
637c1dc840
|
In the case of only one playlist item, update with current selection on select
|
2020-02-15 14:41:16 +09:00 |
|
recapitalverb
|
7c9569c9a3
|
Merge branch 'master' into remove-duplicated-load
|
2020-02-15 12:10:34 +07:00 |
|
Dean Herbert
|
da68ae5461
|
Merge branch 'master' into match-songselect-playlist-logic
|
2020-02-15 12:27:51 +09:00 |
|
voidedWarranties
|
8e1ecddb1d
|
Add testing
|
2020-02-14 17:23:24 -08:00 |
|
recapitalverb
|
c46d828716
|
Preserve permitNulls
|
2020-02-14 20:59:51 +07:00 |
|
recapitalverb
|
10798aeab3
|
Fix code formatting
|
2020-02-14 20:30:27 +07:00 |
|
recapitalverb
|
c753cb46c5
|
Use [Resolved] wherever possible
|
2020-02-14 20:14:00 +07:00 |
|
smoogipoo
|
f31220c1ee
|
Fix exception when adding duplicate items
|
2020-02-14 19:56:43 +09:00 |
|
Dean Herbert
|
14f632b532
|
Merge branch 'master' into match-detail-area
|
2020-02-14 19:54:17 +09:00 |
|
smoogipoo
|
f0f739707f
|
Add playlist support to match song select
|
2020-02-14 17:51:42 +09:00 |
|
Dean Herbert
|
66910f1ee3
|
Remove unnecessary bindable setter
|
2020-02-14 17:50:53 +09:00 |
|
Dean Herbert
|
48dcb91118
|
Merge branch 'master' into custom-detail-area
|
2020-02-14 17:40:12 +09:00 |
|
smoogipoo
|
5ec9f454d5
|
Implement the match beatmap detail area
|
2020-02-14 17:20:38 +09:00 |
|
smoogipoo
|
25e399f11b
|
Merge branch 'match-playlist' into match-detail-area
|
2020-02-14 17:04:22 +09:00 |
|
voidedWarranties
|
368e6f9579
|
Use CarouselBeatmap.State to select
|
2020-02-13 17:47:16 -08:00 |
|
voidedWarranties
|
c871f07d2e
|
Use CarouselBeatmap action to select beatmap
|
2020-02-13 17:14:46 -08:00 |
|
Dean Herbert
|
b9a296d3f9
|
Merge branch 'master' into remove-current-item
|
2020-02-13 19:34:15 +09:00 |
|
Dean Herbert
|
49a1725749
|
Merge pull request #7812 from smoogipoo/playlist-bindables
Make playlist beatmap and ruleset into bindables
|
2020-02-13 18:51:42 +09:00 |
|
smoogipoo
|
75bef15583
|
Remove "current" multiplayer room item
|
2020-02-13 18:48:28 +09:00 |
|
smoogipoo
|
91edadfe9d
|
Make playlist beatmap and ruleset into bindables
|
2020-02-13 18:12:47 +09:00 |
|
smoogipoo
|
d4f14e552a
|
Improve extensibility of mod display expansion
|
2020-02-13 18:05:53 +09:00 |
|
voidedWarranties
|
ad0de27964
|
Safer dependency injection and accessibility levels
|
2020-02-12 22:11:26 -08:00 |
|
smoogipoo
|
6f7196b0b8
|
Make beatmap detail area abstractable
|
2020-02-13 13:46:23 +09:00 |
|
voidedWarranties
|
f8b69fe632
|
Remove unnecessary carousel variable, fix code formatting
|
2020-02-12 20:11:39 -08:00 |
|
voidedWarranties
|
b126c00292
|
Use dependency loader to get SongSelect instance
|
2020-02-12 19:05:08 -08:00 |
|
voidedWarranties
|
2901ec9f26
|
Select specific difficulties using their icons
|
2020-02-11 20:05:26 -08:00 |
|
Dean Herbert
|
8186f72507
|
Remove unused using
|
2020-02-10 17:12:45 +09:00 |
|
Dean Herbert
|
66fb72cd8a
|
Fix song select not showing active beatmap if it is filtered by local criteria
|
2020-02-10 16:59:54 +09:00 |
|
Dean Herbert
|
81cadb7875
|
Simplify the way multiple subscreens handle their disable states via a custom stack
|
2020-02-06 14:22:01 +09:00 |
|
recapitalverb
|
79bb476f4c
|
Merge branch 'master' into display-accuracy
|
2020-02-04 11:39:47 +07:00 |
|