266 Commits

Author	SHA1	Message	Date
Dean Herbert	4cb07b8839	Specify column widths for argon	2022-10-07 15:45:35 +09:00
Dean Herbert	6c0923ec1a	Add argon hold note pieces	2022-10-07 15:45:35 +09:00
Dean Herbert	a10f9ebfa5	Update argon colours to roughly match design spec	2022-10-07 15:45:35 +09:00
Dean Herbert	c1cb62cc35	Add basic argon note piece	2022-10-07 15:45:35 +09:00
Dean Herbert	dee01abab1	Add method to get stage from column index	2022-10-07 15:24:37 +09:00
Dean Herbert	eea3d5adb8	Standardise column index naming and xmldoc	2022-10-07 15:24:36 +09:00
Dean Herbert	0d21c0e49c	Remove StageDefinition from configuration lookups ... I added this for future usage, but it turns out I can get the definitions directly from `ManiaBeatmap`.	2022-10-07 15:24:36 +09:00
Dean Herbert	4a127f5d81	Fix classic skin colours sourcing from triangles defaults	2022-10-07 15:24:36 +09:00
Dean Herbert	6b79f16461	Make Column.AccentColour bindable	2022-10-07 15:24:36 +09:00
Dean Herbert	3947011baf	Fix regression in legacy dual stage handling logic	2022-10-07 15:24:36 +09:00
Dean Herbert	2ae1aef0be	Move column initialisation to ctor and fix remaining tests	2022-10-07 15:24:36 +09:00
Dean Herbert	5fe9b953a5	Add back triangles column colours via a transformer	2022-10-07 15:24:36 +09:00
Dean Herbert	1a0b953846	Remove unnecessary Beatmap parameter in ManiaLegacySkinTransformer	2022-10-07 15:24:36 +09:00
Dean Herbert	5c48d8931a	Add StageDefinition to ManiaSkinConfigurationLookup and make column background colour lookup work	2022-10-07 15:24:36 +09:00
Dean Herbert	46c3cfe54d	Remove StageDefinition flow in ManiaSkinComponent	2022-10-07 15:24:36 +09:00
Dean Herbert	7796a4c109	Cache StageDefinition for consumption (and remove ColumnType)	2022-10-07 15:24:36 +09:00
Dean Herbert	395ab58892	Attempt to fix code style infractions	2022-10-04 16:17:38 +09:00
Dean Herbert	345430ab39	Fix argon hit target area not being aligned correctly	2022-10-04 16:16:09 +09:00
Dean Herbert	1ffa0afafc	Tweak visuals and fix up code quality	2022-10-04 16:05:36 +09:00
Dean Herbert	36e2f5c512	Add argon hit target pieces	2022-10-04 14:56:46 +09:00
Dean Herbert	d32eb64561	Adjust colour application to stay around a bit longer	2022-10-04 14:56:46 +09:00
Dean Herbert	4718f4ac24	Add second icon and improve glow effect	2022-10-04 14:56:46 +09:00
Dean Herbert	83e7cc1e09	Add argon key area	2022-10-04 14:56:46 +09:00
Dean Herbert	97207c11f5	Add base transformer for osu!mania argon skin	2022-10-04 14:56:46 +09:00
Dean Herbert	a215d009fe	Update Remove/RemoveRange/RemoveAll calls in line with framework changes	2022-08-29 15:57:40 +09:00
Dan Balasescu	b4e55f7309	Apply IRenderer changes	2022-08-02 19:50:57 +09:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Salman Ahmed	61078910a6	Handle all skin component types explicitly	2022-04-23 03:34:05 +03:00
Dean Herbert	f703828e1b	Clarify ambiguous conditionals in LegacyStageBackground	2022-02-16 15:27:49 +09:00
Joseph Madamba	7de43e3aba	Fix most open compound words in identifiers being closed	2021-12-27 20:26:28 -08:00
Dean Herbert	6399c695e8	Update usages of BufferedContainer in line with framework changes	2021-11-05 15:54:49 +09:00
Dean Herbert	add39fbd4f	Merge branch 'master' into fix-skin-layout-editor-crash	2021-10-28 06:24:24 +09:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using var	2021-10-27 13:04:41 +09:00
Dean Herbert	93482414d6	Remove SkinConfiguration subclasses and allow configuration parsing for all skin types	2021-10-22 14:42:23 +09:00
smoogipoo	f9d5abff8a	Update with keybinding changes	2021-09-16 18:26:12 +09:00
smoogipoo	34bde293ab	Fix tests	2021-09-15 13:26:39 +09:00
smoogipoo	c009e1473d	Add extra safety check	2021-09-14 17:47:12 +09:00
smoogipoo	63aa3ddcba	Add animation support for mania notes	2021-09-14 17:45:23 +09:00
Salman Ahmed	fbb856d84b	Call base when overriding lookup methods ... Rather than arbitrarily accessing `Skin` here and there.	2021-06-11 12:44:44 +03:00
Salman Ahmed	cf40282f1f	Convert LegacySkinTransformers to accept raw ISkins rather than a full ISkinSource	2021-06-09 22:49:31 +03:00
Dean Herbert	d248bbd4c8	Use candidate skin for mania skin key lookup rather than this	2021-06-09 15:00:55 +09:00
Dean Herbert	33577cbad5	Fix multiple issues with default lookups	2021-05-31 21:29:47 +09:00
Dean Herbert	88ed95e012	Add FindProvider lookup function	2021-05-31 21:29:47 +09:00
Dean Herbert	17574833fb	Update other transformers with similar refactored logic	2021-05-30 19:15:59 +09:00
Salman Ahmed	fbc316ea1d	Fix legacy skin transformers potentially ignoring source implementations	2021-05-29 21:23:22 +03:00
Dean Herbert	5b1d9f4cf0	Fix constant case	2021-03-22 16:19:29 +09:00
Dean Herbert	690fb9224a	Combine constants for readability	2021-03-22 16:18:31 +09:00
smoogipoo	db64fac824	Delay key fade in legacy mania skins	2021-03-22 15:26:22 +09:00
Dean Herbert	00574a5288	Use ISample everywhere in Skin GetSample lookup path	2021-02-18 18:32:28 +09:00
smoogipoo	de9d075f94	Initial sample + samplechannel rework	2021-01-19 17:11:40 +09:00
Dean Herbert	bf39aa5980	Fix incorrectly converted rotation values	2020-12-22 12:18:42 +09:00
Dean Herbert	e1b2de27a6	Update osu!mania legacy skin's judgement animation to match stable	2020-12-21 17:23:23 +09:00
smoogipoo	a835ca9612	Fix anchors/origins for legacy pieces	2020-12-14 14:20:43 +09:00
smoogipoo	1794bfeddb	Move offset into legacy mania judgement	2020-12-14 13:07:55 +09:00
ekrctb	e3c035fe9c	Adjust namespace	2020-12-07 12:32:52 +09:00
ekrctb	40da799103	Move piece files of Mania ruleset	2020-12-07 12:31:56 +09:00
Bartłomiej Dach	21f29e28e2	Add clarification comment	2020-11-16 20:36:56 +01:00
Bartłomiej Dach	e88920442c	Use HitStateUpdateTime instead	2020-11-16 20:01:10 +01:00
Bartłomiej Dach	ba30800bf4	Extract constant	2020-11-13 22:21:22 +01:00
Bartłomiej Dach	a199a957cc	Use stored hold note break time to fade upon it	2020-11-13 22:16:38 +01:00
Bartłomiej Dach	4777b1be81	Fix fade not applying to tails sometimes	2020-11-13 20:52:15 +01:00
Bartłomiej Dach	55a91dbbe0	Add fading on hit state change	2020-11-13 20:52:15 +01:00
smoogipoo	b1877b649b	Use new hit results in mania	2020-09-29 16:33:38 +09:00
Dean Herbert	cd0a73883d	Merge pull request #9945 from smoogipoo/skin-colour-fix-2 ... Exactly reproduce osu!stable skin colour alphas	2020-08-29 20:06:26 +09:00
Dean Herbert	da34544fdc	Merge branch 'master' into hold-note-lighting	2020-08-28 18:27:29 +09:00
smoogipoo	7002193165	Mark nullable members	2020-08-27 23:16:59 +09:00
smoogipoo	29b29cde8e	Flip condition to reduce nesting	2020-08-27 23:09:54 +09:00
smoogipoo	157e1d8965	Add fades	2020-08-26 20:46:12 +09:00
smoogipoo	6fe1279e9d	Re-use existing inset container	2020-08-26 20:23:01 +09:00
smoogipoo	1db836e9e0	Merge branch 'master' into hold-note-lighting	2020-08-26 20:22:07 +09:00
smoogipoo	9372c6eef6	Implement hold note lighting	2020-08-26 20:21:56 +09:00
smoogipoo	d057f5f4bc	Implement mania "KeysUnderNotes" skin config	2020-08-26 15:37:16 +09:00
smoogipoo	c09cef4fca	Apply post-merge fixes to LegacyStageBackground	2020-08-25 19:40:17 +09:00
smoogipoo	8dde512657	Merge branch 'master' into skin-colour-fix-2	2020-08-25 19:39:01 +09:00
smoogipoo	ff72ccabd8	Rename method	2020-08-25 18:44:32 +09:00
smoogipoo	ab8d9be095	Move out into a separate method	2020-08-25 15:16:41 +09:00
smoogipoo	018523a43a	Rework to remove cross-class pollutions	2020-08-25 01:21:27 +09:00
smoogipoo	77bf646ea0	Move column lines to background layer	2020-08-24 23:01:06 +09:00
smoogipoo	500cb0ccf5	Fix legacy hit target being layered incorrectly	2020-08-24 22:36:37 +09:00
Bartłomiej Dach	891f5cb130	Add padding to mania column borders to match stable	2020-08-21 20:00:20 +02:00
smoogipoo	08078b9513	Rename method to remove "InitialColour" namings	2020-08-22 00:56:29 +09:00
smoogipoo	454564b189	Update mania with legacy colour setters	2020-08-22 00:19:15 +09:00
Dean Herbert	f6ca31688e	Fix incorrect spacing	2020-08-19 21:39:55 +09:00
Jihoon Yang	474f245222	Replace nested loop with early return	2020-08-18 08:40:29 -07:00
Jihoon Yang	af8f727721	Disable LegacyHitExplosion for hold notes	2020-08-18 08:28:53 -07:00
smoogipoo	00821e7b65	Re-implement support for small ticks	2020-07-29 16:14:19 +09:00
smoogipoo	7f2e554ad4	Fix animations not being reset	2020-07-29 15:52:25 +09:00
smoogipoo	0f1f4b2b5c	Add pooling for mania hit explosions	2020-07-29 15:36:42 +09:00
smoogipoo	b3769112fb	Fix mania hold note bodies behaving badly with edge alphas	2020-07-17 17:08:26 +09:00
Bartłomiej Dach	8233f5fbc4	Check skin option in skin transformers	2020-06-22 20:08:32 +02:00
Bartłomiej Dach	ad85c5f538	Add base legacy skin transformer	2020-06-21 23:06:55 +02:00
mcendu	ca555a6a52	rename per-column skin config retrieval to GetColumnSkinConfig ... Removed parameter "index"; all these cases should use extension instead	2020-06-20 14:56:39 +08:00
mcendu	8298a2c8a9	inline stage light lookup and clarify behavior	2020-06-20 14:53:25 +08:00
mcendu	9a0a1ba0df	correct logic of hasKeyTexture determination	2020-06-13 23:12:15 +08:00
mcendu	ffae73a966	let retrievals outside mania skin components use extension ... https://github.com/ppy/osu/pull/9264#discussion_r439730321	2020-06-13 23:07:04 +08:00
mcendu	bd7b7b5017	make all former LegacyManiaElement subclasses use extension method ... Remove LegacyManiaElement	2020-06-13 23:06:25 +08:00
mcendu	308ec6a491	add extension method for mania skin config retrieval	2020-06-13 23:05:57 +08:00
Dean Herbert	8402d4a5f3	Remove newline	2020-06-13 21:18:56 +09:00
mcendu	4eeb22ca18	rename a few variables and fix typo	2020-06-13 18:47:40 +08:00
mcendu	5655e090d1	revert movement of is mania skin check statements	2020-06-13 18:45:06 +08:00
mcendu	aa476835e7	tidy up code	2020-06-13 11:31:34 +08:00
mcendu	7c3e7b65a8	add custom file path support for osu\!mania judgement sprite	2020-06-12 21:22:22 +08:00
mcendu	b06017dbf1	supress horizontal scaling of left-and-right stages	2020-05-31 11:28:54 +08:00
smoogipoo	0a2b585c65	Apply missing scale	2020-04-21 17:14:49 +09:00
smoogipoo	83db6cebb6	Implement bottom stage image	2020-04-08 16:20:54 +09:00
smoogipoo	cd15b672eb	Implement left and right stage images	2020-04-08 16:20:47 +09:00
smoogipoo	e429c274a9	Initial structure	2020-04-08 15:35:37 +09:00
Dean Herbert	2062087155	Merge branch 'master' into more-mania-colours	2020-04-07 23:36:42 +09:00
Dean Herbert	9ff4458fd6	Merge branch 'master' into mania-skin-note-images	2020-04-07 22:41:22 +09:00
smoogipoo	11d58fb7f6	Implement column background and light colours	2020-04-07 16:53:55 +09:00
smoogipoo	9fd73492ca	Implement judgement line colour	2020-04-07 16:53:55 +09:00
smoogipoo	3ecb99462f	Make note height scale by minimum column width	2020-04-07 16:07:18 +09:00
smoogipoo	707a6269b3	Fix incorrect key texture lookup	2020-04-06 19:03:37 +09:00
Dean Herbert	cfa2404626	Remove explicit specification of new default	2020-04-06 12:39:49 +09:00
Dean Herbert	53c99d137a	Merge branch 'master' into mania-config-lookup-refactor	2020-04-03 22:22:59 +09:00
Dean Herbert	51db361c32	Update usages of Animation and Video in line with framework changes	2020-04-03 16:00:06 +09:00
smoogipoo	571748d105	Add some xmldocs + nullable parameter	2020-04-03 12:31:05 +09:00
smoogipoo	1f797207f7	Rework lookups to not require total playfield columns	2020-04-03 12:31:05 +09:00
Dean Herbert	f919a2f267	Merge branch 'master' into mania-hitexplosion-skinning	2020-04-02 23:57:03 +09:00
Dan Balasescu	0f5fd8051c	Merge branch 'master' into mania-hitexplosion-skinning	2020-04-02 23:08:31 +09:00
Dean Herbert	c35dd0153d	Merge branch 'master' into mania-column-line-colour	2020-04-02 23:03:22 +09:00
smoogipoo	47e2ff5ce6	Fix incorrect frame length for hit explosions	2020-04-02 22:56:30 +09:00
Dean Herbert	e1a9a76e01	Merge pull request #8564 from smoogipoo/fix-holdnote-texturing ... Fix hold note animation not being reset	2020-04-02 22:42:47 +09:00
Dean Herbert	8f2a3578bd	Merge branch 'master' into mania-hitexplosion-skinning	2020-04-02 21:59:01 +09:00
smoogipoo	62f1bc276d	Add skinning support for column line colour	2020-04-02 18:10:17 +09:00
smoogipoo	9552319732	Fix hold note animation not being reset	2020-04-02 17:09:08 +09:00
mcendu	dae738d6a4	add todo entries	2020-04-02 14:58:31 +08:00
mcendu	f3b96f8f50	add fallback to normal note image	2020-04-02 14:29:30 +08:00
smoogipoo	de7ee57100	Fix adding null hit explosions	2020-04-02 15:27:31 +09:00
smoogipoo	fa3a449c3b	Implement legacy normal hit explosions	2020-04-02 14:37:29 +09:00
smoogipoo	b375a02cff	Cleanup positioning factor definition	2020-04-02 14:37:29 +09:00
smoogipoo	c8eee8d204	Add structure for legacy hit explosions	2020-04-02 14:37:29 +09:00
Dean Herbert	1446b0782b	Merge branch 'master' into mania-existence-check	2020-04-01 23:11:09 +09:00
smoogipoo	558feade87	Fix ci warnings	2020-04-01 18:19:11 +09:00
smoogipoo	ff2c5b446e	Fix column lights positioned incorrectly	2020-04-01 16:06:09 +09:00
mcendu	87e5e98cae	use GetAnimation for checking	2020-04-01 14:17:23 +08:00
mcendu	716c7fa07a	Add check to detect whether mania is skinned	2020-04-01 11:04:29 +08:00
smoogipoo	bb5fa472dc	Remove null-stage fallback	2020-04-01 11:59:34 +09:00
mcendu	44fcd2613f	Add support for special column	2020-03-31 22:58:04 +08:00
mcendu	ff499b7d6b	fix indent	2020-03-31 19:12:02 +08:00
mcendu	df2379fb0e	remove unnecessary using	2020-03-31 18:10:43 +08:00
mcendu	3e0991d350	fix indent	2020-03-31 18:00:56 +08:00
mcendu	d41ff8c4b4	remove Column field from LegacyHitTarget	2020-03-31 17:58:29 +08:00
mcendu	ecc305bb63	extract superclass for all mania skinning elements	2020-03-31 17:54:51 +08:00
mcendu	977e1a3bfe	split shortcut into two methods	2020-03-31 17:48:37 +08:00
mcendu	71fc240aee	make mania skin elements use new method	2020-03-31 17:32:05 +08:00
mcendu	ec3d21e2b7	convert older elements to LegacyManiaColumnElement ... Also added xmldoc for new shorthand method.	2020-03-31 17:18:53 +08:00
mcendu	5179635b2d	add shorthand method for config retrieval	2020-03-31 17:08:05 +08:00
smoogipoo	1952fcc0ce	Implement mania hold note skinning	2020-03-31 16:42:35 +09:00
smoogipoo	b805ed6bf1	Flip anchors and origins	2020-03-31 15:59:52 +09:00