Dean Herbert
d608714cea
Merge branch 'master' into midi-keybinds
2020-05-11 17:09:15 +09:00
Dean Herbert
916d8245e6
Don't timeout on long beatmap load when debugging
2020-05-11 12:50:47 +09:00
Dan Balasescu
0b05a6d895
Merge branch 'master' into custom-data-directory
2020-05-11 12:12:03 +09:00
Dan Balasescu
6841bd5609
Merge branch 'master' into taiko-scroller
2020-05-11 11:10:55 +09:00
Dean Herbert
44fdf1e6b0
Reword xmldoc
2020-05-10 20:09:41 +09:00
Dean Herbert
c712e98f2b
Merge branch 'master' into publicly-expose-hud
2020-05-10 20:06:28 +09:00
Dean Herbert
729585e151
Merge branch 'master' into mania-holdnote-selection-fix
2020-05-10 15:07:30 +09:00
Dan Balasescu
2f12c4126a
Apply suggestions from code review
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-05-10 13:49:08 +09:00
smoogipoo
738c6da594
Implement midi keybindings
2020-05-10 13:39:20 +09:00
Dean Herbert
384862d48b
Fix incorrect relative paths when using GetStorageForDirectory
2020-05-10 13:20:13 +09:00
Dean Herbert
7ce78d8ce4
Merge branch 'master' into taiko-scroller
2020-05-09 23:25:54 +09:00
Dean Herbert
bbebd26efb
Use DirectoryInfo in more places
2020-05-09 20:13:31 +09:00
Dean Herbert
0bbf02d916
Merge branch 'master' into migration-backend
2020-05-09 19:32:35 +09:00
Dean Herbert
1348bdaa15
Merge branch 'custom-data-directory' into migration-backend
2020-05-09 19:32:29 +09:00
Dean Herbert
3f78ddf482
Add CanBeNull hinting
2020-05-09 19:13:18 +09:00
Dean Herbert
e2979cbe9a
Merge branch 'master' into fix-nullref-on-early-exit
2020-05-09 19:13:11 +09:00
Dean Herbert
fa711a6456
Fix null reference causing hard freeze if game is forcefully closed during disclaimer
2020-05-09 19:11:51 +09:00
Huo Yaoyuan
80a193a616
Use IEnumerable<T> for TypedListConverter.
2020-05-09 17:41:59 +08:00
Dean Herbert
55e0d91f37
Fix download button being disabled after importing a download disabled beatmap
2020-05-09 18:09:17 +09:00
Huo Yaoyuan
74cbe9306c
Use strongly-typed JsonConerter.
2020-05-09 16:39:46 +08:00
Dean Herbert
56f17fa64f
Merge branch 'master' into custom-data-directory
2020-05-09 17:27:16 +09:00
Endrik Tombak
d1976b194d
Check local availability before disabling buttons
2020-05-09 10:42:56 +03:00
Dean Herbert
5c2778d5f0
Change comparison direction
2020-05-08 20:33:02 +09:00
smoogipoo
be3b77cf25
Fix potentially skipping hitobject updates
2020-05-08 20:09:59 +09:00
Dean Herbert
9b8589583c
Merge branch 'master' into taiko-scroller
2020-05-08 19:10:39 +09:00
Dean Herbert
abd1115c6d
Fix test failures
2020-05-08 19:08:43 +09:00
Dean Herbert
d9658bc34e
Merge branch 'master' into custom-data-directory
2020-05-08 19:08:07 +09:00
smoogipoo
22dda3fe02
Make ScrollingHitObjectContainer respond to defaults applied events
2020-05-08 18:49:58 +09:00
smoogipoo
efff2bf15d
Add HitObject to DefaultsApplied event
2020-05-08 18:49:19 +09:00
smoogipoo
dcfef6b443
Add clear method to EditorBeatmap
2020-05-08 18:46:37 +09:00
Dean Herbert
a59db976d6
Fix loading a ruleset with a new version specification causing a crash
2020-05-08 18:05:06 +09:00
Lucas A
30dd158c33
Rename property to AllowGameplayOverlays and update XMLDoc accordingly.
2020-05-08 09:37:50 +02:00
Dean Herbert
9f64882f37
Update framework
2020-05-08 14:48:38 +09:00
Dean Herbert
b6f232e394
Update framework
2020-05-08 10:27:48 +09:00
Dean Herbert
abb32b3256
Merge branch 'master' into custom-data-directory
2020-05-08 10:05:11 +09:00
Dean Herbert
a019b5e6e8
Merge pull request #8958 from smoogipoo/fix-ss-nullref
...
Fix potential nullref in song select filtering
2020-05-08 09:08:03 +09:00
Dean Herbert
e8aebada3c
Merge pull request #8959 from smoogipoo/fix-catch-crash
...
Fix catch crashing when finishing maps
2020-05-07 23:46:36 +09:00
Dean Herbert
c5bd352f63
Merge branch 'master' into fix-ss-nullref
2020-05-07 22:29:18 +09:00
Dean Herbert
7a2020fd45
User copy operation instead of move
2020-05-07 22:12:24 +09:00
Dean Herbert
49a03f1c06
Add basic blocking migration, move not copy
2020-05-07 22:11:57 +09:00
Dean Herbert
754afb9c0b
Expose ContextFactory to allow for connection flushing
2020-05-07 22:11:57 +09:00
Dean Herbert
d21c42a222
Update framework
2020-05-07 20:59:29 +09:00
Lucas A
83998d5ba5
Trim whitespace.
2020-05-07 09:39:14 +02:00
Lucas A
83be5455d3
Disable the display of HUD through DisplayHud property.
2020-05-07 08:52:36 +02:00
Joehu
259ef68811
Fix date tooltip not showing in 24-hour format
2020-05-06 22:29:37 -07:00
smoogipoo
401c516503
Expose searchable terms from beatmap info instead
2020-05-07 13:04:08 +09:00
smoogipoo
e91e4a73af
Fix catch crashing when finishing maps
2020-05-07 12:22:07 +09:00
smoogipoo
5186da8412
Fix potential song select nullref
2020-05-07 11:37:04 +09:00
Dean Herbert
7781408643
Update in line with framework storage changes
2020-05-06 18:28:24 +09:00
Dean Herbert
c8134162b5
Merge pull request #8934 from smoogipoo/sorcerer-catch-changes
...
Implement Sorcerer's osu!catch difficulty calculation adjustments
2020-05-06 18:10:33 +09:00
Lucas A
aff74db80d
Publicly expose HUDOverlay in Player.
2020-05-05 10:40:10 +02:00
Dan Balasescu
0eae8d078b
Merge branch 'master' into master
2020-05-05 13:33:29 +09:00
alex
0e2ccac33b
Add spaces to comments
2020-05-04 18:36:24 -07:00
alex
c987af988c
Fix typo
2020-05-04 18:26:12 -07:00
Dan Balasescu
c14842d18b
Merge pull request #8937 from ppy/dependabot/nuget/Microsoft.CodeAnalysis.FxCopAnalyzers-3.0.0
...
Bump Microsoft.CodeAnalysis.FxCopAnalyzers from 2.9.8 to 3.0.0
2020-05-04 21:42:29 +09:00
Dan Balasescu
a7a156b4f1
Merge pull request #8939 from ppy/dependabot/nuget/Humanizer-2.8.11
...
Bump Humanizer from 2.8.2 to 2.8.11
2020-05-04 19:27:29 +09:00
smoogipoo
fe31bac505
Fix build error
2020-05-04 18:20:20 +09:00
dependabot-preview[bot]
4ee2e6cd47
Bump Humanizer from 2.8.2 to 2.8.11
...
Bumps [Humanizer](https://github.com/Humanizr/Humanizer ) from 2.8.2 to 2.8.11.
- [Release notes](https://github.com/Humanizr/Humanizer/releases )
- [Changelog](https://github.com/Humanizr/Humanizer/blob/master/release_notes.md )
- [Commits](https://github.com/Humanizr/Humanizer/compare/v2.8.2...v2.8.11 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-04 08:57:09 +00:00
Dean Herbert
5edabbdee2
Redirect log output to custom data directory
2020-05-04 17:35:35 +09:00
Dean Herbert
6621d363da
Add basic custom data directory support
2020-05-04 17:01:05 +09:00
smoogipoo
6d3a24ff01
Reorder tick hit results
2020-05-04 15:55:42 +09:00
smoogipoo
f42be7a6d7
Merge branch 'master' into sorcerer-catch-changes
2020-05-04 15:25:09 +09:00
Dean Herbert
06f58dd3e3
Ensure correct beatmap and ruleset when presenting a score from song select
2020-05-04 15:20:43 +09:00
Dean Herbert
a1cd007cad
Fix song select tests potentially failing due to difficulty panels not yet displayed
2020-05-04 14:44:53 +09:00
Dan Balasescu
5767bcb8d7
Merge branch 'master' into add-interval-list
2020-05-04 02:00:14 +09:00
Dan Balasescu
425457db81
Merge pull request #8924 from peppy/cached-online-lookups
...
Add local beatmap lookup cache to improve performance of imports
2020-05-04 01:12:02 +09:00
Dean Herbert
cea6be5e52
Expose as JudgementResult instead of "passing" state
2020-05-03 23:55:44 +09:00
Dean Herbert
68d40cf790
Fix test failures due to online cache download
2020-05-03 13:25:57 +09:00
Dean Herbert
6fef4eeb8f
Rename class and extract out lookup method
2020-05-03 09:35:48 +09:00
Dean Herbert
035b513b68
Use QuerySingle instead of QueryFirst
2020-05-03 09:32:33 +09:00
Dean Herbert
b9b5779251
Move deletion to catch instead of finally
2020-05-03 09:31:56 +09:00
Dean Herbert
917393697c
Update framework
2020-05-02 14:38:46 +09:00
Dean Herbert
deb87517d0
Add local beatmap lookup cache
2020-05-02 14:35:12 +09:00
Bartłomiej Dach
8118747732
Make PeriodTracker actually immutable
2020-05-02 01:33:33 +02:00
Dean Herbert
ff1d63060d
Add and consume passing state in GameplayBeatmap
2020-05-01 20:08:18 +09:00
Joehu
700214d249
Truncate beatmap title and artist on score panel
2020-04-30 22:13:38 -07:00
smoogipoo
e0ae9f791c
Update framework
2020-05-01 11:56:40 +09:00
smoogipoo
15d3648533
Merge branch 'master' into display-modes
2020-05-01 11:55:13 +09:00
Dean Herbert
d470e092a3
Merge branch 'master' into fix-overlapping-object-undoredo
2020-05-01 10:45:29 +09:00
Dan Balasescu
5740563391
Merge pull request #8903 from peppy/carousel-loading-spinner
...
Show loading spinner when carousel is not ready to be displayed
2020-04-30 21:29:53 +09:00
Dean Herbert
53474c74ee
Merge pull request #8913 from smoogipoo/fix-mania-undo-redo-crash
...
Fix mania crashing on undo/redo
2020-04-30 21:03:38 +09:00
Dean Herbert
000c34dc26
Move recommender to field construction
2020-04-30 21:01:53 +09:00
Dan Balasescu
273266abc1
Merge pull request #8910 from peppy/taiko-kiai-playfield
...
Add kiai support to osu!taiko skinned playfields
2020-04-30 21:00:08 +09:00
smoogipoo
c96bc5c51c
Fix undo/redo behaving poorly with simultaneous objects
2020-04-30 20:39:41 +09:00
smoogipoo
9bec42bc7e
Fix mania crashing on undo/redo
2020-04-30 20:03:46 +09:00
Dean Herbert
d0a8c0fa71
Add kiai support to osu!taiko skinned playfields
2020-04-30 16:43:00 +09:00
Dean Herbert
21c6ac8c43
Allow closing the game during intro
2020-04-30 12:12:28 +09:00
Dean Herbert
cf4e79cf38
Show loading spinner when carousel is not ready to be displayed
2020-04-30 11:51:06 +09:00
Dean Herbert
c3ef1d3170
Merge pull request #8893 from peppy/reduce-initial-channel-load-overhead
...
Reduce initial channel load overhead by only loading history on active channel
2020-04-29 19:56:23 +09:00
Dan Balasescu
a8c3cdbd2e
Merge pull request #8895 from peppy/improve-beatmap-lookup-performance
...
Further improve beatmap carousel load performance by avoiding incorrect query construction
2020-04-29 19:35:26 +09:00
Dan Balasescu
f282d57aa7
Merge branch 'master' into reduce-initial-channel-load-overhead
2020-04-29 19:30:56 +09:00
Dean Herbert
064e5004ed
Merge branch 'master' into fix-mania-selection
2020-04-29 17:15:48 +09:00
Dean Herbert
d1ec99ffd9
Further improve beatmap carousel load performance by avoiding incorrect query construction
2020-04-29 16:51:22 +09:00
Dean Herbert
c73d45bc01
Reduce initial channel load overhead by only loading history on active channel
2020-04-29 15:23:28 +09:00
Dean Herbert
68fe3e12bc
Merge pull request #8887 from smoogipoo/mania-dt-speed
...
Fix speed adjustment mods affecting mania scroll speed
2020-04-29 14:52:51 +09:00
Salman Ahmed
6fa9feb15c
Merge remote-tracking branch 'upstream/master' into add-interval-list
2020-04-29 05:14:40 +03:00
Salman Ahmed
6e76e5900a
Rename is-in-any check method to a more legible name
2020-04-29 05:11:44 +03:00
Salman Ahmed
8d899f4e77
Apply changes to the BreakTracker and more adjustment
2020-04-29 05:11:43 +03:00
Salman Ahmed
00918ecb6d
Replace interval collection with a more-specific immutable component
...
Covers all small changes into one commit:
- Remove generics and use `double` type instead.
- Make the component immutable and not enumerable for simplicity of it's worth.
- Make the component more-specific (to time period tracking)
- Apply small adjustments to the component
2020-04-29 05:11:43 +03:00
Dean Herbert
cd22e5883d
Merge pull request #8883 from peppy/dont-use-internal-ef-linq
...
Avoid using internal EF methods in tests
2020-04-29 09:54:06 +09:00
Dean Herbert
119000f1ab
Reduce database includes where possible
2020-04-28 21:43:35 +09:00
smoogipoo
1aaab40228
Fix mods affecting mania scroll speed
2020-04-28 19:34:02 +09:00
smoogipoo
7d54d4b800
Improve test scene
2020-04-28 18:36:10 +09:00
Dean Herbert
c3a41c8476
Also avoid using internal TypeExtensions
2020-04-28 17:02:10 +09:00
smoogipoo
da30eafa30
Prevent potential exception
2020-04-28 14:47:45 +09:00
Dan Balasescu
e915f22516
Merge branch 'master' into schedule-music-controller-operations
2020-04-28 14:09:56 +09:00
Dean Herbert
19fe15887a
Merge pull request #8860 from Joehuu/fix-mod-sel-score-multi-being-off-screen
...
Fix score multiplier being cut off in mod select at higher ui scales
2020-04-28 13:52:56 +09:00
Dean Herbert
832fa74a5e
Reword comment slightly
2020-04-28 13:26:42 +09:00
smoogipoo
799b5179ed
Merge branch 'master' into fix-mania-selection
2020-04-28 13:00:33 +09:00
Dean Herbert
62be138aa9
Avoid calls on MusicController executing before it may have finished loading
2020-04-28 11:46:08 +09:00
Shane Woolcock
9477a5373c
Merge branch 'master' into display-modes
2020-04-28 12:04:20 +09:30
Joseph Madamba
a34ec03efc
Reword width comment
...
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-04-27 12:44:20 -07:00
smoogipoo
cebc0fc046
Attempt to fix multiple selection movements
2020-04-27 20:35:24 +09:00
dependabot-preview[bot]
c0b225ffc8
Bump ppy.osu.Game.Resources from 2020.412.0 to 2020.427.0
...
Bumps [ppy.osu.Game.Resources](https://github.com/ppy/osu-resources ) from 2020.412.0 to 2020.427.0.
- [Release notes](https://github.com/ppy/osu-resources/releases )
- [Commits](https://github.com/ppy/osu-resources/compare/2020.412.0...2020.427.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-27 08:59:34 +00:00
smoogipoo
7f5a1d7f44
Merge branch 'master' into fix-mania-selection
2020-04-27 17:09:40 +09:00
smoogipoo
bc6b02664f
Merge branch 'master' into taiko-drumroll-party
2020-04-27 11:52:13 +09:00
Joehu
1b9362041a
Revert multiplier number changes and set width
...
Safe arbitrary width taken from "0.00x" (highest width of 67), rounded to the nearest tenth.
2020-04-26 19:50:11 -07:00
Joehu
8a47a615db
Remove unranked label from footer
2020-04-26 19:29:22 -07:00
smoogipoo
104c61d622
Remove unnecessary scale
2020-04-27 11:06:23 +09:00
Dean Herbert
48168dddce
Adjust editor timeline current marker to promote tick visibility
2020-04-27 10:54:32 +09:00
Dean Herbert
2737726f93
Merge pull request #8864 from Game4all/keybinds-ruleset-icon
...
Fix custom rulesets not showing correct icons in key binding settings
2020-04-27 08:48:00 +09:00
Bartłomiej Dach
a436f8e6d4
Trim other leftover RelativeSizeAxes
2020-04-26 22:54:01 +02:00
Lucas A
801968ed51
Remove un-needed RelativeSizeAxes specifications.
2020-04-26 21:17:40 +02:00
Lucas A
a756486a4d
Make settings section icons actual drawables.
2020-04-25 20:35:46 +02:00
Dean Herbert
b50e8471d2
Reword comment
2020-04-25 18:23:09 +09:00
Salman Ahmed
1953c8fc10
Fix ruleset selector not receiving key input on toolbar absence
2020-04-25 09:53:09 +03:00
Salman Ahmed
37cc1ed5a2
Fix potential null reference while hiding toolbar
2020-04-25 09:51:39 +03:00
Tim Oliver
c1c930c472
Fixed linting warnings
2020-04-25 13:47:20 +08:00
Joehu
4b60be87b5
Move unranked label under multiplier number to avoid width changes
2020-04-24 16:34:41 -07:00
Dean Herbert
cbcd915ec8
Fix crash on switching comments page at an inopportune time
2020-04-24 18:18:10 +09:00
Dean Herbert
59bd2b3035
Merge pull request #8823 from smoogipoo/all-ruleset-encoders
...
Implement legacy beatmap encoding for all rulesets
2020-04-24 17:49:34 +09:00
Dean Herbert
fe0038ed14
Merge branch 'master' into fix-mania-placement
2020-04-24 17:00:12 +09:00
Joehu
0f6ec274f9
Add transitions to footer when flowing to another row
2020-04-23 22:44:17 -07:00
Joehu
118db03b56
Fix vertical spacing and score multiplier splitting apart
...
Also cleans up margin and its hacks (alignment done with anchor/origin now).
2020-04-23 22:41:38 -07:00
Joehu
abb687286b
Fix score multiplier being cut off in mod select at higher ui scales
2020-04-23 22:34:00 -07:00
Dan Balasescu
e67ac515fc
Merge branch 'master' into fix-editor-hard-crash
2020-04-24 12:29:48 +09:00
Dean Herbert
131f011239
Merge branch 'master' into all-ruleset-encoders
2020-04-24 11:32:48 +09:00
Dean Herbert
1c13fa6c61
Fix editor crashing when entering with no beatmap selected
2020-04-24 10:27:32 +09:00
smoogipoo
4ebb28d3e7
wip
2020-04-23 17:52:54 +09:00
smoogipoo
6df45164fa
Expose direction from scrolling test container
2020-04-23 11:17:16 +09:00
smoogipoo
86ef73aa27
Implement HitObjectContainer.Clear()
2020-04-23 11:16:59 +09:00
smoogipoo
40f11ed15c
Resolve broken test scene
2020-04-23 10:37:05 +09:00
smoogipoo
7796593b2c
Merge branch 'master' into fix-testbeatmap-rulesetid
2020-04-23 10:35:08 +09:00
Dean Herbert
dd9ceed802
Merge branch 'master' into all-ruleset-encoders
2020-04-22 22:51:42 +09:00
Dean Herbert
97dcd546f1
Merge pull request #8833 from smoogipoo/remove-obsoletes
...
Remove obsolete nested hitobject methods
2020-04-22 22:40:06 +09:00
smoogipoo
08982e0e00
Ensure editor tests wait for load to complete
2020-04-22 19:49:21 +09:00
smoogipoo
0a34fddcc3
Fix TestBeatmap not setting appropriate ruleset ID
2020-04-22 19:38:27 +09:00
smoogipoo
93151f7612
Add back necessary events + addition to list
2020-04-22 18:32:59 +09:00
smoogipoo
e1142b424d
Fix test failures
2020-04-22 18:14:21 +09:00
smoogipoo
8b0274fedd
Remove obsolete methods
2020-04-22 17:55:50 +09:00