394 Commits

Author	SHA1	Message	Date
Dan Balasescu	a2f8ff825e	Also ignore drum roll strong judgement	2022-09-06 23:26:25 +09:00
Dan Balasescu	792b410c04	Merge branch 'master' into classic_drumrolls	2022-09-06 16:29:45 +09:00
sw1tchbl4d3	a9aa928ce6	Fix test, make strong hits have LargeBonus judgement	2022-08-30 15:00:46 +02:00
sw1tchbl4d3	b185194d07	Apply comments by smoogi	2022-08-30 14:44:44 +02:00
Dean Herbert	a215d009fe	Update Remove/RemoveRange/RemoveAll calls in line with framework changes	2022-08-29 15:57:40 +09:00
Dean Herbert	ad28bfc9b2	Fix taiko blueprints displaying incorrectly for drum rolls	2022-08-18 17:18:11 +09:00
sw1tchbl4d3	e0426836c1	Make swells and drumrolls optional by default	2022-08-05 16:30:07 +02:00
sw1tchbl4d3	0a0f3c93dd	Rename OkResult, rephrase "strong bonus"	2022-07-24 20:55:13 +02:00
Justin	a4f3a0d201	Merge branch 'master' into classic_drumrolls	2022-07-24 18:33:04 +00:00
Salman Ahmed	1051009827	Change bindable properties in all HitObjects to be lazily initialised	2022-07-19 05:39:10 +03:00
Dean Herbert	31a447fda0	Update parameter discards	2022-06-24 21:26:19 +09:00
Bartłomiej Dach	3497e966fd	Revert no longer needed access modifier change	2022-06-24 13:01:16 +02:00
Bartłomiej Dach	f47b74a938	Move OkResult from drawable swell to judgement	2022-06-24 13:00:12 +02:00
sw1tchbl4d3	6c8042642a	Reduce code duplication	2022-06-20 17:22:41 +02:00
sw1tchbl4d3	98527fec26	Make mod selfcontained	2022-06-19 15:11:12 +02:00
sw1tchbl4d3	a5bf16e873	Make drum rolls and swells optional with Classic mod	2022-06-19 02:10:23 +02:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Salman Ahmed	117d81d84f	Use perfect osu!(stable) strong scale value ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2022-04-05 03:04:53 +03:00
Salman Ahmed	01b10e68d2	Adjust taiko hit objects sizes to match osu!(stable)	2022-04-02 23:47:20 +03:00
Bartłomiej Dach	c6adbdd46f	Fix drum rolls nested objects not applying min result on kill	2022-01-16 17:53:37 +01:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using var	2021-10-27 13:04:41 +09:00
smoogipoo	bc37cb6f43	Merge branch 'master' into no-more-difficulty-control-points-info	2021-10-08 18:41:17 +09:00
Dean Herbert	a92d499d7a	Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo	2021-10-01 16:55:50 +09:00
Dean Herbert	46bafb6252	Merge branch 'master' into no-more-difficulty-control-points-info	2021-09-28 13:53:56 +09:00
smoogipoo	f9d5abff8a	Update with keybinding changes	2021-09-16 18:26:12 +09:00
Dean Herbert	a3d9ab1e2e	Move approach rate to EffectControlPoint	2021-09-03 16:58:16 +09:00
Dean Herbert	071c56e90b	Update usages of DifficultyPointAt	2021-09-03 16:58:16 +09:00
Dean Herbert	ee49305cad	Move taiko legacy speed multiplier to osu.Game project ... Allows it to be used in local case in `LegacyBeatmapEncoder`.	2021-08-30 15:13:31 +09:00
PercyDan54	e1c646b9b2	Remove redundant arguments	2021-07-05 23:52:39 +08:00
Dean Herbert	9c34cb0777	Share colour constants with default drawable piece implementations	2021-06-11 14:20:08 +09:00
Dean Herbert	bc3b7233ab	Show osu!taiko centre/rim colouring in editor timeline ... Closes #13443.	2021-06-11 14:17:30 +09:00
Dean Herbert	cbad7bb7f0	Move taiko Type to Hit and localise all bind handling	2021-05-26 13:40:36 +09:00
Dean Herbert	912748b428	Avoid bindable feedback causing overwrites	2021-05-26 13:24:22 +09:00
Dean Herbert	dc322d1c63	Run all type and sample mutations through standardising methods	2021-05-23 20:22:48 +09:00
Dean Herbert	6471ce902d	Run RecreatePieces using AddOnce to avoid multiple unnecessary calls	2021-05-21 16:45:28 +09:00
Dean Herbert	0bcd0cda6b	Fix taiko drawable hit content not correctly being removed on regeneration	2021-05-21 16:41:40 +09:00
Dean Herbert	7bc8a4bb5f	Apply same logic changes to IsStrong status	2021-05-21 16:15:27 +09:00
Dean Herbert	a5ca736e37	Fix RecreatePieces being called more than once	2021-05-21 16:10:48 +09:00
Dean Herbert	40c8378d81	Fix type-to-sample mapping being applied too late	2021-05-21 14:37:22 +09:00
Bartłomiej Dach	370f56eadb	Make strong hit DHOs public for pool registration	2020-12-20 18:02:34 +01:00
Bartłomiej Dach	0c5333bd58	Adjust top-level hitobjects to support nested pooling	2020-12-20 17:57:19 +01:00
Bartłomiej Dach	ae6dedacaf	Implement nested strong hit application	2020-12-20 16:26:39 +01:00
Bartłomiej Dach	d823c77a63	Implement swell tick application	2020-12-20 16:26:39 +01:00
Bartłomiej Dach	3bd4279589	Implement drum roll tick application	2020-12-20 16:26:39 +01:00
Bartłomiej Dach	e3b6eaa390	Implement swell application ... Also removes a weird sizing application that seems to have no effect (introduced in 27e63eb; compare removals for other taiko DHO types in 9d00e5b and 58bf288).	2020-12-20 16:26:39 +01:00
Bartłomiej Dach	8b6bc09b8f	Implement drum roll application	2020-12-20 16:26:16 +01:00
Bartłomiej Dach	e32b1c34ca	Implement hit application	2020-12-20 16:26:16 +01:00
Bartłomiej Dach	7b350fc8e5	Prepare strongable DHO for HO application	2020-12-20 15:42:24 +01:00
Bartłomiej Dach	a25cd910f8	Prepare base DHO for HO application	2020-12-20 15:42:24 +01:00
Dan Balasescu	48805a82f9	Merge branch 'master' into taiko-strong-state-refactor	2020-12-15 11:46:52 +09:00
Dan Balasescu	52d9864818	Merge pull request #11179 from bdach/swell-rewind-crash ... Fix swells crashing on rapid seeks in editor	2020-12-15 11:21:37 +09:00
Bartłomiej Dach	523e803440	Fix swells crashing on rapid seeks in editor	2020-12-15 00:28:00 +01:00
Bartłomiej Dach	2051f49f78	Ensure correct initial state of taiko bar lines	2020-12-14 21:58:17 +01:00
Bartłomiej Dach	512549b4ea	Rename DrawableTaikoStrong{-> able}HitObject	2020-12-14 21:47:31 +01:00
Bartłomiej Dach	5af1ac1b53	Rename TaikoStrong{-> able}HitObject	2020-12-14 21:46:02 +01:00
Bartłomiej Dach	7ba04a2cc3	Merge branch 'master' into taiko-strong-state-refactor	2020-12-14 21:44:50 +01:00
Dean Herbert	7041503063	Avoid intermediary delegate	2020-12-14 15:34:32 +09:00
Bartłomiej Dach	a8e86a20e1	Unify bar line types & prepare for pooling	2020-12-13 22:31:33 +01:00
Bartłomiej Dach	f83c5fa81d	Add backing bindable for major field	2020-12-13 22:12:26 +01:00
Bartłomiej Dach	080f7a3e32	Add/fix up xmldocs with clarifications	2020-12-13 14:39:32 +01:00
Bartłomiej Dach	091b08b507	Scope drawable nested hits more closely to models	2020-12-13 14:38:16 +01:00
Bartłomiej Dach	61c488cd5e	Create HO-specific nested hit types	2020-12-13 13:08:32 +01:00
Bartłomiej Dach	4d444df6b3	Rename DHO CreateStrong{-> Nested}Hit	2020-12-13 13:08:32 +01:00
Bartłomiej Dach	b1635ecd16	Reflect can-be-strong split in DHO structure	2020-12-13 13:08:30 +01:00
Bartłomiej Dach	f74567e8eb	Introduce base class for hitobjects that can be strong	2020-12-13 12:36:39 +01:00
Bartłomiej Dach	1ddc896b76	Rename Strong{-> Nested}HitObject	2020-12-13 12:34:14 +01:00
ekrctb	c70b13ecc2	Adjust namespace	2020-12-07 12:30:25 +09:00
ekrctb	f78bd7c739	Move piece files of Taiko ruleset	2020-12-07 12:29:14 +09:00
smoogipoo	5760e1c1fc	Make HitSampleInfo immutable	2020-12-01 15:37:51 +09:00
smoogipoo	0414e5c550	Add MaximumJudgementOffset to DrawableHitObject, use in more places	2020-11-26 01:12:42 +09:00
Dean Herbert	a3dc1d5730	Update existing implementations	2020-11-04 17:14:23 +09:00
Dean Herbert	cb96a40dd6	Fix bindable propagation potentially making swells strong	2020-10-09 17:12:10 +09:00
Dean Herbert	144726e3c6	Better guard against taiko swells becoming strong	2020-10-09 17:12:01 +09:00
Bartłomiej Dach	1f0620ffd4	Replace assignment references to HitResult.Miss with Judgement.MinResult	2020-10-02 23:31:24 +02:00
Bartłomiej Dach	2b1ef16f89	Replace comparison references to HitResult.Miss with IsHit	2020-10-02 23:31:24 +02:00
smoogipoo	f439c1afbc	Make osu/taiko/catch use Ok+Great	2020-09-29 17:16:55 +09:00
smoogipoo	903bcd747e	Revert unintended changes	2020-09-29 16:39:29 +09:00
smoogipoo	bad48d6d44	Merge branch 'master' into scoring-standardisation	2020-09-29 16:33:38 +09:00
smoogipoo	c45b5690cf	Use new hit results in taiko	2020-09-29 16:33:38 +09:00
Bartłomiej Dach	d61a8327da	Fix rim flying hits changing colour	2020-09-26 20:59:55 +02:00
Dean Herbert	33fad27ec2	Avoid API change to DrawableHitObject	2020-09-24 13:28:29 +09:00
Dean Herbert	156edf24c2	Change properties to methods and improve naming	2020-09-24 13:22:31 +09:00
Dean Herbert	9a0e5ac154	Handle type/strength changes from samples changes	2020-09-23 18:09:40 +09:00
Dean Herbert	8f3eb9a422	Fix taiko sample selection not updating when changing strong/rim type	2020-09-23 17:59:11 +09:00
Dean Herbert	14ad3835ff	Update naming	2020-06-23 21:27:01 +09:00
Dean Herbert	dd7dbfd548	Rename to IHasDuration	2020-05-29 16:45:47 +09:00
Dean Herbert	534dccc0c3	Move sett from EndTime to Duration	2020-05-29 16:45:47 +09:00
Dean Herbert	280b0adb1d	Split out IHasPath from IHasCurve to better define hitobjects	2020-05-29 16:45:47 +09:00
Dean Herbert	a2eec5d963	Fix strong bindable changes for DrumRolls	2020-05-29 16:45:47 +09:00
Dean Herbert	50fcd4149f	Support Strong bindable changes	2020-05-29 16:45:47 +09:00
Dean Herbert	4e9631b546	Support HitType bindable changes	2020-05-29 16:45:47 +09:00
Dean Herbert	3487c1fd1b	Add menus to mark as rim and strong	2020-05-29 16:45:47 +09:00
smoogipoo	bc35bc5efb	Merge branch 'master' into applydefaults-cancellation	2020-05-25 16:45:30 +09:00
Dean Herbert	db4e3047dd	Add test for final sample output	2020-05-19 23:28:13 +09:00
Dean Herbert	013683c23b	Fix taiko rim markers incorrectly playing as whistle samples	2020-05-19 00:17:13 +09:00
smoogipoo	6534510999	Use cancellation token in taiko swell/drumroll	2020-05-15 19:25:14 +09:00
smoogipoo	98125102a7	Add cancellation token support to CreateNestedHitObjects()	2020-05-15 18:07:41 +09:00
Dean Herbert	77041bdbb5	Move implementation to DrawableHit to avoid "breaking" legacy encoding	2020-05-11 16:29:50 +09:00
Dean Herbert	b4d790c076	Fix taiko sample mapping for strong hits	2020-05-11 12:53:54 +09:00
Dean Herbert	52cf1e1859	Fix hit type not being provided and hit time offset not being considered	2020-04-27 16:48:27 +09:00